Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 2c6d06f73319aaff5effca97d8ede1db8a39bf04
commit2c6d06f73319aaff5effca97d8ede1db8a39bf04[log] [tgz]
authorGeorge Burgess IV <gbiv@google.com>Tue Mar 19 17:02:01 2019 -0700
committerTreehugger Robot <treehugger-gerrit@google.com>Wed Mar 20 22:48:31 2019 +0000
treea0175955e8aea03a65fe9e1156554a98314b332b
parent478cec32e71e59b952f9f9f76710346d7feb788c [diff]
Make TypeNamespace::Add take a unique_ptr

After a compiler update, our static analyzer started comaplining about
20(ish) potential leaks. It seems that `Add()` only ever takes ownership
of pointers, so it makes sense for it to take a `unique_ptr<const T>`
instead of a raw `const T*`. This also ensures that this object is freed
appropriately if we had trouble inserting the type.

Static analyzer messages omitted for brevity.

Bug: None
Test: TreeHugger; ran static analyzer

Change-Id: I212c2510708675942302a46a99038851a56aa85d
4 files changed
tree: a0175955e8aea03a65fe9e1156554a98314b332b
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_apicheck.cpp
  8. aidl_apicheck.h
  9. aidl_language.cpp
  10. aidl_language.h
  11. aidl_language_l.ll
  12. aidl_language_y.yy
  13. aidl_to_cpp.cpp
  14. aidl_to_cpp.h
  15. aidl_to_cpp_common.cpp
  16. aidl_to_cpp_common.h
  17. aidl_to_java.cpp
  18. aidl_to_java.h
  19. aidl_to_ndk.cpp
  20. aidl_to_ndk.h
  21. aidl_typenames.cpp
  22. aidl_typenames.h
  23. aidl_unittest.cpp
  24. Android.bp
  25. ast_cpp.cpp
  26. ast_cpp.h
  27. ast_cpp_unittest.cpp
  28. ast_java.cpp
  29. ast_java.h
  30. ast_java_unittest.cpp
  31. code_writer.cpp
  32. code_writer.h
  33. code_writer_unittest.cpp
  34. generate_aidl_mappings.cpp
  35. generate_aidl_mappings.h
  36. generate_cpp.cpp
  37. generate_cpp.h
  38. generate_cpp_unittest.cpp
  39. generate_java.cpp
  40. generate_java.h
  41. generate_java_binder.cpp
  42. generate_ndk.cpp
  43. generate_ndk.h
  44. import_resolver.cpp
  45. import_resolver.h
  46. io_delegate.cpp
  47. io_delegate.h
  48. io_delegate_unittest.cpp
  49. line_reader.cpp
  50. line_reader.h
  51. logging.h
  52. main.cpp
  53. main_cpp.cpp
  54. MODULE_LICENSE_APACHE2
  55. NOTICE
  56. options.cpp
  57. options.h
  58. options_unittest.cpp
  59. os.h
  60. OWNERS
  61. PREUPLOAD.cfg
  62. runtests.sh
  63. TEST_MAPPING
  64. type_cpp.cpp
  65. type_cpp.h
  66. type_cpp_unittest.cpp
  67. type_java.cpp
  68. type_java.h
  69. type_java_unittest.cpp
  70. type_namespace.cpp
  71. type_namespace.h