commit 3557e48f1d2af73210278a2e59f0bacfd09f7b63
author Jooyung Han <jooyung@google.com> Thu Dec 24 05:11:15 2020 +0900
committer Jooyung Han <jooyung@google.com> Tue Dec 29 02:00:43 2020 +0000
tree 89d52a9a3d63a77e6fbc09ff6f42364f3e4260b9
parent 348fcddc12f2b8dca54e7d43a9b9a175b426127d

add -Winout-parameter to avoid inout parameter

This is somewhat confusing for clients because although the parameters
are in, they look like out parameters.

Bug: 168028537
Test: aidl_unittests
Change-Id: I6509c376a9142249e948760fd84dd35897d0136d

aidl_unittest.cpp

diff --git a/aidl_unittest.cpp b/aidl_unittest.cpp
index 2ee75df..36d82c9 100644
--- a/aidl_unittest.cpp
+++ b/aidl_unittest.cpp
@@ -4323,7 +4323,7 @@
                                " -Weverything -o out -h out p/Foo.aidl");
   CaptureStderr();
   EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
-  EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I.\n",
+  EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
             GetCapturedStderr());
 }
 
@@ -4333,17 +4333,7 @@
                                " -Weverything -Werror -o out -h out p/Foo.aidl");
   CaptureStderr();
   EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
-  EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I.\n",
-            GetCapturedStderr());
-}
-
-TEST_P(AidlTest, ErrorEnumZero) {
-  io_delegate_.SetFileContents("p/Foo.aidl", "enum Foo { FOO = 1 }");
-  auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
-                               " -Weverything -Werror -o out -h out p/Foo.aidl");
-  CaptureStderr();
-  EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
-  EXPECT_EQ("ERROR: p/Foo.aidl:1.11-15: The first enumerator 'FOO' should be 0, but it is 1.\n",
+  EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
             GetCapturedStderr());
 }