commit 442cacfc96f69adce7b55bd28cf07a75fbcb4b65
author Jooyung Han <jooyung@google.com> Mon Sep 13 17:44:56 2021 +0900
committer Jooyung Han <jooyung@google.com> Tue Sep 14 10:28:18 2021 +0900
tree 49f9e1fe6ce8f0f06187378386507a67371269c8
parent d9ee6f0ab50e754a6e7dd3e85ba0b2a4528878d3

Fix leak in aidl_unittests

Turning on "sanitizer: address" revealed the leak in the test code.

Bug: n/a
Test: aidl_unittests
Change-Id: Id13820cff676d998934d6b1485d453f37397d696

aidl_language.h

diff --git a/aidl_language.h b/aidl_language.h
index d32ee24..973f20c 100644
--- a/aidl_language.h
+++ b/aidl_language.h
@@ -252,9 +252,9 @@
 
   static std::string TypeToString(Type type);
 
-  static AidlAnnotation* Parse(
+  static std::unique_ptr<AidlAnnotation> Parse(
       const AidlLocation& location, const string& name,
-      std::map<std::string, std::shared_ptr<AidlConstantValue>>* parameter_list,
+      std::map<std::string, std::shared_ptr<AidlConstantValue>> parameter_list,
       const Comments& comments);
 
   AidlAnnotation(const AidlAnnotation&) = default;
@@ -306,7 +306,7 @@
   static const std::vector<Schema>& AllSchemas();
 
   AidlAnnotation(const AidlLocation& location, const Schema& schema,
-                 std::map<std::string, std::shared_ptr<AidlConstantValue>>&& parameters,
+                 std::map<std::string, std::shared_ptr<AidlConstantValue>> parameters,
                  const Comments& comments);
 
   const Schema& schema_;