commit 45db9eec8a0bb71ba1afb5b8c9da72fd0f60028f
author Christopher Wiley <wiley@google.com> Mon Oct 26 18:53:53 2015 -0700
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Oct 27 21:40:34 2015 +0000
tree 970ccebfe1035954bede0e152f4b69a6435d9f0f
parent 1227d6135418a6a876666adcf4f8d9b498f17647

Clean up reporting of bad oneway return/out params

Change the messages on detecting a bad parameter direction from:

  a/IFoo.aidl:1oneway method cannot have out parameters: f

to the more readable:

  a/IBar.aidl:1 oneway method 'f' cannot have out parameters

Bug: None
Test: unit test output is prettier

Change-Id: I1b8da80edf4d04c0fae110c941300afa2080deb7

aidl.cpp

diff --git a/aidl.cpp b/aidl.cpp
index 670e8dc..133fe3d 100644
--- a/aidl.cpp
+++ b/aidl.cpp
@@ -201,8 +201,8 @@
 
     if (oneway && m->GetType().GetName() != "void") {
         cerr << filename << ":" << m->GetLine()
-            << "oneway method cannot return a value: "
-            << m->GetName() << endl;
+            << " oneway method '" << m->GetName() << "' cannot return a value"
+            << endl;
         err = 1;
     }
 
@@ -215,8 +215,8 @@
 
       if (oneway && arg->IsOut()) {
         cerr << filename << ":" << m->GetLine()
-            << "oneway method cannot have out parameters: "
-            << m->GetName() << endl;
+            << " oneway method '" << m->GetName()
+            << "' cannot have out parameters" << endl;
         err = 1;
       }
     }