commit 481f5933b0b075d1cfc9cde2c0dd956256c504ee
author Steven Moreland <smoreland@google.com> Mon Aug 09 17:31:05 2021 -0700
committer Steven Moreland <smoreland@google.com> Mon Aug 09 17:31:05 2021 -0700
tree 785ca147922a4461b5563b5dc8b8d2207efb618d
parent 104ccca35d08aaa1db7a4109f1be2e8f5195f9ff

remove unused Task::UNSPECIFIED

Fixes: 195987773
Test: aidl_unittests
Change-Id: I73ad85484efe311904e11b9ede44b03b7a1854fc

options.cpp

diff --git a/options.cpp b/options.cpp
index b79c4f1..de695dc 100644
--- a/options.cpp
+++ b/options.cpp
@@ -269,33 +269,27 @@
         }
         break;
       case 's':
-        if (task_ != Options::Task::UNSPECIFIED) {
-          task_ = Options::Task::PREPROCESS;
-        }
+        task_ = Options::Task::PREPROCESS;
         break;
 #ifndef _WIN32
       case 'u':
-        if (task_ != Options::Task::UNSPECIFIED) {
-          task_ = Options::Task::DUMP_API;
-        }
+        task_ = Options::Task::DUMP_API;
         break;
       case 'x':
         dump_no_license_ = true;
         break;
       case 'A':
-        if (task_ != Options::Task::UNSPECIFIED) {
-          task_ = Options::Task::CHECK_API;
-          // to ensure that all parcelables in the api dumpes are structured
-          structured_ = true;
-          if (optarg) {
-            if (strcmp(optarg, "compatible") == 0)
-              check_api_level_ = CheckApiLevel::COMPATIBLE;
-            else if (strcmp(optarg, "equal") == 0)
-              check_api_level_ = CheckApiLevel::EQUAL;
-            else {
-              error_message_ << "Unsupported --checkapi level: '" << optarg << "'" << endl;
-              return;
-            }
+        task_ = Options::Task::CHECK_API;
+        // to ensure that all parcelables in the api dumpes are structured
+        structured_ = true;
+        if (optarg) {
+          if (strcmp(optarg, "compatible") == 0)
+            check_api_level_ = CheckApiLevel::COMPATIBLE;
+          else if (strcmp(optarg, "equal") == 0)
+            check_api_level_ = CheckApiLevel::EQUAL;
+          else {
+            error_message_ << "Unsupported --checkapi level: '" << optarg << "'" << endl;
+            return;
           }
         }
         break;

options.h

diff --git a/options.h b/options.h
index 9f645a8..70c82a6 100644
--- a/options.h
+++ b/options.h
@@ -77,7 +77,7 @@
  public:
   enum class Language { UNSPECIFIED, JAVA, CPP, NDK, RUST };
 
-  enum class Task { UNSPECIFIED, HELP, COMPILE, PREPROCESS, DUMP_API, CHECK_API, DUMP_MAPPINGS };
+  enum class Task { HELP, COMPILE, PREPROCESS, DUMP_API, CHECK_API, DUMP_MAPPINGS };
 
   enum class CheckApiLevel { COMPATIBLE, EQUAL };