Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 4dbadf51f66fccf3f22af531202dcee55a96ee51
commit4dbadf51f66fccf3f22af531202dcee55a96ee51[log] [tgz]
authorSteven Moreland <smoreland@google.com>Wed Aug 08 17:46:10 2018 -0700
committerSteven Moreland <smoreland@google.com>Wed Aug 08 18:00:26 2018 -0700
tree4ac8100427546db90467b87b6ee0d7586cc14173
parent5b708384225e4d765474b314963912d2be7ed372 [diff]
Fix segfaults in some error cases.

BEFORE:
$ aidl -h
aidl: option requires an argument -- 'h'
Segmentation fault
$ aidl asdf
terminating with uncaught exception of type std::out_of_range: basic_string
Aborted

NOW:
$ aidl -h
aidl: option requires an argument -- 'h'
usage:
...
$ aidl adsf
Expected .aidl file for input but got 'adsf'

(also, some error checks were missing)

Bug: N/A
Test: runtests.sh
Change-Id: I28584fdf3eb74a64cec260e80fc32f6c9cd99f4e
1 file changed
tree: 4ac8100427546db90467b87b6ee0d7586cc14173
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_language.cpp
  8. aidl_language.h
  9. aidl_language_l.ll
  10. aidl_language_y.yy
  11. aidl_to_java.cpp
  12. aidl_to_java.h
  13. aidl_typenames.cpp
  14. aidl_typenames.h
  15. aidl_unittest.cpp
  16. Android.bp
  17. ast_cpp.cpp
  18. ast_cpp.h
  19. ast_cpp_unittest.cpp
  20. ast_java.cpp
  21. ast_java.h
  22. ast_java_unittest.cpp
  23. code_writer.cpp
  24. code_writer.h
  25. code_writer_unittest.cpp
  26. generate_cpp.cpp
  27. generate_cpp.h
  28. generate_cpp_unittest.cpp
  29. generate_java.cpp
  30. generate_java.h
  31. generate_java_binder.cpp
  32. import_resolver.cpp
  33. import_resolver.h
  34. io_delegate.cpp
  35. io_delegate.h
  36. io_delegate_unittest.cpp
  37. line_reader.cpp
  38. line_reader.h
  39. logging.h
  40. main.cpp
  41. main_cpp.cpp
  42. MODULE_LICENSE_APACHE2
  43. NOTICE
  44. options.cpp
  45. options.h
  46. options_unittest.cpp
  47. os.h
  48. OWNERS
  49. PREUPLOAD.cfg
  50. runtests.sh
  51. type_cpp.cpp
  52. type_cpp.h
  53. type_cpp_unittest.cpp
  54. type_java.cpp
  55. type_java.h
  56. type_java_unittest.cpp
  57. type_namespace.cpp
  58. type_namespace.h