commit 4ff04aa17a60f59a84281f691343aa887ff76a73
author Steven Moreland <smoreland@google.com> Mon Dec 02 10:44:29 2019 -0800
committer Treehugger Robot <treehugger-gerrit@google.com> Mon Dec 02 20:02:02 2019 +0000
tree 00de1ffc501b234b0845ef7afe8a1a0c311b10db
parent 4bcb05c620a59509f6956dd07eecf8b2d8d6c74a

Avoid fatal error on ERROR type.

Should simply return invalid so that user-facing errors are presented as
necessary.

Fixes: 145421785
Test: fuzzer w/ case: enum o{r=""}

Change-Id: I26a0a249dbe6b6bf19a2f729b6adb347b92767a4

aidl_const_expressions.cpp

diff --git a/aidl_const_expressions.cpp b/aidl_const_expressions.cpp
index 64aab78..828e17a 100644
--- a/aidl_const_expressions.cpp
+++ b/aidl_const_expressions.cpp
@@ -467,6 +467,8 @@
     case Type::BINARY:
       is_valid_ = true;
       break;
+    case Type::ERROR:
+      return false;
     default:
       AIDL_FATAL(this) << "Unrecognized constant value type: " << ToString(type_);
       return false;