Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 53fb424e045b274c2798e72a373f6eee5443b136
commit53fb424e045b274c2798e72a373f6eee5443b136[log] [tgz]
authorJooyung Han <jooyung@google.com>Thu Dec 17 16:03:49 2020 +0900
committerTreehugger Robot <treehugger-gerrit@google.com>Tue Dec 22 10:35:23 2020 +0000
treefd4cc6066a64d0b95f5c3bbe22808d24b3b01655
parentb06c563515c0e1fc229a912bb1e0e8bba77614cc [diff]
union requires first member's default value

Default constructor of union type should initialize with the first
member. Java backend was failing with union types when their first member
is of enum type because enum type in Java backend is primitive but with
no default value. (To be specific, the generated default constructor was
trying to init primitive type(enum) with "null").

Now union's first member should have a useful default value.
- set explicit default value (e.g. int a = 3;)
- @nullable annotated.

So, when the first member of a union is an enum, it should have a
default value. Or, it will fail with an error.

Bug: 175834770
Test: aidl_unittests / aidl_integration_test
Change-Id: I6a0acc25331927826a8e747e6ea703f34dccae94
10 files changed
tree: fd4cc6066a64d0b95f5c3bbe22808d24b3b01655
  1. aidl_api/
  2. build/
  3. metadata/
  4. tests/
  5. trace/
  6. .clang-format
  7. aidl.cpp
  8. aidl.h
  9. aidl_checkapi.cpp
  10. aidl_checkapi.h
  11. aidl_const_expressions.cpp
  12. aidl_language.cpp
  13. aidl_language.h
  14. aidl_language_l.ll
  15. aidl_language_y.yy
  16. aidl_to_cpp.cpp
  17. aidl_to_cpp.h
  18. aidl_to_cpp_common.cpp
  19. aidl_to_cpp_common.h
  20. aidl_to_java.cpp
  21. aidl_to_java.h
  22. aidl_to_ndk.cpp
  23. aidl_to_ndk.h
  24. aidl_to_rust.cpp
  25. aidl_to_rust.h
  26. aidl_typenames.cpp
  27. aidl_typenames.h
  28. aidl_unittest.cpp
  29. Android.bp
  30. ast_cpp.cpp
  31. ast_cpp.h
  32. ast_cpp_unittest.cpp
  33. ast_java.cpp
  34. ast_java.h
  35. ast_java_unittest.cpp
  36. code_writer.cpp
  37. code_writer.h
  38. code_writer_unittest.cpp
  39. generate_aidl_mappings.cpp
  40. generate_aidl_mappings.h
  41. generate_cpp.cpp
  42. generate_cpp.h
  43. generate_cpp_unittest.cpp
  44. generate_java.cpp
  45. generate_java.h
  46. generate_java_binder.cpp
  47. generate_ndk.cpp
  48. generate_ndk.h
  49. generate_rust.cpp
  50. generate_rust.h
  51. hiddenapi-greylist
  52. import_resolver.cpp
  53. import_resolver.h
  54. io_delegate.cpp
  55. io_delegate.h
  56. io_delegate_unittest.cpp
  57. line_reader.cpp
  58. line_reader.h
  59. logging.cpp
  60. logging.h
  61. main.cpp
  62. NOTICE
  63. options.cpp
  64. options.h
  65. options_unittest.cpp
  66. os.h
  67. OWNERS
  68. parser.cpp
  69. parser.h
  70. PREUPLOAD.cfg
  71. README.md
  72. run_integration_tests.sh
  73. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview