commit 589cfb0c1244d87682b97c1262718b56c8b5d251
author Jooyung Han <jooyung@google.com> Tue Sep 28 17:26:04 2021 +0900
committer Jooyung Han <jooyung@google.com> Tue Sep 28 23:20:06 2021 +0900
tree e154f70c7529078f231517ff6e1c4084d25f644a
parent cd1609564902ffb70b4216495f2d96dac8bf7a58

Refactor LanguageSpecificCheckValid()

Calls AidlTypeSpecifier::LanguageSpecificCheckValid() from
AidlDefinedType using visitor.

Bug: n/a
Test: aidl_unittests
Change-Id: Idb127d7fa2f091c8979d1c777ca34c3edafcc2c2

aidl_language.h

diff --git a/aidl_language.h b/aidl_language.h
index c2cffd6..284e24f 100644
--- a/aidl_language.h
+++ b/aidl_language.h
@@ -950,8 +950,7 @@
   virtual const AidlInterface* AsInterface() const { return nullptr; }
   virtual const AidlParameterizable<std::string>* AsParameterizable() const { return nullptr; }
   virtual bool CheckValid(const AidlTypenames& typenames) const;
-  virtual bool LanguageSpecificCheckValid(const AidlTypenames& typenames,
-                                          Options::Language lang) const = 0;
+  bool LanguageSpecificCheckValid(const AidlTypenames& typenames, Options::Language lang) const;
   AidlStructuredParcelable* AsStructuredParcelable() {
     return const_cast<AidlStructuredParcelable*>(
         const_cast<const AidlDefinedType*>(this)->AsStructuredParcelable());
@@ -1034,8 +1033,6 @@
   std::string GetCppHeader() const { return cpp_header_; }
 
   bool CheckValid(const AidlTypenames& typenames) const override;
-  bool LanguageSpecificCheckValid(const AidlTypenames& typenames,
-                                  Options::Language lang) const override;
   const AidlParcelable* AsParcelable() const override { return this; }
   const AidlParameterizable<std::string>* AsParameterizable() const override { return this; }
   const AidlNode& AsAidlNode() const override { return *this; }
@@ -1120,10 +1117,6 @@
     return enumerators_;
   }
   bool CheckValid(const AidlTypenames& typenames) const override;
-  bool LanguageSpecificCheckValid(const AidlTypenames& /*typenames*/,
-                                  Options::Language) const override {
-    return true;
-  }
   std::string GetPreprocessDeclarationName() const override { return "enum"; }
 
   const AidlEnumDeclaration* AsEnumDeclaration() const override { return this; }
@@ -1182,9 +1175,6 @@
   std::string GetPreprocessDeclarationName() const override { return "interface"; }
 
   bool CheckValid(const AidlTypenames& typenames) const override;
-  bool LanguageSpecificCheckValid(const AidlTypenames& typenames,
-                                  Options::Language lang) const override;
-
   std::string GetDescriptor() const;
   void DispatchVisit(AidlVisitor& v) const override { v.Visit(*this); }
 };