Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 59e53e49b63d12d8d366e9ad035de9b98b7c7cb4
commit59e53e49b63d12d8d366e9ad035de9b98b7c7cb4[log] [tgz]
authorSteven Moreland <smoreland@google.com>Tue Nov 26 20:38:08 2019 -0800
committerSteven Moreland <smoreland@google.com>Wed Nov 27 16:53:23 2019 +0000
treebbcde34fd1289a6a0e22334aec40bb62fcd4cc5c
parenta923a729a56e4cfafff63afe53ef7946815c3efc [diff]
ShallowIntegralCopy: report user errors w/o crash

Needs to check that ValueString returns non-empty string.
Bug: 145066992
Test: aidl_parser_fuzzer with:
    "enum F{s=2e8,z}"

Needs to consider unsuccessful evaluate as user error not as AIDL_FATAL
(also removed confusing print out of 'type' since in the case where it
fails to evaluate, it may be something like 'binary expression').
Fixes: 145011986
Test: aidl_parser_fuzzer with:
    "enum i{Uecp,a333333=033-3.33333372928 ,ut,}"
ERROR: a/path/Foo.aidl:1.35-38: Failed to parse expression as integer: 033-3.33333372928

Change-Id: If76948afd96e7f975b6f834b59f9e29db7205cd0
4 files changed
tree: bbcde34fd1289a6a0e22334aec40bb62fcd4cc5c
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_apicheck.cpp
  8. aidl_apicheck.h
  9. aidl_const_expressions.cpp
  10. aidl_language.cpp
  11. aidl_language.h
  12. aidl_language_l.ll
  13. aidl_language_y.yy
  14. aidl_to_cpp.cpp
  15. aidl_to_cpp.h
  16. aidl_to_cpp_common.cpp
  17. aidl_to_cpp_common.h
  18. aidl_to_java.cpp
  19. aidl_to_java.h
  20. aidl_to_ndk.cpp
  21. aidl_to_ndk.h
  22. aidl_typenames.cpp
  23. aidl_typenames.h
  24. aidl_unittest.cpp
  25. Android.bp
  26. ast_cpp.cpp
  27. ast_cpp.h
  28. ast_cpp_unittest.cpp
  29. ast_java.cpp
  30. ast_java.h
  31. ast_java_unittest.cpp
  32. code_writer.cpp
  33. code_writer.h
  34. code_writer_unittest.cpp
  35. generate_aidl_mappings.cpp
  36. generate_aidl_mappings.h
  37. generate_cpp.cpp
  38. generate_cpp.h
  39. generate_cpp_unittest.cpp
  40. generate_java.cpp
  41. generate_java.h
  42. generate_java_binder.cpp
  43. generate_ndk.cpp
  44. generate_ndk.h
  45. import_resolver.cpp
  46. import_resolver.h
  47. io_delegate.cpp
  48. io_delegate.h
  49. io_delegate_unittest.cpp
  50. line_reader.cpp
  51. line_reader.h
  52. logging.h
  53. main.cpp
  54. main_cpp.cpp
  55. MODULE_LICENSE_APACHE2
  56. NOTICE
  57. options.cpp
  58. options.h
  59. options_unittest.cpp
  60. os.h
  61. OWNERS
  62. PREUPLOAD.cfg
  63. runtests.sh
  64. runtests_asan.sh
  65. TEST_MAPPING