Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 5c7e77c322f6266fcfb3f5f892c0e104f42240b6
commit5c7e77c322f6266fcfb3f5f892c0e104f42240b6[log] [tgz]
authorJooyung Han <jooyung@google.com>Wed Jan 20 16:00:29 2021 +0900
committerJooyung Han <jooyung@google.com>Thu Jan 21 11:03:42 2021 +0900
treed59fa0afd9b6052c775da173866a54bdeece38cd
parent28328d97be1363b93c750fa1eda9fe6f2cde9758 [diff]
AidlCommentable represents AIDL-commentable entities

Because the parser uses GetComments/SetComments to move comments around, even
syntactically non-commentable nodes can have comments temporarily. Those types'
inheriting AidlCommentable doesn't make sense. We'd like to model classes to
reflect what entities are really commentable in AIDL.

This change pulls up GetComments/SetComments to AidlNode and makes
AidlCommentable a base class for AIDL-commentable nodes. AidlCommentable
provides IsHidden/IsDeprecated/DumpComments.

Now AidlCommentable types are:
  - AidlAnnotatable
    - AidlTypeSpecifier
    - AidlDefinedType
      - AidlInterface
      - AidlParcelable
        - AidlStructuredParacelable
        - AidlUnionDecl
      - AidlEnumDeclaration
  - AidlMember
    - AidlVarialbeDeclaration
    - AidlMethod
    - AidlConstantDeclartion
  - AidlEnumerator
  - AidlDocument

Bug: none
Test: aidl_unittests
Change-Id: Ie4dbd12cdc08e9fafcf59c04da588eae18685727
2 files changed
tree: d59fa0afd9b6052c775da173866a54bdeece38cd
  1. aidl_api/
  2. build/
  3. metadata/
  4. tests/
  5. trace/
  6. .clang-format
  7. aidl-format.sh
  8. aidl.cpp
  9. aidl.h
  10. aidl_checkapi.cpp
  11. aidl_checkapi.h
  12. aidl_const_expressions.cpp
  13. aidl_language.cpp
  14. aidl_language.h
  15. aidl_language_l.ll
  16. aidl_language_y.yy
  17. aidl_to_cpp.cpp
  18. aidl_to_cpp.h
  19. aidl_to_cpp_common.cpp
  20. aidl_to_cpp_common.h
  21. aidl_to_java.cpp
  22. aidl_to_java.h
  23. aidl_to_ndk.cpp
  24. aidl_to_ndk.h
  25. aidl_to_rust.cpp
  26. aidl_to_rust.h
  27. aidl_typenames.cpp
  28. aidl_typenames.h
  29. aidl_unittest.cpp
  30. Android.bp
  31. ast_cpp.cpp
  32. ast_cpp.h
  33. ast_cpp_unittest.cpp
  34. ast_java.cpp
  35. ast_java.h
  36. ast_java_unittest.cpp
  37. code_writer.cpp
  38. code_writer.h
  39. code_writer_unittest.cpp
  40. comments.cpp
  41. comments.h
  42. diagnostics.cpp
  43. diagnostics.h
  44. diagnostics.inc
  45. diagnostics_unittest.cpp
  46. generate_aidl_mappings.cpp
  47. generate_aidl_mappings.h
  48. generate_cpp.cpp
  49. generate_cpp.h
  50. generate_cpp_unittest.cpp
  51. generate_java.cpp
  52. generate_java.h
  53. generate_java_binder.cpp
  54. generate_ndk.cpp
  55. generate_ndk.h
  56. generate_rust.cpp
  57. generate_rust.h
  58. hiddenapi-greylist
  59. import_resolver.cpp
  60. import_resolver.h
  61. io_delegate.cpp
  62. io_delegate.h
  63. io_delegate_unittest.cpp
  64. line_reader.cpp
  65. line_reader.h
  66. location.cpp
  67. location.h
  68. logging.cpp
  69. logging.h
  70. main.cpp
  71. NOTICE
  72. options.cpp
  73. options.h
  74. options_unittest.cpp
  75. os.h
  76. OWNERS
  77. parser.cpp
  78. parser.h
  79. PREUPLOAD.cfg
  80. README.md
  81. run_integration_tests.sh
  82. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview