commit 70df614724ada23b04987fe3e592d2570e45e840
author Jooyung Han <jooyung@google.com> Mon Oct 12 19:23:19 2020 +0900
committer Treehugger Robot <treehugger-gerrit@google.com> Tue Oct 13 03:37:26 2020 +0000
tree 7a2df196f6bf01c4d912378ca435ed87b1a432b8
parent 9bcf80e5d349e88f57d5e441539706a9b16b8880

refactor: remove redundant check

AsParcelable() returns non-null ptr for every AidlParcelable or its
derived classes like AidlStructuredParcelable (and upcoming
AidlUnionDecl).

Bug: n/a
Test: aidl_unittests
Change-Id: If7fdc75dd0c97a1f39e552d0a04e2f7fc71e2c37

aidl_to_java.cpp

diff --git a/aidl_to_java.cpp b/aidl_to_java.cpp
index 9bb9052..658348b 100644
--- a/aidl_to_java.cpp
+++ b/aidl_to_java.cpp
@@ -620,7 +620,7 @@
         c.writer << c.var << " = " << c.type.GetName() << ".Stub.asInterface(" << c.parcel
                  << ".readStrongBinder());\n";
       }
-    } else if (t->AsParcelable() != nullptr || t->AsStructuredParcelable() != nullptr) {
+    } else if (t->AsParcelable() != nullptr) {
       if (c.type.IsArray()) {
         c.writer << c.var << " = " << c.parcel << ".createTypedArray("
                  << JavaNameOf(c.type, c.typenames) << ".CREATOR);\n";