commit 808a2a0d083ce5235cbb484310a06ad33b761e47
author Jooyung Han <jooyung@google.com> Mon Dec 28 16:46:54 2020 +0900
committer Jooyung Han <jooyung@google.com> Tue Dec 29 23:32:12 2020 +0000
tree f5d817e56dc32312c7ade896f65307fbed41e6e7
parent 77ecaa153597a6b1659dd195c3af9d95680edd56

Run diagnostics in a separate visitor

CheckValid() is already quite complicated and adding more to the method
seems not to be scalable.

Bug: 168028537
Test: aidl_unittests
Change-Id: I41a11ce028d8b8f018e80e7203b0d6a955d3768b

aidl_unittest.cpp

diff --git a/aidl_unittest.cpp b/aidl_unittest.cpp
index f985575..e654086 100644
--- a/aidl_unittest.cpp
+++ b/aidl_unittest.cpp
@@ -4325,7 +4325,7 @@
                                " -Weverything -o out -h out p/Foo.aidl");
   CaptureStderr();
   EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
-  EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
+  EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
             GetCapturedStderr());
 }
 
@@ -4335,7 +4335,7 @@
                                " -Weverything -Werror -o out -h out p/Foo.aidl");
   CaptureStderr();
   EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
-  EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
+  EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
             GetCapturedStderr());
 }