commit 808a2a0d083ce5235cbb484310a06ad33b761e47
author Jooyung Han <jooyung@google.com> Mon Dec 28 16:46:54 2020 +0900
committer Jooyung Han <jooyung@google.com> Tue Dec 29 23:32:12 2020 +0000
tree f5d817e56dc32312c7ade896f65307fbed41e6e7
parent 77ecaa153597a6b1659dd195c3af9d95680edd56

Run diagnostics in a separate visitor

CheckValid() is already quite complicated and adding more to the method
seems not to be scalable.

Bug: 168028537
Test: aidl_unittests
Change-Id: I41a11ce028d8b8f018e80e7203b0d6a955d3768b

options_unittest.cpp

diff --git a/options_unittest.cpp b/options_unittest.cpp
index 83ab32a..f573fe6 100644
--- a/options_unittest.cpp
+++ b/options_unittest.cpp
@@ -354,8 +354,8 @@
   };
   auto options = GetOptions(args);
   EXPECT_TRUE(options->Ok());
-  auto warning_options = options->GetWarningOptions();
-  EXPECT_EQ(DiagnosticSeverity::WARNING, warning_options.Severity(DiagnosticID::interface_name));
+  auto mapping = options->GetDiagnosticMapping();
+  EXPECT_EQ(DiagnosticSeverity::WARNING, mapping.Severity(DiagnosticID::interface_name));
 }
 
 TEST(OptionsTests, ParsesWarningEnableSpecificWarning) {
@@ -364,8 +364,8 @@
   };
   auto options = GetOptions(args);
   EXPECT_TRUE(options->Ok());
-  auto warning_options = options->GetWarningOptions();
-  EXPECT_EQ(DiagnosticSeverity::WARNING, warning_options.Severity(DiagnosticID::interface_name));
+  auto mapping = options->GetDiagnosticMapping();
+  EXPECT_EQ(DiagnosticSeverity::WARNING, mapping.Severity(DiagnosticID::interface_name));
 }
 
 TEST(OptionsTests, ParsesWarningDisableSpecificWarning) {
@@ -375,8 +375,8 @@
   };
   auto options = GetOptions(args);
   EXPECT_TRUE(options->Ok());
-  auto warning_options = options->GetWarningOptions();
-  EXPECT_EQ(DiagnosticSeverity::DISABLED, warning_options.Severity(DiagnosticID::interface_name));
+  auto mapping = options->GetDiagnosticMapping();
+  EXPECT_EQ(DiagnosticSeverity::DISABLED, mapping.Severity(DiagnosticID::interface_name));
 }
 
 TEST(OptionsTests, ParsesWarningAsErrors) {
@@ -385,8 +385,8 @@
   };
   auto options = GetOptions(args);
   EXPECT_TRUE(options->Ok());
-  auto warning_options = options->GetWarningOptions();
-  EXPECT_EQ(DiagnosticSeverity::ERROR, warning_options.Severity(DiagnosticID::interface_name));
+  auto mapping = options->GetDiagnosticMapping();
+  EXPECT_EQ(DiagnosticSeverity::ERROR, mapping.Severity(DiagnosticID::interface_name));
 }
 
 TEST(OptionsTests, RejectsUnknownWarning) {