Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 822d0aa0f0984da38b069654c7c825e9d5677616
commit822d0aa0f0984da38b069654c7c825e9d5677616[log] [tgz]
authorJiyong Park <jiyong@google.com>Mon Jul 23 21:45:51 2018 +0900
committerJiyong Park <jiyong@google.com>Wed Jul 25 01:39:39 2018 +0900
tree1d0362005457dc7fb1b35622c353f3dcf414efc8
parentac896042c2a19b3ed482ebe2240a9fbfca01f432 [diff]
Retain imported AidlDocuments even after parsing.

For each import statements, load_and_validate_aidl parses the imported
file. However, the resultant AidlDocument objects have not been returned
to the caller, and thus they are destroyed after the function returns.
This made it impossible to refer to the imported types from
AidlTypenamespace after the parsing, i.e., code generation.

Fix the problem by retaining the AidlDocument objects in the
corresponding AidlImport objects.

Test: m -j
Test: runtests.sh
Change-Id: Ibe51289803e8bae61dd20b7b98ee1606e46b5743
2 files changed
tree: 1d0362005457dc7fb1b35622c353f3dcf414efc8
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_language.cpp
  8. aidl_language.h
  9. aidl_language_l.ll
  10. aidl_language_y.yy
  11. aidl_typenames.cpp
  12. aidl_typenames.h
  13. aidl_unittest.cpp
  14. Android.bp
  15. ast_cpp.cpp
  16. ast_cpp.h
  17. ast_cpp_unittest.cpp
  18. ast_java.cpp
  19. ast_java.h
  20. ast_java_unittest.cpp
  21. code_writer.cpp
  22. code_writer.h
  23. generate_cpp.cpp
  24. generate_cpp.h
  25. generate_cpp_unittest.cpp
  26. generate_java.cpp
  27. generate_java.h
  28. generate_java_binder.cpp
  29. import_resolver.cpp
  30. import_resolver.h
  31. io_delegate.cpp
  32. io_delegate.h
  33. io_delegate_unittest.cpp
  34. line_reader.cpp
  35. line_reader.h
  36. logging.h
  37. main_cpp.cpp
  38. main_java.cpp
  39. MODULE_LICENSE_APACHE2
  40. NOTICE
  41. options.cpp
  42. options.h
  43. options_unittest.cpp
  44. os.h
  45. OWNERS
  46. PREUPLOAD.cfg
  47. runtests.sh
  48. type_cpp.cpp
  49. type_cpp.h
  50. type_cpp_unittest.cpp
  51. type_java.cpp
  52. type_java.h
  53. type_java_unittest.cpp
  54. type_namespace.cpp
  55. type_namespace.h