commit 8f6816ea1fb532cff9ce0ecc1449926553b4e1da
author Christopher Wiley <wiley@google.com> Tue Sep 22 17:03:47 2015 -0700
committer Christopher Wiley <wiley@google.com> Wed Sep 23 15:48:22 2015 -0700
tree 67ab00745513f9e644a3048e75f580866cc596b9
parent 3637a4d41d9dd1669d92127212fb4822a315ab76

Don't allow non-const pointers to Type instances

This makes the namespace into a read only datastructure of types
with a few methods to load types during parsing.

Bug: 24303749
Test: compiles, unittests

Change-Id: I0873e520d771b348a1a8ec9515b6e7b9a8a29298

ast_java.cpp

diff --git a/ast_java.cpp b/ast_java.cpp
index 8a4b64e..b3c3a3f 100644
--- a/ast_java.cpp
+++ b/ast_java.cpp
@@ -93,7 +93,7 @@
 }
 
 void
-Field::GatherTypes(set<Type*>* types) const
+Field::GatherTypes(set<const Type*>* types) const
 {
     types->insert(this->variable->type);
 }
@@ -154,14 +154,14 @@
 {
 }
 
-Variable::Variable(Type* t, const string& n)
+Variable::Variable(const Type* t, const string& n)
     :type(t),
      name(n),
      dimension(0)
 {
 }
 
-Variable::Variable(Type* t, const string& n, int d)
+Variable::Variable(const Type* t, const string& n, int d)
     :type(t),
      name(n),
      dimension(d)
@@ -173,7 +173,7 @@
 }
 
 void
-Variable::GatherTypes(set<Type*>* types) const
+Variable::GatherTypes(set<const Type*>* types) const
 {
     types->insert(this->type);
 }
@@ -202,7 +202,7 @@
 {
 }
 
-FieldVariable::FieldVariable(Type* c, const string& n)
+FieldVariable::FieldVariable(const Type* c, const string& n)
     :object(NULL),
      clazz(c),
      name(n)
@@ -331,7 +331,7 @@
 {
 }
 
-MethodCall::MethodCall(Type* t, const string& n)
+MethodCall::MethodCall(const Type* t, const string& n)
     :obj(NULL),
      clazz(t),
      name(n)
@@ -349,7 +349,7 @@
   va_end(args);
 }
 
-MethodCall::MethodCall(Type* t, const string& n, int argc = 0, ...)
+MethodCall::MethodCall(const Type* t, const string& n, int argc = 0, ...)
     :obj(NULL),
      clazz(t),
      name(n)
@@ -409,12 +409,12 @@
     to->Write(")");
 }
 
-NewExpression::NewExpression(Type* t)
+NewExpression::NewExpression(const Type* t)
     :type(t)
 {
 }
 
-NewExpression::NewExpression(Type* t, int argc = 0, ...)
+NewExpression::NewExpression(const Type* t, int argc = 0, ...)
     :type(t)
 {
   va_list args;
@@ -444,7 +444,7 @@
     to->Write(")");
 }
 
-NewArrayExpression::NewArrayExpression(Type* t, Expression* s)
+NewArrayExpression::NewArrayExpression(const Type* t, Expression* s)
     :type(t),
      size(s)
 {
@@ -498,7 +498,7 @@
 {
 }
 
-Cast::Cast(Type* t, Expression* e)
+Cast::Cast(const Type* t, Expression* e)
     :type(t),
      expression(e)
 {
@@ -516,7 +516,7 @@
     to->Write(")");
 }
 
-VariableDeclaration::VariableDeclaration(Variable* l, Expression* r, Type* c)
+VariableDeclaration::VariableDeclaration(Variable* l, Expression* r, const Type* c)
     :lvalue(l),
      cast(c),
      rvalue(r)
@@ -729,7 +729,7 @@
 }
 
 void
-Method::GatherTypes(set<Type*>* types) const
+Method::GatherTypes(set<const Type*>* types) const
 {
     size_t N, i;
 
@@ -811,7 +811,7 @@
 }
 
 void
-Class::GatherTypes(set<Type*>* types) const
+Class::GatherTypes(set<const Type*>* types) const
 {
     int N, i;