Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 02a11bee998bda59cd420e2c8dd57f3684ee288a
commit02a11bee998bda59cd420e2c8dd57f3684ee288a[log] [tgz]
authorJooyung Han <jooyung@google.com>Thu Feb 11 13:18:06 2021 +0900
committerJooyung Han <jooyung@google.com>Fri Feb 12 22:02:19 2021 +0000
treea73c7ddd01d0d9038cd825828f8e9fe7ca969e23
parent1f56b70282b8e1dc23d9c4f1278b1e8bd219594a [diff]
fix: --checkapi works with enum constants

--checkapi should compare const values with "literal" values, not
with evaluated values because --checkapi task can't resolve imported
types.

--checkapi=equal was relying on "Dump()" which relies on type/value/
resolution.

Now --checkapi=equal dumps const values using literals, not evaluated
values.

Bug: 179950161
Test: m aidl_unittests
Change-Id: I62c84f060036260bfcd9c1020e32715993378e26
3 files changed
tree: a73c7ddd01d0d9038cd825828f8e9fe7ca969e23
  1. aidl_api/
  2. build/
  3. metadata/
  4. tests/
  5. trace/
  6. .clang-format
  7. aidl-format.sh
  8. aidl.cpp
  9. aidl.h
  10. aidl_checkapi.cpp
  11. aidl_checkapi.h
  12. aidl_const_expressions.cpp
  13. aidl_dumpapi.cpp
  14. aidl_dumpapi.h
  15. aidl_language.cpp
  16. aidl_language.h
  17. aidl_language_l.ll
  18. aidl_language_y.yy
  19. aidl_to_cpp.cpp
  20. aidl_to_cpp.h
  21. aidl_to_cpp_common.cpp
  22. aidl_to_cpp_common.h
  23. aidl_to_java.cpp
  24. aidl_to_java.h
  25. aidl_to_ndk.cpp
  26. aidl_to_ndk.h
  27. aidl_to_rust.cpp
  28. aidl_to_rust.h
  29. aidl_typenames.cpp
  30. aidl_typenames.h
  31. aidl_unittest.cpp
  32. Android.bp
  33. ast_cpp.cpp
  34. ast_cpp.h
  35. ast_cpp_unittest.cpp
  36. ast_java.cpp
  37. ast_java.h
  38. ast_java_unittest.cpp
  39. code_writer.cpp
  40. code_writer.h
  41. code_writer_unittest.cpp
  42. comments.cpp
  43. comments.h
  44. diagnostics.cpp
  45. diagnostics.h
  46. diagnostics.inc
  47. diagnostics_unittest.cpp
  48. generate_aidl_mappings.cpp
  49. generate_aidl_mappings.h
  50. generate_cpp.cpp
  51. generate_cpp.h
  52. generate_cpp_unittest.cpp
  53. generate_java.cpp
  54. generate_java.h
  55. generate_java_binder.cpp
  56. generate_ndk.cpp
  57. generate_ndk.h
  58. generate_rust.cpp
  59. generate_rust.h
  60. hiddenapi-greylist
  61. import_resolver.cpp
  62. import_resolver.h
  63. io_delegate.cpp
  64. io_delegate.h
  65. io_delegate_unittest.cpp
  66. line_reader.cpp
  67. line_reader.h
  68. location.cpp
  69. location.h
  70. logging.cpp
  71. logging.h
  72. main.cpp
  73. NOTICE
  74. options.cpp
  75. options.h
  76. options_unittest.cpp
  77. os.h
  78. OWNERS
  79. parser.cpp
  80. parser.h
  81. PREUPLOAD.cfg
  82. README.md
  83. run_integration_tests.sh
  84. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview