Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / adb7467c7d3f24f19a936bf9d8d33603f7937f71
commitadb7467c7d3f24f19a936bf9d8d33603f7937f71[log] [tgz]
authorMathew Inwood <mathewi@google.com>Fri Nov 29 14:01:53 2019 +0000
committersatayev <satayev@google.com>Wed Dec 04 13:03:32 2019 +0000
tree7d81c9109974b78b00938e0de87157dad48822a8
parent5b98eb8c044bbd392817cac209ee7df65fa701ab [diff]
Include source position in generated annotations.

There is a bunch of tooling build on top the annotation index created for
the UnsupportedAppUsage annotations. That index currently points to the
java code generated from AIDL. Including the original source position here
allows the index to point the the original location in AIDL, simplifying
the downstream tooling.

To get the exact source location needed, modify the location generated in
aidl_language.yy to span the whole annotation including the parameters.
The location end now corresponds to the closing parenthesis if there are
any parameters on the annotation.

Bug: 145120552
Test: m
Change-Id: Ie6387394bf6403766000ba0b3654ca47619ab23d
7 files changed
tree: 7d81c9109974b78b00938e0de87157dad48822a8
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_apicheck.cpp
  8. aidl_apicheck.h
  9. aidl_const_expressions.cpp
  10. aidl_language.cpp
  11. aidl_language.h
  12. aidl_language_l.ll
  13. aidl_language_y.yy
  14. aidl_to_cpp.cpp
  15. aidl_to_cpp.h
  16. aidl_to_cpp_common.cpp
  17. aidl_to_cpp_common.h
  18. aidl_to_java.cpp
  19. aidl_to_java.h
  20. aidl_to_ndk.cpp
  21. aidl_to_ndk.h
  22. aidl_typenames.cpp
  23. aidl_typenames.h
  24. aidl_unittest.cpp
  25. Android.bp
  26. ast_cpp.cpp
  27. ast_cpp.h
  28. ast_cpp_unittest.cpp
  29. ast_java.cpp
  30. ast_java.h
  31. ast_java_unittest.cpp
  32. code_writer.cpp
  33. code_writer.h
  34. code_writer_unittest.cpp
  35. generate_aidl_mappings.cpp
  36. generate_aidl_mappings.h
  37. generate_cpp.cpp
  38. generate_cpp.h
  39. generate_cpp_unittest.cpp
  40. generate_java.cpp
  41. generate_java.h
  42. generate_java_binder.cpp
  43. generate_ndk.cpp
  44. generate_ndk.h
  45. import_resolver.cpp
  46. import_resolver.h
  47. io_delegate.cpp
  48. io_delegate.h
  49. io_delegate_unittest.cpp
  50. line_reader.cpp
  51. line_reader.h
  52. logging.h
  53. main.cpp
  54. main_cpp.cpp
  55. MODULE_LICENSE_APACHE2
  56. NOTICE
  57. options.cpp
  58. options.h
  59. options_unittest.cpp
  60. os.h
  61. OWNERS
  62. PREUPLOAD.cfg
  63. runtests.sh
  64. runtests_asan.sh
  65. TEST_MAPPING