Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / b3cd3c7e3a2943740f586575ce095a5af66cb524
commitb3cd3c7e3a2943740f586575ce095a5af66cb524[log] [tgz]
authorSteven Moreland <smoreland@google.com>Thu Oct 11 12:37:45 2018 -0700
committerSteven Moreland <smoreland@google.com>Thu Oct 11 22:02:36 2018 +0000
tree69f7a4b17ab436bd9674d00ce0e8c611382abe95
parent1eac5fa876cd56c24094b89b34ec2da692dc7fce [diff]
Throw earlier error for duplicate argument names.

Right now, these errors don't happen until the output language is
compiled.

...
[ RUN      ] AidlTest.RejectsDuplicatedArgumentNames
ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'
ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'
[       OK ] AidlTest.RejectsDuplicatedArgumentNames (0 ms)
...

Change-Id: Ia49f3c0bd514ac76cccba2a72a820bcb831dd4b2
Fixes: 117241915
Test: runtests.sh
2 files changed
tree: 69f7a4b17ab436bd9674d00ce0e8c611382abe95
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_apicheck.cpp
  8. aidl_apicheck.h
  9. aidl_language.cpp
  10. aidl_language.h
  11. aidl_language_l.ll
  12. aidl_language_y.yy
  13. aidl_to_cpp.cpp
  14. aidl_to_cpp.h
  15. aidl_to_cpp_common.cpp
  16. aidl_to_cpp_common.h
  17. aidl_to_java.cpp
  18. aidl_to_java.h
  19. aidl_to_ndk.cpp
  20. aidl_to_ndk.h
  21. aidl_typenames.cpp
  22. aidl_typenames.h
  23. aidl_unittest.cpp
  24. Android.bp
  25. ast_cpp.cpp
  26. ast_cpp.h
  27. ast_cpp_unittest.cpp
  28. ast_java.cpp
  29. ast_java.h
  30. ast_java_unittest.cpp
  31. code_writer.cpp
  32. code_writer.h
  33. code_writer_unittest.cpp
  34. generate_cpp.cpp
  35. generate_cpp.h
  36. generate_cpp_unittest.cpp
  37. generate_java.cpp
  38. generate_java.h
  39. generate_java_binder.cpp
  40. generate_ndk.cpp
  41. generate_ndk.h
  42. import_resolver.cpp
  43. import_resolver.h
  44. io_delegate.cpp
  45. io_delegate.h
  46. io_delegate_unittest.cpp
  47. line_reader.cpp
  48. line_reader.h
  49. logging.h
  50. main.cpp
  51. main_cpp.cpp
  52. MODULE_LICENSE_APACHE2
  53. NOTICE
  54. options.cpp
  55. options.h
  56. options_unittest.cpp
  57. os.h
  58. OWNERS
  59. PREUPLOAD.cfg
  60. runtests.sh
  61. TEST_MAPPING
  62. type_cpp.cpp
  63. type_cpp.h
  64. type_cpp_unittest.cpp
  65. type_java.cpp
  66. type_java.h
  67. type_java_unittest.cpp
  68. type_namespace.cpp
  69. type_namespace.h