commit b7d5865fef84832508eaa1ab5f73d041d43c1a02
author Steven Moreland <smoreland@google.com> Mon Oct 25 15:10:02 2021 -0700
committer Steven Moreland <smoreland@google.com> Wed Oct 27 16:30:02 2021 +0000
tree e0626c56dd5d6d1772f362eee18e018c7435c71b
parent fc55a53b4d8400c33c2cf0e8f061b1a32e138e3c

Allow for unsigned byte constants (u8)

For int32 constants, we can use something like 0xffffffff in order to
express a 32-bit value. However, byte literals are automatically
converted to 32-bit values. This is consistent with how integral
promotion works in C. However, this can be annoying when trying to
create 8-bit constants. So, the integer literal suffix 'u8' is added in
order to represent byte literals.

Fixes: 203492856
Test: aidl_integration_test, aidl_unittests
Change-Id: Idc9c842306d6410cc979e21b6ad5d3423a87354d

aidl_unittest.cpp

diff --git a/aidl_unittest.cpp b/aidl_unittest.cpp
index 1e6ec6e..fd3c3e3 100644
--- a/aidl_unittest.cpp
+++ b/aidl_unittest.cpp
@@ -1251,7 +1251,7 @@
 TEST_P(AidlTest, FailOnTooBigConstant) {
   AidlError error;
   const string expected_stderr =
-      "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
+      "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte (256)\n";
   CaptureStderr();
   EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
                            R"(package p;
@@ -3829,7 +3829,7 @@
 TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
   AidlError error;
   const string expected_stderr =
-      "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
+      "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int (2147483650)\n";
   CaptureStderr();
   EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
                            R"(package p;
@@ -3845,7 +3845,8 @@
 TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
   AidlError error;
   const string expected_stderr =
-      "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
+      "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int "
+      "(-2147483650)\n";
   CaptureStderr();
   EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
                            R"(package p;
@@ -3893,7 +3894,7 @@
 TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
   AidlError error;
   const string expected_stderr =
-      "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
+      "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte (FOO+1)\n"
       "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
   CaptureStderr();
   EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",