Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / 9d3cbe2954705c3ac1d2f4f0ba389155c271758c
commit9d3cbe2954705c3ac1d2f4f0ba389155c271758c[log] [tgz]
authorJooyung Han <jooyung@google.com>Mon Dec 28 03:02:08 2020 +0900
committerJooyung Han <jooyung@google.com>Tue Jan 05 23:50:57 2021 +0000
treef5bfc41da17fcca715fb104cc54090093984c15d
parentb3cd63f83187dd773a8033d001ea06e975dfc9da [diff]
refactor: remove AidlConstantReference::SetRefType

A constant reference is composed of <type>.<field>. But when <type> is
missing, <field> is looked up from the defining type (the current
scope).

e.g. enum Enum { A = 0, B = A }; // the second "A" refers to "Enum.A"

Previously, when <type> is missing, we create AidlTypeSpecifer for the
current scope type and set it as AidlConstantReference's type.
However, the purpose of AidlTypeSpecifier is to resolve it to a
AidlDefinedType to look up <field> from it.

In the above example, AidlTypeSpecifier("Enum") is created and resolved
to "Enum" type.

Because we already know the scope type, creating AidlTypeSpecifier and
resolve it again is meaningless.

When traversing AST, these manually created nodes should be skipped with
additional flags. (e.g. user_defined_xxx). Let's avoid creating AST
nodes manually.

Bug: none
Test: m aidl_unittests
Change-Id: I3965e571875c6b6a1c7c237f0b4628d362958d46
4 files changed
tree: f5bfc41da17fcca715fb104cc54090093984c15d
  1. aidl_api/
  2. build/
  3. metadata/
  4. tests/
  5. trace/
  6. .clang-format
  7. aidl.cpp
  8. aidl.h
  9. aidl_checkapi.cpp
  10. aidl_checkapi.h
  11. aidl_const_expressions.cpp
  12. aidl_language.cpp
  13. aidl_language.h
  14. aidl_language_l.ll
  15. aidl_language_y.yy
  16. aidl_to_cpp.cpp
  17. aidl_to_cpp.h
  18. aidl_to_cpp_common.cpp
  19. aidl_to_cpp_common.h
  20. aidl_to_java.cpp
  21. aidl_to_java.h
  22. aidl_to_ndk.cpp
  23. aidl_to_ndk.h
  24. aidl_to_rust.cpp
  25. aidl_to_rust.h
  26. aidl_typenames.cpp
  27. aidl_typenames.h
  28. aidl_unittest.cpp
  29. Android.bp
  30. ast_cpp.cpp
  31. ast_cpp.h
  32. ast_cpp_unittest.cpp
  33. ast_java.cpp
  34. ast_java.h
  35. ast_java_unittest.cpp
  36. code_writer.cpp
  37. code_writer.h
  38. code_writer_unittest.cpp
  39. diagnostics.cpp
  40. diagnostics.h
  41. diagnostics.inc
  42. diagnostics_unittest.cpp
  43. generate_aidl_mappings.cpp
  44. generate_aidl_mappings.h
  45. generate_cpp.cpp
  46. generate_cpp.h
  47. generate_cpp_unittest.cpp
  48. generate_java.cpp
  49. generate_java.h
  50. generate_java_binder.cpp
  51. generate_ndk.cpp
  52. generate_ndk.h
  53. generate_rust.cpp
  54. generate_rust.h
  55. hiddenapi-greylist
  56. import_resolver.cpp
  57. import_resolver.h
  58. io_delegate.cpp
  59. io_delegate.h
  60. io_delegate_unittest.cpp
  61. line_reader.cpp
  62. line_reader.h
  63. location.cpp
  64. location.h
  65. logging.cpp
  66. logging.h
  67. main.cpp
  68. NOTICE
  69. options.cpp
  70. options.h
  71. options_unittest.cpp
  72. os.h
  73. OWNERS
  74. parser.cpp
  75. parser.h
  76. PREUPLOAD.cfg
  77. README.md
  78. run_integration_tests.sh
  79. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview