Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / e2de9e4e26f6107f6305e211ba9e0f3cd5f7b699
commite2de9e4e26f6107f6305e211ba9e0f3cd5f7b699[log] [tgz]
authorDevin Moore <devinmoore@google.com>Fri Oct 02 08:55:08 2020 -0700
committerDevin Moore <devinmoore@google.com>Fri Oct 02 19:45:29 2020 +0000
treeea476b5378398608fcb13760766b652ac75fdec4
parent474754d226cc7b04b850c74a7ed1ae323fe66c3f [diff]
Handle constexpr shift left 0 of max bits

__builtin_clz(0) is undefined and was causing a failure to be missed
locally, but it was caught by the fuzzer.
Handle the 0 case by returning the max number of bits in that type.
Make sure left shift exponent doesn't excede the number of bits in the
type when it is 0.

Test: aidl_parser_fuzzer tests/corpus/shift_zero_left_32
Fixes: 169905365
Change-Id: If3f22c423b0b1904be4aa91b178c7a0eb2f0f8ec
2 files changed
tree: ea476b5378398608fcb13760766b652ac75fdec4
  1. aidl_api/
  2. build/
  3. metadata/
  4. tests/
  5. trace/
  6. .clang-format
  7. aidl.cpp
  8. aidl.h
  9. aidl_checkapi.cpp
  10. aidl_checkapi.h
  11. aidl_const_expressions.cpp
  12. aidl_language.cpp
  13. aidl_language.h
  14. aidl_language_l.ll
  15. aidl_language_y.yy
  16. aidl_to_cpp.cpp
  17. aidl_to_cpp.h
  18. aidl_to_cpp_common.cpp
  19. aidl_to_cpp_common.h
  20. aidl_to_java.cpp
  21. aidl_to_java.h
  22. aidl_to_ndk.cpp
  23. aidl_to_ndk.h
  24. aidl_to_rust.cpp
  25. aidl_to_rust.h
  26. aidl_typenames.cpp
  27. aidl_typenames.h
  28. aidl_unittest.cpp
  29. Android.bp
  30. ast_cpp.cpp
  31. ast_cpp.h
  32. ast_cpp_unittest.cpp
  33. ast_java.cpp
  34. ast_java.h
  35. ast_java_unittest.cpp
  36. code_writer.cpp
  37. code_writer.h
  38. code_writer_unittest.cpp
  39. generate_aidl_mappings.cpp
  40. generate_aidl_mappings.h
  41. generate_cpp.cpp
  42. generate_cpp.h
  43. generate_cpp_unittest.cpp
  44. generate_java.cpp
  45. generate_java.h
  46. generate_java_binder.cpp
  47. generate_ndk.cpp
  48. generate_ndk.h
  49. generate_rust.cpp
  50. generate_rust.h
  51. hiddenapi-greylist
  52. import_resolver.cpp
  53. import_resolver.h
  54. io_delegate.cpp
  55. io_delegate.h
  56. io_delegate_unittest.cpp
  57. line_reader.cpp
  58. line_reader.h
  59. logging.cpp
  60. logging.h
  61. main.cpp
  62. NOTICE
  63. options.cpp
  64. options.h
  65. options_unittest.cpp
  66. os.h
  67. OWNERS
  68. parser.cpp
  69. parser.h
  70. PREUPLOAD.cfg
  71. README.md
  72. run_integration_tests.sh
  73. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview