Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / e58e2aec064a5c4f7e6c776597fdbacf79f3281c
commite58e2aec064a5c4f7e6c776597fdbacf79f3281c[log] [tgz]
authorJeongik Cha <jeongik@google.com>Mon May 20 18:45:05 2019 +0900
committerJeongik Cha <jeongik@google.com>Mon May 20 11:44:41 2019 +0000
treee0f25c9f6562bde04ef6bd077470898e27316ab7
parent1844e2f3dc98ec3dc1fa46d4db594865891163e4 [diff]
Fix getInterfaceVersion() inconsistency bug between backends

Java:
- Server
  writeNoException(), and then writeInt(version)
- Client
  As-is: just readInt() -> read exception code, not version
  To-be: readException, and then readInt() -> consume exception code first

Cpp:
- Transaction code
  As-is: getInterface's ID
  To-be: FIRST_CALL_TRANSACTION + the ID
- Server & Client
  As-is: No exception read/write before version code
  To-be: Add exception value before version code

Bug: 133118233
Test: m
Test: atest CtsNdkBinderTestCases
Test: ./runtests.sh
Change-Id: I168a0b8ff7e1871afd95a0ab76b544bfe131a9ed
Merged-In: I168a0b8ff7e1871afd95a0ab76b544bfe131a9ed
6 files changed
tree: e0f25c9f6562bde04ef6bd077470898e27316ab7
  1. build/
  2. docs/
  3. tests/
  4. .clang-format
  5. aidl.cpp
  6. aidl.h
  7. aidl_apicheck.cpp
  8. aidl_apicheck.h
  9. aidl_language.cpp
  10. aidl_language.h
  11. aidl_language_l.ll
  12. aidl_language_y.yy
  13. aidl_to_cpp.cpp
  14. aidl_to_cpp.h
  15. aidl_to_cpp_common.cpp
  16. aidl_to_cpp_common.h
  17. aidl_to_java.cpp
  18. aidl_to_java.h
  19. aidl_to_ndk.cpp
  20. aidl_to_ndk.h
  21. aidl_typenames.cpp
  22. aidl_typenames.h
  23. aidl_unittest.cpp
  24. Android.bp
  25. ast_cpp.cpp
  26. ast_cpp.h
  27. ast_cpp_unittest.cpp
  28. ast_java.cpp
  29. ast_java.h
  30. ast_java_unittest.cpp
  31. code_writer.cpp
  32. code_writer.h
  33. code_writer_unittest.cpp
  34. generate_aidl_mappings.cpp
  35. generate_aidl_mappings.h
  36. generate_cpp.cpp
  37. generate_cpp.h
  38. generate_cpp_unittest.cpp
  39. generate_java.cpp
  40. generate_java.h
  41. generate_java_binder.cpp
  42. generate_ndk.cpp
  43. generate_ndk.h
  44. import_resolver.cpp
  45. import_resolver.h
  46. io_delegate.cpp
  47. io_delegate.h
  48. io_delegate_unittest.cpp
  49. line_reader.cpp
  50. line_reader.h
  51. logging.h
  52. main.cpp
  53. main_cpp.cpp
  54. MODULE_LICENSE_APACHE2
  55. NOTICE
  56. options.cpp
  57. options.h
  58. options_unittest.cpp
  59. os.h
  60. OWNERS
  61. PREUPLOAD.cfg
  62. runtests.sh
  63. TEST_MAPPING
  64. type_cpp.cpp
  65. type_cpp.h
  66. type_cpp_unittest.cpp
  67. type_java.cpp
  68. type_java.h
  69. type_java_unittest.cpp
  70. type_namespace.cpp
  71. type_namespace.h