commit e58e2aec064a5c4f7e6c776597fdbacf79f3281c
author Jeongik Cha <jeongik@google.com> Mon May 20 18:45:05 2019 +0900
committer Jeongik Cha <jeongik@google.com> Mon May 20 11:44:41 2019 +0000
tree e0f25c9f6562bde04ef6bd077470898e27316ab7
parent 1844e2f3dc98ec3dc1fa46d4db594865891163e4

Fix getInterfaceVersion() inconsistency bug between backends

Java:
- Server
  writeNoException(), and then writeInt(version)
- Client
  As-is: just readInt() -> read exception code, not version
  To-be: readException, and then readInt() -> consume exception code first

Cpp:
- Transaction code
  As-is: getInterface's ID
  To-be: FIRST_CALL_TRANSACTION + the ID
- Server & Client
  As-is: No exception read/write before version code
  To-be: Add exception value before version code

Bug: 133118233
Test: m
Test: atest CtsNdkBinderTestCases
Test: ./runtests.sh
Change-Id: I168a0b8ff7e1871afd95a0ab76b544bfe131a9ed
Merged-In: I168a0b8ff7e1871afd95a0ab76b544bfe131a9ed

generate_java_binder.cpp

diff --git a/generate_java_binder.cpp b/generate_java_binder.cpp
index f017d62..8ced119 100644
--- a/generate_java_binder.cpp
+++ b/generate_java_binder.cpp
@@ -828,6 +828,7 @@
            << "      data.writeInterfaceToken(DESCRIPTOR);\n"
            << "      mRemote.transact(Stub." << transactCodeName << ", "
            << "data, reply, 0);\n"
+           << "      reply.readException();\n"
            << "      mCachedVersion = reply.readInt();\n"
            << "    } finally {\n"
            << "      reply.recycle();\n"