Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / aidl / ea2147cec89bf5f617cbc7e1c57e0e0aea3dc653
commitea2147cec89bf5f617cbc7e1c57e0e0aea3dc653[log] [tgz]
authorJooyung Han <jooyung@google.com>Wed Oct 21 18:16:56 2020 +0900
committerJooyung Han <jooyung@google.com>Wed Oct 21 20:52:22 2020 +0900
tree7fb69b245733fdc0d1b00a118ec3877abd6e69da
parent8f02a53bba40de65fa97f618c7aba00473018bd1 [diff]
fix: null-deref if parcelable contains untyped List

untyped List/Map is supported now.

Since untyped List can hold various types of objects including even
SparseArray. So we need to recursively iterate each element to figure
out if it (transitively) contains any file descriptor.

describeContents() calls helper "describeContents(Object)" to reduce
generated code size.

We can't put this helper to Parcelable because generated code needs to
support "sdk" variants as well which are built and run against older
frameworks.

Bug: 171321089
Test: aidl_unittests / aidl_integration_test
Test: m
Change-Id: Id7acd0536afb69d096e2ee9965210b4eb43401e2
2 files changed
tree: 7fb69b245733fdc0d1b00a118ec3877abd6e69da
  1. aidl_api/
  2. build/
  3. metadata/
  4. tests/
  5. trace/
  6. .clang-format
  7. aidl.cpp
  8. aidl.h
  9. aidl_checkapi.cpp
  10. aidl_checkapi.h
  11. aidl_const_expressions.cpp
  12. aidl_language.cpp
  13. aidl_language.h
  14. aidl_language_l.ll
  15. aidl_language_y.yy
  16. aidl_to_cpp.cpp
  17. aidl_to_cpp.h
  18. aidl_to_cpp_common.cpp
  19. aidl_to_cpp_common.h
  20. aidl_to_java.cpp
  21. aidl_to_java.h
  22. aidl_to_ndk.cpp
  23. aidl_to_ndk.h
  24. aidl_to_rust.cpp
  25. aidl_to_rust.h
  26. aidl_typenames.cpp
  27. aidl_typenames.h
  28. aidl_unittest.cpp
  29. Android.bp
  30. ast_cpp.cpp
  31. ast_cpp.h
  32. ast_cpp_unittest.cpp
  33. ast_java.cpp
  34. ast_java.h
  35. ast_java_unittest.cpp
  36. code_writer.cpp
  37. code_writer.h
  38. code_writer_unittest.cpp
  39. generate_aidl_mappings.cpp
  40. generate_aidl_mappings.h
  41. generate_cpp.cpp
  42. generate_cpp.h
  43. generate_cpp_unittest.cpp
  44. generate_java.cpp
  45. generate_java.h
  46. generate_java_binder.cpp
  47. generate_ndk.cpp
  48. generate_ndk.h
  49. generate_rust.cpp
  50. generate_rust.h
  51. hiddenapi-greylist
  52. import_resolver.cpp
  53. import_resolver.h
  54. io_delegate.cpp
  55. io_delegate.h
  56. io_delegate_unittest.cpp
  57. line_reader.cpp
  58. line_reader.h
  59. logging.cpp
  60. logging.h
  61. main.cpp
  62. NOTICE
  63. options.cpp
  64. options.h
  65. options_unittest.cpp
  66. os.h
  67. OWNERS
  68. parser.cpp
  69. parser.h
  70. PREUPLOAD.cfg
  71. README.md
  72. run_integration_tests.sh
  73. TEST_MAPPING
README.md

Documentation for this project is currently maintained here:

https://source.android.com/devices/architecture/aidl/overview