commit f08c15f417c49e4ffb170d6275613aec65a74c1e
author Jooyung Han <jooyung@google.com> Fri Jan 28 14:57:13 2022 +0900
committer Jooyung Han <jooyung@google.com> Wed Feb 02 00:13:17 2022 +0000
tree c1220634ef754c595414ca8a1713c5f81de46761
parent d06ac1913a3a8d16d0829d50d7eabb85b4220227

Lint: Redundant imports

Following the Java language, redundant imports are allowed and just ignored.
But now the linter detects and complains about it as violating "unique-import".

Bug: 215566892
Test: aidl_unittests
Change-Id: Ibe575fa73f8e47c8646f1807f7c9df94f2a9ce7a

aidl_language.h

diff --git a/aidl_language.h b/aidl_language.h
index d19e425..0f4e2d1 100644
--- a/aidl_language.h
+++ b/aidl_language.h
@@ -1202,7 +1202,7 @@
 class AidlDocument : public AidlCommentable, public AidlScope {
  public:
   AidlDocument(const AidlLocation& location, const Comments& comments,
-               std::set<std::string> imports,
+               std::vector<std::string> imports,
                std::vector<std::unique_ptr<AidlDefinedType>> defined_types, bool is_preprocessed);
   ~AidlDocument() = default;
 
@@ -1213,7 +1213,7 @@
   AidlDocument& operator=(AidlDocument&&) = delete;
 
   std::string ResolveName(const std::string& name) const override;
-  const std::set<std::string>& Imports() const { return imports_; }
+  const std::vector<std::string>& Imports() const { return imports_; }
   const std::vector<std::unique_ptr<AidlDefinedType>>& DefinedTypes() const {
     return defined_types_;
   }
@@ -1227,7 +1227,7 @@
   void DispatchVisit(AidlVisitor& v) const override { v.Visit(*this); }
 
  private:
-  const std::set<std::string> imports_;
+  const std::vector<std::string> imports_;
   const std::vector<std::unique_ptr<AidlDefinedType>> defined_types_;
   bool is_preprocessed_;
 };