commit fe89f12d7c0f892d999fb79724a1e033bf075b79
author Jooyung Han <jooyung@google.com> Wed Oct 14 03:49:18 2020 +0900
committer Jooyung Han <jooyung@google.com> Thu Oct 15 13:10:38 2020 +0000
tree 97e2f8185f0a2a21e220c0e1e248a63a95e38541
parent 7e03cda465a045c797583c28f7435d8a8c51033a

union: default constructor inits with first member

CheckValid() checks if union is not-empty.

Bug: 150948558
Test: aidl_unittests / aidl_integration_test
Change-Id: I493b27c84977c3984d599ff7a7a32b0acdd5457f

aidl_language.h

diff --git a/aidl_language.h b/aidl_language.h
index 6a5932d..e8bf546 100644
--- a/aidl_language.h
+++ b/aidl_language.h
@@ -875,10 +875,9 @@
   const std::vector<std::unique_ptr<AidlVariableDeclaration>>& GetFields() const {
     return variables_;
   }
-  bool LanguageSpecificCheckValid(const AidlTypenames& /*typenames*/,
-                                  Options::Language) const override {
-    return true;
-  }
+  bool CheckValid(const AidlTypenames& typenames) const override;
+  bool LanguageSpecificCheckValid(const AidlTypenames& typenames,
+                                  Options::Language lang) const override;
   std::string GetPreprocessDeclarationName() const override { return "union"; }
 
   void Dump(CodeWriter* writer) const override;