blob: 7bf63d9b3449f4010dcc91dcf9c6bc5379b451f9 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900395 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
425 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jooyung Han1cbc4962020-10-25 10:07:15 +0900583TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
584 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
585 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
586 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
Jooyung Han1cbc4962020-10-25 10:07:15 +0900597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
Jooyung Han1cbc4962020-10-25 10:07:15 +0900601TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
602 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
603 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
604 CaptureStderr();
605 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
606 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
607 EXPECT_EQ("", GetCapturedStderr());
608
609 const string expected_to_string_method = R"--(
610 @Override
611 public String toString() {
612 switch (_tag) {
613 case a: return "a.Foo.a(" + (getA()) + ")";
614 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
615 }
616 throw new IllegalStateException("unknown field: " + _tag);
617 }
618)--";
619
620 string java_out;
621 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
622 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
623}
624
Jooyung Han90345002020-10-23 15:28:53 +0900625TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 {
Jooyung Han90345002020-10-23 15:28:53 +0900627 io_delegate_.SetFileContents("a/Foo.aidl",
628 "package a; @JavaDerive(blah=true) parcelable Foo{}");
629 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
630 CaptureStderr();
631 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 const std::string expected_stderr =
633 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
634 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
635 }
636
637 {
638 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900639 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
640 CaptureStderr();
641 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
642 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900643 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000644 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
645 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
647 }
648
649 {
Jooyung Han90345002020-10-23 15:28:53 +0900650 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900651 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
652 CaptureStderr();
653 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
654 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900655 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900656 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
658 }
659}
660
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900661TEST_P(AidlTest, ParseDescriptorAnnotation) {
662 AidlError error;
663 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
664 typenames_, GetLanguage(), &error, {"--structured"});
665 ASSERT_EQ(AidlError::OK, error);
666 ASSERT_NE(nullptr, parse_result);
667 const AidlInterface* interface = parse_result->AsInterface();
668 ASSERT_NE(nullptr, interface);
669 ASSERT_EQ("IBar", interface->GetDescriptor());
670}
671
Jiyong Park40782d02020-07-24 19:17:43 +0900672TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700673 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900675}
676
677TEST_P(AidlTest, AcceptsOnewayInterface) {
678 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700679 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700680}
Christopher Wileyef140932015-11-03 09:29:19 -0800681
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700683 const string oneway_method =
684 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700685 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100686}
687
Steven Moreland65297cc2020-04-20 20:17:36 -0700688TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
689 const string oneway_method =
690 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
691 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
692 ASSERT_NE(nullptr, defined);
693 const AidlInterface* iface = defined->AsInterface();
694 ASSERT_NE(nullptr, iface);
695
696 const auto& methods = iface->GetMethods();
697 ASSERT_EQ(1u, methods.size());
698 const auto& method = methods[0];
699 const AidlTypeSpecifier& ret_type = method->GetType();
700
701 // TODO(b/151102494): these annotations should be on the method
702 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
703 ASSERT_TRUE(ret_type.IsHide());
704}
705
Devin Moore7b8d5c92020-03-17 14:14:08 -0700706TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100707 string foo_interface =
708 "package a; /* foo */ interface IFoo {"
709 " /* i */ int i();"
710 " /* j */ @nullable String j();"
711 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
712
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
715 EXPECT_EQ("/* foo */", parse_result->GetComments());
716
717 const AidlInterface* interface = parse_result->AsInterface();
718 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
719 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
720 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
721}
722
Jooyung Han1a551d32020-10-05 15:37:26 +0900723TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
724 io_delegate_.SetFileContents("p/cpp_header.aidl",
725 R"(package p;
726 parcelable cpp_header cpp_header "bar/header";)");
727 import_paths_.emplace("");
728 const string input_path = "p/IFoo.aidl";
729 const string input = R"(package p;
730 import p.cpp_header;
731 interface IFoo {
732 // get bar
733 cpp_header get();
734 })";
735
736 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
737 EXPECT_NE(nullptr, parse_result);
738 const AidlInterface* interface = parse_result->AsInterface();
739 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
740}
741
Christopher Wileyef140932015-11-03 09:29:19 -0800742TEST_F(AidlTest, ParsesPreprocessedFile) {
743 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
744 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700745 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900746 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700747 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
748 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800749}
750
751TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
752 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
753 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900754
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700755 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900756 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700757 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
758 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800759}
760
Devin Moore7b8d5c92020-03-17 14:14:08 -0700761TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800762 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
763 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
764 "interface IBar {}");
765 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900766 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900767 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700768 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800769 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900770
Christopher Wiley41544372015-11-03 14:52:29 -0800771 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700772 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
773 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800774 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700775 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900776 ambiguous_type.Resolve(typenames_);
777 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800778}
779
Jiyong Park8f6ec462020-01-19 20:52:47 +0900780// Special case of PreferImportToPreprocessed. Imported type should be preferred
781// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700782TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900783 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
784 io_delegate_.SetFileContents("one/IBar.aidl",
785 "package one; "
786 "interface IBar {}");
787 preprocessed_files_.push_back("preprocessed");
788 import_paths_.emplace("");
789 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700790 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900791 EXPECT_NE(nullptr, parse_result);
792
793 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700794 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
795 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900796 // But if we request just "IBar" we should get our imported one.
797 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
798 ambiguous_type.Resolve(typenames_);
799 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
800}
801
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800802TEST_F(AidlTest, WritePreprocessedFile) {
803 io_delegate_.SetFileContents("p/Outer.aidl",
804 "package p; parcelable Outer.Inner;");
805 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
806 "interface IBar {}");
807
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900808 vector<string> args {
809 "aidl",
810 "--preprocess",
811 "preprocessed",
812 "p/Outer.aidl",
813 "one/IBar.aidl"};
814 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800815 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
816
817 string output;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
819 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
820}
821
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900822TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100823 io_delegate_.SetFileContents(
824 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800825 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100826 "parcelable Rect {\n"
827 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800828 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100829 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800830 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100831 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100832 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
833 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100834 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900835 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900836 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100837 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900838
839 vector<string> args{"aidl", "Rect.aidl"};
840 Options options = Options::From(args);
841 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
842
843 string output;
844 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900845 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900846}
847
Devin Moore2f2077a2020-08-28 11:27:53 -0700848TEST_F(AidlTest, CppHeaderIncludes) {
849 io_delegate_.SetFileContents("IFoo.aidl",
850 "interface IFoo {\n"
851 " @nullable List<String> foo();\n"
852 "}");
853
854 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
855 Options options = Options::From(args);
856 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
857 std::vector<std::string> empty;
858 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
859 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
860 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
861
862 // Make sure the optional and String16.h includes are added
863 string output;
864 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
865 EXPECT_EQ(kExpectedCppHeaderOutput, output);
866}
867
Devin Moore7b8d5c92020-03-17 14:14:08 -0700868TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800870 io_delegate_.SetFileContents("p/Outer.aidl",
871 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900872 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700873 CaptureStderr();
874 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
875 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700876 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800878}
879
Devin Moore7b8d5c92020-03-17 14:14:08 -0700880TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800881 io_delegate_.SetFileContents("preprocessed",
882 "parcelable p.Outer.Inner;");
883 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900884 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800886 // TODO(wiley): This should actually return nullptr because we require
887 // the outer class name. However, for legacy reasons,
888 // this behavior must be maintained. b/17415692
889 EXPECT_NE(nullptr, parse_result);
890}
891
Christopher Wiley632801d2015-11-05 14:15:49 -0800892TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700893 const string expected_foo_stderr =
894 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
895 "Declared parcelables should be in their own file and/or cannot be used with --structured "
896 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700897 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
898
Christopher Wiley632801d2015-11-05 14:15:49 -0800899 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700900 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900902 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700903 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900904
Steven Morelande2c64b42018-09-18 15:06:37 -0700905 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900906 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700907 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900908 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700909 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700910
Devin Moore097a3ab2020-03-11 16:08:44 -0700911 const string expected_bar_stderr =
912 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
913 "Declared parcelables should be in their own file and/or cannot be used with --structured "
914 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700915 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
916
Jiyong Parkda8c6932019-08-12 19:56:08 +0900917 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700918 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700919 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900920 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700922 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700923 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700924 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700925 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800926}
927
Devin Moore7b8d5c92020-03-17 14:14:08 -0700928TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700929 const string expected_stderr =
930 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
931 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700932 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
933 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 AidlError error;
935 CaptureStderr();
936 EXPECT_EQ(
937 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700938 Parse("p/IFoo.aidl",
939 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700940 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
942 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700943}
944
Devin Moore7b8d5c92020-03-17 14:14:08 -0700945TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 AidlError error;
947 const string expected_stderr =
948 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
949 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900950 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
951 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700952 interface IFoo {
953 const String DUPLICATED = "d";
954 const int DUPLICATED = 1;
955 }
956 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 EXPECT_EQ(expected_stderr, GetCapturedStderr());
959 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700960}
961
Steven Morelande689da22020-11-10 02:06:30 +0000962TEST_P(AidlTest, FailOnTooBigConstant) {
963 AidlError error;
964 const string expected_stderr =
965 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
966 CaptureStderr();
967 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
968 R"(package p;
969 interface IFoo {
970 const byte type2small = 256;
971 }
972 )",
973 typenames_, GetLanguage(), &error));
974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
975 EXPECT_EQ(AidlError::BAD_TYPE, error);
976}
977
Devin Moore7b8d5c92020-03-17 14:14:08 -0700978TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700979 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700980 const string expected_stderr =
981 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700982 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700983 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
984 R"(package p;
985 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700986 parcelable IBar {}
987 parcelable StructuredParcelable {}
988 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900989 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700992 // Parse success is important for clear error handling even if the cases aren't
993 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700994 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700995}
996
Devin Moore7b8d5c92020-03-17 14:14:08 -0700997TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700998 AidlError error;
999 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1000 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001004}
1005
Steven Morelandf9e922f2020-07-08 21:15:27 +00001006TEST_P(AidlTest, FailOnEmptyListWithComma) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1010 CaptureStderr();
1011 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1012 typenames_, GetLanguage(), &error));
1013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1014 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1015}
1016
Devin Moore7b8d5c92020-03-17 14:14:08 -07001017TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001018 AidlError error;
1019 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001020 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001022 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1023 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001024 interface IFoo {
1025 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1026 }
1027 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001028 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001029 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1030 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001031}
1032
Jiyong Park18132182020-06-08 20:24:40 +09001033TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1034 AidlError error;
1035 const string expected_stderr =
1036 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1037 "cpp_header (which can also be used as an identifier)\n";
1038 CaptureStderr();
1039 // Notice the trailing dot(.) in the name, which isn't a correct name
1040 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1041 GetLanguage(), &error));
1042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1043 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1044}
1045
1046TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1047 AidlError error;
1048 const string expected_stderr =
1049 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1050 "cpp_header (which can also be used as an identifier)\n";
1051 CaptureStderr();
1052 // Notice the trailing dot(.) in the package name
1053 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1054 GetLanguage(), &error));
1055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1056 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1057}
1058
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001061 auto parse_result = Parse("p/IFoo.aidl",
1062 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001063 interface IFoo {
1064 const int POSITIVE_HEX_VALUE = 0xf5;
1065 }
1066 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001067 typenames_, GetLanguage(), &error);
1068 EXPECT_NE(nullptr, parse_result);
1069 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001070 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001071 const auto& cpp_constants = interface->GetConstantDeclarations();
1072 EXPECT_EQ((size_t)1, cpp_constants.size());
1073 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001074 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001075 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001076}
1077
Devin Moore7b8d5c92020-03-17 14:14:08 -07001078TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001079 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080 auto parse_result = Parse("p/IFoo.aidl",
1081 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001082 interface IFoo {
1083 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1084 }
1085 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001086 typenames_, GetLanguage(), &error);
1087 ASSERT_NE(nullptr, parse_result);
1088 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001089 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001090 const auto& cpp_constants = interface->GetConstantDeclarations();
1091 EXPECT_EQ((size_t)1, cpp_constants.size());
1092 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001093 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001094 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001095}
1096
Devin Moore7b8d5c92020-03-17 14:14:08 -07001097TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001098 io_delegate_.SetFileContents(
1099 "p/Outer.aidl",
1100 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001101 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001102 const string input_path = "p/IFoo.aidl";
1103 const string input = "package p; import p.Outer; interface IFoo"
1104 " { Outer.Inner get(); }";
1105
Devin Moore7b8d5c92020-03-17 14:14:08 -07001106 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1107 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001108
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001109 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001110 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001111 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1112 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001113}
1114
Devin Moore7b8d5c92020-03-17 14:14:08 -07001115TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001116 io_delegate_.SetFileContents(
1117 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001118 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001119 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001120 const string input_path = "p/IFoo.aidl";
1121 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1123 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001124 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001125 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1126 native_type.Resolve(typenames_);
1127
1128 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1129 // C++ understands C++ specific stuff
1130 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1131 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001132 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001133 EXPECT_EQ(1u, headers.size());
1134 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001135}
1136
Christopher Wileyf8136192016-04-12 14:19:35 -07001137TEST_F(AidlTest, WritesCorrectDependencyFile) {
1138 // While the in tree build system always gives us an output file name,
1139 // other android tools take advantage of our ability to infer the intended
1140 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001141 vector<string> args = {
1142 "aidl",
1143 "-d dep/file/path",
1144 "-o place/for/output",
1145 "p/IFoo.aidl"};
1146 Options options = Options::From(args);
1147 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001148 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001149 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001150 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001151 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1152}
1153
Dan Willemsen93298ee2016-11-10 23:55:55 -08001154TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1155 // While the in tree build system always gives us an output file name,
1156 // other android tools take advantage of our ability to infer the intended
1157 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001158 vector<string> args = {
1159 "aidl",
1160 "-d dep/file/path",
1161 "--ninja",
1162 "-o place/for/output",
1163 "p/IFoo.aidl"};
1164 Options options = Options::From(args);
1165 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001166 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001167 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001168 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001169 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1170}
1171
Jiyong Parkdf202122019-09-30 20:48:35 +09001172TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001173 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1174 // this by calling aidl with every .aidl file it finds, then parsing the
1175 // generated dependency files. Those that reference .java output files are
1176 // for interfaces and those that do not are parcelables. However, for both
1177 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001178 vector<string> args = {
1179 "aidl",
1180 "-o place/for/output",
1181 "-d dep/file/path",
1182 "p/Foo.aidl"};
1183 Options options = Options::From(args);
1184 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001185 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001186 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001187 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001188 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1189}
1190
1191TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1192 vector<string> args = {
1193 "aidl",
1194 "--structured",
1195 "-o place/for/output",
1196 "-d dep/file/path",
1197 "p/Foo.aidl"};
1198 Options options = Options::From(args);
1199 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1200 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1201 string actual_dep_file_contents;
1202 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1203 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001204}
1205
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001206TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1207 vector<string> args = {
1208 "aidl",
1209 "--lang=java",
1210 "-o place/for/output",
1211 "p/Foo.aidl"};
1212 Options options = Options::From(args);
1213 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1214 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1215 string output_file_contents;
1216 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1217}
1218
Jeongik Cha08ca2182019-11-21 14:01:13 +09001219// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001220TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001221 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001222 "package a; interface IFoo {\n"
1223 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001224 string expected_stderr;
1225 switch (GetLanguage()) {
1226 case Options::Language::CPP:
1227 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001228 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1230 "String and IBinder.\n";
1231 break;
1232 case Options::Language::JAVA:
1233 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001234 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001235 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1236 "String, IBinder, and ParcelFileDescriptor.\n";
1237 break;
1238 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001239 case Options::Language::RUST:
1240 expected_stderr =
1241 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1242 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001243 default:
1244 AIDL_FATAL(AIDL_LOCATION_HERE)
1245 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1246 }
1247 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001248 AidlTypenames tn1;
1249 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001251
1252 string primitive_parcelable =
1253 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001254 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001255 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001256 AidlTypenames tn2;
1257 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001258 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001259}
1260
Devin Moore21b26772020-08-26 16:37:56 -07001261TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001262 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001263 const string list_array_parcelable =
1264 "package a; parcelable Foo {\n"
1265 " List[] lists; }";
1266 CaptureStderr();
1267 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1268 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1269}
1270
Jiyong Parkf8d53612020-05-04 14:06:13 +09001271TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1272 AidlError error;
1273 string expected_stderr =
1274 "ERROR: a/IFoo.aidl:2.7-11: "
1275 "Encountered an untyped List or Map. The use of untyped List/Map is "
1276 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1277 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1278 if (GetLanguage() != Options::Language::JAVA) {
1279 expected_stderr =
1280 "ERROR: a/IFoo.aidl:2.1-7: "
1281 "Currently, only the Java backend supports non-generic List.\n";
1282 }
1283
1284 const string primitive_interface =
1285 "package a; interface IFoo {\n"
1286 " List foo(); }";
1287 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001288 AidlTypenames tn1;
1289 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001290 {"--structured"}));
1291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001292
1293 string primitive_parcelable =
1294 "package a; parcelable IFoo {\n"
1295 " List foo;}";
1296 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001297 AidlTypenames tn2;
1298 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001299 {"--structured"}));
1300 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1301}
1302
Jeongik Cha225519b2020-08-29 01:55:32 +09001303TEST_P(AidlTest, ExtensionTest) {
1304 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001305 string extendable_parcelable =
1306 "package a; parcelable Data {\n"
1307 " ParcelableHolder extension;\n"
1308 " ParcelableHolder extension2;\n"
1309 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001310 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001311 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1312 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001313 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001314 "yet.\n",
1315 GetCapturedStderr());
1316 } else {
1317 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1318 EXPECT_EQ("", GetCapturedStderr());
1319 }
1320}
1321TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1322 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001323 string parcelableholder_return_interface =
1324 "package a; interface IFoo {\n"
1325 " ParcelableHolder foo();\n"
1326 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001327 EXPECT_EQ(nullptr,
1328 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001329
Jeongik Cha8f02a532020-10-14 00:16:28 +09001330 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001332 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001333 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001334 "yet.\n",
1335 GetCapturedStderr());
1336 return;
1337 }
1338 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1339 GetCapturedStderr());
1340}
1341
1342TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1343 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001344 string extendable_parcelable_arg_interface =
1345 "package a; interface IFoo {\n"
1346 " void foo(in ParcelableHolder ph);\n"
1347 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001348 EXPECT_EQ(nullptr,
1349 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1350
Jeongik Cha8f02a532020-10-14 00:16:28 +09001351 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001352 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001353 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001354 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001355 "yet.\n",
1356 GetCapturedStderr());
1357 return;
1358 }
1359 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1360 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001361}
1362
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001363TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1364 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1365 Options options =
1366 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1367 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1368 CaptureStderr();
1369 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1370 if (GetLanguage() == Options::Language::RUST) {
1371 EXPECT_EQ(
1372 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1373 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1374 "yet.\n",
1375 GetCapturedStderr());
1376 return;
1377 }
1378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1379}
1380
Jiyong Park02da7422018-07-16 16:00:26 +09001381TEST_F(AidlTest, ApiDump) {
1382 io_delegate_.SetFileContents(
1383 "foo/bar/IFoo.aidl",
1384 "package foo.bar;\n"
1385 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001386 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001387 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001388 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001389 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1390 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1391 " IFoo foo3(IFoo foo);\n"
1392 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001393 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001394 " const int A = 1;\n"
1395 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001396 "}\n");
1397 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1398 "package foo.bar;\n"
1399 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001400 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001401 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001402 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001403 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001404 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001405 " int y;\n"
1406 " IFoo foo;\n"
1407 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001408 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001409 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001410 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001411 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001412 "}\n");
1413 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001414 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1415 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001416 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001417 bool result = dump_api(options, io_delegate_);
1418 ASSERT_TRUE(result);
1419 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001420 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001421 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001422/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001423interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001424 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001425 int foo(out int[] a, String b, boolean c, inout List<String> d);
1426 int foo2(@utf8InCpp String x, inout List<String> y);
1427 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1428 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001429 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001430 const int A = 1;
1431 const String STR = "Hello";
1432}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001433)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001434
Jiyong Parke59c3682018-09-11 23:10:25 +09001435 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001436 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001437/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001438parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001439 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001440 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001441 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001442 int y;
1443 foo.bar.IFoo foo;
1444 List<foo.bar.IFoo> a;
1445 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001446 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001447 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001448}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001449)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001450}
1451
Jiyong Parked65bf42018-08-28 15:43:27 +09001452TEST_F(AidlTest, ApiDumpWithManualIds) {
1453 io_delegate_.SetFileContents(
1454 "foo/bar/IFoo.aidl",
1455 "package foo.bar;\n"
1456 "interface IFoo {\n"
1457 " int foo() = 1;\n"
1458 " int bar() = 2;\n"
1459 " int baz() = 10;\n"
1460 "}\n");
1461
Jiyong Parke59c3682018-09-11 23:10:25 +09001462 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001463 Options options = Options::From(args);
1464 bool result = dump_api(options, io_delegate_);
1465 ASSERT_TRUE(result);
1466 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001467 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001468 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001469interface IFoo {
1470 int foo() = 1;
1471 int bar() = 2;
1472 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001473}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001474)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001475}
1476
1477TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001478 const string expected_stderr =
1479 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1480 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001481 io_delegate_.SetFileContents(
1482 "foo/bar/IFoo.aidl",
1483 "package foo.bar;\n"
1484 "interface IFoo {\n"
1485 " int foo() = 1;\n"
1486 " int bar();\n"
1487 " int baz() = 10;\n"
1488 "}\n");
1489
Jiyong Parke59c3682018-09-11 23:10:25 +09001490 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001491 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001492 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001493 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001494 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001495}
1496
Jooyung Han965e31d2020-11-27 12:30:16 +09001497TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1498 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1499 "package foo.bar;\n"
1500 "interface IFoo {\n"
1501 " @utf8InCpp String foo();\n"
1502 " const @utf8InCpp String bar = \"bar\";\n"
1503 "}\n");
1504
1505 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1506 Options options = Options::From(args);
1507 CaptureStderr();
1508 EXPECT_TRUE(dump_api(options, io_delegate_));
1509 EXPECT_EQ("", GetCapturedStderr());
1510 string actual;
1511 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001512 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1513interface IFoo {
1514 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001515 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001516}
1517)"),
1518 actual);
1519}
1520
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001521TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001522 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001523 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1524 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001525 const string expected_map_stderr =
1526 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001527 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1528 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001529 "package p; interface IFoo {"
1530 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001531 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001532 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001533 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001534
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001535 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001536 "package p; interface IFoo {"
1537 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001538 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001539 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001541}
1542
Jeongik Chae48d9942020-01-02 17:39:00 +09001543TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001544 const string expected_stderr =
1545 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001546 Options options = Options::From("aidl -I p p/IFoo.aidl");
1547 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1548
1549 io_delegate_.SetFileContents("p/IFoo.aidl",
1550 "package p; interface IFoo {"
1551 "Map<String, Bar> foo();}");
1552 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1553
1554 io_delegate_.SetFileContents("p/IFoo.aidl",
1555 "package p; interface IFoo {"
1556 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001557 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001558 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001559 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001560
1561 io_delegate_.SetFileContents("p/IFoo.aidl",
1562 "package p; interface IFoo {"
1563 "Map<String, String> foo();}");
1564 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1565
1566 io_delegate_.SetFileContents("p/IFoo.aidl",
1567 "package p; interface IFoo {"
1568 "Map<String, ParcelFileDescriptor> foo();}");
1569 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1570}
1571
Jeongik Chadf76dc72019-11-28 00:08:47 +09001572TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001573 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001574 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1575 io_delegate_.SetFileContents(options.InputFiles().front(),
1576 "package p; interface IFoo {"
1577 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001578 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001579 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001581}
1582
1583TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1584 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1585 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001586 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001587 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001588 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1589 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001590
1591 Options options = Options::From("aidl -I p p/IFoo.aidl");
1592 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1593 io_delegate_.SetFileContents("p/IFoo.aidl",
1594 "package p; interface IFoo {"
1595 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001596 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001597 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001598 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001599 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001600 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001601 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001602 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1603 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001604 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1605 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1606 io_delegate_.SetFileContents("p/IFoo.aidl",
1607 "package p; interface IFoo {"
1608 "Bar<String, ParcelFileDescriptor> foo();}");
1609 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001610
1611 io_delegate_.SetFileContents("p/IFoo.aidl",
1612 "package p; interface IFoo {"
1613 "Bar<int, long> foo();}");
1614
1615 io_delegate_.SetFileContents("p/IFoo.aidl",
1616 "package p; interface IFoo {"
1617 "Bar<int[], long[]> foo();}");
1618
1619 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001620}
1621
Jeongik Cha0e426012019-07-29 15:57:02 +09001622TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1623 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001624 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1625 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001626 for (const auto& rawOption : rawOptions) {
1627 string expected_stderr =
1628 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001629 Options options = Options::From(rawOption);
1630 io_delegate_.SetFileContents(options.InputFiles().front(),
1631 "package foo.bar;\n"
1632 "interface IFoo1 { int foo(); }\n"
1633 "interface IFoo2 { int foo(); }\n"
1634 "parcelable Data1 { int a; int b;}\n"
1635 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001637 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001639
Jeongik Cha0e426012019-07-29 15:57:02 +09001640 io_delegate_.SetFileContents(options.InputFiles().front(),
1641 "package foo.bar;\n"
1642 "interface IFoo1 { int foo(); }\n"
1643 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001644 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001645 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001647
Devin Moore5de18ed2020-04-02 13:52:29 -07001648 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001649 io_delegate_.SetFileContents(options.InputFiles().front(),
1650 "package foo.bar;\n"
1651 "parcelable Data1 { int a; int b;}\n"
1652 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001653 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001654 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001656 }
1657}
1658
Devin Moorebdba2a82020-03-31 15:19:02 -07001659TEST_P(AidlTest, FailParseOnEmptyFile) {
1660 const string contents = "";
1661 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1662 CaptureStderr();
1663 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1664 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1665}
1666
Jiyong Parkb034bf02018-07-30 17:44:33 +09001667TEST_F(AidlTest, MultipleInputFiles) {
1668 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001669 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001670
1671 io_delegate_.SetFileContents(options.InputFiles().at(0),
1672 "package foo.bar;\n"
1673 "import foo.bar.Data;\n"
1674 "interface IFoo { Data getData(); }\n");
1675
1676 io_delegate_.SetFileContents(options.InputFiles().at(1),
1677 "package foo.bar;\n"
1678 "import foo.bar.IFoo;\n"
1679 "parcelable Data { IFoo foo; }\n");
1680
1681 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1682
1683 string content;
1684 for (const auto file : {
1685 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1686 content.clear();
1687 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1688 EXPECT_FALSE(content.empty());
1689 }
1690}
1691
1692TEST_F(AidlTest, MultipleInputFilesCpp) {
1693 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001694 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001695
1696 io_delegate_.SetFileContents(options.InputFiles().at(0),
1697 "package foo.bar;\n"
1698 "import foo.bar.Data;\n"
1699 "interface IFoo { Data getData(); }\n");
1700
1701 io_delegate_.SetFileContents(options.InputFiles().at(1),
1702 "package foo.bar;\n"
1703 "import foo.bar.IFoo;\n"
1704 "parcelable Data { IFoo foo; }\n");
1705
1706 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1707
1708 string content;
1709 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001710 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001711 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1712 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1713 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1714 content.clear();
1715 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1716 EXPECT_FALSE(content.empty());
1717 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001718}
1719
Andrei Homescub62afd92020-05-11 19:24:59 -07001720TEST_F(AidlTest, MultipleInputFilesRust) {
1721 Options options =
1722 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1723
1724 io_delegate_.SetFileContents(options.InputFiles().at(0),
1725 "package foo.bar;\n"
1726 "import foo.bar.Data;\n"
1727 "interface IFoo { Data getData(); }\n");
1728
1729 io_delegate_.SetFileContents(options.InputFiles().at(1),
1730 "package foo.bar;\n"
1731 "import foo.bar.IFoo;\n"
1732 "parcelable Data { IFoo foo; }\n");
1733
1734 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1735
1736 string content;
1737 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1738 content.clear();
1739 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1740 EXPECT_FALSE(content.empty());
1741 }
1742}
1743
Devin Moore097a3ab2020-03-11 16:08:44 -07001744TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1745 const string expected_stderr =
1746 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001747 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1748 // int getInterfaceVersion() is one of the meta transactions
1749 io_delegate_.SetFileContents(options.InputFiles().front(),
1750 "package p; interface IFoo {"
1751 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001752 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001753 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001754 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1755}
Jiyong Park309668e2018-07-28 16:55:44 +09001756
Devin Moore097a3ab2020-03-11 16:08:44 -07001757TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1758 // boolean getInterfaceVersion() is not a meta transaction, but should be
1759 // prevented because return type is not part of a method signature
1760 const string expected_stderr =
1761 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1762 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001763 io_delegate_.SetFileContents(options.InputFiles().front(),
1764 "package p; interface IFoo {"
1765 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001766 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001767 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001768 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1769}
Jiyong Park309668e2018-07-28 16:55:44 +09001770
Devin Moore097a3ab2020-03-11 16:08:44 -07001771TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001772 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001773 const string expected_stderr =
1774 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1775 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001776 io_delegate_.SetFileContents(options.InputFiles().front(),
1777 "package p; interface IFoo {"
1778 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001779 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001780 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001781 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001782
1783 // this is not a meta interface method as it differs type arguments
1784 io_delegate_.SetFileContents(options.InputFiles().front(),
1785 "package p; interface IFoo {"
1786 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001787 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001788}
1789
Daniel Norman85aed542019-08-21 12:01:14 -07001790TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001791 Options options = Options::From("aidl --checkapi old new");
1792 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1793 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1794 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1795 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1796
1797 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1798}
1799
Jiyong Park3656c3c2018-08-01 20:02:01 +09001800TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001801 Options options = Options::From("aidl --checkapi old new");
1802 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1803 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001804
1805 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1806}
1807
Daniel Norman85aed542019-08-21 12:01:14 -07001808class AidlTestCompatibleChanges : public AidlTest {
1809 protected:
1810 Options options_ = Options::From("aidl --checkapi old new");
1811};
1812
1813TEST_F(AidlTestCompatibleChanges, NewType) {
1814 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1815 "package p;"
1816 "interface IFoo {"
1817 " void foo(int a);"
1818 "}");
1819 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1820 "package p;"
1821 "interface IFoo {"
1822 " void foo(int a);"
1823 "}");
1824 io_delegate_.SetFileContents("new/p/IBar.aidl",
1825 "package p;"
1826 "interface IBar {"
1827 " void bar();"
1828 "}");
1829 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1830}
1831
1832TEST_F(AidlTestCompatibleChanges, NewMethod) {
1833 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1834 "package p;"
1835 "interface IFoo {"
1836 " void foo(int a);"
1837 "}");
1838 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1839 "package p;"
1840 "interface IFoo {"
1841 " void foo(int a);"
1842 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001843 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001844 "}");
1845 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1846}
1847
1848TEST_F(AidlTestCompatibleChanges, NewField) {
1849 io_delegate_.SetFileContents("old/p/Data.aidl",
1850 "package p;"
1851 "parcelable Data {"
1852 " int foo;"
1853 "}");
1854 io_delegate_.SetFileContents("new/p/Data.aidl",
1855 "package p;"
1856 "parcelable Data {"
1857 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001858 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001859 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001860 "}");
1861 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1862}
1863
1864TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1865 io_delegate_.SetFileContents("old/p/Enum.aidl",
1866 "package p;"
1867 "enum Enum {"
1868 " FOO = 1,"
1869 "}");
1870 io_delegate_.SetFileContents("new/p/Enum.aidl",
1871 "package p;"
1872 "enum Enum {"
1873 " FOO = 1,"
1874 " BAR = 2,"
1875 "}");
1876 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1877}
1878
1879TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1880 io_delegate_.SetFileContents("old/p/Enum.aidl",
1881 "package p;"
1882 "enum Enum {"
1883 " FOO = 1,"
1884 " BAR = 2,"
1885 "}");
1886 io_delegate_.SetFileContents("new/p/Enum.aidl",
1887 "package p;"
1888 "enum Enum {"
1889 " BAR = 2,"
1890 " FOO = 1,"
1891 "}");
1892 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1893}
1894
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001895TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1896 io_delegate_.SetFileContents("old/p/Union.aidl",
1897 "package p;"
1898 "union Union {"
1899 " String foo;"
1900 "}");
1901 io_delegate_.SetFileContents("new/p/Union.aidl",
1902 "package p;"
1903 "union Union {"
1904 " String foo;"
1905 " int num;"
1906 "}");
1907 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1908}
1909
Daniel Norman85aed542019-08-21 12:01:14 -07001910TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001911 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1912 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001913 "interface IFoo {"
1914 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001915 "}");
1916 io_delegate_.SetFileContents("old/p/Data.aidl",
1917 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001918 "parcelable Data {"
1919 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001920 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001921 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1922 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001923 "interface IFoo {"
1924 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001925 "}");
1926 io_delegate_.SetFileContents("new/p/Data.aidl",
1927 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001928 "parcelable Data {"
1929 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001930 "}");
1931 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1932 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001933 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001934 " void foo(int a);"
1935 "}");
1936 io_delegate_.SetFileContents("new/q/Data.aidl",
1937 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001938 "parcelable Data {"
1939 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001940 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001941 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1942}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001943
Daniel Norman85aed542019-08-21 12:01:14 -07001944TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1945 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1946 "package p;"
1947 "interface IFoo {"
1948 " void foo(int a);"
1949 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001950 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1951 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001952 "interface IFoo {"
1953 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001954 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001955 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1956}
Jiyong Parke59c3682018-09-11 23:10:25 +09001957
Daniel Norman85aed542019-08-21 12:01:14 -07001958TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001959 io_delegate_.SetFileContents("old/p/I.aidl",
1960 "package p; interface I {"
1961 "const int A = 1; }");
1962 io_delegate_.SetFileContents("new/p/I.aidl",
1963 "package p ; interface I {"
1964 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001965 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1966}
Jiyong Parka428d212018-08-29 22:26:30 +09001967
Daniel Norman85aed542019-08-21 12:01:14 -07001968TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001969 io_delegate_.SetFileContents("old/p/I.aidl",
1970 "package p; interface I {"
1971 "const int A = 1; const int B = 2;}");
1972 io_delegate_.SetFileContents("new/p/I.aidl",
1973 "package p ; interface I {"
1974 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001975 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001976}
1977
Jooyung Han69ea4ba2020-10-29 15:33:37 +09001978TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
1979 io_delegate_.SetFileContents("old/p/Foo.aidl",
1980 "package p;"
1981 "@JavaPassthrough(annotation=\"Alice\")"
1982 "@JavaPassthrough(annotation=\"Bob\")"
1983 "parcelable Foo {}");
1984 io_delegate_.SetFileContents("new/p/Foo.aidl",
1985 "package p;"
1986 "@JavaPassthrough(annotation=\"Bob\")"
1987 "@JavaPassthrough(annotation=\"Alice\")"
1988 "parcelable Foo {}");
1989 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1990}
1991
Jooyung Han00073272020-11-27 14:20:20 +09001992TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
1993 io_delegate_.SetFileContents("old/p/Foo.aidl",
1994 "package p;"
1995 "parcelable Foo {}");
1996 io_delegate_.SetFileContents("new/p/Foo.aidl",
1997 "package p;"
1998 "@JavaPassthrough(annotation=\"@Deprecated\")"
1999 "parcelable Foo {}");
2000 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2001}
2002
Jooyung Han636fd2f2020-10-22 11:33:45 +09002003TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2004 io_delegate_.SetFileContents("old/p/Data.aidl",
2005 "package p;"
2006 "parcelable Data {"
2007 " int num;"
2008 "}");
2009 io_delegate_.SetFileContents(
2010 "new/p/Data.aidl",
2011 "package p;"
2012 "parcelable Data {"
2013 " int num;"
2014 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2015 "}");
2016 io_delegate_.SetFileContents("new/p/Enum.aidl",
2017 "package p;"
2018 "enum Enum {"
2019 " FOO = 0,"
2020 " BAR = 1,"
2021 "}");
2022 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2023}
2024
Daniel Norman85aed542019-08-21 12:01:14 -07002025class AidlTestIncompatibleChanges : public AidlTest {
2026 protected:
2027 Options options_ = Options::From("aidl --checkapi old new");
2028};
2029
2030TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002031 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002032 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2033 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002034 "interface IFoo {"
2035 " void foo(in String[] str);"
2036 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002037 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002038 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002039 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002040 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002041}
2042
2043TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002044 const string expected_stderr =
2045 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002046 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2047 "package p;"
2048 "interface IFoo {"
2049 " void foo(in String[] str);"
2050 " void bar(@utf8InCpp String str);"
2051 "}");
2052 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2053 "package p;"
2054 "interface IFoo {"
2055 " void foo(in String[] str);"
2056 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002057 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002058 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002059 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002060}
2061
Jiyong Parkf8d53612020-05-04 14:06:13 +09002062TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2063 const string expected_stderr =
2064 "ERROR: new/p/IFoo.aidl:1.61-65: "
2065 "Encountered an untyped List or Map. The use of untyped List/Map is "
2066 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2067 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2068 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2069 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2070 "package p;"
2071 "interface IFoo {"
2072 " void foo(in String[] str);"
2073 "}");
2074 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2075 "package p;"
2076 "interface IFoo {"
2077 " void foo(in String[] str);"
2078 " void bar(in List arg);"
2079 "}");
2080 CaptureStderr();
2081 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2082 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2083}
2084
2085TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2086 const string expected_stderr =
2087 "ERROR: new/p/Data.aidl:1.54-59: "
2088 "Encountered an untyped List or Map. The use of untyped List/Map is "
2089 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2090 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2091 "ERROR: new/p/Data.aidl: Failed to read.\n";
2092 io_delegate_.SetFileContents("old/p/Data.aidl",
2093 "package p;"
2094 "parcelable Data {"
2095 " int foo;"
2096 "}");
2097 io_delegate_.SetFileContents("new/p/Data.aidl",
2098 "package p;"
2099 "parcelable Data {"
2100 " int foo;"
2101 " @nullable List list;"
2102 "}");
2103 CaptureStderr();
2104 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2106}
2107
Daniel Norman85aed542019-08-21 12:01:14 -07002108TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002109 const string expected_stderr =
2110 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002111 io_delegate_.SetFileContents("old/p/Data.aidl",
2112 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002113 "parcelable Data {"
2114 " int foo;"
2115 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002116 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002117 io_delegate_.SetFileContents("new/p/Data.aidl",
2118 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002119 "parcelable Data {"
2120 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002121 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002122 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002123 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002124 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002125}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002126
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002127TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2128 const string expected_stderr =
2129 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2130 "backends. Please either provide a default value for this field or mark the field as "
2131 "@nullable. This value or a null value will be used automatically when an old version of "
2132 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2133 "order to make sure your code continues to be backwards compatible, make sure the default or "
2134 "null value does not cause a semantic change to this parcelable.\n";
2135 io_delegate_.SetFileContents("old/p/Data.aidl",
2136 "package p;"
2137 "parcelable Data {"
2138 " int num;"
2139 "}");
2140 io_delegate_.SetFileContents("new/p/Data.aidl",
2141 "package p;"
2142 "parcelable Data {"
2143 " int num;"
2144 " String str;"
2145 "}");
2146 CaptureStderr();
2147 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2148 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2149}
2150
Jooyung Han636fd2f2020-10-22 11:33:45 +09002151TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2152 const string expected_stderr =
2153 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2154 "Please make sure 'Enum' has '0' as a valid value.\n";
2155 io_delegate_.SetFileContents("old/p/Data.aidl",
2156 "package p;"
2157 "parcelable Data {"
2158 " int num;"
2159 "}");
2160 io_delegate_.SetFileContents("new/p/Data.aidl",
2161 "package p;"
2162 "parcelable Data {"
2163 " int num;"
2164 " p.Enum e;"
2165 "}");
2166 io_delegate_.SetFileContents("new/p/Enum.aidl",
2167 "package p;"
2168 "enum Enum {"
2169 " FOO = 1,"
2170 " BAR = 2,"
2171 "}");
2172 CaptureStderr();
2173 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2174 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2175}
2176
Daniel Norman85aed542019-08-21 12:01:14 -07002177TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002178 const string expected_stderr =
2179 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002180 io_delegate_.SetFileContents("old/p/Enum.aidl",
2181 "package p;"
2182 "enum Enum {"
2183 " FOO = 1,"
2184 " BAR = 2,"
2185 "}");
2186 io_delegate_.SetFileContents("new/p/Enum.aidl",
2187 "package p;"
2188 "enum Enum {"
2189 " BAR = 2,"
2190 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002191 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002192 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002194}
2195
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002196TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2197 const string expected_stderr =
2198 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2199 io_delegate_.SetFileContents("old/p/Union.aidl",
2200 "package p;"
2201 "union Union {"
2202 " String str;"
2203 " int num;"
2204 "}");
2205 io_delegate_.SetFileContents("new/p/Union.aidl",
2206 "package p;"
2207 "union Union {"
2208 " String str;"
2209 "}");
2210 CaptureStderr();
2211 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2212 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2213}
2214
Daniel Norman85aed542019-08-21 12:01:14 -07002215TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002216 const string expected_stderr =
2217 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002218 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2219 "package p;"
2220 "interface IFoo {"
2221 " void foo(in String[] str);"
2222 " void bar(@utf8InCpp String str);"
2223 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002224 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2225 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002226 "interface IFoo {"
2227 " void foo(in String[] str);"
2228 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002229 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002230 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002231 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002233}
2234
Daniel Norman85aed542019-08-21 12:01:14 -07002235TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002236 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002237 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2238 "package p;"
2239 "interface IFoo {"
2240 " void foo(in String[] str);"
2241 " void bar(@utf8InCpp String str);"
2242 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002243 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2244 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002245 "interface IFoo2 {"
2246 " void foo(in String[] str);"
2247 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002248 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002249 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002250 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002252}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002253
Daniel Norman85aed542019-08-21 12:01:14 -07002254TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002255 const string expected_stderr =
2256 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002257 io_delegate_.SetFileContents("old/p/Enum.aidl",
2258 "package p;"
2259 "enum Enum {"
2260 " FOO = 1,"
2261 " BAR = 2,"
2262 "}");
2263 io_delegate_.SetFileContents("new/p/Enum.aidl",
2264 "package p;"
2265 "enum Enum {"
2266 " FOO = 3,"
2267 " BAR = 2,"
2268 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002269 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002270 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002272}
2273
2274TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002275 const string expected_stderr =
2276 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2277 "from 0 to 1.\n"
2278 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2279 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002280 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2281 "package p;"
2282 "interface IFoo {"
2283 " void foo(in String[] str);"
2284 " void bar(@utf8InCpp String str);"
2285 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2287 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002288 "interface IFoo {"
2289 " void bar(@utf8InCpp String str);"
2290 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002291 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002292 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002293 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002294 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002295}
2296
2297TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002298 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002299 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2300 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002301 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002302 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002303 "parcelable Data {"
2304 " int foo;"
2305 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002306 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002307 io_delegate_.SetFileContents("new/p/Data.aidl",
2308 "package p;"
2309 "parcelable Data {"
2310 " int bar;"
2311 " int foo;"
2312 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002313 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002314 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002315 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002316}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002317
Daniel Norman85aed542019-08-21 12:01:14 -07002318TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002319 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002320 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002321 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002322 "interface IFoo {"
2323 " void foo(in String[] str);"
2324 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002325 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002326 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2327 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002328 "interface IFoo {"
2329 " void foo(out String[] str);"
2330 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002331 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002332 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002333 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002334 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002335}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002336
Daniel Norman85aed542019-08-21 12:01:14 -07002337TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002338 const string expected_stderr =
2339 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002340 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2341 "package p;"
2342 "interface IFoo {"
2343 " void foo(in String[] str);"
2344 " void bar(@utf8InCpp String str);"
2345 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002346 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2347 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002348 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002349 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002350 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002351 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002352 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002353 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002355}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002356
Daniel Norman85aed542019-08-21 12:01:14 -07002357TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002358 const string expected_stderr =
2359 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002360 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2361 "package p;"
2362 "interface IFoo {"
2363 " void foo(in String[] str);"
2364 " void bar(@utf8InCpp String str);"
2365 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002366 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2367 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002368 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002369 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002370 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002371 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002372 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002373 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002375}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002376
Jooyung Han60b2fde2020-10-29 15:12:40 +09002377TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2378 const string expected_stderr =
2379 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2380 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2381 io_delegate_.SetFileContents("old/p/Foo.aidl",
2382 "package p;"
2383 "@Backing(type=\"byte\")"
2384 "enum Foo {"
2385 " FOO, BAR,"
2386 "}");
2387 io_delegate_.SetFileContents("new/p/Foo.aidl",
2388 "package p;"
2389 "@Backing(type=\"long\")"
2390 "enum Foo {"
2391 " FOO, BAR,"
2392 "}");
2393 CaptureStderr();
2394 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2395 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2396}
2397
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002398TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2399 const string expected_stderr =
2400 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2401 "to @JavaPassthrough(annotation=\"Bob\")\n";
2402 io_delegate_.SetFileContents("old/p/Foo.aidl",
2403 "package p;"
2404 "@JavaPassthrough(annotation=\"Alice\")"
2405 "parcelable Foo {}");
2406 io_delegate_.SetFileContents("new/p/Foo.aidl",
2407 "package p;"
2408 "@JavaPassthrough(annotation=\"Bob\")"
2409 "parcelable Foo {}");
2410
2411 CaptureStderr();
2412 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2414}
2415
Devin Mooredb7ac512020-08-07 11:17:36 -07002416TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2417 const string expected_stderr =
2418 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2419 io_delegate_.SetFileContents("old/p/Foo.aidl",
2420 "package p;"
2421 "parcelable Foo {"
2422 " int A;"
2423 "}");
2424 io_delegate_.SetFileContents("new/p/Foo.aidl",
2425 "package p;"
2426 "@JavaOnlyStableParcelable parcelable Foo {"
2427 " int A;"
2428 "}");
2429 CaptureStderr();
2430 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2431 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2432}
2433
2434TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2435 const string expected_stderr =
2436 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2437 io_delegate_.SetFileContents("old/p/Foo.aidl",
2438 "package p;"
2439 "@JavaOnlyStableParcelable parcelable Foo {"
2440 " int A;"
2441 "}");
2442 io_delegate_.SetFileContents("new/p/Foo.aidl",
2443 "package p;"
2444 "parcelable Foo {"
2445 " int A;"
2446 "}");
2447 CaptureStderr();
2448 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2449 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2450}
2451
Daniel Norman85aed542019-08-21 12:01:14 -07002452TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002454 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2455 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002456 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002458 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002459 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002460}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002461
Daniel Norman85aed542019-08-21 12:01:14 -07002462TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002463 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002464 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2465 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002466 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002467 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002468 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002469}
Jiyong Parka428d212018-08-29 22:26:30 +09002470
Daniel Norman85aed542019-08-21 12:01:14 -07002471TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002472 const string expected_stderr =
2473 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 io_delegate_.SetFileContents("old/p/I.aidl",
2475 "package p; interface I {"
2476 "const int A = 1; const int B = 2;}");
2477 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002478 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002479 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002480 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002481}
Jiyong Parka428d212018-08-29 22:26:30 +09002482
Daniel Norman85aed542019-08-21 12:01:14 -07002483TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 const string expected_stderr =
2485 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002486 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2487 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002488 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002489 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002490 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002491}
2492
Devin Moorec7e47a32020-08-07 10:55:25 -07002493TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2494 const string expected_stderr =
2495 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2496 "This is an incompatible change for FixedSize types.\n";
2497 io_delegate_.SetFileContents("old/p/Foo.aidl",
2498 "package p; @FixedSize parcelable Foo { int A = 1; }");
2499 io_delegate_.SetFileContents("new/p/Foo.aidl",
2500 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2501 CaptureStderr();
2502 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2504}
2505
2506TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2507 const string expected_stderr =
2508 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2509 io_delegate_.SetFileContents("old/p/Foo.aidl",
2510 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2511 io_delegate_.SetFileContents("new/p/Foo.aidl",
2512 "package p; @FixedSize parcelable Foo { int A = 1; }");
2513 CaptureStderr();
2514 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2515 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2516}
2517
2518TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2519 const string expected_stderr =
2520 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2521 "a.\n"
2522 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2523 "b.\n"
2524 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2525 "c.\n"
2526 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2527 "d.\n"
2528 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2529 "e.\n"
2530 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2531 "f.\n";
2532
2533 io_delegate_.SetFileContents("Foo.aidl",
2534 "@FixedSize parcelable Foo { "
2535 " int[] a;"
2536 " Bar b;"
2537 " String c;"
2538 " ParcelFileDescriptor d;"
2539 " IBinder e;"
2540 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002541 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002542 "}");
2543 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2544 Options options =
2545 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2546
2547 CaptureStderr();
2548 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2550}
2551
2552TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2553 const string expected_stderr = "";
2554
2555 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2556 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2557 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2558 Options options =
2559 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2560
2561 CaptureStderr();
2562 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2563 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2564}
2565
Jiyong Park8c380532018-08-30 14:55:26 +09002566TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 const string expected_stderr =
2568 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2569 "dir1/q/IBar.aidl\n"
2570 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002571 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002572 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2573 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2574 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2575 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2576
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002578 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002580}
2581
Jiyong Parked65bf42018-08-28 15:43:27 +09002582TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002583 const string expected_stderr =
2584 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2585 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002586 Options options = Options::From("aidl --checkapi old new");
2587 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2588 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002589
2590 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2591
Jiyong Parke59c3682018-09-11 23:10:25 +09002592 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002593 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002594 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002595 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002596}
2597
Jiyong Parke05195e2018-10-08 18:24:23 +09002598TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2599 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2600 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002601 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002602
2603 // use without import
2604 io_delegate_.SetFileContents("p/IFoo.aidl",
2605 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2606 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2607 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002608 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002609
Devin Moore7b8d5c92020-03-17 14:14:08 -07002610 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002611 io_delegate_.SetFileContents(
2612 "p/IFoo.aidl",
2613 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2614 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2615 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002616 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002617
2618 // use with import (as before)
2619 io_delegate_.SetFileContents("p/IFoo.aidl",
2620 "package p;"
2621 "import android.os.ParcelFileDescriptor;"
2622 "interface IFoo{"
2623 " void foo(in ParcelFileDescriptor fd);"
2624 "}");
2625 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2626 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002627 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002628}
Jiyong Parked65bf42018-08-28 15:43:27 +09002629
Jiyong Park3633b722019-04-11 15:38:26 +09002630TEST_F(AidlTest, ManualIds) {
2631 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2632 io_delegate_.SetFileContents("IFoo.aidl",
2633 "interface IFoo {\n"
2634 " void foo() = 0;\n"
2635 " void bar() = 1;\n"
2636 "}");
2637 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2638}
2639
2640TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2641 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2642 io_delegate_.SetFileContents("IFoo.aidl",
2643 "interface IFoo {\n"
2644 " void foo() = 0;\n"
2645 " void bar() = 1;\n"
2646 "}");
2647 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2648}
2649
2650TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002651 const string expected_stderr =
2652 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002653 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2654 io_delegate_.SetFileContents("IFoo.aidl",
2655 "interface IFoo {\n"
2656 " void foo() = 3;\n"
2657 " void bar() = 3;\n"
2658 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002659 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002660 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002662}
2663
2664TEST_F(AidlTest, FailOnOutOfRangeIds) {
2665 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002666 const string expected_stderr =
2667 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2668 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002669 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2670 io_delegate_.SetFileContents("IFoo.aidl",
2671 "interface IFoo {\n"
2672 " void foo() = 3;\n"
2673 " void bar() = 16777115;\n"
2674 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002675 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002676 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002677 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002678}
2679
2680TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002681 const string expected_stderr =
2682 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002683 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2684 io_delegate_.SetFileContents("IFoo.aidl",
2685 "interface IFoo {\n"
2686 " void foo() = 3;\n"
2687 " void bar();\n"
2688 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002689 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002690 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002691 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002692}
2693
Jiyong Parkc6816252019-07-08 08:12:28 +09002694TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2695 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2696 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2697 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2698 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2699}
2700
2701TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002702 const string expected_stderr =
2703 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2704 "dir/IBar.aidl\n"
2705 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002706 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002707
Jiyong Parkc6816252019-07-08 08:12:28 +09002708 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2709 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2710 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2711 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002712 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002713 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002714 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002715}
2716
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002717TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2718 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2719 "package a.b;\n"
2720 "import a.b.IBar;\n"
2721 "import a.b.IQux;\n"
2722 "interface IFoo { IQux foo(); }\n");
2723 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2724 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2725
2726 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2727 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2728
2729 string output;
2730 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2731 // IBar was imported but wasn't used. include is not expected.
2732 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2733 // IBar was imported and used. include is expected.
2734 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2735}
2736
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002737TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002738 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002739 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002740 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2741 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002742 interface IFoo {
2743 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002744 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002745 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002746 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002747 // JavaPassthrough should work with other types as well (e.g. enum)
2748 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2749 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2750 @JavaPassthrough(annotation="@com.android.AliceTwo")
2751 @Backing(type="byte")
2752 enum MyEnum {
2753 a, b, c
2754 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002755
Jooyung Han4cde01d2020-10-13 11:10:47 +09002756 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002757 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2758
2759 string java_out;
2760 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002761 // type-decl-level annotations with newline at the end
2762 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2763 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2764 // member-decl-level annotations with newline at the end
2765 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2766 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2767 // inline annotations with space at the end
2768 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002769
Jooyung Han4cde01d2020-10-13 11:10:47 +09002770 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2771 // type-decl-level annotations with newline at the end
2772 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2773 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2774
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002775 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002776 Options cpp_options =
2777 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002778 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2779
Jooyung Han4cde01d2020-10-13 11:10:47 +09002780 Options ndk_options =
2781 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002782 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002783
Jooyung Han4cde01d2020-10-13 11:10:47 +09002784 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002785 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002786}
2787
Andrei Homescue61feb52020-08-18 15:44:24 -07002788TEST_F(AidlTest, ParseRustDerive) {
2789 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2790 @RustDerive(Clone=true, Copy=false)
2791 parcelable Foo {
2792 int a;
2793 })");
2794
2795 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2796 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2797
2798 string rust_out;
2799 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2800 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2801
2802 // Other backends shouldn't be bothered
2803 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2804 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2805
2806 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2807 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2808
2809 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2810 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2811}
2812
Jiyong Park56f73d72019-06-11 12:20:28 +09002813class AidlOutputPathTest : public AidlTest {
2814 protected:
2815 void SetUp() override {
2816 AidlTest::SetUp();
2817 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2818 }
2819
2820 void Test(const Options& options, const std::string expected_output_path) {
2821 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2822 // check the existence
2823 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2824 }
2825};
2826
2827TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2828 // <out_dir> / <package_name> / <type_name>.java
2829 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2830}
2831
2832TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2833 // when output file is explicitly set, it is always respected. -o option is
2834 // ignored.
2835 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2836}
2837
2838TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2839 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2840}
2841
2842TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2843 // output is the same as the input file except for the suffix
2844 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2845}
2846
Devin Moore7b8d5c92020-03-17 14:14:08 -07002847TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002848 AidlError error;
2849 const string expected_stderr =
2850 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2851 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002852 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2853 R"(package p;
2854 interface IFoo {
2855 const int int32_max_oob = 2147483650;
2856 }
2857 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002858 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002859 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2860 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002861}
2862
Devin Moore7b8d5c92020-03-17 14:14:08 -07002863TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002864 AidlError error;
2865 const string expected_stderr =
2866 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2867 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002868 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2869 R"(package p;
2870 interface IFoo {
2871 const int int32_min_oob = -2147483650;
2872 }
2873 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002874 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002875 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2876 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002877}
2878
Devin Moore7b8d5c92020-03-17 14:14:08 -07002879TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002880 AidlError error;
2881 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002882 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002883 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002884 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2885 R"(package p;
2886 interface IFoo {
2887 const long int64_max_oob = 21474836509999999999999999;
2888 }
2889 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002890 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002891 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2892 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002893}
2894
Devin Moore7b8d5c92020-03-17 14:14:08 -07002895TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002896 AidlError error;
2897 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002898 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002899 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002900 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2901 R"(package p;
2902 interface IFoo {
2903 const long int64_min_oob = -21474836509999999999999999;
2904 }
2905 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002906 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002907 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2908 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002909}
2910
Devin Moore7b8d5c92020-03-17 14:14:08 -07002911TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002912 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002913 const string expected_stderr =
2914 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2915 "literal: byte\n"
2916 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2917 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002918 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2919 R"(package p;
2920 @Backing(type="byte")
2921 enum TestEnum {
2922 FOO = 127,
2923 BAR,
2924 }
2925 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002926 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002927 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002928 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002929}
2930
Devin Mooredecaf292020-04-30 09:16:40 -07002931TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2932 AidlError error;
2933 const string expected_stderr =
2934 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2935 "be one of: type\n"
2936 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2937 "be one of: type\n";
2938 CaptureStderr();
2939 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2940 R"(package p;
2941 @Backing(foo="byte")
2942 enum TestEnum {
2943 FOO = 1,
2944 BAR,
2945 }
2946 )",
2947 typenames_, GetLanguage(), &error));
2948 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2949 EXPECT_EQ(AidlError::BAD_TYPE, error);
2950}
2951
Jooyung Han66813932020-10-23 13:24:44 +09002952TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002953 io_delegate_.SetFileContents("Foo.aidl",
2954 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2955 "Map<String, Baz> d; Bar[] e; }");
2956 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2957 io_delegate_.SetFileContents("Baz.aidl",
2958 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002959 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2960 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2961}
2962
Jooyung Han66813932020-10-23 13:24:44 +09002963TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002964 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002965 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002966 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002967 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
2968 "named 'bar'.\n";
2969 CaptureStderr();
2970 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2971 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2972 EXPECT_EQ(expected_error, GetCapturedStderr());
2973}
2974
2975TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
2976 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
2977 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2978 string expected_error =
2979 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09002980 "named 'bar'.\n";
2981 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002982 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2983 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002984 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002985}
2986
Jooyung Han66813932020-10-23 13:24:44 +09002987TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002988 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002989 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2990 string expected_error =
2991 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2992 "only be an in parameter.\n";
2993 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002994 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2995 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002996 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002997}
2998
Jooyung Han66813932020-10-23 13:24:44 +09002999TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003000 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003001 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3002 string expected_error =
3003 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3004 "only be an in parameter.\n";
3005 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003006 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3007 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003008 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003009}
3010
Jooyung Han66813932020-10-23 13:24:44 +09003011TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003012 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003013 Options options = Options::From("aidl --lang=java Foo.aidl");
3014 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003015 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3016 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003017 CaptureStderr();
3018 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3019 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3020}
Devin Moore53fc99c2020-08-12 08:07:52 -07003021
Jooyung Han1f14ab32020-10-14 13:48:29 +09003022const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3023
3024#include <a/ByteEnum.h>
3025#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003026#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003027#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003028#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003029#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003030#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003031#include <locale>
3032#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003033#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003034#include <utility>
3035#include <variant>
3036#include <vector>
3037
Jooyung Handf39e192020-11-23 15:59:46 +09003038#ifndef __BIONIC__
3039#define __assert2(a,b,c,d) ((void)0)
3040#endif
3041
Jooyung Han1f14ab32020-10-14 13:48:29 +09003042namespace a {
3043
3044class Foo : public ::android::Parcelable {
3045public:
Jooyung Han97945de2020-10-15 16:41:38 +09003046 inline bool operator!=(const Foo& rhs) const {
3047 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003048 }
Jooyung Han97945de2020-10-15 16:41:38 +09003049 inline bool operator<(const Foo& rhs) const {
3050 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003051 }
Jooyung Han97945de2020-10-15 16:41:38 +09003052 inline bool operator<=(const Foo& rhs) const {
3053 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003054 }
Jooyung Han97945de2020-10-15 16:41:38 +09003055 inline bool operator==(const Foo& rhs) const {
3056 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003057 }
Jooyung Han97945de2020-10-15 16:41:38 +09003058 inline bool operator>(const Foo& rhs) const {
3059 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003060 }
Jooyung Han97945de2020-10-15 16:41:38 +09003061 inline bool operator>=(const Foo& rhs) const {
3062 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003063 }
Jooyung Han97945de2020-10-15 16:41:38 +09003064
Jooyung Han1f14ab32020-10-14 13:48:29 +09003065 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003066 ns = 0, // int[] ns;
3067 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003068 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003069 };
Jooyung Han97945de2020-10-15 16:41:38 +09003070
Jooyung Han1f14ab32020-10-14 13:48:29 +09003071 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003072 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003073
3074 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003075 Foo(const Foo&) = default;
3076 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003077 Foo& operator=(const Foo&) = default;
3078 Foo& operator=(Foo&&) = default;
3079
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003080 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3081 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003082 constexpr Foo(_Tp&& _arg)
3083 : _value(std::forward<_Tp>(_arg)) {}
3084
3085 template <typename... _Tp>
3086 constexpr explicit Foo(_Tp&&... _args)
3087 : _value(std::forward<_Tp>(_args)...) {}
3088
3089 template <Tag _tag, typename... _Tp>
3090 static Foo make(_Tp&&... _args) {
3091 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003092 }
Jooyung Han97945de2020-10-15 16:41:38 +09003093
3094 template <Tag _tag, typename _Tp, typename... _Up>
3095 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3096 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003097 }
3098
3099 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003100 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003101 }
3102
Jooyung Han97945de2020-10-15 16:41:38 +09003103 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003104 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003105 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003106 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003107 }
3108
Jooyung Han97945de2020-10-15 16:41:38 +09003109 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003110 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003111 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003112 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003113 }
3114
Jooyung Han97945de2020-10-15 16:41:38 +09003115 template <Tag _tag, typename... _Tp>
3116 void set(_Tp&&... _args) {
3117 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003118 }
3119
3120 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3121 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3122 static const std::string& getParcelableDescriptor() {
3123 static const std::string DESCIPTOR = "a.Foo";
3124 return DESCIPTOR;
3125 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003126 template <typename _T> class _has_toString {
3127 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3128 template <typename _U> static std::false_type __has_toString(...);
3129 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3130 };
3131 template <typename _T> inline static std::string _call_toString(const _T& t) {
3132 if constexpr (_has_toString<_T>::value) return t.toString();
3133 return "{no toString() implemented}";
3134 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003135 inline std::string toString() const {
3136 std::ostringstream os;
3137 os << "Foo{";
3138 switch (getTag()) {
3139 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3140 case e: os << "e: " << a::toString(get<e>()); break;
3141 case pfd: os << "pfd: " << ""; break;
3142 }
3143 os << "}";
3144 return os.str();
3145 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003146private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003147 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003148}; // class Foo
3149
3150} // namespace a
3151)";
3152
3153const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3154
3155namespace a {
3156
3157::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3158 ::android::status_t _aidl_ret_status;
3159 int32_t _aidl_tag;
3160 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3161 switch (_aidl_tag) {
3162 case ns: {
3163 ::std::vector<int32_t> _aidl_value;
3164 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003165 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3166 set<ns>(_aidl_value);
3167 } else {
3168 // NOLINTNEXTLINE(performance-move-const-arg)
3169 set<ns>(std::move(_aidl_value));
3170 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003171 return ::android::OK; }
3172 case e: {
3173 ::a::ByteEnum _aidl_value;
3174 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003175 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3176 set<e>(_aidl_value);
3177 } else {
3178 // NOLINTNEXTLINE(performance-move-const-arg)
3179 set<e>(std::move(_aidl_value));
3180 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003181 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003182 case pfd: {
3183 ::android::os::ParcelFileDescriptor _aidl_value;
3184 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003185 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3186 set<pfd>(_aidl_value);
3187 } else {
3188 // NOLINTNEXTLINE(performance-move-const-arg)
3189 set<pfd>(std::move(_aidl_value));
3190 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003191 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003192 }
3193 return ::android::BAD_VALUE;
3194}
3195
3196::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3197 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3198 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3199 switch (getTag()) {
3200 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3201 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003202 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003203 }
Jooyung Handf39e192020-11-23 15:59:46 +09003204 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003205}
3206
3207} // namespace a
3208)";
3209
Jooyung Han6beac042020-10-17 21:59:43 +09003210const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3211#include <android/binder_interface_utils.h>
3212#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003213#include <codecvt>
3214#include <locale>
3215#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003216
Jooyung Handf39e192020-11-23 15:59:46 +09003217#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003218#include <type_traits>
3219#include <utility>
3220#include <variant>
3221#include <cstdint>
3222#include <memory>
3223#include <optional>
3224#include <string>
3225#include <vector>
3226#ifdef BINDER_STABILITY_SUPPORT
3227#include <android/binder_stability.h>
3228#endif // BINDER_STABILITY_SUPPORT
3229#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003230
3231#ifndef __BIONIC__
3232#define __assert2(a,b,c,d) ((void)0)
3233#endif
3234
Jooyung Han6beac042020-10-17 21:59:43 +09003235namespace aidl {
3236namespace a {
3237class Foo {
3238public:
3239 typedef std::false_type fixed_size;
3240 static const char* descriptor;
3241
3242 enum Tag : int32_t {
3243 ns = 0, // int[] ns;
3244 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003245 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003246 };
3247
3248 template<typename _Tp>
3249 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3250
3251 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3252 Foo(const Foo&) = default;
3253 Foo(Foo&&) = default;
3254 Foo& operator=(const Foo&) = default;
3255 Foo& operator=(Foo&&) = default;
3256
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003257 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3258 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003259 constexpr Foo(_Tp&& _arg)
3260 : _value(std::forward<_Tp>(_arg)) {}
3261
3262 template <typename... _Tp>
3263 constexpr explicit Foo(_Tp&&... _args)
3264 : _value(std::forward<_Tp>(_args)...) {}
3265
3266 template <Tag _tag, typename... _Tp>
3267 static Foo make(_Tp&&... _args) {
3268 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3269 }
3270
3271 template <Tag _tag, typename _Tp, typename... _Up>
3272 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3273 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3274 }
3275
3276 Tag getTag() const {
3277 return static_cast<Tag>(_value.index());
3278 }
3279
3280 template <Tag _tag>
3281 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003282 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003283 return std::get<_tag>(_value);
3284 }
3285
3286 template <Tag _tag>
3287 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003288 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003289 return std::get<_tag>(_value);
3290 }
3291
3292 template <Tag _tag, typename... _Tp>
3293 void set(_Tp&&... _args) {
3294 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3295 }
3296
3297 binder_status_t readFromParcel(const AParcel* _parcel);
3298 binder_status_t writeToParcel(AParcel* _parcel) const;
3299 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003300 template <typename _T> class _has_toString {
3301 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3302 template <typename _U> static std::false_type __has_toString(...);
3303 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3304 };
3305 template <typename _T> inline static std::string _call_toString(const _T& t) {
3306 if constexpr (_has_toString<_T>::value) return t.toString();
3307 return "{no toString() implemented}";
3308 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003309 inline std::string toString() const {
3310 std::ostringstream os;
3311 os << "Foo{";
3312 switch (getTag()) {
3313 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3314 case e: os << "e: " << a::toString(get<e>()); break;
3315 case pfd: os << "pfd: " << ""; break;
3316 }
3317 os << "}";
3318 return os.str();
3319 }
Jooyung Han6beac042020-10-17 21:59:43 +09003320private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003321 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003322};
3323} // namespace a
3324} // namespace aidl
3325)";
3326
3327const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3328
3329#include <android/binder_parcel_utils.h>
3330
3331namespace aidl {
3332namespace a {
3333const char* Foo::descriptor = "a.Foo";
3334
3335binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3336 binder_status_t _aidl_ret_status;
3337 int32_t _aidl_tag;
3338 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3339 switch (_aidl_tag) {
3340 case ns: {
3341 std::vector<int32_t> _aidl_value;
3342 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003343 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3344 set<ns>(_aidl_value);
3345 } else {
3346 // NOLINTNEXTLINE(performance-move-const-arg)
3347 set<ns>(std::move(_aidl_value));
3348 }
Jooyung Han6beac042020-10-17 21:59:43 +09003349 return STATUS_OK; }
3350 case e: {
3351 ::aidl::a::ByteEnum _aidl_value;
3352 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003353 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3354 set<e>(_aidl_value);
3355 } else {
3356 // NOLINTNEXTLINE(performance-move-const-arg)
3357 set<e>(std::move(_aidl_value));
3358 }
Jooyung Han6beac042020-10-17 21:59:43 +09003359 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003360 case pfd: {
3361 ::ndk::ScopedFileDescriptor _aidl_value;
3362 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003363 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3364 set<pfd>(_aidl_value);
3365 } else {
3366 // NOLINTNEXTLINE(performance-move-const-arg)
3367 set<pfd>(std::move(_aidl_value));
3368 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003369 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003370 }
3371 return STATUS_BAD_VALUE;
3372}
3373binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3374 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3375 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3376 switch (getTag()) {
3377 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3378 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003379 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003380 }
Jooyung Handf39e192020-11-23 15:59:46 +09003381 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003382}
3383
3384} // namespace a
3385} // namespace aidl
3386)";
3387
Jooyung Han1f14ab32020-10-14 13:48:29 +09003388const char kUnionExampleExpectedOutputJava[] = R"(/*
3389 * This file is auto-generated. DO NOT MODIFY.
3390 */
3391package a;
3392
3393
3394public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003395 // tags for union fields
3396 public final static int ns = 0; // int[] ns;
3397 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003398 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003399
3400 private int _tag;
3401 private Object _value;
3402
3403 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003404 int[] _value = {42};
3405 this._tag = ns;
3406 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003407 }
Jooyung Han97945de2020-10-15 16:41:38 +09003408
Jooyung Han1f14ab32020-10-14 13:48:29 +09003409 private Foo(android.os.Parcel _aidl_parcel) {
3410 readFromParcel(_aidl_parcel);
3411 }
Jooyung Han97945de2020-10-15 16:41:38 +09003412
Jooyung Hance62f932020-10-25 10:21:49 +09003413 private Foo(int _tag, Object _value) {
3414 this._tag = _tag;
3415 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003416 }
3417
3418 public int getTag() {
3419 return _tag;
3420 }
3421
Jooyung Han97945de2020-10-15 16:41:38 +09003422 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003423
3424 public static Foo ns(int[] _value) {
3425 return new Foo(ns, _value);
3426 }
Jooyung Han97945de2020-10-15 16:41:38 +09003427
Jooyung Han1f14ab32020-10-14 13:48:29 +09003428 public int[] getNs() {
3429 _assertTag(ns);
3430 return (int[]) _value;
3431 }
Jooyung Han97945de2020-10-15 16:41:38 +09003432
Jooyung Han1f14ab32020-10-14 13:48:29 +09003433 public void setNs(int[] _value) {
3434 _set(ns, _value);
3435 }
3436
Jooyung Han97945de2020-10-15 16:41:38 +09003437 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003438
3439 public static Foo e(byte _value) {
3440 return new Foo(e, _value);
3441 }
Jooyung Han97945de2020-10-15 16:41:38 +09003442
Jooyung Han1f14ab32020-10-14 13:48:29 +09003443 public byte getE() {
3444 _assertTag(e);
3445 return (byte) _value;
3446 }
Jooyung Han97945de2020-10-15 16:41:38 +09003447
Jooyung Han1f14ab32020-10-14 13:48:29 +09003448 public void setE(byte _value) {
3449 _set(e, _value);
3450 }
3451
Jooyung Hand2fa0232020-10-19 02:51:41 +09003452 // ParcelFileDescriptor pfd;
3453
3454 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3455 return new Foo(pfd, _value);
3456 }
3457
3458 public android.os.ParcelFileDescriptor getPfd() {
3459 _assertTag(pfd);
3460 return (android.os.ParcelFileDescriptor) _value;
3461 }
3462
3463 public void setPfd(android.os.ParcelFileDescriptor _value) {
3464 _set(pfd, _value);
3465 }
3466
Jooyung Han1f14ab32020-10-14 13:48:29 +09003467 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3468 @Override
3469 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003470 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003471 }
3472 @Override
3473 public Foo[] newArray(int _aidl_size) {
3474 return new Foo[_aidl_size];
3475 }
3476 };
Jooyung Han97945de2020-10-15 16:41:38 +09003477
Jooyung Han1f14ab32020-10-14 13:48:29 +09003478 @Override
3479 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3480 _aidl_parcel.writeInt(_tag);
3481 switch (_tag) {
3482 case ns:
3483 _aidl_parcel.writeIntArray(getNs());
3484 break;
3485 case e:
3486 _aidl_parcel.writeByte(getE());
3487 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003488 case pfd:
3489 if ((getPfd()!=null)) {
3490 _aidl_parcel.writeInt(1);
3491 getPfd().writeToParcel(_aidl_parcel, 0);
3492 }
3493 else {
3494 _aidl_parcel.writeInt(0);
3495 }
3496 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003497 }
3498 }
Jooyung Han97945de2020-10-15 16:41:38 +09003499
Jooyung Han1f14ab32020-10-14 13:48:29 +09003500 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3501 int _aidl_tag;
3502 _aidl_tag = _aidl_parcel.readInt();
3503 switch (_aidl_tag) {
3504 case ns: {
3505 int[] _aidl_value;
3506 _aidl_value = _aidl_parcel.createIntArray();
3507 _set(_aidl_tag, _aidl_value);
3508 return; }
3509 case e: {
3510 byte _aidl_value;
3511 _aidl_value = _aidl_parcel.readByte();
3512 _set(_aidl_tag, _aidl_value);
3513 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003514 case pfd: {
3515 android.os.ParcelFileDescriptor _aidl_value;
3516 if ((0!=_aidl_parcel.readInt())) {
3517 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3518 }
3519 else {
3520 _aidl_value = null;
3521 }
3522 _set(_aidl_tag, _aidl_value);
3523 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003524 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003525 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003526 }
Jooyung Han97945de2020-10-15 16:41:38 +09003527
Jooyung Han1f14ab32020-10-14 13:48:29 +09003528 @Override
3529 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003530 int _mask = 0;
3531 switch (getTag()) {
3532 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003533 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003534 break;
3535 }
3536 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003537 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003538 private int describeContents(Object _v) {
3539 if (_v == null) return 0;
3540 if (_v instanceof android.os.Parcelable) {
3541 return ((android.os.Parcelable) _v).describeContents();
3542 }
3543 return 0;
3544 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003545
3546 private void _assertTag(int tag) {
3547 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003548 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003549 }
3550 }
Jooyung Han97945de2020-10-15 16:41:38 +09003551
Jooyung Han1f14ab32020-10-14 13:48:29 +09003552 private String _tagString(int _tag) {
3553 switch (_tag) {
3554 case ns: return "ns";
3555 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003556 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003557 }
3558 throw new IllegalStateException("unknown field: " + _tag);
3559 }
Jooyung Han97945de2020-10-15 16:41:38 +09003560
Jooyung Hance62f932020-10-25 10:21:49 +09003561 private void _set(int _tag, Object _value) {
3562 this._tag = _tag;
3563 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003564 }
3565}
3566)";
3567
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003568const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3569pub enum Foo {
3570 Ns(Vec<i32>),
3571 E(crate::mangled::_1_a_8_ByteEnum),
3572 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3573}
3574pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3575impl Default for Foo {
3576 fn default() -> Self {
3577 Self::Ns(vec!{42})
3578 }
3579}
3580impl binder::parcel::Serialize for Foo {
3581 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3582 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3583 }
3584}
3585impl binder::parcel::SerializeArray for Foo {}
3586impl binder::parcel::SerializeOption for Foo {
3587 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3588 let this = if let Some(this) = this {
3589 parcel.write(&1i32)?;
3590 this
3591 } else {
3592 return parcel.write(&0i32);
3593 };
3594 match this {
3595 Self::Ns(v) => {
3596 parcel.write(&0i32)?;
3597 parcel.write(v)
3598 }
3599 Self::E(v) => {
3600 parcel.write(&1i32)?;
3601 parcel.write(v)
3602 }
3603 Self::Pfd(v) => {
3604 parcel.write(&2i32)?;
3605 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3606 parcel.write(__field_ref)
3607 }
3608 }
3609 }
3610}
3611impl binder::parcel::Deserialize for Foo {
3612 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3613 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3614 .transpose()
3615 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3616 }
3617}
3618impl binder::parcel::DeserializeArray for Foo {}
3619impl binder::parcel::DeserializeOption for Foo {
3620 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3621 let status: i32 = parcel.read()?;
3622 if status == 0 { return Ok(None); }
3623 let tag: i32 = parcel.read()?;
3624 match tag {
3625 0 => {
3626 let value: Vec<i32> = parcel.read()?;
3627 Ok(Some(Self::Ns(value)))
3628 }
3629 1 => {
3630 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3631 Ok(Some(Self::E(value)))
3632 }
3633 2 => {
3634 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3635 Ok(Some(Self::Pfd(value)))
3636 }
3637 _ => {
3638 Err(binder::StatusCode::BAD_VALUE)
3639 }
3640 }
3641 }
3642}
3643)";
3644
Jooyung Han97945de2020-10-15 16:41:38 +09003645struct AidlUnionTest : ::testing::Test {
3646 void SetUp() override {
3647 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003648package a;
3649import a.ByteEnum;
3650union Foo {
3651 int[] ns = {42};
3652 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003653 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003654}
3655)");
Jooyung Han97945de2020-10-15 16:41:38 +09003656 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003657package a;
3658@Backing(type="byte")
3659enum ByteEnum {
3660 a, b, c
3661}
3662)");
Jooyung Han97945de2020-10-15 16:41:38 +09003663 }
3664 FakeIoDelegate io_delegate_;
3665 void Compile(string lang) {
3666 string command = "aidl --structured -I. -o out --lang=" + lang;
3667 if (lang == "cpp" || lang == "ndk") {
3668 command += " -h out";
3669 }
3670 command += " a/Foo.aidl";
3671 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003672 CaptureStderr();
3673 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3674 auto err = GetCapturedStderr();
3675 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003676 }
3677 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3678 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003679 string actual;
3680 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3681 EXPECT_EQ(expected, actual);
3682 }
Jooyung Han97945de2020-10-15 16:41:38 +09003683 }
3684};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003685
Jooyung Han97945de2020-10-15 16:41:38 +09003686TEST_F(AidlUnionTest, Example_Cpp) {
3687 Compile("cpp");
3688 EXPECT_COMPILE_OUTPUTS(
3689 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3690 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3691}
3692
Jooyung Han6beac042020-10-17 21:59:43 +09003693TEST_F(AidlUnionTest, Example_Ndk) {
3694 Compile("ndk");
3695 EXPECT_COMPILE_OUTPUTS(
3696 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3697 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3698}
3699
Jooyung Han97945de2020-10-15 16:41:38 +09003700TEST_F(AidlUnionTest, Example_Java) {
3701 Compile("java");
3702 EXPECT_COMPILE_OUTPUTS(
3703 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003704}
3705
3706TEST_F(AidlUnionTest, Example_Rust) {
3707 Compile("rust");
3708 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003709}
3710
Jooyung Hanfe89f122020-10-14 03:49:18 +09003711TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3712 const string method = "package a; union Foo {}";
3713 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3714 CaptureStderr();
3715 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3716 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3717}
3718
3719TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3720 const string method = "package a; union Foo { ParcelableHolder x; }";
3721 const string expected_stderr =
3722 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3723 CaptureStderr();
3724 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3725 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3726}
3727
Devin Moore53fc99c2020-08-12 08:07:52 -07003728TEST_P(AidlTest, GenericStructuredParcelable) {
3729 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3730 Options options =
3731 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3732 const string expected_stderr = "";
3733 CaptureStderr();
3734 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3735 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3736}
3737
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003738TEST_F(AidlTest, NestedTypeArgs) {
3739 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003740 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3741
3742 io_delegate_.SetFileContents("a/Foo.aidl",
3743 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3744 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003745 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3746 const string expected_stderr = "";
3747 CaptureStderr();
3748 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3749 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3750
3751 string code;
3752 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003753 EXPECT_THAT(code,
3754 testing::HasSubstr(
3755 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3756}
3757
3758TEST_F(AidlTest, DoubleArrayError) {
3759 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3760
3761 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3762 const string expected_stderr =
3763 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3764 CaptureStderr();
3765 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3766 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3767}
3768
3769TEST_F(AidlTest, DoubleGenericError) {
3770 io_delegate_.SetFileContents("a/Bar.aidl",
3771 "package a; parcelable Bar { List<String><String> a; }");
3772
3773 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3774 const string expected_stderr =
3775 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3776 CaptureStderr();
3777 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3778 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3779}
3780
3781TEST_F(AidlTest, ArrayBeforeGenericError) {
3782 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3783
3784 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3785 const string expected_stderr =
3786 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3787 CaptureStderr();
3788 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3789 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003790}
3791
Jooyung Han14004ed2020-10-16 03:49:57 +09003792struct GenericAidlTest : ::testing::Test {
3793 FakeIoDelegate io_delegate_;
3794 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003795 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003796 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3797 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3798 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3799
3800 Options options = Options::From(cmd);
3801 CaptureStderr();
3802 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3803 EXPECT_EQ("", GetCapturedStderr());
3804 }
3805};
3806
3807TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3808 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3809 string code;
3810 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3811 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3812 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3813 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3814}
3815
3816TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3817 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3818 string code;
3819 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3820 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3821 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3822 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3823}
3824
Devin Moore53fc99c2020-08-12 08:07:52 -07003825TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3826 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3827 Options options =
3828 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3829 const string expected_stderr =
3830 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3831 CaptureStderr();
3832 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3833 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3834}
3835
3836TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3837 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3838 Options options =
3839 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3840 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3841 CaptureStderr();
3842 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3843 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3844}
3845
Jooyung Han7a308842020-10-27 19:06:49 +09003846TEST_P(AidlTest, LongCommentWithinConstExpression) {
3847 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3848 Options options =
3849 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3850 CaptureStderr();
3851 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3852 EXPECT_EQ("", GetCapturedStderr());
3853}
3854
Jeongik Chaef44e622020-10-23 16:00:52 +09003855TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3856 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3857 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3858 std::string expectedErr =
3859 "ERROR: a/Foo.aidl:1.28-30: "
3860 "Encountered an untyped List or Map. The use of untyped List/Map is "
3861 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3862 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3863 "ERROR: a/Foo.aidl:1.35-37: "
3864 "Encountered an untyped List or Map. The use of untyped List/Map is "
3865 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3866 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3867 CaptureStderr();
3868 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3869 EXPECT_EQ(expectedErr, GetCapturedStderr());
3870}
3871
3872TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003873 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3874 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003875 std::string expectedErr =
3876 "ERROR: a/Foo.aidl:1.33-35: "
3877 "Encountered an untyped List or Map. The use of untyped List/Map is "
3878 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3879 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3880 "ERROR: a/Foo.aidl:1.40-42: "
3881 "Encountered an untyped List or Map. The use of untyped List/Map is "
3882 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3883 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003884 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003885 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3886 EXPECT_EQ(expectedErr, GetCapturedStderr());
3887}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003888
Jeongik Chaef44e622020-10-23 16:00:52 +09003889TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3890 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3891 io_delegate_.SetFileContents(
3892 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3893 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3894 std::string expectedErr =
3895 "ERROR: a/Foo.aidl:1.52-54: "
3896 "Encountered an untyped List or Map. The use of untyped List/Map is "
3897 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3898 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3899 "ERROR: a/Foo.aidl:1.64-66: "
3900 "Encountered an untyped List or Map. The use of untyped List/Map is "
3901 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3902 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3903 CaptureStderr();
3904 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3905 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003906}
3907
Christopher Wiley90be4e32015-10-20 14:55:25 -07003908} // namespace aidl
3909} // namespace android