blob: e3a761b26bdd480de447f65fd024ebaed1ca4360 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
1477TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1478 io_delegate_.SetFileContents("p/IOuter.aidl",
1479 "package p;\n"
1480 "interface IOuter {\n"
1481 " parcelable Inner {}\n"
1482 "}");
1483 import_paths_.emplace("");
1484 const string input_path = "p/IFoo.aidl";
1485 const string input =
1486 "package p;\n"
1487 "interface IFoo {\n"
1488 " p.IOuter.Inner get();\n"
1489 "}";
1490 CaptureStderr();
1491 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1492 EXPECT_EQ(GetCapturedStderr(), "");
1493
1494 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1495}
1496
1497TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1498 io_delegate_.SetFileContents("p/IOuter.aidl",
1499 "package p;\n"
1500 "interface IOuter {\n"
1501 " parcelable Inner {}\n"
1502 "}");
1503 import_paths_.emplace("");
1504 const string input_path = "p/IFoo.aidl";
1505 const string input =
1506 "package p;\n"
1507 "import p.IOuter.Inner;"
1508 "interface IFoo {\n"
1509 " Inner get();\n"
1510 "}";
1511 CaptureStderr();
1512 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1513 EXPECT_EQ(GetCapturedStderr(), "");
1514
1515 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1516}
1517
1518TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1519 const string input_path = "p/IFoo.aidl";
1520 const string input =
1521 "package p;\n"
1522 "interface IFoo {\n"
1523 " parcelable Result {}\n"
1524 " Result get();\n"
1525 "}";
1526 CaptureStderr();
1527 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1528 EXPECT_EQ(GetCapturedStderr(), "");
1529
1530 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1531}
1532
1533// Finding the type of nested named member.
1534struct TypeFinder : AidlVisitor {
1535 string name;
1536 const AidlTypeSpecifier* type = nullptr;
1537 TypeFinder(std::string name) : name(name) {}
1538 void Visit(const AidlVariableDeclaration& v) override {
1539 if (v.GetName() == name) {
1540 type = &v.GetType();
1541 }
1542 }
1543 void Visit(const AidlMethod& m) override {
1544 if (m.GetName() == name) {
1545 type = &m.GetType();
1546 }
1547 }
1548 static string Get(const AidlDefinedType& type, const string& name) {
1549 TypeFinder v(name);
1550 VisitTopDown(v, type);
1551 return v.type ? v.type->Signature() : "(null)";
1552 };
1553};
1554
1555TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1556 io_delegate_.SetFileContents("q/IBar.aidl",
1557 "package q;\n"
1558 "interface IBar {\n"
1559 " parcelable Baz {}\n"
1560 "}");
1561 import_paths_.emplace("");
1562 const string input_path = "p/IFoo.aidl";
1563 const string input =
1564 "package p;\n"
1565 "import q.IBar;\n"
1566 "interface IFoo {\n"
1567 " parcelable Nested {\n"
1568 " Baz t1;\n"
1569 " }\n"
1570 " parcelable Baz { }\n"
1571 " IBar.Baz t2();\n"
1572 " Baz t3();\n"
1573 "}";
1574 CaptureStderr();
1575 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1576 EXPECT_EQ(GetCapturedStderr(), "");
1577 ASSERT_NE(nullptr, foo);
1578
1579 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1580 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1581 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1582}
1583
1584TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1585 const string input_path = "p/Foo.aidl";
1586 const string input =
1587 "package p;\n"
1588 "parcelable Foo {\n"
1589 " parcelable Foo {}\n"
1590 "}";
1591 CaptureStderr();
1592 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1593 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1594}
1595
1596TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1597 const string input_path = "p/IFoo.aidl";
1598 const string input =
1599 "package p;\n"
1600 "interface IFoo {\n"
1601 " interface ICallback { void done(); }\n"
1602 " void doTask(ICallback cb);\n"
1603 "}";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1606 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1607}
1608
Jooyung Han2b1487d2021-09-30 09:57:01 +09001609TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1610 const string input_path = "p/IFoo.aidl";
1611 const string input =
1612 "package p;\n"
1613 "interface IFoo {\n"
1614 " parcelable Bar cpp_header \"Bar.h\";\n"
1615 "}";
1616 CaptureStderr();
1617 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1618 EXPECT_THAT(GetCapturedStderr(),
1619 HasSubstr("Unstructured parcelables should be at the root scope"));
1620}
1621
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001622TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1623 const string input_path = "p/IFoo.aidl";
1624 const string input =
1625 "package p;\n"
1626 "interface IFoo {\n"
1627 " parcelable;\n" // missing identifier
1628 "}";
1629 CaptureStderr();
1630 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1631 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1632}
1633
Jooyung Han2aedb112021-09-29 09:37:59 +09001634TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1635 const string input_path = "p/Foo.aidl";
1636 const string input =
1637 "package p;\n"
1638 "interface Foo {\n"
1639 " parcelable Bar {}\n"
1640 " parcelable Bar {}\n"
1641 "}";
1642 CaptureStderr();
1643 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1644 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1645}
1646
1647TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1648 struct Failure {
1649 string err;
1650 };
1651 struct TestCase {
1652 string type;
1653 variant<string, Failure> expected; // success<0> or failure<1>
1654 };
1655 vector<TestCase> cases = {
1656 {"foo.A", "foo.A"},
1657 {"foo.A.B", "foo.A.B"},
1658 {"@nullable(heap=true) A", "foo.A.B.A"},
1659 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1660 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1661 {"B", "foo.A.B.A.B"},
1662 {"A.B", "foo.A.B.A.B"},
1663 };
1664 const string input_path = "foo/A.aidl";
1665 for (auto& [type, expected] : cases) {
1666 AidlTypenames typenames;
1667 // clang-format off
1668 const string input =
1669 "package foo;\n"
1670 "parcelable A {\n"
1671 " parcelable B {\n"
1672 " parcelable A {\n"
1673 " parcelable B {\n"
1674 " }\n"
1675 " " + type + " m;\n"
1676 " }\n"
1677 " }\n"
1678 "}";
1679 // clang-format on
1680 CaptureStderr();
1681 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1682 if (auto failure = std::get_if<Failure>(&expected); failure) {
1683 ASSERT_EQ(nullptr, foo);
1684 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1685 } else {
1686 EXPECT_EQ(GetCapturedStderr(), "");
1687 ASSERT_NE(nullptr, foo);
1688 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1689 }
1690 }
1691}
1692
Jooyung Hanca84b032021-09-30 02:15:59 +09001693TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1694 const string input_path = "p/IFoo.aidl";
1695 const string input =
1696 "package p;\n"
1697 "interface IFoo {\n"
1698 " parcelable Result {}\n"
1699 "}";
1700 CaptureStderr();
1701 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1702 ASSERT_NE(nullptr, foo);
1703 EXPECT_EQ(GetCapturedStderr(), "");
1704
1705 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1706 ASSERT_NE(nullptr, result);
1707 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1708}
1709
Jooyung Han0a950bd2021-05-15 12:50:36 +09001710TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001711 const string input_path = "p/Wrapper.aidl";
1712 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001713
1714 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1715 EXPECT_NE(nullptr, parse_result);
1716
1717 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1718 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1719 (..., params->emplace_back(std::move(type_params)));
1720 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1721 };
1722
1723 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1724 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001725 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001726 type->Annotate(std::move(annotations));
1727 return std::move(type);
1728 };
1729
1730 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1731 (void)type->SetArray();
1732 return std::move(type);
1733 };
1734
1735 auto w = type("p.Wrapper", type("String"));
1736 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1737
1738 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1739 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1740 cpp::CppNameOf(*nullable_w, typenames_));
1741
1742 auto array_w = set_array(type("p.Wrapper", type("String")));
1743 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1744 cpp::CppNameOf(*array_w, typenames_));
1745
1746 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1747 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1748 cpp::CppNameOf(*nullable_array_w, typenames_));
1749
1750 auto list_w = type("List", type("p.Wrapper", type("String")));
1751 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1752 cpp::CppNameOf(*list_w, typenames_));
1753
1754 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1755 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1756 cpp::CppNameOf(*nullable_list_w, typenames_));
1757}
1758
Devin Moore7b8d5c92020-03-17 14:14:08 -07001759TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001760 io_delegate_.SetFileContents(
1761 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001762 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001763 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001764 const string input_path = "p/IFoo.aidl";
1765 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001766 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1767 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001768 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001769 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001770 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001771
1772 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1773 // C++ understands C++ specific stuff
1774 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1775 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001776 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001777 EXPECT_EQ(1u, headers.size());
1778 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001779}
1780
Christopher Wileyf8136192016-04-12 14:19:35 -07001781TEST_F(AidlTest, WritesCorrectDependencyFile) {
1782 // While the in tree build system always gives us an output file name,
1783 // other android tools take advantage of our ability to infer the intended
1784 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001785 vector<string> args = {
1786 "aidl",
1787 "-d dep/file/path",
1788 "-o place/for/output",
1789 "p/IFoo.aidl"};
1790 Options options = Options::From(args);
1791 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001792 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001793 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001794 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001795 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1796}
1797
Dan Willemsen93298ee2016-11-10 23:55:55 -08001798TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1799 // While the in tree build system always gives us an output file name,
1800 // other android tools take advantage of our ability to infer the intended
1801 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001802 vector<string> args = {
1803 "aidl",
1804 "-d dep/file/path",
1805 "--ninja",
1806 "-o place/for/output",
1807 "p/IFoo.aidl"};
1808 Options options = Options::From(args);
1809 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001810 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001811 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001812 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001813 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1814}
1815
Jiyong Parkdf202122019-09-30 20:48:35 +09001816TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001817 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1818 // this by calling aidl with every .aidl file it finds, then parsing the
1819 // generated dependency files. Those that reference .java output files are
1820 // for interfaces and those that do not are parcelables. However, for both
1821 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001822 vector<string> args = {
1823 "aidl",
1824 "-o place/for/output",
1825 "-d dep/file/path",
1826 "p/Foo.aidl"};
1827 Options options = Options::From(args);
1828 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001829 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001830 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001831 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001832 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1833}
1834
1835TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1836 vector<string> args = {
1837 "aidl",
1838 "--structured",
1839 "-o place/for/output",
1840 "-d dep/file/path",
1841 "p/Foo.aidl"};
1842 Options options = Options::From(args);
1843 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001844 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001845 string actual_dep_file_contents;
1846 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1847 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001848}
1849
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001850TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1851 vector<string> args = {
1852 "aidl",
1853 "--lang=java",
1854 "-o place/for/output",
1855 "p/Foo.aidl"};
1856 Options options = Options::From(args);
1857 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001858 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001859 string output_file_contents;
1860 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1861}
1862
Devin Moore21b26772020-08-26 16:37:56 -07001863TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001864 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001865 const string list_array_parcelable =
1866 "package a; parcelable Foo {\n"
1867 " List[] lists; }";
1868 CaptureStderr();
1869 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1870 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1871}
1872
Jiyong Parkf8d53612020-05-04 14:06:13 +09001873TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1874 AidlError error;
1875 string expected_stderr =
1876 "ERROR: a/IFoo.aidl:2.7-11: "
1877 "Encountered an untyped List or Map. The use of untyped List/Map is "
1878 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1879 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1880 if (GetLanguage() != Options::Language::JAVA) {
1881 expected_stderr =
1882 "ERROR: a/IFoo.aidl:2.1-7: "
1883 "Currently, only the Java backend supports non-generic List.\n";
1884 }
1885
1886 const string primitive_interface =
1887 "package a; interface IFoo {\n"
1888 " List foo(); }";
1889 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001890 AidlTypenames tn1;
1891 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001892 {"--structured"}));
1893 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001894
1895 string primitive_parcelable =
1896 "package a; parcelable IFoo {\n"
1897 " List foo;}";
1898 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001899 AidlTypenames tn2;
1900 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001901 {"--structured"}));
1902 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1903}
1904
Jeongik Cha225519b2020-08-29 01:55:32 +09001905TEST_P(AidlTest, ExtensionTest) {
1906 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001907 string extendable_parcelable =
1908 "package a; parcelable Data {\n"
1909 " ParcelableHolder extension;\n"
1910 " ParcelableHolder extension2;\n"
1911 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001912 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001913 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1914 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001915 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001916 "yet.\n",
1917 GetCapturedStderr());
1918 } else {
1919 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1920 EXPECT_EQ("", GetCapturedStderr());
1921 }
1922}
1923TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1924 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001925 string parcelableholder_return_interface =
1926 "package a; interface IFoo {\n"
1927 " ParcelableHolder foo();\n"
1928 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001929 EXPECT_EQ(nullptr,
1930 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001931
Jeongik Cha8f02a532020-10-14 00:16:28 +09001932 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001933 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001934 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001935 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001936 "yet.\n",
1937 GetCapturedStderr());
1938 return;
1939 }
1940 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1941 GetCapturedStderr());
1942}
1943
1944TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1945 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001946 string extendable_parcelable_arg_interface =
1947 "package a; interface IFoo {\n"
1948 " void foo(in ParcelableHolder ph);\n"
1949 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001950 EXPECT_EQ(nullptr,
1951 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1952
Jeongik Cha8f02a532020-10-14 00:16:28 +09001953 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001954 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001955 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001956 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001957 "yet.\n",
1958 GetCapturedStderr());
1959 return;
1960 }
1961 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1962 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001963}
1964
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001965TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1966 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001967 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001968 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1969 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001970 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001971 if (GetLanguage() == Options::Language::RUST) {
1972 EXPECT_EQ(
1973 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1974 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1975 "yet.\n",
1976 GetCapturedStderr());
1977 return;
1978 }
1979 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1980}
1981
Jooyung Han3f347ca2020-12-01 12:41:50 +09001982TEST_P(AidlTest, ParcelablesWithConstants) {
1983 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001984 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001985 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001986 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001987 EXPECT_EQ("", GetCapturedStderr());
1988}
1989
1990TEST_P(AidlTest, UnionWithConstants) {
1991 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001992 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001993 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001994 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001995 EXPECT_EQ("", GetCapturedStderr());
1996}
1997
Jooyung Han633eab62021-01-07 14:12:40 +09001998TEST_F(AidlTest, ConstantsWithAnnotations) {
1999 io_delegate_.SetFileContents("IFoo.aidl",
2000 "interface IFoo {\n"
2001 " @JavaPassthrough(annotation=\"@Foo\")\n"
2002 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2003 "}");
2004 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2005 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002006 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002007 EXPECT_EQ("", GetCapturedStderr());
2008 string code;
2009 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2010 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2011 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2012}
2013
Jiyong Park02da7422018-07-16 16:00:26 +09002014TEST_F(AidlTest, ApiDump) {
2015 io_delegate_.SetFileContents(
2016 "foo/bar/IFoo.aidl",
2017 "package foo.bar;\n"
2018 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002019 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002020 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002021 " /* @hide applied \n"
2022 " @deprecated use foo2 */\n"
2023 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2024 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002025 " IFoo foo3(IFoo foo);\n"
2026 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002027 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002028 " /** blahblah\n"
2029 " @deprecated\n"
2030 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002031 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002032 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002033 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002034 "}\n");
2035 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2036 "package foo.bar;\n"
2037 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002038 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002039 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002040 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002041 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002042 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002043 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002044 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002045 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002046 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002047 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002048 "}\n");
2049 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002050 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2051 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002052 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002053 bool result = dump_api(options, io_delegate_);
2054 ASSERT_TRUE(result);
2055 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002056 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002057 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002058interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002059 /**
2060 * @hide
2061 * @deprecated use foo2
2062 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002063 int foo(out int[] a, String b, boolean c, inout List<String> d);
2064 int foo2(@utf8InCpp String x, inout List<String> y);
2065 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2066 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002067 /**
2068 * @deprecated reason why...
2069 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002070 const int A = 1;
2071 const String STR = "Hello";
2072}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002073)"),
2074 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002075
Jiyong Parke59c3682018-09-11 23:10:25 +09002076 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002077 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002078/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002079parcelable Data {
2080 int x = 10;
2081 int y;
2082 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002083 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002084}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002085)"),
2086 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002087}
2088
Jiyong Parked65bf42018-08-28 15:43:27 +09002089TEST_F(AidlTest, ApiDumpWithManualIds) {
2090 io_delegate_.SetFileContents(
2091 "foo/bar/IFoo.aidl",
2092 "package foo.bar;\n"
2093 "interface IFoo {\n"
2094 " int foo() = 1;\n"
2095 " int bar() = 2;\n"
2096 " int baz() = 10;\n"
2097 "}\n");
2098
Jiyong Parke59c3682018-09-11 23:10:25 +09002099 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002100 Options options = Options::From(args);
2101 bool result = dump_api(options, io_delegate_);
2102 ASSERT_TRUE(result);
2103 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002104 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002105 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002106interface IFoo {
2107 int foo() = 1;
2108 int bar() = 2;
2109 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002110}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002111)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002112}
2113
2114TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002115 const string expected_stderr =
2116 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2117 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002118 io_delegate_.SetFileContents(
2119 "foo/bar/IFoo.aidl",
2120 "package foo.bar;\n"
2121 "interface IFoo {\n"
2122 " int foo() = 1;\n"
2123 " int bar();\n"
2124 " int baz() = 10;\n"
2125 "}\n");
2126
Jiyong Parke59c3682018-09-11 23:10:25 +09002127 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002128 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002129 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002130 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002131 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002132}
2133
Jooyung Han965e31d2020-11-27 12:30:16 +09002134TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2135 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2136 "package foo.bar;\n"
2137 "interface IFoo {\n"
2138 " @utf8InCpp String foo();\n"
2139 " const @utf8InCpp String bar = \"bar\";\n"
2140 "}\n");
2141
2142 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2143 Options options = Options::From(args);
2144 CaptureStderr();
2145 EXPECT_TRUE(dump_api(options, io_delegate_));
2146 EXPECT_EQ("", GetCapturedStderr());
2147 string actual;
2148 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002149 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2150interface IFoo {
2151 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002152 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002153}
2154)"),
2155 actual);
2156}
2157
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002158TEST_F(AidlTest, ApiDumpWithEnums) {
2159 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2160 "package foo.bar;\n"
2161 "enum Enum {\n"
2162 " FOO,\n"
2163 " BAR = FOO + 1,\n"
2164 "}\n");
2165
2166 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2167 Options options = Options::From(args);
2168 CaptureStderr();
2169 EXPECT_TRUE(dump_api(options, io_delegate_));
2170 EXPECT_EQ("", GetCapturedStderr());
2171 string actual;
2172 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2173 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2174 "enum Enum {\n"
2175 " FOO = 0,\n"
2176 " BAR = 1,\n"
2177 "}\n"),
2178 actual);
2179}
2180
2181TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2182 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2183 "package foo.bar;\n"
2184 "enum Enum {\n"
2185 " FOO,\n"
2186 "}\n");
2187 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2188 "package foo.bar;\n"
2189 "import foo.bar.Enum;\n"
2190 "parcelable Foo {\n"
2191 " Enum e = Enum.FOO;\n"
2192 "}\n");
2193
2194 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2195 Options options = Options::From(args);
2196 CaptureStderr();
2197 EXPECT_TRUE(dump_api(options, io_delegate_));
2198 EXPECT_EQ("", GetCapturedStderr());
2199 string actual;
2200 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2201 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2202 "parcelable Foo {\n"
2203 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2204 "}\n"),
2205 actual);
2206}
2207
Jooyung Han71dfec32021-05-23 07:18:58 +09002208TEST_F(AidlTest, ApiDumpWithGenerics) {
2209 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2210 "package foo.bar;\n"
2211 "parcelable Foo<T, U> {\n"
2212 "}\n");
2213
2214 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2215 Options options = Options::From(args);
2216 CaptureStderr();
2217 EXPECT_TRUE(dump_api(options, io_delegate_));
2218 EXPECT_EQ("", GetCapturedStderr());
2219 string actual;
2220 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2221 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2222 "parcelable Foo<T, U> {\n"
2223 "}\n"),
2224 actual);
2225}
2226
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002227TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2228 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2229 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2230
2231 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2232 Options options = Options::From(args);
2233 CaptureStderr();
2234 EXPECT_FALSE(dump_api(options, io_delegate_));
2235 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2236}
2237
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002238TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002239 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002240 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2241 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002242 const string expected_map_stderr =
2243 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002244 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2245 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002246 "package p; interface IFoo {"
2247 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002248 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002249 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002250 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002251
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002252 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002253 "package p; interface IFoo {"
2254 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002255 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002256 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002257 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002258}
2259
Jeongik Chae48d9942020-01-02 17:39:00 +09002260TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002261 const string expected_stderr =
2262 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002263 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002264 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2265
2266 io_delegate_.SetFileContents("p/IFoo.aidl",
2267 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002268 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002269 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002270
2271 io_delegate_.SetFileContents("p/IFoo.aidl",
2272 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002273 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002274 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002275 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002276 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002277
2278 io_delegate_.SetFileContents("p/IFoo.aidl",
2279 "package p; interface IFoo {"
2280 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002281 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002282
2283 io_delegate_.SetFileContents("p/IFoo.aidl",
2284 "package p; interface IFoo {"
2285 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002286 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002287}
2288
Jeongik Chadf76dc72019-11-28 00:08:47 +09002289TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002290 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002291 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2292 io_delegate_.SetFileContents(options.InputFiles().front(),
2293 "package p; interface IFoo {"
2294 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002295 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002296 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002297 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002298}
2299
2300TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002301 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002302 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002304 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002305 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2306 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002307
Jooyung Han13f1fa52021-06-11 18:06:12 +09002308 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002309 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2310 io_delegate_.SetFileContents("p/IFoo.aidl",
2311 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002312 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002313 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002314 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002316 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002317 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002318 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002319 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002320 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002321 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002322 io_delegate_.SetFileContents("p/IFoo.aidl",
2323 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002324 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002325 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002326
2327 io_delegate_.SetFileContents("p/IFoo.aidl",
2328 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002329 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002330
2331 io_delegate_.SetFileContents("p/IFoo.aidl",
2332 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002333 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002334
Steven Moreland4e059132021-08-11 13:36:30 -07002335 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002336}
2337
Jeongik Cha0e426012019-07-29 15:57:02 +09002338TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2339 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002340 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2341 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002342 for (const auto& rawOption : rawOptions) {
2343 string expected_stderr =
2344 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002345 Options options = Options::From(rawOption);
2346 io_delegate_.SetFileContents(options.InputFiles().front(),
2347 "package foo.bar;\n"
2348 "interface IFoo1 { int foo(); }\n"
2349 "interface IFoo2 { int foo(); }\n"
2350 "parcelable Data1 { int a; int b;}\n"
2351 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002352 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002353 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002355
Jeongik Cha0e426012019-07-29 15:57:02 +09002356 io_delegate_.SetFileContents(options.InputFiles().front(),
2357 "package foo.bar;\n"
2358 "interface IFoo1 { int foo(); }\n"
2359 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002360 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002361 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002363
Devin Moore5de18ed2020-04-02 13:52:29 -07002364 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002365 io_delegate_.SetFileContents(options.InputFiles().front(),
2366 "package foo.bar;\n"
2367 "parcelable Data1 { int a; int b;}\n"
2368 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002370 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002371 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002372 }
2373}
2374
Devin Moorebdba2a82020-03-31 15:19:02 -07002375TEST_P(AidlTest, FailParseOnEmptyFile) {
2376 const string contents = "";
2377 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2378 CaptureStderr();
2379 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2381}
2382
Jiyong Parkb034bf02018-07-30 17:44:33 +09002383TEST_F(AidlTest, MultipleInputFiles) {
2384 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002385 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002386
2387 io_delegate_.SetFileContents(options.InputFiles().at(0),
2388 "package foo.bar;\n"
2389 "import foo.bar.Data;\n"
2390 "interface IFoo { Data getData(); }\n");
2391
2392 io_delegate_.SetFileContents(options.InputFiles().at(1),
2393 "package foo.bar;\n"
2394 "import foo.bar.IFoo;\n"
2395 "parcelable Data { IFoo foo; }\n");
2396
Steven Moreland4e059132021-08-11 13:36:30 -07002397 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002398
2399 string content;
2400 for (const auto file : {
2401 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2402 content.clear();
2403 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2404 EXPECT_FALSE(content.empty());
2405 }
2406}
2407
2408TEST_F(AidlTest, MultipleInputFilesCpp) {
2409 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002410 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002411
2412 io_delegate_.SetFileContents(options.InputFiles().at(0),
2413 "package foo.bar;\n"
2414 "import foo.bar.Data;\n"
2415 "interface IFoo { Data getData(); }\n");
2416
2417 io_delegate_.SetFileContents(options.InputFiles().at(1),
2418 "package foo.bar;\n"
2419 "import foo.bar.IFoo;\n"
2420 "parcelable Data { IFoo foo; }\n");
2421
Steven Moreland4e059132021-08-11 13:36:30 -07002422 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002423
2424 string content;
2425 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002426 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002427 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2428 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2429 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2430 content.clear();
2431 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2432 EXPECT_FALSE(content.empty());
2433 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002434}
2435
Andrei Homescub62afd92020-05-11 19:24:59 -07002436TEST_F(AidlTest, MultipleInputFilesRust) {
2437 Options options =
2438 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2439
2440 io_delegate_.SetFileContents(options.InputFiles().at(0),
2441 "package foo.bar;\n"
2442 "import foo.bar.Data;\n"
2443 "interface IFoo { Data getData(); }\n");
2444
2445 io_delegate_.SetFileContents(options.InputFiles().at(1),
2446 "package foo.bar;\n"
2447 "import foo.bar.IFoo;\n"
2448 "parcelable Data { IFoo foo; }\n");
2449
Steven Moreland4e059132021-08-11 13:36:30 -07002450 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002451
2452 string content;
2453 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2454 content.clear();
2455 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2456 EXPECT_FALSE(content.empty());
2457 }
2458}
2459
Devin Moore097a3ab2020-03-11 16:08:44 -07002460TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2461 const string expected_stderr =
2462 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002463 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2464 // int getInterfaceVersion() is one of the meta transactions
2465 io_delegate_.SetFileContents(options.InputFiles().front(),
2466 "package p; interface IFoo {"
2467 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002468 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002469 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2471}
Jiyong Park309668e2018-07-28 16:55:44 +09002472
Devin Moore097a3ab2020-03-11 16:08:44 -07002473TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2474 // boolean getInterfaceVersion() is not a meta transaction, but should be
2475 // prevented because return type is not part of a method signature
2476 const string expected_stderr =
2477 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2478 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002479 io_delegate_.SetFileContents(options.InputFiles().front(),
2480 "package p; interface IFoo {"
2481 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002483 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2485}
Jiyong Park309668e2018-07-28 16:55:44 +09002486
Devin Moore097a3ab2020-03-11 16:08:44 -07002487TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002488 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002489 const string expected_stderr =
2490 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2491 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002492 io_delegate_.SetFileContents(options.InputFiles().front(),
2493 "package p; interface IFoo {"
2494 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002495 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002496 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002497 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002498
2499 // this is not a meta interface method as it differs type arguments
2500 io_delegate_.SetFileContents(options.InputFiles().front(),
2501 "package p; interface IFoo {"
2502 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002503 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002504}
2505
Jooyung Hanb8a97772021-01-19 01:27:38 +09002506TEST_F(AidlTest, CheckApiForEquality) {
2507 CaptureStderr();
2508 Options options = Options::From("aidl --checkapi=equal old new");
2509
2510 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2511 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2512 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2513 "package p; interface IFoo{ @utf8InCpp String foo();}");
2514
2515 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2516 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2517}
2518
Daniel Norman85aed542019-08-21 12:01:14 -07002519TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002520 Options options = Options::From("aidl --checkapi old new");
2521 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2522 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2523 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2524 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2525
2526 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2527}
2528
Jiyong Park3656c3c2018-08-01 20:02:01 +09002529TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002530 Options options = Options::From("aidl --checkapi old new");
2531 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2532 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002533
2534 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2535}
2536
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002537TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2538 Options options = Options::From("aidl --checkapi old new");
2539 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2540 const string enum_definition = "package p; enum Enum { FOO }";
2541 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2542 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2543 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2544 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2545
2546 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2547}
2548
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002549TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2550 Options options = Options::From("aidl --checkapi old new -I import");
2551
2552 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2553 io_delegate_.SetFileContents("new/p/Foo.aidl",
2554 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2555 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2556
2557 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2558}
2559
Jooyung Han02a11be2021-02-11 13:18:06 +09002560TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2561 Options options = Options::From("aidl --checkapi=equal old new");
2562 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2563 const string enum_definition = "package p; enum Enum { FOO }";
2564 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2565 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2566 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2567 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2568 CaptureStderr();
2569 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2570 EXPECT_EQ("", GetCapturedStderr());
2571}
2572
Daniel Norman85aed542019-08-21 12:01:14 -07002573class AidlTestCompatibleChanges : public AidlTest {
2574 protected:
2575 Options options_ = Options::From("aidl --checkapi old new");
2576};
2577
2578TEST_F(AidlTestCompatibleChanges, NewType) {
2579 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2580 "package p;"
2581 "interface IFoo {"
2582 " void foo(int a);"
2583 "}");
2584 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2585 "package p;"
2586 "interface IFoo {"
2587 " void foo(int a);"
2588 "}");
2589 io_delegate_.SetFileContents("new/p/IBar.aidl",
2590 "package p;"
2591 "interface IBar {"
2592 " void bar();"
2593 "}");
2594 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2595}
2596
2597TEST_F(AidlTestCompatibleChanges, NewMethod) {
2598 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2599 "package p;"
2600 "interface IFoo {"
2601 " void foo(int a);"
2602 "}");
2603 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2604 "package p;"
2605 "interface IFoo {"
2606 " void foo(int a);"
2607 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002608 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002609 "}");
2610 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2611}
2612
2613TEST_F(AidlTestCompatibleChanges, NewField) {
2614 io_delegate_.SetFileContents("old/p/Data.aidl",
2615 "package p;"
2616 "parcelable Data {"
2617 " int foo;"
2618 "}");
2619 io_delegate_.SetFileContents("new/p/Data.aidl",
2620 "package p;"
2621 "parcelable Data {"
2622 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002623 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002624 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002625 "}");
2626 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2627}
2628
Jooyung Han05bd8a82021-04-28 23:56:38 +09002629TEST_F(AidlTestCompatibleChanges, NewField2) {
2630 io_delegate_.SetFileContents("old/p/Data.aidl",
2631 "package p;"
2632 "parcelable Data {"
2633 "}");
2634 io_delegate_.SetFileContents("new/p/Data.aidl",
2635 "package p;"
2636 "parcelable Data {"
2637 " int foo = 0;"
2638 "}");
2639 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2640}
2641
Daniel Norman85aed542019-08-21 12:01:14 -07002642TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2643 io_delegate_.SetFileContents("old/p/Enum.aidl",
2644 "package p;"
2645 "enum Enum {"
2646 " FOO = 1,"
2647 "}");
2648 io_delegate_.SetFileContents("new/p/Enum.aidl",
2649 "package p;"
2650 "enum Enum {"
2651 " FOO = 1,"
2652 " BAR = 2,"
2653 "}");
2654 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2655}
2656
2657TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2658 io_delegate_.SetFileContents("old/p/Enum.aidl",
2659 "package p;"
2660 "enum Enum {"
2661 " FOO = 1,"
2662 " BAR = 2,"
2663 "}");
2664 io_delegate_.SetFileContents("new/p/Enum.aidl",
2665 "package p;"
2666 "enum Enum {"
2667 " BAR = 2,"
2668 " FOO = 1,"
2669 "}");
2670 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2671}
2672
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002673TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2674 io_delegate_.SetFileContents("old/p/Union.aidl",
2675 "package p;"
2676 "union Union {"
2677 " String foo;"
2678 "}");
2679 io_delegate_.SetFileContents("new/p/Union.aidl",
2680 "package p;"
2681 "union Union {"
2682 " String foo;"
2683 " int num;"
2684 "}");
2685 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2686}
2687
Daniel Norman85aed542019-08-21 12:01:14 -07002688TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002689 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2690 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002691 "interface IFoo {"
2692 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002693 "}");
2694 io_delegate_.SetFileContents("old/p/Data.aidl",
2695 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002696 "parcelable Data {"
2697 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002698 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002699 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2700 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002701 "interface IFoo {"
2702 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002703 "}");
2704 io_delegate_.SetFileContents("new/p/Data.aidl",
2705 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002706 "parcelable Data {"
2707 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002708 "}");
2709 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2710 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002711 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002712 " void foo(int a);"
2713 "}");
2714 io_delegate_.SetFileContents("new/q/Data.aidl",
2715 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002716 "parcelable Data {"
2717 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002718 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002719 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2720}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002721
Daniel Norman85aed542019-08-21 12:01:14 -07002722TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2723 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2724 "package p;"
2725 "interface IFoo {"
2726 " void foo(int a);"
2727 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002728 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2729 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002730 "interface IFoo {"
2731 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002732 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002733 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2734}
Jiyong Parke59c3682018-09-11 23:10:25 +09002735
Daniel Norman85aed542019-08-21 12:01:14 -07002736TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002737 io_delegate_.SetFileContents("old/p/I.aidl",
2738 "package p; interface I {"
2739 "const int A = 1; }");
2740 io_delegate_.SetFileContents("new/p/I.aidl",
2741 "package p ; interface I {"
2742 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002743 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2744}
Jiyong Parka428d212018-08-29 22:26:30 +09002745
Daniel Norman85aed542019-08-21 12:01:14 -07002746TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002747 io_delegate_.SetFileContents("old/p/I.aidl",
2748 "package p; interface I {"
2749 "const int A = 1; const int B = 2;}");
2750 io_delegate_.SetFileContents("new/p/I.aidl",
2751 "package p ; interface I {"
2752 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002753 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002754}
2755
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002756TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2757 io_delegate_.SetFileContents("old/p/Foo.aidl",
2758 "package p;"
2759 "@JavaPassthrough(annotation=\"Alice\")"
2760 "@JavaPassthrough(annotation=\"Bob\")"
2761 "parcelable Foo {}");
2762 io_delegate_.SetFileContents("new/p/Foo.aidl",
2763 "package p;"
2764 "@JavaPassthrough(annotation=\"Bob\")"
2765 "@JavaPassthrough(annotation=\"Alice\")"
2766 "parcelable Foo {}");
2767 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2768}
2769
Jooyung Han00073272020-11-27 14:20:20 +09002770TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2771 io_delegate_.SetFileContents("old/p/Foo.aidl",
2772 "package p;"
2773 "parcelable Foo {}");
2774 io_delegate_.SetFileContents("new/p/Foo.aidl",
2775 "package p;"
2776 "@JavaPassthrough(annotation=\"@Deprecated\")"
2777 "parcelable Foo {}");
2778 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2779}
2780
Jooyung Han636fd2f2020-10-22 11:33:45 +09002781TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2782 io_delegate_.SetFileContents("old/p/Data.aidl",
2783 "package p;"
2784 "parcelable Data {"
2785 " int num;"
2786 "}");
2787 io_delegate_.SetFileContents(
2788 "new/p/Data.aidl",
2789 "package p;"
2790 "parcelable Data {"
2791 " int num;"
2792 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2793 "}");
2794 io_delegate_.SetFileContents("new/p/Enum.aidl",
2795 "package p;"
2796 "enum Enum {"
2797 " FOO = 0,"
2798 " BAR = 1,"
2799 "}");
2800 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2801}
2802
Jooyung Han308bbe02021-04-27 12:09:59 +09002803TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2804 io_delegate_.SetFileContents("old/p/Data.aidl",
2805 "package p;\n"
2806 "parcelable Data {\n"
2807 " p.Enum e;\n"
2808 "}");
2809 io_delegate_.SetFileContents("old/p/Enum.aidl",
2810 "package p;\n"
2811 "enum Enum {\n"
2812 " FOO = 0,\n"
2813 " BAR = 1,\n"
2814 "}");
2815 io_delegate_.SetFileContents("new/p/Data.aidl",
2816 "package p;\n"
2817 "parcelable Data {\n"
2818 " p.Enum e = p.Enum.FOO;\n"
2819 "}");
2820 io_delegate_.SetFileContents("new/p/Enum.aidl",
2821 "package p;\n"
2822 "enum Enum {\n"
2823 " FOO = 0,\n"
2824 " BAR = 1,\n"
2825 "}");
2826 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2827}
2828
Daniel Norman85aed542019-08-21 12:01:14 -07002829class AidlTestIncompatibleChanges : public AidlTest {
2830 protected:
2831 Options options_ = Options::From("aidl --checkapi old new");
2832};
2833
2834TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002835 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002836 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2837 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002838 "interface IFoo {"
2839 " void foo(in String[] str);"
2840 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002841 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002842 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002843 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002844 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002845}
2846
2847TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002848 const string expected_stderr =
2849 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002850 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2851 "package p;"
2852 "interface IFoo {"
2853 " void foo(in String[] str);"
2854 " void bar(@utf8InCpp String str);"
2855 "}");
2856 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2857 "package p;"
2858 "interface IFoo {"
2859 " void foo(in String[] str);"
2860 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002861 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002862 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002863 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002864}
2865
Jiyong Parkf8d53612020-05-04 14:06:13 +09002866TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2867 const string expected_stderr =
2868 "ERROR: new/p/IFoo.aidl:1.61-65: "
2869 "Encountered an untyped List or Map. The use of untyped List/Map is "
2870 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2871 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2872 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2873 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2874 "package p;"
2875 "interface IFoo {"
2876 " void foo(in String[] str);"
2877 "}");
2878 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2879 "package p;"
2880 "interface IFoo {"
2881 " void foo(in String[] str);"
2882 " void bar(in List arg);"
2883 "}");
2884 CaptureStderr();
2885 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2886 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2887}
2888
2889TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2890 const string expected_stderr =
2891 "ERROR: new/p/Data.aidl:1.54-59: "
2892 "Encountered an untyped List or Map. The use of untyped List/Map is "
2893 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2894 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2895 "ERROR: new/p/Data.aidl: Failed to read.\n";
2896 io_delegate_.SetFileContents("old/p/Data.aidl",
2897 "package p;"
2898 "parcelable Data {"
2899 " int foo;"
2900 "}");
2901 io_delegate_.SetFileContents("new/p/Data.aidl",
2902 "package p;"
2903 "parcelable Data {"
2904 " int foo;"
2905 " @nullable List list;"
2906 "}");
2907 CaptureStderr();
2908 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2910}
2911
Daniel Norman85aed542019-08-21 12:01:14 -07002912TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002913 const string expected_stderr =
2914 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002915 io_delegate_.SetFileContents("old/p/Data.aidl",
2916 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002917 "parcelable Data {"
2918 " int foo;"
2919 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002920 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002921 io_delegate_.SetFileContents("new/p/Data.aidl",
2922 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002923 "parcelable Data {"
2924 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002925 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002926 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002927 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002928 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002929}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002930
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002931TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2932 const string expected_stderr =
2933 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2934 "backends. Please either provide a default value for this field or mark the field as "
2935 "@nullable. This value or a null value will be used automatically when an old version of "
2936 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2937 "order to make sure your code continues to be backwards compatible, make sure the default or "
2938 "null value does not cause a semantic change to this parcelable.\n";
2939 io_delegate_.SetFileContents("old/p/Data.aidl",
2940 "package p;"
2941 "parcelable Data {"
2942 " int num;"
2943 "}");
2944 io_delegate_.SetFileContents("new/p/Data.aidl",
2945 "package p;"
2946 "parcelable Data {"
2947 " int num;"
2948 " String str;"
2949 "}");
2950 CaptureStderr();
2951 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2952 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2953}
2954
Jooyung Han636fd2f2020-10-22 11:33:45 +09002955TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2956 const string expected_stderr =
2957 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2958 "Please make sure 'Enum' has '0' as a valid value.\n";
2959 io_delegate_.SetFileContents("old/p/Data.aidl",
2960 "package p;"
2961 "parcelable Data {"
2962 " int num;"
2963 "}");
2964 io_delegate_.SetFileContents("new/p/Data.aidl",
2965 "package p;"
2966 "parcelable Data {"
2967 " int num;"
2968 " p.Enum e;"
2969 "}");
2970 io_delegate_.SetFileContents("new/p/Enum.aidl",
2971 "package p;"
2972 "enum Enum {"
2973 " FOO = 1,"
2974 " BAR = 2,"
2975 "}");
2976 CaptureStderr();
2977 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2979}
2980
Daniel Norman85aed542019-08-21 12:01:14 -07002981TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002982 const string expected_stderr =
2983 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002984 io_delegate_.SetFileContents("old/p/Enum.aidl",
2985 "package p;"
2986 "enum Enum {"
2987 " FOO = 1,"
2988 " BAR = 2,"
2989 "}");
2990 io_delegate_.SetFileContents("new/p/Enum.aidl",
2991 "package p;"
2992 "enum Enum {"
2993 " BAR = 2,"
2994 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002995 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002996 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002997 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002998}
2999
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003000TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3001 const string expected_stderr =
3002 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3003 io_delegate_.SetFileContents("old/p/Union.aidl",
3004 "package p;"
3005 "union Union {"
3006 " String str;"
3007 " int num;"
3008 "}");
3009 io_delegate_.SetFileContents("new/p/Union.aidl",
3010 "package p;"
3011 "union Union {"
3012 " String str;"
3013 "}");
3014 CaptureStderr();
3015 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3017}
3018
Daniel Norman85aed542019-08-21 12:01:14 -07003019TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003020 const string expected_stderr =
3021 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003022 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3023 "package p;"
3024 "interface IFoo {"
3025 " void foo(in String[] str);"
3026 " void bar(@utf8InCpp String str);"
3027 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003028 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3029 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003030 "interface IFoo {"
3031 " void foo(in String[] str);"
3032 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003033 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003034 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003035 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003037}
3038
Daniel Norman85aed542019-08-21 12:01:14 -07003039TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003040 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003041 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3042 "package p;"
3043 "interface IFoo {"
3044 " void foo(in String[] str);"
3045 " void bar(@utf8InCpp String str);"
3046 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003047 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3048 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003049 "interface IFoo2 {"
3050 " void foo(in String[] str);"
3051 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003052 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003053 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003054 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003056}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003057
Daniel Norman85aed542019-08-21 12:01:14 -07003058TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003059 const string expected_stderr =
3060 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003061 io_delegate_.SetFileContents("old/p/Enum.aidl",
3062 "package p;"
3063 "enum Enum {"
3064 " FOO = 1,"
3065 " BAR = 2,"
3066 "}");
3067 io_delegate_.SetFileContents("new/p/Enum.aidl",
3068 "package p;"
3069 "enum Enum {"
3070 " FOO = 3,"
3071 " BAR = 2,"
3072 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003073 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003074 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003076}
3077
3078TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003079 const string expected_stderr =
3080 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3081 "from 0 to 1.\n"
3082 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3083 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003084 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3085 "package p;"
3086 "interface IFoo {"
3087 " void foo(in String[] str);"
3088 " void bar(@utf8InCpp String str);"
3089 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003090 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3091 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003092 "interface IFoo {"
3093 " void bar(@utf8InCpp String str);"
3094 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003095 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003096 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003097 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003098 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003099}
3100
3101TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003102 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003103 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3104 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003105 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003106 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003107 "parcelable Data {"
3108 " int foo;"
3109 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003110 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003111 io_delegate_.SetFileContents("new/p/Data.aidl",
3112 "package p;"
3113 "parcelable Data {"
3114 " int bar;"
3115 " int foo;"
3116 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003117 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003118 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003119 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003120}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003121
Daniel Norman85aed542019-08-21 12:01:14 -07003122TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003123 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003124 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003125 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003126 "interface IFoo {"
3127 " void foo(in String[] str);"
3128 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003129 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003130 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3131 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003132 "interface IFoo {"
3133 " void foo(out String[] str);"
3134 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003135 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003136 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003137 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003138 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003139}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003140
Daniel Norman85aed542019-08-21 12:01:14 -07003141TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003142 const string expected_stderr =
3143 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003144 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3145 "package p;"
3146 "interface IFoo {"
3147 " void foo(in String[] str);"
3148 " void bar(@utf8InCpp String str);"
3149 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003150 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3151 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003152 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003153 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003154 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003155 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003156 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003157 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003158 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003159}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003160
Daniel Norman85aed542019-08-21 12:01:14 -07003161TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003162 const string expected_stderr =
3163 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003164 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3165 "package p;"
3166 "interface IFoo {"
3167 " void foo(in String[] str);"
3168 " void bar(@utf8InCpp String str);"
3169 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003170 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3171 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003172 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003173 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003174 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003175 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003176 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003177 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003178 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003179}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003180
Jooyung Han60b2fde2020-10-29 15:12:40 +09003181TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3182 const string expected_stderr =
3183 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3184 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3185 io_delegate_.SetFileContents("old/p/Foo.aidl",
3186 "package p;"
3187 "@Backing(type=\"byte\")"
3188 "enum Foo {"
3189 " FOO, BAR,"
3190 "}");
3191 io_delegate_.SetFileContents("new/p/Foo.aidl",
3192 "package p;"
3193 "@Backing(type=\"long\")"
3194 "enum Foo {"
3195 " FOO, BAR,"
3196 "}");
3197 CaptureStderr();
3198 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3199 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3200}
3201
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003202TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3203 const string expected_stderr =
3204 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3205 "to @JavaPassthrough(annotation=\"Bob\")\n";
3206 io_delegate_.SetFileContents("old/p/Foo.aidl",
3207 "package p;"
3208 "@JavaPassthrough(annotation=\"Alice\")"
3209 "parcelable Foo {}");
3210 io_delegate_.SetFileContents("new/p/Foo.aidl",
3211 "package p;"
3212 "@JavaPassthrough(annotation=\"Bob\")"
3213 "parcelable Foo {}");
3214
3215 CaptureStderr();
3216 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3217 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3218}
3219
Devin Mooredb7ac512020-08-07 11:17:36 -07003220TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3221 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003222 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003223 io_delegate_.SetFileContents("old/p/Foo.aidl",
3224 "package p;"
3225 "parcelable Foo {"
3226 " int A;"
3227 "}");
3228 io_delegate_.SetFileContents("new/p/Foo.aidl",
3229 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003230 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003231 " int A;"
3232 "}");
3233 CaptureStderr();
3234 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3235 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3236}
3237
3238TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3239 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003240 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003241 io_delegate_.SetFileContents("old/p/Foo.aidl",
3242 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003243 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003244 " int A;"
3245 "}");
3246 io_delegate_.SetFileContents("new/p/Foo.aidl",
3247 "package p;"
3248 "parcelable Foo {"
3249 " int A;"
3250 "}");
3251 CaptureStderr();
3252 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3253 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3254}
3255
Daniel Norman85aed542019-08-21 12:01:14 -07003256TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003257 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003258 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3259 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003260 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003261 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003262 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003264}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003265
Daniel Norman85aed542019-08-21 12:01:14 -07003266TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003267 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003268 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3269 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003270 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003271 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003272 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003273}
Jiyong Parka428d212018-08-29 22:26:30 +09003274
Daniel Norman85aed542019-08-21 12:01:14 -07003275TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003276 const string expected_stderr =
3277 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003278 io_delegate_.SetFileContents("old/p/I.aidl",
3279 "package p; interface I {"
3280 "const int A = 1; const int B = 2;}");
3281 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003282 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003283 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003285}
Jiyong Parka428d212018-08-29 22:26:30 +09003286
Daniel Norman85aed542019-08-21 12:01:14 -07003287TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003288 const string expected_stderr =
3289 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003290 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3291 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003292 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003293 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003294 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003295}
3296
Devin Moorec7e47a32020-08-07 10:55:25 -07003297TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3298 const string expected_stderr =
3299 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3300 "This is an incompatible change for FixedSize types.\n";
3301 io_delegate_.SetFileContents("old/p/Foo.aidl",
3302 "package p; @FixedSize parcelable Foo { int A = 1; }");
3303 io_delegate_.SetFileContents("new/p/Foo.aidl",
3304 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3305 CaptureStderr();
3306 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3307 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3308}
3309
Jeongik Cha68d18e72021-04-29 20:07:01 +09003310TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3311 const string expected_stderr =
3312 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3313 "android.net.UidRangeParcel is changed from 1 to 2. "
3314 "But it is forbidden because of legacy support.\n";
3315 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3316 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3317 io_delegate_.SetFileContents(
3318 "new/android/net/UidRangeParcel.aidl",
3319 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3320 CaptureStderr();
3321 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3323}
3324
Devin Moorec7e47a32020-08-07 10:55:25 -07003325TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3326 const string expected_stderr =
3327 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3328 io_delegate_.SetFileContents("old/p/Foo.aidl",
3329 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3330 io_delegate_.SetFileContents("new/p/Foo.aidl",
3331 "package p; @FixedSize parcelable Foo { int A = 1; }");
3332 CaptureStderr();
3333 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3334 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3335}
3336
3337TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3338 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003339 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003340 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003341 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3342 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003343 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003344 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003345 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003346 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003347 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003348 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3349 "f.\n"
3350 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3351 "nullable1.\n"
3352 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3353 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003354
3355 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003356 "@FixedSize parcelable Foo {\n"
3357 " int[] a;\n"
3358 " Bar b;\n"
3359 " String c;\n"
3360 " ParcelFileDescriptor d;\n"
3361 " IBinder e;\n"
3362 " List<String> f;\n"
3363 " int isFixedSize;\n"
3364 " @nullable OtherFixed nullable1;\n"
3365 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003366 "}");
3367 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003368 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003369 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003370
3371 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003372 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3374}
3375
3376TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3377 const string expected_stderr = "";
3378
3379 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3380 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3381 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003382 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003383
3384 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003385 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003386 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3387}
3388
Jiyong Park8c380532018-08-30 14:55:26 +09003389TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003390 const string expected_stderr =
3391 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3392 "dir1/q/IBar.aidl\n"
3393 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003394 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003395 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3396 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3397 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3398 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3399
Devin Moore097a3ab2020-03-11 16:08:44 -07003400 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003401 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003403}
3404
Jiyong Parked65bf42018-08-28 15:43:27 +09003405TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003406 const string expected_stderr =
3407 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3408 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003409 Options options = Options::From("aidl --checkapi old new");
3410 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3411 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003412
3413 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3414
Jiyong Parke59c3682018-09-11 23:10:25 +09003415 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003416 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003417 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003418 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003419}
3420
Jooyung Han652ce482021-02-26 12:40:35 +09003421TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3422 Options options =
3423 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003424
3425 // use without import
3426 io_delegate_.SetFileContents("p/IFoo.aidl",
3427 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003428 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003429
3430 // capture output files
3431 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003432
Devin Moore7b8d5c92020-03-17 14:14:08 -07003433 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003434 io_delegate_.SetFileContents(
3435 "p/IFoo.aidl",
3436 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003437 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003438 // output files should be the same
3439 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003440
3441 // use with import (as before)
3442 io_delegate_.SetFileContents("p/IFoo.aidl",
3443 "package p;"
3444 "import android.os.ParcelFileDescriptor;"
3445 "interface IFoo{"
3446 " void foo(in ParcelFileDescriptor fd);"
3447 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003448 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003449 // output files should be the same
3450 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003451}
Jiyong Parked65bf42018-08-28 15:43:27 +09003452
Jooyung Han020d8d12021-02-26 17:23:02 +09003453TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3454 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3455 CaptureStderr();
3456 io_delegate_.SetFileContents("p/IFoo.aidl",
3457 "package p;"
3458 "interface IFoo{"
3459 " void foo(out ParcelFileDescriptor fd);"
3460 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003461 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003462 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3463}
3464
3465TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3466 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3467 CaptureStderr();
3468 io_delegate_.SetFileContents("p/IFoo.aidl",
3469 "package p;"
3470 "interface IFoo{"
3471 " void foo(ParcelFileDescriptor fd);"
3472 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003473 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003474 EXPECT_THAT(GetCapturedStderr(),
3475 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3476}
3477
Jiyong Park3633b722019-04-11 15:38:26 +09003478TEST_F(AidlTest, ManualIds) {
3479 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3480 io_delegate_.SetFileContents("IFoo.aidl",
3481 "interface IFoo {\n"
3482 " void foo() = 0;\n"
3483 " void bar() = 1;\n"
3484 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003485 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003486}
3487
3488TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3489 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3490 io_delegate_.SetFileContents("IFoo.aidl",
3491 "interface IFoo {\n"
3492 " void foo() = 0;\n"
3493 " void bar() = 1;\n"
3494 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003495 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003496}
3497
3498TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003499 const string expected_stderr =
3500 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003501 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3502 io_delegate_.SetFileContents("IFoo.aidl",
3503 "interface IFoo {\n"
3504 " void foo() = 3;\n"
3505 " void bar() = 3;\n"
3506 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003507 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003508 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003509 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003510}
3511
3512TEST_F(AidlTest, FailOnOutOfRangeIds) {
3513 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003514 const string expected_stderr =
3515 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3516 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003517 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3518 io_delegate_.SetFileContents("IFoo.aidl",
3519 "interface IFoo {\n"
3520 " void foo() = 3;\n"
3521 " void bar() = 16777115;\n"
3522 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003523 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003524 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003525 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003526}
3527
3528TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003529 const string expected_stderr =
3530 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003531 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3532 io_delegate_.SetFileContents("IFoo.aidl",
3533 "interface IFoo {\n"
3534 " void foo() = 3;\n"
3535 " void bar();\n"
3536 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003537 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003538 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003540}
3541
Jiyong Parkc6816252019-07-08 08:12:28 +09003542TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3543 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3544 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3545 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003546 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003547}
3548
3549TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003550 const string expected_stderr =
3551 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3552 "dir/IBar.aidl\n"
3553 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003554 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003555
Jiyong Parkc6816252019-07-08 08:12:28 +09003556 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3557 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3558 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3559 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003560 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003561 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003562 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003563}
3564
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003565TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3566 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3567 "package a.b;\n"
3568 "import a.b.IBar;\n"
3569 "import a.b.IQux;\n"
3570 "interface IFoo { IQux foo(); }\n");
3571 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3572 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3573
3574 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003575 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003576
3577 string output;
3578 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3579 // IBar was imported but wasn't used. include is not expected.
3580 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3581 // IBar was imported and used. include is expected.
3582 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3583}
3584
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003585TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003586 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003587 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003588 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3589 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003590 interface IFoo {
3591 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003592 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003593 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003594 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003595 // JavaPassthrough should work with other types as well (e.g. enum)
3596 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3597 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3598 @JavaPassthrough(annotation="@com.android.AliceTwo")
3599 @Backing(type="byte")
3600 enum MyEnum {
3601 a, b, c
3602 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003603
Jooyung Han4cde01d2020-10-13 11:10:47 +09003604 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003605 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003606
3607 string java_out;
3608 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003609 // type-decl-level annotations with newline at the end
3610 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3611 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3612 // member-decl-level annotations with newline at the end
3613 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3614 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3615 // inline annotations with space at the end
3616 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003617
Jooyung Han4cde01d2020-10-13 11:10:47 +09003618 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3619 // type-decl-level annotations with newline at the end
3620 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3621 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3622
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003623 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003624 Options cpp_options =
3625 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003626 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003627
Jooyung Han4cde01d2020-10-13 11:10:47 +09003628 Options ndk_options =
3629 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003630 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003631
Jooyung Han4cde01d2020-10-13 11:10:47 +09003632 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003633 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003634}
3635
Andrei Homescue61feb52020-08-18 15:44:24 -07003636TEST_F(AidlTest, ParseRustDerive) {
3637 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3638 @RustDerive(Clone=true, Copy=false)
3639 parcelable Foo {
3640 int a;
3641 })");
3642
3643 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003644 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003645
3646 string rust_out;
3647 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3648 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3649
3650 // Other backends shouldn't be bothered
3651 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003652 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003653
3654 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003655 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003656
3657 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003658 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003659}
3660
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003661TEST_F(AidlTest, EmptyEnforceAnnotation) {
3662 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3663 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3664 interface IFoo {
3665 @Enforce()
3666 void Protected();
3667 })");
3668
3669 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3670 CaptureStderr();
3671 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3672 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3673}
3674
3675TEST_F(AidlTest, EmptyEnforceCondition) {
3676 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3677 interface IFoo {
3678 @Enforce(condition="")
3679 void Protected();
3680 })");
3681
3682 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3683 CaptureStderr();
3684 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3685 EXPECT_THAT(GetCapturedStderr(),
3686 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3687}
3688
3689TEST_F(AidlTest, InvalidEnforceCondition) {
3690 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3691 interface IFoo {
3692 @Enforce(condition="invalid")
3693 void Protected();
3694 })");
3695
3696 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3697 CaptureStderr();
3698 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3699 EXPECT_THAT(GetCapturedStderr(),
3700 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3701}
3702
Jiyong Park56f73d72019-06-11 12:20:28 +09003703class AidlOutputPathTest : public AidlTest {
3704 protected:
3705 void SetUp() override {
3706 AidlTest::SetUp();
3707 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3708 }
3709
3710 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003711 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003712 // check the existence
3713 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3714 }
3715};
3716
3717TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3718 // <out_dir> / <package_name> / <type_name>.java
3719 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3720}
3721
3722TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3723 // when output file is explicitly set, it is always respected. -o option is
3724 // ignored.
3725 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3726}
3727
3728TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3729 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3730}
3731
3732TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3733 // output is the same as the input file except for the suffix
3734 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3735}
3736
Devin Moore7b8d5c92020-03-17 14:14:08 -07003737TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003738 AidlError error;
3739 const string expected_stderr =
3740 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3741 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003742 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3743 R"(package p;
3744 interface IFoo {
3745 const int int32_max_oob = 2147483650;
3746 }
3747 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003748 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003749 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3750 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003751}
3752
Devin Moore7b8d5c92020-03-17 14:14:08 -07003753TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003754 AidlError error;
3755 const string expected_stderr =
3756 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3757 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003758 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3759 R"(package p;
3760 interface IFoo {
3761 const int int32_min_oob = -2147483650;
3762 }
3763 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003764 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003765 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3766 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003767}
3768
Devin Moore7b8d5c92020-03-17 14:14:08 -07003769TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003770 AidlError error;
3771 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003772 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003773 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003774 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3775 R"(package p;
3776 interface IFoo {
3777 const long int64_max_oob = 21474836509999999999999999;
3778 }
3779 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003780 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003781 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3782 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003783}
3784
Devin Moore7b8d5c92020-03-17 14:14:08 -07003785TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003786 AidlError error;
3787 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003788 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003789 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003790 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3791 R"(package p;
3792 interface IFoo {
3793 const long int64_min_oob = -21474836509999999999999999;
3794 }
3795 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003796 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003797 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3798 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003799}
3800
Devin Moore7b8d5c92020-03-17 14:14:08 -07003801TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003802 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003803 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003804 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003805 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3806 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003807 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3808 R"(package p;
3809 @Backing(type="byte")
3810 enum TestEnum {
3811 FOO = 127,
3812 BAR,
3813 }
3814 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003815 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003816 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003817 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003818}
3819
Devin Mooredecaf292020-04-30 09:16:40 -07003820TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3821 AidlError error;
3822 const string expected_stderr =
3823 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003824 "be one of: type\n";
3825 CaptureStderr();
3826 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3827 R"(package p;
3828 @Backing(foo="byte")
3829 enum TestEnum {
3830 FOO = 1,
3831 BAR,
3832 }
3833 )",
3834 typenames_, GetLanguage(), &error));
3835 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3836 EXPECT_EQ(AidlError::BAD_TYPE, error);
3837}
3838
Jooyung Han5721a232020-12-24 04:34:55 +09003839TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3840 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3841 CaptureStderr();
3842 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3843 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3844}
3845
Jooyung Han66813932020-10-23 13:24:44 +09003846TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003847 io_delegate_.SetFileContents("Foo.aidl",
3848 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3849 "Map<String, Baz> d; Bar[] e; }");
3850 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3851 io_delegate_.SetFileContents("Baz.aidl",
3852 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003853 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003854 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003855}
3856
Jooyung Han66813932020-10-23 13:24:44 +09003857TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003858 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003859 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003860 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003861 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3862 "named 'bar'.\n";
3863 CaptureStderr();
3864 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003865 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003866 EXPECT_EQ(expected_error, GetCapturedStderr());
3867}
3868
Jooyung Han09e551c2021-05-11 11:44:48 +09003869TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3870 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3871 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3872 CaptureStderr();
3873 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003874 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003875 EXPECT_EQ("", GetCapturedStderr());
3876}
3877
Jooyung Han59af9cc2020-10-25 21:44:14 +09003878TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3879 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3880 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3881 string expected_error =
3882 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003883 "named 'bar'.\n";
3884 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003885 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003886 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003887 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003888}
3889
Jooyung Han66813932020-10-23 13:24:44 +09003890TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003891 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003892 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3893 string expected_error =
3894 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3895 "only be an in parameter.\n";
3896 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003897 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003898 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003899 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003900}
3901
Jooyung Han66813932020-10-23 13:24:44 +09003902TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003903 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003904 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3905 string expected_error =
3906 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3907 "only be an in parameter.\n";
3908 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003909 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003910 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003911 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003912}
3913
Jooyung Han66813932020-10-23 13:24:44 +09003914TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003915 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003916 Options options = Options::From("aidl --lang=java Foo.aidl");
3917 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003918 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3919 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003921 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003922 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3923}
Devin Moore53fc99c2020-08-12 08:07:52 -07003924
Jooyung Hanfe086af2021-01-16 03:44:47 +09003925TEST_P(AidlTest, UnionInUnion) {
3926 import_paths_.insert(".");
3927 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3928 CaptureStderr();
3929 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3930 EXPECT_THAT("", GetCapturedStderr());
3931}
3932
Jooyung Hanfe89f122020-10-14 03:49:18 +09003933TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3934 const string method = "package a; union Foo {}";
3935 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3936 CaptureStderr();
3937 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3938 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3939}
3940
3941TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3942 const string method = "package a; union Foo { ParcelableHolder x; }";
3943 const string expected_stderr =
3944 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3945 CaptureStderr();
3946 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3947 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3948}
3949
Jooyung Han53fb4242020-12-17 16:03:49 +09003950TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3951 import_paths_.insert(".");
3952 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3953 const string expected_err = "The union's first member should have a useful default value.";
3954 CaptureStderr();
3955 EXPECT_EQ(nullptr,
3956 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3957 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3958}
3959
Devin Moore53fc99c2020-08-12 08:07:52 -07003960TEST_P(AidlTest, GenericStructuredParcelable) {
3961 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003962 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003963 const string expected_stderr = "";
3964 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003965 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3967}
3968
Jooyung Han3f347ca2020-12-01 12:41:50 +09003969TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3970 io_delegate_.SetFileContents("Foo.aidl",
3971 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3972 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003973 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003974 const string expected_stderr = "";
3975 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003976 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003977 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3978
3979 string code;
3980 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3981 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3982const ::android::String16& Foo<T,U>::s() {
3983 static const ::android::String16 value(::android::String16(""));
3984 return value;
3985})--"));
3986}
3987
3988TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3989 io_delegate_.SetFileContents("Foo.aidl",
3990 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3991 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003992 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003993 const string expected_stderr = "";
3994 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003995 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003996 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3997
3998 string code;
3999 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4000 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4001const char* Foo<T, U>::s = "";
4002)--"));
4003}
4004
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004005TEST_F(AidlTest, NestedTypeArgs) {
4006 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004007 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4008
4009 io_delegate_.SetFileContents("a/Foo.aidl",
4010 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4011 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004012 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4013 const string expected_stderr = "";
4014 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004015 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4017
4018 string code;
4019 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004020 EXPECT_THAT(code,
4021 testing::HasSubstr(
4022 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4023}
4024
4025TEST_F(AidlTest, DoubleArrayError) {
4026 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4027
4028 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4029 const string expected_stderr =
4030 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4031 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004032 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004033 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4034}
4035
4036TEST_F(AidlTest, DoubleGenericError) {
4037 io_delegate_.SetFileContents("a/Bar.aidl",
4038 "package a; parcelable Bar { List<String><String> a; }");
4039
4040 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4041 const string expected_stderr =
4042 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4043 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004044 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004045 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4046}
4047
4048TEST_F(AidlTest, ArrayBeforeGenericError) {
4049 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4050
4051 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004052 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004053 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004054 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4055}
4056
4057TEST_F(AidlTest, NullableArraysAreNotSupported) {
4058 io_delegate_.SetFileContents("a/Bar.aidl",
4059 "package a; parcelable Bar { String @nullable [] a; }");
4060
4061 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4062 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004063 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004064 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4065}
4066
4067TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4068 io_delegate_.SetFileContents("a/Bar.aidl",
4069 "package a; parcelable Bar { List<@nullable String> a; }");
4070
4071 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4072 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004073 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004074 EXPECT_THAT(GetCapturedStderr(),
4075 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004076}
4077
Jooyung Han14004ed2020-10-16 03:49:57 +09004078struct GenericAidlTest : ::testing::Test {
4079 FakeIoDelegate io_delegate_;
4080 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004081 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004082 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4083 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4084 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4085
4086 Options options = Options::From(cmd);
4087 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004088 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004089 EXPECT_EQ("", GetCapturedStderr());
4090 }
4091};
4092
4093TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4094 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4095 string code;
4096 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4097 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4098 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4099 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4100}
4101
4102TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4103 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4104 string code;
4105 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4106 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4107 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4108 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4109}
4110
Devin Moore53fc99c2020-08-12 08:07:52 -07004111TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4112 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004113 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004114 const string expected_stderr =
4115 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4116 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004117 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4119}
4120
4121TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4122 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004123 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004124 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4125 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004126 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004127 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4128}
4129
Jooyung Han7a308842020-10-27 19:06:49 +09004130TEST_P(AidlTest, LongCommentWithinConstExpression) {
4131 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004132 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004133 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004134 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004135 EXPECT_EQ("", GetCapturedStderr());
4136}
4137
Jeongik Chaef44e622020-10-23 16:00:52 +09004138TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4139 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4140 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4141 std::string expectedErr =
4142 "ERROR: a/Foo.aidl:1.28-30: "
4143 "Encountered an untyped List or Map. The use of untyped List/Map is "
4144 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4145 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4146 "ERROR: a/Foo.aidl:1.35-37: "
4147 "Encountered an untyped List or Map. The use of untyped List/Map is "
4148 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4149 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4150 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004151 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004152 EXPECT_EQ(expectedErr, GetCapturedStderr());
4153}
4154
4155TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004156 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4157 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004158 std::string expectedErr =
4159 "ERROR: a/Foo.aidl:1.33-35: "
4160 "Encountered an untyped List or Map. The use of untyped List/Map is "
4161 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4162 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4163 "ERROR: a/Foo.aidl:1.40-42: "
4164 "Encountered an untyped List or Map. The use of untyped List/Map is "
4165 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4166 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004167 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004168 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004169 EXPECT_EQ(expectedErr, GetCapturedStderr());
4170}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004171
Jeongik Chaef44e622020-10-23 16:00:52 +09004172TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4173 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4174 io_delegate_.SetFileContents(
4175 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4176 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4177 std::string expectedErr =
4178 "ERROR: a/Foo.aidl:1.52-54: "
4179 "Encountered an untyped List or Map. The use of untyped List/Map is "
4180 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4181 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4182 "ERROR: a/Foo.aidl:1.64-66: "
4183 "Encountered an untyped List or Map. The use of untyped List/Map is "
4184 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4185 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4186 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004187 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004188 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004189}
4190
Jooyung Han690f5842020-12-04 13:02:04 +09004191TEST_F(AidlTest, EnumWithDefaults_Java) {
4192 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4193 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4194package p;
4195import p.Enum;
4196parcelable Foo {
4197 Enum e = Enum.BAR;
4198})");
4199 CaptureStderr();
4200 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004201 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004202 auto err = GetCapturedStderr();
4203 EXPECT_EQ("", err);
4204
4205 string code;
4206 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004207 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004208}
4209
4210TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4211 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4212 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4213package p;
4214import p.Enum;
4215parcelable Foo {
4216 Enum e = Enum.BAR;
4217})");
4218 CaptureStderr();
4219 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004220 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004221 auto err = GetCapturedStderr();
4222 EXPECT_EQ("", err);
4223
4224 string code;
4225 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4226 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4227}
4228
4229TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4230 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4231 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4232package p;
4233import p.Enum;
4234parcelable Foo {
4235 Enum e = Enum.BAR;
4236})");
4237 CaptureStderr();
4238 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004239 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004240 auto err = GetCapturedStderr();
4241 EXPECT_EQ("", err);
4242
4243 string code;
4244 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4245 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4246}
4247
4248TEST_F(AidlTest, EnumWithDefaults_Rust) {
4249 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4250 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4251package p;
4252import p.Enum;
4253parcelable Foo {
4254 int n = 42;
4255 Enum e = Enum.BAR;
4256})");
4257 CaptureStderr();
4258 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004259 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004260 auto err = GetCapturedStderr();
4261 EXPECT_EQ("", err);
4262
4263 string code;
4264 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4265 EXPECT_THAT(code, testing::HasSubstr(R"(
4266 fn default() -> Self {
4267 Self {
4268 n: 42,
4269 e: crate::mangled::_1_p_4_Enum::BAR,
4270 }
4271 })"));
4272}
4273
4274TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4275 import_paths_.insert("a");
4276 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4277 CaptureStderr();
4278 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4279package p;
4280import p.Enum;
4281parcelable Foo {
4282 int e = Enum.FOO | Enum.BAR;
4283})",
4284 typenames_, GetLanguage());
4285 auto err = GetCapturedStderr();
4286 EXPECT_EQ("", err);
4287 EXPECT_TRUE(type);
4288 const auto& fields = type->AsStructuredParcelable()->GetFields();
4289 EXPECT_EQ("int e = 3", fields[0]->ToString());
4290}
4291
4292TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4293 CaptureStderr();
4294 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4295@Backing(type="int")
4296enum Foo {
4297 STANDARD_SHIFT = 16,
4298 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4299 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4300}
4301)",
4302 typenames_, GetLanguage());
4303 auto err = GetCapturedStderr();
4304 EXPECT_EQ("", err);
4305 EXPECT_TRUE(type);
4306 const auto& enum_type = type->AsEnumDeclaration();
4307 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004308 auto writer = CodeWriter::ForString(&code);
4309 DumpVisitor visitor(*writer);
4310 visitor.Visit(*enum_type);
4311 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004312 EXPECT_EQ(R"--(@Backing(type="int")
4313enum Foo {
4314 STANDARD_SHIFT = 16,
4315 STANDARD_BT709 = 65536,
4316 STANDARD_BT601_625 = 131072,
4317}
4318)--",
4319 code);
4320}
4321
4322TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4323 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4324 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4325package p;
4326import p.Enum;
4327parcelable Foo {
4328 Enum e = Enum.FOO | Enum.BAR;
4329})");
4330 CaptureStderr();
4331 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004332 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004333 auto err = GetCapturedStderr();
4334 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4335 err);
4336}
4337
Jooyung Han361cd102021-05-24 11:30:10 +09004338TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4339 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4340 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4341package p;
4342import p.Enum;
4343parcelable Foo {
4344 Enum e = 1;
4345})");
4346 CaptureStderr();
4347 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004348 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004349 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4350}
4351
Jooyung Han690f5842020-12-04 13:02:04 +09004352TEST_P(AidlTest, DefaultWithEmptyArray) {
4353 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4354 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4355 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004356 auto options =
4357 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004358 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004359 auto err = GetCapturedStderr();
4360 EXPECT_EQ("", err);
4361}
4362
4363TEST_P(AidlTest, RejectRefsInAnnotation) {
4364 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4365 "package p; interface IFoo {\n"
4366 " const String ANNOTATION = \"@Annotation\";\n"
4367 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4368 "}");
4369 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004370 auto options =
4371 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004372 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004373 auto err = GetCapturedStderr();
4374 EXPECT_EQ(
4375 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4376 "ANNOTATION.\n",
4377 err);
4378}
4379
4380TEST_F(AidlTest, DefaultWithEnumValues) {
4381 io_delegate_.SetFileContents(
4382 "a/p/Foo.aidl",
4383 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4384 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4385 CaptureStderr();
4386 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004387 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004388 auto err = GetCapturedStderr();
4389 EXPECT_EQ("", err);
4390 string code;
4391 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4392 EXPECT_THAT(
4393 code, testing::HasSubstr(
4394 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4395}
4396
Jooyung Han14259392020-12-07 10:00:08 +09004397TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4398 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4399 CaptureStderr();
4400 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004401 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004402 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004403 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004404}
4405
4406TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4407 io_delegate_.SetFileContents("a/p/Foo.aidl",
4408 "package p; parcelable Foo { const int A = A + 1; }");
4409 CaptureStderr();
4410 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004411 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004412 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004413 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4414}
4415
4416TEST_F(AidlTest, RecursiveReferences) {
4417 io_delegate_.SetFileContents("a/p/Foo.aidl",
4418 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4419 io_delegate_.SetFileContents("a/p/Bar.aidl",
4420 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4421 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4422 CaptureStderr();
4423 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004424 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004425 EXPECT_EQ("", GetCapturedStderr());
4426}
4427
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004428TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4429 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4430 auto options =
4431 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4432 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4433 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004434 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004435 EXPECT_EQ(err, GetCapturedStderr());
4436}
4437
4438TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4439 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4440 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4441 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4442 auto options =
4443 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4444 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004445 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004446 EXPECT_EQ("", GetCapturedStderr());
4447}
4448
Jooyung Hane9f5b272021-01-07 00:18:11 +09004449TEST_P(AidlTest, UnknownConstReference) {
4450 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4451 auto options =
4452 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4453 const string err =
4454 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4455 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4456 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4457 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004458 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004459 EXPECT_EQ(err, GetCapturedStderr());
4460}
4461
Jooyung Han29813842020-12-08 01:28:03 +09004462TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4463 string contents = R"(
4464import android.os.IBinder;
4465import android.os.IInterface;
4466interface IFoo {}
4467 )";
4468 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004469}
4470
Jooyung Han888c5bc2020-12-22 17:28:47 +09004471TEST_P(AidlTest, WarningInterfaceName) {
4472 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004473 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004474 " -Weverything -o out -h out p/Foo.aidl");
4475 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004476 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004477 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004478 GetCapturedStderr());
4479}
4480
4481TEST_P(AidlTest, ErrorInterfaceName) {
4482 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004483 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004484 " -Weverything -Werror -o out -h out p/Foo.aidl");
4485 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004486 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004487 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004488 GetCapturedStderr());
4489}
4490
Jiyong Park9f4c3822021-04-07 20:36:45 +09004491TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4492 const std::string input_file = "base/p/q/IFoo.aidl";
4493 const std::string header_dir = "out/";
4494 const std::string output_file = "out/base/p/q/IFoo.cpp";
4495 const std::string package = "p.q"; // not base.p.q
4496 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4497
4498 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4499 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004500 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004501 EXPECT_THAT(
4502 GetCapturedStderr(),
4503 testing::StartsWith(
4504 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4505 "but is out/base/p/q/IFoo.cpp."));
4506}
4507
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004508TEST_F(AidlTest, FormatCommentsForJava) {
4509 using android::aidl::FormatCommentsForJava;
4510
4511 struct TestCase {
4512 vector<Comment> comments;
4513 string formatted;
4514 };
4515 vector<TestCase> testcases = {
4516 {{}, ""},
4517 {{{"// line comments\n"}}, "// line comments\n"},
4518 {{{"// @hide \n"}}, "// @hide \n"},
4519 // Transform the last block comment as Javadoc.
4520 {{{"/*\n"
4521 " * Hello, world!\n"
4522 " */"}},
4523 "/**\n"
4524 " * Hello, world!\n"
4525 " */"},
4526 {{{"/* @hide */"}}, "/** @hide */"},
4527 {{{"/**\n"
4528 " @param foo ...\n"
4529 "*/"}},
4530 "/**\n"
4531 " @param foo ...\n"
4532 "*/"},
4533 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4534 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4535 "/* @deprecated first *//** @deprecated second */"},
4536 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4537 // Line comments are printed as they are
4538 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4539 };
4540 for (const auto& [input, formatted] : testcases) {
4541 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4542 }
4543}
4544
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004545TEST_F(AidlTest, HideIsNotForArgs) {
4546 io_delegate_.SetFileContents("IFoo.aidl",
4547 "interface IFoo {\n"
4548 " void foo(in @Hide int x);\n"
4549 "}");
4550 auto options = Options::From("aidl --lang=java IFoo.aidl");
4551 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004552 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004553 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4554}
4555
4556TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4557 io_delegate_.SetFileContents(
4558 "IFoo.aidl",
4559 "interface IFoo {\n"
4560 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4561 "}");
4562 auto options = Options::From("aidl --lang=java IFoo.aidl");
4563 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004564 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004565 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4566}
4567
Jooyung Hanfa181932021-06-12 07:56:53 +09004568TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4569 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4570 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4571 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004572 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004573 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4574}
4575
Jooyung Hanfd3be322020-12-13 09:11:06 +09004576struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004577 string kind;
4578 string literal;
4579};
4580
Jooyung Hanfd3be322020-12-13 09:11:06 +09004581const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004582 {"primitive", "int"}, {"primitiveArray", "int[]"},
4583 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004584 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4585 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4586 {"union", "a.Union"}, {"interface", "a.IBar"},
4587};
4588
4589const std::map<std::string, std::string> kListSupportExpectations = {
4590 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4591 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4592 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4593 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004594 {"cpp_primitiveArray", "List of arrays is not supported."},
4595 {"java_primitiveArray", "List of arrays is not supported."},
4596 {"ndk_primitiveArray", "List of arrays is not supported."},
4597 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004598 {"cpp_String", ""},
4599 {"java_String", ""},
4600 {"ndk_String", ""},
4601 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004602 {"cpp_StringArray", "List of arrays is not supported."},
4603 {"java_StringArray", "List of arrays is not supported."},
4604 {"ndk_StringArray", "List of arrays is not supported."},
4605 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004606 {"cpp_IBinder", ""},
4607 {"java_IBinder", ""},
4608 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4609 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004610 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004611 {"java_ParcelFileDescriptor", ""},
4612 {"ndk_ParcelFileDescriptor", ""},
4613 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004614 {"cpp_interface", "List<a.IBar> is not supported."},
4615 {"java_interface", "List<a.IBar> is not supported."},
4616 {"ndk_interface", "List<a.IBar> is not supported."},
4617 {"rust_interface", "List<a.IBar> is not supported."},
4618 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004619 {"java_parcelable", ""},
4620 {"ndk_parcelable", ""},
4621 {"rust_parcelable", ""},
4622 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4623 {"java_enum", "A generic type cannot have any primitive type parameters."},
4624 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4625 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004626 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004627 {"java_union", ""},
4628 {"ndk_union", ""},
4629 {"rust_union", ""},
4630};
4631
Jooyung Hand236e552020-12-13 09:21:27 +09004632const std::map<std::string, std::string> kArraySupportExpectations = {
4633 {"cpp_primitive", ""},
4634 {"java_primitive", ""},
4635 {"ndk_primitive", ""},
4636 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004637 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4638 {"java_primitiveArray", "Can only have one dimensional arrays."},
4639 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4640 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004641 {"cpp_String", ""},
4642 {"java_String", ""},
4643 {"ndk_String", ""},
4644 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004645 {"cpp_StringArray", "Can only have one dimensional arrays."},
4646 {"java_StringArray", "Can only have one dimensional arrays."},
4647 {"ndk_StringArray", "Can only have one dimensional arrays."},
4648 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004649 {"cpp_IBinder", ""},
4650 {"java_IBinder", ""},
4651 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4652 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4653 {"cpp_ParcelFileDescriptor", ""},
4654 {"java_ParcelFileDescriptor", ""},
4655 {"ndk_ParcelFileDescriptor", ""},
4656 {"rust_ParcelFileDescriptor", ""},
4657 {"cpp_interface", "Binder type cannot be an array"},
4658 {"java_interface", "Binder type cannot be an array"},
4659 {"ndk_interface", "Binder type cannot be an array"},
4660 {"rust_interface", "Binder type cannot be an array"},
4661 {"cpp_parcelable", ""},
4662 {"java_parcelable", ""},
4663 {"ndk_parcelable", ""},
4664 {"rust_parcelable", ""},
4665 {"cpp_enum", ""},
4666 {"java_enum", ""},
4667 {"ndk_enum", ""},
4668 {"rust_enum", ""},
4669 {"cpp_union", ""},
4670 {"java_union", ""},
4671 {"ndk_union", ""},
4672 {"rust_union", ""},
4673};
4674
Jooyung Hanfd3be322020-12-13 09:11:06 +09004675class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004676 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004677 void Run(const std::string& generic_type_decl,
4678 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004679 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004680 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004681 const auto& kind = std::get<1>(param).kind;
4682
4683 FakeIoDelegate io;
4684 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4685 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4686 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004687 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4688 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004689
4690 const auto options =
4691 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4692 CaptureStderr();
4693 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004694 auto it = expectations.find(lang + "_" + kind);
4695 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004696 const string err = GetCapturedStderr();
4697 if (it->second.empty()) {
4698 EXPECT_EQ("", err);
4699 } else {
4700 EXPECT_THAT(err, testing::HasSubstr(it->second));
4701 }
4702 }
4703};
4704
4705INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004706 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004707 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4708 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004709 testing::ValuesIn(kTypeParams)),
4710 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004711 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004712 });
4713
Jooyung Hanfd3be322020-12-13 09:11:06 +09004714TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4715 Run("List<{}>", kListSupportExpectations);
4716}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004717
Jooyung Hand236e552020-12-13 09:21:27 +09004718TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4719 Run("{}[]", kArraySupportExpectations);
4720}
4721
Christopher Wiley90be4e32015-10-20 14:55:25 -07004722} // namespace aidl
4723} // namespace android