blob: f1dce8d9d412942c8844ff5070d7bba1a3f1a362 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070038#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070039
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090040using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070041using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080042using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090043using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045using std::string;
46using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080047using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090048using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070049using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090050using testing::internal::CaptureStderr;
51using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070052
53namespace android {
54namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070055namespace {
56
57const char kExpectedDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60
61p/IFoo.aidl :
62)";
63
Dan Willemsen93298ee2016-11-10 23:55:55 -080064const char kExpectedNinjaDepFileContents[] =
65R"(place/for/output/p/IFoo.java : \
66 p/IFoo.aidl
67)";
68
Jiyong Parkdf202122019-09-30 20:48:35 +090069const char kExpectedParcelableDeclarationDepFileContents[] =
70 R"( : \
71 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
76const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080077 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070078 p/Foo.aidl
79
80p/Foo.aidl :
81)";
82
Christopher Wileyf8136192016-04-12 14:19:35 -070083} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070084
Devin Moore7b8d5c92020-03-17 14:14:08 -070085class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070086 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090087 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
88 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070089 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070090 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090091 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070092 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090093 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070094 for (const string& s : additional_arguments) {
95 args.emplace_back(s);
96 }
97 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090098 args.emplace_back("--preprocessed=" + f);
99 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700100 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--include=" + i);
102 }
103 args.emplace_back(path);
104 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900105 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900106 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700107 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900108 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900109
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 if (error != nullptr) {
111 *error = actual_error;
112 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900113
114 if (actual_error != AidlError::OK) {
115 return nullptr;
116 }
117
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900118 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900119 EXPECT_EQ(1ul, defined_types.size());
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700122 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700123
Devin Moore7b8d5c92020-03-17 14:14:08 -0700124 Options::Language GetLanguage() { return GetParam(); }
125
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800127 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900128 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900129 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700130};
131
Devin Moore7b8d5c92020-03-17 14:14:08 -0700132// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
133// tests with each of the supported languages as a parameter.
134INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
135 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700136 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900138 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700139 });
140
141TEST_P(AidlTest, AcceptMissingPackage) {
142 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700143}
144
Devin Moore7b8d5c92020-03-17 14:14:08 -0700145TEST_P(AidlTest, EndsInSingleLineComment) {
146 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700147}
148
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000149TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
150 const string expected_stderr =
151 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
152 const std::string file_contents = "package a; interface IBar {}";
153 CaptureStderr();
154 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
155 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
156}
157
158TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
159 const string expected_stderr =
160 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
161 const std::string file_contents = "package a; interface Bar {}";
162 CaptureStderr();
163 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
164 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
165}
166
167TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
168 const string expected_stderr =
169 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
170 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
171 CaptureStderr();
172 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
173 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
174}
175
176TEST_P(AidlTest, EnumRequiresCorrectPath) {
177 const string expected_stderr =
178 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
179 const std::string file_contents = "package a; enum Bar { A, }";
180 CaptureStderr();
181 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
182 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
183}
184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900186 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700187 io_delegate_.SetFileContents("bar/IBar.aidl",
188 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700189 const string path = "foo/IFoo.aidl";
190 const string contents =
191 "package foo;\n"
192 "import bar.IBar;\n"
193 "interface IFoo { void f(in IBar[] input); }";
194 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
195 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700196 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700198}
199
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700201 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700202 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900203}
Devin Moore097a3ab2020-03-11 16:08:44 -0700204
Jiyong Park40782d02020-07-24 19:17:43 +0900205TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700206 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
207 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900208 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
209 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700212 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900213}
214
Jiyong Park40782d02020-07-24 19:17:43 +0900215TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900216 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700217 const string expected_stderr =
218 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 CaptureStderr();
220 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900222}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700223
Jiyong Park40782d02020-07-24 19:17:43 +0900224TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900225 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900226 const string expected_stderr =
227 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700229 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700231}
232
Devin Moore7b8d5c92020-03-17 14:14:08 -0700233TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700234 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
235 const string expected_stderr =
236 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
237 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700238 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700240}
241
Devin Moore7b8d5c92020-03-17 14:14:08 -0700242TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700243 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
244 const string expected_stderr =
245 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
246 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700247 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800249}
250
Devin Moore2f2077a2020-08-28 11:27:53 -0700251TEST_P(AidlTest, AcceptNullableList) {
252 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
253 const string expected_stderr = "";
254 CaptureStderr();
255 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
257}
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700260 const string method = "package a; interface IFoo { void f(int a, int a); }";
261 const string expected_stderr =
262 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
263 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700266}
267
Jeongik Cha13066da2020-08-06 15:43:19 +0900268TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
269 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900270 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
274}
275
Jooyung Hand902a972020-10-23 17:32:44 +0900276TEST_P(AidlTest, RejectsRepeatedAnnotations) {
277 const string method = R"(@Hide @Hide parcelable Foo {})";
278 const string expected_stderr =
279 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
280 "Foo.aidl:1.1-6\n";
281 CaptureStderr();
282 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
284}
285
Devin Moore7b8d5c92020-03-17 14:14:08 -0700286TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700287 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
288 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
289 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700290 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100292}
293
Devin Moore7b8d5c92020-03-17 14:14:08 -0700294TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700295 AidlError error;
296 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700297 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700298 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900299 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700300 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800301}
302
Devin Moore7b8d5c92020-03-17 14:14:08 -0700303TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700304 AidlError error;
305 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700306 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700307 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900308 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700309 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800310}
311
Devin Moore7b8d5c92020-03-17 14:14:08 -0700312TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700313 AidlError error;
314 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700315 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000316 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900317 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700318 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800319}
320
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700324 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000325 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900326 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700327 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800328}
329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, ParsesNonNullableAnnotation) {
331 auto parse_result =
332 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
333 ASSERT_NE(nullptr, parse_result);
334 const AidlInterface* interface = parse_result->AsInterface();
335 ASSERT_NE(nullptr, interface);
336 ASSERT_FALSE(interface->GetMethods().empty());
337 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
338}
339
Devin Moore7b8d5c92020-03-17 14:14:08 -0700340TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900341 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
342 typenames_, GetLanguage());
343 ASSERT_NE(nullptr, parse_result);
344 const AidlInterface* interface = parse_result->AsInterface();
345 ASSERT_NE(nullptr, interface);
346 ASSERT_FALSE(interface->GetMethods().empty());
347 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
348}
349
350TEST_P(AidlTest, ParsesNonUtf8Annotations) {
351 auto parse_result =
352 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
353 ASSERT_NE(nullptr, parse_result);
354 const AidlInterface* interface = parse_result->AsInterface();
355 ASSERT_NE(nullptr, interface);
356 ASSERT_FALSE(interface->GetMethods().empty());
357 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900361 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
362 typenames_, GetLanguage());
363 ASSERT_NE(nullptr, parse_result);
364 const AidlInterface* interface = parse_result->AsInterface();
365 ASSERT_NE(nullptr, interface);
366 ASSERT_FALSE(interface->GetMethods().empty());
367 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800368}
369
Devin Moore7b8d5c92020-03-17 14:14:08 -0700370TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700371 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700372 const string expected_stderr =
373 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
374 "\"vintf\"'\n"
375 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
376 "--structured\n";
377 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700378 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700379 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700381 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700385 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700386 const string expected_stderr =
387 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
388 "--structured\n";
389 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700393 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700394}
395
Devin Moore7b8d5c92020-03-17 14:14:08 -0700396TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700397 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700398 const string expected_stderr =
399 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
400 "\"vintf\"'\n";
401 CaptureStderr();
402 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700403 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700404 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700405 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700406}
407
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700409 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700410 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
411 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700412 ASSERT_EQ(AidlError::OK, error);
413 ASSERT_NE(nullptr, parse_result);
414 const AidlInterface* interface = parse_result->AsInterface();
415 ASSERT_NE(nullptr, interface);
416 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700417}
418
Jeongik Cha64783ed2019-06-07 18:30:54 +0900419TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
420 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900421 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
422 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900423 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700424 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900425 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900426 "a/Foo.aidl",
427 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900428
429 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900430 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700431 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900432 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700433 "Parcelable must be defined in AIDL directly.\n";
434 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900435 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700436 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700437
438 CaptureStderr();
439 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900441}
442
Jooyung Han1cbc4962020-10-25 10:07:15 +0900443TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
444 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
445 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
446 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900447 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
448
449 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900450 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900451 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
452
453 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900454 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900455 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
456
Jooyung Han1cbc4962020-10-25 10:07:15 +0900457 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900458 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
459}
460
Jooyung Han1cbc4962020-10-25 10:07:15 +0900461TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
462 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
463 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
464 CaptureStderr();
465 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
466 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
467 EXPECT_EQ("", GetCapturedStderr());
468
469 const string expected_to_string_method = R"--(
470 @Override
471 public String toString() {
472 switch (_tag) {
473 case a: return "a.Foo.a(" + (getA()) + ")";
474 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
475 }
476 throw new IllegalStateException("unknown field: " + _tag);
477 }
478)--";
479
480 string java_out;
481 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
482 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
483}
484
Jiyong Park9aa3d042020-12-04 23:30:02 +0900485TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
486 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
487 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
488 CaptureStderr();
489 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
490 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
491 EXPECT_EQ("", GetCapturedStderr());
492
493 const std::string expected = R"--(
494 @Override
495 public boolean equals(Object other) {
496 if (this == other) return true;
497 if (other == null) return false;
498 if (!(other instanceof Foo)) return false;
499 Foo that = (Foo)other;
500 if (!java.util.Objects.deepEquals(a, that.a)) return false;
501 if (!java.util.Objects.deepEquals(b, that.b)) return false;
502 return true;
503 }
504
505 @Override
506 public int hashCode() {
507 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
508 }
509)--";
510
511 string java_out;
512 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
513 EXPECT_THAT(java_out, testing::HasSubstr(expected));
514}
515
516TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
517 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
518 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
519 CaptureStderr();
520 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
521 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
522 EXPECT_EQ("", GetCapturedStderr());
523
524 const std::string expected = R"--(
525 @Override
526 public boolean equals(Object other) {
527 if (this == other) return true;
528 if (other == null) return false;
529 if (!(other instanceof Foo)) return false;
530 Foo that = (Foo)other;
531 if (_tag != that._tag) return false;
532 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
533 return true;
534 }
535
536 @Override
537 public int hashCode() {
538 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
539 }
540)--";
541
542 string java_out;
543 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
544 EXPECT_THAT(java_out, testing::HasSubstr(expected));
545}
546
Jooyung Han90345002020-10-23 15:28:53 +0900547TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900548 {
Jooyung Han90345002020-10-23 15:28:53 +0900549 io_delegate_.SetFileContents("a/Foo.aidl",
550 "package a; @JavaDerive(blah=true) parcelable Foo{}");
551 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
552 CaptureStderr();
553 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
554 const std::string expected_stderr =
555 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900556 EXPECT_THAT(GetCapturedStderr(),
557 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900558 }
559
560 {
561 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900562 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
563 CaptureStderr();
564 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900565 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900566 }
567
568 {
Jooyung Han90345002020-10-23 15:28:53 +0900569 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900570 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
571 CaptureStderr();
572 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900573 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900574 }
575}
576
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900577TEST_P(AidlTest, ParseDescriptorAnnotation) {
578 AidlError error;
579 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
580 typenames_, GetLanguage(), &error, {"--structured"});
581 ASSERT_EQ(AidlError::OK, error);
582 ASSERT_NE(nullptr, parse_result);
583 const AidlInterface* interface = parse_result->AsInterface();
584 ASSERT_NE(nullptr, interface);
585 ASSERT_EQ("IBar", interface->GetDescriptor());
586}
587
Jiyong Park40782d02020-07-24 19:17:43 +0900588TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700589 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700590 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900591}
592
593TEST_P(AidlTest, AcceptsOnewayInterface) {
594 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700595 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700596}
Christopher Wileyef140932015-11-03 09:29:19 -0800597
Devin Moore7b8d5c92020-03-17 14:14:08 -0700598TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700599 const string oneway_method =
600 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700601 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100602}
603
Steven Moreland65297cc2020-04-20 20:17:36 -0700604TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
605 const string oneway_method =
606 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
607 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
608 ASSERT_NE(nullptr, defined);
609 const AidlInterface* iface = defined->AsInterface();
610 ASSERT_NE(nullptr, iface);
611
612 const auto& methods = iface->GetMethods();
613 ASSERT_EQ(1u, methods.size());
614 const auto& method = methods[0];
615 const AidlTypeSpecifier& ret_type = method->GetType();
616
617 // TODO(b/151102494): these annotations should be on the method
618 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
619 ASSERT_TRUE(ret_type.IsHide());
620}
621
Devin Moore7b8d5c92020-03-17 14:14:08 -0700622TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100623 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900624 R"(package a;
625 /* foo */
626 interface IFoo {
627 /* i */
628 int i();
629 // j
630 @nullable String j();
631 // k1
632 /* k2 */
633 @UnsupportedAppUsage oneway void k(int a);
634 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100635
Jooyung Han8451a202021-01-16 03:07:06 +0900636 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700637 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100638 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900639 EXPECT_EQ("", GetCapturedStderr());
640
Jooyung Han161bb0f2021-01-21 12:30:16 +0900641 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100642
643 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900644 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
645 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
646 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100647}
648
Jooyung Han1a551d32020-10-05 15:37:26 +0900649TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
650 io_delegate_.SetFileContents("p/cpp_header.aidl",
651 R"(package p;
652 parcelable cpp_header cpp_header "bar/header";)");
653 import_paths_.emplace("");
654 const string input_path = "p/IFoo.aidl";
655 const string input = R"(package p;
656 import p.cpp_header;
657 interface IFoo {
658 // get bar
659 cpp_header get();
660 })";
661
662 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
663 EXPECT_NE(nullptr, parse_result);
664 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900665 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900666}
667
Christopher Wileyef140932015-11-03 09:29:19 -0800668TEST_F(AidlTest, ParsesPreprocessedFile) {
669 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
670 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700671 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900672 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700673 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
674 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800675}
676
677TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
678 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
679 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900680
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700681 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900682 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700683 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
684 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800685}
686
Devin Moore7b8d5c92020-03-17 14:14:08 -0700687TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800688 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
689 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
690 "interface IBar {}");
691 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900692 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900693 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700694 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800695 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900696
Christopher Wiley41544372015-11-03 14:52:29 -0800697 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700698 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
699 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800700 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900701 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900702 ambiguous_type.Resolve(typenames_);
703 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800704}
705
Jiyong Park8f6ec462020-01-19 20:52:47 +0900706// Special case of PreferImportToPreprocessed. Imported type should be preferred
707// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700708TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900709 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
710 io_delegate_.SetFileContents("one/IBar.aidl",
711 "package one; "
712 "interface IBar {}");
713 preprocessed_files_.push_back("preprocessed");
714 import_paths_.emplace("");
715 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700716 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900717 EXPECT_NE(nullptr, parse_result);
718
719 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700720 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
721 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900722 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900723 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900724 ambiguous_type.Resolve(typenames_);
725 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
726}
727
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800728TEST_F(AidlTest, WritePreprocessedFile) {
729 io_delegate_.SetFileContents("p/Outer.aidl",
730 "package p; parcelable Outer.Inner;");
731 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
732 "interface IBar {}");
733
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900734 vector<string> args {
735 "aidl",
736 "--preprocess",
737 "preprocessed",
738 "p/Outer.aidl",
739 "one/IBar.aidl"};
740 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800741 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
742
743 string output;
744 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
745 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
746}
747
Jooyung Han720253d2021-01-05 19:13:17 +0900748TEST_P(AidlTest, SupportDeprecated) {
749 struct TestCase {
750 std::string output_file;
751 std::string annotation;
752 };
753
754 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900755 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900756 io_delegate_.SetFileContents(filename, contents);
757
758 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
759 " --out=out --header_out=out");
760 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900761 for (const auto& [lang, test_case] : expectations) {
762 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900763 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900764 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900765 EXPECT_THAT(output, HasSubstr(test_case.annotation));
766 }
767 };
768
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900769 // Emit escaped string for notes
770 CheckDeprecated(
771 "IFoo.aidl",
772 R"(interface IFoo {
773 /**
774 * @note asdf
775 * @deprecated a really long deprecation message
776 *
777 * which is really long
778 * @param foo bar
779 */
780 List<String> foo();
781 })",
782 {
783 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
784 {Options::Language::CPP,
785 {"out/IFoo.h",
786 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
787 {Options::Language::NDK,
788 {"out/aidl/IFoo.h",
789 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
790 {Options::Language::RUST,
791 {"out/IFoo.rs",
792 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
793 });
794
Jooyung Han24effbf2021-01-16 10:24:03 +0900795 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900796 CheckDeprecated(
797 "IFoo.aidl",
798 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900799 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900800 " List<String> foo();\n"
801 "}",
802 {
803 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900804 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900805 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
806 {Options::Language::NDK,
807 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
808 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
809 });
Jooyung Han720253d2021-01-05 19:13:17 +0900810
Jooyung Han24effbf2021-01-16 10:24:03 +0900811 // but not in line comments
812 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
813 EXPECT_FALSE(parsed->IsDeprecated());
814
815 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900816 CheckDeprecated("Foo.aidl",
817 "parcelable Foo {\n"
818 " /** @deprecated use bar*/\n"
819 " int foo = 0;\n"
820 "}",
821 {
822 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
823 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
824 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
825 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
826 });
827
Jooyung Han24effbf2021-01-16 10:24:03 +0900828 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900829 CheckDeprecated("IFoo.aidl",
830 "interface IFoo {\n"
831 " /** @deprecated use bar*/\n"
832 " const int FOO = 0;\n"
833 "}",
834 {
835 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
836 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
837 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
838 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
839 });
840
841 // union fields
842 CheckDeprecated("Foo.aidl",
843 "union Foo {\n"
844 " int bar = 0;\n"
845 " /** @deprecated use bar*/\n"
846 " int foo;\n"
847 "}",
848 {
849 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
850 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
851 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
852 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
853 });
854
855 CheckDeprecated("Foo.aidl",
856 "/** @deprecated use Bar */\n"
857 "parcelable Foo {}",
858 {
859 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
860 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
861 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
862 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
863 });
864
865 CheckDeprecated("Foo.aidl",
866 "/** @deprecated use Bar */\n"
867 "union Foo { int foo = 0; }",
868 {
869 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
870 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
871 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
872 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
873 });
874
875 CheckDeprecated("IFoo.aidl",
876 "/** @deprecated use IBar */\n"
877 "interface IFoo {}",
878 {
879 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
880 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
881 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
882 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
883 });
884
885 CheckDeprecated("Foo.aidl",
886 "/** @deprecated use IBar */\n"
887 "enum Foo { FOO }",
888 {
889 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
890 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
891 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900892 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +0900893 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
894 });
895}
896
Devin Moore7b8d5c92020-03-17 14:14:08 -0700897TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700898 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800899 io_delegate_.SetFileContents("p/Outer.aidl",
900 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900901 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700902 CaptureStderr();
903 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
904 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700905 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800907}
908
Devin Moore7b8d5c92020-03-17 14:14:08 -0700909TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800910 io_delegate_.SetFileContents("preprocessed",
911 "parcelable p.Outer.Inner;");
912 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900913 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700914 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800915 // TODO(wiley): This should actually return nullptr because we require
916 // the outer class name. However, for legacy reasons,
917 // this behavior must be maintained. b/17415692
918 EXPECT_NE(nullptr, parse_result);
919}
920
Christopher Wiley632801d2015-11-05 14:15:49 -0800921TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 const string expected_foo_stderr =
923 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
924 "Declared parcelables should be in their own file and/or cannot be used with --structured "
925 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700926 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
927
Christopher Wiley632801d2015-11-05 14:15:49 -0800928 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700929 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700930 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900931 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900933
Steven Morelande2c64b42018-09-18 15:06:37 -0700934 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900935 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900937 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700939
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 const string expected_bar_stderr =
941 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
942 "Declared parcelables should be in their own file and/or cannot be used with --structured "
943 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700944 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
945
Jiyong Parkda8c6932019-08-12 19:56:08 +0900946 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700947 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700948 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900949 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700950 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700951 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700952 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700953 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800955}
956
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 const string expected_stderr =
959 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
960 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700961 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
962 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 AidlError error;
964 CaptureStderr();
965 EXPECT_EQ(
966 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700967 Parse("p/IFoo.aidl",
968 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700969 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 EXPECT_EQ(expected_stderr, GetCapturedStderr());
971 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700972}
973
Devin Moore7b8d5c92020-03-17 14:14:08 -0700974TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700975 AidlError error;
976 const string expected_stderr =
977 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
978 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900979 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
980 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700981 interface IFoo {
982 const String DUPLICATED = "d";
983 const int DUPLICATED = 1;
984 }
985 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700986 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
988 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700989}
990
Steven Morelande689da22020-11-10 02:06:30 +0000991TEST_P(AidlTest, FailOnTooBigConstant) {
992 AidlError error;
993 const string expected_stderr =
994 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
995 CaptureStderr();
996 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
997 R"(package p;
998 interface IFoo {
999 const byte type2small = 256;
1000 }
1001 )",
1002 typenames_, GetLanguage(), &error));
1003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1004 EXPECT_EQ(AidlError::BAD_TYPE, error);
1005}
1006
Jooyung Han30f64ad2020-12-15 08:16:31 +09001007TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1008 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1009 CaptureStderr();
1010 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1011 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1012 EXPECT_EQ("", GetCapturedStderr());
1013 string code;
1014 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1015 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1016}
1017
Jooyung Han535c5e82020-12-29 15:16:59 +09001018TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001019 using Ptr = unique_ptr<AidlConstantValue>;
1020 const AidlLocation& loc = AIDL_LOCATION_HERE;
1021
Jooyung Han535c5e82020-12-29 15:16:59 +09001022 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1023 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1024 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1025 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001026
1027 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1028 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001029 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001030
1031 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1032 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1033 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1034 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001035 EXPECT_EQ(
1036 expected,
1037 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001038}
1039
Devin Moore7b8d5c92020-03-17 14:14:08 -07001040TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001041 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001042 const string expected_stderr =
1043 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001044 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001045 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1046 R"(package p;
1047 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001048 parcelable IBar {}
1049 parcelable StructuredParcelable {}
1050 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001051 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001052 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001053 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001054 // Parse success is important for clear error handling even if the cases aren't
1055 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001056 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001057}
1058
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 AidlError error;
1061 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1062 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001064 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1065 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001066}
1067
Steven Morelandf9e922f2020-07-08 21:15:27 +00001068TEST_P(AidlTest, FailOnEmptyListWithComma) {
1069 AidlError error;
1070 const string expected_stderr =
1071 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1072 CaptureStderr();
1073 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1074 typenames_, GetLanguage(), &error));
1075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1076 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1077}
1078
Devin Moore7b8d5c92020-03-17 14:14:08 -07001079TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001080 AidlError error;
1081 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001082 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001083 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001084 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1085 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001086 interface IFoo {
1087 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1088 }
1089 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001090 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001091 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1092 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001093}
1094
Jiyong Park18132182020-06-08 20:24:40 +09001095TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1096 AidlError error;
1097 const string expected_stderr =
1098 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1099 "cpp_header (which can also be used as an identifier)\n";
1100 CaptureStderr();
1101 // Notice the trailing dot(.) in the name, which isn't a correct name
1102 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1103 GetLanguage(), &error));
1104 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1105 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1106}
1107
1108TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1109 AidlError error;
1110 const string expected_stderr =
1111 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1112 "cpp_header (which can also be used as an identifier)\n";
1113 CaptureStderr();
1114 // Notice the trailing dot(.) in the package name
1115 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1116 GetLanguage(), &error));
1117 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1118 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1119}
1120
Devin Moore7b8d5c92020-03-17 14:14:08 -07001121TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001122 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001123 auto parse_result = Parse("p/IFoo.aidl",
1124 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001125 interface IFoo {
1126 const int POSITIVE_HEX_VALUE = 0xf5;
1127 }
1128 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001129 typenames_, GetLanguage(), &error);
1130 EXPECT_NE(nullptr, parse_result);
1131 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001132 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001133 const auto& cpp_constants = interface->GetConstantDeclarations();
1134 EXPECT_EQ((size_t)1, cpp_constants.size());
1135 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001136 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001137 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001138}
1139
Devin Moore7b8d5c92020-03-17 14:14:08 -07001140TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001141 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001142 auto parse_result = Parse("p/IFoo.aidl",
1143 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001144 interface IFoo {
1145 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1146 }
1147 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001148 typenames_, GetLanguage(), &error);
1149 ASSERT_NE(nullptr, parse_result);
1150 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001151 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001152 const auto& cpp_constants = interface->GetConstantDeclarations();
1153 EXPECT_EQ((size_t)1, cpp_constants.size());
1154 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001155 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001156 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001157}
1158
Devin Moore7b8d5c92020-03-17 14:14:08 -07001159TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001160 io_delegate_.SetFileContents(
1161 "p/Outer.aidl",
1162 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001163 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001164 const string input_path = "p/IFoo.aidl";
1165 const string input = "package p; import p.Outer; interface IFoo"
1166 " { Outer.Inner get(); }";
1167
Devin Moore7b8d5c92020-03-17 14:14:08 -07001168 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1169 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001170
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001171 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001172 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001173 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001174 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001175}
1176
Devin Moore7b8d5c92020-03-17 14:14:08 -07001177TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001178 io_delegate_.SetFileContents(
1179 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001180 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001181 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001182 const string input_path = "p/IFoo.aidl";
1183 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001184 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1185 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001186 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001187 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001188 native_type.Resolve(typenames_);
1189
1190 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1191 // C++ understands C++ specific stuff
1192 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1193 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001194 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001195 EXPECT_EQ(1u, headers.size());
1196 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001197}
1198
Christopher Wileyf8136192016-04-12 14:19:35 -07001199TEST_F(AidlTest, WritesCorrectDependencyFile) {
1200 // While the in tree build system always gives us an output file name,
1201 // other android tools take advantage of our ability to infer the intended
1202 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001203 vector<string> args = {
1204 "aidl",
1205 "-d dep/file/path",
1206 "-o place/for/output",
1207 "p/IFoo.aidl"};
1208 Options options = Options::From(args);
1209 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001210 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001211 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001212 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001213 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1214}
1215
Dan Willemsen93298ee2016-11-10 23:55:55 -08001216TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1217 // While the in tree build system always gives us an output file name,
1218 // other android tools take advantage of our ability to infer the intended
1219 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001220 vector<string> args = {
1221 "aidl",
1222 "-d dep/file/path",
1223 "--ninja",
1224 "-o place/for/output",
1225 "p/IFoo.aidl"};
1226 Options options = Options::From(args);
1227 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001228 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001229 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001230 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001231 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1232}
1233
Jiyong Parkdf202122019-09-30 20:48:35 +09001234TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001235 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1236 // this by calling aidl with every .aidl file it finds, then parsing the
1237 // generated dependency files. Those that reference .java output files are
1238 // for interfaces and those that do not are parcelables. However, for both
1239 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001240 vector<string> args = {
1241 "aidl",
1242 "-o place/for/output",
1243 "-d dep/file/path",
1244 "p/Foo.aidl"};
1245 Options options = Options::From(args);
1246 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001247 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001248 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001249 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001250 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1251}
1252
1253TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1254 vector<string> args = {
1255 "aidl",
1256 "--structured",
1257 "-o place/for/output",
1258 "-d dep/file/path",
1259 "p/Foo.aidl"};
1260 Options options = Options::From(args);
1261 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1262 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1263 string actual_dep_file_contents;
1264 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1265 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001266}
1267
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001268TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1269 vector<string> args = {
1270 "aidl",
1271 "--lang=java",
1272 "-o place/for/output",
1273 "p/Foo.aidl"};
1274 Options options = Options::From(args);
1275 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1276 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1277 string output_file_contents;
1278 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1279}
1280
Devin Moore21b26772020-08-26 16:37:56 -07001281TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001282 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001283 const string list_array_parcelable =
1284 "package a; parcelable Foo {\n"
1285 " List[] lists; }";
1286 CaptureStderr();
1287 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1288 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1289}
1290
Jiyong Parkf8d53612020-05-04 14:06:13 +09001291TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1292 AidlError error;
1293 string expected_stderr =
1294 "ERROR: a/IFoo.aidl:2.7-11: "
1295 "Encountered an untyped List or Map. The use of untyped List/Map is "
1296 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1297 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1298 if (GetLanguage() != Options::Language::JAVA) {
1299 expected_stderr =
1300 "ERROR: a/IFoo.aidl:2.1-7: "
1301 "Currently, only the Java backend supports non-generic List.\n";
1302 }
1303
1304 const string primitive_interface =
1305 "package a; interface IFoo {\n"
1306 " List foo(); }";
1307 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001308 AidlTypenames tn1;
1309 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001310 {"--structured"}));
1311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001312
1313 string primitive_parcelable =
1314 "package a; parcelable IFoo {\n"
1315 " List foo;}";
1316 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001317 AidlTypenames tn2;
1318 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001319 {"--structured"}));
1320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1321}
1322
Jeongik Cha225519b2020-08-29 01:55:32 +09001323TEST_P(AidlTest, ExtensionTest) {
1324 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001325 string extendable_parcelable =
1326 "package a; parcelable Data {\n"
1327 " ParcelableHolder extension;\n"
1328 " ParcelableHolder extension2;\n"
1329 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001330 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1332 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001333 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001334 "yet.\n",
1335 GetCapturedStderr());
1336 } else {
1337 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1338 EXPECT_EQ("", GetCapturedStderr());
1339 }
1340}
1341TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1342 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001343 string parcelableholder_return_interface =
1344 "package a; interface IFoo {\n"
1345 " ParcelableHolder foo();\n"
1346 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001347 EXPECT_EQ(nullptr,
1348 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001349
Jeongik Cha8f02a532020-10-14 00:16:28 +09001350 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001351 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001352 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001353 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001354 "yet.\n",
1355 GetCapturedStderr());
1356 return;
1357 }
1358 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1359 GetCapturedStderr());
1360}
1361
1362TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1363 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001364 string extendable_parcelable_arg_interface =
1365 "package a; interface IFoo {\n"
1366 " void foo(in ParcelableHolder ph);\n"
1367 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001368 EXPECT_EQ(nullptr,
1369 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1370
Jeongik Cha8f02a532020-10-14 00:16:28 +09001371 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001372 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001373 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001374 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001375 "yet.\n",
1376 GetCapturedStderr());
1377 return;
1378 }
1379 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1380 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001381}
1382
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001383TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1384 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001385 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001386 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1387 CaptureStderr();
1388 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1389 if (GetLanguage() == Options::Language::RUST) {
1390 EXPECT_EQ(
1391 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1392 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1393 "yet.\n",
1394 GetCapturedStderr());
1395 return;
1396 }
1397 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1398}
1399
Jooyung Han3f347ca2020-12-01 12:41:50 +09001400TEST_P(AidlTest, ParcelablesWithConstants) {
1401 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001402 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001403 CaptureStderr();
1404 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1405 EXPECT_EQ("", GetCapturedStderr());
1406}
1407
1408TEST_P(AidlTest, UnionWithConstants) {
1409 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001410 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001411 CaptureStderr();
1412 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1413 EXPECT_EQ("", GetCapturedStderr());
1414}
1415
Jooyung Han633eab62021-01-07 14:12:40 +09001416TEST_F(AidlTest, ConstantsWithAnnotations) {
1417 io_delegate_.SetFileContents("IFoo.aidl",
1418 "interface IFoo {\n"
1419 " @JavaPassthrough(annotation=\"@Foo\")\n"
1420 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1421 "}");
1422 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1423 CaptureStderr();
1424 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1425 EXPECT_EQ("", GetCapturedStderr());
1426 string code;
1427 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1428 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1429 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1430}
1431
Jiyong Park02da7422018-07-16 16:00:26 +09001432TEST_F(AidlTest, ApiDump) {
1433 io_delegate_.SetFileContents(
1434 "foo/bar/IFoo.aidl",
1435 "package foo.bar;\n"
1436 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001437 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001438 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001439 " /* @hide applied \n"
1440 " @deprecated use foo2 */\n"
1441 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1442 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001443 " IFoo foo3(IFoo foo);\n"
1444 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001445 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001446 " /** blahblah\n"
1447 " @deprecated\n"
1448 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001449 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001450 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001451 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001452 "}\n");
1453 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1454 "package foo.bar;\n"
1455 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001456 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001457 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001458 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001459 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001460 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001461 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001462 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001463 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001464 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001465 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001466 "}\n");
1467 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001468 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1469 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001470 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001471 bool result = dump_api(options, io_delegate_);
1472 ASSERT_TRUE(result);
1473 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001474 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001475 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001476interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001477 /**
1478 * @hide
1479 * @deprecated use foo2
1480 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001481 int foo(out int[] a, String b, boolean c, inout List<String> d);
1482 int foo2(@utf8InCpp String x, inout List<String> y);
1483 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1484 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001485 /**
1486 * @deprecated reason why...
1487 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001488 const int A = 1;
1489 const String STR = "Hello";
1490}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001491)"),
1492 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001493
Jiyong Parke59c3682018-09-11 23:10:25 +09001494 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001495 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001496/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001497parcelable Data {
1498 int x = 10;
1499 int y;
1500 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001501 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001502}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001503)"),
1504 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001505}
1506
Jiyong Parked65bf42018-08-28 15:43:27 +09001507TEST_F(AidlTest, ApiDumpWithManualIds) {
1508 io_delegate_.SetFileContents(
1509 "foo/bar/IFoo.aidl",
1510 "package foo.bar;\n"
1511 "interface IFoo {\n"
1512 " int foo() = 1;\n"
1513 " int bar() = 2;\n"
1514 " int baz() = 10;\n"
1515 "}\n");
1516
Jiyong Parke59c3682018-09-11 23:10:25 +09001517 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001518 Options options = Options::From(args);
1519 bool result = dump_api(options, io_delegate_);
1520 ASSERT_TRUE(result);
1521 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001522 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001523 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001524interface IFoo {
1525 int foo() = 1;
1526 int bar() = 2;
1527 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001528}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001529)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001530}
1531
1532TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001533 const string expected_stderr =
1534 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1535 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001536 io_delegate_.SetFileContents(
1537 "foo/bar/IFoo.aidl",
1538 "package foo.bar;\n"
1539 "interface IFoo {\n"
1540 " int foo() = 1;\n"
1541 " int bar();\n"
1542 " int baz() = 10;\n"
1543 "}\n");
1544
Jiyong Parke59c3682018-09-11 23:10:25 +09001545 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001546 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001547 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001548 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001550}
1551
Jooyung Han965e31d2020-11-27 12:30:16 +09001552TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1553 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1554 "package foo.bar;\n"
1555 "interface IFoo {\n"
1556 " @utf8InCpp String foo();\n"
1557 " const @utf8InCpp String bar = \"bar\";\n"
1558 "}\n");
1559
1560 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1561 Options options = Options::From(args);
1562 CaptureStderr();
1563 EXPECT_TRUE(dump_api(options, io_delegate_));
1564 EXPECT_EQ("", GetCapturedStderr());
1565 string actual;
1566 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001567 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1568interface IFoo {
1569 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001570 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001571}
1572)"),
1573 actual);
1574}
1575
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001576TEST_F(AidlTest, ApiDumpWithEnums) {
1577 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1578 "package foo.bar;\n"
1579 "enum Enum {\n"
1580 " FOO,\n"
1581 " BAR = FOO + 1,\n"
1582 "}\n");
1583
1584 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1585 Options options = Options::From(args);
1586 CaptureStderr();
1587 EXPECT_TRUE(dump_api(options, io_delegate_));
1588 EXPECT_EQ("", GetCapturedStderr());
1589 string actual;
1590 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1591 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1592 "enum Enum {\n"
1593 " FOO = 0,\n"
1594 " BAR = 1,\n"
1595 "}\n"),
1596 actual);
1597}
1598
1599TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1600 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1601 "package foo.bar;\n"
1602 "enum Enum {\n"
1603 " FOO,\n"
1604 "}\n");
1605 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1606 "package foo.bar;\n"
1607 "import foo.bar.Enum;\n"
1608 "parcelable Foo {\n"
1609 " Enum e = Enum.FOO;\n"
1610 "}\n");
1611
1612 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1613 Options options = Options::From(args);
1614 CaptureStderr();
1615 EXPECT_TRUE(dump_api(options, io_delegate_));
1616 EXPECT_EQ("", GetCapturedStderr());
1617 string actual;
1618 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1619 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1620 "parcelable Foo {\n"
1621 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1622 "}\n"),
1623 actual);
1624}
1625
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001626TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001627 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001628 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1629 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001630 const string expected_map_stderr =
1631 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001632 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1633 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001634 "package p; interface IFoo {"
1635 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001637 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001639
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001640 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001641 "package p; interface IFoo {"
1642 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001643 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001644 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001645 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001646}
1647
Jeongik Chae48d9942020-01-02 17:39:00 +09001648TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001649 const string expected_stderr =
1650 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001651 Options options = Options::From("aidl -I p p/IFoo.aidl");
1652 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1653
1654 io_delegate_.SetFileContents("p/IFoo.aidl",
1655 "package p; interface IFoo {"
1656 "Map<String, Bar> foo();}");
1657 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1658
1659 io_delegate_.SetFileContents("p/IFoo.aidl",
1660 "package p; interface IFoo {"
1661 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001662 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001663 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001664 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001665
1666 io_delegate_.SetFileContents("p/IFoo.aidl",
1667 "package p; interface IFoo {"
1668 "Map<String, String> foo();}");
1669 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1670
1671 io_delegate_.SetFileContents("p/IFoo.aidl",
1672 "package p; interface IFoo {"
1673 "Map<String, ParcelFileDescriptor> foo();}");
1674 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1675}
1676
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001678 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001679 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1680 io_delegate_.SetFileContents(options.InputFiles().front(),
1681 "package p; interface IFoo {"
1682 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001683 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001684 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001685 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686}
1687
1688TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1689 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1690 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001691 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001692 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001693 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1694 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001695
1696 Options options = Options::From("aidl -I p p/IFoo.aidl");
1697 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1698 io_delegate_.SetFileContents("p/IFoo.aidl",
1699 "package p; interface IFoo {"
1700 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001701 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001702 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001703 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001704 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001705 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001706 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001707 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1708 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001709 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1710 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1711 io_delegate_.SetFileContents("p/IFoo.aidl",
1712 "package p; interface IFoo {"
1713 "Bar<String, ParcelFileDescriptor> foo();}");
1714 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001715
1716 io_delegate_.SetFileContents("p/IFoo.aidl",
1717 "package p; interface IFoo {"
1718 "Bar<int, long> foo();}");
1719
1720 io_delegate_.SetFileContents("p/IFoo.aidl",
1721 "package p; interface IFoo {"
1722 "Bar<int[], long[]> foo();}");
1723
1724 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001725}
1726
Jeongik Cha0e426012019-07-29 15:57:02 +09001727TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1728 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001729 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1730 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001731 for (const auto& rawOption : rawOptions) {
1732 string expected_stderr =
1733 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001734 Options options = Options::From(rawOption);
1735 io_delegate_.SetFileContents(options.InputFiles().front(),
1736 "package foo.bar;\n"
1737 "interface IFoo1 { int foo(); }\n"
1738 "interface IFoo2 { int foo(); }\n"
1739 "parcelable Data1 { int a; int b;}\n"
1740 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001741 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001742 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001743 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001744
Jeongik Cha0e426012019-07-29 15:57:02 +09001745 io_delegate_.SetFileContents(options.InputFiles().front(),
1746 "package foo.bar;\n"
1747 "interface IFoo1 { int foo(); }\n"
1748 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001749 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001750 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001752
Devin Moore5de18ed2020-04-02 13:52:29 -07001753 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001754 io_delegate_.SetFileContents(options.InputFiles().front(),
1755 "package foo.bar;\n"
1756 "parcelable Data1 { int a; int b;}\n"
1757 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001758 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001759 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001760 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001761 }
1762}
1763
Devin Moorebdba2a82020-03-31 15:19:02 -07001764TEST_P(AidlTest, FailParseOnEmptyFile) {
1765 const string contents = "";
1766 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1767 CaptureStderr();
1768 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1769 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1770}
1771
Jiyong Parkb034bf02018-07-30 17:44:33 +09001772TEST_F(AidlTest, MultipleInputFiles) {
1773 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001774 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001775
1776 io_delegate_.SetFileContents(options.InputFiles().at(0),
1777 "package foo.bar;\n"
1778 "import foo.bar.Data;\n"
1779 "interface IFoo { Data getData(); }\n");
1780
1781 io_delegate_.SetFileContents(options.InputFiles().at(1),
1782 "package foo.bar;\n"
1783 "import foo.bar.IFoo;\n"
1784 "parcelable Data { IFoo foo; }\n");
1785
1786 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1787
1788 string content;
1789 for (const auto file : {
1790 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1791 content.clear();
1792 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1793 EXPECT_FALSE(content.empty());
1794 }
1795}
1796
1797TEST_F(AidlTest, MultipleInputFilesCpp) {
1798 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001799 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001800
1801 io_delegate_.SetFileContents(options.InputFiles().at(0),
1802 "package foo.bar;\n"
1803 "import foo.bar.Data;\n"
1804 "interface IFoo { Data getData(); }\n");
1805
1806 io_delegate_.SetFileContents(options.InputFiles().at(1),
1807 "package foo.bar;\n"
1808 "import foo.bar.IFoo;\n"
1809 "parcelable Data { IFoo foo; }\n");
1810
1811 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1812
1813 string content;
1814 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001815 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001816 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1817 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1818 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1819 content.clear();
1820 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1821 EXPECT_FALSE(content.empty());
1822 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001823}
1824
Andrei Homescub62afd92020-05-11 19:24:59 -07001825TEST_F(AidlTest, MultipleInputFilesRust) {
1826 Options options =
1827 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1828
1829 io_delegate_.SetFileContents(options.InputFiles().at(0),
1830 "package foo.bar;\n"
1831 "import foo.bar.Data;\n"
1832 "interface IFoo { Data getData(); }\n");
1833
1834 io_delegate_.SetFileContents(options.InputFiles().at(1),
1835 "package foo.bar;\n"
1836 "import foo.bar.IFoo;\n"
1837 "parcelable Data { IFoo foo; }\n");
1838
1839 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1840
1841 string content;
1842 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1843 content.clear();
1844 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1845 EXPECT_FALSE(content.empty());
1846 }
1847}
1848
Devin Moore097a3ab2020-03-11 16:08:44 -07001849TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1850 const string expected_stderr =
1851 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001852 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1853 // int getInterfaceVersion() is one of the meta transactions
1854 io_delegate_.SetFileContents(options.InputFiles().front(),
1855 "package p; interface IFoo {"
1856 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001857 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001858 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001859 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1860}
Jiyong Park309668e2018-07-28 16:55:44 +09001861
Devin Moore097a3ab2020-03-11 16:08:44 -07001862TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1863 // boolean getInterfaceVersion() is not a meta transaction, but should be
1864 // prevented because return type is not part of a method signature
1865 const string expected_stderr =
1866 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1867 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001868 io_delegate_.SetFileContents(options.InputFiles().front(),
1869 "package p; interface IFoo {"
1870 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001871 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001872 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001873 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1874}
Jiyong Park309668e2018-07-28 16:55:44 +09001875
Devin Moore097a3ab2020-03-11 16:08:44 -07001876TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001877 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001878 const string expected_stderr =
1879 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1880 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001881 io_delegate_.SetFileContents(options.InputFiles().front(),
1882 "package p; interface IFoo {"
1883 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001884 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001885 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001886 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001887
1888 // this is not a meta interface method as it differs type arguments
1889 io_delegate_.SetFileContents(options.InputFiles().front(),
1890 "package p; interface IFoo {"
1891 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001892 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001893}
1894
Jooyung Hanb8a97772021-01-19 01:27:38 +09001895TEST_F(AidlTest, CheckApiForEquality) {
1896 CaptureStderr();
1897 Options options = Options::From("aidl --checkapi=equal old new");
1898
1899 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1900 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1901 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1902 "package p; interface IFoo{ @utf8InCpp String foo();}");
1903
1904 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1905 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1906}
1907
Daniel Norman85aed542019-08-21 12:01:14 -07001908TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001909 Options options = Options::From("aidl --checkapi old new");
1910 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1911 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1912 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1913 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1914
1915 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1916}
1917
Jiyong Park3656c3c2018-08-01 20:02:01 +09001918TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001919 Options options = Options::From("aidl --checkapi old new");
1920 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1921 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001922
1923 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1924}
1925
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001926TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1927 Options options = Options::From("aidl --checkapi old new");
1928 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1929 const string enum_definition = "package p; enum Enum { FOO }";
1930 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1931 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1932 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1933 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1934
1935 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1936}
1937
Jooyung Han02a11be2021-02-11 13:18:06 +09001938TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
1939 Options options = Options::From("aidl --checkapi=equal old new");
1940 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1941 const string enum_definition = "package p; enum Enum { FOO }";
1942 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1943 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1944 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1945 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1946 CaptureStderr();
1947 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1948 EXPECT_EQ("", GetCapturedStderr());
1949}
1950
Daniel Norman85aed542019-08-21 12:01:14 -07001951class AidlTestCompatibleChanges : public AidlTest {
1952 protected:
1953 Options options_ = Options::From("aidl --checkapi old new");
1954};
1955
1956TEST_F(AidlTestCompatibleChanges, NewType) {
1957 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1958 "package p;"
1959 "interface IFoo {"
1960 " void foo(int a);"
1961 "}");
1962 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1963 "package p;"
1964 "interface IFoo {"
1965 " void foo(int a);"
1966 "}");
1967 io_delegate_.SetFileContents("new/p/IBar.aidl",
1968 "package p;"
1969 "interface IBar {"
1970 " void bar();"
1971 "}");
1972 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1973}
1974
1975TEST_F(AidlTestCompatibleChanges, NewMethod) {
1976 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1977 "package p;"
1978 "interface IFoo {"
1979 " void foo(int a);"
1980 "}");
1981 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1982 "package p;"
1983 "interface IFoo {"
1984 " void foo(int a);"
1985 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001986 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001987 "}");
1988 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1989}
1990
1991TEST_F(AidlTestCompatibleChanges, NewField) {
1992 io_delegate_.SetFileContents("old/p/Data.aidl",
1993 "package p;"
1994 "parcelable Data {"
1995 " int foo;"
1996 "}");
1997 io_delegate_.SetFileContents("new/p/Data.aidl",
1998 "package p;"
1999 "parcelable Data {"
2000 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002001 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002002 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002003 "}");
2004 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2005}
2006
2007TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2008 io_delegate_.SetFileContents("old/p/Enum.aidl",
2009 "package p;"
2010 "enum Enum {"
2011 " FOO = 1,"
2012 "}");
2013 io_delegate_.SetFileContents("new/p/Enum.aidl",
2014 "package p;"
2015 "enum Enum {"
2016 " FOO = 1,"
2017 " BAR = 2,"
2018 "}");
2019 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2020}
2021
2022TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2023 io_delegate_.SetFileContents("old/p/Enum.aidl",
2024 "package p;"
2025 "enum Enum {"
2026 " FOO = 1,"
2027 " BAR = 2,"
2028 "}");
2029 io_delegate_.SetFileContents("new/p/Enum.aidl",
2030 "package p;"
2031 "enum Enum {"
2032 " BAR = 2,"
2033 " FOO = 1,"
2034 "}");
2035 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2036}
2037
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002038TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2039 io_delegate_.SetFileContents("old/p/Union.aidl",
2040 "package p;"
2041 "union Union {"
2042 " String foo;"
2043 "}");
2044 io_delegate_.SetFileContents("new/p/Union.aidl",
2045 "package p;"
2046 "union Union {"
2047 " String foo;"
2048 " int num;"
2049 "}");
2050 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2051}
2052
Daniel Norman85aed542019-08-21 12:01:14 -07002053TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002054 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2055 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002056 "interface IFoo {"
2057 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002058 "}");
2059 io_delegate_.SetFileContents("old/p/Data.aidl",
2060 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002061 "parcelable Data {"
2062 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002063 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002064 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2065 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002066 "interface IFoo {"
2067 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002068 "}");
2069 io_delegate_.SetFileContents("new/p/Data.aidl",
2070 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002071 "parcelable Data {"
2072 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002073 "}");
2074 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2075 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002076 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 " void foo(int a);"
2078 "}");
2079 io_delegate_.SetFileContents("new/q/Data.aidl",
2080 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002081 "parcelable Data {"
2082 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002083 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002084 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2085}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002086
Daniel Norman85aed542019-08-21 12:01:14 -07002087TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2088 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2089 "package p;"
2090 "interface IFoo {"
2091 " void foo(int a);"
2092 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002093 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2094 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002095 "interface IFoo {"
2096 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002097 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002098 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2099}
Jiyong Parke59c3682018-09-11 23:10:25 +09002100
Daniel Norman85aed542019-08-21 12:01:14 -07002101TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002102 io_delegate_.SetFileContents("old/p/I.aidl",
2103 "package p; interface I {"
2104 "const int A = 1; }");
2105 io_delegate_.SetFileContents("new/p/I.aidl",
2106 "package p ; interface I {"
2107 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002108 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2109}
Jiyong Parka428d212018-08-29 22:26:30 +09002110
Daniel Norman85aed542019-08-21 12:01:14 -07002111TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002112 io_delegate_.SetFileContents("old/p/I.aidl",
2113 "package p; interface I {"
2114 "const int A = 1; const int B = 2;}");
2115 io_delegate_.SetFileContents("new/p/I.aidl",
2116 "package p ; interface I {"
2117 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002118 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002119}
2120
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002121TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2122 io_delegate_.SetFileContents("old/p/Foo.aidl",
2123 "package p;"
2124 "@JavaPassthrough(annotation=\"Alice\")"
2125 "@JavaPassthrough(annotation=\"Bob\")"
2126 "parcelable Foo {}");
2127 io_delegate_.SetFileContents("new/p/Foo.aidl",
2128 "package p;"
2129 "@JavaPassthrough(annotation=\"Bob\")"
2130 "@JavaPassthrough(annotation=\"Alice\")"
2131 "parcelable Foo {}");
2132 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2133}
2134
Jooyung Han00073272020-11-27 14:20:20 +09002135TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2136 io_delegate_.SetFileContents("old/p/Foo.aidl",
2137 "package p;"
2138 "parcelable Foo {}");
2139 io_delegate_.SetFileContents("new/p/Foo.aidl",
2140 "package p;"
2141 "@JavaPassthrough(annotation=\"@Deprecated\")"
2142 "parcelable Foo {}");
2143 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2144}
2145
Jooyung Han636fd2f2020-10-22 11:33:45 +09002146TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2147 io_delegate_.SetFileContents("old/p/Data.aidl",
2148 "package p;"
2149 "parcelable Data {"
2150 " int num;"
2151 "}");
2152 io_delegate_.SetFileContents(
2153 "new/p/Data.aidl",
2154 "package p;"
2155 "parcelable Data {"
2156 " int num;"
2157 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2158 "}");
2159 io_delegate_.SetFileContents("new/p/Enum.aidl",
2160 "package p;"
2161 "enum Enum {"
2162 " FOO = 0,"
2163 " BAR = 1,"
2164 "}");
2165 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2166}
2167
Jooyung Han308bbe02021-04-27 12:09:59 +09002168TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2169 io_delegate_.SetFileContents("old/p/Data.aidl",
2170 "package p;\n"
2171 "parcelable Data {\n"
2172 " p.Enum e;\n"
2173 "}");
2174 io_delegate_.SetFileContents("old/p/Enum.aidl",
2175 "package p;\n"
2176 "enum Enum {\n"
2177 " FOO = 0,\n"
2178 " BAR = 1,\n"
2179 "}");
2180 io_delegate_.SetFileContents("new/p/Data.aidl",
2181 "package p;\n"
2182 "parcelable Data {\n"
2183 " p.Enum e = p.Enum.FOO;\n"
2184 "}");
2185 io_delegate_.SetFileContents("new/p/Enum.aidl",
2186 "package p;\n"
2187 "enum Enum {\n"
2188 " FOO = 0,\n"
2189 " BAR = 1,\n"
2190 "}");
2191 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2192}
2193
Daniel Norman85aed542019-08-21 12:01:14 -07002194class AidlTestIncompatibleChanges : public AidlTest {
2195 protected:
2196 Options options_ = Options::From("aidl --checkapi old new");
2197};
2198
2199TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002200 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002201 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2202 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002203 "interface IFoo {"
2204 " void foo(in String[] str);"
2205 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002206 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002207 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002208 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002209 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002210}
2211
2212TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002213 const string expected_stderr =
2214 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002215 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2216 "package p;"
2217 "interface IFoo {"
2218 " void foo(in String[] str);"
2219 " void bar(@utf8InCpp String str);"
2220 "}");
2221 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2222 "package p;"
2223 "interface IFoo {"
2224 " void foo(in String[] str);"
2225 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002226 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002227 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002229}
2230
Jiyong Parkf8d53612020-05-04 14:06:13 +09002231TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2232 const string expected_stderr =
2233 "ERROR: new/p/IFoo.aidl:1.61-65: "
2234 "Encountered an untyped List or Map. The use of untyped List/Map is "
2235 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2236 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2237 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2238 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2239 "package p;"
2240 "interface IFoo {"
2241 " void foo(in String[] str);"
2242 "}");
2243 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2244 "package p;"
2245 "interface IFoo {"
2246 " void foo(in String[] str);"
2247 " void bar(in List arg);"
2248 "}");
2249 CaptureStderr();
2250 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2252}
2253
2254TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2255 const string expected_stderr =
2256 "ERROR: new/p/Data.aidl:1.54-59: "
2257 "Encountered an untyped List or Map. The use of untyped List/Map is "
2258 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2259 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2260 "ERROR: new/p/Data.aidl: Failed to read.\n";
2261 io_delegate_.SetFileContents("old/p/Data.aidl",
2262 "package p;"
2263 "parcelable Data {"
2264 " int foo;"
2265 "}");
2266 io_delegate_.SetFileContents("new/p/Data.aidl",
2267 "package p;"
2268 "parcelable Data {"
2269 " int foo;"
2270 " @nullable List list;"
2271 "}");
2272 CaptureStderr();
2273 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2274 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2275}
2276
Daniel Norman85aed542019-08-21 12:01:14 -07002277TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002278 const string expected_stderr =
2279 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002280 io_delegate_.SetFileContents("old/p/Data.aidl",
2281 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002282 "parcelable Data {"
2283 " int foo;"
2284 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002285 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 io_delegate_.SetFileContents("new/p/Data.aidl",
2287 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002288 "parcelable Data {"
2289 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002290 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002291 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002292 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002293 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002294}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002295
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002296TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2297 const string expected_stderr =
2298 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2299 "backends. Please either provide a default value for this field or mark the field as "
2300 "@nullable. This value or a null value will be used automatically when an old version of "
2301 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2302 "order to make sure your code continues to be backwards compatible, make sure the default or "
2303 "null value does not cause a semantic change to this parcelable.\n";
2304 io_delegate_.SetFileContents("old/p/Data.aidl",
2305 "package p;"
2306 "parcelable Data {"
2307 " int num;"
2308 "}");
2309 io_delegate_.SetFileContents("new/p/Data.aidl",
2310 "package p;"
2311 "parcelable Data {"
2312 " int num;"
2313 " String str;"
2314 "}");
2315 CaptureStderr();
2316 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2317 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2318}
2319
Jooyung Han636fd2f2020-10-22 11:33:45 +09002320TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2321 const string expected_stderr =
2322 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2323 "Please make sure 'Enum' has '0' as a valid value.\n";
2324 io_delegate_.SetFileContents("old/p/Data.aidl",
2325 "package p;"
2326 "parcelable Data {"
2327 " int num;"
2328 "}");
2329 io_delegate_.SetFileContents("new/p/Data.aidl",
2330 "package p;"
2331 "parcelable Data {"
2332 " int num;"
2333 " p.Enum e;"
2334 "}");
2335 io_delegate_.SetFileContents("new/p/Enum.aidl",
2336 "package p;"
2337 "enum Enum {"
2338 " FOO = 1,"
2339 " BAR = 2,"
2340 "}");
2341 CaptureStderr();
2342 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2344}
2345
Daniel Norman85aed542019-08-21 12:01:14 -07002346TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002347 const string expected_stderr =
2348 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002349 io_delegate_.SetFileContents("old/p/Enum.aidl",
2350 "package p;"
2351 "enum Enum {"
2352 " FOO = 1,"
2353 " BAR = 2,"
2354 "}");
2355 io_delegate_.SetFileContents("new/p/Enum.aidl",
2356 "package p;"
2357 "enum Enum {"
2358 " BAR = 2,"
2359 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002360 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002361 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002363}
2364
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002365TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2366 const string expected_stderr =
2367 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2368 io_delegate_.SetFileContents("old/p/Union.aidl",
2369 "package p;"
2370 "union Union {"
2371 " String str;"
2372 " int num;"
2373 "}");
2374 io_delegate_.SetFileContents("new/p/Union.aidl",
2375 "package p;"
2376 "union Union {"
2377 " String str;"
2378 "}");
2379 CaptureStderr();
2380 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2382}
2383
Daniel Norman85aed542019-08-21 12:01:14 -07002384TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002385 const string expected_stderr =
2386 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002387 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2388 "package p;"
2389 "interface IFoo {"
2390 " void foo(in String[] str);"
2391 " void bar(@utf8InCpp String str);"
2392 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002393 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2394 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002395 "interface IFoo {"
2396 " void foo(in String[] str);"
2397 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002398 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002399 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002400 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002401 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002402}
2403
Daniel Norman85aed542019-08-21 12:01:14 -07002404TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002405 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002406 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2407 "package p;"
2408 "interface IFoo {"
2409 " void foo(in String[] str);"
2410 " void bar(@utf8InCpp String str);"
2411 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002412 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2413 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002414 "interface IFoo2 {"
2415 " void foo(in String[] str);"
2416 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002417 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002418 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002419 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002420 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002421}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002422
Daniel Norman85aed542019-08-21 12:01:14 -07002423TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 const string expected_stderr =
2425 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002426 io_delegate_.SetFileContents("old/p/Enum.aidl",
2427 "package p;"
2428 "enum Enum {"
2429 " FOO = 1,"
2430 " BAR = 2,"
2431 "}");
2432 io_delegate_.SetFileContents("new/p/Enum.aidl",
2433 "package p;"
2434 "enum Enum {"
2435 " FOO = 3,"
2436 " BAR = 2,"
2437 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002438 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002439 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002441}
2442
2443TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002444 const string expected_stderr =
2445 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2446 "from 0 to 1.\n"
2447 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2448 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002449 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2450 "package p;"
2451 "interface IFoo {"
2452 " void foo(in String[] str);"
2453 " void bar(@utf8InCpp String str);"
2454 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002455 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2456 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002457 "interface IFoo {"
2458 " void bar(@utf8InCpp String str);"
2459 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002460 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002461 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002462 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002463 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002464}
2465
2466TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002467 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002468 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2469 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002470 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002471 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002472 "parcelable Data {"
2473 " int foo;"
2474 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002475 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002476 io_delegate_.SetFileContents("new/p/Data.aidl",
2477 "package p;"
2478 "parcelable Data {"
2479 " int bar;"
2480 " int foo;"
2481 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002483 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002485}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002486
Daniel Norman85aed542019-08-21 12:01:14 -07002487TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002488 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002489 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002490 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002491 "interface IFoo {"
2492 " void foo(in String[] str);"
2493 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002494 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002495 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2496 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002497 "interface IFoo {"
2498 " void foo(out String[] str);"
2499 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002500 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002501 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002502 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002504}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002505
Daniel Norman85aed542019-08-21 12:01:14 -07002506TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002507 const string expected_stderr =
2508 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002509 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2510 "package p;"
2511 "interface IFoo {"
2512 " void foo(in String[] str);"
2513 " void bar(@utf8InCpp String str);"
2514 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002515 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2516 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002517 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002518 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002519 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002520 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002521 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002522 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002523 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002524}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002525
Daniel Norman85aed542019-08-21 12:01:14 -07002526TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002527 const string expected_stderr =
2528 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002529 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2530 "package p;"
2531 "interface IFoo {"
2532 " void foo(in String[] str);"
2533 " void bar(@utf8InCpp String str);"
2534 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002535 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2536 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002537 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002538 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002539 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002540 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002541 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002542 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002544}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002545
Jooyung Han60b2fde2020-10-29 15:12:40 +09002546TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2547 const string expected_stderr =
2548 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2549 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2550 io_delegate_.SetFileContents("old/p/Foo.aidl",
2551 "package p;"
2552 "@Backing(type=\"byte\")"
2553 "enum Foo {"
2554 " FOO, BAR,"
2555 "}");
2556 io_delegate_.SetFileContents("new/p/Foo.aidl",
2557 "package p;"
2558 "@Backing(type=\"long\")"
2559 "enum Foo {"
2560 " FOO, BAR,"
2561 "}");
2562 CaptureStderr();
2563 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2564 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2565}
2566
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002567TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2568 const string expected_stderr =
2569 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2570 "to @JavaPassthrough(annotation=\"Bob\")\n";
2571 io_delegate_.SetFileContents("old/p/Foo.aidl",
2572 "package p;"
2573 "@JavaPassthrough(annotation=\"Alice\")"
2574 "parcelable Foo {}");
2575 io_delegate_.SetFileContents("new/p/Foo.aidl",
2576 "package p;"
2577 "@JavaPassthrough(annotation=\"Bob\")"
2578 "parcelable Foo {}");
2579
2580 CaptureStderr();
2581 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2582 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2583}
2584
Devin Mooredb7ac512020-08-07 11:17:36 -07002585TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2586 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002587 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002588 io_delegate_.SetFileContents("old/p/Foo.aidl",
2589 "package p;"
2590 "parcelable Foo {"
2591 " int A;"
2592 "}");
2593 io_delegate_.SetFileContents("new/p/Foo.aidl",
2594 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002595 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002596 " int A;"
2597 "}");
2598 CaptureStderr();
2599 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2600 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2601}
2602
2603TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2604 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002605 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002606 io_delegate_.SetFileContents("old/p/Foo.aidl",
2607 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002608 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002609 " int A;"
2610 "}");
2611 io_delegate_.SetFileContents("new/p/Foo.aidl",
2612 "package p;"
2613 "parcelable Foo {"
2614 " int A;"
2615 "}");
2616 CaptureStderr();
2617 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2618 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2619}
2620
Daniel Norman85aed542019-08-21 12:01:14 -07002621TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002622 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002623 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2624 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002625 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002626 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002627 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002628 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002629}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002630
Daniel Norman85aed542019-08-21 12:01:14 -07002631TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002632 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002633 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2634 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002635 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002636 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002637 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002638}
Jiyong Parka428d212018-08-29 22:26:30 +09002639
Daniel Norman85aed542019-08-21 12:01:14 -07002640TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002641 const string expected_stderr =
2642 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002643 io_delegate_.SetFileContents("old/p/I.aidl",
2644 "package p; interface I {"
2645 "const int A = 1; const int B = 2;}");
2646 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002647 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002648 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002649 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002650}
Jiyong Parka428d212018-08-29 22:26:30 +09002651
Daniel Norman85aed542019-08-21 12:01:14 -07002652TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002653 const string expected_stderr =
2654 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002655 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2656 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002657 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002658 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002659 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002660}
2661
Devin Moorec7e47a32020-08-07 10:55:25 -07002662TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2663 const string expected_stderr =
2664 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2665 "This is an incompatible change for FixedSize types.\n";
2666 io_delegate_.SetFileContents("old/p/Foo.aidl",
2667 "package p; @FixedSize parcelable Foo { int A = 1; }");
2668 io_delegate_.SetFileContents("new/p/Foo.aidl",
2669 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2670 CaptureStderr();
2671 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2672 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2673}
2674
2675TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2676 const string expected_stderr =
2677 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2678 io_delegate_.SetFileContents("old/p/Foo.aidl",
2679 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2680 io_delegate_.SetFileContents("new/p/Foo.aidl",
2681 "package p; @FixedSize parcelable Foo { int A = 1; }");
2682 CaptureStderr();
2683 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2684 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2685}
2686
2687TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2688 const string expected_stderr =
2689 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2690 "a.\n"
2691 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2692 "b.\n"
2693 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2694 "c.\n"
2695 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2696 "d.\n"
2697 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2698 "e.\n"
2699 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2700 "f.\n";
2701
2702 io_delegate_.SetFileContents("Foo.aidl",
2703 "@FixedSize parcelable Foo { "
2704 " int[] a;"
2705 " Bar b;"
2706 " String c;"
2707 " ParcelFileDescriptor d;"
2708 " IBinder e;"
2709 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002710 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002711 "}");
2712 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002713 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002714
2715 CaptureStderr();
2716 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2717 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2718}
2719
2720TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2721 const string expected_stderr = "";
2722
2723 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2724 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2725 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002726 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002727
2728 CaptureStderr();
2729 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2730 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2731}
2732
Jiyong Park8c380532018-08-30 14:55:26 +09002733TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002734 const string expected_stderr =
2735 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2736 "dir1/q/IBar.aidl\n"
2737 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002738 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002739 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2740 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2741 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2742 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2743
Devin Moore097a3ab2020-03-11 16:08:44 -07002744 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002745 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002746 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002747}
2748
Jiyong Parked65bf42018-08-28 15:43:27 +09002749TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002750 const string expected_stderr =
2751 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2752 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002753 Options options = Options::From("aidl --checkapi old new");
2754 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2755 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002756
2757 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2758
Jiyong Parke59c3682018-09-11 23:10:25 +09002759 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002760 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002761 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002762 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002763}
2764
Jooyung Han652ce482021-02-26 12:40:35 +09002765TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2766 Options options =
2767 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002768
2769 // use without import
2770 io_delegate_.SetFileContents("p/IFoo.aidl",
2771 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002772 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2773
2774 // capture output files
2775 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09002776
Devin Moore7b8d5c92020-03-17 14:14:08 -07002777 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002778 io_delegate_.SetFileContents(
2779 "p/IFoo.aidl",
2780 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002781 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2782 // output files should be the same
2783 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002784
2785 // use with import (as before)
2786 io_delegate_.SetFileContents("p/IFoo.aidl",
2787 "package p;"
2788 "import android.os.ParcelFileDescriptor;"
2789 "interface IFoo{"
2790 " void foo(in ParcelFileDescriptor fd);"
2791 "}");
Jooyung Han652ce482021-02-26 12:40:35 +09002792 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2793 // output files should be the same
2794 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002795}
Jiyong Parked65bf42018-08-28 15:43:27 +09002796
Jooyung Han020d8d12021-02-26 17:23:02 +09002797TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
2798 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
2799 CaptureStderr();
2800 io_delegate_.SetFileContents("p/IFoo.aidl",
2801 "package p;"
2802 "interface IFoo{"
2803 " void foo(out ParcelFileDescriptor fd);"
2804 "}");
2805 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
2806 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
2807}
2808
2809TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
2810 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
2811 CaptureStderr();
2812 io_delegate_.SetFileContents("p/IFoo.aidl",
2813 "package p;"
2814 "interface IFoo{"
2815 " void foo(ParcelFileDescriptor fd);"
2816 "}");
2817 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
2818 EXPECT_THAT(GetCapturedStderr(),
2819 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
2820}
2821
Jiyong Park3633b722019-04-11 15:38:26 +09002822TEST_F(AidlTest, ManualIds) {
2823 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2824 io_delegate_.SetFileContents("IFoo.aidl",
2825 "interface IFoo {\n"
2826 " void foo() = 0;\n"
2827 " void bar() = 1;\n"
2828 "}");
2829 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2830}
2831
2832TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2833 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2834 io_delegate_.SetFileContents("IFoo.aidl",
2835 "interface IFoo {\n"
2836 " void foo() = 0;\n"
2837 " void bar() = 1;\n"
2838 "}");
2839 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2840}
2841
2842TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002843 const string expected_stderr =
2844 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002845 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2846 io_delegate_.SetFileContents("IFoo.aidl",
2847 "interface IFoo {\n"
2848 " void foo() = 3;\n"
2849 " void bar() = 3;\n"
2850 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002851 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002852 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002853 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002854}
2855
2856TEST_F(AidlTest, FailOnOutOfRangeIds) {
2857 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002858 const string expected_stderr =
2859 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2860 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002861 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2862 io_delegate_.SetFileContents("IFoo.aidl",
2863 "interface IFoo {\n"
2864 " void foo() = 3;\n"
2865 " void bar() = 16777115;\n"
2866 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002867 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002868 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002869 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002870}
2871
2872TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002873 const string expected_stderr =
2874 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002875 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2876 io_delegate_.SetFileContents("IFoo.aidl",
2877 "interface IFoo {\n"
2878 " void foo() = 3;\n"
2879 " void bar();\n"
2880 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002881 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002882 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002883 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002884}
2885
Jiyong Parkc6816252019-07-08 08:12:28 +09002886TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2887 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2888 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2889 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2890 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2891}
2892
2893TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002894 const string expected_stderr =
2895 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2896 "dir/IBar.aidl\n"
2897 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002898 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002899
Jiyong Parkc6816252019-07-08 08:12:28 +09002900 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2901 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2902 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2903 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002904 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002905 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002906 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002907}
2908
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002909TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2910 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2911 "package a.b;\n"
2912 "import a.b.IBar;\n"
2913 "import a.b.IQux;\n"
2914 "interface IFoo { IQux foo(); }\n");
2915 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2916 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2917
2918 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2920
2921 string output;
2922 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2923 // IBar was imported but wasn't used. include is not expected.
2924 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2925 // IBar was imported and used. include is expected.
2926 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2927}
2928
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002929TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002930 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002931 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002932 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2933 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002934 interface IFoo {
2935 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002936 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002937 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002938 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002939 // JavaPassthrough should work with other types as well (e.g. enum)
2940 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2941 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2942 @JavaPassthrough(annotation="@com.android.AliceTwo")
2943 @Backing(type="byte")
2944 enum MyEnum {
2945 a, b, c
2946 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002947
Jooyung Han4cde01d2020-10-13 11:10:47 +09002948 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002949 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2950
2951 string java_out;
2952 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002953 // type-decl-level annotations with newline at the end
2954 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2955 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2956 // member-decl-level annotations with newline at the end
2957 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2958 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2959 // inline annotations with space at the end
2960 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002961
Jooyung Han4cde01d2020-10-13 11:10:47 +09002962 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2963 // type-decl-level annotations with newline at the end
2964 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2965 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2966
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002967 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002968 Options cpp_options =
2969 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002970 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2971
Jooyung Han4cde01d2020-10-13 11:10:47 +09002972 Options ndk_options =
2973 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002974 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002975
Jooyung Han4cde01d2020-10-13 11:10:47 +09002976 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002977 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002978}
2979
Andrei Homescue61feb52020-08-18 15:44:24 -07002980TEST_F(AidlTest, ParseRustDerive) {
2981 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2982 @RustDerive(Clone=true, Copy=false)
2983 parcelable Foo {
2984 int a;
2985 })");
2986
2987 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2988 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2989
2990 string rust_out;
2991 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2992 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2993
2994 // Other backends shouldn't be bothered
2995 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2996 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2997
2998 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2999 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
3000
3001 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
3002 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3003}
3004
Jiyong Park56f73d72019-06-11 12:20:28 +09003005class AidlOutputPathTest : public AidlTest {
3006 protected:
3007 void SetUp() override {
3008 AidlTest::SetUp();
3009 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3010 }
3011
3012 void Test(const Options& options, const std::string expected_output_path) {
3013 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3014 // check the existence
3015 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3016 }
3017};
3018
3019TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3020 // <out_dir> / <package_name> / <type_name>.java
3021 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3022}
3023
3024TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3025 // when output file is explicitly set, it is always respected. -o option is
3026 // ignored.
3027 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3028}
3029
3030TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3031 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3032}
3033
3034TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3035 // output is the same as the input file except for the suffix
3036 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3037}
3038
Devin Moore7b8d5c92020-03-17 14:14:08 -07003039TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003040 AidlError error;
3041 const string expected_stderr =
3042 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3043 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003044 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3045 R"(package p;
3046 interface IFoo {
3047 const int int32_max_oob = 2147483650;
3048 }
3049 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003050 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003051 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3052 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003053}
3054
Devin Moore7b8d5c92020-03-17 14:14:08 -07003055TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003056 AidlError error;
3057 const string expected_stderr =
3058 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3059 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003060 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3061 R"(package p;
3062 interface IFoo {
3063 const int int32_min_oob = -2147483650;
3064 }
3065 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003066 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003067 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3068 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003069}
3070
Devin Moore7b8d5c92020-03-17 14:14:08 -07003071TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003072 AidlError error;
3073 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003074 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003075 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003076 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3077 R"(package p;
3078 interface IFoo {
3079 const long int64_max_oob = 21474836509999999999999999;
3080 }
3081 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003082 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003083 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3084 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003085}
3086
Devin Moore7b8d5c92020-03-17 14:14:08 -07003087TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003088 AidlError error;
3089 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003090 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003091 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003092 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3093 R"(package p;
3094 interface IFoo {
3095 const long int64_min_oob = -21474836509999999999999999;
3096 }
3097 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003098 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003099 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3100 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003101}
3102
Devin Moore7b8d5c92020-03-17 14:14:08 -07003103TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003104 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003105 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003106 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003107 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3108 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003109 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3110 R"(package p;
3111 @Backing(type="byte")
3112 enum TestEnum {
3113 FOO = 127,
3114 BAR,
3115 }
3116 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003117 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003119 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003120}
3121
Devin Mooredecaf292020-04-30 09:16:40 -07003122TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3123 AidlError error;
3124 const string expected_stderr =
3125 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003126 "be one of: type\n";
3127 CaptureStderr();
3128 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3129 R"(package p;
3130 @Backing(foo="byte")
3131 enum TestEnum {
3132 FOO = 1,
3133 BAR,
3134 }
3135 )",
3136 typenames_, GetLanguage(), &error));
3137 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3138 EXPECT_EQ(AidlError::BAD_TYPE, error);
3139}
3140
Jooyung Han5721a232020-12-24 04:34:55 +09003141TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3142 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3143 CaptureStderr();
3144 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3145 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3146}
3147
Jooyung Han66813932020-10-23 13:24:44 +09003148TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003149 io_delegate_.SetFileContents("Foo.aidl",
3150 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3151 "Map<String, Baz> d; Bar[] e; }");
3152 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3153 io_delegate_.SetFileContents("Baz.aidl",
3154 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003155 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3156 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3157}
3158
Jooyung Han66813932020-10-23 13:24:44 +09003159TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003160 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003161 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003162 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003163 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3164 "named 'bar'.\n";
3165 CaptureStderr();
3166 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3167 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3168 EXPECT_EQ(expected_error, GetCapturedStderr());
3169}
3170
3171TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3172 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3173 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3174 string expected_error =
3175 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003176 "named 'bar'.\n";
3177 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003178 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3179 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003180 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003181}
3182
Jooyung Han66813932020-10-23 13:24:44 +09003183TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003184 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003185 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3186 string expected_error =
3187 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3188 "only be an in parameter.\n";
3189 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003190 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3191 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003192 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003193}
3194
Jooyung Han66813932020-10-23 13:24:44 +09003195TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003196 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003197 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3198 string expected_error =
3199 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3200 "only be an in parameter.\n";
3201 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003202 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3203 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003204 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003205}
3206
Jooyung Han66813932020-10-23 13:24:44 +09003207TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003208 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003209 Options options = Options::From("aidl --lang=java Foo.aidl");
3210 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003211 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3212 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003213 CaptureStderr();
3214 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3216}
Devin Moore53fc99c2020-08-12 08:07:52 -07003217
Jooyung Hanfe086af2021-01-16 03:44:47 +09003218TEST_P(AidlTest, UnionInUnion) {
3219 import_paths_.insert(".");
3220 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3221 CaptureStderr();
3222 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3223 EXPECT_THAT("", GetCapturedStderr());
3224}
3225
Jooyung Hanfe89f122020-10-14 03:49:18 +09003226TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3227 const string method = "package a; union Foo {}";
3228 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3229 CaptureStderr();
3230 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3231 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3232}
3233
3234TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3235 const string method = "package a; union Foo { ParcelableHolder x; }";
3236 const string expected_stderr =
3237 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3238 CaptureStderr();
3239 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3240 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3241}
3242
Jooyung Han53fb4242020-12-17 16:03:49 +09003243TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3244 import_paths_.insert(".");
3245 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3246 const string expected_err = "The union's first member should have a useful default value.";
3247 CaptureStderr();
3248 EXPECT_EQ(nullptr,
3249 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3250 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3251}
3252
Devin Moore53fc99c2020-08-12 08:07:52 -07003253TEST_P(AidlTest, GenericStructuredParcelable) {
3254 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003255 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003256 const string expected_stderr = "";
3257 CaptureStderr();
3258 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3260}
3261
Jooyung Han3f347ca2020-12-01 12:41:50 +09003262TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3263 io_delegate_.SetFileContents("Foo.aidl",
3264 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3265 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003266 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003267 const string expected_stderr = "";
3268 CaptureStderr();
3269 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3270 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3271
3272 string code;
3273 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3274 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3275const ::android::String16& Foo<T,U>::s() {
3276 static const ::android::String16 value(::android::String16(""));
3277 return value;
3278})--"));
3279}
3280
3281TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3282 io_delegate_.SetFileContents("Foo.aidl",
3283 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3284 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003285 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003286 const string expected_stderr = "";
3287 CaptureStderr();
3288 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3290
3291 string code;
3292 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3293 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3294const char* Foo<T, U>::s = "";
3295)--"));
3296}
3297
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003298TEST_F(AidlTest, NestedTypeArgs) {
3299 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003300 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3301
3302 io_delegate_.SetFileContents("a/Foo.aidl",
3303 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3304 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003305 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3306 const string expected_stderr = "";
3307 CaptureStderr();
3308 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3310
3311 string code;
3312 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003313 EXPECT_THAT(code,
3314 testing::HasSubstr(
3315 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3316}
3317
3318TEST_F(AidlTest, DoubleArrayError) {
3319 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3320
3321 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3322 const string expected_stderr =
3323 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3324 CaptureStderr();
3325 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3326 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3327}
3328
3329TEST_F(AidlTest, DoubleGenericError) {
3330 io_delegate_.SetFileContents("a/Bar.aidl",
3331 "package a; parcelable Bar { List<String><String> a; }");
3332
3333 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3334 const string expected_stderr =
3335 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3336 CaptureStderr();
3337 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3338 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3339}
3340
3341TEST_F(AidlTest, ArrayBeforeGenericError) {
3342 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3343
3344 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003345 CaptureStderr();
3346 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003347 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3348}
3349
3350TEST_F(AidlTest, NullableArraysAreNotSupported) {
3351 io_delegate_.SetFileContents("a/Bar.aidl",
3352 "package a; parcelable Bar { String @nullable [] a; }");
3353
3354 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3355 CaptureStderr();
3356 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3357 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3358}
3359
3360TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3361 io_delegate_.SetFileContents("a/Bar.aidl",
3362 "package a; parcelable Bar { List<@nullable String> a; }");
3363
3364 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3365 CaptureStderr();
3366 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3367 EXPECT_THAT(GetCapturedStderr(),
3368 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003369}
3370
Jooyung Han14004ed2020-10-16 03:49:57 +09003371struct GenericAidlTest : ::testing::Test {
3372 FakeIoDelegate io_delegate_;
3373 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003374 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003375 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3376 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3377 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3378
3379 Options options = Options::From(cmd);
3380 CaptureStderr();
3381 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3382 EXPECT_EQ("", GetCapturedStderr());
3383 }
3384};
3385
3386TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3387 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3388 string code;
3389 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3390 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3391 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3392 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3393}
3394
3395TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3396 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3397 string code;
3398 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3399 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3400 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3401 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3402}
3403
Devin Moore53fc99c2020-08-12 08:07:52 -07003404TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3405 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003406 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003407 const string expected_stderr =
3408 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3409 CaptureStderr();
3410 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3411 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3412}
3413
3414TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3415 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003416 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003417 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3418 CaptureStderr();
3419 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3420 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3421}
3422
Jooyung Han7a308842020-10-27 19:06:49 +09003423TEST_P(AidlTest, LongCommentWithinConstExpression) {
3424 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003425 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003426 CaptureStderr();
3427 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3428 EXPECT_EQ("", GetCapturedStderr());
3429}
3430
Jeongik Chaef44e622020-10-23 16:00:52 +09003431TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3432 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3433 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3434 std::string expectedErr =
3435 "ERROR: a/Foo.aidl:1.28-30: "
3436 "Encountered an untyped List or Map. The use of untyped List/Map is "
3437 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3438 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3439 "ERROR: a/Foo.aidl:1.35-37: "
3440 "Encountered an untyped List or Map. The use of untyped List/Map is "
3441 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3442 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3443 CaptureStderr();
3444 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3445 EXPECT_EQ(expectedErr, GetCapturedStderr());
3446}
3447
3448TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003449 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3450 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003451 std::string expectedErr =
3452 "ERROR: a/Foo.aidl:1.33-35: "
3453 "Encountered an untyped List or Map. The use of untyped List/Map is "
3454 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3455 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3456 "ERROR: a/Foo.aidl:1.40-42: "
3457 "Encountered an untyped List or Map. The use of untyped List/Map is "
3458 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3459 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003460 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003461 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3462 EXPECT_EQ(expectedErr, GetCapturedStderr());
3463}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003464
Jeongik Chaef44e622020-10-23 16:00:52 +09003465TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3466 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3467 io_delegate_.SetFileContents(
3468 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3469 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3470 std::string expectedErr =
3471 "ERROR: a/Foo.aidl:1.52-54: "
3472 "Encountered an untyped List or Map. The use of untyped List/Map is "
3473 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3474 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3475 "ERROR: a/Foo.aidl:1.64-66: "
3476 "Encountered an untyped List or Map. The use of untyped List/Map is "
3477 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3478 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3479 CaptureStderr();
3480 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3481 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003482}
3483
Jooyung Han690f5842020-12-04 13:02:04 +09003484TEST_F(AidlTest, EnumWithDefaults_Java) {
3485 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3486 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3487package p;
3488import p.Enum;
3489parcelable Foo {
3490 Enum e = Enum.BAR;
3491})");
3492 CaptureStderr();
3493 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3494 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3495 auto err = GetCapturedStderr();
3496 EXPECT_EQ("", err);
3497
3498 string code;
3499 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003500 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003501}
3502
3503TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3504 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3505 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3506package p;
3507import p.Enum;
3508parcelable Foo {
3509 Enum e = Enum.BAR;
3510})");
3511 CaptureStderr();
3512 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3513 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3514 auto err = GetCapturedStderr();
3515 EXPECT_EQ("", err);
3516
3517 string code;
3518 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3519 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3520}
3521
3522TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3523 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3524 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3525package p;
3526import p.Enum;
3527parcelable Foo {
3528 Enum e = Enum.BAR;
3529})");
3530 CaptureStderr();
3531 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3532 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3533 auto err = GetCapturedStderr();
3534 EXPECT_EQ("", err);
3535
3536 string code;
3537 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3538 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3539}
3540
3541TEST_F(AidlTest, EnumWithDefaults_Rust) {
3542 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3543 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3544package p;
3545import p.Enum;
3546parcelable Foo {
3547 int n = 42;
3548 Enum e = Enum.BAR;
3549})");
3550 CaptureStderr();
3551 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3552 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3553 auto err = GetCapturedStderr();
3554 EXPECT_EQ("", err);
3555
3556 string code;
3557 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3558 EXPECT_THAT(code, testing::HasSubstr(R"(
3559 fn default() -> Self {
3560 Self {
3561 n: 42,
3562 e: crate::mangled::_1_p_4_Enum::BAR,
3563 }
3564 })"));
3565}
3566
3567TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3568 import_paths_.insert("a");
3569 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3570 CaptureStderr();
3571 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3572package p;
3573import p.Enum;
3574parcelable Foo {
3575 int e = Enum.FOO | Enum.BAR;
3576})",
3577 typenames_, GetLanguage());
3578 auto err = GetCapturedStderr();
3579 EXPECT_EQ("", err);
3580 EXPECT_TRUE(type);
3581 const auto& fields = type->AsStructuredParcelable()->GetFields();
3582 EXPECT_EQ("int e = 3", fields[0]->ToString());
3583}
3584
3585TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3586 CaptureStderr();
3587 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3588@Backing(type="int")
3589enum Foo {
3590 STANDARD_SHIFT = 16,
3591 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3592 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3593}
3594)",
3595 typenames_, GetLanguage());
3596 auto err = GetCapturedStderr();
3597 EXPECT_EQ("", err);
3598 EXPECT_TRUE(type);
3599 const auto& enum_type = type->AsEnumDeclaration();
3600 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003601 auto writer = CodeWriter::ForString(&code);
3602 DumpVisitor visitor(*writer);
3603 visitor.Visit(*enum_type);
3604 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003605 EXPECT_EQ(R"--(@Backing(type="int")
3606enum Foo {
3607 STANDARD_SHIFT = 16,
3608 STANDARD_BT709 = 65536,
3609 STANDARD_BT601_625 = 131072,
3610}
3611)--",
3612 code);
3613}
3614
3615TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3616 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3617 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3618package p;
3619import p.Enum;
3620parcelable Foo {
3621 Enum e = Enum.FOO | Enum.BAR;
3622})");
3623 CaptureStderr();
3624 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3625 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3626 auto err = GetCapturedStderr();
3627 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3628 err);
3629}
3630
3631TEST_P(AidlTest, DefaultWithEmptyArray) {
3632 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3633 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3634 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003635 auto options =
3636 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003637 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3638 auto err = GetCapturedStderr();
3639 EXPECT_EQ("", err);
3640}
3641
3642TEST_P(AidlTest, RejectRefsInAnnotation) {
3643 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3644 "package p; interface IFoo {\n"
3645 " const String ANNOTATION = \"@Annotation\";\n"
3646 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3647 "}");
3648 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003649 auto options =
3650 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003651 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3652 auto err = GetCapturedStderr();
3653 EXPECT_EQ(
3654 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3655 "ANNOTATION.\n",
3656 err);
3657}
3658
3659TEST_F(AidlTest, DefaultWithEnumValues) {
3660 io_delegate_.SetFileContents(
3661 "a/p/Foo.aidl",
3662 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3663 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3664 CaptureStderr();
3665 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3666 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3667 auto err = GetCapturedStderr();
3668 EXPECT_EQ("", err);
3669 string code;
3670 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3671 EXPECT_THAT(
3672 code, testing::HasSubstr(
3673 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3674}
3675
Jooyung Han14259392020-12-07 10:00:08 +09003676TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3677 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3678 CaptureStderr();
3679 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3680 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3681 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003682 EXPECT_EQ(
3683 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3684 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3685 err);
Jooyung Han14259392020-12-07 10:00:08 +09003686}
3687
3688TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3689 io_delegate_.SetFileContents("a/p/Foo.aidl",
3690 "package p; parcelable Foo { const int A = A + 1; }");
3691 CaptureStderr();
3692 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3693 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3694 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003695 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3696}
3697
3698TEST_F(AidlTest, RecursiveReferences) {
3699 io_delegate_.SetFileContents("a/p/Foo.aidl",
3700 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3701 io_delegate_.SetFileContents("a/p/Bar.aidl",
3702 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3703 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3704 CaptureStderr();
3705 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3706 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3707 EXPECT_EQ("", GetCapturedStderr());
3708}
3709
Jooyung Hane9f5b272021-01-07 00:18:11 +09003710TEST_P(AidlTest, UnknownConstReference) {
3711 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3712 auto options =
3713 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3714 const string err =
3715 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3716 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3717 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3718 CaptureStderr();
3719 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3720 EXPECT_EQ(err, GetCapturedStderr());
3721}
3722
Jooyung Han29813842020-12-08 01:28:03 +09003723TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3724 string contents = R"(
3725import android.os.IBinder;
3726import android.os.IInterface;
3727interface IFoo {}
3728 )";
3729 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003730}
3731
Jooyung Han888c5bc2020-12-22 17:28:47 +09003732TEST_P(AidlTest, WarningInterfaceName) {
3733 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003734 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003735 " -Weverything -o out -h out p/Foo.aidl");
3736 CaptureStderr();
3737 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003738 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003739 GetCapturedStderr());
3740}
3741
3742TEST_P(AidlTest, ErrorInterfaceName) {
3743 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003744 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003745 " -Weverything -Werror -o out -h out p/Foo.aidl");
3746 CaptureStderr();
3747 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003748 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003749 GetCapturedStderr());
3750}
3751
Jiyong Park9f4c3822021-04-07 20:36:45 +09003752TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
3753 const std::string input_file = "base/p/q/IFoo.aidl";
3754 const std::string header_dir = "out/";
3755 const std::string output_file = "out/base/p/q/IFoo.cpp";
3756 const std::string package = "p.q"; // not base.p.q
3757 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
3758
3759 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
3760 CaptureStderr();
3761 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3762 EXPECT_THAT(
3763 GetCapturedStderr(),
3764 testing::StartsWith(
3765 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
3766 "but is out/base/p/q/IFoo.cpp."));
3767}
3768
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09003769TEST_F(AidlTest, FormatCommentsForJava) {
3770 using android::aidl::FormatCommentsForJava;
3771
3772 struct TestCase {
3773 vector<Comment> comments;
3774 string formatted;
3775 };
3776 vector<TestCase> testcases = {
3777 {{}, ""},
3778 {{{"// line comments\n"}}, "// line comments\n"},
3779 {{{"// @hide \n"}}, "// @hide \n"},
3780 // Transform the last block comment as Javadoc.
3781 {{{"/*\n"
3782 " * Hello, world!\n"
3783 " */"}},
3784 "/**\n"
3785 " * Hello, world!\n"
3786 " */"},
3787 {{{"/* @hide */"}}, "/** @hide */"},
3788 {{{"/**\n"
3789 " @param foo ...\n"
3790 "*/"}},
3791 "/**\n"
3792 " @param foo ...\n"
3793 "*/"},
3794 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
3795 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
3796 "/* @deprecated first *//** @deprecated second */"},
3797 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
3798 // Line comments are printed as they are
3799 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
3800 };
3801 for (const auto& [input, formatted] : testcases) {
3802 EXPECT_EQ(formatted, FormatCommentsForJava(input));
3803 }
3804}
3805
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003806TEST_F(AidlTest, HideIsNotForArgs) {
3807 io_delegate_.SetFileContents("IFoo.aidl",
3808 "interface IFoo {\n"
3809 " void foo(in @Hide int x);\n"
3810 "}");
3811 auto options = Options::From("aidl --lang=java IFoo.aidl");
3812 CaptureStderr();
3813 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3814 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3815}
3816
3817TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3818 io_delegate_.SetFileContents(
3819 "IFoo.aidl",
3820 "interface IFoo {\n"
3821 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3822 "}");
3823 auto options = Options::From("aidl --lang=java IFoo.aidl");
3824 CaptureStderr();
3825 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3826 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3827}
3828
Jooyung Hanfd3be322020-12-13 09:11:06 +09003829struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003830 string kind;
3831 string literal;
3832};
3833
Jooyung Hanfd3be322020-12-13 09:11:06 +09003834const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09003835 {"primitive", "int"}, {"primitiveArray", "int[]"},
3836 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003837 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3838 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3839 {"union", "a.Union"}, {"interface", "a.IBar"},
3840};
3841
3842const std::map<std::string, std::string> kListSupportExpectations = {
3843 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3844 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3845 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3846 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09003847 {"cpp_primitiveArray", "List of arrays is not supported."},
3848 {"java_primitiveArray", "List of arrays is not supported."},
3849 {"ndk_primitiveArray", "List of arrays is not supported."},
3850 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003851 {"cpp_String", ""},
3852 {"java_String", ""},
3853 {"ndk_String", ""},
3854 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09003855 {"cpp_StringArray", "List of arrays is not supported."},
3856 {"java_StringArray", "List of arrays is not supported."},
3857 {"ndk_StringArray", "List of arrays is not supported."},
3858 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003859 {"cpp_IBinder", ""},
3860 {"java_IBinder", ""},
3861 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3862 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003863 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003864 {"java_ParcelFileDescriptor", ""},
3865 {"ndk_ParcelFileDescriptor", ""},
3866 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003867 {"cpp_interface", "List<a.IBar> is not supported."},
3868 {"java_interface", "List<a.IBar> is not supported."},
3869 {"ndk_interface", "List<a.IBar> is not supported."},
3870 {"rust_interface", "List<a.IBar> is not supported."},
3871 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003872 {"java_parcelable", ""},
3873 {"ndk_parcelable", ""},
3874 {"rust_parcelable", ""},
3875 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3876 {"java_enum", "A generic type cannot have any primitive type parameters."},
3877 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3878 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003879 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003880 {"java_union", ""},
3881 {"ndk_union", ""},
3882 {"rust_union", ""},
3883};
3884
Jooyung Hand236e552020-12-13 09:21:27 +09003885const std::map<std::string, std::string> kArraySupportExpectations = {
3886 {"cpp_primitive", ""},
3887 {"java_primitive", ""},
3888 {"ndk_primitive", ""},
3889 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09003890 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
3891 {"java_primitiveArray", "Can only have one dimensional arrays."},
3892 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
3893 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09003894 {"cpp_String", ""},
3895 {"java_String", ""},
3896 {"ndk_String", ""},
3897 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09003898 {"cpp_StringArray", "Can only have one dimensional arrays."},
3899 {"java_StringArray", "Can only have one dimensional arrays."},
3900 {"ndk_StringArray", "Can only have one dimensional arrays."},
3901 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09003902 {"cpp_IBinder", ""},
3903 {"java_IBinder", ""},
3904 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3905 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3906 {"cpp_ParcelFileDescriptor", ""},
3907 {"java_ParcelFileDescriptor", ""},
3908 {"ndk_ParcelFileDescriptor", ""},
3909 {"rust_ParcelFileDescriptor", ""},
3910 {"cpp_interface", "Binder type cannot be an array"},
3911 {"java_interface", "Binder type cannot be an array"},
3912 {"ndk_interface", "Binder type cannot be an array"},
3913 {"rust_interface", "Binder type cannot be an array"},
3914 {"cpp_parcelable", ""},
3915 {"java_parcelable", ""},
3916 {"ndk_parcelable", ""},
3917 {"rust_parcelable", ""},
3918 {"cpp_enum", ""},
3919 {"java_enum", ""},
3920 {"ndk_enum", ""},
3921 {"rust_enum", ""},
3922 {"cpp_union", ""},
3923 {"java_union", ""},
3924 {"ndk_union", ""},
3925 {"rust_union", ""},
3926};
3927
Jooyung Hanfd3be322020-12-13 09:11:06 +09003928class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003929 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003930 void Run(const std::string& generic_type_decl,
3931 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003932 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003933 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003934 const auto& kind = std::get<1>(param).kind;
3935
3936 FakeIoDelegate io;
3937 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3938 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3939 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003940 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3941 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003942
3943 const auto options =
3944 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3945 CaptureStderr();
3946 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003947 auto it = expectations.find(lang + "_" + kind);
3948 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003949 const string err = GetCapturedStderr();
3950 if (it->second.empty()) {
3951 EXPECT_EQ("", err);
3952 } else {
3953 EXPECT_THAT(err, testing::HasSubstr(it->second));
3954 }
3955 }
3956};
3957
3958INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003959 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003960 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3961 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003962 testing::ValuesIn(kTypeParams)),
3963 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003964 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003965 });
3966
Jooyung Hanfd3be322020-12-13 09:11:06 +09003967TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3968 Run("List<{}>", kListSupportExpectations);
3969}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003970
Jooyung Hand236e552020-12-13 09:21:27 +09003971TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3972 Run("{}[]", kArraySupportExpectations);
3973}
3974
Christopher Wiley90be4e32015-10-20 14:55:25 -07003975} // namespace aidl
3976} // namespace android