blob: ef134fb809ffcd610903edb8a21a66de7c2e127b [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900395 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700425 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
428 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800429}
430
Devin Moore7b8d5c92020-03-17 14:14:08 -0700431TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700432 AidlError error;
433 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
434 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800435 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900436 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700437 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700438 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
440 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800441}
442
Devin Moore7b8d5c92020-03-17 14:14:08 -0700443TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 AidlError error;
445 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
446 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000447 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900448 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900449 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700450 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000451 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700452 EXPECT_EQ(expected_stderr, GetCapturedStderr());
453 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800454}
455
Devin Moore7b8d5c92020-03-17 14:14:08 -0700456TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700457 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000458 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900461 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700462 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700463 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000464 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
466 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800467}
468
Jiyong Park40782d02020-07-24 19:17:43 +0900469TEST_P(AidlTest, ParsesNonNullableAnnotation) {
470 auto parse_result =
471 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
472 ASSERT_NE(nullptr, parse_result);
473 const AidlInterface* interface = parse_result->AsInterface();
474 ASSERT_NE(nullptr, interface);
475 ASSERT_FALSE(interface->GetMethods().empty());
476 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
477}
478
Devin Moore7b8d5c92020-03-17 14:14:08 -0700479TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900480 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
481 typenames_, GetLanguage());
482 ASSERT_NE(nullptr, parse_result);
483 const AidlInterface* interface = parse_result->AsInterface();
484 ASSERT_NE(nullptr, interface);
485 ASSERT_FALSE(interface->GetMethods().empty());
486 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
487}
488
489TEST_P(AidlTest, ParsesNonUtf8Annotations) {
490 auto parse_result =
491 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
492 ASSERT_NE(nullptr, parse_result);
493 const AidlInterface* interface = parse_result->AsInterface();
494 ASSERT_NE(nullptr, interface);
495 ASSERT_FALSE(interface->GetMethods().empty());
496 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800497}
498
Devin Moore7b8d5c92020-03-17 14:14:08 -0700499TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900500 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
501 typenames_, GetLanguage());
502 ASSERT_NE(nullptr, parse_result);
503 const AidlInterface* interface = parse_result->AsInterface();
504 ASSERT_NE(nullptr, interface);
505 ASSERT_FALSE(interface->GetMethods().empty());
506 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800507}
508
Devin Moore7b8d5c92020-03-17 14:14:08 -0700509TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700511 const string expected_stderr =
512 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
513 "\"vintf\"'\n"
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
515 "--structured\n";
516 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700517 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700518 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700519 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700520 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521}
522
Devin Moore7b8d5c92020-03-17 14:14:08 -0700523TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700524 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700525 const string expected_stderr =
526 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
527 "--structured\n";
528 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700529 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700530 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700531 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700532 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533}
534
Devin Moore7b8d5c92020-03-17 14:14:08 -0700535TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700536 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700537 const string expected_stderr =
538 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
539 "\"vintf\"'\n";
540 CaptureStderr();
541 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700542 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700544 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545}
546
Devin Moore7b8d5c92020-03-17 14:14:08 -0700547TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700548 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
550 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700551 ASSERT_EQ(AidlError::OK, error);
552 ASSERT_NE(nullptr, parse_result);
553 const AidlInterface* interface = parse_result->AsInterface();
554 ASSERT_NE(nullptr, interface);
555 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700556}
557
Jeongik Cha64783ed2019-06-07 18:30:54 +0900558TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
559 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900560 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
561 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900562 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700563 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900565 "a/Foo.aidl",
566 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900567
568 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900569 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700570 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700572 "Parcelable must be defined in AIDL directly.\n";
573 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900574 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700576
577 CaptureStderr();
578 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900580}
581
Jooyung Han1cbc4962020-10-25 10:07:15 +0900582TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
583 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
584 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
585 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
587
588 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900589 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900590 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
591
592 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900593 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900594 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
595
Jooyung Han1cbc4962020-10-25 10:07:15 +0900596 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900597 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
598}
599
Jooyung Han1cbc4962020-10-25 10:07:15 +0900600TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
601 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
602 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
603 CaptureStderr();
604 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
605 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
606 EXPECT_EQ("", GetCapturedStderr());
607
608 const string expected_to_string_method = R"--(
609 @Override
610 public String toString() {
611 switch (_tag) {
612 case a: return "a.Foo.a(" + (getA()) + ")";
613 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
614 }
615 throw new IllegalStateException("unknown field: " + _tag);
616 }
617)--";
618
619 string java_out;
620 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
621 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
622}
623
Jooyung Han90345002020-10-23 15:28:53 +0900624TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900625 {
Jooyung Han90345002020-10-23 15:28:53 +0900626 io_delegate_.SetFileContents("a/Foo.aidl",
627 "package a; @JavaDerive(blah=true) parcelable Foo{}");
628 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
629 CaptureStderr();
630 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
631 const std::string expected_stderr =
632 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
633 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
634 }
635
636 {
637 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
639 CaptureStderr();
640 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
641 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900642 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900643 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
644 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900645 EXPECT_EQ(expected_stderr, GetCapturedStderr());
646 }
647
648 {
Jooyung Han90345002020-10-23 15:28:53 +0900649 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900650 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
651 CaptureStderr();
652 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
653 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900654 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900655 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
657 }
658}
659
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900660TEST_P(AidlTest, ParseDescriptorAnnotation) {
661 AidlError error;
662 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
663 typenames_, GetLanguage(), &error, {"--structured"});
664 ASSERT_EQ(AidlError::OK, error);
665 ASSERT_NE(nullptr, parse_result);
666 const AidlInterface* interface = parse_result->AsInterface();
667 ASSERT_NE(nullptr, interface);
668 ASSERT_EQ("IBar", interface->GetDescriptor());
669}
670
Jiyong Park40782d02020-07-24 19:17:43 +0900671TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700672 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700673 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900674}
675
676TEST_P(AidlTest, AcceptsOnewayInterface) {
677 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700678 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700679}
Christopher Wileyef140932015-11-03 09:29:19 -0800680
Devin Moore7b8d5c92020-03-17 14:14:08 -0700681TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700682 const string oneway_method =
683 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700684 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100685}
686
Steven Moreland65297cc2020-04-20 20:17:36 -0700687TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
688 const string oneway_method =
689 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
690 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
691 ASSERT_NE(nullptr, defined);
692 const AidlInterface* iface = defined->AsInterface();
693 ASSERT_NE(nullptr, iface);
694
695 const auto& methods = iface->GetMethods();
696 ASSERT_EQ(1u, methods.size());
697 const auto& method = methods[0];
698 const AidlTypeSpecifier& ret_type = method->GetType();
699
700 // TODO(b/151102494): these annotations should be on the method
701 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
702 ASSERT_TRUE(ret_type.IsHide());
703}
704
Devin Moore7b8d5c92020-03-17 14:14:08 -0700705TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100706 string foo_interface =
707 "package a; /* foo */ interface IFoo {"
708 " /* i */ int i();"
709 " /* j */ @nullable String j();"
710 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
711
Devin Moore7b8d5c92020-03-17 14:14:08 -0700712 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100713 EXPECT_NE(nullptr, parse_result);
714 EXPECT_EQ("/* foo */", parse_result->GetComments());
715
716 const AidlInterface* interface = parse_result->AsInterface();
717 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
718 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
719 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
720}
721
Jooyung Han1a551d32020-10-05 15:37:26 +0900722TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
723 io_delegate_.SetFileContents("p/cpp_header.aidl",
724 R"(package p;
725 parcelable cpp_header cpp_header "bar/header";)");
726 import_paths_.emplace("");
727 const string input_path = "p/IFoo.aidl";
728 const string input = R"(package p;
729 import p.cpp_header;
730 interface IFoo {
731 // get bar
732 cpp_header get();
733 })";
734
735 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
736 EXPECT_NE(nullptr, parse_result);
737 const AidlInterface* interface = parse_result->AsInterface();
738 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
739}
740
Christopher Wileyef140932015-11-03 09:29:19 -0800741TEST_F(AidlTest, ParsesPreprocessedFile) {
742 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
743 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700744 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900745 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700746 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
747 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800748}
749
750TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
751 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
752 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900753
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700754 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900755 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700756 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
757 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800758}
759
Devin Moore7b8d5c92020-03-17 14:14:08 -0700760TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800761 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
762 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
763 "interface IBar {}");
764 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900765 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900766 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700767 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800768 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900769
Christopher Wiley41544372015-11-03 14:52:29 -0800770 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700771 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
772 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800773 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700774 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900775 ambiguous_type.Resolve(typenames_);
776 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800777}
778
Jiyong Park8f6ec462020-01-19 20:52:47 +0900779// Special case of PreferImportToPreprocessed. Imported type should be preferred
780// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700781TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900782 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
783 io_delegate_.SetFileContents("one/IBar.aidl",
784 "package one; "
785 "interface IBar {}");
786 preprocessed_files_.push_back("preprocessed");
787 import_paths_.emplace("");
788 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700789 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900790 EXPECT_NE(nullptr, parse_result);
791
792 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700793 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
794 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900795 // But if we request just "IBar" we should get our imported one.
796 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
797 ambiguous_type.Resolve(typenames_);
798 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
799}
800
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800801TEST_F(AidlTest, WritePreprocessedFile) {
802 io_delegate_.SetFileContents("p/Outer.aidl",
803 "package p; parcelable Outer.Inner;");
804 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
805 "interface IBar {}");
806
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900807 vector<string> args {
808 "aidl",
809 "--preprocess",
810 "preprocessed",
811 "p/Outer.aidl",
812 "one/IBar.aidl"};
813 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800814 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
815
816 string output;
817 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
818 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
819}
820
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900821TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100822 io_delegate_.SetFileContents(
823 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800824 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100825 "parcelable Rect {\n"
826 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800827 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100828 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800829 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100830 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100831 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
832 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100833 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900834 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900835 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100836 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900837
838 vector<string> args{"aidl", "Rect.aidl"};
839 Options options = Options::From(args);
840 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
841
842 string output;
843 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900844 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900845}
846
Devin Moore2f2077a2020-08-28 11:27:53 -0700847TEST_F(AidlTest, CppHeaderIncludes) {
848 io_delegate_.SetFileContents("IFoo.aidl",
849 "interface IFoo {\n"
850 " @nullable List<String> foo();\n"
851 "}");
852
853 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
854 Options options = Options::From(args);
855 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
856 std::vector<std::string> empty;
857 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
858 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
859 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
860
861 // Make sure the optional and String16.h includes are added
862 string output;
863 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
864 EXPECT_EQ(kExpectedCppHeaderOutput, output);
865}
866
Devin Moore7b8d5c92020-03-17 14:14:08 -0700867TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700868 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800869 io_delegate_.SetFileContents("p/Outer.aidl",
870 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900871 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700872 CaptureStderr();
873 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
874 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700875 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700876 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800877}
878
Devin Moore7b8d5c92020-03-17 14:14:08 -0700879TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800880 io_delegate_.SetFileContents("preprocessed",
881 "parcelable p.Outer.Inner;");
882 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900883 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700884 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800885 // TODO(wiley): This should actually return nullptr because we require
886 // the outer class name. However, for legacy reasons,
887 // this behavior must be maintained. b/17415692
888 EXPECT_NE(nullptr, parse_result);
889}
890
Christopher Wiley632801d2015-11-05 14:15:49 -0800891TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700892 const string expected_foo_stderr =
893 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
894 "Declared parcelables should be in their own file and/or cannot be used with --structured "
895 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700896 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
897
Christopher Wiley632801d2015-11-05 14:15:49 -0800898 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700899 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700900 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900901 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700902 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900903
Steven Morelande2c64b42018-09-18 15:06:37 -0700904 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900905 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900907 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700908 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700909
Devin Moore097a3ab2020-03-11 16:08:44 -0700910 const string expected_bar_stderr =
911 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
912 "Declared parcelables should be in their own file and/or cannot be used with --structured "
913 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700914 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
915
Jiyong Parkda8c6932019-08-12 19:56:08 +0900916 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700917 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700918 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700920 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700921 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700923 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700924 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800925}
926
Devin Moore7b8d5c92020-03-17 14:14:08 -0700927TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700928 const string expected_stderr =
929 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
930 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700931 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
932 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700933 AidlError error;
934 CaptureStderr();
935 EXPECT_EQ(
936 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700937 Parse("p/IFoo.aidl",
938 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
941 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700942}
943
Devin Moore7b8d5c92020-03-17 14:14:08 -0700944TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700945 AidlError error;
946 const string expected_stderr =
947 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
948 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900949 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
950 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700951 interface IFoo {
952 const String DUPLICATED = "d";
953 const int DUPLICATED = 1;
954 }
955 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700956 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700957 EXPECT_EQ(expected_stderr, GetCapturedStderr());
958 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700959}
960
Devin Moore7b8d5c92020-03-17 14:14:08 -0700961TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700962 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700963 const string expected_stderr =
964 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700965 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700966 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
967 R"(package p;
968 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700969 parcelable IBar {}
970 parcelable StructuredParcelable {}
971 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900972 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700973 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700975 // Parse success is important for clear error handling even if the cases aren't
976 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700977 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700978}
979
Devin Moore7b8d5c92020-03-17 14:14:08 -0700980TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700981 AidlError error;
982 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
983 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700984 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
986 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700987}
988
Steven Morelandf9e922f2020-07-08 21:15:27 +0000989TEST_P(AidlTest, FailOnEmptyListWithComma) {
990 AidlError error;
991 const string expected_stderr =
992 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
993 CaptureStderr();
994 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
995 typenames_, GetLanguage(), &error));
996 EXPECT_EQ(expected_stderr, GetCapturedStderr());
997 EXPECT_EQ(AidlError::PARSE_ERROR, error);
998}
999
Devin Moore7b8d5c92020-03-17 14:14:08 -07001000TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001001 AidlError error;
1002 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001003 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001004 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001005 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1006 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001007 interface IFoo {
1008 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1009 }
1010 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001011 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001012 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1013 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001014}
1015
Jiyong Park18132182020-06-08 20:24:40 +09001016TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1017 AidlError error;
1018 const string expected_stderr =
1019 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1020 "cpp_header (which can also be used as an identifier)\n";
1021 CaptureStderr();
1022 // Notice the trailing dot(.) in the name, which isn't a correct name
1023 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1024 GetLanguage(), &error));
1025 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1026 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1027}
1028
1029TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1030 AidlError error;
1031 const string expected_stderr =
1032 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1033 "cpp_header (which can also be used as an identifier)\n";
1034 CaptureStderr();
1035 // Notice the trailing dot(.) in the package name
1036 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1037 GetLanguage(), &error));
1038 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1039 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1040}
1041
Devin Moore7b8d5c92020-03-17 14:14:08 -07001042TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001043 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001044 auto parse_result = Parse("p/IFoo.aidl",
1045 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001046 interface IFoo {
1047 const int POSITIVE_HEX_VALUE = 0xf5;
1048 }
1049 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001050 typenames_, GetLanguage(), &error);
1051 EXPECT_NE(nullptr, parse_result);
1052 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001053 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001054 const auto& cpp_constants = interface->GetConstantDeclarations();
1055 EXPECT_EQ((size_t)1, cpp_constants.size());
1056 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001057 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001058 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001059}
1060
Devin Moore7b8d5c92020-03-17 14:14:08 -07001061TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001062 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063 auto parse_result = Parse("p/IFoo.aidl",
1064 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001065 interface IFoo {
1066 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1067 }
1068 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001069 typenames_, GetLanguage(), &error);
1070 ASSERT_NE(nullptr, parse_result);
1071 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001072 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001073 const auto& cpp_constants = interface->GetConstantDeclarations();
1074 EXPECT_EQ((size_t)1, cpp_constants.size());
1075 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001076 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001077 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001078}
1079
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001081 io_delegate_.SetFileContents(
1082 "p/Outer.aidl",
1083 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001084 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001085 const string input_path = "p/IFoo.aidl";
1086 const string input = "package p; import p.Outer; interface IFoo"
1087 " { Outer.Inner get(); }";
1088
Devin Moore7b8d5c92020-03-17 14:14:08 -07001089 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1090 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001091
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001092 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001093 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001094 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1095 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001096}
1097
Devin Moore7b8d5c92020-03-17 14:14:08 -07001098TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001099 io_delegate_.SetFileContents(
1100 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001101 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001102 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001103 const string input_path = "p/IFoo.aidl";
1104 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001105 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1106 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001107 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001108 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1109 native_type.Resolve(typenames_);
1110
1111 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1112 // C++ understands C++ specific stuff
1113 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1114 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001115 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001116 EXPECT_EQ(1u, headers.size());
1117 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001118}
1119
Christopher Wileyf8136192016-04-12 14:19:35 -07001120TEST_F(AidlTest, WritesCorrectDependencyFile) {
1121 // While the in tree build system always gives us an output file name,
1122 // other android tools take advantage of our ability to infer the intended
1123 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001124 vector<string> args = {
1125 "aidl",
1126 "-d dep/file/path",
1127 "-o place/for/output",
1128 "p/IFoo.aidl"};
1129 Options options = Options::From(args);
1130 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001131 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001132 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001133 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001134 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1135}
1136
Dan Willemsen93298ee2016-11-10 23:55:55 -08001137TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1138 // While the in tree build system always gives us an output file name,
1139 // other android tools take advantage of our ability to infer the intended
1140 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001141 vector<string> args = {
1142 "aidl",
1143 "-d dep/file/path",
1144 "--ninja",
1145 "-o place/for/output",
1146 "p/IFoo.aidl"};
1147 Options options = Options::From(args);
1148 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001149 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001150 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001151 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001152 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1153}
1154
Jiyong Parkdf202122019-09-30 20:48:35 +09001155TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001156 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1157 // this by calling aidl with every .aidl file it finds, then parsing the
1158 // generated dependency files. Those that reference .java output files are
1159 // for interfaces and those that do not are parcelables. However, for both
1160 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001161 vector<string> args = {
1162 "aidl",
1163 "-o place/for/output",
1164 "-d dep/file/path",
1165 "p/Foo.aidl"};
1166 Options options = Options::From(args);
1167 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001168 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001169 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001170 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001171 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1172}
1173
1174TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1175 vector<string> args = {
1176 "aidl",
1177 "--structured",
1178 "-o place/for/output",
1179 "-d dep/file/path",
1180 "p/Foo.aidl"};
1181 Options options = Options::From(args);
1182 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1183 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1184 string actual_dep_file_contents;
1185 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1186 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001187}
1188
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001189TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1190 vector<string> args = {
1191 "aidl",
1192 "--lang=java",
1193 "-o place/for/output",
1194 "p/Foo.aidl"};
1195 Options options = Options::From(args);
1196 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1197 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1198 string output_file_contents;
1199 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1200}
1201
Jeongik Cha08ca2182019-11-21 14:01:13 +09001202// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001203TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001204 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001205 "package a; interface IFoo {\n"
1206 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001207 string expected_stderr;
1208 switch (GetLanguage()) {
1209 case Options::Language::CPP:
1210 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001211 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001212 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1213 "String and IBinder.\n";
1214 break;
1215 case Options::Language::JAVA:
1216 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001217 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001218 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1219 "String, IBinder, and ParcelFileDescriptor.\n";
1220 break;
1221 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001222 case Options::Language::RUST:
1223 expected_stderr =
1224 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1225 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001226 default:
1227 AIDL_FATAL(AIDL_LOCATION_HERE)
1228 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1229 }
1230 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001231 AidlTypenames tn1;
1232 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234
1235 string primitive_parcelable =
1236 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001237 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001238 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001239 AidlTypenames tn2;
1240 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001241 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001242}
1243
Devin Moore21b26772020-08-26 16:37:56 -07001244TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001245 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001246 const string list_array_parcelable =
1247 "package a; parcelable Foo {\n"
1248 " List[] lists; }";
1249 CaptureStderr();
1250 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1252}
1253
Jiyong Parkf8d53612020-05-04 14:06:13 +09001254TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1255 AidlError error;
1256 string expected_stderr =
1257 "ERROR: a/IFoo.aidl:2.7-11: "
1258 "Encountered an untyped List or Map. The use of untyped List/Map is "
1259 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1260 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1261 if (GetLanguage() != Options::Language::JAVA) {
1262 expected_stderr =
1263 "ERROR: a/IFoo.aidl:2.1-7: "
1264 "Currently, only the Java backend supports non-generic List.\n";
1265 }
1266
1267 const string primitive_interface =
1268 "package a; interface IFoo {\n"
1269 " List foo(); }";
1270 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001271 AidlTypenames tn1;
1272 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001273 {"--structured"}));
1274 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001275
1276 string primitive_parcelable =
1277 "package a; parcelable IFoo {\n"
1278 " List foo;}";
1279 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001280 AidlTypenames tn2;
1281 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001282 {"--structured"}));
1283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1284}
1285
Jeongik Cha225519b2020-08-29 01:55:32 +09001286TEST_P(AidlTest, ExtensionTest) {
1287 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001288 string extendable_parcelable =
1289 "package a; parcelable Data {\n"
1290 " ParcelableHolder extension;\n"
1291 " ParcelableHolder extension2;\n"
1292 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001293 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001294 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1295 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001296 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001297 "yet.\n",
1298 GetCapturedStderr());
1299 } else {
1300 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1301 EXPECT_EQ("", GetCapturedStderr());
1302 }
1303}
1304TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1305 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001306 string parcelableholder_return_interface =
1307 "package a; interface IFoo {\n"
1308 " ParcelableHolder foo();\n"
1309 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001310 EXPECT_EQ(nullptr,
1311 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001312
Jeongik Cha8f02a532020-10-14 00:16:28 +09001313 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001314 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001315 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001316 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001317 "yet.\n",
1318 GetCapturedStderr());
1319 return;
1320 }
1321 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1322 GetCapturedStderr());
1323}
1324
1325TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1326 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001327 string extendable_parcelable_arg_interface =
1328 "package a; interface IFoo {\n"
1329 " void foo(in ParcelableHolder ph);\n"
1330 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(nullptr,
1332 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1333
Jeongik Cha8f02a532020-10-14 00:16:28 +09001334 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001335 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001336 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001337 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001338 "yet.\n",
1339 GetCapturedStderr());
1340 return;
1341 }
1342 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1343 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001344}
1345
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001346TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1347 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1348 Options options =
1349 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1350 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1351 CaptureStderr();
1352 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1353 if (GetLanguage() == Options::Language::RUST) {
1354 EXPECT_EQ(
1355 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1356 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1357 "yet.\n",
1358 GetCapturedStderr());
1359 return;
1360 }
1361 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1362}
1363
Jiyong Park02da7422018-07-16 16:00:26 +09001364TEST_F(AidlTest, ApiDump) {
1365 io_delegate_.SetFileContents(
1366 "foo/bar/IFoo.aidl",
1367 "package foo.bar;\n"
1368 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001369 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001370 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001371 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001372 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1373 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1374 " IFoo foo3(IFoo foo);\n"
1375 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001376 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001377 " const int A = 1;\n"
1378 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001379 "}\n");
1380 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1381 "package foo.bar;\n"
1382 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001383 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001384 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001385 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001386 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001387 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001388 " int y;\n"
1389 " IFoo foo;\n"
1390 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001391 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001392 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001393 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001394 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001395 "}\n");
1396 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001397 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1398 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001399 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001400 bool result = dump_api(options, io_delegate_);
1401 ASSERT_TRUE(result);
1402 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001403 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001404 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001405/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001406interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001407 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001408 int foo(out int[] a, String b, boolean c, inout List<String> d);
1409 int foo2(@utf8InCpp String x, inout List<String> y);
1410 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1411 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001412 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001413 const int A = 1;
1414 const String STR = "Hello";
1415}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001416)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001417
Jiyong Parke59c3682018-09-11 23:10:25 +09001418 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001419 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001420/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001421parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001422 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001423 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001424 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001425 int y;
1426 foo.bar.IFoo foo;
1427 List<foo.bar.IFoo> a;
1428 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001429 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001430 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001431}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001432)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001433}
1434
Jiyong Parked65bf42018-08-28 15:43:27 +09001435TEST_F(AidlTest, ApiDumpWithManualIds) {
1436 io_delegate_.SetFileContents(
1437 "foo/bar/IFoo.aidl",
1438 "package foo.bar;\n"
1439 "interface IFoo {\n"
1440 " int foo() = 1;\n"
1441 " int bar() = 2;\n"
1442 " int baz() = 10;\n"
1443 "}\n");
1444
Jiyong Parke59c3682018-09-11 23:10:25 +09001445 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001446 Options options = Options::From(args);
1447 bool result = dump_api(options, io_delegate_);
1448 ASSERT_TRUE(result);
1449 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001450 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001451 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001452interface IFoo {
1453 int foo() = 1;
1454 int bar() = 2;
1455 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001456}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001457)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001458}
1459
1460TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001461 const string expected_stderr =
1462 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1463 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001464 io_delegate_.SetFileContents(
1465 "foo/bar/IFoo.aidl",
1466 "package foo.bar;\n"
1467 "interface IFoo {\n"
1468 " int foo() = 1;\n"
1469 " int bar();\n"
1470 " int baz() = 10;\n"
1471 "}\n");
1472
Jiyong Parke59c3682018-09-11 23:10:25 +09001473 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001474 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001475 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001476 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001477 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001478}
1479
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001480TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001481 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001482 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1483 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001484 const string expected_map_stderr =
1485 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001486 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1487 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001488 "package p; interface IFoo {"
1489 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001490 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001491 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001492 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001493
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001494 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001495 "package p; interface IFoo {"
1496 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001497 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001498 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001499 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001500}
1501
Jeongik Chae48d9942020-01-02 17:39:00 +09001502TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001503 const string expected_stderr =
1504 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001505 Options options = Options::From("aidl -I p p/IFoo.aidl");
1506 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1507
1508 io_delegate_.SetFileContents("p/IFoo.aidl",
1509 "package p; interface IFoo {"
1510 "Map<String, Bar> foo();}");
1511 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1512
1513 io_delegate_.SetFileContents("p/IFoo.aidl",
1514 "package p; interface IFoo {"
1515 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001516 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001517 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001518 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001519
1520 io_delegate_.SetFileContents("p/IFoo.aidl",
1521 "package p; interface IFoo {"
1522 "Map<String, String> foo();}");
1523 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1524
1525 io_delegate_.SetFileContents("p/IFoo.aidl",
1526 "package p; interface IFoo {"
1527 "Map<String, ParcelFileDescriptor> foo();}");
1528 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1529}
1530
Jeongik Chadf76dc72019-11-28 00:08:47 +09001531TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001532 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001533 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1534 io_delegate_.SetFileContents(options.InputFiles().front(),
1535 "package p; interface IFoo {"
1536 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001537 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001538 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001540}
1541
1542TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1543 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1544 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001545 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001546 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001547 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1548 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001549
1550 Options options = Options::From("aidl -I p p/IFoo.aidl");
1551 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1552 io_delegate_.SetFileContents("p/IFoo.aidl",
1553 "package p; interface IFoo {"
1554 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001555 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001556 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001557 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001558 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001559 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001560 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001561 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1562 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001563 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1564 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1565 io_delegate_.SetFileContents("p/IFoo.aidl",
1566 "package p; interface IFoo {"
1567 "Bar<String, ParcelFileDescriptor> foo();}");
1568 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001569
1570 io_delegate_.SetFileContents("p/IFoo.aidl",
1571 "package p; interface IFoo {"
1572 "Bar<int, long> foo();}");
1573
1574 io_delegate_.SetFileContents("p/IFoo.aidl",
1575 "package p; interface IFoo {"
1576 "Bar<int[], long[]> foo();}");
1577
1578 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001579}
1580
Jeongik Cha0e426012019-07-29 15:57:02 +09001581TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1582 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001583 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1584 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001585 for (const auto& rawOption : rawOptions) {
1586 string expected_stderr =
1587 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001588 Options options = Options::From(rawOption);
1589 io_delegate_.SetFileContents(options.InputFiles().front(),
1590 "package foo.bar;\n"
1591 "interface IFoo1 { int foo(); }\n"
1592 "interface IFoo2 { int foo(); }\n"
1593 "parcelable Data1 { int a; int b;}\n"
1594 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001595 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001596 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001597 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001598
Jeongik Cha0e426012019-07-29 15:57:02 +09001599 io_delegate_.SetFileContents(options.InputFiles().front(),
1600 "package foo.bar;\n"
1601 "interface IFoo1 { int foo(); }\n"
1602 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001603 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001604 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001605 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001606
Devin Moore5de18ed2020-04-02 13:52:29 -07001607 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001608 io_delegate_.SetFileContents(options.InputFiles().front(),
1609 "package foo.bar;\n"
1610 "parcelable Data1 { int a; int b;}\n"
1611 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001612 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001613 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001614 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001615 }
1616}
1617
Devin Moorebdba2a82020-03-31 15:19:02 -07001618TEST_P(AidlTest, FailParseOnEmptyFile) {
1619 const string contents = "";
1620 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1621 CaptureStderr();
1622 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1623 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1624}
1625
Jiyong Parkb034bf02018-07-30 17:44:33 +09001626TEST_F(AidlTest, MultipleInputFiles) {
1627 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001628 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001629
1630 io_delegate_.SetFileContents(options.InputFiles().at(0),
1631 "package foo.bar;\n"
1632 "import foo.bar.Data;\n"
1633 "interface IFoo { Data getData(); }\n");
1634
1635 io_delegate_.SetFileContents(options.InputFiles().at(1),
1636 "package foo.bar;\n"
1637 "import foo.bar.IFoo;\n"
1638 "parcelable Data { IFoo foo; }\n");
1639
1640 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1641
1642 string content;
1643 for (const auto file : {
1644 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1645 content.clear();
1646 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1647 EXPECT_FALSE(content.empty());
1648 }
1649}
1650
1651TEST_F(AidlTest, MultipleInputFilesCpp) {
1652 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001653 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001654
1655 io_delegate_.SetFileContents(options.InputFiles().at(0),
1656 "package foo.bar;\n"
1657 "import foo.bar.Data;\n"
1658 "interface IFoo { Data getData(); }\n");
1659
1660 io_delegate_.SetFileContents(options.InputFiles().at(1),
1661 "package foo.bar;\n"
1662 "import foo.bar.IFoo;\n"
1663 "parcelable Data { IFoo foo; }\n");
1664
1665 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1666
1667 string content;
1668 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001669 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001670 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1671 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1672 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1673 content.clear();
1674 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1675 EXPECT_FALSE(content.empty());
1676 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001677}
1678
Andrei Homescub62afd92020-05-11 19:24:59 -07001679TEST_F(AidlTest, MultipleInputFilesRust) {
1680 Options options =
1681 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1682
1683 io_delegate_.SetFileContents(options.InputFiles().at(0),
1684 "package foo.bar;\n"
1685 "import foo.bar.Data;\n"
1686 "interface IFoo { Data getData(); }\n");
1687
1688 io_delegate_.SetFileContents(options.InputFiles().at(1),
1689 "package foo.bar;\n"
1690 "import foo.bar.IFoo;\n"
1691 "parcelable Data { IFoo foo; }\n");
1692
1693 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1694
1695 string content;
1696 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1697 content.clear();
1698 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1699 EXPECT_FALSE(content.empty());
1700 }
1701}
1702
Devin Moore097a3ab2020-03-11 16:08:44 -07001703TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1704 const string expected_stderr =
1705 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001706 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1707 // int getInterfaceVersion() is one of the meta transactions
1708 io_delegate_.SetFileContents(options.InputFiles().front(),
1709 "package p; interface IFoo {"
1710 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001711 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001712 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001713 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1714}
Jiyong Park309668e2018-07-28 16:55:44 +09001715
Devin Moore097a3ab2020-03-11 16:08:44 -07001716TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1717 // boolean getInterfaceVersion() is not a meta transaction, but should be
1718 // prevented because return type is not part of a method signature
1719 const string expected_stderr =
1720 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1721 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001722 io_delegate_.SetFileContents(options.InputFiles().front(),
1723 "package p; interface IFoo {"
1724 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001725 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001726 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001727 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1728}
Jiyong Park309668e2018-07-28 16:55:44 +09001729
Devin Moore097a3ab2020-03-11 16:08:44 -07001730TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001731 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001732 const string expected_stderr =
1733 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1734 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001735 io_delegate_.SetFileContents(options.InputFiles().front(),
1736 "package p; interface IFoo {"
1737 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001738 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001739 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001740 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001741
1742 // this is not a meta interface method as it differs type arguments
1743 io_delegate_.SetFileContents(options.InputFiles().front(),
1744 "package p; interface IFoo {"
1745 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001746 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001747}
1748
Daniel Norman85aed542019-08-21 12:01:14 -07001749TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001750 Options options = Options::From("aidl --checkapi old new");
1751 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1752 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1753 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1754 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1755
1756 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1757}
1758
Jiyong Park3656c3c2018-08-01 20:02:01 +09001759TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001760 Options options = Options::From("aidl --checkapi old new");
1761 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1762 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001763
1764 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1765}
1766
Daniel Norman85aed542019-08-21 12:01:14 -07001767class AidlTestCompatibleChanges : public AidlTest {
1768 protected:
1769 Options options_ = Options::From("aidl --checkapi old new");
1770};
1771
1772TEST_F(AidlTestCompatibleChanges, NewType) {
1773 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1774 "package p;"
1775 "interface IFoo {"
1776 " void foo(int a);"
1777 "}");
1778 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1779 "package p;"
1780 "interface IFoo {"
1781 " void foo(int a);"
1782 "}");
1783 io_delegate_.SetFileContents("new/p/IBar.aidl",
1784 "package p;"
1785 "interface IBar {"
1786 " void bar();"
1787 "}");
1788 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1789}
1790
1791TEST_F(AidlTestCompatibleChanges, NewMethod) {
1792 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1793 "package p;"
1794 "interface IFoo {"
1795 " void foo(int a);"
1796 "}");
1797 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1798 "package p;"
1799 "interface IFoo {"
1800 " void foo(int a);"
1801 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001802 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001803 "}");
1804 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1805}
1806
1807TEST_F(AidlTestCompatibleChanges, NewField) {
1808 io_delegate_.SetFileContents("old/p/Data.aidl",
1809 "package p;"
1810 "parcelable Data {"
1811 " int foo;"
1812 "}");
1813 io_delegate_.SetFileContents("new/p/Data.aidl",
1814 "package p;"
1815 "parcelable Data {"
1816 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001817 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001818 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001819 "}");
1820 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1821}
1822
1823TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1824 io_delegate_.SetFileContents("old/p/Enum.aidl",
1825 "package p;"
1826 "enum Enum {"
1827 " FOO = 1,"
1828 "}");
1829 io_delegate_.SetFileContents("new/p/Enum.aidl",
1830 "package p;"
1831 "enum Enum {"
1832 " FOO = 1,"
1833 " BAR = 2,"
1834 "}");
1835 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1836}
1837
1838TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1839 io_delegate_.SetFileContents("old/p/Enum.aidl",
1840 "package p;"
1841 "enum Enum {"
1842 " FOO = 1,"
1843 " BAR = 2,"
1844 "}");
1845 io_delegate_.SetFileContents("new/p/Enum.aidl",
1846 "package p;"
1847 "enum Enum {"
1848 " BAR = 2,"
1849 " FOO = 1,"
1850 "}");
1851 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1852}
1853
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001854TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1855 io_delegate_.SetFileContents("old/p/Union.aidl",
1856 "package p;"
1857 "union Union {"
1858 " String foo;"
1859 "}");
1860 io_delegate_.SetFileContents("new/p/Union.aidl",
1861 "package p;"
1862 "union Union {"
1863 " String foo;"
1864 " int num;"
1865 "}");
1866 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1867}
1868
Daniel Norman85aed542019-08-21 12:01:14 -07001869TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001870 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1871 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001872 "interface IFoo {"
1873 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001874 "}");
1875 io_delegate_.SetFileContents("old/p/Data.aidl",
1876 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001877 "parcelable Data {"
1878 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001879 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001880 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1881 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001882 "interface IFoo {"
1883 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001884 "}");
1885 io_delegate_.SetFileContents("new/p/Data.aidl",
1886 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001887 "parcelable Data {"
1888 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001889 "}");
1890 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1891 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001892 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001893 " void foo(int a);"
1894 "}");
1895 io_delegate_.SetFileContents("new/q/Data.aidl",
1896 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001897 "parcelable Data {"
1898 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001899 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001900 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1901}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001902
Daniel Norman85aed542019-08-21 12:01:14 -07001903TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1904 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1905 "package p;"
1906 "interface IFoo {"
1907 " void foo(int a);"
1908 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001909 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1910 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001911 "interface IFoo {"
1912 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001913 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001914 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1915}
Jiyong Parke59c3682018-09-11 23:10:25 +09001916
Daniel Norman85aed542019-08-21 12:01:14 -07001917TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001918 io_delegate_.SetFileContents("old/p/I.aidl",
1919 "package p; interface I {"
1920 "const int A = 1; }");
1921 io_delegate_.SetFileContents("new/p/I.aidl",
1922 "package p ; interface I {"
1923 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001924 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1925}
Jiyong Parka428d212018-08-29 22:26:30 +09001926
Daniel Norman85aed542019-08-21 12:01:14 -07001927TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001928 io_delegate_.SetFileContents("old/p/I.aidl",
1929 "package p; interface I {"
1930 "const int A = 1; const int B = 2;}");
1931 io_delegate_.SetFileContents("new/p/I.aidl",
1932 "package p ; interface I {"
1933 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001934 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001935}
1936
Jooyung Han636fd2f2020-10-22 11:33:45 +09001937TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1938 io_delegate_.SetFileContents("old/p/Data.aidl",
1939 "package p;"
1940 "parcelable Data {"
1941 " int num;"
1942 "}");
1943 io_delegate_.SetFileContents(
1944 "new/p/Data.aidl",
1945 "package p;"
1946 "parcelable Data {"
1947 " int num;"
1948 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1949 "}");
1950 io_delegate_.SetFileContents("new/p/Enum.aidl",
1951 "package p;"
1952 "enum Enum {"
1953 " FOO = 0,"
1954 " BAR = 1,"
1955 "}");
1956 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1957}
1958
Daniel Norman85aed542019-08-21 12:01:14 -07001959class AidlTestIncompatibleChanges : public AidlTest {
1960 protected:
1961 Options options_ = Options::From("aidl --checkapi old new");
1962};
1963
1964TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001965 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001966 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1967 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001968 "interface IFoo {"
1969 " void foo(in String[] str);"
1970 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001971 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001972 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001973 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001975}
1976
1977TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001978 const string expected_stderr =
1979 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001980 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1981 "package p;"
1982 "interface IFoo {"
1983 " void foo(in String[] str);"
1984 " void bar(@utf8InCpp String str);"
1985 "}");
1986 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1987 "package p;"
1988 "interface IFoo {"
1989 " void foo(in String[] str);"
1990 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001991 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001992 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001994}
1995
Jiyong Parkf8d53612020-05-04 14:06:13 +09001996TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1997 const string expected_stderr =
1998 "ERROR: new/p/IFoo.aidl:1.61-65: "
1999 "Encountered an untyped List or Map. The use of untyped List/Map is "
2000 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2001 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2002 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2003 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2004 "package p;"
2005 "interface IFoo {"
2006 " void foo(in String[] str);"
2007 "}");
2008 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2009 "package p;"
2010 "interface IFoo {"
2011 " void foo(in String[] str);"
2012 " void bar(in List arg);"
2013 "}");
2014 CaptureStderr();
2015 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2017}
2018
2019TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2020 const string expected_stderr =
2021 "ERROR: new/p/Data.aidl:1.54-59: "
2022 "Encountered an untyped List or Map. The use of untyped List/Map is "
2023 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2024 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2025 "ERROR: new/p/Data.aidl: Failed to read.\n";
2026 io_delegate_.SetFileContents("old/p/Data.aidl",
2027 "package p;"
2028 "parcelable Data {"
2029 " int foo;"
2030 "}");
2031 io_delegate_.SetFileContents("new/p/Data.aidl",
2032 "package p;"
2033 "parcelable Data {"
2034 " int foo;"
2035 " @nullable List list;"
2036 "}");
2037 CaptureStderr();
2038 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2039 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2040}
2041
Daniel Norman85aed542019-08-21 12:01:14 -07002042TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002043 const string expected_stderr =
2044 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002045 io_delegate_.SetFileContents("old/p/Data.aidl",
2046 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002047 "parcelable Data {"
2048 " int foo;"
2049 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002050 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002051 io_delegate_.SetFileContents("new/p/Data.aidl",
2052 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002053 "parcelable Data {"
2054 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002055 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002056 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002057 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002058 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002059}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002060
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002061TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2062 const string expected_stderr =
2063 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2064 "backends. Please either provide a default value for this field or mark the field as "
2065 "@nullable. This value or a null value will be used automatically when an old version of "
2066 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2067 "order to make sure your code continues to be backwards compatible, make sure the default or "
2068 "null value does not cause a semantic change to this parcelable.\n";
2069 io_delegate_.SetFileContents("old/p/Data.aidl",
2070 "package p;"
2071 "parcelable Data {"
2072 " int num;"
2073 "}");
2074 io_delegate_.SetFileContents("new/p/Data.aidl",
2075 "package p;"
2076 "parcelable Data {"
2077 " int num;"
2078 " String str;"
2079 "}");
2080 CaptureStderr();
2081 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2082 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2083}
2084
Jooyung Han636fd2f2020-10-22 11:33:45 +09002085TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2086 const string expected_stderr =
2087 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2088 "Please make sure 'Enum' has '0' as a valid value.\n";
2089 io_delegate_.SetFileContents("old/p/Data.aidl",
2090 "package p;"
2091 "parcelable Data {"
2092 " int num;"
2093 "}");
2094 io_delegate_.SetFileContents("new/p/Data.aidl",
2095 "package p;"
2096 "parcelable Data {"
2097 " int num;"
2098 " p.Enum e;"
2099 "}");
2100 io_delegate_.SetFileContents("new/p/Enum.aidl",
2101 "package p;"
2102 "enum Enum {"
2103 " FOO = 1,"
2104 " BAR = 2,"
2105 "}");
2106 CaptureStderr();
2107 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2108 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2109}
2110
Daniel Norman85aed542019-08-21 12:01:14 -07002111TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002112 const string expected_stderr =
2113 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002114 io_delegate_.SetFileContents("old/p/Enum.aidl",
2115 "package p;"
2116 "enum Enum {"
2117 " FOO = 1,"
2118 " BAR = 2,"
2119 "}");
2120 io_delegate_.SetFileContents("new/p/Enum.aidl",
2121 "package p;"
2122 "enum Enum {"
2123 " BAR = 2,"
2124 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002125 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002126 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002127 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002128}
2129
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002130TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2131 const string expected_stderr =
2132 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2133 io_delegate_.SetFileContents("old/p/Union.aidl",
2134 "package p;"
2135 "union Union {"
2136 " String str;"
2137 " int num;"
2138 "}");
2139 io_delegate_.SetFileContents("new/p/Union.aidl",
2140 "package p;"
2141 "union Union {"
2142 " String str;"
2143 "}");
2144 CaptureStderr();
2145 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2147}
2148
Daniel Norman85aed542019-08-21 12:01:14 -07002149TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002150 const string expected_stderr =
2151 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002152 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2153 "package p;"
2154 "interface IFoo {"
2155 " void foo(in String[] str);"
2156 " void bar(@utf8InCpp String str);"
2157 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002158 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2159 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002160 "interface IFoo {"
2161 " void foo(in String[] str);"
2162 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002163 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002164 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002165 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002166 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002167}
2168
Daniel Norman85aed542019-08-21 12:01:14 -07002169TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002170 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002171 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2172 "package p;"
2173 "interface IFoo {"
2174 " void foo(in String[] str);"
2175 " void bar(@utf8InCpp String str);"
2176 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002177 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2178 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002179 "interface IFoo2 {"
2180 " void foo(in String[] str);"
2181 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002182 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002183 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002184 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002185 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002186}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002187
Daniel Norman85aed542019-08-21 12:01:14 -07002188TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002189 const string expected_stderr =
2190 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002191 io_delegate_.SetFileContents("old/p/Enum.aidl",
2192 "package p;"
2193 "enum Enum {"
2194 " FOO = 1,"
2195 " BAR = 2,"
2196 "}");
2197 io_delegate_.SetFileContents("new/p/Enum.aidl",
2198 "package p;"
2199 "enum Enum {"
2200 " FOO = 3,"
2201 " BAR = 2,"
2202 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002203 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002204 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002205 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002206}
2207
2208TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002209 const string expected_stderr =
2210 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2211 "from 0 to 1.\n"
2212 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2213 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002214 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2215 "package p;"
2216 "interface IFoo {"
2217 " void foo(in String[] str);"
2218 " void bar(@utf8InCpp String str);"
2219 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002220 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2221 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002222 "interface IFoo {"
2223 " void bar(@utf8InCpp String str);"
2224 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002225 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002226 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002227 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002229}
2230
2231TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002233 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2234 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002235 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002236 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002237 "parcelable Data {"
2238 " int foo;"
2239 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002240 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002241 io_delegate_.SetFileContents("new/p/Data.aidl",
2242 "package p;"
2243 "parcelable Data {"
2244 " int bar;"
2245 " int foo;"
2246 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002247 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002248 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002250}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002251
Daniel Norman85aed542019-08-21 12:01:14 -07002252TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002253 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002254 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002255 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002256 "interface IFoo {"
2257 " void foo(in String[] str);"
2258 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002259 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002260 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2261 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002262 "interface IFoo {"
2263 " void foo(out String[] str);"
2264 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002265 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002266 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002267 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002268 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002269}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002270
Daniel Norman85aed542019-08-21 12:01:14 -07002271TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002272 const string expected_stderr =
2273 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002274 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2275 "package p;"
2276 "interface IFoo {"
2277 " void foo(in String[] str);"
2278 " void bar(@utf8InCpp String str);"
2279 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002280 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2281 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002282 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002283 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002284 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002285 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002286 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002287 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002288 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002289}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002290
Daniel Norman85aed542019-08-21 12:01:14 -07002291TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002292 const string expected_stderr =
2293 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002294 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2295 "package p;"
2296 "interface IFoo {"
2297 " void foo(in String[] str);"
2298 " void bar(@utf8InCpp String str);"
2299 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002300 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2301 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002302 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002303 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002304 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002305 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002306 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002307 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002308 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002309}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002310
Jooyung Han60b2fde2020-10-29 15:12:40 +09002311TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2312 const string expected_stderr =
2313 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2314 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2315 io_delegate_.SetFileContents("old/p/Foo.aidl",
2316 "package p;"
2317 "@Backing(type=\"byte\")"
2318 "enum Foo {"
2319 " FOO, BAR,"
2320 "}");
2321 io_delegate_.SetFileContents("new/p/Foo.aidl",
2322 "package p;"
2323 "@Backing(type=\"long\")"
2324 "enum Foo {"
2325 " FOO, BAR,"
2326 "}");
2327 CaptureStderr();
2328 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2330}
2331
Devin Mooredb7ac512020-08-07 11:17:36 -07002332TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2333 const string expected_stderr =
2334 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2335 io_delegate_.SetFileContents("old/p/Foo.aidl",
2336 "package p;"
2337 "parcelable Foo {"
2338 " int A;"
2339 "}");
2340 io_delegate_.SetFileContents("new/p/Foo.aidl",
2341 "package p;"
2342 "@JavaOnlyStableParcelable parcelable Foo {"
2343 " int A;"
2344 "}");
2345 CaptureStderr();
2346 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2348}
2349
2350TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2351 const string expected_stderr =
2352 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2353 io_delegate_.SetFileContents("old/p/Foo.aidl",
2354 "package p;"
2355 "@JavaOnlyStableParcelable parcelable Foo {"
2356 " int A;"
2357 "}");
2358 io_delegate_.SetFileContents("new/p/Foo.aidl",
2359 "package p;"
2360 "parcelable Foo {"
2361 " int A;"
2362 "}");
2363 CaptureStderr();
2364 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2366}
2367
Daniel Norman85aed542019-08-21 12:01:14 -07002368TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002370 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2371 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002372 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002373 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002374 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002376}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002377
Daniel Norman85aed542019-08-21 12:01:14 -07002378TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002379 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002380 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2381 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002382 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002383 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002384 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002385}
Jiyong Parka428d212018-08-29 22:26:30 +09002386
Daniel Norman85aed542019-08-21 12:01:14 -07002387TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002388 const string expected_stderr =
2389 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002390 io_delegate_.SetFileContents("old/p/I.aidl",
2391 "package p; interface I {"
2392 "const int A = 1; const int B = 2;}");
2393 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002394 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002395 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002396 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002397}
Jiyong Parka428d212018-08-29 22:26:30 +09002398
Daniel Norman85aed542019-08-21 12:01:14 -07002399TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 const string expected_stderr =
2401 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002402 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2403 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002404 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002405 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002407}
2408
Devin Moorec7e47a32020-08-07 10:55:25 -07002409TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2410 const string expected_stderr =
2411 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2412 "This is an incompatible change for FixedSize types.\n";
2413 io_delegate_.SetFileContents("old/p/Foo.aidl",
2414 "package p; @FixedSize parcelable Foo { int A = 1; }");
2415 io_delegate_.SetFileContents("new/p/Foo.aidl",
2416 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2417 CaptureStderr();
2418 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2419 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2420}
2421
2422TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2423 const string expected_stderr =
2424 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2425 io_delegate_.SetFileContents("old/p/Foo.aidl",
2426 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2427 io_delegate_.SetFileContents("new/p/Foo.aidl",
2428 "package p; @FixedSize parcelable Foo { int A = 1; }");
2429 CaptureStderr();
2430 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2431 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2432}
2433
2434TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2435 const string expected_stderr =
2436 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2437 "a.\n"
2438 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2439 "b.\n"
2440 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2441 "c.\n"
2442 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2443 "d.\n"
2444 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2445 "e.\n"
2446 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2447 "f.\n";
2448
2449 io_delegate_.SetFileContents("Foo.aidl",
2450 "@FixedSize parcelable Foo { "
2451 " int[] a;"
2452 " Bar b;"
2453 " String c;"
2454 " ParcelFileDescriptor d;"
2455 " IBinder e;"
2456 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002457 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002458 "}");
2459 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2460 Options options =
2461 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2462
2463 CaptureStderr();
2464 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2466}
2467
2468TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2469 const string expected_stderr = "";
2470
2471 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2472 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2473 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2474 Options options =
2475 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2476
2477 CaptureStderr();
2478 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2479 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2480}
2481
Jiyong Park8c380532018-08-30 14:55:26 +09002482TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002483 const string expected_stderr =
2484 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2485 "dir1/q/IBar.aidl\n"
2486 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002487 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002488 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2489 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2490 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2491 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2492
Devin Moore097a3ab2020-03-11 16:08:44 -07002493 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002494 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002495 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002496}
2497
Jiyong Parked65bf42018-08-28 15:43:27 +09002498TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002499 const string expected_stderr =
2500 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2501 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002502 Options options = Options::From("aidl --checkapi old new");
2503 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2504 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002505
2506 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2507
Jiyong Parke59c3682018-09-11 23:10:25 +09002508 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002509 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002510 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002512}
2513
Jiyong Parke05195e2018-10-08 18:24:23 +09002514TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2515 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2516 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002517 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002518
2519 // use without import
2520 io_delegate_.SetFileContents("p/IFoo.aidl",
2521 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2522 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2523 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002524 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002525
Devin Moore7b8d5c92020-03-17 14:14:08 -07002526 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002527 io_delegate_.SetFileContents(
2528 "p/IFoo.aidl",
2529 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2530 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2531 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002532 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002533
2534 // use with import (as before)
2535 io_delegate_.SetFileContents("p/IFoo.aidl",
2536 "package p;"
2537 "import android.os.ParcelFileDescriptor;"
2538 "interface IFoo{"
2539 " void foo(in ParcelFileDescriptor fd);"
2540 "}");
2541 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2542 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002543 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002544}
Jiyong Parked65bf42018-08-28 15:43:27 +09002545
Jiyong Park3633b722019-04-11 15:38:26 +09002546TEST_F(AidlTest, ManualIds) {
2547 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2548 io_delegate_.SetFileContents("IFoo.aidl",
2549 "interface IFoo {\n"
2550 " void foo() = 0;\n"
2551 " void bar() = 1;\n"
2552 "}");
2553 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2554}
2555
2556TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2557 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2558 io_delegate_.SetFileContents("IFoo.aidl",
2559 "interface IFoo {\n"
2560 " void foo() = 0;\n"
2561 " void bar() = 1;\n"
2562 "}");
2563 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2564}
2565
2566TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 const string expected_stderr =
2568 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002569 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2570 io_delegate_.SetFileContents("IFoo.aidl",
2571 "interface IFoo {\n"
2572 " void foo() = 3;\n"
2573 " void bar() = 3;\n"
2574 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002575 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002576 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002578}
2579
2580TEST_F(AidlTest, FailOnOutOfRangeIds) {
2581 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002582 const string expected_stderr =
2583 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2584 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002585 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2586 io_delegate_.SetFileContents("IFoo.aidl",
2587 "interface IFoo {\n"
2588 " void foo() = 3;\n"
2589 " void bar() = 16777115;\n"
2590 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002591 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002592 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002593 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002594}
2595
2596TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002597 const string expected_stderr =
2598 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002599 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2600 io_delegate_.SetFileContents("IFoo.aidl",
2601 "interface IFoo {\n"
2602 " void foo() = 3;\n"
2603 " void bar();\n"
2604 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002605 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002606 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002607 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002608}
2609
Jiyong Parkc6816252019-07-08 08:12:28 +09002610TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2611 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2612 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2613 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2614 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2615}
2616
2617TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002618 const string expected_stderr =
2619 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2620 "dir/IBar.aidl\n"
2621 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002622 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002623
Jiyong Parkc6816252019-07-08 08:12:28 +09002624 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2625 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2626 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2627 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002628 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002629 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002630 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002631}
2632
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002633TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2634 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2635 "package a.b;\n"
2636 "import a.b.IBar;\n"
2637 "import a.b.IQux;\n"
2638 "interface IFoo { IQux foo(); }\n");
2639 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2640 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2641
2642 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2643 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2644
2645 string output;
2646 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2647 // IBar was imported but wasn't used. include is not expected.
2648 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2649 // IBar was imported and used. include is expected.
2650 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2651}
2652
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002653TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002654 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002655 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002656 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2657 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002658 interface IFoo {
2659 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002660 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002661 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002662 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002663 // JavaPassthrough should work with other types as well (e.g. enum)
2664 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2665 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2666 @JavaPassthrough(annotation="@com.android.AliceTwo")
2667 @Backing(type="byte")
2668 enum MyEnum {
2669 a, b, c
2670 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002671
Jooyung Han4cde01d2020-10-13 11:10:47 +09002672 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002673 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2674
2675 string java_out;
2676 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002677 // type-decl-level annotations with newline at the end
2678 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2679 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2680 // member-decl-level annotations with newline at the end
2681 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2682 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2683 // inline annotations with space at the end
2684 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002685
Jooyung Han4cde01d2020-10-13 11:10:47 +09002686 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2687 // type-decl-level annotations with newline at the end
2688 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2689 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2690
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002691 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002692 Options cpp_options =
2693 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002694 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2695
Jooyung Han4cde01d2020-10-13 11:10:47 +09002696 Options ndk_options =
2697 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002698 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002699
Jooyung Han4cde01d2020-10-13 11:10:47 +09002700 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002701 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002702}
2703
Andrei Homescue61feb52020-08-18 15:44:24 -07002704TEST_F(AidlTest, ParseRustDerive) {
2705 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2706 @RustDerive(Clone=true, Copy=false)
2707 parcelable Foo {
2708 int a;
2709 })");
2710
2711 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2712 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2713
2714 string rust_out;
2715 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2716 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2717
2718 // Other backends shouldn't be bothered
2719 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2720 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2721
2722 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2723 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2724
2725 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2726 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2727}
2728
Jiyong Park56f73d72019-06-11 12:20:28 +09002729class AidlOutputPathTest : public AidlTest {
2730 protected:
2731 void SetUp() override {
2732 AidlTest::SetUp();
2733 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2734 }
2735
2736 void Test(const Options& options, const std::string expected_output_path) {
2737 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2738 // check the existence
2739 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2740 }
2741};
2742
2743TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2744 // <out_dir> / <package_name> / <type_name>.java
2745 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2746}
2747
2748TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2749 // when output file is explicitly set, it is always respected. -o option is
2750 // ignored.
2751 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2752}
2753
2754TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2755 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2756}
2757
2758TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2759 // output is the same as the input file except for the suffix
2760 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2761}
2762
Devin Moore7b8d5c92020-03-17 14:14:08 -07002763TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002764 AidlError error;
2765 const string expected_stderr =
2766 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2767 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002768 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2769 R"(package p;
2770 interface IFoo {
2771 const int int32_max_oob = 2147483650;
2772 }
2773 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002774 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002775 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2776 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002777}
2778
Devin Moore7b8d5c92020-03-17 14:14:08 -07002779TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002780 AidlError error;
2781 const string expected_stderr =
2782 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2783 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002784 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2785 R"(package p;
2786 interface IFoo {
2787 const int int32_min_oob = -2147483650;
2788 }
2789 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002790 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002791 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2792 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002793}
2794
Devin Moore7b8d5c92020-03-17 14:14:08 -07002795TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002796 AidlError error;
2797 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002798 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002799 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002800 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2801 R"(package p;
2802 interface IFoo {
2803 const long int64_max_oob = 21474836509999999999999999;
2804 }
2805 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002806 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002807 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2808 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002809}
2810
Devin Moore7b8d5c92020-03-17 14:14:08 -07002811TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002812 AidlError error;
2813 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002814 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002815 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002816 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2817 R"(package p;
2818 interface IFoo {
2819 const long int64_min_oob = -21474836509999999999999999;
2820 }
2821 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002822 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002823 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2824 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002825}
2826
Devin Moore7b8d5c92020-03-17 14:14:08 -07002827TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002828 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002829 const string expected_stderr =
2830 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2831 "literal: byte\n"
2832 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2833 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002834 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2835 R"(package p;
2836 @Backing(type="byte")
2837 enum TestEnum {
2838 FOO = 127,
2839 BAR,
2840 }
2841 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002842 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002843 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002844 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002845}
2846
Devin Mooredecaf292020-04-30 09:16:40 -07002847TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2848 AidlError error;
2849 const string expected_stderr =
2850 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2851 "be one of: type\n"
2852 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2853 "be one of: type\n";
2854 CaptureStderr();
2855 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2856 R"(package p;
2857 @Backing(foo="byte")
2858 enum TestEnum {
2859 FOO = 1,
2860 BAR,
2861 }
2862 )",
2863 typenames_, GetLanguage(), &error));
2864 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2865 EXPECT_EQ(AidlError::BAD_TYPE, error);
2866}
2867
Jooyung Han66813932020-10-23 13:24:44 +09002868TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002869 io_delegate_.SetFileContents("Foo.aidl",
2870 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2871 "Map<String, Baz> d; Bar[] e; }");
2872 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2873 io_delegate_.SetFileContents("Baz.aidl",
2874 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002875 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2876 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2877}
2878
Jooyung Han66813932020-10-23 13:24:44 +09002879TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002880 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002881 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002882 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002883 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
2884 "named 'bar'.\n";
2885 CaptureStderr();
2886 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2887 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2888 EXPECT_EQ(expected_error, GetCapturedStderr());
2889}
2890
2891TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
2892 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
2893 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2894 string expected_error =
2895 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09002896 "named 'bar'.\n";
2897 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002898 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2899 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002900 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002901}
2902
Jooyung Han66813932020-10-23 13:24:44 +09002903TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002904 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002905 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2906 string expected_error =
2907 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2908 "only be an in parameter.\n";
2909 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002910 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2911 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002912 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002913}
2914
Jooyung Han66813932020-10-23 13:24:44 +09002915TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002916 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002917 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
2918 string expected_error =
2919 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
2920 "only be an in parameter.\n";
2921 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002922 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2923 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002924 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002925}
2926
Jooyung Han66813932020-10-23 13:24:44 +09002927TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002928 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002929 Options options = Options::From("aidl --lang=java Foo.aidl");
2930 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002931 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
2932 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09002933 CaptureStderr();
2934 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2935 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2936}
Devin Moore53fc99c2020-08-12 08:07:52 -07002937
Jooyung Han1f14ab32020-10-14 13:48:29 +09002938const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2939
2940#include <a/ByteEnum.h>
2941#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002942#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002943#include <binder/Status.h>
2944#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002945#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002946#include <utility>
2947#include <variant>
2948#include <vector>
2949
2950namespace a {
2951
2952class Foo : public ::android::Parcelable {
2953public:
Jooyung Han97945de2020-10-15 16:41:38 +09002954 inline bool operator!=(const Foo& rhs) const {
2955 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002956 }
Jooyung Han97945de2020-10-15 16:41:38 +09002957 inline bool operator<(const Foo& rhs) const {
2958 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002959 }
Jooyung Han97945de2020-10-15 16:41:38 +09002960 inline bool operator<=(const Foo& rhs) const {
2961 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002962 }
Jooyung Han97945de2020-10-15 16:41:38 +09002963 inline bool operator==(const Foo& rhs) const {
2964 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002965 }
Jooyung Han97945de2020-10-15 16:41:38 +09002966 inline bool operator>(const Foo& rhs) const {
2967 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002968 }
Jooyung Han97945de2020-10-15 16:41:38 +09002969 inline bool operator>=(const Foo& rhs) const {
2970 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002971 }
Jooyung Han97945de2020-10-15 16:41:38 +09002972
Jooyung Han1f14ab32020-10-14 13:48:29 +09002973 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002974 ns = 0, // int[] ns;
2975 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002976 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002977 };
Jooyung Han97945de2020-10-15 16:41:38 +09002978
Jooyung Han1f14ab32020-10-14 13:48:29 +09002979 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002980 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002981
2982 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002983 Foo(const Foo&) = default;
2984 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002985 Foo& operator=(const Foo&) = default;
2986 Foo& operator=(Foo&&) = default;
2987
Jooyung Han97945de2020-10-15 16:41:38 +09002988 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2989 constexpr Foo(_Tp&& _arg)
2990 : _value(std::forward<_Tp>(_arg)) {}
2991
2992 template <typename... _Tp>
2993 constexpr explicit Foo(_Tp&&... _args)
2994 : _value(std::forward<_Tp>(_args)...) {}
2995
2996 template <Tag _tag, typename... _Tp>
2997 static Foo make(_Tp&&... _args) {
2998 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002999 }
Jooyung Han97945de2020-10-15 16:41:38 +09003000
3001 template <Tag _tag, typename _Tp, typename... _Up>
3002 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3003 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003004 }
3005
3006 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003007 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003008 }
3009
Jooyung Han97945de2020-10-15 16:41:38 +09003010 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003011 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003012 if (getTag() != _tag) { abort(); }
3013 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003014 }
3015
Jooyung Han97945de2020-10-15 16:41:38 +09003016 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003017 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09003018 if (getTag() != _tag) { abort(); }
3019 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003020 }
3021
Jooyung Han97945de2020-10-15 16:41:38 +09003022 template <Tag _tag, typename... _Tp>
3023 void set(_Tp&&... _args) {
3024 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003025 }
3026
3027 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3028 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3029 static const std::string& getParcelableDescriptor() {
3030 static const std::string DESCIPTOR = "a.Foo";
3031 return DESCIPTOR;
3032 }
3033private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003034 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003035}; // class Foo
3036
3037} // namespace a
3038)";
3039
3040const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3041
3042namespace a {
3043
3044::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3045 ::android::status_t _aidl_ret_status;
3046 int32_t _aidl_tag;
3047 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3048 switch (_aidl_tag) {
3049 case ns: {
3050 ::std::vector<int32_t> _aidl_value;
3051 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
3052 set<ns>(std::move(_aidl_value));
3053 return ::android::OK; }
3054 case e: {
3055 ::a::ByteEnum _aidl_value;
3056 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
3057 set<e>(std::move(_aidl_value));
3058 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003059 case pfd: {
3060 ::android::os::ParcelFileDescriptor _aidl_value;
3061 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
3062 set<pfd>(std::move(_aidl_value));
3063 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003064 }
3065 return ::android::BAD_VALUE;
3066}
3067
3068::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3069 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3070 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3071 switch (getTag()) {
3072 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3073 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003074 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003075 }
3076 abort();
3077}
3078
3079} // namespace a
3080)";
3081
Jooyung Han6beac042020-10-17 21:59:43 +09003082const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3083#include <android/binder_interface_utils.h>
3084#include <android/binder_parcelable_utils.h>
3085
3086#include <type_traits>
3087#include <utility>
3088#include <variant>
3089#include <cstdint>
3090#include <memory>
3091#include <optional>
3092#include <string>
3093#include <vector>
3094#ifdef BINDER_STABILITY_SUPPORT
3095#include <android/binder_stability.h>
3096#endif // BINDER_STABILITY_SUPPORT
3097#include <aidl/a/ByteEnum.h>
3098namespace aidl {
3099namespace a {
3100class Foo {
3101public:
3102 typedef std::false_type fixed_size;
3103 static const char* descriptor;
3104
3105 enum Tag : int32_t {
3106 ns = 0, // int[] ns;
3107 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003108 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003109 };
3110
3111 template<typename _Tp>
3112 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3113
3114 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3115 Foo(const Foo&) = default;
3116 Foo(Foo&&) = default;
3117 Foo& operator=(const Foo&) = default;
3118 Foo& operator=(Foo&&) = default;
3119
3120 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3121 constexpr Foo(_Tp&& _arg)
3122 : _value(std::forward<_Tp>(_arg)) {}
3123
3124 template <typename... _Tp>
3125 constexpr explicit Foo(_Tp&&... _args)
3126 : _value(std::forward<_Tp>(_args)...) {}
3127
3128 template <Tag _tag, typename... _Tp>
3129 static Foo make(_Tp&&... _args) {
3130 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3131 }
3132
3133 template <Tag _tag, typename _Tp, typename... _Up>
3134 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3135 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3136 }
3137
3138 Tag getTag() const {
3139 return static_cast<Tag>(_value.index());
3140 }
3141
3142 template <Tag _tag>
3143 const auto& get() const {
3144 if (getTag() != _tag) { abort(); }
3145 return std::get<_tag>(_value);
3146 }
3147
3148 template <Tag _tag>
3149 auto& get() {
3150 if (getTag() != _tag) { abort(); }
3151 return std::get<_tag>(_value);
3152 }
3153
3154 template <Tag _tag, typename... _Tp>
3155 void set(_Tp&&... _args) {
3156 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3157 }
3158
3159 binder_status_t readFromParcel(const AParcel* _parcel);
3160 binder_status_t writeToParcel(AParcel* _parcel) const;
3161 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
3162private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003163 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003164};
3165} // namespace a
3166} // namespace aidl
3167)";
3168
3169const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3170
3171#include <android/binder_parcel_utils.h>
3172
3173namespace aidl {
3174namespace a {
3175const char* Foo::descriptor = "a.Foo";
3176
3177binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3178 binder_status_t _aidl_ret_status;
3179 int32_t _aidl_tag;
3180 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3181 switch (_aidl_tag) {
3182 case ns: {
3183 std::vector<int32_t> _aidl_value;
3184 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3185 set<ns>(std::move(_aidl_value));
3186 return STATUS_OK; }
3187 case e: {
3188 ::aidl::a::ByteEnum _aidl_value;
3189 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3190 set<e>(std::move(_aidl_value));
3191 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003192 case pfd: {
3193 ::ndk::ScopedFileDescriptor _aidl_value;
3194 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3195 set<pfd>(std::move(_aidl_value));
3196 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003197 }
3198 return STATUS_BAD_VALUE;
3199}
3200binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3201 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3202 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3203 switch (getTag()) {
3204 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3205 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003206 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003207 }
3208 abort();
3209}
3210
3211} // namespace a
3212} // namespace aidl
3213)";
3214
Jooyung Han1f14ab32020-10-14 13:48:29 +09003215const char kUnionExampleExpectedOutputJava[] = R"(/*
3216 * This file is auto-generated. DO NOT MODIFY.
3217 */
3218package a;
3219
3220
3221public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003222 // tags for union fields
3223 public final static int ns = 0; // int[] ns;
3224 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003225 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003226
3227 private int _tag;
3228 private Object _value;
3229
3230 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003231 int[] _value = {42};
3232 this._tag = ns;
3233 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003234 }
Jooyung Han97945de2020-10-15 16:41:38 +09003235
Jooyung Han1f14ab32020-10-14 13:48:29 +09003236 private Foo(android.os.Parcel _aidl_parcel) {
3237 readFromParcel(_aidl_parcel);
3238 }
Jooyung Han97945de2020-10-15 16:41:38 +09003239
Jooyung Hance62f932020-10-25 10:21:49 +09003240 private Foo(int _tag, Object _value) {
3241 this._tag = _tag;
3242 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003243 }
3244
3245 public int getTag() {
3246 return _tag;
3247 }
3248
Jooyung Han97945de2020-10-15 16:41:38 +09003249 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003250
3251 public static Foo ns(int[] _value) {
3252 return new Foo(ns, _value);
3253 }
Jooyung Han97945de2020-10-15 16:41:38 +09003254
Jooyung Han1f14ab32020-10-14 13:48:29 +09003255 public int[] getNs() {
3256 _assertTag(ns);
3257 return (int[]) _value;
3258 }
Jooyung Han97945de2020-10-15 16:41:38 +09003259
Jooyung Han1f14ab32020-10-14 13:48:29 +09003260 public void setNs(int[] _value) {
3261 _set(ns, _value);
3262 }
3263
Jooyung Han97945de2020-10-15 16:41:38 +09003264 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003265
3266 public static Foo e(byte _value) {
3267 return new Foo(e, _value);
3268 }
Jooyung Han97945de2020-10-15 16:41:38 +09003269
Jooyung Han1f14ab32020-10-14 13:48:29 +09003270 public byte getE() {
3271 _assertTag(e);
3272 return (byte) _value;
3273 }
Jooyung Han97945de2020-10-15 16:41:38 +09003274
Jooyung Han1f14ab32020-10-14 13:48:29 +09003275 public void setE(byte _value) {
3276 _set(e, _value);
3277 }
3278
Jooyung Hand2fa0232020-10-19 02:51:41 +09003279 // ParcelFileDescriptor pfd;
3280
3281 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3282 return new Foo(pfd, _value);
3283 }
3284
3285 public android.os.ParcelFileDescriptor getPfd() {
3286 _assertTag(pfd);
3287 return (android.os.ParcelFileDescriptor) _value;
3288 }
3289
3290 public void setPfd(android.os.ParcelFileDescriptor _value) {
3291 _set(pfd, _value);
3292 }
3293
Jooyung Han1f14ab32020-10-14 13:48:29 +09003294 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3295 @Override
3296 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003297 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003298 }
3299 @Override
3300 public Foo[] newArray(int _aidl_size) {
3301 return new Foo[_aidl_size];
3302 }
3303 };
Jooyung Han97945de2020-10-15 16:41:38 +09003304
Jooyung Han1f14ab32020-10-14 13:48:29 +09003305 @Override
3306 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3307 _aidl_parcel.writeInt(_tag);
3308 switch (_tag) {
3309 case ns:
3310 _aidl_parcel.writeIntArray(getNs());
3311 break;
3312 case e:
3313 _aidl_parcel.writeByte(getE());
3314 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003315 case pfd:
3316 if ((getPfd()!=null)) {
3317 _aidl_parcel.writeInt(1);
3318 getPfd().writeToParcel(_aidl_parcel, 0);
3319 }
3320 else {
3321 _aidl_parcel.writeInt(0);
3322 }
3323 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003324 }
3325 }
Jooyung Han97945de2020-10-15 16:41:38 +09003326
Jooyung Han1f14ab32020-10-14 13:48:29 +09003327 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3328 int _aidl_tag;
3329 _aidl_tag = _aidl_parcel.readInt();
3330 switch (_aidl_tag) {
3331 case ns: {
3332 int[] _aidl_value;
3333 _aidl_value = _aidl_parcel.createIntArray();
3334 _set(_aidl_tag, _aidl_value);
3335 return; }
3336 case e: {
3337 byte _aidl_value;
3338 _aidl_value = _aidl_parcel.readByte();
3339 _set(_aidl_tag, _aidl_value);
3340 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003341 case pfd: {
3342 android.os.ParcelFileDescriptor _aidl_value;
3343 if ((0!=_aidl_parcel.readInt())) {
3344 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3345 }
3346 else {
3347 _aidl_value = null;
3348 }
3349 _set(_aidl_tag, _aidl_value);
3350 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003351 }
3352 throw new RuntimeException("union: out of range: " + _aidl_tag);
3353 }
Jooyung Han97945de2020-10-15 16:41:38 +09003354
Jooyung Han1f14ab32020-10-14 13:48:29 +09003355 @Override
3356 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003357 int _mask = 0;
3358 switch (getTag()) {
3359 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003360 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003361 break;
3362 }
3363 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003364 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003365 private int describeContents(Object _v) {
3366 if (_v == null) return 0;
3367 if (_v instanceof android.os.Parcelable) {
3368 return ((android.os.Parcelable) _v).describeContents();
3369 }
3370 return 0;
3371 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003372
3373 private void _assertTag(int tag) {
3374 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003375 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003376 }
3377 }
Jooyung Han97945de2020-10-15 16:41:38 +09003378
Jooyung Han1f14ab32020-10-14 13:48:29 +09003379 private String _tagString(int _tag) {
3380 switch (_tag) {
3381 case ns: return "ns";
3382 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003383 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003384 }
3385 throw new IllegalStateException("unknown field: " + _tag);
3386 }
Jooyung Han97945de2020-10-15 16:41:38 +09003387
Jooyung Hance62f932020-10-25 10:21:49 +09003388 private void _set(int _tag, Object _value) {
3389 this._tag = _tag;
3390 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003391 }
3392}
3393)";
3394
Jooyung Han97945de2020-10-15 16:41:38 +09003395struct AidlUnionTest : ::testing::Test {
3396 void SetUp() override {
3397 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003398package a;
3399import a.ByteEnum;
3400union Foo {
3401 int[] ns = {42};
3402 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003403 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003404}
3405)");
Jooyung Han97945de2020-10-15 16:41:38 +09003406 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003407package a;
3408@Backing(type="byte")
3409enum ByteEnum {
3410 a, b, c
3411}
3412)");
Jooyung Han97945de2020-10-15 16:41:38 +09003413 }
3414 FakeIoDelegate io_delegate_;
3415 void Compile(string lang) {
3416 string command = "aidl --structured -I. -o out --lang=" + lang;
3417 if (lang == "cpp" || lang == "ndk") {
3418 command += " -h out";
3419 }
3420 command += " a/Foo.aidl";
3421 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003422 CaptureStderr();
3423 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3424 auto err = GetCapturedStderr();
3425 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003426 }
3427 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3428 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003429 string actual;
3430 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3431 EXPECT_EQ(expected, actual);
3432 }
Jooyung Han97945de2020-10-15 16:41:38 +09003433 }
3434};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003435
Jooyung Han97945de2020-10-15 16:41:38 +09003436TEST_F(AidlUnionTest, Example_Cpp) {
3437 Compile("cpp");
3438 EXPECT_COMPILE_OUTPUTS(
3439 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3440 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3441}
3442
Jooyung Han6beac042020-10-17 21:59:43 +09003443TEST_F(AidlUnionTest, Example_Ndk) {
3444 Compile("ndk");
3445 EXPECT_COMPILE_OUTPUTS(
3446 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3447 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3448}
3449
Jooyung Han97945de2020-10-15 16:41:38 +09003450TEST_F(AidlUnionTest, Example_Java) {
3451 Compile("java");
3452 EXPECT_COMPILE_OUTPUTS(
3453 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003454 // TODO(b/170689477) Rust
3455}
3456
Jooyung Hanfe89f122020-10-14 03:49:18 +09003457TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3458 const string method = "package a; union Foo {}";
3459 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3460 CaptureStderr();
3461 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3462 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3463}
3464
3465TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3466 const string method = "package a; union Foo { ParcelableHolder x; }";
3467 const string expected_stderr =
3468 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3469 CaptureStderr();
3470 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3471 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3472}
3473
Devin Moore53fc99c2020-08-12 08:07:52 -07003474TEST_P(AidlTest, GenericStructuredParcelable) {
3475 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3476 Options options =
3477 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3478 const string expected_stderr = "";
3479 CaptureStderr();
3480 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3481 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3482}
3483
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003484TEST_F(AidlTest, NestedTypeArgs) {
3485 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
3486 io_delegate_.SetFileContents(
3487 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<Bar<String>> barss; }");
3488 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3489 const string expected_stderr = "";
3490 CaptureStderr();
3491 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3492 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3493
3494 string code;
3495 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3496 EXPECT_THAT(code, testing::HasSubstr("a.Bar<a.Bar<java.lang.String>> barss;"));
3497}
3498
Jooyung Han14004ed2020-10-16 03:49:57 +09003499struct GenericAidlTest : ::testing::Test {
3500 FakeIoDelegate io_delegate_;
3501 void Compile(string cmd) {
3502 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3503 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3504 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3505 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3506
3507 Options options = Options::From(cmd);
3508 CaptureStderr();
3509 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3510 EXPECT_EQ("", GetCapturedStderr());
3511 }
3512};
3513
3514TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3515 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3516 string code;
3517 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3518 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3519 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3520 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3521}
3522
3523TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3524 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3525 string code;
3526 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3527 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3528 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3529 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3530}
3531
Devin Moore53fc99c2020-08-12 08:07:52 -07003532TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3533 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3534 Options options =
3535 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3536 const string expected_stderr =
3537 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3538 CaptureStderr();
3539 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3541}
3542
3543TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3544 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3545 Options options =
3546 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3547 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3548 CaptureStderr();
3549 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3550 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3551}
3552
Jooyung Han7a308842020-10-27 19:06:49 +09003553TEST_P(AidlTest, LongCommentWithinConstExpression) {
3554 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3555 Options options =
3556 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3557 CaptureStderr();
3558 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3559 EXPECT_EQ("", GetCapturedStderr());
3560}
3561
Jeongik Chaef44e622020-10-23 16:00:52 +09003562TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3563 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3564 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3565 std::string expectedErr =
3566 "ERROR: a/Foo.aidl:1.28-30: "
3567 "Encountered an untyped List or Map. The use of untyped List/Map is "
3568 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3569 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3570 "ERROR: a/Foo.aidl:1.35-37: "
3571 "Encountered an untyped List or Map. The use of untyped List/Map is "
3572 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3573 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3574 CaptureStderr();
3575 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3576 EXPECT_EQ(expectedErr, GetCapturedStderr());
3577}
3578
3579TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003580 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3581 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003582 std::string expectedErr =
3583 "ERROR: a/Foo.aidl:1.33-35: "
3584 "Encountered an untyped List or Map. The use of untyped List/Map is "
3585 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3586 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3587 "ERROR: a/Foo.aidl:1.40-42: "
3588 "Encountered an untyped List or Map. The use of untyped List/Map is "
3589 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3590 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003591 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003592 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3593 EXPECT_EQ(expectedErr, GetCapturedStderr());
3594}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003595
Jeongik Chaef44e622020-10-23 16:00:52 +09003596TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3597 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3598 io_delegate_.SetFileContents(
3599 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3600 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3601 std::string expectedErr =
3602 "ERROR: a/Foo.aidl:1.52-54: "
3603 "Encountered an untyped List or Map. The use of untyped List/Map is "
3604 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3605 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3606 "ERROR: a/Foo.aidl:1.64-66: "
3607 "Encountered an untyped List or Map. The use of untyped List/Map is "
3608 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3609 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3610 CaptureStderr();
3611 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3612 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003613}
3614
Christopher Wiley90be4e32015-10-20 14:55:25 -07003615} // namespace aidl
3616} // namespace android