blob: 56faba579b1519d5ffdca4995a16729358318796 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
Jooyung Hanf8c39632021-10-05 09:56:29 +09001477TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1478 const string input_path = "p/IFoo.aidl";
1479 const string input =
1480 "package p;\n"
1481 "interface IFoo {\n"
1482 " parcelable Inner {\n"
1483 " enum Enum { A }\n"
1484 " }\n"
1485 "}";
1486 CaptureStderr();
1487 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1488 EXPECT_EQ(GetCapturedStderr(), "");
1489
1490 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1491 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1492 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1493 EXPECT_TRUE(enum_type.is_resolved);
1494 EXPECT_TRUE(inner_type.is_resolved);
1495 EXPECT_TRUE(ifoo_type.is_resolved);
1496 // GetParentType()
1497 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1498 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1499 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1500 // GetRootType()
1501 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1502 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1503 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1504 // GetDocument()
1505 auto main_document = &typenames_.MainDocument();
1506 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1507 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1508 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1509}
1510
Jooyung Han2aedb112021-09-29 09:37:59 +09001511TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1512 io_delegate_.SetFileContents("p/IOuter.aidl",
1513 "package p;\n"
1514 "interface IOuter {\n"
1515 " parcelable Inner {}\n"
1516 "}");
1517 import_paths_.emplace("");
1518 const string input_path = "p/IFoo.aidl";
1519 const string input =
1520 "package p;\n"
1521 "interface IFoo {\n"
1522 " p.IOuter.Inner get();\n"
1523 "}";
1524 CaptureStderr();
1525 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1526 EXPECT_EQ(GetCapturedStderr(), "");
1527
1528 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1529}
1530
1531TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1532 io_delegate_.SetFileContents("p/IOuter.aidl",
1533 "package p;\n"
1534 "interface IOuter {\n"
1535 " parcelable Inner {}\n"
1536 "}");
1537 import_paths_.emplace("");
1538 const string input_path = "p/IFoo.aidl";
1539 const string input =
1540 "package p;\n"
1541 "import p.IOuter.Inner;"
1542 "interface IFoo {\n"
1543 " Inner get();\n"
1544 "}";
1545 CaptureStderr();
1546 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1547 EXPECT_EQ(GetCapturedStderr(), "");
1548
1549 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1550}
1551
1552TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1553 const string input_path = "p/IFoo.aidl";
1554 const string input =
1555 "package p;\n"
1556 "interface IFoo {\n"
1557 " parcelable Result {}\n"
1558 " Result get();\n"
1559 "}";
1560 CaptureStderr();
1561 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1562 EXPECT_EQ(GetCapturedStderr(), "");
1563
1564 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1565}
1566
1567// Finding the type of nested named member.
1568struct TypeFinder : AidlVisitor {
1569 string name;
1570 const AidlTypeSpecifier* type = nullptr;
1571 TypeFinder(std::string name) : name(name) {}
1572 void Visit(const AidlVariableDeclaration& v) override {
1573 if (v.GetName() == name) {
1574 type = &v.GetType();
1575 }
1576 }
1577 void Visit(const AidlMethod& m) override {
1578 if (m.GetName() == name) {
1579 type = &m.GetType();
1580 }
1581 }
1582 static string Get(const AidlDefinedType& type, const string& name) {
1583 TypeFinder v(name);
1584 VisitTopDown(v, type);
1585 return v.type ? v.type->Signature() : "(null)";
1586 };
1587};
1588
1589TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1590 io_delegate_.SetFileContents("q/IBar.aidl",
1591 "package q;\n"
1592 "interface IBar {\n"
1593 " parcelable Baz {}\n"
1594 "}");
1595 import_paths_.emplace("");
1596 const string input_path = "p/IFoo.aidl";
1597 const string input =
1598 "package p;\n"
1599 "import q.IBar;\n"
1600 "interface IFoo {\n"
1601 " parcelable Nested {\n"
1602 " Baz t1;\n"
1603 " }\n"
1604 " parcelable Baz { }\n"
1605 " IBar.Baz t2();\n"
1606 " Baz t3();\n"
1607 "}";
1608 CaptureStderr();
1609 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1610 EXPECT_EQ(GetCapturedStderr(), "");
1611 ASSERT_NE(nullptr, foo);
1612
1613 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1614 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1615 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1616}
1617
1618TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1619 const string input_path = "p/Foo.aidl";
1620 const string input =
1621 "package p;\n"
1622 "parcelable Foo {\n"
1623 " parcelable Foo {}\n"
1624 "}";
1625 CaptureStderr();
1626 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1628}
1629
1630TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1631 const string input_path = "p/IFoo.aidl";
1632 const string input =
1633 "package p;\n"
1634 "interface IFoo {\n"
1635 " interface ICallback { void done(); }\n"
1636 " void doTask(ICallback cb);\n"
1637 "}";
1638 CaptureStderr();
1639 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1640 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1641}
1642
Jooyung Han2b1487d2021-09-30 09:57:01 +09001643TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1644 const string input_path = "p/IFoo.aidl";
1645 const string input =
1646 "package p;\n"
1647 "interface IFoo {\n"
1648 " parcelable Bar cpp_header \"Bar.h\";\n"
1649 "}";
1650 CaptureStderr();
1651 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1652 EXPECT_THAT(GetCapturedStderr(),
1653 HasSubstr("Unstructured parcelables should be at the root scope"));
1654}
1655
Jooyung Han7fc5de02021-09-30 22:26:27 +09001656TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1657 const string input_path = "p/Foo.aidl";
1658 const string input =
1659 "package p;\n"
1660 "parcelable Foo<T> {\n"
1661 " parcelable Bar {}\n"
1662 "}";
1663 CaptureStderr();
1664 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1665 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1666}
1667
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001668TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1669 const string input_path = "p/IFoo.aidl";
1670 const string input =
1671 "package p;\n"
1672 "interface IFoo {\n"
1673 " parcelable;\n" // missing identifier
1674 "}";
1675 CaptureStderr();
1676 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1677 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1678}
1679
Jooyung Han2aedb112021-09-29 09:37:59 +09001680TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1681 const string input_path = "p/Foo.aidl";
1682 const string input =
1683 "package p;\n"
1684 "interface Foo {\n"
1685 " parcelable Bar {}\n"
1686 " parcelable Bar {}\n"
1687 "}";
1688 CaptureStderr();
1689 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1690 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1691}
1692
1693TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1694 struct Failure {
1695 string err;
1696 };
1697 struct TestCase {
1698 string type;
1699 variant<string, Failure> expected; // success<0> or failure<1>
1700 };
1701 vector<TestCase> cases = {
1702 {"foo.A", "foo.A"},
1703 {"foo.A.B", "foo.A.B"},
1704 {"@nullable(heap=true) A", "foo.A.B.A"},
1705 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1706 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1707 {"B", "foo.A.B.A.B"},
1708 {"A.B", "foo.A.B.A.B"},
1709 };
1710 const string input_path = "foo/A.aidl";
1711 for (auto& [type, expected] : cases) {
1712 AidlTypenames typenames;
1713 // clang-format off
1714 const string input =
1715 "package foo;\n"
1716 "parcelable A {\n"
1717 " parcelable B {\n"
1718 " parcelable A {\n"
1719 " parcelable B {\n"
1720 " }\n"
1721 " " + type + " m;\n"
1722 " }\n"
1723 " }\n"
1724 "}";
1725 // clang-format on
1726 CaptureStderr();
1727 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1728 if (auto failure = std::get_if<Failure>(&expected); failure) {
1729 ASSERT_EQ(nullptr, foo);
1730 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1731 } else {
1732 EXPECT_EQ(GetCapturedStderr(), "");
1733 ASSERT_NE(nullptr, foo);
1734 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1735 }
1736 }
1737}
1738
Jooyung Hanca84b032021-09-30 02:15:59 +09001739TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1740 const string input_path = "p/IFoo.aidl";
1741 const string input =
1742 "package p;\n"
1743 "interface IFoo {\n"
1744 " parcelable Result {}\n"
1745 "}";
1746 CaptureStderr();
1747 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1748 ASSERT_NE(nullptr, foo);
1749 EXPECT_EQ(GetCapturedStderr(), "");
1750
1751 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1752 ASSERT_NE(nullptr, result);
1753 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1754}
1755
Jooyung Han8e9ae872021-10-13 02:52:25 +09001756TEST_F(AidlTest, ReorderNestedTypesForCppOutput) {
1757 const string input_path = "p/IFoo.aidl";
1758 const string input = R"(
1759 package p;
1760 interface IFoo {
1761 // partial orderings for [A, D, G]:
1762 // D - A
1763 // A - G
1764 parcelable A {
1765 // partial orderings for [B, C]:
1766 // C - B
1767 parcelable B {
1768 C c;
1769 D.E d;
1770 }
1771 parcelable C {}
1772 }
1773 parcelable D {
1774 // partial orderings for [E, F]:
1775 // F - E
1776 parcelable E {
1777 F f;
1778 }
1779 parcelable F {}
1780 }
1781 parcelable G {
1782 A.B b;
1783 }
1784 }
1785 )";
1786 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1787 io_delegate_.SetFileContents(input_path, input);
1788 CaptureStderr();
1789 EXPECT_TRUE(compile_aidl(options, io_delegate_));
1790 EXPECT_EQ(GetCapturedStderr(), "");
1791
1792 string code;
1793 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/IFoo.h", &code));
1794 // check partial orderings: a should comes before b
1795 EXPECT_LE(code.find("class D"), code.find("class A"));
1796 EXPECT_LE(code.find("class A"), code.find("class G"));
1797 EXPECT_LE(code.find("class C"), code.find("class B"));
1798 EXPECT_LE(code.find("class F"), code.find("class E"));
1799}
1800
1801TEST_F(AidlTest, RejectsNestedTypesWithCyclicDeps) {
1802 const string input_path = "p/IFoo.aidl";
1803 const string input = R"(
1804 package p;
1805 interface IFoo {
1806 // Cycles:
1807 // D - A
1808 // A - G
1809 // G - D
1810 parcelable A {
1811 parcelable B {
1812 C c;
1813 }
1814 }
1815 parcelable C {
1816 parcelable D {
1817 E e;
1818 }
1819 }
1820 parcelable E {
1821 parcelable F {
1822 A a;
1823 }
1824 }
1825 }
1826 )";
1827 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1828 io_delegate_.SetFileContents(input_path, input);
1829 CaptureStderr();
1830 EXPECT_FALSE(compile_aidl(options, io_delegate_));
1831 EXPECT_THAT(GetCapturedStderr(), HasSubstr("IFoo has nested types with cyclic references."));
1832}
1833
Jooyung Han0a950bd2021-05-15 12:50:36 +09001834TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001835 const string input_path = "p/Wrapper.aidl";
1836 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001837
1838 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1839 EXPECT_NE(nullptr, parse_result);
1840
1841 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1842 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1843 (..., params->emplace_back(std::move(type_params)));
1844 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1845 };
1846
1847 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
Steven Morelanda7560e82021-10-08 16:24:39 -07001848 std::vector<std::unique_ptr<AidlAnnotation>> annotations;
1849 annotations.emplace_back(std::unique_ptr<AidlAnnotation>(
1850 AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {})));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001851 type->Annotate(std::move(annotations));
1852 return std::move(type);
1853 };
1854
1855 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1856 (void)type->SetArray();
1857 return std::move(type);
1858 };
1859
1860 auto w = type("p.Wrapper", type("String"));
1861 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1862
1863 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1864 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1865 cpp::CppNameOf(*nullable_w, typenames_));
1866
1867 auto array_w = set_array(type("p.Wrapper", type("String")));
1868 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1869 cpp::CppNameOf(*array_w, typenames_));
1870
1871 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1872 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1873 cpp::CppNameOf(*nullable_array_w, typenames_));
1874
1875 auto list_w = type("List", type("p.Wrapper", type("String")));
1876 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1877 cpp::CppNameOf(*list_w, typenames_));
1878
1879 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1880 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1881 cpp::CppNameOf(*nullable_list_w, typenames_));
1882}
1883
Devin Moore7b8d5c92020-03-17 14:14:08 -07001884TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001885 io_delegate_.SetFileContents(
1886 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001887 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001888 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001889 const string input_path = "p/IFoo.aidl";
1890 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001891 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1892 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001893 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001894 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001895 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001896
1897 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1898 // C++ understands C++ specific stuff
1899 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1900 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001901 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001902 EXPECT_EQ(1u, headers.size());
1903 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001904}
1905
Christopher Wileyf8136192016-04-12 14:19:35 -07001906TEST_F(AidlTest, WritesCorrectDependencyFile) {
1907 // While the in tree build system always gives us an output file name,
1908 // other android tools take advantage of our ability to infer the intended
1909 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001910 vector<string> args = {
1911 "aidl",
1912 "-d dep/file/path",
1913 "-o place/for/output",
1914 "p/IFoo.aidl"};
1915 Options options = Options::From(args);
1916 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001917 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001918 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001919 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001920 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1921}
1922
Dan Willemsen93298ee2016-11-10 23:55:55 -08001923TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1924 // While the in tree build system always gives us an output file name,
1925 // other android tools take advantage of our ability to infer the intended
1926 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001927 vector<string> args = {
1928 "aidl",
1929 "-d dep/file/path",
1930 "--ninja",
1931 "-o place/for/output",
1932 "p/IFoo.aidl"};
1933 Options options = Options::From(args);
1934 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001935 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001936 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001937 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001938 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1939}
1940
Jiyong Parkdf202122019-09-30 20:48:35 +09001941TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001942 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1943 // this by calling aidl with every .aidl file it finds, then parsing the
1944 // generated dependency files. Those that reference .java output files are
1945 // for interfaces and those that do not are parcelables. However, for both
1946 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001947 vector<string> args = {
1948 "aidl",
1949 "-o place/for/output",
1950 "-d dep/file/path",
1951 "p/Foo.aidl"};
1952 Options options = Options::From(args);
1953 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001954 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001955 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001956 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001957 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1958}
1959
1960TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1961 vector<string> args = {
1962 "aidl",
1963 "--structured",
1964 "-o place/for/output",
1965 "-d dep/file/path",
1966 "p/Foo.aidl"};
1967 Options options = Options::From(args);
1968 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001969 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001970 string actual_dep_file_contents;
1971 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1972 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001973}
1974
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001975TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1976 vector<string> args = {
1977 "aidl",
1978 "--lang=java",
1979 "-o place/for/output",
1980 "p/Foo.aidl"};
1981 Options options = Options::From(args);
1982 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001983 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001984 string output_file_contents;
1985 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1986}
1987
Devin Moore21b26772020-08-26 16:37:56 -07001988TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001989 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001990 const string list_array_parcelable =
1991 "package a; parcelable Foo {\n"
1992 " List[] lists; }";
1993 CaptureStderr();
1994 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1995 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1996}
1997
Jiyong Parkf8d53612020-05-04 14:06:13 +09001998TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1999 AidlError error;
2000 string expected_stderr =
2001 "ERROR: a/IFoo.aidl:2.7-11: "
2002 "Encountered an untyped List or Map. The use of untyped List/Map is "
2003 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2004 "the receiving side. Consider switching to an array or a generic List/Map.\n";
2005 if (GetLanguage() != Options::Language::JAVA) {
2006 expected_stderr =
2007 "ERROR: a/IFoo.aidl:2.1-7: "
2008 "Currently, only the Java backend supports non-generic List.\n";
2009 }
2010
2011 const string primitive_interface =
2012 "package a; interface IFoo {\n"
2013 " List foo(); }";
2014 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002015 AidlTypenames tn1;
2016 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002017 {"--structured"}));
2018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09002019
2020 string primitive_parcelable =
2021 "package a; parcelable IFoo {\n"
2022 " List foo;}";
2023 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002024 AidlTypenames tn2;
2025 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002026 {"--structured"}));
2027 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2028}
2029
Jeongik Cha225519b2020-08-29 01:55:32 +09002030TEST_P(AidlTest, ExtensionTest) {
2031 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002032 string extendable_parcelable =
2033 "package a; parcelable Data {\n"
2034 " ParcelableHolder extension;\n"
2035 " ParcelableHolder extension2;\n"
2036 "}";
Andrei Homescub2316a52021-09-04 04:41:12 +00002037 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
2038 EXPECT_EQ("", GetCapturedStderr());
Jeongik Cha225519b2020-08-29 01:55:32 +09002039}
2040TEST_P(AidlTest, ParcelableHolderAsReturnType) {
2041 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002042 string parcelableholder_return_interface =
2043 "package a; interface IFoo {\n"
2044 " ParcelableHolder foo();\n"
2045 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002046 EXPECT_EQ(nullptr,
2047 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09002048
Jeongik Cha225519b2020-08-29 01:55:32 +09002049 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
2050 GetCapturedStderr());
2051}
2052
2053TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
2054 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002055 string extendable_parcelable_arg_interface =
2056 "package a; interface IFoo {\n"
2057 " void foo(in ParcelableHolder ph);\n"
2058 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002059 EXPECT_EQ(nullptr,
2060 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
2061
Jeongik Cha225519b2020-08-29 01:55:32 +09002062 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
2063 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09002064}
2065
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002066TEST_P(AidlTest, RejectNullableParcelableHolderField) {
2067 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002068 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002069 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
2070 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002071 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002072 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2073}
2074
Jooyung Han3f347ca2020-12-01 12:41:50 +09002075TEST_P(AidlTest, ParcelablesWithConstants) {
2076 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002077 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002078 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002079 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002080 EXPECT_EQ("", GetCapturedStderr());
2081}
2082
2083TEST_P(AidlTest, UnionWithConstants) {
2084 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002085 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002086 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002087 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002088 EXPECT_EQ("", GetCapturedStderr());
2089}
2090
Jooyung Han633eab62021-01-07 14:12:40 +09002091TEST_F(AidlTest, ConstantsWithAnnotations) {
2092 io_delegate_.SetFileContents("IFoo.aidl",
2093 "interface IFoo {\n"
2094 " @JavaPassthrough(annotation=\"@Foo\")\n"
2095 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2096 "}");
2097 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2098 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002099 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002100 EXPECT_EQ("", GetCapturedStderr());
2101 string code;
2102 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2103 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2104 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2105}
2106
Jiyong Park02da7422018-07-16 16:00:26 +09002107TEST_F(AidlTest, ApiDump) {
2108 io_delegate_.SetFileContents(
2109 "foo/bar/IFoo.aidl",
2110 "package foo.bar;\n"
2111 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002112 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002113 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002114 " /* @hide applied \n"
2115 " @deprecated use foo2 */\n"
2116 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2117 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002118 " IFoo foo3(IFoo foo);\n"
2119 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002120 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002121 " /** blahblah\n"
2122 " @deprecated\n"
2123 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002124 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002125 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002126 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002127 "}\n");
2128 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2129 "package foo.bar;\n"
2130 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002131 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002132 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002133 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002134 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002135 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002136 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002137 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002138 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002139 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002140 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002141 "}\n");
2142 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002143 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2144 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002145 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002146 bool result = dump_api(options, io_delegate_);
2147 ASSERT_TRUE(result);
2148 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002149 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002150 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002151interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002152 /**
2153 * @hide
2154 * @deprecated use foo2
2155 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002156 int foo(out int[] a, String b, boolean c, inout List<String> d);
2157 int foo2(@utf8InCpp String x, inout List<String> y);
2158 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2159 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002160 /**
2161 * @deprecated reason why...
2162 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002163 const int A = 1;
2164 const String STR = "Hello";
2165}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002166)"),
2167 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002168
Jiyong Parke59c3682018-09-11 23:10:25 +09002169 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002170 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002171/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002172parcelable Data {
2173 int x = 10;
2174 int y;
2175 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002176 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002177}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002178)"),
2179 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002180}
2181
Jiyong Parked65bf42018-08-28 15:43:27 +09002182TEST_F(AidlTest, ApiDumpWithManualIds) {
2183 io_delegate_.SetFileContents(
2184 "foo/bar/IFoo.aidl",
2185 "package foo.bar;\n"
2186 "interface IFoo {\n"
2187 " int foo() = 1;\n"
2188 " int bar() = 2;\n"
2189 " int baz() = 10;\n"
2190 "}\n");
2191
Jiyong Parke59c3682018-09-11 23:10:25 +09002192 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002193 Options options = Options::From(args);
2194 bool result = dump_api(options, io_delegate_);
2195 ASSERT_TRUE(result);
2196 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002197 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002198 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002199interface IFoo {
2200 int foo() = 1;
2201 int bar() = 2;
2202 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002203}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002204)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002205}
2206
2207TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002208 const string expected_stderr =
2209 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2210 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002211 io_delegate_.SetFileContents(
2212 "foo/bar/IFoo.aidl",
2213 "package foo.bar;\n"
2214 "interface IFoo {\n"
2215 " int foo() = 1;\n"
2216 " int bar();\n"
2217 " int baz() = 10;\n"
2218 "}\n");
2219
Jiyong Parke59c3682018-09-11 23:10:25 +09002220 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002221 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002222 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002223 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002225}
2226
Jooyung Han965e31d2020-11-27 12:30:16 +09002227TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2228 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2229 "package foo.bar;\n"
2230 "interface IFoo {\n"
2231 " @utf8InCpp String foo();\n"
2232 " const @utf8InCpp String bar = \"bar\";\n"
2233 "}\n");
2234
2235 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2236 Options options = Options::From(args);
2237 CaptureStderr();
2238 EXPECT_TRUE(dump_api(options, io_delegate_));
2239 EXPECT_EQ("", GetCapturedStderr());
2240 string actual;
2241 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002242 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2243interface IFoo {
2244 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002245 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002246}
2247)"),
2248 actual);
2249}
2250
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002251TEST_F(AidlTest, ApiDumpWithEnums) {
2252 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2253 "package foo.bar;\n"
2254 "enum Enum {\n"
2255 " FOO,\n"
2256 " BAR = FOO + 1,\n"
2257 "}\n");
2258
2259 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2260 Options options = Options::From(args);
2261 CaptureStderr();
2262 EXPECT_TRUE(dump_api(options, io_delegate_));
2263 EXPECT_EQ("", GetCapturedStderr());
2264 string actual;
2265 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2266 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2267 "enum Enum {\n"
2268 " FOO = 0,\n"
2269 " BAR = 1,\n"
2270 "}\n"),
2271 actual);
2272}
2273
2274TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2275 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2276 "package foo.bar;\n"
2277 "enum Enum {\n"
2278 " FOO,\n"
2279 "}\n");
2280 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2281 "package foo.bar;\n"
2282 "import foo.bar.Enum;\n"
2283 "parcelable Foo {\n"
2284 " Enum e = Enum.FOO;\n"
2285 "}\n");
2286
2287 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2288 Options options = Options::From(args);
2289 CaptureStderr();
2290 EXPECT_TRUE(dump_api(options, io_delegate_));
2291 EXPECT_EQ("", GetCapturedStderr());
2292 string actual;
2293 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2294 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2295 "parcelable Foo {\n"
2296 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2297 "}\n"),
2298 actual);
2299}
2300
Jooyung Han71dfec32021-05-23 07:18:58 +09002301TEST_F(AidlTest, ApiDumpWithGenerics) {
2302 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2303 "package foo.bar;\n"
2304 "parcelable Foo<T, U> {\n"
2305 "}\n");
2306
2307 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2308 Options options = Options::From(args);
2309 CaptureStderr();
2310 EXPECT_TRUE(dump_api(options, io_delegate_));
2311 EXPECT_EQ("", GetCapturedStderr());
2312 string actual;
2313 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2314 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2315 "parcelable Foo<T, U> {\n"
2316 "}\n"),
2317 actual);
2318}
2319
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002320TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2321 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2322 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2323
2324 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2325 Options options = Options::From(args);
2326 CaptureStderr();
2327 EXPECT_FALSE(dump_api(options, io_delegate_));
2328 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2329}
2330
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002331TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002333 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2334 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002335 const string expected_map_stderr =
2336 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002337 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2338 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002339 "package p; interface IFoo {"
2340 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002341 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002342 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002343 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002344
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002345 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002346 "package p; interface IFoo {"
2347 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002348 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002349 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002350 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002351}
2352
Jeongik Chae48d9942020-01-02 17:39:00 +09002353TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002354 const string expected_stderr =
2355 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002356 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002357 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2358
2359 io_delegate_.SetFileContents("p/IFoo.aidl",
2360 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002361 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002362 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002363
2364 io_delegate_.SetFileContents("p/IFoo.aidl",
2365 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002366 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002367 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002368 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002370
2371 io_delegate_.SetFileContents("p/IFoo.aidl",
2372 "package p; interface IFoo {"
2373 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002374 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002375
2376 io_delegate_.SetFileContents("p/IFoo.aidl",
2377 "package p; interface IFoo {"
2378 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002379 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002380}
2381
Jeongik Chadf76dc72019-11-28 00:08:47 +09002382TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002384 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2385 io_delegate_.SetFileContents(options.InputFiles().front(),
2386 "package p; interface IFoo {"
2387 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002388 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002389 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002391}
2392
2393TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002394 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002395 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002396 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002397 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002398 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2399 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002400
Jooyung Han13f1fa52021-06-11 18:06:12 +09002401 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002402 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2403 io_delegate_.SetFileContents("p/IFoo.aidl",
2404 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002405 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002407 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002408 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002409 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002410 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002411 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002412 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002413 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002414 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002415 io_delegate_.SetFileContents("p/IFoo.aidl",
2416 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002417 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002418 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002419
2420 io_delegate_.SetFileContents("p/IFoo.aidl",
2421 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002422 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002423
2424 io_delegate_.SetFileContents("p/IFoo.aidl",
2425 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002426 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002427
Steven Moreland4e059132021-08-11 13:36:30 -07002428 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002429}
2430
Jeongik Cha0e426012019-07-29 15:57:02 +09002431TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2432 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002433 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2434 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002435 for (const auto& rawOption : rawOptions) {
2436 string expected_stderr =
2437 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002438 Options options = Options::From(rawOption);
2439 io_delegate_.SetFileContents(options.InputFiles().front(),
2440 "package foo.bar;\n"
2441 "interface IFoo1 { int foo(); }\n"
2442 "interface IFoo2 { int foo(); }\n"
2443 "parcelable Data1 { int a; int b;}\n"
2444 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002445 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002446 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002447 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002448
Jeongik Cha0e426012019-07-29 15:57:02 +09002449 io_delegate_.SetFileContents(options.InputFiles().front(),
2450 "package foo.bar;\n"
2451 "interface IFoo1 { int foo(); }\n"
2452 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002454 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002456
Devin Moore5de18ed2020-04-02 13:52:29 -07002457 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002458 io_delegate_.SetFileContents(options.InputFiles().front(),
2459 "package foo.bar;\n"
2460 "parcelable Data1 { int a; int b;}\n"
2461 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002462 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002463 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002464 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002465 }
2466}
2467
Devin Moorebdba2a82020-03-31 15:19:02 -07002468TEST_P(AidlTest, FailParseOnEmptyFile) {
2469 const string contents = "";
2470 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2471 CaptureStderr();
2472 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2473 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2474}
2475
Jiyong Parkb034bf02018-07-30 17:44:33 +09002476TEST_F(AidlTest, MultipleInputFiles) {
2477 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002478 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002479
2480 io_delegate_.SetFileContents(options.InputFiles().at(0),
2481 "package foo.bar;\n"
2482 "import foo.bar.Data;\n"
2483 "interface IFoo { Data getData(); }\n");
2484
2485 io_delegate_.SetFileContents(options.InputFiles().at(1),
2486 "package foo.bar;\n"
2487 "import foo.bar.IFoo;\n"
2488 "parcelable Data { IFoo foo; }\n");
2489
Steven Moreland4e059132021-08-11 13:36:30 -07002490 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002491
2492 string content;
2493 for (const auto file : {
2494 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2495 content.clear();
2496 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2497 EXPECT_FALSE(content.empty());
2498 }
2499}
2500
2501TEST_F(AidlTest, MultipleInputFilesCpp) {
2502 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002503 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002504
2505 io_delegate_.SetFileContents(options.InputFiles().at(0),
2506 "package foo.bar;\n"
2507 "import foo.bar.Data;\n"
2508 "interface IFoo { Data getData(); }\n");
2509
2510 io_delegate_.SetFileContents(options.InputFiles().at(1),
2511 "package foo.bar;\n"
2512 "import foo.bar.IFoo;\n"
2513 "parcelable Data { IFoo foo; }\n");
2514
Steven Moreland4e059132021-08-11 13:36:30 -07002515 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002516
2517 string content;
2518 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002519 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002520 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2521 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2522 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2523 content.clear();
2524 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2525 EXPECT_FALSE(content.empty());
2526 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002527}
2528
Andrei Homescub62afd92020-05-11 19:24:59 -07002529TEST_F(AidlTest, MultipleInputFilesRust) {
2530 Options options =
2531 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2532
2533 io_delegate_.SetFileContents(options.InputFiles().at(0),
2534 "package foo.bar;\n"
2535 "import foo.bar.Data;\n"
2536 "interface IFoo { Data getData(); }\n");
2537
2538 io_delegate_.SetFileContents(options.InputFiles().at(1),
2539 "package foo.bar;\n"
2540 "import foo.bar.IFoo;\n"
2541 "parcelable Data { IFoo foo; }\n");
2542
Steven Moreland4e059132021-08-11 13:36:30 -07002543 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002544
2545 string content;
2546 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2547 content.clear();
2548 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2549 EXPECT_FALSE(content.empty());
2550 }
2551}
2552
Devin Moore097a3ab2020-03-11 16:08:44 -07002553TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2554 const string expected_stderr =
2555 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002556 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2557 // int getInterfaceVersion() is one of the meta transactions
2558 io_delegate_.SetFileContents(options.InputFiles().front(),
2559 "package p; interface IFoo {"
2560 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002562 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002563 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2564}
Jiyong Park309668e2018-07-28 16:55:44 +09002565
Devin Moore097a3ab2020-03-11 16:08:44 -07002566TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2567 // boolean getInterfaceVersion() is not a meta transaction, but should be
2568 // prevented because return type is not part of a method signature
2569 const string expected_stderr =
2570 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2571 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002572 io_delegate_.SetFileContents(options.InputFiles().front(),
2573 "package p; interface IFoo {"
2574 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002575 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002576 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2578}
Jiyong Park309668e2018-07-28 16:55:44 +09002579
Devin Moore097a3ab2020-03-11 16:08:44 -07002580TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002581 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002582 const string expected_stderr =
2583 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2584 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002585 io_delegate_.SetFileContents(options.InputFiles().front(),
2586 "package p; interface IFoo {"
2587 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002588 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002589 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002591
2592 // this is not a meta interface method as it differs type arguments
2593 io_delegate_.SetFileContents(options.InputFiles().front(),
2594 "package p; interface IFoo {"
2595 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002596 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002597}
2598
Jooyung Hanb8a97772021-01-19 01:27:38 +09002599TEST_F(AidlTest, CheckApiForEquality) {
2600 CaptureStderr();
2601 Options options = Options::From("aidl --checkapi=equal old new");
2602
2603 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2604 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2605 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2606 "package p; interface IFoo{ @utf8InCpp String foo();}");
2607
2608 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2609 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2610}
2611
Daniel Norman85aed542019-08-21 12:01:14 -07002612TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002613 Options options = Options::From("aidl --checkapi old new");
2614 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2615 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2616 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2617 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2618
2619 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2620}
2621
Jiyong Park3656c3c2018-08-01 20:02:01 +09002622TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002623 Options options = Options::From("aidl --checkapi old new");
2624 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2625 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002626
2627 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2628}
2629
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002630TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2631 Options options = Options::From("aidl --checkapi old new");
2632 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2633 const string enum_definition = "package p; enum Enum { FOO }";
2634 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2635 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2636 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2637 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2638
2639 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2640}
2641
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002642TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2643 Options options = Options::From("aidl --checkapi old new -I import");
2644
2645 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2646 io_delegate_.SetFileContents("new/p/Foo.aidl",
2647 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2648 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2649
2650 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2651}
2652
Jooyung Han02a11be2021-02-11 13:18:06 +09002653TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2654 Options options = Options::From("aidl --checkapi=equal old new");
2655 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2656 const string enum_definition = "package p; enum Enum { FOO }";
2657 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2658 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2659 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2660 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2661 CaptureStderr();
2662 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2663 EXPECT_EQ("", GetCapturedStderr());
2664}
2665
Daniel Norman85aed542019-08-21 12:01:14 -07002666class AidlTestCompatibleChanges : public AidlTest {
2667 protected:
2668 Options options_ = Options::From("aidl --checkapi old new");
2669};
2670
2671TEST_F(AidlTestCompatibleChanges, NewType) {
2672 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2673 "package p;"
2674 "interface IFoo {"
2675 " void foo(int a);"
2676 "}");
2677 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2678 "package p;"
2679 "interface IFoo {"
2680 " void foo(int a);"
2681 "}");
2682 io_delegate_.SetFileContents("new/p/IBar.aidl",
2683 "package p;"
2684 "interface IBar {"
2685 " void bar();"
2686 "}");
2687 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2688}
2689
2690TEST_F(AidlTestCompatibleChanges, NewMethod) {
2691 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2692 "package p;"
2693 "interface IFoo {"
2694 " void foo(int a);"
2695 "}");
2696 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2697 "package p;"
2698 "interface IFoo {"
2699 " void foo(int a);"
2700 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002701 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002702 "}");
2703 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2704}
2705
2706TEST_F(AidlTestCompatibleChanges, NewField) {
2707 io_delegate_.SetFileContents("old/p/Data.aidl",
2708 "package p;"
2709 "parcelable Data {"
2710 " int foo;"
2711 "}");
2712 io_delegate_.SetFileContents("new/p/Data.aidl",
2713 "package p;"
2714 "parcelable Data {"
2715 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002716 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002717 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002718 "}");
2719 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2720}
2721
Jooyung Han05bd8a82021-04-28 23:56:38 +09002722TEST_F(AidlTestCompatibleChanges, NewField2) {
2723 io_delegate_.SetFileContents("old/p/Data.aidl",
2724 "package p;"
2725 "parcelable Data {"
2726 "}");
2727 io_delegate_.SetFileContents("new/p/Data.aidl",
2728 "package p;"
2729 "parcelable Data {"
2730 " int foo = 0;"
2731 "}");
2732 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2733}
2734
Daniel Norman85aed542019-08-21 12:01:14 -07002735TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2736 io_delegate_.SetFileContents("old/p/Enum.aidl",
2737 "package p;"
2738 "enum Enum {"
2739 " FOO = 1,"
2740 "}");
2741 io_delegate_.SetFileContents("new/p/Enum.aidl",
2742 "package p;"
2743 "enum Enum {"
2744 " FOO = 1,"
2745 " BAR = 2,"
2746 "}");
2747 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2748}
2749
2750TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2751 io_delegate_.SetFileContents("old/p/Enum.aidl",
2752 "package p;"
2753 "enum Enum {"
2754 " FOO = 1,"
2755 " BAR = 2,"
2756 "}");
2757 io_delegate_.SetFileContents("new/p/Enum.aidl",
2758 "package p;"
2759 "enum Enum {"
2760 " BAR = 2,"
2761 " FOO = 1,"
2762 "}");
2763 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2764}
2765
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002766TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2767 io_delegate_.SetFileContents("old/p/Union.aidl",
2768 "package p;"
2769 "union Union {"
2770 " String foo;"
2771 "}");
2772 io_delegate_.SetFileContents("new/p/Union.aidl",
2773 "package p;"
2774 "union Union {"
2775 " String foo;"
2776 " int num;"
2777 "}");
2778 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2779}
2780
Daniel Norman85aed542019-08-21 12:01:14 -07002781TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002782 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2783 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002784 "interface IFoo {"
2785 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002786 "}");
2787 io_delegate_.SetFileContents("old/p/Data.aidl",
2788 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002789 "parcelable Data {"
2790 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002791 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002792 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2793 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002794 "interface IFoo {"
2795 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002796 "}");
2797 io_delegate_.SetFileContents("new/p/Data.aidl",
2798 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002799 "parcelable Data {"
2800 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002801 "}");
2802 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2803 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002804 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002805 " void foo(int a);"
2806 "}");
2807 io_delegate_.SetFileContents("new/q/Data.aidl",
2808 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002809 "parcelable Data {"
2810 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002811 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002812 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2813}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002814
Daniel Norman85aed542019-08-21 12:01:14 -07002815TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2816 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2817 "package p;"
2818 "interface IFoo {"
2819 " void foo(int a);"
2820 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002821 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2822 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002823 "interface IFoo {"
2824 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002825 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002826 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2827}
Jiyong Parke59c3682018-09-11 23:10:25 +09002828
Daniel Norman85aed542019-08-21 12:01:14 -07002829TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002830 io_delegate_.SetFileContents("old/p/I.aidl",
2831 "package p; interface I {"
2832 "const int A = 1; }");
2833 io_delegate_.SetFileContents("new/p/I.aidl",
2834 "package p ; interface I {"
2835 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002836 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2837}
Jiyong Parka428d212018-08-29 22:26:30 +09002838
Daniel Norman85aed542019-08-21 12:01:14 -07002839TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002840 io_delegate_.SetFileContents("old/p/I.aidl",
2841 "package p; interface I {"
2842 "const int A = 1; const int B = 2;}");
2843 io_delegate_.SetFileContents("new/p/I.aidl",
2844 "package p ; interface I {"
2845 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002846 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002847}
2848
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002849TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2850 io_delegate_.SetFileContents("old/p/Foo.aidl",
2851 "package p;"
2852 "@JavaPassthrough(annotation=\"Alice\")"
2853 "@JavaPassthrough(annotation=\"Bob\")"
2854 "parcelable Foo {}");
2855 io_delegate_.SetFileContents("new/p/Foo.aidl",
2856 "package p;"
2857 "@JavaPassthrough(annotation=\"Bob\")"
2858 "@JavaPassthrough(annotation=\"Alice\")"
2859 "parcelable Foo {}");
2860 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2861}
2862
Jooyung Han00073272020-11-27 14:20:20 +09002863TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2864 io_delegate_.SetFileContents("old/p/Foo.aidl",
2865 "package p;"
2866 "parcelable Foo {}");
2867 io_delegate_.SetFileContents("new/p/Foo.aidl",
2868 "package p;"
2869 "@JavaPassthrough(annotation=\"@Deprecated\")"
2870 "parcelable Foo {}");
2871 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2872}
2873
Jooyung Han636fd2f2020-10-22 11:33:45 +09002874TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2875 io_delegate_.SetFileContents("old/p/Data.aidl",
2876 "package p;"
2877 "parcelable Data {"
2878 " int num;"
2879 "}");
2880 io_delegate_.SetFileContents(
2881 "new/p/Data.aidl",
2882 "package p;"
2883 "parcelable Data {"
2884 " int num;"
2885 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2886 "}");
2887 io_delegate_.SetFileContents("new/p/Enum.aidl",
2888 "package p;"
2889 "enum Enum {"
2890 " FOO = 0,"
2891 " BAR = 1,"
2892 "}");
2893 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2894}
2895
Jooyung Han308bbe02021-04-27 12:09:59 +09002896TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2897 io_delegate_.SetFileContents("old/p/Data.aidl",
2898 "package p;\n"
2899 "parcelable Data {\n"
2900 " p.Enum e;\n"
2901 "}");
2902 io_delegate_.SetFileContents("old/p/Enum.aidl",
2903 "package p;\n"
2904 "enum Enum {\n"
2905 " FOO = 0,\n"
2906 " BAR = 1,\n"
2907 "}");
2908 io_delegate_.SetFileContents("new/p/Data.aidl",
2909 "package p;\n"
2910 "parcelable Data {\n"
2911 " p.Enum e = p.Enum.FOO;\n"
2912 "}");
2913 io_delegate_.SetFileContents("new/p/Enum.aidl",
2914 "package p;\n"
2915 "enum Enum {\n"
2916 " FOO = 0,\n"
2917 " BAR = 1,\n"
2918 "}");
2919 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2920}
2921
Daniel Norman85aed542019-08-21 12:01:14 -07002922class AidlTestIncompatibleChanges : public AidlTest {
2923 protected:
2924 Options options_ = Options::From("aidl --checkapi old new");
2925};
2926
2927TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002928 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002929 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2930 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002931 "interface IFoo {"
2932 " void foo(in String[] str);"
2933 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002934 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002935 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002936 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002937 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002938}
2939
2940TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002941 const string expected_stderr =
2942 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002943 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2944 "package p;"
2945 "interface IFoo {"
2946 " void foo(in String[] str);"
2947 " void bar(@utf8InCpp String str);"
2948 "}");
2949 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2950 "package p;"
2951 "interface IFoo {"
2952 " void foo(in String[] str);"
2953 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002954 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002955 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002956 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002957}
2958
Jiyong Parkf8d53612020-05-04 14:06:13 +09002959TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2960 const string expected_stderr =
2961 "ERROR: new/p/IFoo.aidl:1.61-65: "
2962 "Encountered an untyped List or Map. The use of untyped List/Map is "
2963 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2964 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2965 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2966 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2967 "package p;"
2968 "interface IFoo {"
2969 " void foo(in String[] str);"
2970 "}");
2971 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2972 "package p;"
2973 "interface IFoo {"
2974 " void foo(in String[] str);"
2975 " void bar(in List arg);"
2976 "}");
2977 CaptureStderr();
2978 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2979 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2980}
2981
2982TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2983 const string expected_stderr =
2984 "ERROR: new/p/Data.aidl:1.54-59: "
2985 "Encountered an untyped List or Map. The use of untyped List/Map is "
2986 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2987 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2988 "ERROR: new/p/Data.aidl: Failed to read.\n";
2989 io_delegate_.SetFileContents("old/p/Data.aidl",
2990 "package p;"
2991 "parcelable Data {"
2992 " int foo;"
2993 "}");
2994 io_delegate_.SetFileContents("new/p/Data.aidl",
2995 "package p;"
2996 "parcelable Data {"
2997 " int foo;"
2998 " @nullable List list;"
2999 "}");
3000 CaptureStderr();
3001 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3003}
3004
Daniel Norman85aed542019-08-21 12:01:14 -07003005TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003006 const string expected_stderr =
3007 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003008 io_delegate_.SetFileContents("old/p/Data.aidl",
3009 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003010 "parcelable Data {"
3011 " int foo;"
3012 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003013 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003014 io_delegate_.SetFileContents("new/p/Data.aidl",
3015 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003016 "parcelable Data {"
3017 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003018 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003019 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003020 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003022}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003023
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003024TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
3025 const string expected_stderr =
3026 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
3027 "backends. Please either provide a default value for this field or mark the field as "
3028 "@nullable. This value or a null value will be used automatically when an old version of "
3029 "this parcelable is sent to a process which understands a new version of this parcelable. In "
3030 "order to make sure your code continues to be backwards compatible, make sure the default or "
3031 "null value does not cause a semantic change to this parcelable.\n";
3032 io_delegate_.SetFileContents("old/p/Data.aidl",
3033 "package p;"
3034 "parcelable Data {"
3035 " int num;"
3036 "}");
3037 io_delegate_.SetFileContents("new/p/Data.aidl",
3038 "package p;"
3039 "parcelable Data {"
3040 " int num;"
3041 " String str;"
3042 "}");
3043 CaptureStderr();
3044 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3045 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3046}
3047
Jooyung Han636fd2f2020-10-22 11:33:45 +09003048TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
3049 const string expected_stderr =
3050 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
3051 "Please make sure 'Enum' has '0' as a valid value.\n";
3052 io_delegate_.SetFileContents("old/p/Data.aidl",
3053 "package p;"
3054 "parcelable Data {"
3055 " int num;"
3056 "}");
3057 io_delegate_.SetFileContents("new/p/Data.aidl",
3058 "package p;"
3059 "parcelable Data {"
3060 " int num;"
3061 " p.Enum e;"
3062 "}");
3063 io_delegate_.SetFileContents("new/p/Enum.aidl",
3064 "package p;"
3065 "enum Enum {"
3066 " FOO = 1,"
3067 " BAR = 2,"
3068 "}");
3069 CaptureStderr();
3070 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3071 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3072}
3073
Daniel Norman85aed542019-08-21 12:01:14 -07003074TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003075 const string expected_stderr =
3076 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003077 io_delegate_.SetFileContents("old/p/Enum.aidl",
3078 "package p;"
3079 "enum Enum {"
3080 " FOO = 1,"
3081 " BAR = 2,"
3082 "}");
3083 io_delegate_.SetFileContents("new/p/Enum.aidl",
3084 "package p;"
3085 "enum Enum {"
3086 " BAR = 2,"
3087 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003088 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003089 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003090 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003091}
3092
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003093TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3094 const string expected_stderr =
3095 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3096 io_delegate_.SetFileContents("old/p/Union.aidl",
3097 "package p;"
3098 "union Union {"
3099 " String str;"
3100 " int num;"
3101 "}");
3102 io_delegate_.SetFileContents("new/p/Union.aidl",
3103 "package p;"
3104 "union Union {"
3105 " String str;"
3106 "}");
3107 CaptureStderr();
3108 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3109 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3110}
3111
Daniel Norman85aed542019-08-21 12:01:14 -07003112TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003113 const string expected_stderr =
3114 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003115 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3116 "package p;"
3117 "interface IFoo {"
3118 " void foo(in String[] str);"
3119 " void bar(@utf8InCpp String str);"
3120 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003121 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3122 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003123 "interface IFoo {"
3124 " void foo(in String[] str);"
3125 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003126 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003127 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003128 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003129 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003130}
3131
Daniel Norman85aed542019-08-21 12:01:14 -07003132TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003133 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003134 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3135 "package p;"
3136 "interface IFoo {"
3137 " void foo(in String[] str);"
3138 " void bar(@utf8InCpp String str);"
3139 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003140 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3141 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003142 "interface IFoo2 {"
3143 " void foo(in String[] str);"
3144 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003145 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003146 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003147 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003148 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003149}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003150
Daniel Norman85aed542019-08-21 12:01:14 -07003151TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003152 const string expected_stderr =
3153 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003154 io_delegate_.SetFileContents("old/p/Enum.aidl",
3155 "package p;"
3156 "enum Enum {"
3157 " FOO = 1,"
3158 " BAR = 2,"
3159 "}");
3160 io_delegate_.SetFileContents("new/p/Enum.aidl",
3161 "package p;"
3162 "enum Enum {"
3163 " FOO = 3,"
3164 " BAR = 2,"
3165 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003166 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003167 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003168 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003169}
3170
3171TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003172 const string expected_stderr =
3173 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3174 "from 0 to 1.\n"
3175 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3176 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003177 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3178 "package p;"
3179 "interface IFoo {"
3180 " void foo(in String[] str);"
3181 " void bar(@utf8InCpp String str);"
3182 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003183 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3184 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003185 "interface IFoo {"
3186 " void bar(@utf8InCpp String str);"
3187 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003188 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003189 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003190 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003191 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003192}
3193
3194TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003195 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003196 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3197 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003198 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003199 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003200 "parcelable Data {"
3201 " int foo;"
3202 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003203 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003204 io_delegate_.SetFileContents("new/p/Data.aidl",
3205 "package p;"
3206 "parcelable Data {"
3207 " int bar;"
3208 " int foo;"
3209 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003210 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003211 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003212 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003213}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003214
Daniel Norman85aed542019-08-21 12:01:14 -07003215TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003216 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003217 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003218 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003219 "interface IFoo {"
3220 " void foo(in String[] str);"
3221 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003222 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003223 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3224 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003225 "interface IFoo {"
3226 " void foo(out String[] str);"
3227 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003228 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003229 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003230 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003232}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003233
Daniel Norman85aed542019-08-21 12:01:14 -07003234TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003235 const string expected_stderr =
3236 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003237 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3238 "package p;"
3239 "interface IFoo {"
3240 " void foo(in String[] str);"
3241 " void bar(@utf8InCpp String str);"
3242 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003243 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3244 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003245 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003246 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003247 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003248 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003249 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003250 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003252}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003253
Daniel Norman85aed542019-08-21 12:01:14 -07003254TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003255 const string expected_stderr =
3256 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003257 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3258 "package p;"
3259 "interface IFoo {"
3260 " void foo(in String[] str);"
3261 " void bar(@utf8InCpp String str);"
3262 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003263 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3264 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003265 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003266 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003267 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003268 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003269 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003270 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003272}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003273
Jooyung Han60b2fde2020-10-29 15:12:40 +09003274TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3275 const string expected_stderr =
3276 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3277 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3278 io_delegate_.SetFileContents("old/p/Foo.aidl",
3279 "package p;"
3280 "@Backing(type=\"byte\")"
3281 "enum Foo {"
3282 " FOO, BAR,"
3283 "}");
3284 io_delegate_.SetFileContents("new/p/Foo.aidl",
3285 "package p;"
3286 "@Backing(type=\"long\")"
3287 "enum Foo {"
3288 " FOO, BAR,"
3289 "}");
3290 CaptureStderr();
3291 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3293}
3294
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003295TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3296 const string expected_stderr =
3297 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3298 "to @JavaPassthrough(annotation=\"Bob\")\n";
3299 io_delegate_.SetFileContents("old/p/Foo.aidl",
3300 "package p;"
3301 "@JavaPassthrough(annotation=\"Alice\")"
3302 "parcelable Foo {}");
3303 io_delegate_.SetFileContents("new/p/Foo.aidl",
3304 "package p;"
3305 "@JavaPassthrough(annotation=\"Bob\")"
3306 "parcelable Foo {}");
3307
3308 CaptureStderr();
3309 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3310 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3311}
3312
Devin Mooredb7ac512020-08-07 11:17:36 -07003313TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3314 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003315 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003316 io_delegate_.SetFileContents("old/p/Foo.aidl",
3317 "package p;"
3318 "parcelable Foo {"
3319 " int A;"
3320 "}");
3321 io_delegate_.SetFileContents("new/p/Foo.aidl",
3322 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003323 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003324 " int A;"
3325 "}");
3326 CaptureStderr();
3327 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3328 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3329}
3330
3331TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3332 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003333 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003334 io_delegate_.SetFileContents("old/p/Foo.aidl",
3335 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003336 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003337 " int A;"
3338 "}");
3339 io_delegate_.SetFileContents("new/p/Foo.aidl",
3340 "package p;"
3341 "parcelable Foo {"
3342 " int A;"
3343 "}");
3344 CaptureStderr();
3345 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3347}
3348
Daniel Norman85aed542019-08-21 12:01:14 -07003349TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003350 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003351 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3352 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003353 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003354 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003355 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003357}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003358
Daniel Norman85aed542019-08-21 12:01:14 -07003359TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003360 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003361 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3362 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003363 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003364 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003366}
Jiyong Parka428d212018-08-29 22:26:30 +09003367
Daniel Norman85aed542019-08-21 12:01:14 -07003368TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003369 const string expected_stderr =
3370 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003371 io_delegate_.SetFileContents("old/p/I.aidl",
3372 "package p; interface I {"
3373 "const int A = 1; const int B = 2;}");
3374 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003375 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003376 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003378}
Jiyong Parka428d212018-08-29 22:26:30 +09003379
Daniel Norman85aed542019-08-21 12:01:14 -07003380TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003381 const string expected_stderr =
3382 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003383 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3384 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003385 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003386 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003388}
3389
Devin Moorec7e47a32020-08-07 10:55:25 -07003390TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3391 const string expected_stderr =
3392 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3393 "This is an incompatible change for FixedSize types.\n";
3394 io_delegate_.SetFileContents("old/p/Foo.aidl",
3395 "package p; @FixedSize parcelable Foo { int A = 1; }");
3396 io_delegate_.SetFileContents("new/p/Foo.aidl",
3397 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3398 CaptureStderr();
3399 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3401}
3402
Jeongik Cha68d18e72021-04-29 20:07:01 +09003403TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3404 const string expected_stderr =
3405 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3406 "android.net.UidRangeParcel is changed from 1 to 2. "
3407 "But it is forbidden because of legacy support.\n";
3408 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3409 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3410 io_delegate_.SetFileContents(
3411 "new/android/net/UidRangeParcel.aidl",
3412 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3413 CaptureStderr();
3414 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3415 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3416}
3417
Devin Moorec7e47a32020-08-07 10:55:25 -07003418TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3419 const string expected_stderr =
3420 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3421 io_delegate_.SetFileContents("old/p/Foo.aidl",
3422 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3423 io_delegate_.SetFileContents("new/p/Foo.aidl",
3424 "package p; @FixedSize parcelable Foo { int A = 1; }");
3425 CaptureStderr();
3426 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3428}
3429
3430TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3431 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003432 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003433 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003434 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3435 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003436 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003437 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003438 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003439 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003440 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003441 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3442 "f.\n"
3443 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3444 "nullable1.\n"
3445 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3446 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003447
3448 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003449 "@FixedSize parcelable Foo {\n"
3450 " int[] a;\n"
3451 " Bar b;\n"
3452 " String c;\n"
3453 " ParcelFileDescriptor d;\n"
3454 " IBinder e;\n"
3455 " List<String> f;\n"
3456 " int isFixedSize;\n"
3457 " @nullable OtherFixed nullable1;\n"
3458 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003459 "}");
3460 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003461 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003462 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003463
3464 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003465 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3467}
3468
3469TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3470 const string expected_stderr = "";
3471
3472 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3473 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3474 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003475 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003476
3477 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003478 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003479 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3480}
3481
Jiyong Park8c380532018-08-30 14:55:26 +09003482TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003483 const string expected_stderr =
3484 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3485 "dir1/q/IBar.aidl\n"
3486 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003487 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003488 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3489 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3490 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3491 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3492
Devin Moore097a3ab2020-03-11 16:08:44 -07003493 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003494 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003495 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003496}
3497
Jiyong Parked65bf42018-08-28 15:43:27 +09003498TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003499 const string expected_stderr =
3500 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3501 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003502 Options options = Options::From("aidl --checkapi old new");
3503 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3504 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003505
3506 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3507
Jiyong Parke59c3682018-09-11 23:10:25 +09003508 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003509 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003510 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003512}
3513
Jooyung Han652ce482021-02-26 12:40:35 +09003514TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3515 Options options =
3516 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003517
3518 // use without import
3519 io_delegate_.SetFileContents("p/IFoo.aidl",
3520 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003521 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003522
3523 // capture output files
3524 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003525
Devin Moore7b8d5c92020-03-17 14:14:08 -07003526 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003527 io_delegate_.SetFileContents(
3528 "p/IFoo.aidl",
3529 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003530 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003531 // output files should be the same
3532 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003533
3534 // use with import (as before)
3535 io_delegate_.SetFileContents("p/IFoo.aidl",
3536 "package p;"
3537 "import android.os.ParcelFileDescriptor;"
3538 "interface IFoo{"
3539 " void foo(in ParcelFileDescriptor fd);"
3540 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003541 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003542 // output files should be the same
3543 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003544}
Jiyong Parked65bf42018-08-28 15:43:27 +09003545
Jooyung Han020d8d12021-02-26 17:23:02 +09003546TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3547 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3548 CaptureStderr();
3549 io_delegate_.SetFileContents("p/IFoo.aidl",
3550 "package p;"
3551 "interface IFoo{"
3552 " void foo(out ParcelFileDescriptor fd);"
3553 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003554 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003555 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3556}
3557
3558TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3559 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3560 CaptureStderr();
3561 io_delegate_.SetFileContents("p/IFoo.aidl",
3562 "package p;"
3563 "interface IFoo{"
3564 " void foo(ParcelFileDescriptor fd);"
3565 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003566 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003567 EXPECT_THAT(GetCapturedStderr(),
3568 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3569}
3570
Jiyong Park3633b722019-04-11 15:38:26 +09003571TEST_F(AidlTest, ManualIds) {
3572 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3573 io_delegate_.SetFileContents("IFoo.aidl",
3574 "interface IFoo {\n"
3575 " void foo() = 0;\n"
3576 " void bar() = 1;\n"
3577 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003578 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003579}
3580
3581TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3582 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3583 io_delegate_.SetFileContents("IFoo.aidl",
3584 "interface IFoo {\n"
3585 " void foo() = 0;\n"
3586 " void bar() = 1;\n"
3587 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003588 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003589}
3590
3591TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003592 const string expected_stderr =
3593 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003594 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3595 io_delegate_.SetFileContents("IFoo.aidl",
3596 "interface IFoo {\n"
3597 " void foo() = 3;\n"
3598 " void bar() = 3;\n"
3599 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003600 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003601 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003602 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003603}
3604
3605TEST_F(AidlTest, FailOnOutOfRangeIds) {
3606 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003607 const string expected_stderr =
3608 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3609 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003610 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3611 io_delegate_.SetFileContents("IFoo.aidl",
3612 "interface IFoo {\n"
3613 " void foo() = 3;\n"
3614 " void bar() = 16777115;\n"
3615 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003617 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003618 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003619}
3620
3621TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003622 const string expected_stderr =
3623 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003624 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3625 io_delegate_.SetFileContents("IFoo.aidl",
3626 "interface IFoo {\n"
3627 " void foo() = 3;\n"
3628 " void bar();\n"
3629 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003630 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003631 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003632 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003633}
3634
Jiyong Parkc6816252019-07-08 08:12:28 +09003635TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3636 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3637 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3638 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003639 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003640}
3641
3642TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003643 const string expected_stderr =
3644 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3645 "dir/IBar.aidl\n"
3646 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003647 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003648
Jiyong Parkc6816252019-07-08 08:12:28 +09003649 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3650 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3651 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3652 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003653 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003654 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003655 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003656}
3657
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003658TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3659 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3660 "package a.b;\n"
3661 "import a.b.IBar;\n"
3662 "import a.b.IQux;\n"
3663 "interface IFoo { IQux foo(); }\n");
3664 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3665 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3666
3667 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003668 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003669
3670 string output;
3671 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3672 // IBar was imported but wasn't used. include is not expected.
3673 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3674 // IBar was imported and used. include is expected.
3675 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3676}
3677
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003678TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003679 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003680 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003681 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3682 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003683 interface IFoo {
3684 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003685 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003686 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003687 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003688 // JavaPassthrough should work with other types as well (e.g. enum)
3689 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3690 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3691 @JavaPassthrough(annotation="@com.android.AliceTwo")
3692 @Backing(type="byte")
3693 enum MyEnum {
3694 a, b, c
3695 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003696
Jooyung Han4cde01d2020-10-13 11:10:47 +09003697 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003698 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003699
3700 string java_out;
3701 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003702 // type-decl-level annotations with newline at the end
3703 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3704 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3705 // member-decl-level annotations with newline at the end
3706 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3707 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3708 // inline annotations with space at the end
3709 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003710
Jooyung Han4cde01d2020-10-13 11:10:47 +09003711 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3712 // type-decl-level annotations with newline at the end
3713 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3714 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3715
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003716 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003717 Options cpp_options =
3718 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003719 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003720
Jooyung Han4cde01d2020-10-13 11:10:47 +09003721 Options ndk_options =
3722 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003723 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003724
Jooyung Han4cde01d2020-10-13 11:10:47 +09003725 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003726 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003727}
3728
Andrei Homescue61feb52020-08-18 15:44:24 -07003729TEST_F(AidlTest, ParseRustDerive) {
3730 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3731 @RustDerive(Clone=true, Copy=false)
3732 parcelable Foo {
3733 int a;
3734 })");
3735
3736 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003737 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003738
3739 string rust_out;
3740 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3741 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3742
3743 // Other backends shouldn't be bothered
3744 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003745 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003746
3747 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003748 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003749
3750 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003751 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003752}
3753
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003754TEST_F(AidlTest, EmptyEnforceAnnotation) {
3755 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3756 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3757 interface IFoo {
3758 @Enforce()
3759 void Protected();
3760 })");
3761
3762 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3763 CaptureStderr();
3764 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3765 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3766}
3767
3768TEST_F(AidlTest, EmptyEnforceCondition) {
3769 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3770 interface IFoo {
3771 @Enforce(condition="")
3772 void Protected();
3773 })");
3774
3775 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3776 CaptureStderr();
3777 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3778 EXPECT_THAT(GetCapturedStderr(),
3779 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3780}
3781
3782TEST_F(AidlTest, InvalidEnforceCondition) {
3783 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3784 interface IFoo {
3785 @Enforce(condition="invalid")
3786 void Protected();
3787 })");
3788
3789 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3790 CaptureStderr();
3791 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3792 EXPECT_THAT(GetCapturedStderr(),
3793 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3794}
3795
Jiyong Park56f73d72019-06-11 12:20:28 +09003796class AidlOutputPathTest : public AidlTest {
3797 protected:
3798 void SetUp() override {
3799 AidlTest::SetUp();
3800 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3801 }
3802
3803 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003804 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003805 // check the existence
3806 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3807 }
3808};
3809
3810TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3811 // <out_dir> / <package_name> / <type_name>.java
3812 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3813}
3814
3815TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3816 // when output file is explicitly set, it is always respected. -o option is
3817 // ignored.
3818 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3819}
3820
3821TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3822 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3823}
3824
3825TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3826 // output is the same as the input file except for the suffix
3827 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3828}
3829
Devin Moore7b8d5c92020-03-17 14:14:08 -07003830TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003831 AidlError error;
3832 const string expected_stderr =
3833 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3834 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003835 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3836 R"(package p;
3837 interface IFoo {
3838 const int int32_max_oob = 2147483650;
3839 }
3840 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003841 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003842 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3843 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003844}
3845
Devin Moore7b8d5c92020-03-17 14:14:08 -07003846TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003847 AidlError error;
3848 const string expected_stderr =
3849 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3850 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003851 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3852 R"(package p;
3853 interface IFoo {
3854 const int int32_min_oob = -2147483650;
3855 }
3856 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003857 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003858 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3859 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003860}
3861
Devin Moore7b8d5c92020-03-17 14:14:08 -07003862TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003863 AidlError error;
3864 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003865 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003866 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003867 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3868 R"(package p;
3869 interface IFoo {
3870 const long int64_max_oob = 21474836509999999999999999;
3871 }
3872 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003873 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003874 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3875 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003876}
3877
Devin Moore7b8d5c92020-03-17 14:14:08 -07003878TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003879 AidlError error;
3880 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003881 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003882 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003883 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3884 R"(package p;
3885 interface IFoo {
3886 const long int64_min_oob = -21474836509999999999999999;
3887 }
3888 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003889 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003890 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3891 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003892}
3893
Devin Moore7b8d5c92020-03-17 14:14:08 -07003894TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003895 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003896 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003897 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003898 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3899 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003900 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3901 R"(package p;
3902 @Backing(type="byte")
3903 enum TestEnum {
3904 FOO = 127,
3905 BAR,
3906 }
3907 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003908 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003910 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003911}
3912
Steven Morelandb248d072021-09-29 19:07:17 -07003913TEST_P(AidlTest, FailOnUnsupportedBackingType) {
3914 AidlError error;
3915 const string expected_stderr =
3916 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
3917 "byte, int, long\n";
3918 CaptureStderr();
3919 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3920 R"(package p;
3921 @Backing(type="boolean")
3922 enum TestEnum {
3923 FOO = 0,
3924 BAR = 1,
3925 }
3926 )",
3927 typenames_, GetLanguage(), &error));
3928 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3929 EXPECT_EQ(AidlError::BAD_TYPE, error);
3930}
3931
Devin Mooredecaf292020-04-30 09:16:40 -07003932TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3933 AidlError error;
3934 const string expected_stderr =
3935 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003936 "be one of: type\n";
3937 CaptureStderr();
3938 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3939 R"(package p;
3940 @Backing(foo="byte")
3941 enum TestEnum {
3942 FOO = 1,
3943 BAR,
3944 }
3945 )",
3946 typenames_, GetLanguage(), &error));
3947 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3948 EXPECT_EQ(AidlError::BAD_TYPE, error);
3949}
3950
Jooyung Han5721a232020-12-24 04:34:55 +09003951TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3952 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3953 CaptureStderr();
3954 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3956}
3957
Jooyung Han66813932020-10-23 13:24:44 +09003958TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003959 io_delegate_.SetFileContents("Foo.aidl",
3960 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3961 "Map<String, Baz> d; Bar[] e; }");
3962 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3963 io_delegate_.SetFileContents("Baz.aidl",
3964 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003965 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003966 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003967}
3968
Jooyung Han66813932020-10-23 13:24:44 +09003969TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003970 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003971 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003972 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003973 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3974 "named 'bar'.\n";
3975 CaptureStderr();
3976 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003977 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003978 EXPECT_EQ(expected_error, GetCapturedStderr());
3979}
3980
Jooyung Han09e551c2021-05-11 11:44:48 +09003981TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3982 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3983 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3984 CaptureStderr();
3985 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003986 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003987 EXPECT_EQ("", GetCapturedStderr());
3988}
3989
Jooyung Han59af9cc2020-10-25 21:44:14 +09003990TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3991 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3992 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3993 string expected_error =
3994 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003995 "named 'bar'.\n";
3996 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003997 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003998 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003999 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004000}
4001
Jooyung Han66813932020-10-23 13:24:44 +09004002TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004003 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004004 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
4005 string expected_error =
4006 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
4007 "only be an in parameter.\n";
4008 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004009 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004010 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004011 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004012}
4013
Jooyung Han66813932020-10-23 13:24:44 +09004014TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004015 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004016 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
4017 string expected_error =
4018 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
4019 "only be an in parameter.\n";
4020 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004021 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004022 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004023 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004024}
4025
Jooyung Han66813932020-10-23 13:24:44 +09004026TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004027 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09004028 Options options = Options::From("aidl --lang=java Foo.aidl");
4029 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09004030 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
4031 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09004032 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004033 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09004034 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4035}
Devin Moore53fc99c2020-08-12 08:07:52 -07004036
Jooyung Hanfe086af2021-01-16 03:44:47 +09004037TEST_P(AidlTest, UnionInUnion) {
4038 import_paths_.insert(".");
4039 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
4040 CaptureStderr();
4041 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
4042 EXPECT_THAT("", GetCapturedStderr());
4043}
4044
Jooyung Hanfe89f122020-10-14 03:49:18 +09004045TEST_P(AidlTest, UnionRejectsEmptyDecl) {
4046 const string method = "package a; union Foo {}";
4047 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
4048 CaptureStderr();
4049 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4050 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4051}
4052
4053TEST_P(AidlTest, UnionRejectsParcelableHolder) {
4054 const string method = "package a; union Foo { ParcelableHolder x; }";
4055 const string expected_stderr =
4056 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
4057 CaptureStderr();
4058 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4059 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4060}
4061
Jooyung Han53fb4242020-12-17 16:03:49 +09004062TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
4063 import_paths_.insert(".");
4064 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
4065 const string expected_err = "The union's first member should have a useful default value.";
4066 CaptureStderr();
4067 EXPECT_EQ(nullptr,
4068 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
4069 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
4070}
4071
Devin Moore53fc99c2020-08-12 08:07:52 -07004072TEST_P(AidlTest, GenericStructuredParcelable) {
4073 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004074 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004075 const string expected_stderr = "";
4076 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004077 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004078 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4079}
4080
Jooyung Han3f347ca2020-12-01 12:41:50 +09004081TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4082 io_delegate_.SetFileContents("Foo.aidl",
4083 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4084 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004085 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004086 const string expected_stderr = "";
4087 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004088 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4090
4091 string code;
4092 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4093 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4094const ::android::String16& Foo<T,U>::s() {
4095 static const ::android::String16 value(::android::String16(""));
4096 return value;
4097})--"));
4098}
4099
4100TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4101 io_delegate_.SetFileContents("Foo.aidl",
4102 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4103 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004104 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004105 const string expected_stderr = "";
4106 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004107 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004108 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4109
4110 string code;
4111 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4112 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4113const char* Foo<T, U>::s = "";
4114)--"));
4115}
4116
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004117TEST_F(AidlTest, NestedTypeArgs) {
4118 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004119 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4120
4121 io_delegate_.SetFileContents("a/Foo.aidl",
4122 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4123 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004124 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4125 const string expected_stderr = "";
4126 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004127 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004128 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4129
4130 string code;
4131 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004132 EXPECT_THAT(code,
4133 testing::HasSubstr(
4134 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4135}
4136
4137TEST_F(AidlTest, DoubleArrayError) {
4138 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4139
4140 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4141 const string expected_stderr =
4142 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4143 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004144 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004145 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4146}
4147
4148TEST_F(AidlTest, DoubleGenericError) {
4149 io_delegate_.SetFileContents("a/Bar.aidl",
4150 "package a; parcelable Bar { List<String><String> a; }");
4151
4152 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4153 const string expected_stderr =
4154 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4155 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004156 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004157 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4158}
4159
4160TEST_F(AidlTest, ArrayBeforeGenericError) {
4161 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4162
4163 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004164 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004165 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004166 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4167}
4168
4169TEST_F(AidlTest, NullableArraysAreNotSupported) {
4170 io_delegate_.SetFileContents("a/Bar.aidl",
4171 "package a; parcelable Bar { String @nullable [] a; }");
4172
4173 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4174 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004175 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004176 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4177}
4178
4179TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4180 io_delegate_.SetFileContents("a/Bar.aidl",
4181 "package a; parcelable Bar { List<@nullable String> a; }");
4182
4183 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004185 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004186 EXPECT_THAT(GetCapturedStderr(),
4187 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004188}
4189
Jooyung Han14004ed2020-10-16 03:49:57 +09004190struct GenericAidlTest : ::testing::Test {
4191 FakeIoDelegate io_delegate_;
4192 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004193 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004194 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4195 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4196 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4197
4198 Options options = Options::From(cmd);
4199 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004200 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004201 EXPECT_EQ("", GetCapturedStderr());
4202 }
4203};
4204
4205TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4206 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4207 string code;
4208 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4209 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4210 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4211 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4212}
4213
4214TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4215 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4216 string code;
4217 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4218 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4219 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4220 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4221}
4222
Devin Moore53fc99c2020-08-12 08:07:52 -07004223TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4224 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004225 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004226 const string expected_stderr =
4227 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4228 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004229 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4231}
4232
4233TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4234 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004235 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004236 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4237 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004238 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4240}
4241
Jooyung Han7a308842020-10-27 19:06:49 +09004242TEST_P(AidlTest, LongCommentWithinConstExpression) {
4243 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004244 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004245 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004246 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004247 EXPECT_EQ("", GetCapturedStderr());
4248}
4249
Jeongik Chaef44e622020-10-23 16:00:52 +09004250TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4251 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4252 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4253 std::string expectedErr =
4254 "ERROR: a/Foo.aidl:1.28-30: "
4255 "Encountered an untyped List or Map. The use of untyped List/Map is "
4256 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4257 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4258 "ERROR: a/Foo.aidl:1.35-37: "
4259 "Encountered an untyped List or Map. The use of untyped List/Map is "
4260 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4261 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4262 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004263 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004264 EXPECT_EQ(expectedErr, GetCapturedStderr());
4265}
4266
4267TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4269 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004270 std::string expectedErr =
4271 "ERROR: a/Foo.aidl:1.33-35: "
4272 "Encountered an untyped List or Map. The use of untyped List/Map is "
4273 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4274 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4275 "ERROR: a/Foo.aidl:1.40-42: "
4276 "Encountered an untyped List or Map. The use of untyped List/Map is "
4277 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4278 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004279 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004280 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004281 EXPECT_EQ(expectedErr, GetCapturedStderr());
4282}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004283
Jeongik Chaef44e622020-10-23 16:00:52 +09004284TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4285 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4286 io_delegate_.SetFileContents(
4287 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4288 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4289 std::string expectedErr =
4290 "ERROR: a/Foo.aidl:1.52-54: "
4291 "Encountered an untyped List or Map. The use of untyped List/Map is "
4292 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4293 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4294 "ERROR: a/Foo.aidl:1.64-66: "
4295 "Encountered an untyped List or Map. The use of untyped List/Map is "
4296 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4297 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4298 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004299 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004300 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004301}
4302
Jooyung Han690f5842020-12-04 13:02:04 +09004303TEST_F(AidlTest, EnumWithDefaults_Java) {
4304 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4305 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4306package p;
4307import p.Enum;
4308parcelable Foo {
4309 Enum e = Enum.BAR;
4310})");
4311 CaptureStderr();
4312 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004313 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004314 auto err = GetCapturedStderr();
4315 EXPECT_EQ("", err);
4316
4317 string code;
4318 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004319 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004320}
4321
4322TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4323 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4324 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4325package p;
4326import p.Enum;
4327parcelable Foo {
4328 Enum e = Enum.BAR;
4329})");
4330 CaptureStderr();
4331 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004332 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004333 auto err = GetCapturedStderr();
4334 EXPECT_EQ("", err);
4335
4336 string code;
4337 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4338 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4339}
4340
4341TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4342 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4343 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4344package p;
4345import p.Enum;
4346parcelable Foo {
4347 Enum e = Enum.BAR;
4348})");
4349 CaptureStderr();
4350 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004351 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004352 auto err = GetCapturedStderr();
4353 EXPECT_EQ("", err);
4354
4355 string code;
4356 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4357 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4358}
4359
4360TEST_F(AidlTest, EnumWithDefaults_Rust) {
4361 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4362 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4363package p;
4364import p.Enum;
4365parcelable Foo {
4366 int n = 42;
4367 Enum e = Enum.BAR;
4368})");
4369 CaptureStderr();
4370 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004371 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004372 auto err = GetCapturedStderr();
4373 EXPECT_EQ("", err);
4374
4375 string code;
4376 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4377 EXPECT_THAT(code, testing::HasSubstr(R"(
4378 fn default() -> Self {
4379 Self {
4380 n: 42,
4381 e: crate::mangled::_1_p_4_Enum::BAR,
4382 }
4383 })"));
4384}
4385
4386TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4387 import_paths_.insert("a");
4388 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4389 CaptureStderr();
4390 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4391package p;
4392import p.Enum;
4393parcelable Foo {
4394 int e = Enum.FOO | Enum.BAR;
4395})",
4396 typenames_, GetLanguage());
4397 auto err = GetCapturedStderr();
4398 EXPECT_EQ("", err);
4399 EXPECT_TRUE(type);
4400 const auto& fields = type->AsStructuredParcelable()->GetFields();
4401 EXPECT_EQ("int e = 3", fields[0]->ToString());
4402}
4403
4404TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4405 CaptureStderr();
4406 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4407@Backing(type="int")
4408enum Foo {
4409 STANDARD_SHIFT = 16,
4410 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4411 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4412}
4413)",
4414 typenames_, GetLanguage());
4415 auto err = GetCapturedStderr();
4416 EXPECT_EQ("", err);
4417 EXPECT_TRUE(type);
4418 const auto& enum_type = type->AsEnumDeclaration();
4419 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004420 auto writer = CodeWriter::ForString(&code);
4421 DumpVisitor visitor(*writer);
4422 visitor.Visit(*enum_type);
4423 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004424 EXPECT_EQ(R"--(@Backing(type="int")
4425enum Foo {
4426 STANDARD_SHIFT = 16,
4427 STANDARD_BT709 = 65536,
4428 STANDARD_BT601_625 = 131072,
4429}
4430)--",
4431 code);
4432}
4433
4434TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4435 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4436 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4437package p;
4438import p.Enum;
4439parcelable Foo {
4440 Enum e = Enum.FOO | Enum.BAR;
4441})");
4442 CaptureStderr();
4443 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004444 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004445 auto err = GetCapturedStderr();
4446 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4447 err);
4448}
4449
Jooyung Han361cd102021-05-24 11:30:10 +09004450TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4451 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4452 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4453package p;
4454import p.Enum;
4455parcelable Foo {
4456 Enum e = 1;
4457})");
4458 CaptureStderr();
4459 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004460 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004461 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4462}
4463
Jooyung Han690f5842020-12-04 13:02:04 +09004464TEST_P(AidlTest, DefaultWithEmptyArray) {
4465 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4466 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4467 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004468 auto options =
4469 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004470 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004471 auto err = GetCapturedStderr();
4472 EXPECT_EQ("", err);
4473}
4474
4475TEST_P(AidlTest, RejectRefsInAnnotation) {
4476 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4477 "package p; interface IFoo {\n"
4478 " const String ANNOTATION = \"@Annotation\";\n"
4479 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4480 "}");
4481 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004482 auto options =
4483 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004484 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004485 auto err = GetCapturedStderr();
4486 EXPECT_EQ(
4487 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4488 "ANNOTATION.\n",
4489 err);
4490}
4491
4492TEST_F(AidlTest, DefaultWithEnumValues) {
4493 io_delegate_.SetFileContents(
4494 "a/p/Foo.aidl",
4495 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4496 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4497 CaptureStderr();
4498 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004499 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004500 auto err = GetCapturedStderr();
4501 EXPECT_EQ("", err);
4502 string code;
4503 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4504 EXPECT_THAT(
4505 code, testing::HasSubstr(
4506 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4507}
4508
Jooyung Han14259392020-12-07 10:00:08 +09004509TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4510 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4511 CaptureStderr();
4512 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004513 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004514 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004515 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004516}
4517
4518TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4519 io_delegate_.SetFileContents("a/p/Foo.aidl",
4520 "package p; parcelable Foo { const int A = A + 1; }");
4521 CaptureStderr();
4522 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004523 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004524 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004525 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4526}
4527
4528TEST_F(AidlTest, RecursiveReferences) {
4529 io_delegate_.SetFileContents("a/p/Foo.aidl",
4530 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4531 io_delegate_.SetFileContents("a/p/Bar.aidl",
4532 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4533 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4534 CaptureStderr();
4535 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004536 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004537 EXPECT_EQ("", GetCapturedStderr());
4538}
4539
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004540TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4541 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4542 auto options =
4543 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4544 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4545 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004546 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004547 EXPECT_EQ(err, GetCapturedStderr());
4548}
4549
4550TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4551 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4552 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4553 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4554 auto options =
4555 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4556 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004557 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004558 EXPECT_EQ("", GetCapturedStderr());
4559}
4560
Jooyung Hane9f5b272021-01-07 00:18:11 +09004561TEST_P(AidlTest, UnknownConstReference) {
Jooyung Hane1abd592021-10-05 10:35:02 +09004562 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { int field = UNKNOWN_REF; }");
Jooyung Hane9f5b272021-01-07 00:18:11 +09004563 auto options =
4564 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4565 const string err =
Jooyung Hane1abd592021-10-05 10:35:02 +09004566 "ERROR: Foo.aidl:1.30-42: Can't find UNKNOWN_REF in Foo\n"
4567 "ERROR: Foo.aidl:1.30-42: Unknown reference 'UNKNOWN_REF'\n";
Jooyung Hane9f5b272021-01-07 00:18:11 +09004568 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004569 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004570 EXPECT_EQ(err, GetCapturedStderr());
4571}
4572
Jooyung Han29813842020-12-08 01:28:03 +09004573TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4574 string contents = R"(
4575import android.os.IBinder;
4576import android.os.IInterface;
4577interface IFoo {}
4578 )";
4579 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004580}
4581
Jooyung Han888c5bc2020-12-22 17:28:47 +09004582TEST_P(AidlTest, WarningInterfaceName) {
4583 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004584 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004585 " -Weverything -o out -h out p/Foo.aidl");
4586 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004587 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004588 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004589 GetCapturedStderr());
4590}
4591
4592TEST_P(AidlTest, ErrorInterfaceName) {
4593 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004594 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004595 " -Weverything -Werror -o out -h out p/Foo.aidl");
4596 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004597 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004598 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004599 GetCapturedStderr());
4600}
4601
Jiyong Park9f4c3822021-04-07 20:36:45 +09004602TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4603 const std::string input_file = "base/p/q/IFoo.aidl";
4604 const std::string header_dir = "out/";
4605 const std::string output_file = "out/base/p/q/IFoo.cpp";
4606 const std::string package = "p.q"; // not base.p.q
4607 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4608
4609 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4610 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004611 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004612 EXPECT_THAT(
4613 GetCapturedStderr(),
4614 testing::StartsWith(
4615 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4616 "but is out/base/p/q/IFoo.cpp."));
4617}
4618
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004619TEST_F(AidlTest, FormatCommentsForJava) {
4620 using android::aidl::FormatCommentsForJava;
4621
4622 struct TestCase {
4623 vector<Comment> comments;
4624 string formatted;
4625 };
4626 vector<TestCase> testcases = {
4627 {{}, ""},
4628 {{{"// line comments\n"}}, "// line comments\n"},
4629 {{{"// @hide \n"}}, "// @hide \n"},
4630 // Transform the last block comment as Javadoc.
4631 {{{"/*\n"
4632 " * Hello, world!\n"
4633 " */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004634 "/** Hello, world! */\n"},
4635 {{{"/* @hide */"}}, "/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004636 {{{"/**\n"
4637 " @param foo ...\n"
4638 "*/"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004639 "/** @param foo ... */\n"},
4640 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide */\n/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004641 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004642 "/* @deprecated first */\n/** @deprecated second */\n"},
4643 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated */\n/** @param foo */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004644 // Line comments are printed as they are
Steven Morelandc29d7172021-10-12 15:25:11 -07004645 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */\n// line comments\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004646 };
4647 for (const auto& [input, formatted] : testcases) {
4648 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4649 }
4650}
4651
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004652TEST_F(AidlTest, HideIsNotForArgs) {
4653 io_delegate_.SetFileContents("IFoo.aidl",
4654 "interface IFoo {\n"
4655 " void foo(in @Hide int x);\n"
4656 "}");
4657 auto options = Options::From("aidl --lang=java IFoo.aidl");
4658 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004659 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004660 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4661}
4662
4663TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4664 io_delegate_.SetFileContents(
4665 "IFoo.aidl",
4666 "interface IFoo {\n"
4667 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4668 "}");
4669 auto options = Options::From("aidl --lang=java IFoo.aidl");
4670 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004671 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004672 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4673}
4674
Jooyung Hanfa181932021-06-12 07:56:53 +09004675TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4676 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4677 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4678 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004679 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004680 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4681}
4682
Jooyung Hanfd3be322020-12-13 09:11:06 +09004683struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004684 string kind;
4685 string literal;
4686};
4687
Jooyung Hanfd3be322020-12-13 09:11:06 +09004688const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004689 {"primitive", "int"}, {"primitiveArray", "int[]"},
4690 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004691 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4692 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4693 {"union", "a.Union"}, {"interface", "a.IBar"},
4694};
4695
4696const std::map<std::string, std::string> kListSupportExpectations = {
4697 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4698 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4699 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4700 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004701 {"cpp_primitiveArray", "List of arrays is not supported."},
4702 {"java_primitiveArray", "List of arrays is not supported."},
4703 {"ndk_primitiveArray", "List of arrays is not supported."},
4704 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004705 {"cpp_String", ""},
4706 {"java_String", ""},
4707 {"ndk_String", ""},
4708 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004709 {"cpp_StringArray", "List of arrays is not supported."},
4710 {"java_StringArray", "List of arrays is not supported."},
4711 {"ndk_StringArray", "List of arrays is not supported."},
4712 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004713 {"cpp_IBinder", ""},
4714 {"java_IBinder", ""},
4715 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4716 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004717 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004718 {"java_ParcelFileDescriptor", ""},
4719 {"ndk_ParcelFileDescriptor", ""},
4720 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004721 {"cpp_interface", "List<a.IBar> is not supported."},
4722 {"java_interface", "List<a.IBar> is not supported."},
4723 {"ndk_interface", "List<a.IBar> is not supported."},
4724 {"rust_interface", "List<a.IBar> is not supported."},
4725 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004726 {"java_parcelable", ""},
4727 {"ndk_parcelable", ""},
4728 {"rust_parcelable", ""},
4729 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4730 {"java_enum", "A generic type cannot have any primitive type parameters."},
4731 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4732 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004733 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004734 {"java_union", ""},
4735 {"ndk_union", ""},
4736 {"rust_union", ""},
4737};
4738
Jooyung Hand236e552020-12-13 09:21:27 +09004739const std::map<std::string, std::string> kArraySupportExpectations = {
4740 {"cpp_primitive", ""},
4741 {"java_primitive", ""},
4742 {"ndk_primitive", ""},
4743 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004744 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4745 {"java_primitiveArray", "Can only have one dimensional arrays."},
4746 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4747 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004748 {"cpp_String", ""},
4749 {"java_String", ""},
4750 {"ndk_String", ""},
4751 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004752 {"cpp_StringArray", "Can only have one dimensional arrays."},
4753 {"java_StringArray", "Can only have one dimensional arrays."},
4754 {"ndk_StringArray", "Can only have one dimensional arrays."},
4755 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004756 {"cpp_IBinder", ""},
4757 {"java_IBinder", ""},
4758 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4759 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4760 {"cpp_ParcelFileDescriptor", ""},
4761 {"java_ParcelFileDescriptor", ""},
4762 {"ndk_ParcelFileDescriptor", ""},
4763 {"rust_ParcelFileDescriptor", ""},
4764 {"cpp_interface", "Binder type cannot be an array"},
4765 {"java_interface", "Binder type cannot be an array"},
4766 {"ndk_interface", "Binder type cannot be an array"},
4767 {"rust_interface", "Binder type cannot be an array"},
4768 {"cpp_parcelable", ""},
4769 {"java_parcelable", ""},
4770 {"ndk_parcelable", ""},
4771 {"rust_parcelable", ""},
4772 {"cpp_enum", ""},
4773 {"java_enum", ""},
4774 {"ndk_enum", ""},
4775 {"rust_enum", ""},
4776 {"cpp_union", ""},
4777 {"java_union", ""},
4778 {"ndk_union", ""},
4779 {"rust_union", ""},
4780};
4781
Jooyung Hanfd3be322020-12-13 09:11:06 +09004782class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004783 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004784 void Run(const std::string& generic_type_decl,
4785 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004786 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004787 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004788 const auto& kind = std::get<1>(param).kind;
4789
4790 FakeIoDelegate io;
4791 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4792 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4793 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004794 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4795 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004796
4797 const auto options =
4798 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4799 CaptureStderr();
4800 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004801 auto it = expectations.find(lang + "_" + kind);
4802 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004803 const string err = GetCapturedStderr();
4804 if (it->second.empty()) {
4805 EXPECT_EQ("", err);
4806 } else {
4807 EXPECT_THAT(err, testing::HasSubstr(it->second));
4808 }
4809 }
4810};
4811
4812INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004813 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004814 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4815 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004816 testing::ValuesIn(kTypeParams)),
4817 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004818 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004819 });
4820
Jooyung Hanfd3be322020-12-13 09:11:06 +09004821TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4822 Run("List<{}>", kListSupportExpectations);
4823}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004824
Jooyung Hand236e552020-12-13 09:21:27 +09004825TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4826 Run("{}[]", kArraySupportExpectations);
4827}
4828
Christopher Wiley90be4e32015-10-20 14:55:25 -07004829} // namespace aidl
4830} // namespace android