blob: 10e804431bda744d4c844772f974174ae41311c4 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
1477TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1478 io_delegate_.SetFileContents("p/IOuter.aidl",
1479 "package p;\n"
1480 "interface IOuter {\n"
1481 " parcelable Inner {}\n"
1482 "}");
1483 import_paths_.emplace("");
1484 const string input_path = "p/IFoo.aidl";
1485 const string input =
1486 "package p;\n"
1487 "interface IFoo {\n"
1488 " p.IOuter.Inner get();\n"
1489 "}";
1490 CaptureStderr();
1491 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1492 EXPECT_EQ(GetCapturedStderr(), "");
1493
1494 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1495}
1496
1497TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1498 io_delegate_.SetFileContents("p/IOuter.aidl",
1499 "package p;\n"
1500 "interface IOuter {\n"
1501 " parcelable Inner {}\n"
1502 "}");
1503 import_paths_.emplace("");
1504 const string input_path = "p/IFoo.aidl";
1505 const string input =
1506 "package p;\n"
1507 "import p.IOuter.Inner;"
1508 "interface IFoo {\n"
1509 " Inner get();\n"
1510 "}";
1511 CaptureStderr();
1512 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1513 EXPECT_EQ(GetCapturedStderr(), "");
1514
1515 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1516}
1517
1518TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1519 const string input_path = "p/IFoo.aidl";
1520 const string input =
1521 "package p;\n"
1522 "interface IFoo {\n"
1523 " parcelable Result {}\n"
1524 " Result get();\n"
1525 "}";
1526 CaptureStderr();
1527 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1528 EXPECT_EQ(GetCapturedStderr(), "");
1529
1530 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1531}
1532
1533// Finding the type of nested named member.
1534struct TypeFinder : AidlVisitor {
1535 string name;
1536 const AidlTypeSpecifier* type = nullptr;
1537 TypeFinder(std::string name) : name(name) {}
1538 void Visit(const AidlVariableDeclaration& v) override {
1539 if (v.GetName() == name) {
1540 type = &v.GetType();
1541 }
1542 }
1543 void Visit(const AidlMethod& m) override {
1544 if (m.GetName() == name) {
1545 type = &m.GetType();
1546 }
1547 }
1548 static string Get(const AidlDefinedType& type, const string& name) {
1549 TypeFinder v(name);
1550 VisitTopDown(v, type);
1551 return v.type ? v.type->Signature() : "(null)";
1552 };
1553};
1554
1555TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1556 io_delegate_.SetFileContents("q/IBar.aidl",
1557 "package q;\n"
1558 "interface IBar {\n"
1559 " parcelable Baz {}\n"
1560 "}");
1561 import_paths_.emplace("");
1562 const string input_path = "p/IFoo.aidl";
1563 const string input =
1564 "package p;\n"
1565 "import q.IBar;\n"
1566 "interface IFoo {\n"
1567 " parcelable Nested {\n"
1568 " Baz t1;\n"
1569 " }\n"
1570 " parcelable Baz { }\n"
1571 " IBar.Baz t2();\n"
1572 " Baz t3();\n"
1573 "}";
1574 CaptureStderr();
1575 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1576 EXPECT_EQ(GetCapturedStderr(), "");
1577 ASSERT_NE(nullptr, foo);
1578
1579 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1580 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1581 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1582}
1583
1584TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1585 const string input_path = "p/Foo.aidl";
1586 const string input =
1587 "package p;\n"
1588 "parcelable Foo {\n"
1589 " parcelable Foo {}\n"
1590 "}";
1591 CaptureStderr();
1592 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1593 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1594}
1595
1596TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1597 const string input_path = "p/IFoo.aidl";
1598 const string input =
1599 "package p;\n"
1600 "interface IFoo {\n"
1601 " interface ICallback { void done(); }\n"
1602 " void doTask(ICallback cb);\n"
1603 "}";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1606 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1607}
1608
Jooyung Han2b1487d2021-09-30 09:57:01 +09001609TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1610 const string input_path = "p/IFoo.aidl";
1611 const string input =
1612 "package p;\n"
1613 "interface IFoo {\n"
1614 " parcelable Bar cpp_header \"Bar.h\";\n"
1615 "}";
1616 CaptureStderr();
1617 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1618 EXPECT_THAT(GetCapturedStderr(),
1619 HasSubstr("Unstructured parcelables should be at the root scope"));
1620}
1621
Jooyung Han7fc5de02021-09-30 22:26:27 +09001622TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1623 const string input_path = "p/Foo.aidl";
1624 const string input =
1625 "package p;\n"
1626 "parcelable Foo<T> {\n"
1627 " parcelable Bar {}\n"
1628 "}";
1629 CaptureStderr();
1630 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1631 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1632}
1633
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001634TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1635 const string input_path = "p/IFoo.aidl";
1636 const string input =
1637 "package p;\n"
1638 "interface IFoo {\n"
1639 " parcelable;\n" // missing identifier
1640 "}";
1641 CaptureStderr();
1642 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1643 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1644}
1645
Jooyung Han2aedb112021-09-29 09:37:59 +09001646TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1647 const string input_path = "p/Foo.aidl";
1648 const string input =
1649 "package p;\n"
1650 "interface Foo {\n"
1651 " parcelable Bar {}\n"
1652 " parcelable Bar {}\n"
1653 "}";
1654 CaptureStderr();
1655 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1657}
1658
1659TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1660 struct Failure {
1661 string err;
1662 };
1663 struct TestCase {
1664 string type;
1665 variant<string, Failure> expected; // success<0> or failure<1>
1666 };
1667 vector<TestCase> cases = {
1668 {"foo.A", "foo.A"},
1669 {"foo.A.B", "foo.A.B"},
1670 {"@nullable(heap=true) A", "foo.A.B.A"},
1671 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1672 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1673 {"B", "foo.A.B.A.B"},
1674 {"A.B", "foo.A.B.A.B"},
1675 };
1676 const string input_path = "foo/A.aidl";
1677 for (auto& [type, expected] : cases) {
1678 AidlTypenames typenames;
1679 // clang-format off
1680 const string input =
1681 "package foo;\n"
1682 "parcelable A {\n"
1683 " parcelable B {\n"
1684 " parcelable A {\n"
1685 " parcelable B {\n"
1686 " }\n"
1687 " " + type + " m;\n"
1688 " }\n"
1689 " }\n"
1690 "}";
1691 // clang-format on
1692 CaptureStderr();
1693 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1694 if (auto failure = std::get_if<Failure>(&expected); failure) {
1695 ASSERT_EQ(nullptr, foo);
1696 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1697 } else {
1698 EXPECT_EQ(GetCapturedStderr(), "");
1699 ASSERT_NE(nullptr, foo);
1700 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1701 }
1702 }
1703}
1704
Jooyung Hanca84b032021-09-30 02:15:59 +09001705TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1706 const string input_path = "p/IFoo.aidl";
1707 const string input =
1708 "package p;\n"
1709 "interface IFoo {\n"
1710 " parcelable Result {}\n"
1711 "}";
1712 CaptureStderr();
1713 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1714 ASSERT_NE(nullptr, foo);
1715 EXPECT_EQ(GetCapturedStderr(), "");
1716
1717 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1718 ASSERT_NE(nullptr, result);
1719 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1720}
1721
Jooyung Han0a950bd2021-05-15 12:50:36 +09001722TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001723 const string input_path = "p/Wrapper.aidl";
1724 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001725
1726 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1727 EXPECT_NE(nullptr, parse_result);
1728
1729 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1730 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1731 (..., params->emplace_back(std::move(type_params)));
1732 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1733 };
1734
1735 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1736 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001737 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001738 type->Annotate(std::move(annotations));
1739 return std::move(type);
1740 };
1741
1742 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1743 (void)type->SetArray();
1744 return std::move(type);
1745 };
1746
1747 auto w = type("p.Wrapper", type("String"));
1748 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1749
1750 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1751 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1752 cpp::CppNameOf(*nullable_w, typenames_));
1753
1754 auto array_w = set_array(type("p.Wrapper", type("String")));
1755 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1756 cpp::CppNameOf(*array_w, typenames_));
1757
1758 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1759 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1760 cpp::CppNameOf(*nullable_array_w, typenames_));
1761
1762 auto list_w = type("List", type("p.Wrapper", type("String")));
1763 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1764 cpp::CppNameOf(*list_w, typenames_));
1765
1766 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1767 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1768 cpp::CppNameOf(*nullable_list_w, typenames_));
1769}
1770
Devin Moore7b8d5c92020-03-17 14:14:08 -07001771TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001772 io_delegate_.SetFileContents(
1773 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001774 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001775 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001776 const string input_path = "p/IFoo.aidl";
1777 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001778 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1779 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001780 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001781 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001782 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001783
1784 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1785 // C++ understands C++ specific stuff
1786 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1787 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001788 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001789 EXPECT_EQ(1u, headers.size());
1790 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001791}
1792
Christopher Wileyf8136192016-04-12 14:19:35 -07001793TEST_F(AidlTest, WritesCorrectDependencyFile) {
1794 // While the in tree build system always gives us an output file name,
1795 // other android tools take advantage of our ability to infer the intended
1796 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001797 vector<string> args = {
1798 "aidl",
1799 "-d dep/file/path",
1800 "-o place/for/output",
1801 "p/IFoo.aidl"};
1802 Options options = Options::From(args);
1803 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001804 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001805 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001806 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001807 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1808}
1809
Dan Willemsen93298ee2016-11-10 23:55:55 -08001810TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1811 // While the in tree build system always gives us an output file name,
1812 // other android tools take advantage of our ability to infer the intended
1813 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001814 vector<string> args = {
1815 "aidl",
1816 "-d dep/file/path",
1817 "--ninja",
1818 "-o place/for/output",
1819 "p/IFoo.aidl"};
1820 Options options = Options::From(args);
1821 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001822 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001823 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001824 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001825 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1826}
1827
Jiyong Parkdf202122019-09-30 20:48:35 +09001828TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001829 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1830 // this by calling aidl with every .aidl file it finds, then parsing the
1831 // generated dependency files. Those that reference .java output files are
1832 // for interfaces and those that do not are parcelables. However, for both
1833 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001834 vector<string> args = {
1835 "aidl",
1836 "-o place/for/output",
1837 "-d dep/file/path",
1838 "p/Foo.aidl"};
1839 Options options = Options::From(args);
1840 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001841 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001842 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001843 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001844 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1845}
1846
1847TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1848 vector<string> args = {
1849 "aidl",
1850 "--structured",
1851 "-o place/for/output",
1852 "-d dep/file/path",
1853 "p/Foo.aidl"};
1854 Options options = Options::From(args);
1855 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001856 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001857 string actual_dep_file_contents;
1858 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1859 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001860}
1861
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001862TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1863 vector<string> args = {
1864 "aidl",
1865 "--lang=java",
1866 "-o place/for/output",
1867 "p/Foo.aidl"};
1868 Options options = Options::From(args);
1869 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001870 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001871 string output_file_contents;
1872 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1873}
1874
Devin Moore21b26772020-08-26 16:37:56 -07001875TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001876 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001877 const string list_array_parcelable =
1878 "package a; parcelable Foo {\n"
1879 " List[] lists; }";
1880 CaptureStderr();
1881 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1882 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1883}
1884
Jiyong Parkf8d53612020-05-04 14:06:13 +09001885TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1886 AidlError error;
1887 string expected_stderr =
1888 "ERROR: a/IFoo.aidl:2.7-11: "
1889 "Encountered an untyped List or Map. The use of untyped List/Map is "
1890 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1891 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1892 if (GetLanguage() != Options::Language::JAVA) {
1893 expected_stderr =
1894 "ERROR: a/IFoo.aidl:2.1-7: "
1895 "Currently, only the Java backend supports non-generic List.\n";
1896 }
1897
1898 const string primitive_interface =
1899 "package a; interface IFoo {\n"
1900 " List foo(); }";
1901 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001902 AidlTypenames tn1;
1903 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001904 {"--structured"}));
1905 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001906
1907 string primitive_parcelable =
1908 "package a; parcelable IFoo {\n"
1909 " List foo;}";
1910 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001911 AidlTypenames tn2;
1912 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001913 {"--structured"}));
1914 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1915}
1916
Jeongik Cha225519b2020-08-29 01:55:32 +09001917TEST_P(AidlTest, ExtensionTest) {
1918 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001919 string extendable_parcelable =
1920 "package a; parcelable Data {\n"
1921 " ParcelableHolder extension;\n"
1922 " ParcelableHolder extension2;\n"
1923 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001924 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001925 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1926 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001927 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001928 "yet.\n",
1929 GetCapturedStderr());
1930 } else {
1931 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1932 EXPECT_EQ("", GetCapturedStderr());
1933 }
1934}
1935TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1936 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001937 string parcelableholder_return_interface =
1938 "package a; interface IFoo {\n"
1939 " ParcelableHolder foo();\n"
1940 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001941 EXPECT_EQ(nullptr,
1942 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001943
Jeongik Cha8f02a532020-10-14 00:16:28 +09001944 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001945 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001946 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001947 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001948 "yet.\n",
1949 GetCapturedStderr());
1950 return;
1951 }
1952 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1953 GetCapturedStderr());
1954}
1955
1956TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1957 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001958 string extendable_parcelable_arg_interface =
1959 "package a; interface IFoo {\n"
1960 " void foo(in ParcelableHolder ph);\n"
1961 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001962 EXPECT_EQ(nullptr,
1963 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1964
Jeongik Cha8f02a532020-10-14 00:16:28 +09001965 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001966 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001967 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001968 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001969 "yet.\n",
1970 GetCapturedStderr());
1971 return;
1972 }
1973 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1974 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001975}
1976
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001977TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1978 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001979 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001980 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1981 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001982 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001983 if (GetLanguage() == Options::Language::RUST) {
1984 EXPECT_EQ(
1985 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1986 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1987 "yet.\n",
1988 GetCapturedStderr());
1989 return;
1990 }
1991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1992}
1993
Jooyung Han3f347ca2020-12-01 12:41:50 +09001994TEST_P(AidlTest, ParcelablesWithConstants) {
1995 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001996 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001997 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001998 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001999 EXPECT_EQ("", GetCapturedStderr());
2000}
2001
2002TEST_P(AidlTest, UnionWithConstants) {
2003 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002004 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002005 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002006 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002007 EXPECT_EQ("", GetCapturedStderr());
2008}
2009
Jooyung Han633eab62021-01-07 14:12:40 +09002010TEST_F(AidlTest, ConstantsWithAnnotations) {
2011 io_delegate_.SetFileContents("IFoo.aidl",
2012 "interface IFoo {\n"
2013 " @JavaPassthrough(annotation=\"@Foo\")\n"
2014 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2015 "}");
2016 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2017 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002018 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002019 EXPECT_EQ("", GetCapturedStderr());
2020 string code;
2021 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2022 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2023 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2024}
2025
Jiyong Park02da7422018-07-16 16:00:26 +09002026TEST_F(AidlTest, ApiDump) {
2027 io_delegate_.SetFileContents(
2028 "foo/bar/IFoo.aidl",
2029 "package foo.bar;\n"
2030 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002031 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002032 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002033 " /* @hide applied \n"
2034 " @deprecated use foo2 */\n"
2035 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2036 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002037 " IFoo foo3(IFoo foo);\n"
2038 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002039 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002040 " /** blahblah\n"
2041 " @deprecated\n"
2042 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002043 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002044 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002045 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002046 "}\n");
2047 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2048 "package foo.bar;\n"
2049 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002050 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002051 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002052 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002053 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002054 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002055 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002056 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002057 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002058 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002059 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002060 "}\n");
2061 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002062 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2063 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002064 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002065 bool result = dump_api(options, io_delegate_);
2066 ASSERT_TRUE(result);
2067 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002068 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002069 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002070interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002071 /**
2072 * @hide
2073 * @deprecated use foo2
2074 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002075 int foo(out int[] a, String b, boolean c, inout List<String> d);
2076 int foo2(@utf8InCpp String x, inout List<String> y);
2077 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2078 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002079 /**
2080 * @deprecated reason why...
2081 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002082 const int A = 1;
2083 const String STR = "Hello";
2084}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002085)"),
2086 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002087
Jiyong Parke59c3682018-09-11 23:10:25 +09002088 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002089 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002090/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002091parcelable Data {
2092 int x = 10;
2093 int y;
2094 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002095 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002096}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002097)"),
2098 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002099}
2100
Jiyong Parked65bf42018-08-28 15:43:27 +09002101TEST_F(AidlTest, ApiDumpWithManualIds) {
2102 io_delegate_.SetFileContents(
2103 "foo/bar/IFoo.aidl",
2104 "package foo.bar;\n"
2105 "interface IFoo {\n"
2106 " int foo() = 1;\n"
2107 " int bar() = 2;\n"
2108 " int baz() = 10;\n"
2109 "}\n");
2110
Jiyong Parke59c3682018-09-11 23:10:25 +09002111 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002112 Options options = Options::From(args);
2113 bool result = dump_api(options, io_delegate_);
2114 ASSERT_TRUE(result);
2115 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002116 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002117 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002118interface IFoo {
2119 int foo() = 1;
2120 int bar() = 2;
2121 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002122}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002123)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002124}
2125
2126TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002127 const string expected_stderr =
2128 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2129 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002130 io_delegate_.SetFileContents(
2131 "foo/bar/IFoo.aidl",
2132 "package foo.bar;\n"
2133 "interface IFoo {\n"
2134 " int foo() = 1;\n"
2135 " int bar();\n"
2136 " int baz() = 10;\n"
2137 "}\n");
2138
Jiyong Parke59c3682018-09-11 23:10:25 +09002139 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002140 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002141 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002142 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002143 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002144}
2145
Jooyung Han965e31d2020-11-27 12:30:16 +09002146TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2147 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2148 "package foo.bar;\n"
2149 "interface IFoo {\n"
2150 " @utf8InCpp String foo();\n"
2151 " const @utf8InCpp String bar = \"bar\";\n"
2152 "}\n");
2153
2154 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2155 Options options = Options::From(args);
2156 CaptureStderr();
2157 EXPECT_TRUE(dump_api(options, io_delegate_));
2158 EXPECT_EQ("", GetCapturedStderr());
2159 string actual;
2160 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002161 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2162interface IFoo {
2163 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002164 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002165}
2166)"),
2167 actual);
2168}
2169
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002170TEST_F(AidlTest, ApiDumpWithEnums) {
2171 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2172 "package foo.bar;\n"
2173 "enum Enum {\n"
2174 " FOO,\n"
2175 " BAR = FOO + 1,\n"
2176 "}\n");
2177
2178 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2179 Options options = Options::From(args);
2180 CaptureStderr();
2181 EXPECT_TRUE(dump_api(options, io_delegate_));
2182 EXPECT_EQ("", GetCapturedStderr());
2183 string actual;
2184 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2185 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2186 "enum Enum {\n"
2187 " FOO = 0,\n"
2188 " BAR = 1,\n"
2189 "}\n"),
2190 actual);
2191}
2192
2193TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2194 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2195 "package foo.bar;\n"
2196 "enum Enum {\n"
2197 " FOO,\n"
2198 "}\n");
2199 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2200 "package foo.bar;\n"
2201 "import foo.bar.Enum;\n"
2202 "parcelable Foo {\n"
2203 " Enum e = Enum.FOO;\n"
2204 "}\n");
2205
2206 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2207 Options options = Options::From(args);
2208 CaptureStderr();
2209 EXPECT_TRUE(dump_api(options, io_delegate_));
2210 EXPECT_EQ("", GetCapturedStderr());
2211 string actual;
2212 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2213 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2214 "parcelable Foo {\n"
2215 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2216 "}\n"),
2217 actual);
2218}
2219
Jooyung Han71dfec32021-05-23 07:18:58 +09002220TEST_F(AidlTest, ApiDumpWithGenerics) {
2221 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2222 "package foo.bar;\n"
2223 "parcelable Foo<T, U> {\n"
2224 "}\n");
2225
2226 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2227 Options options = Options::From(args);
2228 CaptureStderr();
2229 EXPECT_TRUE(dump_api(options, io_delegate_));
2230 EXPECT_EQ("", GetCapturedStderr());
2231 string actual;
2232 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2233 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2234 "parcelable Foo<T, U> {\n"
2235 "}\n"),
2236 actual);
2237}
2238
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002239TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2240 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2241 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2242
2243 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2244 Options options = Options::From(args);
2245 CaptureStderr();
2246 EXPECT_FALSE(dump_api(options, io_delegate_));
2247 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2248}
2249
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002250TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002251 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002252 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2253 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002254 const string expected_map_stderr =
2255 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002256 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2257 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002258 "package p; interface IFoo {"
2259 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002260 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002261 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002262 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002263
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002264 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002265 "package p; interface IFoo {"
2266 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002267 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002268 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002269 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002270}
2271
Jeongik Chae48d9942020-01-02 17:39:00 +09002272TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002273 const string expected_stderr =
2274 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002275 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002276 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2277
2278 io_delegate_.SetFileContents("p/IFoo.aidl",
2279 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002280 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002281 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002282
2283 io_delegate_.SetFileContents("p/IFoo.aidl",
2284 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002285 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002286 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002287 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002288 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002289
2290 io_delegate_.SetFileContents("p/IFoo.aidl",
2291 "package p; interface IFoo {"
2292 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002293 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002294
2295 io_delegate_.SetFileContents("p/IFoo.aidl",
2296 "package p; interface IFoo {"
2297 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002298 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002299}
2300
Jeongik Chadf76dc72019-11-28 00:08:47 +09002301TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002302 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002303 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2304 io_delegate_.SetFileContents(options.InputFiles().front(),
2305 "package p; interface IFoo {"
2306 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002307 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002308 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002310}
2311
2312TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002313 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002314 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002315 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002316 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002317 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2318 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002319
Jooyung Han13f1fa52021-06-11 18:06:12 +09002320 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002321 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2322 io_delegate_.SetFileContents("p/IFoo.aidl",
2323 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002324 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002325 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002326 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002327 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002328 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002330 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002331 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002332 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002333 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002334 io_delegate_.SetFileContents("p/IFoo.aidl",
2335 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002336 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002337 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002338
2339 io_delegate_.SetFileContents("p/IFoo.aidl",
2340 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002341 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002342
2343 io_delegate_.SetFileContents("p/IFoo.aidl",
2344 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002345 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002346
Steven Moreland4e059132021-08-11 13:36:30 -07002347 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002348}
2349
Jeongik Cha0e426012019-07-29 15:57:02 +09002350TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2351 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002352 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2353 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002354 for (const auto& rawOption : rawOptions) {
2355 string expected_stderr =
2356 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002357 Options options = Options::From(rawOption);
2358 io_delegate_.SetFileContents(options.InputFiles().front(),
2359 "package foo.bar;\n"
2360 "interface IFoo1 { int foo(); }\n"
2361 "interface IFoo2 { int foo(); }\n"
2362 "parcelable Data1 { int a; int b;}\n"
2363 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002364 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002365 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002367
Jeongik Cha0e426012019-07-29 15:57:02 +09002368 io_delegate_.SetFileContents(options.InputFiles().front(),
2369 "package foo.bar;\n"
2370 "interface IFoo1 { int foo(); }\n"
2371 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002372 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002373 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002375
Devin Moore5de18ed2020-04-02 13:52:29 -07002376 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002377 io_delegate_.SetFileContents(options.InputFiles().front(),
2378 "package foo.bar;\n"
2379 "parcelable Data1 { int a; int b;}\n"
2380 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002382 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002384 }
2385}
2386
Devin Moorebdba2a82020-03-31 15:19:02 -07002387TEST_P(AidlTest, FailParseOnEmptyFile) {
2388 const string contents = "";
2389 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2390 CaptureStderr();
2391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2393}
2394
Jiyong Parkb034bf02018-07-30 17:44:33 +09002395TEST_F(AidlTest, MultipleInputFiles) {
2396 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002397 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002398
2399 io_delegate_.SetFileContents(options.InputFiles().at(0),
2400 "package foo.bar;\n"
2401 "import foo.bar.Data;\n"
2402 "interface IFoo { Data getData(); }\n");
2403
2404 io_delegate_.SetFileContents(options.InputFiles().at(1),
2405 "package foo.bar;\n"
2406 "import foo.bar.IFoo;\n"
2407 "parcelable Data { IFoo foo; }\n");
2408
Steven Moreland4e059132021-08-11 13:36:30 -07002409 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002410
2411 string content;
2412 for (const auto file : {
2413 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2414 content.clear();
2415 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2416 EXPECT_FALSE(content.empty());
2417 }
2418}
2419
2420TEST_F(AidlTest, MultipleInputFilesCpp) {
2421 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002422 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002423
2424 io_delegate_.SetFileContents(options.InputFiles().at(0),
2425 "package foo.bar;\n"
2426 "import foo.bar.Data;\n"
2427 "interface IFoo { Data getData(); }\n");
2428
2429 io_delegate_.SetFileContents(options.InputFiles().at(1),
2430 "package foo.bar;\n"
2431 "import foo.bar.IFoo;\n"
2432 "parcelable Data { IFoo foo; }\n");
2433
Steven Moreland4e059132021-08-11 13:36:30 -07002434 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002435
2436 string content;
2437 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002438 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002439 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2440 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2441 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2442 content.clear();
2443 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2444 EXPECT_FALSE(content.empty());
2445 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002446}
2447
Andrei Homescub62afd92020-05-11 19:24:59 -07002448TEST_F(AidlTest, MultipleInputFilesRust) {
2449 Options options =
2450 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2451
2452 io_delegate_.SetFileContents(options.InputFiles().at(0),
2453 "package foo.bar;\n"
2454 "import foo.bar.Data;\n"
2455 "interface IFoo { Data getData(); }\n");
2456
2457 io_delegate_.SetFileContents(options.InputFiles().at(1),
2458 "package foo.bar;\n"
2459 "import foo.bar.IFoo;\n"
2460 "parcelable Data { IFoo foo; }\n");
2461
Steven Moreland4e059132021-08-11 13:36:30 -07002462 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002463
2464 string content;
2465 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2466 content.clear();
2467 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2468 EXPECT_FALSE(content.empty());
2469 }
2470}
2471
Devin Moore097a3ab2020-03-11 16:08:44 -07002472TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2473 const string expected_stderr =
2474 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002475 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2476 // int getInterfaceVersion() is one of the meta transactions
2477 io_delegate_.SetFileContents(options.InputFiles().front(),
2478 "package p; interface IFoo {"
2479 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002480 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002481 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2483}
Jiyong Park309668e2018-07-28 16:55:44 +09002484
Devin Moore097a3ab2020-03-11 16:08:44 -07002485TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2486 // boolean getInterfaceVersion() is not a meta transaction, but should be
2487 // prevented because return type is not part of a method signature
2488 const string expected_stderr =
2489 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2490 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002491 io_delegate_.SetFileContents(options.InputFiles().front(),
2492 "package p; interface IFoo {"
2493 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002494 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002495 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002496 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2497}
Jiyong Park309668e2018-07-28 16:55:44 +09002498
Devin Moore097a3ab2020-03-11 16:08:44 -07002499TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002500 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002501 const string expected_stderr =
2502 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2503 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002504 io_delegate_.SetFileContents(options.InputFiles().front(),
2505 "package p; interface IFoo {"
2506 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002507 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002508 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002509 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002510
2511 // this is not a meta interface method as it differs type arguments
2512 io_delegate_.SetFileContents(options.InputFiles().front(),
2513 "package p; interface IFoo {"
2514 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002515 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002516}
2517
Jooyung Hanb8a97772021-01-19 01:27:38 +09002518TEST_F(AidlTest, CheckApiForEquality) {
2519 CaptureStderr();
2520 Options options = Options::From("aidl --checkapi=equal old new");
2521
2522 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2523 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2524 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2525 "package p; interface IFoo{ @utf8InCpp String foo();}");
2526
2527 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2528 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2529}
2530
Daniel Norman85aed542019-08-21 12:01:14 -07002531TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002532 Options options = Options::From("aidl --checkapi old new");
2533 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2534 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2535 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2536 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2537
2538 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2539}
2540
Jiyong Park3656c3c2018-08-01 20:02:01 +09002541TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002542 Options options = Options::From("aidl --checkapi old new");
2543 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2544 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002545
2546 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2547}
2548
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002549TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2550 Options options = Options::From("aidl --checkapi old new");
2551 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2552 const string enum_definition = "package p; enum Enum { FOO }";
2553 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2554 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2555 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2556 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2557
2558 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2559}
2560
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002561TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2562 Options options = Options::From("aidl --checkapi old new -I import");
2563
2564 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2565 io_delegate_.SetFileContents("new/p/Foo.aidl",
2566 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2567 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2568
2569 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2570}
2571
Jooyung Han02a11be2021-02-11 13:18:06 +09002572TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2573 Options options = Options::From("aidl --checkapi=equal old new");
2574 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2575 const string enum_definition = "package p; enum Enum { FOO }";
2576 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2577 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2578 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2579 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2580 CaptureStderr();
2581 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2582 EXPECT_EQ("", GetCapturedStderr());
2583}
2584
Daniel Norman85aed542019-08-21 12:01:14 -07002585class AidlTestCompatibleChanges : public AidlTest {
2586 protected:
2587 Options options_ = Options::From("aidl --checkapi old new");
2588};
2589
2590TEST_F(AidlTestCompatibleChanges, NewType) {
2591 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2592 "package p;"
2593 "interface IFoo {"
2594 " void foo(int a);"
2595 "}");
2596 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2597 "package p;"
2598 "interface IFoo {"
2599 " void foo(int a);"
2600 "}");
2601 io_delegate_.SetFileContents("new/p/IBar.aidl",
2602 "package p;"
2603 "interface IBar {"
2604 " void bar();"
2605 "}");
2606 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2607}
2608
2609TEST_F(AidlTestCompatibleChanges, NewMethod) {
2610 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2611 "package p;"
2612 "interface IFoo {"
2613 " void foo(int a);"
2614 "}");
2615 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2616 "package p;"
2617 "interface IFoo {"
2618 " void foo(int a);"
2619 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002620 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002621 "}");
2622 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2623}
2624
2625TEST_F(AidlTestCompatibleChanges, NewField) {
2626 io_delegate_.SetFileContents("old/p/Data.aidl",
2627 "package p;"
2628 "parcelable Data {"
2629 " int foo;"
2630 "}");
2631 io_delegate_.SetFileContents("new/p/Data.aidl",
2632 "package p;"
2633 "parcelable Data {"
2634 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002635 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002636 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002637 "}");
2638 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2639}
2640
Jooyung Han05bd8a82021-04-28 23:56:38 +09002641TEST_F(AidlTestCompatibleChanges, NewField2) {
2642 io_delegate_.SetFileContents("old/p/Data.aidl",
2643 "package p;"
2644 "parcelable Data {"
2645 "}");
2646 io_delegate_.SetFileContents("new/p/Data.aidl",
2647 "package p;"
2648 "parcelable Data {"
2649 " int foo = 0;"
2650 "}");
2651 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2652}
2653
Daniel Norman85aed542019-08-21 12:01:14 -07002654TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2655 io_delegate_.SetFileContents("old/p/Enum.aidl",
2656 "package p;"
2657 "enum Enum {"
2658 " FOO = 1,"
2659 "}");
2660 io_delegate_.SetFileContents("new/p/Enum.aidl",
2661 "package p;"
2662 "enum Enum {"
2663 " FOO = 1,"
2664 " BAR = 2,"
2665 "}");
2666 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2667}
2668
2669TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2670 io_delegate_.SetFileContents("old/p/Enum.aidl",
2671 "package p;"
2672 "enum Enum {"
2673 " FOO = 1,"
2674 " BAR = 2,"
2675 "}");
2676 io_delegate_.SetFileContents("new/p/Enum.aidl",
2677 "package p;"
2678 "enum Enum {"
2679 " BAR = 2,"
2680 " FOO = 1,"
2681 "}");
2682 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2683}
2684
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002685TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2686 io_delegate_.SetFileContents("old/p/Union.aidl",
2687 "package p;"
2688 "union Union {"
2689 " String foo;"
2690 "}");
2691 io_delegate_.SetFileContents("new/p/Union.aidl",
2692 "package p;"
2693 "union Union {"
2694 " String foo;"
2695 " int num;"
2696 "}");
2697 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2698}
2699
Daniel Norman85aed542019-08-21 12:01:14 -07002700TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002701 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2702 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002703 "interface IFoo {"
2704 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002705 "}");
2706 io_delegate_.SetFileContents("old/p/Data.aidl",
2707 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002708 "parcelable Data {"
2709 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002710 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002711 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2712 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002713 "interface IFoo {"
2714 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002715 "}");
2716 io_delegate_.SetFileContents("new/p/Data.aidl",
2717 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002718 "parcelable Data {"
2719 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002720 "}");
2721 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2722 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002723 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002724 " void foo(int a);"
2725 "}");
2726 io_delegate_.SetFileContents("new/q/Data.aidl",
2727 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002728 "parcelable Data {"
2729 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002730 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002731 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2732}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002733
Daniel Norman85aed542019-08-21 12:01:14 -07002734TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2735 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2736 "package p;"
2737 "interface IFoo {"
2738 " void foo(int a);"
2739 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002740 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2741 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002742 "interface IFoo {"
2743 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002744 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002745 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2746}
Jiyong Parke59c3682018-09-11 23:10:25 +09002747
Daniel Norman85aed542019-08-21 12:01:14 -07002748TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002749 io_delegate_.SetFileContents("old/p/I.aidl",
2750 "package p; interface I {"
2751 "const int A = 1; }");
2752 io_delegate_.SetFileContents("new/p/I.aidl",
2753 "package p ; interface I {"
2754 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002755 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2756}
Jiyong Parka428d212018-08-29 22:26:30 +09002757
Daniel Norman85aed542019-08-21 12:01:14 -07002758TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002759 io_delegate_.SetFileContents("old/p/I.aidl",
2760 "package p; interface I {"
2761 "const int A = 1; const int B = 2;}");
2762 io_delegate_.SetFileContents("new/p/I.aidl",
2763 "package p ; interface I {"
2764 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002765 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002766}
2767
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002768TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2769 io_delegate_.SetFileContents("old/p/Foo.aidl",
2770 "package p;"
2771 "@JavaPassthrough(annotation=\"Alice\")"
2772 "@JavaPassthrough(annotation=\"Bob\")"
2773 "parcelable Foo {}");
2774 io_delegate_.SetFileContents("new/p/Foo.aidl",
2775 "package p;"
2776 "@JavaPassthrough(annotation=\"Bob\")"
2777 "@JavaPassthrough(annotation=\"Alice\")"
2778 "parcelable Foo {}");
2779 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2780}
2781
Jooyung Han00073272020-11-27 14:20:20 +09002782TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2783 io_delegate_.SetFileContents("old/p/Foo.aidl",
2784 "package p;"
2785 "parcelable Foo {}");
2786 io_delegate_.SetFileContents("new/p/Foo.aidl",
2787 "package p;"
2788 "@JavaPassthrough(annotation=\"@Deprecated\")"
2789 "parcelable Foo {}");
2790 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2791}
2792
Jooyung Han636fd2f2020-10-22 11:33:45 +09002793TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2794 io_delegate_.SetFileContents("old/p/Data.aidl",
2795 "package p;"
2796 "parcelable Data {"
2797 " int num;"
2798 "}");
2799 io_delegate_.SetFileContents(
2800 "new/p/Data.aidl",
2801 "package p;"
2802 "parcelable Data {"
2803 " int num;"
2804 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2805 "}");
2806 io_delegate_.SetFileContents("new/p/Enum.aidl",
2807 "package p;"
2808 "enum Enum {"
2809 " FOO = 0,"
2810 " BAR = 1,"
2811 "}");
2812 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2813}
2814
Jooyung Han308bbe02021-04-27 12:09:59 +09002815TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2816 io_delegate_.SetFileContents("old/p/Data.aidl",
2817 "package p;\n"
2818 "parcelable Data {\n"
2819 " p.Enum e;\n"
2820 "}");
2821 io_delegate_.SetFileContents("old/p/Enum.aidl",
2822 "package p;\n"
2823 "enum Enum {\n"
2824 " FOO = 0,\n"
2825 " BAR = 1,\n"
2826 "}");
2827 io_delegate_.SetFileContents("new/p/Data.aidl",
2828 "package p;\n"
2829 "parcelable Data {\n"
2830 " p.Enum e = p.Enum.FOO;\n"
2831 "}");
2832 io_delegate_.SetFileContents("new/p/Enum.aidl",
2833 "package p;\n"
2834 "enum Enum {\n"
2835 " FOO = 0,\n"
2836 " BAR = 1,\n"
2837 "}");
2838 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2839}
2840
Daniel Norman85aed542019-08-21 12:01:14 -07002841class AidlTestIncompatibleChanges : public AidlTest {
2842 protected:
2843 Options options_ = Options::From("aidl --checkapi old new");
2844};
2845
2846TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002847 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002848 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2849 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002850 "interface IFoo {"
2851 " void foo(in String[] str);"
2852 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002853 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002854 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002855 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002856 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002857}
2858
2859TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002860 const string expected_stderr =
2861 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002862 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2863 "package p;"
2864 "interface IFoo {"
2865 " void foo(in String[] str);"
2866 " void bar(@utf8InCpp String str);"
2867 "}");
2868 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2869 "package p;"
2870 "interface IFoo {"
2871 " void foo(in String[] str);"
2872 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002873 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002874 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002875 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002876}
2877
Jiyong Parkf8d53612020-05-04 14:06:13 +09002878TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2879 const string expected_stderr =
2880 "ERROR: new/p/IFoo.aidl:1.61-65: "
2881 "Encountered an untyped List or Map. The use of untyped List/Map is "
2882 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2883 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2884 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2885 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2886 "package p;"
2887 "interface IFoo {"
2888 " void foo(in String[] str);"
2889 "}");
2890 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2891 "package p;"
2892 "interface IFoo {"
2893 " void foo(in String[] str);"
2894 " void bar(in List arg);"
2895 "}");
2896 CaptureStderr();
2897 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2898 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2899}
2900
2901TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2902 const string expected_stderr =
2903 "ERROR: new/p/Data.aidl:1.54-59: "
2904 "Encountered an untyped List or Map. The use of untyped List/Map is "
2905 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2906 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2907 "ERROR: new/p/Data.aidl: Failed to read.\n";
2908 io_delegate_.SetFileContents("old/p/Data.aidl",
2909 "package p;"
2910 "parcelable Data {"
2911 " int foo;"
2912 "}");
2913 io_delegate_.SetFileContents("new/p/Data.aidl",
2914 "package p;"
2915 "parcelable Data {"
2916 " int foo;"
2917 " @nullable List list;"
2918 "}");
2919 CaptureStderr();
2920 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2921 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2922}
2923
Daniel Norman85aed542019-08-21 12:01:14 -07002924TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002925 const string expected_stderr =
2926 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002927 io_delegate_.SetFileContents("old/p/Data.aidl",
2928 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002929 "parcelable Data {"
2930 " int foo;"
2931 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002932 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002933 io_delegate_.SetFileContents("new/p/Data.aidl",
2934 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002935 "parcelable Data {"
2936 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002937 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002938 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002939 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002941}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002942
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002943TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2944 const string expected_stderr =
2945 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2946 "backends. Please either provide a default value for this field or mark the field as "
2947 "@nullable. This value or a null value will be used automatically when an old version of "
2948 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2949 "order to make sure your code continues to be backwards compatible, make sure the default or "
2950 "null value does not cause a semantic change to this parcelable.\n";
2951 io_delegate_.SetFileContents("old/p/Data.aidl",
2952 "package p;"
2953 "parcelable Data {"
2954 " int num;"
2955 "}");
2956 io_delegate_.SetFileContents("new/p/Data.aidl",
2957 "package p;"
2958 "parcelable Data {"
2959 " int num;"
2960 " String str;"
2961 "}");
2962 CaptureStderr();
2963 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2964 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2965}
2966
Jooyung Han636fd2f2020-10-22 11:33:45 +09002967TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2968 const string expected_stderr =
2969 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2970 "Please make sure 'Enum' has '0' as a valid value.\n";
2971 io_delegate_.SetFileContents("old/p/Data.aidl",
2972 "package p;"
2973 "parcelable Data {"
2974 " int num;"
2975 "}");
2976 io_delegate_.SetFileContents("new/p/Data.aidl",
2977 "package p;"
2978 "parcelable Data {"
2979 " int num;"
2980 " p.Enum e;"
2981 "}");
2982 io_delegate_.SetFileContents("new/p/Enum.aidl",
2983 "package p;"
2984 "enum Enum {"
2985 " FOO = 1,"
2986 " BAR = 2,"
2987 "}");
2988 CaptureStderr();
2989 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2991}
2992
Daniel Norman85aed542019-08-21 12:01:14 -07002993TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002994 const string expected_stderr =
2995 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002996 io_delegate_.SetFileContents("old/p/Enum.aidl",
2997 "package p;"
2998 "enum Enum {"
2999 " FOO = 1,"
3000 " BAR = 2,"
3001 "}");
3002 io_delegate_.SetFileContents("new/p/Enum.aidl",
3003 "package p;"
3004 "enum Enum {"
3005 " BAR = 2,"
3006 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003007 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003008 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003010}
3011
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003012TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3013 const string expected_stderr =
3014 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3015 io_delegate_.SetFileContents("old/p/Union.aidl",
3016 "package p;"
3017 "union Union {"
3018 " String str;"
3019 " int num;"
3020 "}");
3021 io_delegate_.SetFileContents("new/p/Union.aidl",
3022 "package p;"
3023 "union Union {"
3024 " String str;"
3025 "}");
3026 CaptureStderr();
3027 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3028 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3029}
3030
Daniel Norman85aed542019-08-21 12:01:14 -07003031TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003032 const string expected_stderr =
3033 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003034 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3035 "package p;"
3036 "interface IFoo {"
3037 " void foo(in String[] str);"
3038 " void bar(@utf8InCpp String str);"
3039 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003040 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3041 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003042 "interface IFoo {"
3043 " void foo(in String[] str);"
3044 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003045 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003046 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003047 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003048 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003049}
3050
Daniel Norman85aed542019-08-21 12:01:14 -07003051TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003052 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003053 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3054 "package p;"
3055 "interface IFoo {"
3056 " void foo(in String[] str);"
3057 " void bar(@utf8InCpp String str);"
3058 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003059 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3060 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003061 "interface IFoo2 {"
3062 " void foo(in String[] str);"
3063 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003064 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003065 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003066 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003067 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003068}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003069
Daniel Norman85aed542019-08-21 12:01:14 -07003070TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003071 const string expected_stderr =
3072 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003073 io_delegate_.SetFileContents("old/p/Enum.aidl",
3074 "package p;"
3075 "enum Enum {"
3076 " FOO = 1,"
3077 " BAR = 2,"
3078 "}");
3079 io_delegate_.SetFileContents("new/p/Enum.aidl",
3080 "package p;"
3081 "enum Enum {"
3082 " FOO = 3,"
3083 " BAR = 2,"
3084 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003085 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003086 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003087 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003088}
3089
3090TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003091 const string expected_stderr =
3092 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3093 "from 0 to 1.\n"
3094 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3095 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003096 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3097 "package p;"
3098 "interface IFoo {"
3099 " void foo(in String[] str);"
3100 " void bar(@utf8InCpp String str);"
3101 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003102 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3103 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003104 "interface IFoo {"
3105 " void bar(@utf8InCpp String str);"
3106 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003107 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003108 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003109 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003111}
3112
3113TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003114 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003115 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3116 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003117 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003118 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003119 "parcelable Data {"
3120 " int foo;"
3121 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003122 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003123 io_delegate_.SetFileContents("new/p/Data.aidl",
3124 "package p;"
3125 "parcelable Data {"
3126 " int bar;"
3127 " int foo;"
3128 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003129 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003130 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003131 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003132}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003133
Daniel Norman85aed542019-08-21 12:01:14 -07003134TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003135 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003136 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003137 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003138 "interface IFoo {"
3139 " void foo(in String[] str);"
3140 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003141 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003142 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3143 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003144 "interface IFoo {"
3145 " void foo(out String[] str);"
3146 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003147 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003148 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003149 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003150 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003151}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003152
Daniel Norman85aed542019-08-21 12:01:14 -07003153TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003154 const string expected_stderr =
3155 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003156 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3157 "package p;"
3158 "interface IFoo {"
3159 " void foo(in String[] str);"
3160 " void bar(@utf8InCpp String str);"
3161 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003162 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3163 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003164 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003165 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003166 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003167 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003168 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003169 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003170 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003171}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003172
Daniel Norman85aed542019-08-21 12:01:14 -07003173TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003174 const string expected_stderr =
3175 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003176 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3177 "package p;"
3178 "interface IFoo {"
3179 " void foo(in String[] str);"
3180 " void bar(@utf8InCpp String str);"
3181 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003182 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3183 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003184 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003185 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003186 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003187 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003188 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003189 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003191}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003192
Jooyung Han60b2fde2020-10-29 15:12:40 +09003193TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3194 const string expected_stderr =
3195 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3196 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3197 io_delegate_.SetFileContents("old/p/Foo.aidl",
3198 "package p;"
3199 "@Backing(type=\"byte\")"
3200 "enum Foo {"
3201 " FOO, BAR,"
3202 "}");
3203 io_delegate_.SetFileContents("new/p/Foo.aidl",
3204 "package p;"
3205 "@Backing(type=\"long\")"
3206 "enum Foo {"
3207 " FOO, BAR,"
3208 "}");
3209 CaptureStderr();
3210 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3212}
3213
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003214TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3215 const string expected_stderr =
3216 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3217 "to @JavaPassthrough(annotation=\"Bob\")\n";
3218 io_delegate_.SetFileContents("old/p/Foo.aidl",
3219 "package p;"
3220 "@JavaPassthrough(annotation=\"Alice\")"
3221 "parcelable Foo {}");
3222 io_delegate_.SetFileContents("new/p/Foo.aidl",
3223 "package p;"
3224 "@JavaPassthrough(annotation=\"Bob\")"
3225 "parcelable Foo {}");
3226
3227 CaptureStderr();
3228 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3229 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3230}
3231
Devin Mooredb7ac512020-08-07 11:17:36 -07003232TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3233 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003234 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003235 io_delegate_.SetFileContents("old/p/Foo.aidl",
3236 "package p;"
3237 "parcelable Foo {"
3238 " int A;"
3239 "}");
3240 io_delegate_.SetFileContents("new/p/Foo.aidl",
3241 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003242 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003243 " int A;"
3244 "}");
3245 CaptureStderr();
3246 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3248}
3249
3250TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3251 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003252 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003253 io_delegate_.SetFileContents("old/p/Foo.aidl",
3254 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003255 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003256 " int A;"
3257 "}");
3258 io_delegate_.SetFileContents("new/p/Foo.aidl",
3259 "package p;"
3260 "parcelable Foo {"
3261 " int A;"
3262 "}");
3263 CaptureStderr();
3264 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3266}
3267
Daniel Norman85aed542019-08-21 12:01:14 -07003268TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003269 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003270 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3271 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003272 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003273 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003274 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003275 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003276}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003277
Daniel Norman85aed542019-08-21 12:01:14 -07003278TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003279 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003280 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3281 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003282 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003283 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003285}
Jiyong Parka428d212018-08-29 22:26:30 +09003286
Daniel Norman85aed542019-08-21 12:01:14 -07003287TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003288 const string expected_stderr =
3289 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003290 io_delegate_.SetFileContents("old/p/I.aidl",
3291 "package p; interface I {"
3292 "const int A = 1; const int B = 2;}");
3293 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003294 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003295 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003296 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003297}
Jiyong Parka428d212018-08-29 22:26:30 +09003298
Daniel Norman85aed542019-08-21 12:01:14 -07003299TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003300 const string expected_stderr =
3301 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003302 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3303 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003304 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003305 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003306 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003307}
3308
Devin Moorec7e47a32020-08-07 10:55:25 -07003309TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3310 const string expected_stderr =
3311 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3312 "This is an incompatible change for FixedSize types.\n";
3313 io_delegate_.SetFileContents("old/p/Foo.aidl",
3314 "package p; @FixedSize parcelable Foo { int A = 1; }");
3315 io_delegate_.SetFileContents("new/p/Foo.aidl",
3316 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3317 CaptureStderr();
3318 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3319 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3320}
3321
Jeongik Cha68d18e72021-04-29 20:07:01 +09003322TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3323 const string expected_stderr =
3324 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3325 "android.net.UidRangeParcel is changed from 1 to 2. "
3326 "But it is forbidden because of legacy support.\n";
3327 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3328 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3329 io_delegate_.SetFileContents(
3330 "new/android/net/UidRangeParcel.aidl",
3331 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3332 CaptureStderr();
3333 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3334 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3335}
3336
Devin Moorec7e47a32020-08-07 10:55:25 -07003337TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3338 const string expected_stderr =
3339 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3340 io_delegate_.SetFileContents("old/p/Foo.aidl",
3341 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3342 io_delegate_.SetFileContents("new/p/Foo.aidl",
3343 "package p; @FixedSize parcelable Foo { int A = 1; }");
3344 CaptureStderr();
3345 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3347}
3348
3349TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3350 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003351 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003352 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003353 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3354 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003355 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003356 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003357 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003358 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003359 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003360 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3361 "f.\n"
3362 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3363 "nullable1.\n"
3364 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3365 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003366
3367 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003368 "@FixedSize parcelable Foo {\n"
3369 " int[] a;\n"
3370 " Bar b;\n"
3371 " String c;\n"
3372 " ParcelFileDescriptor d;\n"
3373 " IBinder e;\n"
3374 " List<String> f;\n"
3375 " int isFixedSize;\n"
3376 " @nullable OtherFixed nullable1;\n"
3377 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003378 "}");
3379 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003380 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003381 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003382
3383 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003384 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003385 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3386}
3387
3388TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3389 const string expected_stderr = "";
3390
3391 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3392 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3393 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003394 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003395
3396 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003397 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3399}
3400
Jiyong Park8c380532018-08-30 14:55:26 +09003401TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003402 const string expected_stderr =
3403 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3404 "dir1/q/IBar.aidl\n"
3405 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003406 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003407 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3408 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3409 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3410 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3411
Devin Moore097a3ab2020-03-11 16:08:44 -07003412 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003413 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003415}
3416
Jiyong Parked65bf42018-08-28 15:43:27 +09003417TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003418 const string expected_stderr =
3419 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3420 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003421 Options options = Options::From("aidl --checkapi old new");
3422 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3423 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003424
3425 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3426
Jiyong Parke59c3682018-09-11 23:10:25 +09003427 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003428 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003429 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003430 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003431}
3432
Jooyung Han652ce482021-02-26 12:40:35 +09003433TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3434 Options options =
3435 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003436
3437 // use without import
3438 io_delegate_.SetFileContents("p/IFoo.aidl",
3439 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003440 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003441
3442 // capture output files
3443 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003444
Devin Moore7b8d5c92020-03-17 14:14:08 -07003445 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003446 io_delegate_.SetFileContents(
3447 "p/IFoo.aidl",
3448 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003449 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003450 // output files should be the same
3451 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003452
3453 // use with import (as before)
3454 io_delegate_.SetFileContents("p/IFoo.aidl",
3455 "package p;"
3456 "import android.os.ParcelFileDescriptor;"
3457 "interface IFoo{"
3458 " void foo(in ParcelFileDescriptor fd);"
3459 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003460 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003461 // output files should be the same
3462 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003463}
Jiyong Parked65bf42018-08-28 15:43:27 +09003464
Jooyung Han020d8d12021-02-26 17:23:02 +09003465TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3466 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3467 CaptureStderr();
3468 io_delegate_.SetFileContents("p/IFoo.aidl",
3469 "package p;"
3470 "interface IFoo{"
3471 " void foo(out ParcelFileDescriptor fd);"
3472 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003473 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003474 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3475}
3476
3477TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3478 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3479 CaptureStderr();
3480 io_delegate_.SetFileContents("p/IFoo.aidl",
3481 "package p;"
3482 "interface IFoo{"
3483 " void foo(ParcelFileDescriptor fd);"
3484 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003485 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003486 EXPECT_THAT(GetCapturedStderr(),
3487 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3488}
3489
Jiyong Park3633b722019-04-11 15:38:26 +09003490TEST_F(AidlTest, ManualIds) {
3491 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3492 io_delegate_.SetFileContents("IFoo.aidl",
3493 "interface IFoo {\n"
3494 " void foo() = 0;\n"
3495 " void bar() = 1;\n"
3496 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003497 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003498}
3499
3500TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3501 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3502 io_delegate_.SetFileContents("IFoo.aidl",
3503 "interface IFoo {\n"
3504 " void foo() = 0;\n"
3505 " void bar() = 1;\n"
3506 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003507 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003508}
3509
3510TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003511 const string expected_stderr =
3512 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003513 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3514 io_delegate_.SetFileContents("IFoo.aidl",
3515 "interface IFoo {\n"
3516 " void foo() = 3;\n"
3517 " void bar() = 3;\n"
3518 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003519 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003520 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003522}
3523
3524TEST_F(AidlTest, FailOnOutOfRangeIds) {
3525 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003526 const string expected_stderr =
3527 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3528 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003529 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3530 io_delegate_.SetFileContents("IFoo.aidl",
3531 "interface IFoo {\n"
3532 " void foo() = 3;\n"
3533 " void bar() = 16777115;\n"
3534 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003535 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003536 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003537 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003538}
3539
3540TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003541 const string expected_stderr =
3542 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003543 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3544 io_delegate_.SetFileContents("IFoo.aidl",
3545 "interface IFoo {\n"
3546 " void foo() = 3;\n"
3547 " void bar();\n"
3548 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003549 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003550 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003552}
3553
Jiyong Parkc6816252019-07-08 08:12:28 +09003554TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3555 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3556 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3557 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003558 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003559}
3560
3561TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003562 const string expected_stderr =
3563 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3564 "dir/IBar.aidl\n"
3565 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003566 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003567
Jiyong Parkc6816252019-07-08 08:12:28 +09003568 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3569 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3570 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3571 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003572 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003573 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003574 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003575}
3576
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003577TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3578 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3579 "package a.b;\n"
3580 "import a.b.IBar;\n"
3581 "import a.b.IQux;\n"
3582 "interface IFoo { IQux foo(); }\n");
3583 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3584 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3585
3586 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003587 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003588
3589 string output;
3590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3591 // IBar was imported but wasn't used. include is not expected.
3592 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3593 // IBar was imported and used. include is expected.
3594 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3595}
3596
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003597TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003598 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003599 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003600 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3601 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003602 interface IFoo {
3603 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003604 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003605 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003606 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003607 // JavaPassthrough should work with other types as well (e.g. enum)
3608 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3609 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3610 @JavaPassthrough(annotation="@com.android.AliceTwo")
3611 @Backing(type="byte")
3612 enum MyEnum {
3613 a, b, c
3614 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003615
Jooyung Han4cde01d2020-10-13 11:10:47 +09003616 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003617 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003618
3619 string java_out;
3620 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003621 // type-decl-level annotations with newline at the end
3622 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3623 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3624 // member-decl-level annotations with newline at the end
3625 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3626 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3627 // inline annotations with space at the end
3628 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003629
Jooyung Han4cde01d2020-10-13 11:10:47 +09003630 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3631 // type-decl-level annotations with newline at the end
3632 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3633 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3634
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003635 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003636 Options cpp_options =
3637 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003638 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003639
Jooyung Han4cde01d2020-10-13 11:10:47 +09003640 Options ndk_options =
3641 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003642 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003643
Jooyung Han4cde01d2020-10-13 11:10:47 +09003644 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003645 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003646}
3647
Andrei Homescue61feb52020-08-18 15:44:24 -07003648TEST_F(AidlTest, ParseRustDerive) {
3649 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3650 @RustDerive(Clone=true, Copy=false)
3651 parcelable Foo {
3652 int a;
3653 })");
3654
3655 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003656 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003657
3658 string rust_out;
3659 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3660 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3661
3662 // Other backends shouldn't be bothered
3663 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003664 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003665
3666 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003667 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003668
3669 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003670 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003671}
3672
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003673TEST_F(AidlTest, EmptyEnforceAnnotation) {
3674 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3675 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3676 interface IFoo {
3677 @Enforce()
3678 void Protected();
3679 })");
3680
3681 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3682 CaptureStderr();
3683 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3684 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3685}
3686
3687TEST_F(AidlTest, EmptyEnforceCondition) {
3688 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3689 interface IFoo {
3690 @Enforce(condition="")
3691 void Protected();
3692 })");
3693
3694 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3695 CaptureStderr();
3696 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3697 EXPECT_THAT(GetCapturedStderr(),
3698 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3699}
3700
3701TEST_F(AidlTest, InvalidEnforceCondition) {
3702 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3703 interface IFoo {
3704 @Enforce(condition="invalid")
3705 void Protected();
3706 })");
3707
3708 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3709 CaptureStderr();
3710 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3711 EXPECT_THAT(GetCapturedStderr(),
3712 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3713}
3714
Jiyong Park56f73d72019-06-11 12:20:28 +09003715class AidlOutputPathTest : public AidlTest {
3716 protected:
3717 void SetUp() override {
3718 AidlTest::SetUp();
3719 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3720 }
3721
3722 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003723 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003724 // check the existence
3725 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3726 }
3727};
3728
3729TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3730 // <out_dir> / <package_name> / <type_name>.java
3731 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3732}
3733
3734TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3735 // when output file is explicitly set, it is always respected. -o option is
3736 // ignored.
3737 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3738}
3739
3740TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3741 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3742}
3743
3744TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3745 // output is the same as the input file except for the suffix
3746 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3747}
3748
Devin Moore7b8d5c92020-03-17 14:14:08 -07003749TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003750 AidlError error;
3751 const string expected_stderr =
3752 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3753 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003754 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3755 R"(package p;
3756 interface IFoo {
3757 const int int32_max_oob = 2147483650;
3758 }
3759 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003760 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003761 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3762 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003763}
3764
Devin Moore7b8d5c92020-03-17 14:14:08 -07003765TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003766 AidlError error;
3767 const string expected_stderr =
3768 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3769 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003770 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3771 R"(package p;
3772 interface IFoo {
3773 const int int32_min_oob = -2147483650;
3774 }
3775 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003776 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003777 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3778 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003779}
3780
Devin Moore7b8d5c92020-03-17 14:14:08 -07003781TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003782 AidlError error;
3783 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003784 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003785 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003786 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3787 R"(package p;
3788 interface IFoo {
3789 const long int64_max_oob = 21474836509999999999999999;
3790 }
3791 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003792 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003793 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3794 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003795}
3796
Devin Moore7b8d5c92020-03-17 14:14:08 -07003797TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003798 AidlError error;
3799 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003800 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003801 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003802 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3803 R"(package p;
3804 interface IFoo {
3805 const long int64_min_oob = -21474836509999999999999999;
3806 }
3807 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003808 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003809 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3810 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003811}
3812
Devin Moore7b8d5c92020-03-17 14:14:08 -07003813TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003814 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003815 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003816 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003817 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3818 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003819 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3820 R"(package p;
3821 @Backing(type="byte")
3822 enum TestEnum {
3823 FOO = 127,
3824 BAR,
3825 }
3826 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003827 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003828 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003829 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003830}
3831
Devin Mooredecaf292020-04-30 09:16:40 -07003832TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3833 AidlError error;
3834 const string expected_stderr =
3835 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003836 "be one of: type\n";
3837 CaptureStderr();
3838 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3839 R"(package p;
3840 @Backing(foo="byte")
3841 enum TestEnum {
3842 FOO = 1,
3843 BAR,
3844 }
3845 )",
3846 typenames_, GetLanguage(), &error));
3847 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3848 EXPECT_EQ(AidlError::BAD_TYPE, error);
3849}
3850
Jooyung Han5721a232020-12-24 04:34:55 +09003851TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3852 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3853 CaptureStderr();
3854 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3855 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3856}
3857
Jooyung Han66813932020-10-23 13:24:44 +09003858TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003859 io_delegate_.SetFileContents("Foo.aidl",
3860 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3861 "Map<String, Baz> d; Bar[] e; }");
3862 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3863 io_delegate_.SetFileContents("Baz.aidl",
3864 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003865 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003866 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003867}
3868
Jooyung Han66813932020-10-23 13:24:44 +09003869TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003870 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003871 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003872 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003873 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3874 "named 'bar'.\n";
3875 CaptureStderr();
3876 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003877 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003878 EXPECT_EQ(expected_error, GetCapturedStderr());
3879}
3880
Jooyung Han09e551c2021-05-11 11:44:48 +09003881TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3882 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3883 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3884 CaptureStderr();
3885 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003886 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003887 EXPECT_EQ("", GetCapturedStderr());
3888}
3889
Jooyung Han59af9cc2020-10-25 21:44:14 +09003890TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3891 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3892 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3893 string expected_error =
3894 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003895 "named 'bar'.\n";
3896 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003897 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003898 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003899 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003900}
3901
Jooyung Han66813932020-10-23 13:24:44 +09003902TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003903 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003904 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3905 string expected_error =
3906 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3907 "only be an in parameter.\n";
3908 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003909 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003910 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003911 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003912}
3913
Jooyung Han66813932020-10-23 13:24:44 +09003914TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003915 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003916 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3917 string expected_error =
3918 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3919 "only be an in parameter.\n";
3920 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003921 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003922 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003923 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003924}
3925
Jooyung Han66813932020-10-23 13:24:44 +09003926TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003927 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003928 Options options = Options::From("aidl --lang=java Foo.aidl");
3929 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003930 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3931 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003932 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003933 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003934 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3935}
Devin Moore53fc99c2020-08-12 08:07:52 -07003936
Jooyung Hanfe086af2021-01-16 03:44:47 +09003937TEST_P(AidlTest, UnionInUnion) {
3938 import_paths_.insert(".");
3939 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3940 CaptureStderr();
3941 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3942 EXPECT_THAT("", GetCapturedStderr());
3943}
3944
Jooyung Hanfe89f122020-10-14 03:49:18 +09003945TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3946 const string method = "package a; union Foo {}";
3947 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3948 CaptureStderr();
3949 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3950 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3951}
3952
3953TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3954 const string method = "package a; union Foo { ParcelableHolder x; }";
3955 const string expected_stderr =
3956 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3957 CaptureStderr();
3958 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3959 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3960}
3961
Jooyung Han53fb4242020-12-17 16:03:49 +09003962TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3963 import_paths_.insert(".");
3964 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3965 const string expected_err = "The union's first member should have a useful default value.";
3966 CaptureStderr();
3967 EXPECT_EQ(nullptr,
3968 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3969 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3970}
3971
Devin Moore53fc99c2020-08-12 08:07:52 -07003972TEST_P(AidlTest, GenericStructuredParcelable) {
3973 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003974 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003975 const string expected_stderr = "";
3976 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003977 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3979}
3980
Jooyung Han3f347ca2020-12-01 12:41:50 +09003981TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3982 io_delegate_.SetFileContents("Foo.aidl",
3983 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3984 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003985 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003986 const string expected_stderr = "";
3987 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003988 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3990
3991 string code;
3992 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3993 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3994const ::android::String16& Foo<T,U>::s() {
3995 static const ::android::String16 value(::android::String16(""));
3996 return value;
3997})--"));
3998}
3999
4000TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4001 io_delegate_.SetFileContents("Foo.aidl",
4002 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4003 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004004 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004005 const string expected_stderr = "";
4006 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004007 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004008 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4009
4010 string code;
4011 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4012 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4013const char* Foo<T, U>::s = "";
4014)--"));
4015}
4016
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004017TEST_F(AidlTest, NestedTypeArgs) {
4018 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004019 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4020
4021 io_delegate_.SetFileContents("a/Foo.aidl",
4022 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4023 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004024 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4025 const string expected_stderr = "";
4026 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004027 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004028 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4029
4030 string code;
4031 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004032 EXPECT_THAT(code,
4033 testing::HasSubstr(
4034 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4035}
4036
4037TEST_F(AidlTest, DoubleArrayError) {
4038 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4039
4040 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4041 const string expected_stderr =
4042 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4043 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004044 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004045 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4046}
4047
4048TEST_F(AidlTest, DoubleGenericError) {
4049 io_delegate_.SetFileContents("a/Bar.aidl",
4050 "package a; parcelable Bar { List<String><String> a; }");
4051
4052 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4053 const string expected_stderr =
4054 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4055 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004056 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004057 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4058}
4059
4060TEST_F(AidlTest, ArrayBeforeGenericError) {
4061 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4062
4063 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004064 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004065 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004066 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4067}
4068
4069TEST_F(AidlTest, NullableArraysAreNotSupported) {
4070 io_delegate_.SetFileContents("a/Bar.aidl",
4071 "package a; parcelable Bar { String @nullable [] a; }");
4072
4073 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4074 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004075 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004076 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4077}
4078
4079TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4080 io_delegate_.SetFileContents("a/Bar.aidl",
4081 "package a; parcelable Bar { List<@nullable String> a; }");
4082
4083 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4084 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004085 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004086 EXPECT_THAT(GetCapturedStderr(),
4087 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004088}
4089
Jooyung Han14004ed2020-10-16 03:49:57 +09004090struct GenericAidlTest : ::testing::Test {
4091 FakeIoDelegate io_delegate_;
4092 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004093 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004094 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4095 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4096 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4097
4098 Options options = Options::From(cmd);
4099 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004100 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004101 EXPECT_EQ("", GetCapturedStderr());
4102 }
4103};
4104
4105TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4106 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4107 string code;
4108 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4109 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4110 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4111 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4112}
4113
4114TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4115 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4116 string code;
4117 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4118 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4119 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4120 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4121}
4122
Devin Moore53fc99c2020-08-12 08:07:52 -07004123TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4124 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004125 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004126 const string expected_stderr =
4127 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4128 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004129 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004130 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4131}
4132
4133TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4134 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004135 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004136 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4137 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004138 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004139 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4140}
4141
Jooyung Han7a308842020-10-27 19:06:49 +09004142TEST_P(AidlTest, LongCommentWithinConstExpression) {
4143 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004144 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004145 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004146 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004147 EXPECT_EQ("", GetCapturedStderr());
4148}
4149
Jeongik Chaef44e622020-10-23 16:00:52 +09004150TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4151 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4152 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4153 std::string expectedErr =
4154 "ERROR: a/Foo.aidl:1.28-30: "
4155 "Encountered an untyped List or Map. The use of untyped List/Map is "
4156 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4157 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4158 "ERROR: a/Foo.aidl:1.35-37: "
4159 "Encountered an untyped List or Map. The use of untyped List/Map is "
4160 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4161 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4162 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004163 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004164 EXPECT_EQ(expectedErr, GetCapturedStderr());
4165}
4166
4167TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004168 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4169 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004170 std::string expectedErr =
4171 "ERROR: a/Foo.aidl:1.33-35: "
4172 "Encountered an untyped List or Map. The use of untyped List/Map is "
4173 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4174 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4175 "ERROR: a/Foo.aidl:1.40-42: "
4176 "Encountered an untyped List or Map. The use of untyped List/Map is "
4177 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4178 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004179 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004180 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004181 EXPECT_EQ(expectedErr, GetCapturedStderr());
4182}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004183
Jeongik Chaef44e622020-10-23 16:00:52 +09004184TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4185 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4186 io_delegate_.SetFileContents(
4187 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4188 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4189 std::string expectedErr =
4190 "ERROR: a/Foo.aidl:1.52-54: "
4191 "Encountered an untyped List or Map. The use of untyped List/Map is "
4192 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4193 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4194 "ERROR: a/Foo.aidl:1.64-66: "
4195 "Encountered an untyped List or Map. The use of untyped List/Map is "
4196 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4197 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4198 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004199 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004200 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004201}
4202
Jooyung Han690f5842020-12-04 13:02:04 +09004203TEST_F(AidlTest, EnumWithDefaults_Java) {
4204 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4205 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4206package p;
4207import p.Enum;
4208parcelable Foo {
4209 Enum e = Enum.BAR;
4210})");
4211 CaptureStderr();
4212 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004213 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004214 auto err = GetCapturedStderr();
4215 EXPECT_EQ("", err);
4216
4217 string code;
4218 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004219 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004220}
4221
4222TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4223 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4224 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4225package p;
4226import p.Enum;
4227parcelable Foo {
4228 Enum e = Enum.BAR;
4229})");
4230 CaptureStderr();
4231 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004232 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004233 auto err = GetCapturedStderr();
4234 EXPECT_EQ("", err);
4235
4236 string code;
4237 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4238 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4239}
4240
4241TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4242 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4243 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4244package p;
4245import p.Enum;
4246parcelable Foo {
4247 Enum e = Enum.BAR;
4248})");
4249 CaptureStderr();
4250 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004251 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004252 auto err = GetCapturedStderr();
4253 EXPECT_EQ("", err);
4254
4255 string code;
4256 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4257 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4258}
4259
4260TEST_F(AidlTest, EnumWithDefaults_Rust) {
4261 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4262 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4263package p;
4264import p.Enum;
4265parcelable Foo {
4266 int n = 42;
4267 Enum e = Enum.BAR;
4268})");
4269 CaptureStderr();
4270 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004272 auto err = GetCapturedStderr();
4273 EXPECT_EQ("", err);
4274
4275 string code;
4276 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4277 EXPECT_THAT(code, testing::HasSubstr(R"(
4278 fn default() -> Self {
4279 Self {
4280 n: 42,
4281 e: crate::mangled::_1_p_4_Enum::BAR,
4282 }
4283 })"));
4284}
4285
4286TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4287 import_paths_.insert("a");
4288 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4289 CaptureStderr();
4290 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4291package p;
4292import p.Enum;
4293parcelable Foo {
4294 int e = Enum.FOO | Enum.BAR;
4295})",
4296 typenames_, GetLanguage());
4297 auto err = GetCapturedStderr();
4298 EXPECT_EQ("", err);
4299 EXPECT_TRUE(type);
4300 const auto& fields = type->AsStructuredParcelable()->GetFields();
4301 EXPECT_EQ("int e = 3", fields[0]->ToString());
4302}
4303
4304TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4305 CaptureStderr();
4306 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4307@Backing(type="int")
4308enum Foo {
4309 STANDARD_SHIFT = 16,
4310 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4311 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4312}
4313)",
4314 typenames_, GetLanguage());
4315 auto err = GetCapturedStderr();
4316 EXPECT_EQ("", err);
4317 EXPECT_TRUE(type);
4318 const auto& enum_type = type->AsEnumDeclaration();
4319 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004320 auto writer = CodeWriter::ForString(&code);
4321 DumpVisitor visitor(*writer);
4322 visitor.Visit(*enum_type);
4323 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004324 EXPECT_EQ(R"--(@Backing(type="int")
4325enum Foo {
4326 STANDARD_SHIFT = 16,
4327 STANDARD_BT709 = 65536,
4328 STANDARD_BT601_625 = 131072,
4329}
4330)--",
4331 code);
4332}
4333
4334TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4335 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4336 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4337package p;
4338import p.Enum;
4339parcelable Foo {
4340 Enum e = Enum.FOO | Enum.BAR;
4341})");
4342 CaptureStderr();
4343 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004344 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004345 auto err = GetCapturedStderr();
4346 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4347 err);
4348}
4349
Jooyung Han361cd102021-05-24 11:30:10 +09004350TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4351 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4352 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4353package p;
4354import p.Enum;
4355parcelable Foo {
4356 Enum e = 1;
4357})");
4358 CaptureStderr();
4359 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004360 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004361 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4362}
4363
Jooyung Han690f5842020-12-04 13:02:04 +09004364TEST_P(AidlTest, DefaultWithEmptyArray) {
4365 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4366 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4367 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004368 auto options =
4369 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004370 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004371 auto err = GetCapturedStderr();
4372 EXPECT_EQ("", err);
4373}
4374
4375TEST_P(AidlTest, RejectRefsInAnnotation) {
4376 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4377 "package p; interface IFoo {\n"
4378 " const String ANNOTATION = \"@Annotation\";\n"
4379 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4380 "}");
4381 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004382 auto options =
4383 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004384 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004385 auto err = GetCapturedStderr();
4386 EXPECT_EQ(
4387 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4388 "ANNOTATION.\n",
4389 err);
4390}
4391
4392TEST_F(AidlTest, DefaultWithEnumValues) {
4393 io_delegate_.SetFileContents(
4394 "a/p/Foo.aidl",
4395 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4396 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4397 CaptureStderr();
4398 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004399 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004400 auto err = GetCapturedStderr();
4401 EXPECT_EQ("", err);
4402 string code;
4403 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4404 EXPECT_THAT(
4405 code, testing::HasSubstr(
4406 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4407}
4408
Jooyung Han14259392020-12-07 10:00:08 +09004409TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4410 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4411 CaptureStderr();
4412 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004413 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004414 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004415 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004416}
4417
4418TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4419 io_delegate_.SetFileContents("a/p/Foo.aidl",
4420 "package p; parcelable Foo { const int A = A + 1; }");
4421 CaptureStderr();
4422 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004423 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004424 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004425 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4426}
4427
4428TEST_F(AidlTest, RecursiveReferences) {
4429 io_delegate_.SetFileContents("a/p/Foo.aidl",
4430 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4431 io_delegate_.SetFileContents("a/p/Bar.aidl",
4432 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4433 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4434 CaptureStderr();
4435 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004436 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004437 EXPECT_EQ("", GetCapturedStderr());
4438}
4439
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004440TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4441 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4442 auto options =
4443 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4444 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4445 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004446 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004447 EXPECT_EQ(err, GetCapturedStderr());
4448}
4449
4450TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4451 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4452 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4453 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4454 auto options =
4455 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4456 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004457 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004458 EXPECT_EQ("", GetCapturedStderr());
4459}
4460
Jooyung Hane9f5b272021-01-07 00:18:11 +09004461TEST_P(AidlTest, UnknownConstReference) {
4462 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4463 auto options =
4464 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4465 const string err =
4466 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4467 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4468 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4469 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004470 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004471 EXPECT_EQ(err, GetCapturedStderr());
4472}
4473
Jooyung Han29813842020-12-08 01:28:03 +09004474TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4475 string contents = R"(
4476import android.os.IBinder;
4477import android.os.IInterface;
4478interface IFoo {}
4479 )";
4480 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004481}
4482
Jooyung Han888c5bc2020-12-22 17:28:47 +09004483TEST_P(AidlTest, WarningInterfaceName) {
4484 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004485 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004486 " -Weverything -o out -h out p/Foo.aidl");
4487 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004488 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004489 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004490 GetCapturedStderr());
4491}
4492
4493TEST_P(AidlTest, ErrorInterfaceName) {
4494 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004495 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004496 " -Weverything -Werror -o out -h out p/Foo.aidl");
4497 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004498 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004499 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004500 GetCapturedStderr());
4501}
4502
Jiyong Park9f4c3822021-04-07 20:36:45 +09004503TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4504 const std::string input_file = "base/p/q/IFoo.aidl";
4505 const std::string header_dir = "out/";
4506 const std::string output_file = "out/base/p/q/IFoo.cpp";
4507 const std::string package = "p.q"; // not base.p.q
4508 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4509
4510 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4511 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004512 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004513 EXPECT_THAT(
4514 GetCapturedStderr(),
4515 testing::StartsWith(
4516 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4517 "but is out/base/p/q/IFoo.cpp."));
4518}
4519
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004520TEST_F(AidlTest, FormatCommentsForJava) {
4521 using android::aidl::FormatCommentsForJava;
4522
4523 struct TestCase {
4524 vector<Comment> comments;
4525 string formatted;
4526 };
4527 vector<TestCase> testcases = {
4528 {{}, ""},
4529 {{{"// line comments\n"}}, "// line comments\n"},
4530 {{{"// @hide \n"}}, "// @hide \n"},
4531 // Transform the last block comment as Javadoc.
4532 {{{"/*\n"
4533 " * Hello, world!\n"
4534 " */"}},
4535 "/**\n"
4536 " * Hello, world!\n"
4537 " */"},
4538 {{{"/* @hide */"}}, "/** @hide */"},
4539 {{{"/**\n"
4540 " @param foo ...\n"
4541 "*/"}},
4542 "/**\n"
4543 " @param foo ...\n"
4544 "*/"},
4545 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4546 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4547 "/* @deprecated first *//** @deprecated second */"},
4548 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4549 // Line comments are printed as they are
4550 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4551 };
4552 for (const auto& [input, formatted] : testcases) {
4553 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4554 }
4555}
4556
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004557TEST_F(AidlTest, HideIsNotForArgs) {
4558 io_delegate_.SetFileContents("IFoo.aidl",
4559 "interface IFoo {\n"
4560 " void foo(in @Hide int x);\n"
4561 "}");
4562 auto options = Options::From("aidl --lang=java IFoo.aidl");
4563 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004564 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004565 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4566}
4567
4568TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4569 io_delegate_.SetFileContents(
4570 "IFoo.aidl",
4571 "interface IFoo {\n"
4572 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4573 "}");
4574 auto options = Options::From("aidl --lang=java IFoo.aidl");
4575 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004576 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004577 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4578}
4579
Jooyung Hanfa181932021-06-12 07:56:53 +09004580TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4581 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4582 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4583 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004584 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004585 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4586}
4587
Jooyung Hanfd3be322020-12-13 09:11:06 +09004588struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004589 string kind;
4590 string literal;
4591};
4592
Jooyung Hanfd3be322020-12-13 09:11:06 +09004593const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004594 {"primitive", "int"}, {"primitiveArray", "int[]"},
4595 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004596 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4597 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4598 {"union", "a.Union"}, {"interface", "a.IBar"},
4599};
4600
4601const std::map<std::string, std::string> kListSupportExpectations = {
4602 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4603 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4604 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4605 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004606 {"cpp_primitiveArray", "List of arrays is not supported."},
4607 {"java_primitiveArray", "List of arrays is not supported."},
4608 {"ndk_primitiveArray", "List of arrays is not supported."},
4609 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004610 {"cpp_String", ""},
4611 {"java_String", ""},
4612 {"ndk_String", ""},
4613 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004614 {"cpp_StringArray", "List of arrays is not supported."},
4615 {"java_StringArray", "List of arrays is not supported."},
4616 {"ndk_StringArray", "List of arrays is not supported."},
4617 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004618 {"cpp_IBinder", ""},
4619 {"java_IBinder", ""},
4620 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4621 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004622 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004623 {"java_ParcelFileDescriptor", ""},
4624 {"ndk_ParcelFileDescriptor", ""},
4625 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004626 {"cpp_interface", "List<a.IBar> is not supported."},
4627 {"java_interface", "List<a.IBar> is not supported."},
4628 {"ndk_interface", "List<a.IBar> is not supported."},
4629 {"rust_interface", "List<a.IBar> is not supported."},
4630 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004631 {"java_parcelable", ""},
4632 {"ndk_parcelable", ""},
4633 {"rust_parcelable", ""},
4634 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4635 {"java_enum", "A generic type cannot have any primitive type parameters."},
4636 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4637 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004638 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004639 {"java_union", ""},
4640 {"ndk_union", ""},
4641 {"rust_union", ""},
4642};
4643
Jooyung Hand236e552020-12-13 09:21:27 +09004644const std::map<std::string, std::string> kArraySupportExpectations = {
4645 {"cpp_primitive", ""},
4646 {"java_primitive", ""},
4647 {"ndk_primitive", ""},
4648 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004649 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4650 {"java_primitiveArray", "Can only have one dimensional arrays."},
4651 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4652 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004653 {"cpp_String", ""},
4654 {"java_String", ""},
4655 {"ndk_String", ""},
4656 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004657 {"cpp_StringArray", "Can only have one dimensional arrays."},
4658 {"java_StringArray", "Can only have one dimensional arrays."},
4659 {"ndk_StringArray", "Can only have one dimensional arrays."},
4660 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004661 {"cpp_IBinder", ""},
4662 {"java_IBinder", ""},
4663 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4664 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4665 {"cpp_ParcelFileDescriptor", ""},
4666 {"java_ParcelFileDescriptor", ""},
4667 {"ndk_ParcelFileDescriptor", ""},
4668 {"rust_ParcelFileDescriptor", ""},
4669 {"cpp_interface", "Binder type cannot be an array"},
4670 {"java_interface", "Binder type cannot be an array"},
4671 {"ndk_interface", "Binder type cannot be an array"},
4672 {"rust_interface", "Binder type cannot be an array"},
4673 {"cpp_parcelable", ""},
4674 {"java_parcelable", ""},
4675 {"ndk_parcelable", ""},
4676 {"rust_parcelable", ""},
4677 {"cpp_enum", ""},
4678 {"java_enum", ""},
4679 {"ndk_enum", ""},
4680 {"rust_enum", ""},
4681 {"cpp_union", ""},
4682 {"java_union", ""},
4683 {"ndk_union", ""},
4684 {"rust_union", ""},
4685};
4686
Jooyung Hanfd3be322020-12-13 09:11:06 +09004687class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004688 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004689 void Run(const std::string& generic_type_decl,
4690 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004691 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004692 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004693 const auto& kind = std::get<1>(param).kind;
4694
4695 FakeIoDelegate io;
4696 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4697 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4698 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004699 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4700 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004701
4702 const auto options =
4703 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4704 CaptureStderr();
4705 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004706 auto it = expectations.find(lang + "_" + kind);
4707 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004708 const string err = GetCapturedStderr();
4709 if (it->second.empty()) {
4710 EXPECT_EQ("", err);
4711 } else {
4712 EXPECT_THAT(err, testing::HasSubstr(it->second));
4713 }
4714 }
4715};
4716
4717INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004718 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004719 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4720 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004721 testing::ValuesIn(kTypeParams)),
4722 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004723 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004724 });
4725
Jooyung Hanfd3be322020-12-13 09:11:06 +09004726TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4727 Run("List<{}>", kListSupportExpectations);
4728}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004729
Jooyung Hand236e552020-12-13 09:21:27 +09004730TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4731 Run("{}[]", kArraySupportExpectations);
4732}
4733
Christopher Wiley90be4e32015-10-20 14:55:25 -07004734} // namespace aidl
4735} // namespace android