blob: d2092ba2c34c5a0b18956aa515feb06f0acc133f [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Christopher Wiley90be4e32015-10-20 14:55:25 -070017#include <memory>
Christopher Wiley12e894a2016-01-29 11:55:07 -080018#include <set>
19#include <string>
Christopher Wiley90be4e32015-10-20 14:55:25 -070020#include <vector>
21
Christopher Wileyec31a052016-01-25 07:28:51 -080022#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090023#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070024#include <gtest/gtest.h>
25
26#include "aidl.h"
Steven Moreland49585242019-12-18 16:06:49 -080027#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070028#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070029#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090030#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090031#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070034
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090035using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070036using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080037using android::base::StringPrintf;
Christopher Wiley12e894a2016-01-29 11:55:07 -080038using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using std::string;
40using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070042using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090043using testing::internal::CaptureStderr;
44using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045
46namespace android {
47namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070048namespace {
49
50const char kExpectedDepFileContents[] =
51R"(place/for/output/p/IFoo.java : \
52 p/IFoo.aidl
53
54p/IFoo.aidl :
55)";
56
Dan Willemsen93298ee2016-11-10 23:55:55 -080057const char kExpectedNinjaDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60)";
61
Jiyong Parkdf202122019-09-30 20:48:35 +090062const char kExpectedParcelableDeclarationDepFileContents[] =
63 R"( : \
64 p/Foo.aidl
65
66p/Foo.aidl :
67)";
68
69const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080070 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070071 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
Jiyong Parkd4e73c82019-07-24 21:39:15 +090076const char kExpectedJavaParcelableOutputContests[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090077 R"(/*
78 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090079 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080080@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081public class Rect implements android.os.Parcelable
82{
83 // Comment
84
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080085 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090086 public int x = 5;
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
89 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000090 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090091
92 public android.os.ParcelFileDescriptor fd;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090093 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
94 @Override
95 public Rect createFromParcel(android.os.Parcel _aidl_source) {
96 Rect _aidl_out = new Rect();
97 _aidl_out.readFromParcel(_aidl_source);
98 return _aidl_out;
99 }
100 @Override
101 public Rect[] newArray(int _aidl_size) {
102 return new Rect[_aidl_size];
103 }
104 };
105 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
106 {
107 int _aidl_start_pos = _aidl_parcel.dataPosition();
108 _aidl_parcel.writeInt(0);
109 _aidl_parcel.writeInt(x);
110 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900111 if ((fd!=null)) {
112 _aidl_parcel.writeInt(1);
113 fd.writeToParcel(_aidl_parcel, 0);
114 }
115 else {
116 _aidl_parcel.writeInt(0);
117 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900118 int _aidl_end_pos = _aidl_parcel.dataPosition();
119 _aidl_parcel.setDataPosition(_aidl_start_pos);
120 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
121 _aidl_parcel.setDataPosition(_aidl_end_pos);
122 }
123 public final void readFromParcel(android.os.Parcel _aidl_parcel)
124 {
125 int _aidl_start_pos = _aidl_parcel.dataPosition();
126 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900127 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900128 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900129 x = _aidl_parcel.readInt();
130 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
131 y = _aidl_parcel.readInt();
132 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900133 if ((0!=_aidl_parcel.readInt())) {
134 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
135 }
136 else {
137 fd = null;
138 }
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900140 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900141 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
142 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
143 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900144 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
145 }
146 }
147 @Override public int describeContents()
148 {
Jeongik Cha372a8c82018-12-12 16:31:11 +0900149 return 0;
150 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900151}
152)";
153
Devin Moore2f2077a2020-08-28 11:27:53 -0700154// clang-format off
155const char kExpectedCppHeaderOutput[] =
156 R"(#pragma once
157
158#include <binder/IBinder.h>
159#include <binder/IInterface.h>
160#include <binder/Status.h>
161#include <optional>
162#include <utils/String16.h>
163#include <utils/StrongPointer.h>
164#include <vector>
165
166class IFoo : public ::android::IInterface {
167public:
168 DECLARE_META_INTERFACE(Foo)
169 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
170}; // class IFoo
171class IFooDefault : public IFoo {
172public:
173 ::android::IBinder* onAsBinder() override {
174 return nullptr;
175 }
176 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
177 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
178 }
179}; // class IFooDefault
180)";
181// clang-format on
182
Christopher Wileyf8136192016-04-12 14:19:35 -0700183} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700186 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900187 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
188 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700189 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900191 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700192 args.emplace_back("aidl");
193 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700194 for (const string& s : additional_arguments) {
195 args.emplace_back(s);
196 }
197 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900198 args.emplace_back("--preprocessed=" + f);
199 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700200 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900201 args.emplace_back("--include=" + i);
202 }
203 args.emplace_back(path);
204 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900205 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900206 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700207 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900208 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900209
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700210 if (error != nullptr) {
211 *error = actual_error;
212 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900213
214 if (actual_error != AidlError::OK) {
215 return nullptr;
216 }
217
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900218 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900219 EXPECT_EQ(1ul, defined_types.size());
220
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900221 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700222 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700223
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224 Options::Language GetLanguage() { return GetParam(); }
225
Christopher Wiley0522cd52015-10-28 15:39:44 -0700226 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800227 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900228 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900229 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700230};
231
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
233// tests with each of the supported languages as a parameter.
234INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
235 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700236 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700237 [](const testing::TestParamInfo<Options::Language>& info) {
238 return Options::LanguageToString(info.param);
239 });
240
241TEST_P(AidlTest, AcceptMissingPackage) {
242 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, EndsInSingleLineComment) {
246 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700247}
248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900250 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 io_delegate_.SetFileContents("bar/IBar.aidl",
252 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700253 const string path = "foo/IFoo.aidl";
254 const string contents =
255 "package foo;\n"
256 "import bar.IBar;\n"
257 "interface IFoo { void f(in IBar[] input); }";
258 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
259 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700260 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700261 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700262}
263
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700265 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700266 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900267}
Devin Moore097a3ab2020-03-11 16:08:44 -0700268
Jiyong Park40782d02020-07-24 19:17:43 +0900269TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700270 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
271 const string expected_ibinder_stderr =
272 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
273 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700274 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700275 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900276}
277
Jiyong Park40782d02020-07-24 19:17:43 +0900278TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700279 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
280 const string expected_stderr =
281 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700282 CaptureStderr();
283 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900285}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700286
Jiyong Park40782d02020-07-24 19:17:43 +0900287TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700288 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900289 const string expected_stderr =
290 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700291 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700294}
295
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700297 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
298 const string expected_stderr =
299 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
300 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700303}
304
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700306 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
307 const string expected_stderr =
308 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
309 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800312}
313
Devin Moore2f2077a2020-08-28 11:27:53 -0700314TEST_P(AidlTest, AcceptNullableList) {
315 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
316 const string expected_stderr = "";
317 CaptureStderr();
318 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
319 EXPECT_EQ(expected_stderr, GetCapturedStderr());
320}
321
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 const string method = "package a; interface IFoo { void f(int a, int a); }";
324 const string expected_stderr =
325 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
326 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700328 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700329}
330
Jeongik Cha13066da2020-08-06 15:43:19 +0900331TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
332 const string method = "package a; parcelable Foo { int a; String a; }";
333 const string expected_stderr =
334 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
335 CaptureStderr();
336 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
337 EXPECT_EQ(expected_stderr, GetCapturedStderr());
338}
339
Devin Moore7b8d5c92020-03-17 14:14:08 -0700340TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
342 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
343 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100346}
347
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700349 AidlError error;
350 const string method = "package a; @nullable interface IFoo { int f(); }";
351 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800352 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900353 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
357 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
363 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800364 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900365 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700366 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700368 EXPECT_EQ(expected_stderr, GetCapturedStderr());
369 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800370}
371
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 AidlError error;
374 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
375 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800376 "ERROR: a/Foo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900377 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900378 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700379 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700380 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 AidlError error;
387 const string method = "package a; @nullable parcelable Foo { String a; String b; }";
388 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800389 "ERROR: a/Foo.aidl:1.32-36: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900390 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Devin Moorec7e47a32020-08-07 10:55:25 -0700391 "JavaOnlyImmutable, FixedSize\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700392 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700393 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700394 EXPECT_EQ(expected_stderr, GetCapturedStderr());
395 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800396}
397
Jiyong Park40782d02020-07-24 19:17:43 +0900398TEST_P(AidlTest, ParsesNonNullableAnnotation) {
399 auto parse_result =
400 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
401 ASSERT_NE(nullptr, parse_result);
402 const AidlInterface* interface = parse_result->AsInterface();
403 ASSERT_NE(nullptr, interface);
404 ASSERT_FALSE(interface->GetMethods().empty());
405 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
406}
407
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900409 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
410 typenames_, GetLanguage());
411 ASSERT_NE(nullptr, parse_result);
412 const AidlInterface* interface = parse_result->AsInterface();
413 ASSERT_NE(nullptr, interface);
414 ASSERT_FALSE(interface->GetMethods().empty());
415 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
416}
417
418TEST_P(AidlTest, ParsesNonUtf8Annotations) {
419 auto parse_result =
420 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
421 ASSERT_NE(nullptr, parse_result);
422 const AidlInterface* interface = parse_result->AsInterface();
423 ASSERT_NE(nullptr, interface);
424 ASSERT_FALSE(interface->GetMethods().empty());
425 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800426}
427
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900429 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
430 typenames_, GetLanguage());
431 ASSERT_NE(nullptr, parse_result);
432 const AidlInterface* interface = parse_result->AsInterface();
433 ASSERT_NE(nullptr, interface);
434 ASSERT_FALSE(interface->GetMethods().empty());
435 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800436}
437
Devin Moore7b8d5c92020-03-17 14:14:08 -0700438TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700439 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700440 const string expected_stderr =
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
442 "\"vintf\"'\n"
443 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
444 "--structured\n";
445 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700446 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700447 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700448 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700449 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700450}
451
Devin Moore7b8d5c92020-03-17 14:14:08 -0700452TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700453 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700454 const string expected_stderr =
455 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
456 "--structured\n";
457 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700459 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700460 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700461 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700462}
463
Devin Moore7b8d5c92020-03-17 14:14:08 -0700464TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700465 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700466 const string expected_stderr =
467 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
468 "\"vintf\"'\n";
469 CaptureStderr();
470 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700471 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700472 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700473 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700474}
475
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700477 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700478 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
479 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700480 ASSERT_EQ(AidlError::OK, error);
481 ASSERT_NE(nullptr, parse_result);
482 const AidlInterface* interface = parse_result->AsInterface();
483 ASSERT_NE(nullptr, interface);
484 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700485}
486
Jeongik Cha64783ed2019-06-07 18:30:54 +0900487TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
488 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900489 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
490 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700492 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900493 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900494 "a/Foo.aidl",
495 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900496
497 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900498 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700499 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900500 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700501 "Parcelable must be defined in AIDL directly.\n";
502 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900503 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700504 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700505
506 CaptureStderr();
507 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900509}
510
Jiyong Park43113fb2020-07-20 16:26:19 +0900511TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
512 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
513 @JavaDebug parcelable IFoo { int a; float b; })");
514 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
515 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
516
517 string java_out;
518 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
519 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
520
521 // Other backends shouldn't be bothered
522 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
523 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
524
525 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
526 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
527}
528
529TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
530 {
531 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
532 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
533 CaptureStderr();
534 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
535 const std::string expected_stderr =
536 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900537 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
538 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
540 }
541
542 {
543 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
544 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
545 CaptureStderr();
546 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
547 const std::string expected_stderr =
548 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
549 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
550 EXPECT_EQ(expected_stderr, GetCapturedStderr());
551 }
552}
553
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900554TEST_P(AidlTest, ParseDescriptorAnnotation) {
555 AidlError error;
556 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
557 typenames_, GetLanguage(), &error, {"--structured"});
558 ASSERT_EQ(AidlError::OK, error);
559 ASSERT_NE(nullptr, parse_result);
560 const AidlInterface* interface = parse_result->AsInterface();
561 ASSERT_NE(nullptr, interface);
562 ASSERT_EQ("IBar", interface->GetDescriptor());
563}
564
Jiyong Park40782d02020-07-24 19:17:43 +0900565TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700566 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700567 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900568}
569
570TEST_P(AidlTest, AcceptsOnewayInterface) {
571 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700572 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700573}
Christopher Wileyef140932015-11-03 09:29:19 -0800574
Devin Moore7b8d5c92020-03-17 14:14:08 -0700575TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700576 const string oneway_method =
577 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700578 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100579}
580
Steven Moreland65297cc2020-04-20 20:17:36 -0700581TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
582 const string oneway_method =
583 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
584 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
585 ASSERT_NE(nullptr, defined);
586 const AidlInterface* iface = defined->AsInterface();
587 ASSERT_NE(nullptr, iface);
588
589 const auto& methods = iface->GetMethods();
590 ASSERT_EQ(1u, methods.size());
591 const auto& method = methods[0];
592 const AidlTypeSpecifier& ret_type = method->GetType();
593
594 // TODO(b/151102494): these annotations should be on the method
595 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
596 ASSERT_TRUE(ret_type.IsHide());
597}
598
Devin Moore7b8d5c92020-03-17 14:14:08 -0700599TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100600 string foo_interface =
601 "package a; /* foo */ interface IFoo {"
602 " /* i */ int i();"
603 " /* j */ @nullable String j();"
604 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
605
Devin Moore7b8d5c92020-03-17 14:14:08 -0700606 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100607 EXPECT_NE(nullptr, parse_result);
608 EXPECT_EQ("/* foo */", parse_result->GetComments());
609
610 const AidlInterface* interface = parse_result->AsInterface();
611 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
612 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
613 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
614}
615
Christopher Wileyef140932015-11-03 09:29:19 -0800616TEST_F(AidlTest, ParsesPreprocessedFile) {
617 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
618 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700619 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900620 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700621 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
622 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800623}
624
625TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
626 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
627 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900628
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700629 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900630 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700631 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
632 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800633}
634
Devin Moore7b8d5c92020-03-17 14:14:08 -0700635TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800636 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
637 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
638 "interface IBar {}");
639 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900640 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900641 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700642 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800643 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900644
Christopher Wiley41544372015-11-03 14:52:29 -0800645 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700646 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
647 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800648 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700649 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900650 ambiguous_type.Resolve(typenames_);
651 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800652}
653
Jiyong Park8f6ec462020-01-19 20:52:47 +0900654// Special case of PreferImportToPreprocessed. Imported type should be preferred
655// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700656TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900657 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
658 io_delegate_.SetFileContents("one/IBar.aidl",
659 "package one; "
660 "interface IBar {}");
661 preprocessed_files_.push_back("preprocessed");
662 import_paths_.emplace("");
663 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700664 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900665 EXPECT_NE(nullptr, parse_result);
666
667 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700668 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
669 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900670 // But if we request just "IBar" we should get our imported one.
671 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
672 ambiguous_type.Resolve(typenames_);
673 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
674}
675
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800676TEST_F(AidlTest, WritePreprocessedFile) {
677 io_delegate_.SetFileContents("p/Outer.aidl",
678 "package p; parcelable Outer.Inner;");
679 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
680 "interface IBar {}");
681
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900682 vector<string> args {
683 "aidl",
684 "--preprocess",
685 "preprocessed",
686 "p/Outer.aidl",
687 "one/IBar.aidl"};
688 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800689 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
690
691 string output;
692 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
693 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
694}
695
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900696TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100697 io_delegate_.SetFileContents(
698 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800699 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100700 "parcelable Rect {\n"
701 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800702 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100703 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800704 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100705 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100706 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
707 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100708 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900709 " ParcelFileDescriptor fd;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100710 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900711
712 vector<string> args{"aidl", "Rect.aidl"};
713 Options options = Options::From(args);
714 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
715
716 string output;
717 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900718 EXPECT_EQ(kExpectedJavaParcelableOutputContests, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900719}
720
Devin Moore2f2077a2020-08-28 11:27:53 -0700721TEST_F(AidlTest, CppHeaderIncludes) {
722 io_delegate_.SetFileContents("IFoo.aidl",
723 "interface IFoo {\n"
724 " @nullable List<String> foo();\n"
725 "}");
726
727 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
728 Options options = Options::From(args);
729 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
730 std::vector<std::string> empty;
731 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
732 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
733 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
734
735 // Make sure the optional and String16.h includes are added
736 string output;
737 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
738 EXPECT_EQ(kExpectedCppHeaderOutput, output);
739}
740
Devin Moore7b8d5c92020-03-17 14:14:08 -0700741TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700742 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800743 io_delegate_.SetFileContents("p/Outer.aidl",
744 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900745 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700746 CaptureStderr();
747 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
748 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700749 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700750 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800751}
752
Devin Moore7b8d5c92020-03-17 14:14:08 -0700753TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800754 io_delegate_.SetFileContents("preprocessed",
755 "parcelable p.Outer.Inner;");
756 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900757 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700758 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800759 // TODO(wiley): This should actually return nullptr because we require
760 // the outer class name. However, for legacy reasons,
761 // this behavior must be maintained. b/17415692
762 EXPECT_NE(nullptr, parse_result);
763}
764
Christopher Wiley632801d2015-11-05 14:15:49 -0800765TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700766 const string expected_foo_stderr =
767 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
768 "Declared parcelables should be in their own file and/or cannot be used with --structured "
769 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700770 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
771
Christopher Wiley632801d2015-11-05 14:15:49 -0800772 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700773 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700774 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900775 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700776 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900777
Steven Morelande2c64b42018-09-18 15:06:37 -0700778 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900779 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700780 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900781 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700782 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700783
Devin Moore097a3ab2020-03-11 16:08:44 -0700784 const string expected_bar_stderr =
785 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
786 "Declared parcelables should be in their own file and/or cannot be used with --structured "
787 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700788 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
789
Jiyong Parkda8c6932019-08-12 19:56:08 +0900790 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700791 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700792 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900793 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700794 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700795 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700796 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700797 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700798 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800799}
800
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700802 const string expected_stderr =
803 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
804 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700805 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
806 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700807 AidlError error;
808 CaptureStderr();
809 EXPECT_EQ(
810 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700811 Parse("p/IFoo.aidl",
812 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700813 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700814 EXPECT_EQ(expected_stderr, GetCapturedStderr());
815 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700816}
817
Devin Moore7b8d5c92020-03-17 14:14:08 -0700818TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700819 AidlError error;
820 const string expected_stderr =
821 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
822 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900823 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
824 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700825 interface IFoo {
826 const String DUPLICATED = "d";
827 const int DUPLICATED = 1;
828 }
829 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700830 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700831 EXPECT_EQ(expected_stderr, GetCapturedStderr());
832 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700833}
834
Devin Moore7b8d5c92020-03-17 14:14:08 -0700835TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700836 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700837 const string expected_stderr =
838 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700839 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700840 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
841 R"(package p;
842 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700843 parcelable IBar {}
844 parcelable StructuredParcelable {}
845 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900846 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700847 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700848 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700849 // Parse success is important for clear error handling even if the cases aren't
850 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700851 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700852}
853
Devin Moore7b8d5c92020-03-17 14:14:08 -0700854TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700855 AidlError error;
856 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
857 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700858 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700859 EXPECT_EQ(expected_stderr, GetCapturedStderr());
860 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700861}
862
Steven Morelandf9e922f2020-07-08 21:15:27 +0000863TEST_P(AidlTest, FailOnEmptyListWithComma) {
864 AidlError error;
865 const string expected_stderr =
866 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
867 CaptureStderr();
868 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
869 typenames_, GetLanguage(), &error));
870 EXPECT_EQ(expected_stderr, GetCapturedStderr());
871 EXPECT_EQ(AidlError::PARSE_ERROR, error);
872}
873
Devin Moore7b8d5c92020-03-17 14:14:08 -0700874TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700875 AidlError error;
876 const string expected_stderr =
877 "ERROR: Could not parse hexvalue: 0xffffffffffffffffff at p/IFoo.aidl:3.50-70.\n";
878 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900879 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
880 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700881 interface IFoo {
882 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
883 }
884 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700886 EXPECT_EQ(expected_stderr, GetCapturedStderr());
887 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700888}
889
Jiyong Park18132182020-06-08 20:24:40 +0900890TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
891 AidlError error;
892 const string expected_stderr =
893 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
894 "cpp_header (which can also be used as an identifier)\n";
895 CaptureStderr();
896 // Notice the trailing dot(.) in the name, which isn't a correct name
897 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
898 GetLanguage(), &error));
899 EXPECT_EQ(expected_stderr, GetCapturedStderr());
900 EXPECT_EQ(AidlError::PARSE_ERROR, error);
901}
902
903TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
904 AidlError error;
905 const string expected_stderr =
906 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
907 "cpp_header (which can also be used as an identifier)\n";
908 CaptureStderr();
909 // Notice the trailing dot(.) in the package name
910 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
911 GetLanguage(), &error));
912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
913 EXPECT_EQ(AidlError::PARSE_ERROR, error);
914}
915
Devin Moore7b8d5c92020-03-17 14:14:08 -0700916TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700918 auto parse_result = Parse("p/IFoo.aidl",
919 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700920 interface IFoo {
921 const int POSITIVE_HEX_VALUE = 0xf5;
922 }
923 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700924 typenames_, GetLanguage(), &error);
925 EXPECT_NE(nullptr, parse_result);
926 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700927 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700928 const auto& cpp_constants = interface->GetConstantDeclarations();
929 EXPECT_EQ((size_t)1, cpp_constants.size());
930 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700931 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700932 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700933}
934
Devin Moore7b8d5c92020-03-17 14:14:08 -0700935TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700937 auto parse_result = Parse("p/IFoo.aidl",
938 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700939 interface IFoo {
940 const int NEGATIVE_HEX_VALUE = 0xffffffff;
941 }
942 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943 typenames_, GetLanguage(), &error);
944 ASSERT_NE(nullptr, parse_result);
945 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700946 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700947 const auto& cpp_constants = interface->GetConstantDeclarations();
948 EXPECT_EQ((size_t)1, cpp_constants.size());
949 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700950 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700951 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700952}
953
Devin Moore7b8d5c92020-03-17 14:14:08 -0700954TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -0700955 io_delegate_.SetFileContents(
956 "p/Outer.aidl",
957 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +0900958 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -0700959 const string input_path = "p/IFoo.aidl";
960 const string input = "package p; import p.Outer; interface IFoo"
961 " { Outer.Inner get(); }";
962
Devin Moore7b8d5c92020-03-17 14:14:08 -0700963 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
964 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900965
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700966 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -0700967 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900968 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
969 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -0700970}
971
Devin Moore7b8d5c92020-03-17 14:14:08 -0700972TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -0800973 io_delegate_.SetFileContents(
974 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -0800975 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +0900976 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -0800977 const string input_path = "p/IFoo.aidl";
978 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700979 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
980 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700981 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700982 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
983 native_type.Resolve(typenames_);
984
985 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
986 // C++ understands C++ specific stuff
987 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
988 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -0700989 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990 EXPECT_EQ(1u, headers.size());
991 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -0800992}
993
Christopher Wileyf8136192016-04-12 14:19:35 -0700994TEST_F(AidlTest, WritesCorrectDependencyFile) {
995 // While the in tree build system always gives us an output file name,
996 // other android tools take advantage of our ability to infer the intended
997 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900998 vector<string> args = {
999 "aidl",
1000 "-d dep/file/path",
1001 "-o place/for/output",
1002 "p/IFoo.aidl"};
1003 Options options = Options::From(args);
1004 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001005 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001006 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001007 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001008 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1009}
1010
Dan Willemsen93298ee2016-11-10 23:55:55 -08001011TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1012 // While the in tree build system always gives us an output file name,
1013 // other android tools take advantage of our ability to infer the intended
1014 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001015 vector<string> args = {
1016 "aidl",
1017 "-d dep/file/path",
1018 "--ninja",
1019 "-o place/for/output",
1020 "p/IFoo.aidl"};
1021 Options options = Options::From(args);
1022 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001023 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001024 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001025 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001026 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1027}
1028
Jiyong Parkdf202122019-09-30 20:48:35 +09001029TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001030 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1031 // this by calling aidl with every .aidl file it finds, then parsing the
1032 // generated dependency files. Those that reference .java output files are
1033 // for interfaces and those that do not are parcelables. However, for both
1034 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001035 vector<string> args = {
1036 "aidl",
1037 "-o place/for/output",
1038 "-d dep/file/path",
1039 "p/Foo.aidl"};
1040 Options options = Options::From(args);
1041 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001042 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001043 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001044 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001045 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1046}
1047
1048TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1049 vector<string> args = {
1050 "aidl",
1051 "--structured",
1052 "-o place/for/output",
1053 "-d dep/file/path",
1054 "p/Foo.aidl"};
1055 Options options = Options::From(args);
1056 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1057 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1058 string actual_dep_file_contents;
1059 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1060 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001061}
1062
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001063TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1064 vector<string> args = {
1065 "aidl",
1066 "--lang=java",
1067 "-o place/for/output",
1068 "p/Foo.aidl"};
1069 Options options = Options::From(args);
1070 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1071 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1072 string output_file_contents;
1073 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1074}
1075
Jeongik Cha08ca2182019-11-21 14:01:13 +09001076// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001077TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001078 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001079 "package a; interface IFoo {\n"
1080 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001081 string expected_stderr;
1082 switch (GetLanguage()) {
1083 case Options::Language::CPP:
1084 expected_stderr =
1085 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1086 "String and IBinder.\n";
1087 break;
1088 case Options::Language::JAVA:
1089 expected_stderr =
1090 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1091 "String, IBinder, and ParcelFileDescriptor.\n";
1092 break;
1093 case Options::Language::NDK:
1094 expected_stderr =
1095 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1096 break;
Andrei Homescub62afd92020-05-11 19:24:59 -07001097 case Options::Language::RUST:
1098 expected_stderr =
1099 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1100 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001101 default:
1102 AIDL_FATAL(AIDL_LOCATION_HERE)
1103 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1104 }
1105 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001106 AidlTypenames tn1;
1107 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001108 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001109
1110 string primitive_parcelable =
1111 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001112 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001113 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001114 AidlTypenames tn2;
1115 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001117}
1118
Devin Moore21b26772020-08-26 16:37:56 -07001119TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001120 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001121 const string list_array_parcelable =
1122 "package a; parcelable Foo {\n"
1123 " List[] lists; }";
1124 CaptureStderr();
1125 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1126 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1127}
1128
Jiyong Parkf8d53612020-05-04 14:06:13 +09001129TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1130 AidlError error;
1131 string expected_stderr =
1132 "ERROR: a/IFoo.aidl:2.7-11: "
1133 "Encountered an untyped List or Map. The use of untyped List/Map is "
1134 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1135 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1136 if (GetLanguage() != Options::Language::JAVA) {
1137 expected_stderr =
1138 "ERROR: a/IFoo.aidl:2.1-7: "
1139 "Currently, only the Java backend supports non-generic List.\n";
1140 }
1141
1142 const string primitive_interface =
1143 "package a; interface IFoo {\n"
1144 " List foo(); }";
1145 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001146 AidlTypenames tn1;
1147 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001148 {"--structured"}));
1149 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001150
1151 string primitive_parcelable =
1152 "package a; parcelable IFoo {\n"
1153 " List foo;}";
1154 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001155 AidlTypenames tn2;
1156 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001157 {"--structured"}));
1158 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1159}
1160
Jeongik Cha649e8a72020-03-27 17:47:40 +09001161TEST_F(AidlTest, ExtensionTest) {
1162 string extendable_parcelable =
1163 "package a; parcelable Data {\n"
1164 " ParcelableHolder extension;\n"
1165 " ParcelableHolder extension2;\n"
1166 "}";
1167 EXPECT_NE(nullptr,
1168 Parse("a/Data.aidl", extendable_parcelable, typenames_, Options::Language::JAVA));
1169 EXPECT_EQ(nullptr,
1170 Parse("a/Data.aidl", extendable_parcelable, typenames_, Options::Language::CPP));
1171 EXPECT_EQ(nullptr,
1172 Parse("a/Data.aidl", extendable_parcelable, typenames_, Options::Language::NDK));
Andrei Homescub62afd92020-05-11 19:24:59 -07001173 EXPECT_EQ(nullptr,
1174 Parse("a/Data.aidl", extendable_parcelable, typenames_, Options::Language::RUST));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001175
1176 string parcelableholder_return_interface =
1177 "package a; interface IFoo {\n"
1178 " ParcelableHolder foo();\n"
1179 "}";
1180 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_,
1181 Options::Language::JAVA));
1182 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_,
1183 Options::Language::CPP));
1184 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_,
1185 Options::Language::NDK));
Andrei Homescub62afd92020-05-11 19:24:59 -07001186 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_,
1187 Options::Language::RUST));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001188
1189 string extendable_parcelable_arg_interface =
1190 "package a; interface IFoo {\n"
1191 " void foo(in ParcelableHolder ph);\n"
1192 "}";
1193 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_,
1194 Options::Language::JAVA));
1195 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_,
1196 Options::Language::CPP));
1197 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_,
1198 Options::Language::NDK));
Andrei Homescub62afd92020-05-11 19:24:59 -07001199 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_,
1200 Options::Language::RUST));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001201}
1202
Jiyong Park02da7422018-07-16 16:00:26 +09001203TEST_F(AidlTest, ApiDump) {
1204 io_delegate_.SetFileContents(
1205 "foo/bar/IFoo.aidl",
1206 "package foo.bar;\n"
1207 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001208 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001209 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001210 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001211 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1212 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1213 " IFoo foo3(IFoo foo);\n"
1214 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001215 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001216 " const int A = 1;\n"
1217 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001218 "}\n");
1219 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1220 "package foo.bar;\n"
1221 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001222 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001223 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001224 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001225 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001226 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001227 " int y;\n"
1228 " IFoo foo;\n"
1229 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001230 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001231 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001232 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001233 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001234 "}\n");
1235 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001236 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1237 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001238 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001239 bool result = dump_api(options, io_delegate_);
1240 ASSERT_TRUE(result);
1241 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001242 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001243 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001244/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001245interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001246 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001247 int foo(out int[] a, String b, boolean c, inout List<String> d);
1248 int foo2(@utf8InCpp String x, inout List<String> y);
1249 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1250 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001251 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001252 const int A = 1;
1253 const String STR = "Hello";
1254}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001255)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001256
Jiyong Parke59c3682018-09-11 23:10:25 +09001257 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001258 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001259/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001260parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001261 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001262 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001263 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001264 int y;
1265 foo.bar.IFoo foo;
1266 List<foo.bar.IFoo> a;
1267 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001268 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001269 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001270}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001271)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001272}
1273
Jiyong Parked65bf42018-08-28 15:43:27 +09001274TEST_F(AidlTest, ApiDumpWithManualIds) {
1275 io_delegate_.SetFileContents(
1276 "foo/bar/IFoo.aidl",
1277 "package foo.bar;\n"
1278 "interface IFoo {\n"
1279 " int foo() = 1;\n"
1280 " int bar() = 2;\n"
1281 " int baz() = 10;\n"
1282 "}\n");
1283
Jiyong Parke59c3682018-09-11 23:10:25 +09001284 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001285 Options options = Options::From(args);
1286 bool result = dump_api(options, io_delegate_);
1287 ASSERT_TRUE(result);
1288 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001289 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001290 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001291interface IFoo {
1292 int foo() = 1;
1293 int bar() = 2;
1294 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001295}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001296)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001297}
1298
1299TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001300 const string expected_stderr =
1301 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1302 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001303 io_delegate_.SetFileContents(
1304 "foo/bar/IFoo.aidl",
1305 "package foo.bar;\n"
1306 "interface IFoo {\n"
1307 " int foo() = 1;\n"
1308 " int bar();\n"
1309 " int baz() = 10;\n"
1310 "}\n");
1311
Jiyong Parke59c3682018-09-11 23:10:25 +09001312 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001313 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001314 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001315 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001317}
1318
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001319TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 const string expected_list_stderr =
1321 "ERROR: p/IFoo.aidl:1.37-41: List must have only one type parameter.\n";
1322 const string expected_map_stderr =
1323 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001324 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1325 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001326 "package p; interface IFoo {"
1327 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001328 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001329 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001330 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001331
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001332 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001333 "package p; interface IFoo {"
1334 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001335 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001336 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001337 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001338}
1339
Jeongik Chae48d9942020-01-02 17:39:00 +09001340TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001341 const string expected_stderr =
1342 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001343 Options options = Options::From("aidl -I p p/IFoo.aidl");
1344 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1345
1346 io_delegate_.SetFileContents("p/IFoo.aidl",
1347 "package p; interface IFoo {"
1348 "Map<String, Bar> foo();}");
1349 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1350
1351 io_delegate_.SetFileContents("p/IFoo.aidl",
1352 "package p; interface IFoo {"
1353 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001354 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001355 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001357
1358 io_delegate_.SetFileContents("p/IFoo.aidl",
1359 "package p; interface IFoo {"
1360 "Map<String, String> foo();}");
1361 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1362
1363 io_delegate_.SetFileContents("p/IFoo.aidl",
1364 "package p; interface IFoo {"
1365 "Map<String, ParcelFileDescriptor> foo();}");
1366 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1367}
1368
Jeongik Chadf76dc72019-11-28 00:08:47 +09001369TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001370 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001371 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1372 io_delegate_.SetFileContents(options.InputFiles().front(),
1373 "package p; interface IFoo {"
1374 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001375 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001376 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001378}
1379
1380TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1381 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1382 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001383 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001384 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001385 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1386 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001387
1388 Options options = Options::From("aidl -I p p/IFoo.aidl");
1389 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1390 io_delegate_.SetFileContents("p/IFoo.aidl",
1391 "package p; interface IFoo {"
1392 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001393 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001394 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001395 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001396 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001397 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001398 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001399 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1400 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001401 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1402 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1403 io_delegate_.SetFileContents("p/IFoo.aidl",
1404 "package p; interface IFoo {"
1405 "Bar<String, ParcelFileDescriptor> foo();}");
1406 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001407
1408 io_delegate_.SetFileContents("p/IFoo.aidl",
1409 "package p; interface IFoo {"
1410 "Bar<int, long> foo();}");
1411
1412 io_delegate_.SetFileContents("p/IFoo.aidl",
1413 "package p; interface IFoo {"
1414 "Bar<int[], long[]> foo();}");
1415
1416 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001417}
1418
Jeongik Cha0e426012019-07-29 15:57:02 +09001419TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1420 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001421 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1422 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001423 for (const auto& rawOption : rawOptions) {
1424 string expected_stderr =
1425 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001426 Options options = Options::From(rawOption);
1427 io_delegate_.SetFileContents(options.InputFiles().front(),
1428 "package foo.bar;\n"
1429 "interface IFoo1 { int foo(); }\n"
1430 "interface IFoo2 { int foo(); }\n"
1431 "parcelable Data1 { int a; int b;}\n"
1432 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001433 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001434 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001435 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001436
Jeongik Cha0e426012019-07-29 15:57:02 +09001437 io_delegate_.SetFileContents(options.InputFiles().front(),
1438 "package foo.bar;\n"
1439 "interface IFoo1 { int foo(); }\n"
1440 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001441 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001442 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001443 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001444
Devin Moore5de18ed2020-04-02 13:52:29 -07001445 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001446 io_delegate_.SetFileContents(options.InputFiles().front(),
1447 "package foo.bar;\n"
1448 "parcelable Data1 { int a; int b;}\n"
1449 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001450 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001451 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001452 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001453 }
1454}
1455
Devin Moorebdba2a82020-03-31 15:19:02 -07001456TEST_P(AidlTest, FailParseOnEmptyFile) {
1457 const string contents = "";
1458 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1459 CaptureStderr();
1460 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1461 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1462}
1463
Jiyong Parkb034bf02018-07-30 17:44:33 +09001464TEST_F(AidlTest, MultipleInputFiles) {
1465 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001466 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001467
1468 io_delegate_.SetFileContents(options.InputFiles().at(0),
1469 "package foo.bar;\n"
1470 "import foo.bar.Data;\n"
1471 "interface IFoo { Data getData(); }\n");
1472
1473 io_delegate_.SetFileContents(options.InputFiles().at(1),
1474 "package foo.bar;\n"
1475 "import foo.bar.IFoo;\n"
1476 "parcelable Data { IFoo foo; }\n");
1477
1478 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1479
1480 string content;
1481 for (const auto file : {
1482 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1483 content.clear();
1484 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1485 EXPECT_FALSE(content.empty());
1486 }
1487}
1488
1489TEST_F(AidlTest, MultipleInputFilesCpp) {
1490 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001491 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001492
1493 io_delegate_.SetFileContents(options.InputFiles().at(0),
1494 "package foo.bar;\n"
1495 "import foo.bar.Data;\n"
1496 "interface IFoo { Data getData(); }\n");
1497
1498 io_delegate_.SetFileContents(options.InputFiles().at(1),
1499 "package foo.bar;\n"
1500 "import foo.bar.IFoo;\n"
1501 "parcelable Data { IFoo foo; }\n");
1502
1503 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1504
1505 string content;
1506 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001507 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001508 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1509 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1510 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1511 content.clear();
1512 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1513 EXPECT_FALSE(content.empty());
1514 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001515}
1516
Andrei Homescub62afd92020-05-11 19:24:59 -07001517TEST_F(AidlTest, MultipleInputFilesRust) {
1518 Options options =
1519 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1520
1521 io_delegate_.SetFileContents(options.InputFiles().at(0),
1522 "package foo.bar;\n"
1523 "import foo.bar.Data;\n"
1524 "interface IFoo { Data getData(); }\n");
1525
1526 io_delegate_.SetFileContents(options.InputFiles().at(1),
1527 "package foo.bar;\n"
1528 "import foo.bar.IFoo;\n"
1529 "parcelable Data { IFoo foo; }\n");
1530
1531 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1532
1533 string content;
1534 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1535 content.clear();
1536 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1537 EXPECT_FALSE(content.empty());
1538 }
1539}
1540
Devin Moore097a3ab2020-03-11 16:08:44 -07001541TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1542 const string expected_stderr =
1543 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001544 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1545 // int getInterfaceVersion() is one of the meta transactions
1546 io_delegate_.SetFileContents(options.InputFiles().front(),
1547 "package p; interface IFoo {"
1548 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001549 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001550 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1552}
Jiyong Park309668e2018-07-28 16:55:44 +09001553
Devin Moore097a3ab2020-03-11 16:08:44 -07001554TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1555 // boolean getInterfaceVersion() is not a meta transaction, but should be
1556 // prevented because return type is not part of a method signature
1557 const string expected_stderr =
1558 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1559 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001560 io_delegate_.SetFileContents(options.InputFiles().front(),
1561 "package p; interface IFoo {"
1562 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001563 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001564 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001565 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1566}
Jiyong Park309668e2018-07-28 16:55:44 +09001567
Devin Moore097a3ab2020-03-11 16:08:44 -07001568TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001569 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001570 const string expected_stderr =
1571 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1572 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001573 io_delegate_.SetFileContents(options.InputFiles().front(),
1574 "package p; interface IFoo {"
1575 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001576 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001577 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001578 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001579
1580 // this is not a meta interface method as it differs type arguments
1581 io_delegate_.SetFileContents(options.InputFiles().front(),
1582 "package p; interface IFoo {"
1583 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001584 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001585}
1586
Daniel Norman85aed542019-08-21 12:01:14 -07001587TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001588 Options options = Options::From("aidl --checkapi old new");
1589 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1590 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1591 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1592 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1593
1594 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1595}
1596
Jiyong Park3656c3c2018-08-01 20:02:01 +09001597TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001598 Options options = Options::From("aidl --checkapi old new");
1599 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1600 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001601
1602 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1603}
1604
Daniel Norman85aed542019-08-21 12:01:14 -07001605class AidlTestCompatibleChanges : public AidlTest {
1606 protected:
1607 Options options_ = Options::From("aidl --checkapi old new");
1608};
1609
1610TEST_F(AidlTestCompatibleChanges, NewType) {
1611 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1612 "package p;"
1613 "interface IFoo {"
1614 " void foo(int a);"
1615 "}");
1616 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1617 "package p;"
1618 "interface IFoo {"
1619 " void foo(int a);"
1620 "}");
1621 io_delegate_.SetFileContents("new/p/IBar.aidl",
1622 "package p;"
1623 "interface IBar {"
1624 " void bar();"
1625 "}");
1626 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1627}
1628
1629TEST_F(AidlTestCompatibleChanges, NewMethod) {
1630 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1631 "package p;"
1632 "interface IFoo {"
1633 " void foo(int a);"
1634 "}");
1635 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1636 "package p;"
1637 "interface IFoo {"
1638 " void foo(int a);"
1639 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001640 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001641 "}");
1642 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1643}
1644
1645TEST_F(AidlTestCompatibleChanges, NewField) {
1646 io_delegate_.SetFileContents("old/p/Data.aidl",
1647 "package p;"
1648 "parcelable Data {"
1649 " int foo;"
1650 "}");
1651 io_delegate_.SetFileContents("new/p/Data.aidl",
1652 "package p;"
1653 "parcelable Data {"
1654 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001655 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001656 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001657 "}");
1658 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1659}
1660
1661TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1662 io_delegate_.SetFileContents("old/p/Enum.aidl",
1663 "package p;"
1664 "enum Enum {"
1665 " FOO = 1,"
1666 "}");
1667 io_delegate_.SetFileContents("new/p/Enum.aidl",
1668 "package p;"
1669 "enum Enum {"
1670 " FOO = 1,"
1671 " BAR = 2,"
1672 "}");
1673 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1674}
1675
1676TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1677 io_delegate_.SetFileContents("old/p/Enum.aidl",
1678 "package p;"
1679 "enum Enum {"
1680 " FOO = 1,"
1681 " BAR = 2,"
1682 "}");
1683 io_delegate_.SetFileContents("new/p/Enum.aidl",
1684 "package p;"
1685 "enum Enum {"
1686 " BAR = 2,"
1687 " FOO = 1,"
1688 "}");
1689 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1690}
1691
1692TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001693 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1694 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001695 "interface IFoo {"
1696 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001697 "}");
1698 io_delegate_.SetFileContents("old/p/Data.aidl",
1699 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001700 "parcelable Data {"
1701 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001702 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001703 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1704 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001705 "interface IFoo {"
1706 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001707 "}");
1708 io_delegate_.SetFileContents("new/p/Data.aidl",
1709 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001710 "parcelable Data {"
1711 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001712 "}");
1713 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1714 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001715 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001716 " void foo(int a);"
1717 "}");
1718 io_delegate_.SetFileContents("new/q/Data.aidl",
1719 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001720 "parcelable Data {"
1721 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001722 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001723 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1724}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001725
Daniel Norman85aed542019-08-21 12:01:14 -07001726TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1727 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1728 "package p;"
1729 "interface IFoo {"
1730 " void foo(int a);"
1731 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001732 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1733 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001734 "interface IFoo {"
1735 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001736 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001737 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1738}
Jiyong Parke59c3682018-09-11 23:10:25 +09001739
Daniel Norman85aed542019-08-21 12:01:14 -07001740TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001741 io_delegate_.SetFileContents("old/p/I.aidl",
1742 "package p; interface I {"
1743 "const int A = 1; }");
1744 io_delegate_.SetFileContents("new/p/I.aidl",
1745 "package p ; interface I {"
1746 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001747 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1748}
Jiyong Parka428d212018-08-29 22:26:30 +09001749
Daniel Norman85aed542019-08-21 12:01:14 -07001750TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001751 io_delegate_.SetFileContents("old/p/I.aidl",
1752 "package p; interface I {"
1753 "const int A = 1; const int B = 2;}");
1754 io_delegate_.SetFileContents("new/p/I.aidl",
1755 "package p ; interface I {"
1756 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001757 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001758}
1759
Daniel Norman85aed542019-08-21 12:01:14 -07001760class AidlTestIncompatibleChanges : public AidlTest {
1761 protected:
1762 Options options_ = Options::From("aidl --checkapi old new");
1763};
1764
1765TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001766 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001767 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1768 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001769 "interface IFoo {"
1770 " void foo(in String[] str);"
1771 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001772 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001773 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001774 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001775 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001776}
1777
1778TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001779 const string expected_stderr =
1780 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001781 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1782 "package p;"
1783 "interface IFoo {"
1784 " void foo(in String[] str);"
1785 " void bar(@utf8InCpp String str);"
1786 "}");
1787 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1788 "package p;"
1789 "interface IFoo {"
1790 " void foo(in String[] str);"
1791 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001792 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001793 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001794 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001795}
1796
Jiyong Parkf8d53612020-05-04 14:06:13 +09001797TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1798 const string expected_stderr =
1799 "ERROR: new/p/IFoo.aidl:1.61-65: "
1800 "Encountered an untyped List or Map. The use of untyped List/Map is "
1801 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1802 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1803 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1804 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1805 "package p;"
1806 "interface IFoo {"
1807 " void foo(in String[] str);"
1808 "}");
1809 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1810 "package p;"
1811 "interface IFoo {"
1812 " void foo(in String[] str);"
1813 " void bar(in List arg);"
1814 "}");
1815 CaptureStderr();
1816 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1817 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1818}
1819
1820TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1821 const string expected_stderr =
1822 "ERROR: new/p/Data.aidl:1.54-59: "
1823 "Encountered an untyped List or Map. The use of untyped List/Map is "
1824 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1825 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1826 "ERROR: new/p/Data.aidl: Failed to read.\n";
1827 io_delegate_.SetFileContents("old/p/Data.aidl",
1828 "package p;"
1829 "parcelable Data {"
1830 " int foo;"
1831 "}");
1832 io_delegate_.SetFileContents("new/p/Data.aidl",
1833 "package p;"
1834 "parcelable Data {"
1835 " int foo;"
1836 " @nullable List list;"
1837 "}");
1838 CaptureStderr();
1839 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1840 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1841}
1842
Daniel Norman85aed542019-08-21 12:01:14 -07001843TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001844 const string expected_stderr =
1845 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001846 io_delegate_.SetFileContents("old/p/Data.aidl",
1847 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001848 "parcelable Data {"
1849 " int foo;"
1850 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001851 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001852 io_delegate_.SetFileContents("new/p/Data.aidl",
1853 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001854 "parcelable Data {"
1855 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001856 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001857 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001858 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001859 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001860}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001861
Daniel Norman85aed542019-08-21 12:01:14 -07001862TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001863 const string expected_stderr =
1864 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001865 io_delegate_.SetFileContents("old/p/Enum.aidl",
1866 "package p;"
1867 "enum Enum {"
1868 " FOO = 1,"
1869 " BAR = 2,"
1870 "}");
1871 io_delegate_.SetFileContents("new/p/Enum.aidl",
1872 "package p;"
1873 "enum Enum {"
1874 " BAR = 2,"
1875 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001876 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001877 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001878 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001879}
1880
1881TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001882 const string expected_stderr =
1883 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001884 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1885 "package p;"
1886 "interface IFoo {"
1887 " void foo(in String[] str);"
1888 " void bar(@utf8InCpp String str);"
1889 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001890 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1891 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001892 "interface IFoo {"
1893 " void foo(in String[] str);"
1894 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001895 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001896 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001897 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001898 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001899}
1900
Daniel Norman85aed542019-08-21 12:01:14 -07001901TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001902 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001903 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1904 "package p;"
1905 "interface IFoo {"
1906 " void foo(in String[] str);"
1907 " void bar(@utf8InCpp String str);"
1908 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001909 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
1910 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001911 "interface IFoo2 {"
1912 " void foo(in String[] str);"
1913 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001914 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001915 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001916 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001917 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001918}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001919
Daniel Norman85aed542019-08-21 12:01:14 -07001920TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001921 const string expected_stderr =
1922 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001923 io_delegate_.SetFileContents("old/p/Enum.aidl",
1924 "package p;"
1925 "enum Enum {"
1926 " FOO = 1,"
1927 " BAR = 2,"
1928 "}");
1929 io_delegate_.SetFileContents("new/p/Enum.aidl",
1930 "package p;"
1931 "enum Enum {"
1932 " FOO = 3,"
1933 " BAR = 2,"
1934 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001935 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001936 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001937 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001938}
1939
1940TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001941 const string expected_stderr =
1942 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
1943 "from 0 to 1.\n"
1944 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
1945 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001946 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1947 "package p;"
1948 "interface IFoo {"
1949 " void foo(in String[] str);"
1950 " void bar(@utf8InCpp String str);"
1951 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001952 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1953 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001954 "interface IFoo {"
1955 " void bar(@utf8InCpp String str);"
1956 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001957 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001958 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001959 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001960 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001961}
1962
1963TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001964 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09001965 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
1966 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001967 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09001968 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001969 "parcelable Data {"
1970 " int foo;"
1971 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001972 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001973 io_delegate_.SetFileContents("new/p/Data.aidl",
1974 "package p;"
1975 "parcelable Data {"
1976 " int bar;"
1977 " int foo;"
1978 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001979 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001980 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001981 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001982}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001983
Daniel Norman85aed542019-08-21 12:01:14 -07001984TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07001985 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001986 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09001987 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001988 "interface IFoo {"
1989 " void foo(in String[] str);"
1990 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001991 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001992 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1993 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001994 "interface IFoo {"
1995 " void foo(out String[] str);"
1996 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001997 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07001998 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001999 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002000 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002001}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002002
Daniel Norman85aed542019-08-21 12:01:14 -07002003TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002004 const string expected_stderr =
2005 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002006 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2007 "package p;"
2008 "interface IFoo {"
2009 " void foo(in String[] str);"
2010 " void bar(@utf8InCpp String str);"
2011 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002012 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2013 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002014 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002015 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002016 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002017 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002018 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002019 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002021}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002022
Daniel Norman85aed542019-08-21 12:01:14 -07002023TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002024 const string expected_stderr =
2025 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002026 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2027 "package p;"
2028 "interface IFoo {"
2029 " void foo(in String[] str);"
2030 " void bar(@utf8InCpp String str);"
2031 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002032 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2033 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002034 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002035 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002036 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002037 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002038 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002039 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002040 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002041}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002042
Devin Mooredb7ac512020-08-07 11:17:36 -07002043TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2044 const string expected_stderr =
2045 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2046 io_delegate_.SetFileContents("old/p/Foo.aidl",
2047 "package p;"
2048 "parcelable Foo {"
2049 " int A;"
2050 "}");
2051 io_delegate_.SetFileContents("new/p/Foo.aidl",
2052 "package p;"
2053 "@JavaOnlyStableParcelable parcelable Foo {"
2054 " int A;"
2055 "}");
2056 CaptureStderr();
2057 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2058 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2059}
2060
2061TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2062 const string expected_stderr =
2063 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2064 io_delegate_.SetFileContents("old/p/Foo.aidl",
2065 "package p;"
2066 "@JavaOnlyStableParcelable parcelable Foo {"
2067 " int A;"
2068 "}");
2069 io_delegate_.SetFileContents("new/p/Foo.aidl",
2070 "package p;"
2071 "parcelable Foo {"
2072 " int A;"
2073 "}");
2074 CaptureStderr();
2075 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2077}
2078
Daniel Norman85aed542019-08-21 12:01:14 -07002079TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002080 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002081 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2082 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002083 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002084 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002085 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002086 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002087}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002088
Daniel Norman85aed542019-08-21 12:01:14 -07002089TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002090 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002091 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2092 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002093 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002094 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002095 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002096}
Jiyong Parka428d212018-08-29 22:26:30 +09002097
Daniel Norman85aed542019-08-21 12:01:14 -07002098TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002099 const string expected_stderr =
2100 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002101 io_delegate_.SetFileContents("old/p/I.aidl",
2102 "package p; interface I {"
2103 "const int A = 1; const int B = 2;}");
2104 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002105 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002106 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002107 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002108}
Jiyong Parka428d212018-08-29 22:26:30 +09002109
Daniel Norman85aed542019-08-21 12:01:14 -07002110TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002111 const string expected_stderr =
2112 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002113 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2114 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002115 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002116 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002117 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002118}
2119
Devin Moorec7e47a32020-08-07 10:55:25 -07002120TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2121 const string expected_stderr =
2122 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2123 "This is an incompatible change for FixedSize types.\n";
2124 io_delegate_.SetFileContents("old/p/Foo.aidl",
2125 "package p; @FixedSize parcelable Foo { int A = 1; }");
2126 io_delegate_.SetFileContents("new/p/Foo.aidl",
2127 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2128 CaptureStderr();
2129 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2130 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2131}
2132
2133TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2134 const string expected_stderr =
2135 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2136 io_delegate_.SetFileContents("old/p/Foo.aidl",
2137 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2138 io_delegate_.SetFileContents("new/p/Foo.aidl",
2139 "package p; @FixedSize parcelable Foo { int A = 1; }");
2140 CaptureStderr();
2141 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2142 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2143}
2144
2145TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2146 const string expected_stderr =
2147 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2148 "a.\n"
2149 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2150 "b.\n"
2151 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2152 "c.\n"
2153 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2154 "d.\n"
2155 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2156 "e.\n"
2157 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2158 "f.\n";
2159
2160 io_delegate_.SetFileContents("Foo.aidl",
2161 "@FixedSize parcelable Foo { "
2162 " int[] a;"
2163 " Bar b;"
2164 " String c;"
2165 " ParcelFileDescriptor d;"
2166 " IBinder e;"
2167 " List<String> f;"
2168 "}");
2169 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2170 Options options =
2171 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2172
2173 CaptureStderr();
2174 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2175 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2176}
2177
2178TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2179 const string expected_stderr = "";
2180
2181 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2182 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2183 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2184 Options options =
2185 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2186
2187 CaptureStderr();
2188 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2189 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2190}
2191
Jiyong Park8c380532018-08-30 14:55:26 +09002192TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002193 const string expected_stderr =
2194 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2195 "dir1/q/IBar.aidl\n"
2196 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002197 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002198 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2199 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2200 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2201 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2202
Devin Moore097a3ab2020-03-11 16:08:44 -07002203 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002204 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002205 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002206}
2207
Jiyong Parked65bf42018-08-28 15:43:27 +09002208TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002209 const string expected_stderr =
2210 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2211 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002212 Options options = Options::From("aidl --checkapi old new");
2213 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2214 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002215
2216 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2217
Jiyong Parke59c3682018-09-11 23:10:25 +09002218 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002219 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002220 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002222}
2223
Jiyong Parke05195e2018-10-08 18:24:23 +09002224TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2225 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2226 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002227 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002228
2229 // use without import
2230 io_delegate_.SetFileContents("p/IFoo.aidl",
2231 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2232 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2233 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002234 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002235
Devin Moore7b8d5c92020-03-17 14:14:08 -07002236 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002237 io_delegate_.SetFileContents(
2238 "p/IFoo.aidl",
2239 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2240 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2241 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002242 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002243
2244 // use with import (as before)
2245 io_delegate_.SetFileContents("p/IFoo.aidl",
2246 "package p;"
2247 "import android.os.ParcelFileDescriptor;"
2248 "interface IFoo{"
2249 " void foo(in ParcelFileDescriptor fd);"
2250 "}");
2251 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2252 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002253 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002254}
Jiyong Parked65bf42018-08-28 15:43:27 +09002255
Jiyong Park3633b722019-04-11 15:38:26 +09002256TEST_F(AidlTest, ManualIds) {
2257 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2258 io_delegate_.SetFileContents("IFoo.aidl",
2259 "interface IFoo {\n"
2260 " void foo() = 0;\n"
2261 " void bar() = 1;\n"
2262 "}");
2263 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2264}
2265
2266TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2267 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2268 io_delegate_.SetFileContents("IFoo.aidl",
2269 "interface IFoo {\n"
2270 " void foo() = 0;\n"
2271 " void bar() = 1;\n"
2272 "}");
2273 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2274}
2275
2276TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002277 const string expected_stderr =
2278 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002279 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2280 io_delegate_.SetFileContents("IFoo.aidl",
2281 "interface IFoo {\n"
2282 " void foo() = 3;\n"
2283 " void bar() = 3;\n"
2284 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002285 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002286 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002287 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002288}
2289
2290TEST_F(AidlTest, FailOnOutOfRangeIds) {
2291 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002292 const string expected_stderr =
2293 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2294 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002295 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2296 io_delegate_.SetFileContents("IFoo.aidl",
2297 "interface IFoo {\n"
2298 " void foo() = 3;\n"
2299 " void bar() = 16777115;\n"
2300 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002301 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002302 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002304}
2305
2306TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002307 const string expected_stderr =
2308 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002309 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2310 io_delegate_.SetFileContents("IFoo.aidl",
2311 "interface IFoo {\n"
2312 " void foo() = 3;\n"
2313 " void bar();\n"
2314 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002315 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002316 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002317 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002318}
2319
Jiyong Parkc6816252019-07-08 08:12:28 +09002320TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2321 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2322 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2323 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2324 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2325}
2326
2327TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002328 const string expected_stderr =
2329 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2330 "dir/IBar.aidl\n"
2331 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002332 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002333
Jiyong Parkc6816252019-07-08 08:12:28 +09002334 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2335 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2336 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2337 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002338 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002339 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002341}
2342
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002343TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2344 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2345 "package a.b;\n"
2346 "import a.b.IBar;\n"
2347 "import a.b.IQux;\n"
2348 "interface IFoo { IQux foo(); }\n");
2349 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2350 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2351
2352 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2353 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2354
2355 string output;
2356 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2357 // IBar was imported but wasn't used. include is not expected.
2358 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2359 // IBar was imported and used. include is expected.
2360 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2361}
2362
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002363TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
2364 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
2365 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A) ")
2366 interface IFoo {
2367 @JavaPassthrough(annotation="@com.android.Bob")
2368 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002369 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002370 })");
2371
2372 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
2373 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2374
2375 string java_out;
2376 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
2377 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)"));
2378 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob"));
2379 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat"));
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002380 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David"));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002381
2382 // Other backends shouldn't be bothered
2383 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
2384 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2385
2386 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
2387 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002388
2389 Options rust_options = Options::From("aidl --lang=rust -o out a/IFoo.aidl");
2390 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002391}
2392
Jiyong Park56f73d72019-06-11 12:20:28 +09002393class AidlOutputPathTest : public AidlTest {
2394 protected:
2395 void SetUp() override {
2396 AidlTest::SetUp();
2397 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2398 }
2399
2400 void Test(const Options& options, const std::string expected_output_path) {
2401 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2402 // check the existence
2403 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2404 }
2405};
2406
2407TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2408 // <out_dir> / <package_name> / <type_name>.java
2409 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2410}
2411
2412TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2413 // when output file is explicitly set, it is always respected. -o option is
2414 // ignored.
2415 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2416}
2417
2418TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2419 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2420}
2421
2422TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2423 // output is the same as the input file except for the suffix
2424 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2425}
2426
Devin Moore7b8d5c92020-03-17 14:14:08 -07002427TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002428 AidlError error;
2429 const string expected_stderr =
2430 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2431 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002432 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2433 R"(package p;
2434 interface IFoo {
2435 const int int32_max_oob = 2147483650;
2436 }
2437 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002438 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2440 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002441}
2442
Devin Moore7b8d5c92020-03-17 14:14:08 -07002443TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002444 AidlError error;
2445 const string expected_stderr =
2446 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2447 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002448 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2449 R"(package p;
2450 interface IFoo {
2451 const int int32_min_oob = -2147483650;
2452 }
2453 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002454 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2456 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002457}
2458
Devin Moore7b8d5c92020-03-17 14:14:08 -07002459TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002460 AidlError error;
2461 const string expected_stderr =
2462 "ERROR: Could not parse integer: 21474836509999999999999999 at p/IFoo.aidl:3.59-85.\n";
2463 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002464 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2465 R"(package p;
2466 interface IFoo {
2467 const long int64_max_oob = 21474836509999999999999999;
2468 }
2469 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002470 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002471 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2472 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002473}
2474
Devin Moore7b8d5c92020-03-17 14:14:08 -07002475TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002476 AidlError error;
2477 const string expected_stderr =
2478 "ERROR: Could not parse integer: 21474836509999999999999999 at p/IFoo.aidl:3.61-86.\n";
2479 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002480 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2481 R"(package p;
2482 interface IFoo {
2483 const long int64_min_oob = -21474836509999999999999999;
2484 }
2485 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002486 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002487 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2488 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002489}
2490
Devin Moore7b8d5c92020-03-17 14:14:08 -07002491TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002492 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002493 const string expected_stderr =
2494 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2495 "literal: byte\n"
2496 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2497 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002498 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2499 R"(package p;
2500 @Backing(type="byte")
2501 enum TestEnum {
2502 FOO = 127,
2503 BAR,
2504 }
2505 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002506 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002507 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002508 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002509}
2510
Devin Mooredecaf292020-04-30 09:16:40 -07002511TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2512 AidlError error;
2513 const string expected_stderr =
2514 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2515 "be one of: type\n"
2516 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2517 "be one of: type\n";
2518 CaptureStderr();
2519 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2520 R"(package p;
2521 @Backing(foo="byte")
2522 enum TestEnum {
2523 FOO = 1,
2524 BAR,
2525 }
2526 )",
2527 typenames_, GetLanguage(), &error));
2528 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2529 EXPECT_EQ(AidlError::BAD_TYPE, error);
2530}
2531
Jeongik Chad0a10272020-08-06 16:33:36 +09002532TEST_P(AidlTest, SupportJavaOnlyImmutableAnnotation) {
2533 io_delegate_.SetFileContents("Foo.aidl",
2534 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2535 "Map<String, Baz> d; Bar[] e; }");
2536 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2537 io_delegate_.SetFileContents("Baz.aidl",
2538 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002539 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2540 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2541}
2542
Jeongik Chad0a10272020-08-06 16:33:36 +09002543TEST_P(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
2544 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002545 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2546 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2547 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2548}
2549
2550TEST_P(AidlTest, ImmtuableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002551 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002552 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2553 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2554 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2555}
2556
2557TEST_P(AidlTest, ImmtuableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002558 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002559 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2560 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2561 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2562}
2563
Jeongik Cha91180252020-07-31 15:43:11 +09002564TEST_P(AidlTest, ImmtuableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002565 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002566 Options options = Options::From("aidl --lang=java Foo.aidl");
2567 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002568 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002569 "capitalizing the first letter\n";
2570 CaptureStderr();
2571 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2572 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2573}
Devin Moore53fc99c2020-08-12 08:07:52 -07002574
2575TEST_P(AidlTest, GenericStructuredParcelable) {
2576 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
2577 Options options =
2578 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2579 const string expected_stderr = "";
2580 CaptureStderr();
2581 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2582 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2583}
2584
2585TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
2586 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
2587 Options options =
2588 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2589 const string expected_stderr =
2590 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
2591 CaptureStderr();
2592 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2593 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2594}
2595
2596TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
2597 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
2598 Options options =
2599 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2600 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
2601 CaptureStderr();
2602 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2603 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2604}
2605
Christopher Wiley90be4e32015-10-20 14:55:25 -07002606} // namespace aidl
2607} // namespace android