blob: d76d4491951f000fc04654ad1b39f9701a6c9be9 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900395 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
425 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jooyung Han1cbc4962020-10-25 10:07:15 +0900583TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
584 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
585 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
586 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
Jooyung Han1cbc4962020-10-25 10:07:15 +0900597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
Jooyung Han1cbc4962020-10-25 10:07:15 +0900601TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
602 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
603 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
604 CaptureStderr();
605 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
606 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
607 EXPECT_EQ("", GetCapturedStderr());
608
609 const string expected_to_string_method = R"--(
610 @Override
611 public String toString() {
612 switch (_tag) {
613 case a: return "a.Foo.a(" + (getA()) + ")";
614 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
615 }
616 throw new IllegalStateException("unknown field: " + _tag);
617 }
618)--";
619
620 string java_out;
621 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
622 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
623}
624
Jooyung Han90345002020-10-23 15:28:53 +0900625TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 {
Jooyung Han90345002020-10-23 15:28:53 +0900627 io_delegate_.SetFileContents("a/Foo.aidl",
628 "package a; @JavaDerive(blah=true) parcelable Foo{}");
629 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
630 CaptureStderr();
631 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 const std::string expected_stderr =
633 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
634 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
635 }
636
637 {
638 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900639 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
640 CaptureStderr();
641 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
642 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900643 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000644 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
645 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
647 }
648
649 {
Jooyung Han90345002020-10-23 15:28:53 +0900650 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900651 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
652 CaptureStderr();
653 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
654 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900655 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900656 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
658 }
659}
660
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900661TEST_P(AidlTest, ParseDescriptorAnnotation) {
662 AidlError error;
663 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
664 typenames_, GetLanguage(), &error, {"--structured"});
665 ASSERT_EQ(AidlError::OK, error);
666 ASSERT_NE(nullptr, parse_result);
667 const AidlInterface* interface = parse_result->AsInterface();
668 ASSERT_NE(nullptr, interface);
669 ASSERT_EQ("IBar", interface->GetDescriptor());
670}
671
Jiyong Park40782d02020-07-24 19:17:43 +0900672TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700673 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900675}
676
677TEST_P(AidlTest, AcceptsOnewayInterface) {
678 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700679 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700680}
Christopher Wileyef140932015-11-03 09:29:19 -0800681
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700683 const string oneway_method =
684 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700685 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100686}
687
Steven Moreland65297cc2020-04-20 20:17:36 -0700688TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
689 const string oneway_method =
690 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
691 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
692 ASSERT_NE(nullptr, defined);
693 const AidlInterface* iface = defined->AsInterface();
694 ASSERT_NE(nullptr, iface);
695
696 const auto& methods = iface->GetMethods();
697 ASSERT_EQ(1u, methods.size());
698 const auto& method = methods[0];
699 const AidlTypeSpecifier& ret_type = method->GetType();
700
701 // TODO(b/151102494): these annotations should be on the method
702 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
703 ASSERT_TRUE(ret_type.IsHide());
704}
705
Devin Moore7b8d5c92020-03-17 14:14:08 -0700706TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100707 string foo_interface =
708 "package a; /* foo */ interface IFoo {"
709 " /* i */ int i();"
710 " /* j */ @nullable String j();"
711 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
712
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
715 EXPECT_EQ("/* foo */", parse_result->GetComments());
716
717 const AidlInterface* interface = parse_result->AsInterface();
718 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
719 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
720 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
721}
722
Jooyung Han1a551d32020-10-05 15:37:26 +0900723TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
724 io_delegate_.SetFileContents("p/cpp_header.aidl",
725 R"(package p;
726 parcelable cpp_header cpp_header "bar/header";)");
727 import_paths_.emplace("");
728 const string input_path = "p/IFoo.aidl";
729 const string input = R"(package p;
730 import p.cpp_header;
731 interface IFoo {
732 // get bar
733 cpp_header get();
734 })";
735
736 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
737 EXPECT_NE(nullptr, parse_result);
738 const AidlInterface* interface = parse_result->AsInterface();
739 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
740}
741
Christopher Wileyef140932015-11-03 09:29:19 -0800742TEST_F(AidlTest, ParsesPreprocessedFile) {
743 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
744 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700745 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900746 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700747 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
748 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800749}
750
751TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
752 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
753 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900754
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700755 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900756 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700757 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
758 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800759}
760
Devin Moore7b8d5c92020-03-17 14:14:08 -0700761TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800762 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
763 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
764 "interface IBar {}");
765 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900766 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900767 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700768 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800769 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900770
Christopher Wiley41544372015-11-03 14:52:29 -0800771 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700772 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
773 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800774 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700775 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900776 ambiguous_type.Resolve(typenames_);
777 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800778}
779
Jiyong Park8f6ec462020-01-19 20:52:47 +0900780// Special case of PreferImportToPreprocessed. Imported type should be preferred
781// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700782TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900783 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
784 io_delegate_.SetFileContents("one/IBar.aidl",
785 "package one; "
786 "interface IBar {}");
787 preprocessed_files_.push_back("preprocessed");
788 import_paths_.emplace("");
789 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700790 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900791 EXPECT_NE(nullptr, parse_result);
792
793 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700794 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
795 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900796 // But if we request just "IBar" we should get our imported one.
797 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
798 ambiguous_type.Resolve(typenames_);
799 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
800}
801
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800802TEST_F(AidlTest, WritePreprocessedFile) {
803 io_delegate_.SetFileContents("p/Outer.aidl",
804 "package p; parcelable Outer.Inner;");
805 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
806 "interface IBar {}");
807
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900808 vector<string> args {
809 "aidl",
810 "--preprocess",
811 "preprocessed",
812 "p/Outer.aidl",
813 "one/IBar.aidl"};
814 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800815 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
816
817 string output;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
819 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
820}
821
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900822TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100823 io_delegate_.SetFileContents(
824 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800825 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100826 "parcelable Rect {\n"
827 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800828 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100829 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800830 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100831 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100832 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
833 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100834 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900835 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900836 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100837 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900838
839 vector<string> args{"aidl", "Rect.aidl"};
840 Options options = Options::From(args);
841 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
842
843 string output;
844 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900845 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900846}
847
Devin Moore2f2077a2020-08-28 11:27:53 -0700848TEST_F(AidlTest, CppHeaderIncludes) {
849 io_delegate_.SetFileContents("IFoo.aidl",
850 "interface IFoo {\n"
851 " @nullable List<String> foo();\n"
852 "}");
853
854 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
855 Options options = Options::From(args);
856 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
857 std::vector<std::string> empty;
858 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
859 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
860 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
861
862 // Make sure the optional and String16.h includes are added
863 string output;
864 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
865 EXPECT_EQ(kExpectedCppHeaderOutput, output);
866}
867
Devin Moore7b8d5c92020-03-17 14:14:08 -0700868TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800870 io_delegate_.SetFileContents("p/Outer.aidl",
871 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900872 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700873 CaptureStderr();
874 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
875 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700876 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800878}
879
Devin Moore7b8d5c92020-03-17 14:14:08 -0700880TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800881 io_delegate_.SetFileContents("preprocessed",
882 "parcelable p.Outer.Inner;");
883 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900884 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800886 // TODO(wiley): This should actually return nullptr because we require
887 // the outer class name. However, for legacy reasons,
888 // this behavior must be maintained. b/17415692
889 EXPECT_NE(nullptr, parse_result);
890}
891
Christopher Wiley632801d2015-11-05 14:15:49 -0800892TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700893 const string expected_foo_stderr =
894 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
895 "Declared parcelables should be in their own file and/or cannot be used with --structured "
896 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700897 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
898
Christopher Wiley632801d2015-11-05 14:15:49 -0800899 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700900 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900902 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700903 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900904
Steven Morelande2c64b42018-09-18 15:06:37 -0700905 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900906 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700907 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900908 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700909 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700910
Devin Moore097a3ab2020-03-11 16:08:44 -0700911 const string expected_bar_stderr =
912 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
913 "Declared parcelables should be in their own file and/or cannot be used with --structured "
914 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700915 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
916
Jiyong Parkda8c6932019-08-12 19:56:08 +0900917 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700918 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700919 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900920 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700922 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700923 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700924 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700925 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800926}
927
Devin Moore7b8d5c92020-03-17 14:14:08 -0700928TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700929 const string expected_stderr =
930 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
931 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700932 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
933 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 AidlError error;
935 CaptureStderr();
936 EXPECT_EQ(
937 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700938 Parse("p/IFoo.aidl",
939 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700940 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
942 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700943}
944
Devin Moore7b8d5c92020-03-17 14:14:08 -0700945TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 AidlError error;
947 const string expected_stderr =
948 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
949 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900950 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
951 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700952 interface IFoo {
953 const String DUPLICATED = "d";
954 const int DUPLICATED = 1;
955 }
956 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 EXPECT_EQ(expected_stderr, GetCapturedStderr());
959 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700960}
961
Steven Morelande689da22020-11-10 02:06:30 +0000962TEST_P(AidlTest, FailOnTooBigConstant) {
963 AidlError error;
964 const string expected_stderr =
965 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
966 CaptureStderr();
967 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
968 R"(package p;
969 interface IFoo {
970 const byte type2small = 256;
971 }
972 )",
973 typenames_, GetLanguage(), &error));
974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
975 EXPECT_EQ(AidlError::BAD_TYPE, error);
976}
977
Devin Moore7b8d5c92020-03-17 14:14:08 -0700978TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700979 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700980 const string expected_stderr =
981 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700982 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700983 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
984 R"(package p;
985 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700986 parcelable IBar {}
987 parcelable StructuredParcelable {}
988 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900989 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700992 // Parse success is important for clear error handling even if the cases aren't
993 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700994 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700995}
996
Devin Moore7b8d5c92020-03-17 14:14:08 -0700997TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700998 AidlError error;
999 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1000 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001004}
1005
Steven Morelandf9e922f2020-07-08 21:15:27 +00001006TEST_P(AidlTest, FailOnEmptyListWithComma) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1010 CaptureStderr();
1011 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1012 typenames_, GetLanguage(), &error));
1013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1014 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1015}
1016
Devin Moore7b8d5c92020-03-17 14:14:08 -07001017TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001018 AidlError error;
1019 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001020 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001022 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1023 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001024 interface IFoo {
1025 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1026 }
1027 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001028 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001029 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1030 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001031}
1032
Jiyong Park18132182020-06-08 20:24:40 +09001033TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1034 AidlError error;
1035 const string expected_stderr =
1036 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1037 "cpp_header (which can also be used as an identifier)\n";
1038 CaptureStderr();
1039 // Notice the trailing dot(.) in the name, which isn't a correct name
1040 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1041 GetLanguage(), &error));
1042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1043 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1044}
1045
1046TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1047 AidlError error;
1048 const string expected_stderr =
1049 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1050 "cpp_header (which can also be used as an identifier)\n";
1051 CaptureStderr();
1052 // Notice the trailing dot(.) in the package name
1053 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1054 GetLanguage(), &error));
1055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1056 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1057}
1058
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001061 auto parse_result = Parse("p/IFoo.aidl",
1062 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001063 interface IFoo {
1064 const int POSITIVE_HEX_VALUE = 0xf5;
1065 }
1066 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001067 typenames_, GetLanguage(), &error);
1068 EXPECT_NE(nullptr, parse_result);
1069 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001070 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001071 const auto& cpp_constants = interface->GetConstantDeclarations();
1072 EXPECT_EQ((size_t)1, cpp_constants.size());
1073 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001074 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001075 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001076}
1077
Devin Moore7b8d5c92020-03-17 14:14:08 -07001078TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001079 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080 auto parse_result = Parse("p/IFoo.aidl",
1081 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001082 interface IFoo {
1083 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1084 }
1085 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001086 typenames_, GetLanguage(), &error);
1087 ASSERT_NE(nullptr, parse_result);
1088 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001089 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001090 const auto& cpp_constants = interface->GetConstantDeclarations();
1091 EXPECT_EQ((size_t)1, cpp_constants.size());
1092 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001093 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001094 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001095}
1096
Devin Moore7b8d5c92020-03-17 14:14:08 -07001097TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001098 io_delegate_.SetFileContents(
1099 "p/Outer.aidl",
1100 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001101 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001102 const string input_path = "p/IFoo.aidl";
1103 const string input = "package p; import p.Outer; interface IFoo"
1104 " { Outer.Inner get(); }";
1105
Devin Moore7b8d5c92020-03-17 14:14:08 -07001106 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1107 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001108
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001109 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001110 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001111 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1112 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001113}
1114
Devin Moore7b8d5c92020-03-17 14:14:08 -07001115TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001116 io_delegate_.SetFileContents(
1117 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001118 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001119 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001120 const string input_path = "p/IFoo.aidl";
1121 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1123 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001124 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001125 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1126 native_type.Resolve(typenames_);
1127
1128 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1129 // C++ understands C++ specific stuff
1130 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1131 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001132 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001133 EXPECT_EQ(1u, headers.size());
1134 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001135}
1136
Christopher Wileyf8136192016-04-12 14:19:35 -07001137TEST_F(AidlTest, WritesCorrectDependencyFile) {
1138 // While the in tree build system always gives us an output file name,
1139 // other android tools take advantage of our ability to infer the intended
1140 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001141 vector<string> args = {
1142 "aidl",
1143 "-d dep/file/path",
1144 "-o place/for/output",
1145 "p/IFoo.aidl"};
1146 Options options = Options::From(args);
1147 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001148 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001149 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001150 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001151 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1152}
1153
Dan Willemsen93298ee2016-11-10 23:55:55 -08001154TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1155 // While the in tree build system always gives us an output file name,
1156 // other android tools take advantage of our ability to infer the intended
1157 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001158 vector<string> args = {
1159 "aidl",
1160 "-d dep/file/path",
1161 "--ninja",
1162 "-o place/for/output",
1163 "p/IFoo.aidl"};
1164 Options options = Options::From(args);
1165 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001166 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001167 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001168 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001169 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1170}
1171
Jiyong Parkdf202122019-09-30 20:48:35 +09001172TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001173 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1174 // this by calling aidl with every .aidl file it finds, then parsing the
1175 // generated dependency files. Those that reference .java output files are
1176 // for interfaces and those that do not are parcelables. However, for both
1177 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001178 vector<string> args = {
1179 "aidl",
1180 "-o place/for/output",
1181 "-d dep/file/path",
1182 "p/Foo.aidl"};
1183 Options options = Options::From(args);
1184 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001185 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001186 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001187 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001188 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1189}
1190
1191TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1192 vector<string> args = {
1193 "aidl",
1194 "--structured",
1195 "-o place/for/output",
1196 "-d dep/file/path",
1197 "p/Foo.aidl"};
1198 Options options = Options::From(args);
1199 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1200 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1201 string actual_dep_file_contents;
1202 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1203 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001204}
1205
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001206TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1207 vector<string> args = {
1208 "aidl",
1209 "--lang=java",
1210 "-o place/for/output",
1211 "p/Foo.aidl"};
1212 Options options = Options::From(args);
1213 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1214 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1215 string output_file_contents;
1216 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1217}
1218
Jeongik Cha08ca2182019-11-21 14:01:13 +09001219// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001220TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001221 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001222 "package a; interface IFoo {\n"
1223 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001224 string expected_stderr;
1225 switch (GetLanguage()) {
1226 case Options::Language::CPP:
1227 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001228 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1230 "String and IBinder.\n";
1231 break;
1232 case Options::Language::JAVA:
1233 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001234 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001235 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1236 "String, IBinder, and ParcelFileDescriptor.\n";
1237 break;
1238 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001239 case Options::Language::RUST:
1240 expected_stderr =
1241 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1242 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001243 default:
1244 AIDL_FATAL(AIDL_LOCATION_HERE)
1245 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1246 }
1247 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001248 AidlTypenames tn1;
1249 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001251
1252 string primitive_parcelable =
1253 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001254 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001255 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001256 AidlTypenames tn2;
1257 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001258 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001259}
1260
Devin Moore21b26772020-08-26 16:37:56 -07001261TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001262 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001263 const string list_array_parcelable =
1264 "package a; parcelable Foo {\n"
1265 " List[] lists; }";
1266 CaptureStderr();
1267 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1268 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1269}
1270
Jiyong Parkf8d53612020-05-04 14:06:13 +09001271TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1272 AidlError error;
1273 string expected_stderr =
1274 "ERROR: a/IFoo.aidl:2.7-11: "
1275 "Encountered an untyped List or Map. The use of untyped List/Map is "
1276 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1277 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1278 if (GetLanguage() != Options::Language::JAVA) {
1279 expected_stderr =
1280 "ERROR: a/IFoo.aidl:2.1-7: "
1281 "Currently, only the Java backend supports non-generic List.\n";
1282 }
1283
1284 const string primitive_interface =
1285 "package a; interface IFoo {\n"
1286 " List foo(); }";
1287 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001288 AidlTypenames tn1;
1289 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001290 {"--structured"}));
1291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001292
1293 string primitive_parcelable =
1294 "package a; parcelable IFoo {\n"
1295 " List foo;}";
1296 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001297 AidlTypenames tn2;
1298 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001299 {"--structured"}));
1300 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1301}
1302
Jeongik Cha225519b2020-08-29 01:55:32 +09001303TEST_P(AidlTest, ExtensionTest) {
1304 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001305 string extendable_parcelable =
1306 "package a; parcelable Data {\n"
1307 " ParcelableHolder extension;\n"
1308 " ParcelableHolder extension2;\n"
1309 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001310 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001311 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1312 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001313 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001314 "yet.\n",
1315 GetCapturedStderr());
1316 } else {
1317 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1318 EXPECT_EQ("", GetCapturedStderr());
1319 }
1320}
1321TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1322 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001323 string parcelableholder_return_interface =
1324 "package a; interface IFoo {\n"
1325 " ParcelableHolder foo();\n"
1326 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001327 EXPECT_EQ(nullptr,
1328 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001329
Jeongik Cha8f02a532020-10-14 00:16:28 +09001330 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001332 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001333 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001334 "yet.\n",
1335 GetCapturedStderr());
1336 return;
1337 }
1338 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1339 GetCapturedStderr());
1340}
1341
1342TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1343 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001344 string extendable_parcelable_arg_interface =
1345 "package a; interface IFoo {\n"
1346 " void foo(in ParcelableHolder ph);\n"
1347 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001348 EXPECT_EQ(nullptr,
1349 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1350
Jeongik Cha8f02a532020-10-14 00:16:28 +09001351 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001352 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001353 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001354 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001355 "yet.\n",
1356 GetCapturedStderr());
1357 return;
1358 }
1359 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1360 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001361}
1362
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001363TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1364 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1365 Options options =
1366 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1367 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1368 CaptureStderr();
1369 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1370 if (GetLanguage() == Options::Language::RUST) {
1371 EXPECT_EQ(
1372 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1373 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1374 "yet.\n",
1375 GetCapturedStderr());
1376 return;
1377 }
1378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1379}
1380
Jiyong Park02da7422018-07-16 16:00:26 +09001381TEST_F(AidlTest, ApiDump) {
1382 io_delegate_.SetFileContents(
1383 "foo/bar/IFoo.aidl",
1384 "package foo.bar;\n"
1385 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001386 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001387 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001388 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001389 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1390 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1391 " IFoo foo3(IFoo foo);\n"
1392 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001393 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001394 " const int A = 1;\n"
1395 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001396 "}\n");
1397 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1398 "package foo.bar;\n"
1399 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001400 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001401 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001402 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001403 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001404 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001405 " int y;\n"
1406 " IFoo foo;\n"
1407 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001408 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001409 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001410 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001411 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001412 "}\n");
1413 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001414 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1415 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001416 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001417 bool result = dump_api(options, io_delegate_);
1418 ASSERT_TRUE(result);
1419 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001420 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001421 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001422/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001423interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001424 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001425 int foo(out int[] a, String b, boolean c, inout List<String> d);
1426 int foo2(@utf8InCpp String x, inout List<String> y);
1427 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1428 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001429 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001430 const int A = 1;
1431 const String STR = "Hello";
1432}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001433)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001434
Jiyong Parke59c3682018-09-11 23:10:25 +09001435 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001436 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001437/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001438parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001439 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001440 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001441 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001442 int y;
1443 foo.bar.IFoo foo;
1444 List<foo.bar.IFoo> a;
1445 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001446 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001447 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001448}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001449)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001450}
1451
Jiyong Parked65bf42018-08-28 15:43:27 +09001452TEST_F(AidlTest, ApiDumpWithManualIds) {
1453 io_delegate_.SetFileContents(
1454 "foo/bar/IFoo.aidl",
1455 "package foo.bar;\n"
1456 "interface IFoo {\n"
1457 " int foo() = 1;\n"
1458 " int bar() = 2;\n"
1459 " int baz() = 10;\n"
1460 "}\n");
1461
Jiyong Parke59c3682018-09-11 23:10:25 +09001462 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001463 Options options = Options::From(args);
1464 bool result = dump_api(options, io_delegate_);
1465 ASSERT_TRUE(result);
1466 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001467 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001468 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001469interface IFoo {
1470 int foo() = 1;
1471 int bar() = 2;
1472 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001473}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001474)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001475}
1476
1477TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001478 const string expected_stderr =
1479 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1480 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001481 io_delegate_.SetFileContents(
1482 "foo/bar/IFoo.aidl",
1483 "package foo.bar;\n"
1484 "interface IFoo {\n"
1485 " int foo() = 1;\n"
1486 " int bar();\n"
1487 " int baz() = 10;\n"
1488 "}\n");
1489
Jiyong Parke59c3682018-09-11 23:10:25 +09001490 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001491 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001492 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001493 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001494 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001495}
1496
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001497TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001498 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001499 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1500 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001501 const string expected_map_stderr =
1502 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001503 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1504 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001505 "package p; interface IFoo {"
1506 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001507 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001508 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001509 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001510
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001511 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001512 "package p; interface IFoo {"
1513 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001514 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001515 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001516 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001517}
1518
Jeongik Chae48d9942020-01-02 17:39:00 +09001519TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001520 const string expected_stderr =
1521 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001522 Options options = Options::From("aidl -I p p/IFoo.aidl");
1523 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1524
1525 io_delegate_.SetFileContents("p/IFoo.aidl",
1526 "package p; interface IFoo {"
1527 "Map<String, Bar> foo();}");
1528 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1529
1530 io_delegate_.SetFileContents("p/IFoo.aidl",
1531 "package p; interface IFoo {"
1532 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001533 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001534 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001535 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001536
1537 io_delegate_.SetFileContents("p/IFoo.aidl",
1538 "package p; interface IFoo {"
1539 "Map<String, String> foo();}");
1540 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1541
1542 io_delegate_.SetFileContents("p/IFoo.aidl",
1543 "package p; interface IFoo {"
1544 "Map<String, ParcelFileDescriptor> foo();}");
1545 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1546}
1547
Jeongik Chadf76dc72019-11-28 00:08:47 +09001548TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001549 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001550 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1551 io_delegate_.SetFileContents(options.InputFiles().front(),
1552 "package p; interface IFoo {"
1553 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001554 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001555 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001556 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001557}
1558
1559TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1560 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1561 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001562 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001563 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001564 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1565 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001566
1567 Options options = Options::From("aidl -I p p/IFoo.aidl");
1568 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1569 io_delegate_.SetFileContents("p/IFoo.aidl",
1570 "package p; interface IFoo {"
1571 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001572 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001573 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001574 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001575 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001576 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001577 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001578 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1579 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001580 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1581 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1582 io_delegate_.SetFileContents("p/IFoo.aidl",
1583 "package p; interface IFoo {"
1584 "Bar<String, ParcelFileDescriptor> foo();}");
1585 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001586
1587 io_delegate_.SetFileContents("p/IFoo.aidl",
1588 "package p; interface IFoo {"
1589 "Bar<int, long> foo();}");
1590
1591 io_delegate_.SetFileContents("p/IFoo.aidl",
1592 "package p; interface IFoo {"
1593 "Bar<int[], long[]> foo();}");
1594
1595 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001596}
1597
Jeongik Cha0e426012019-07-29 15:57:02 +09001598TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1599 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001600 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1601 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001602 for (const auto& rawOption : rawOptions) {
1603 string expected_stderr =
1604 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001605 Options options = Options::From(rawOption);
1606 io_delegate_.SetFileContents(options.InputFiles().front(),
1607 "package foo.bar;\n"
1608 "interface IFoo1 { int foo(); }\n"
1609 "interface IFoo2 { int foo(); }\n"
1610 "parcelable Data1 { int a; int b;}\n"
1611 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001612 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001613 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001614 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001615
Jeongik Cha0e426012019-07-29 15:57:02 +09001616 io_delegate_.SetFileContents(options.InputFiles().front(),
1617 "package foo.bar;\n"
1618 "interface IFoo1 { int foo(); }\n"
1619 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001620 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001621 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001623
Devin Moore5de18ed2020-04-02 13:52:29 -07001624 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001625 io_delegate_.SetFileContents(options.InputFiles().front(),
1626 "package foo.bar;\n"
1627 "parcelable Data1 { int a; int b;}\n"
1628 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001629 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001630 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001631 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001632 }
1633}
1634
Devin Moorebdba2a82020-03-31 15:19:02 -07001635TEST_P(AidlTest, FailParseOnEmptyFile) {
1636 const string contents = "";
1637 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1638 CaptureStderr();
1639 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1640 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1641}
1642
Jiyong Parkb034bf02018-07-30 17:44:33 +09001643TEST_F(AidlTest, MultipleInputFiles) {
1644 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001645 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001646
1647 io_delegate_.SetFileContents(options.InputFiles().at(0),
1648 "package foo.bar;\n"
1649 "import foo.bar.Data;\n"
1650 "interface IFoo { Data getData(); }\n");
1651
1652 io_delegate_.SetFileContents(options.InputFiles().at(1),
1653 "package foo.bar;\n"
1654 "import foo.bar.IFoo;\n"
1655 "parcelable Data { IFoo foo; }\n");
1656
1657 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1658
1659 string content;
1660 for (const auto file : {
1661 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1662 content.clear();
1663 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1664 EXPECT_FALSE(content.empty());
1665 }
1666}
1667
1668TEST_F(AidlTest, MultipleInputFilesCpp) {
1669 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001670 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001671
1672 io_delegate_.SetFileContents(options.InputFiles().at(0),
1673 "package foo.bar;\n"
1674 "import foo.bar.Data;\n"
1675 "interface IFoo { Data getData(); }\n");
1676
1677 io_delegate_.SetFileContents(options.InputFiles().at(1),
1678 "package foo.bar;\n"
1679 "import foo.bar.IFoo;\n"
1680 "parcelable Data { IFoo foo; }\n");
1681
1682 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1683
1684 string content;
1685 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001686 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001687 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1688 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1689 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1690 content.clear();
1691 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1692 EXPECT_FALSE(content.empty());
1693 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001694}
1695
Andrei Homescub62afd92020-05-11 19:24:59 -07001696TEST_F(AidlTest, MultipleInputFilesRust) {
1697 Options options =
1698 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1699
1700 io_delegate_.SetFileContents(options.InputFiles().at(0),
1701 "package foo.bar;\n"
1702 "import foo.bar.Data;\n"
1703 "interface IFoo { Data getData(); }\n");
1704
1705 io_delegate_.SetFileContents(options.InputFiles().at(1),
1706 "package foo.bar;\n"
1707 "import foo.bar.IFoo;\n"
1708 "parcelable Data { IFoo foo; }\n");
1709
1710 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1711
1712 string content;
1713 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1714 content.clear();
1715 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1716 EXPECT_FALSE(content.empty());
1717 }
1718}
1719
Devin Moore097a3ab2020-03-11 16:08:44 -07001720TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1721 const string expected_stderr =
1722 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001723 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1724 // int getInterfaceVersion() is one of the meta transactions
1725 io_delegate_.SetFileContents(options.InputFiles().front(),
1726 "package p; interface IFoo {"
1727 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001728 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001729 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001730 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1731}
Jiyong Park309668e2018-07-28 16:55:44 +09001732
Devin Moore097a3ab2020-03-11 16:08:44 -07001733TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1734 // boolean getInterfaceVersion() is not a meta transaction, but should be
1735 // prevented because return type is not part of a method signature
1736 const string expected_stderr =
1737 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1738 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001739 io_delegate_.SetFileContents(options.InputFiles().front(),
1740 "package p; interface IFoo {"
1741 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001743 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001744 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1745}
Jiyong Park309668e2018-07-28 16:55:44 +09001746
Devin Moore097a3ab2020-03-11 16:08:44 -07001747TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001748 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001749 const string expected_stderr =
1750 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1751 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001752 io_delegate_.SetFileContents(options.InputFiles().front(),
1753 "package p; interface IFoo {"
1754 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001755 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001756 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001757 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001758
1759 // this is not a meta interface method as it differs type arguments
1760 io_delegate_.SetFileContents(options.InputFiles().front(),
1761 "package p; interface IFoo {"
1762 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001763 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001764}
1765
Daniel Norman85aed542019-08-21 12:01:14 -07001766TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001767 Options options = Options::From("aidl --checkapi old new");
1768 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1769 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1770 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1771 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1772
1773 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1774}
1775
Jiyong Park3656c3c2018-08-01 20:02:01 +09001776TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001777 Options options = Options::From("aidl --checkapi old new");
1778 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1779 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001780
1781 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1782}
1783
Daniel Norman85aed542019-08-21 12:01:14 -07001784class AidlTestCompatibleChanges : public AidlTest {
1785 protected:
1786 Options options_ = Options::From("aidl --checkapi old new");
1787};
1788
1789TEST_F(AidlTestCompatibleChanges, NewType) {
1790 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1791 "package p;"
1792 "interface IFoo {"
1793 " void foo(int a);"
1794 "}");
1795 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1796 "package p;"
1797 "interface IFoo {"
1798 " void foo(int a);"
1799 "}");
1800 io_delegate_.SetFileContents("new/p/IBar.aidl",
1801 "package p;"
1802 "interface IBar {"
1803 " void bar();"
1804 "}");
1805 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1806}
1807
1808TEST_F(AidlTestCompatibleChanges, NewMethod) {
1809 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1810 "package p;"
1811 "interface IFoo {"
1812 " void foo(int a);"
1813 "}");
1814 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1815 "package p;"
1816 "interface IFoo {"
1817 " void foo(int a);"
1818 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001819 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001820 "}");
1821 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1822}
1823
1824TEST_F(AidlTestCompatibleChanges, NewField) {
1825 io_delegate_.SetFileContents("old/p/Data.aidl",
1826 "package p;"
1827 "parcelable Data {"
1828 " int foo;"
1829 "}");
1830 io_delegate_.SetFileContents("new/p/Data.aidl",
1831 "package p;"
1832 "parcelable Data {"
1833 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001834 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001835 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001836 "}");
1837 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1838}
1839
1840TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1841 io_delegate_.SetFileContents("old/p/Enum.aidl",
1842 "package p;"
1843 "enum Enum {"
1844 " FOO = 1,"
1845 "}");
1846 io_delegate_.SetFileContents("new/p/Enum.aidl",
1847 "package p;"
1848 "enum Enum {"
1849 " FOO = 1,"
1850 " BAR = 2,"
1851 "}");
1852 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1853}
1854
1855TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1856 io_delegate_.SetFileContents("old/p/Enum.aidl",
1857 "package p;"
1858 "enum Enum {"
1859 " FOO = 1,"
1860 " BAR = 2,"
1861 "}");
1862 io_delegate_.SetFileContents("new/p/Enum.aidl",
1863 "package p;"
1864 "enum Enum {"
1865 " BAR = 2,"
1866 " FOO = 1,"
1867 "}");
1868 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1869}
1870
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001871TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1872 io_delegate_.SetFileContents("old/p/Union.aidl",
1873 "package p;"
1874 "union Union {"
1875 " String foo;"
1876 "}");
1877 io_delegate_.SetFileContents("new/p/Union.aidl",
1878 "package p;"
1879 "union Union {"
1880 " String foo;"
1881 " int num;"
1882 "}");
1883 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1884}
1885
Daniel Norman85aed542019-08-21 12:01:14 -07001886TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001887 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1888 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001889 "interface IFoo {"
1890 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001891 "}");
1892 io_delegate_.SetFileContents("old/p/Data.aidl",
1893 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001894 "parcelable Data {"
1895 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001896 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001897 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1898 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001899 "interface IFoo {"
1900 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001901 "}");
1902 io_delegate_.SetFileContents("new/p/Data.aidl",
1903 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001904 "parcelable Data {"
1905 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001906 "}");
1907 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1908 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001909 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001910 " void foo(int a);"
1911 "}");
1912 io_delegate_.SetFileContents("new/q/Data.aidl",
1913 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001914 "parcelable Data {"
1915 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001916 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001917 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1918}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001919
Daniel Norman85aed542019-08-21 12:01:14 -07001920TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1921 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1922 "package p;"
1923 "interface IFoo {"
1924 " void foo(int a);"
1925 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001926 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1927 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001928 "interface IFoo {"
1929 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001930 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001931 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1932}
Jiyong Parke59c3682018-09-11 23:10:25 +09001933
Daniel Norman85aed542019-08-21 12:01:14 -07001934TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001935 io_delegate_.SetFileContents("old/p/I.aidl",
1936 "package p; interface I {"
1937 "const int A = 1; }");
1938 io_delegate_.SetFileContents("new/p/I.aidl",
1939 "package p ; interface I {"
1940 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001941 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1942}
Jiyong Parka428d212018-08-29 22:26:30 +09001943
Daniel Norman85aed542019-08-21 12:01:14 -07001944TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001945 io_delegate_.SetFileContents("old/p/I.aidl",
1946 "package p; interface I {"
1947 "const int A = 1; const int B = 2;}");
1948 io_delegate_.SetFileContents("new/p/I.aidl",
1949 "package p ; interface I {"
1950 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001951 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001952}
1953
Jooyung Han69ea4ba2020-10-29 15:33:37 +09001954TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
1955 io_delegate_.SetFileContents("old/p/Foo.aidl",
1956 "package p;"
1957 "@JavaPassthrough(annotation=\"Alice\")"
1958 "@JavaPassthrough(annotation=\"Bob\")"
1959 "parcelable Foo {}");
1960 io_delegate_.SetFileContents("new/p/Foo.aidl",
1961 "package p;"
1962 "@JavaPassthrough(annotation=\"Bob\")"
1963 "@JavaPassthrough(annotation=\"Alice\")"
1964 "parcelable Foo {}");
1965 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1966}
1967
Jooyung Han636fd2f2020-10-22 11:33:45 +09001968TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1969 io_delegate_.SetFileContents("old/p/Data.aidl",
1970 "package p;"
1971 "parcelable Data {"
1972 " int num;"
1973 "}");
1974 io_delegate_.SetFileContents(
1975 "new/p/Data.aidl",
1976 "package p;"
1977 "parcelable Data {"
1978 " int num;"
1979 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1980 "}");
1981 io_delegate_.SetFileContents("new/p/Enum.aidl",
1982 "package p;"
1983 "enum Enum {"
1984 " FOO = 0,"
1985 " BAR = 1,"
1986 "}");
1987 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1988}
1989
Daniel Norman85aed542019-08-21 12:01:14 -07001990class AidlTestIncompatibleChanges : public AidlTest {
1991 protected:
1992 Options options_ = Options::From("aidl --checkapi old new");
1993};
1994
1995TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001996 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001997 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1998 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001999 "interface IFoo {"
2000 " void foo(in String[] str);"
2001 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002002 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002003 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002004 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002005 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002006}
2007
2008TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002009 const string expected_stderr =
2010 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002011 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2012 "package p;"
2013 "interface IFoo {"
2014 " void foo(in String[] str);"
2015 " void bar(@utf8InCpp String str);"
2016 "}");
2017 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2018 "package p;"
2019 "interface IFoo {"
2020 " void foo(in String[] str);"
2021 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002022 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002023 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002024 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002025}
2026
Jiyong Parkf8d53612020-05-04 14:06:13 +09002027TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2028 const string expected_stderr =
2029 "ERROR: new/p/IFoo.aidl:1.61-65: "
2030 "Encountered an untyped List or Map. The use of untyped List/Map is "
2031 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2032 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2033 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2034 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2035 "package p;"
2036 "interface IFoo {"
2037 " void foo(in String[] str);"
2038 "}");
2039 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2040 "package p;"
2041 "interface IFoo {"
2042 " void foo(in String[] str);"
2043 " void bar(in List arg);"
2044 "}");
2045 CaptureStderr();
2046 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2047 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2048}
2049
2050TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2051 const string expected_stderr =
2052 "ERROR: new/p/Data.aidl:1.54-59: "
2053 "Encountered an untyped List or Map. The use of untyped List/Map is "
2054 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2055 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2056 "ERROR: new/p/Data.aidl: Failed to read.\n";
2057 io_delegate_.SetFileContents("old/p/Data.aidl",
2058 "package p;"
2059 "parcelable Data {"
2060 " int foo;"
2061 "}");
2062 io_delegate_.SetFileContents("new/p/Data.aidl",
2063 "package p;"
2064 "parcelable Data {"
2065 " int foo;"
2066 " @nullable List list;"
2067 "}");
2068 CaptureStderr();
2069 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2070 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2071}
2072
Daniel Norman85aed542019-08-21 12:01:14 -07002073TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002074 const string expected_stderr =
2075 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002076 io_delegate_.SetFileContents("old/p/Data.aidl",
2077 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002078 "parcelable Data {"
2079 " int foo;"
2080 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002081 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002082 io_delegate_.SetFileContents("new/p/Data.aidl",
2083 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002084 "parcelable Data {"
2085 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002086 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002087 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002088 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002090}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002091
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002092TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2093 const string expected_stderr =
2094 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2095 "backends. Please either provide a default value for this field or mark the field as "
2096 "@nullable. This value or a null value will be used automatically when an old version of "
2097 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2098 "order to make sure your code continues to be backwards compatible, make sure the default or "
2099 "null value does not cause a semantic change to this parcelable.\n";
2100 io_delegate_.SetFileContents("old/p/Data.aidl",
2101 "package p;"
2102 "parcelable Data {"
2103 " int num;"
2104 "}");
2105 io_delegate_.SetFileContents("new/p/Data.aidl",
2106 "package p;"
2107 "parcelable Data {"
2108 " int num;"
2109 " String str;"
2110 "}");
2111 CaptureStderr();
2112 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2113 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2114}
2115
Jooyung Han636fd2f2020-10-22 11:33:45 +09002116TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2117 const string expected_stderr =
2118 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2119 "Please make sure 'Enum' has '0' as a valid value.\n";
2120 io_delegate_.SetFileContents("old/p/Data.aidl",
2121 "package p;"
2122 "parcelable Data {"
2123 " int num;"
2124 "}");
2125 io_delegate_.SetFileContents("new/p/Data.aidl",
2126 "package p;"
2127 "parcelable Data {"
2128 " int num;"
2129 " p.Enum e;"
2130 "}");
2131 io_delegate_.SetFileContents("new/p/Enum.aidl",
2132 "package p;"
2133 "enum Enum {"
2134 " FOO = 1,"
2135 " BAR = 2,"
2136 "}");
2137 CaptureStderr();
2138 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2139 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2140}
2141
Daniel Norman85aed542019-08-21 12:01:14 -07002142TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002143 const string expected_stderr =
2144 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002145 io_delegate_.SetFileContents("old/p/Enum.aidl",
2146 "package p;"
2147 "enum Enum {"
2148 " FOO = 1,"
2149 " BAR = 2,"
2150 "}");
2151 io_delegate_.SetFileContents("new/p/Enum.aidl",
2152 "package p;"
2153 "enum Enum {"
2154 " BAR = 2,"
2155 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002156 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002157 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002158 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002159}
2160
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002161TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2162 const string expected_stderr =
2163 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2164 io_delegate_.SetFileContents("old/p/Union.aidl",
2165 "package p;"
2166 "union Union {"
2167 " String str;"
2168 " int num;"
2169 "}");
2170 io_delegate_.SetFileContents("new/p/Union.aidl",
2171 "package p;"
2172 "union Union {"
2173 " String str;"
2174 "}");
2175 CaptureStderr();
2176 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2177 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2178}
2179
Daniel Norman85aed542019-08-21 12:01:14 -07002180TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002181 const string expected_stderr =
2182 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002183 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2184 "package p;"
2185 "interface IFoo {"
2186 " void foo(in String[] str);"
2187 " void bar(@utf8InCpp String str);"
2188 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002189 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2190 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002191 "interface IFoo {"
2192 " void foo(in String[] str);"
2193 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002194 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002195 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002196 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002198}
2199
Daniel Norman85aed542019-08-21 12:01:14 -07002200TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002201 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002202 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2203 "package p;"
2204 "interface IFoo {"
2205 " void foo(in String[] str);"
2206 " void bar(@utf8InCpp String str);"
2207 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002208 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2209 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002210 "interface IFoo2 {"
2211 " void foo(in String[] str);"
2212 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002213 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002214 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002215 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002216 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002217}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002218
Daniel Norman85aed542019-08-21 12:01:14 -07002219TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002220 const string expected_stderr =
2221 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002222 io_delegate_.SetFileContents("old/p/Enum.aidl",
2223 "package p;"
2224 "enum Enum {"
2225 " FOO = 1,"
2226 " BAR = 2,"
2227 "}");
2228 io_delegate_.SetFileContents("new/p/Enum.aidl",
2229 "package p;"
2230 "enum Enum {"
2231 " FOO = 3,"
2232 " BAR = 2,"
2233 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002235 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002236 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002237}
2238
2239TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002240 const string expected_stderr =
2241 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2242 "from 0 to 1.\n"
2243 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2244 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002245 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2246 "package p;"
2247 "interface IFoo {"
2248 " void foo(in String[] str);"
2249 " void bar(@utf8InCpp String str);"
2250 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002251 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2252 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002253 "interface IFoo {"
2254 " void bar(@utf8InCpp String str);"
2255 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002256 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002257 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002258 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002260}
2261
2262TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002263 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002264 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2265 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002266 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002267 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002268 "parcelable Data {"
2269 " int foo;"
2270 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002271 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002272 io_delegate_.SetFileContents("new/p/Data.aidl",
2273 "package p;"
2274 "parcelable Data {"
2275 " int bar;"
2276 " int foo;"
2277 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002278 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002279 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002280 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002281}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002282
Daniel Norman85aed542019-08-21 12:01:14 -07002283TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002284 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002285 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002287 "interface IFoo {"
2288 " void foo(in String[] str);"
2289 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002290 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002291 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2292 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002293 "interface IFoo {"
2294 " void foo(out String[] str);"
2295 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002296 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002297 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002298 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002299 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002300}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002301
Daniel Norman85aed542019-08-21 12:01:14 -07002302TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 const string expected_stderr =
2304 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002305 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2306 "package p;"
2307 "interface IFoo {"
2308 " void foo(in String[] str);"
2309 " void bar(@utf8InCpp String str);"
2310 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002311 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2312 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002313 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002314 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002315 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002316 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002317 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002318 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002319 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002320}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002321
Daniel Norman85aed542019-08-21 12:01:14 -07002322TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002323 const string expected_stderr =
2324 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002325 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2326 "package p;"
2327 "interface IFoo {"
2328 " void foo(in String[] str);"
2329 " void bar(@utf8InCpp String str);"
2330 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002331 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2332 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002333 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002334 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002335 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002336 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002337 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002338 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002339 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002340}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002341
Jooyung Han60b2fde2020-10-29 15:12:40 +09002342TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2343 const string expected_stderr =
2344 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2345 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2346 io_delegate_.SetFileContents("old/p/Foo.aidl",
2347 "package p;"
2348 "@Backing(type=\"byte\")"
2349 "enum Foo {"
2350 " FOO, BAR,"
2351 "}");
2352 io_delegate_.SetFileContents("new/p/Foo.aidl",
2353 "package p;"
2354 "@Backing(type=\"long\")"
2355 "enum Foo {"
2356 " FOO, BAR,"
2357 "}");
2358 CaptureStderr();
2359 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2360 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2361}
2362
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002363TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2364 const string expected_stderr =
2365 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2366 "to @JavaPassthrough(annotation=\"Bob\")\n";
2367 io_delegate_.SetFileContents("old/p/Foo.aidl",
2368 "package p;"
2369 "@JavaPassthrough(annotation=\"Alice\")"
2370 "parcelable Foo {}");
2371 io_delegate_.SetFileContents("new/p/Foo.aidl",
2372 "package p;"
2373 "@JavaPassthrough(annotation=\"Bob\")"
2374 "parcelable Foo {}");
2375
2376 CaptureStderr();
2377 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2379}
2380
Devin Mooredb7ac512020-08-07 11:17:36 -07002381TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2382 const string expected_stderr =
2383 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2384 io_delegate_.SetFileContents("old/p/Foo.aidl",
2385 "package p;"
2386 "parcelable Foo {"
2387 " int A;"
2388 "}");
2389 io_delegate_.SetFileContents("new/p/Foo.aidl",
2390 "package p;"
2391 "@JavaOnlyStableParcelable parcelable Foo {"
2392 " int A;"
2393 "}");
2394 CaptureStderr();
2395 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2396 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2397}
2398
2399TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2400 const string expected_stderr =
2401 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2402 io_delegate_.SetFileContents("old/p/Foo.aidl",
2403 "package p;"
2404 "@JavaOnlyStableParcelable parcelable Foo {"
2405 " int A;"
2406 "}");
2407 io_delegate_.SetFileContents("new/p/Foo.aidl",
2408 "package p;"
2409 "parcelable Foo {"
2410 " int A;"
2411 "}");
2412 CaptureStderr();
2413 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2415}
2416
Daniel Norman85aed542019-08-21 12:01:14 -07002417TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002418 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002419 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2420 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002421 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002422 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002423 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002425}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002426
Daniel Norman85aed542019-08-21 12:01:14 -07002427TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002428 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2430 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002431 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002432 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002433 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002434}
Jiyong Parka428d212018-08-29 22:26:30 +09002435
Daniel Norman85aed542019-08-21 12:01:14 -07002436TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002437 const string expected_stderr =
2438 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002439 io_delegate_.SetFileContents("old/p/I.aidl",
2440 "package p; interface I {"
2441 "const int A = 1; const int B = 2;}");
2442 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002443 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002444 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002445 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002446}
Jiyong Parka428d212018-08-29 22:26:30 +09002447
Daniel Norman85aed542019-08-21 12:01:14 -07002448TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002449 const string expected_stderr =
2450 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002451 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2452 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002454 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002456}
2457
Devin Moorec7e47a32020-08-07 10:55:25 -07002458TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2459 const string expected_stderr =
2460 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2461 "This is an incompatible change for FixedSize types.\n";
2462 io_delegate_.SetFileContents("old/p/Foo.aidl",
2463 "package p; @FixedSize parcelable Foo { int A = 1; }");
2464 io_delegate_.SetFileContents("new/p/Foo.aidl",
2465 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2466 CaptureStderr();
2467 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2468 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2469}
2470
2471TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2472 const string expected_stderr =
2473 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2474 io_delegate_.SetFileContents("old/p/Foo.aidl",
2475 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2476 io_delegate_.SetFileContents("new/p/Foo.aidl",
2477 "package p; @FixedSize parcelable Foo { int A = 1; }");
2478 CaptureStderr();
2479 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2480 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2481}
2482
2483TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2484 const string expected_stderr =
2485 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2486 "a.\n"
2487 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2488 "b.\n"
2489 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2490 "c.\n"
2491 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2492 "d.\n"
2493 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2494 "e.\n"
2495 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2496 "f.\n";
2497
2498 io_delegate_.SetFileContents("Foo.aidl",
2499 "@FixedSize parcelable Foo { "
2500 " int[] a;"
2501 " Bar b;"
2502 " String c;"
2503 " ParcelFileDescriptor d;"
2504 " IBinder e;"
2505 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002506 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002507 "}");
2508 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2509 Options options =
2510 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2511
2512 CaptureStderr();
2513 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2514 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2515}
2516
2517TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2518 const string expected_stderr = "";
2519
2520 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2521 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2522 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2523 Options options =
2524 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2525
2526 CaptureStderr();
2527 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2528 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2529}
2530
Jiyong Park8c380532018-08-30 14:55:26 +09002531TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002532 const string expected_stderr =
2533 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2534 "dir1/q/IBar.aidl\n"
2535 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002536 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002537 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2538 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2539 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2540 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2541
Devin Moore097a3ab2020-03-11 16:08:44 -07002542 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002543 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002545}
2546
Jiyong Parked65bf42018-08-28 15:43:27 +09002547TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002548 const string expected_stderr =
2549 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2550 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002551 Options options = Options::From("aidl --checkapi old new");
2552 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2553 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002554
2555 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2556
Jiyong Parke59c3682018-09-11 23:10:25 +09002557 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002558 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002559 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002560 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002561}
2562
Jiyong Parke05195e2018-10-08 18:24:23 +09002563TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2564 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2565 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002566 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002567
2568 // use without import
2569 io_delegate_.SetFileContents("p/IFoo.aidl",
2570 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2571 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2572 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002573 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002574
Devin Moore7b8d5c92020-03-17 14:14:08 -07002575 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002576 io_delegate_.SetFileContents(
2577 "p/IFoo.aidl",
2578 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2579 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2580 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002581 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002582
2583 // use with import (as before)
2584 io_delegate_.SetFileContents("p/IFoo.aidl",
2585 "package p;"
2586 "import android.os.ParcelFileDescriptor;"
2587 "interface IFoo{"
2588 " void foo(in ParcelFileDescriptor fd);"
2589 "}");
2590 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2591 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002592 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002593}
Jiyong Parked65bf42018-08-28 15:43:27 +09002594
Jiyong Park3633b722019-04-11 15:38:26 +09002595TEST_F(AidlTest, ManualIds) {
2596 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2597 io_delegate_.SetFileContents("IFoo.aidl",
2598 "interface IFoo {\n"
2599 " void foo() = 0;\n"
2600 " void bar() = 1;\n"
2601 "}");
2602 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2603}
2604
2605TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2606 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2607 io_delegate_.SetFileContents("IFoo.aidl",
2608 "interface IFoo {\n"
2609 " void foo() = 0;\n"
2610 " void bar() = 1;\n"
2611 "}");
2612 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2613}
2614
2615TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002616 const string expected_stderr =
2617 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002618 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2619 io_delegate_.SetFileContents("IFoo.aidl",
2620 "interface IFoo {\n"
2621 " void foo() = 3;\n"
2622 " void bar() = 3;\n"
2623 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002624 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002625 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002626 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002627}
2628
2629TEST_F(AidlTest, FailOnOutOfRangeIds) {
2630 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002631 const string expected_stderr =
2632 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2633 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002634 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2635 io_delegate_.SetFileContents("IFoo.aidl",
2636 "interface IFoo {\n"
2637 " void foo() = 3;\n"
2638 " void bar() = 16777115;\n"
2639 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002640 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002641 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002642 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002643}
2644
2645TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002646 const string expected_stderr =
2647 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002648 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2649 io_delegate_.SetFileContents("IFoo.aidl",
2650 "interface IFoo {\n"
2651 " void foo() = 3;\n"
2652 " void bar();\n"
2653 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002654 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002655 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002657}
2658
Jiyong Parkc6816252019-07-08 08:12:28 +09002659TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2660 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2661 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2662 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2663 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2664}
2665
2666TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002667 const string expected_stderr =
2668 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2669 "dir/IBar.aidl\n"
2670 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002671 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002672
Jiyong Parkc6816252019-07-08 08:12:28 +09002673 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2674 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2675 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2676 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002677 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002678 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002679 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002680}
2681
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002682TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2683 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2684 "package a.b;\n"
2685 "import a.b.IBar;\n"
2686 "import a.b.IQux;\n"
2687 "interface IFoo { IQux foo(); }\n");
2688 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2689 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2690
2691 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2692 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2693
2694 string output;
2695 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2696 // IBar was imported but wasn't used. include is not expected.
2697 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2698 // IBar was imported and used. include is expected.
2699 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2700}
2701
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002702TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002703 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002704 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002705 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2706 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002707 interface IFoo {
2708 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002709 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002710 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002711 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002712 // JavaPassthrough should work with other types as well (e.g. enum)
2713 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2714 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2715 @JavaPassthrough(annotation="@com.android.AliceTwo")
2716 @Backing(type="byte")
2717 enum MyEnum {
2718 a, b, c
2719 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002720
Jooyung Han4cde01d2020-10-13 11:10:47 +09002721 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002722 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2723
2724 string java_out;
2725 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002726 // type-decl-level annotations with newline at the end
2727 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2728 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2729 // member-decl-level annotations with newline at the end
2730 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2731 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2732 // inline annotations with space at the end
2733 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002734
Jooyung Han4cde01d2020-10-13 11:10:47 +09002735 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2736 // type-decl-level annotations with newline at the end
2737 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2738 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2739
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002740 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002741 Options cpp_options =
2742 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002743 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2744
Jooyung Han4cde01d2020-10-13 11:10:47 +09002745 Options ndk_options =
2746 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002747 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002748
Jooyung Han4cde01d2020-10-13 11:10:47 +09002749 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002750 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002751}
2752
Andrei Homescue61feb52020-08-18 15:44:24 -07002753TEST_F(AidlTest, ParseRustDerive) {
2754 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2755 @RustDerive(Clone=true, Copy=false)
2756 parcelable Foo {
2757 int a;
2758 })");
2759
2760 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2761 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2762
2763 string rust_out;
2764 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2765 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2766
2767 // Other backends shouldn't be bothered
2768 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2769 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2770
2771 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2772 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2773
2774 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2775 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2776}
2777
Jiyong Park56f73d72019-06-11 12:20:28 +09002778class AidlOutputPathTest : public AidlTest {
2779 protected:
2780 void SetUp() override {
2781 AidlTest::SetUp();
2782 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2783 }
2784
2785 void Test(const Options& options, const std::string expected_output_path) {
2786 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2787 // check the existence
2788 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2789 }
2790};
2791
2792TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2793 // <out_dir> / <package_name> / <type_name>.java
2794 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2795}
2796
2797TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2798 // when output file is explicitly set, it is always respected. -o option is
2799 // ignored.
2800 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2801}
2802
2803TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2804 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2805}
2806
2807TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2808 // output is the same as the input file except for the suffix
2809 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2810}
2811
Devin Moore7b8d5c92020-03-17 14:14:08 -07002812TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002813 AidlError error;
2814 const string expected_stderr =
2815 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2816 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002817 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2818 R"(package p;
2819 interface IFoo {
2820 const int int32_max_oob = 2147483650;
2821 }
2822 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002823 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002824 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2825 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002826}
2827
Devin Moore7b8d5c92020-03-17 14:14:08 -07002828TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002829 AidlError error;
2830 const string expected_stderr =
2831 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2832 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002833 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2834 R"(package p;
2835 interface IFoo {
2836 const int int32_min_oob = -2147483650;
2837 }
2838 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002839 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002840 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2841 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002842}
2843
Devin Moore7b8d5c92020-03-17 14:14:08 -07002844TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002845 AidlError error;
2846 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002847 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002848 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002849 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2850 R"(package p;
2851 interface IFoo {
2852 const long int64_max_oob = 21474836509999999999999999;
2853 }
2854 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002855 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002856 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2857 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002858}
2859
Devin Moore7b8d5c92020-03-17 14:14:08 -07002860TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002861 AidlError error;
2862 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002863 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002864 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002865 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2866 R"(package p;
2867 interface IFoo {
2868 const long int64_min_oob = -21474836509999999999999999;
2869 }
2870 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002871 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002872 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2873 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002874}
2875
Devin Moore7b8d5c92020-03-17 14:14:08 -07002876TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002877 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002878 const string expected_stderr =
2879 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2880 "literal: byte\n"
2881 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2882 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002883 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2884 R"(package p;
2885 @Backing(type="byte")
2886 enum TestEnum {
2887 FOO = 127,
2888 BAR,
2889 }
2890 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002891 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002892 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002893 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002894}
2895
Devin Mooredecaf292020-04-30 09:16:40 -07002896TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2897 AidlError error;
2898 const string expected_stderr =
2899 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2900 "be one of: type\n"
2901 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2902 "be one of: type\n";
2903 CaptureStderr();
2904 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2905 R"(package p;
2906 @Backing(foo="byte")
2907 enum TestEnum {
2908 FOO = 1,
2909 BAR,
2910 }
2911 )",
2912 typenames_, GetLanguage(), &error));
2913 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2914 EXPECT_EQ(AidlError::BAD_TYPE, error);
2915}
2916
Jooyung Han66813932020-10-23 13:24:44 +09002917TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002918 io_delegate_.SetFileContents("Foo.aidl",
2919 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2920 "Map<String, Baz> d; Bar[] e; }");
2921 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2922 io_delegate_.SetFileContents("Baz.aidl",
2923 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002924 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2925 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2926}
2927
Jooyung Han66813932020-10-23 13:24:44 +09002928TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002929 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002930 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002931 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002932 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
2933 "named 'bar'.\n";
2934 CaptureStderr();
2935 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2936 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2937 EXPECT_EQ(expected_error, GetCapturedStderr());
2938}
2939
2940TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
2941 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
2942 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2943 string expected_error =
2944 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09002945 "named 'bar'.\n";
2946 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002947 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2948 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002949 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002950}
2951
Jooyung Han66813932020-10-23 13:24:44 +09002952TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002953 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002954 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2955 string expected_error =
2956 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2957 "only be an in parameter.\n";
2958 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002959 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2960 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002961 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002962}
2963
Jooyung Han66813932020-10-23 13:24:44 +09002964TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002965 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002966 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
2967 string expected_error =
2968 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
2969 "only be an in parameter.\n";
2970 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002971 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2972 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002973 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002974}
2975
Jooyung Han66813932020-10-23 13:24:44 +09002976TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002977 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002978 Options options = Options::From("aidl --lang=java Foo.aidl");
2979 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002980 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
2981 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09002982 CaptureStderr();
2983 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2984 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2985}
Devin Moore53fc99c2020-08-12 08:07:52 -07002986
Jooyung Han1f14ab32020-10-14 13:48:29 +09002987const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2988
2989#include <a/ByteEnum.h>
2990#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002991#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002992#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09002993#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09002994#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002995#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09002996#include <locale>
2997#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002998#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002999#include <utility>
3000#include <variant>
3001#include <vector>
3002
Jooyung Handf39e192020-11-23 15:59:46 +09003003#ifndef __BIONIC__
3004#define __assert2(a,b,c,d) ((void)0)
3005#endif
3006
Jooyung Han1f14ab32020-10-14 13:48:29 +09003007namespace a {
3008
3009class Foo : public ::android::Parcelable {
3010public:
Jooyung Han97945de2020-10-15 16:41:38 +09003011 inline bool operator!=(const Foo& rhs) const {
3012 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003013 }
Jooyung Han97945de2020-10-15 16:41:38 +09003014 inline bool operator<(const Foo& rhs) const {
3015 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003016 }
Jooyung Han97945de2020-10-15 16:41:38 +09003017 inline bool operator<=(const Foo& rhs) const {
3018 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003019 }
Jooyung Han97945de2020-10-15 16:41:38 +09003020 inline bool operator==(const Foo& rhs) const {
3021 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003022 }
Jooyung Han97945de2020-10-15 16:41:38 +09003023 inline bool operator>(const Foo& rhs) const {
3024 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003025 }
Jooyung Han97945de2020-10-15 16:41:38 +09003026 inline bool operator>=(const Foo& rhs) const {
3027 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003028 }
Jooyung Han97945de2020-10-15 16:41:38 +09003029
Jooyung Han1f14ab32020-10-14 13:48:29 +09003030 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003031 ns = 0, // int[] ns;
3032 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003033 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003034 };
Jooyung Han97945de2020-10-15 16:41:38 +09003035
Jooyung Han1f14ab32020-10-14 13:48:29 +09003036 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003037 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003038
3039 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003040 Foo(const Foo&) = default;
3041 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003042 Foo& operator=(const Foo&) = default;
3043 Foo& operator=(Foo&&) = default;
3044
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003045 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3046 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003047 constexpr Foo(_Tp&& _arg)
3048 : _value(std::forward<_Tp>(_arg)) {}
3049
3050 template <typename... _Tp>
3051 constexpr explicit Foo(_Tp&&... _args)
3052 : _value(std::forward<_Tp>(_args)...) {}
3053
3054 template <Tag _tag, typename... _Tp>
3055 static Foo make(_Tp&&... _args) {
3056 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003057 }
Jooyung Han97945de2020-10-15 16:41:38 +09003058
3059 template <Tag _tag, typename _Tp, typename... _Up>
3060 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3061 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003062 }
3063
3064 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003065 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003066 }
3067
Jooyung Han97945de2020-10-15 16:41:38 +09003068 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003069 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003070 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003071 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003072 }
3073
Jooyung Han97945de2020-10-15 16:41:38 +09003074 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003075 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003076 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003077 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003078 }
3079
Jooyung Han97945de2020-10-15 16:41:38 +09003080 template <Tag _tag, typename... _Tp>
3081 void set(_Tp&&... _args) {
3082 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003083 }
3084
3085 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3086 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3087 static const std::string& getParcelableDescriptor() {
3088 static const std::string DESCIPTOR = "a.Foo";
3089 return DESCIPTOR;
3090 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003091 template <typename _T> class _has_toString {
3092 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3093 template <typename _U> static std::false_type __has_toString(...);
3094 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3095 };
3096 template <typename _T> inline static std::string _call_toString(const _T& t) {
3097 if constexpr (_has_toString<_T>::value) return t.toString();
3098 return "{no toString() implemented}";
3099 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003100 inline std::string toString() const {
3101 std::ostringstream os;
3102 os << "Foo{";
3103 switch (getTag()) {
3104 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3105 case e: os << "e: " << a::toString(get<e>()); break;
3106 case pfd: os << "pfd: " << ""; break;
3107 }
3108 os << "}";
3109 return os.str();
3110 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003111private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003112 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003113}; // class Foo
3114
3115} // namespace a
3116)";
3117
3118const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3119
3120namespace a {
3121
3122::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3123 ::android::status_t _aidl_ret_status;
3124 int32_t _aidl_tag;
3125 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3126 switch (_aidl_tag) {
3127 case ns: {
3128 ::std::vector<int32_t> _aidl_value;
3129 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003130 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3131 set<ns>(_aidl_value);
3132 } else {
3133 // NOLINTNEXTLINE(performance-move-const-arg)
3134 set<ns>(std::move(_aidl_value));
3135 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003136 return ::android::OK; }
3137 case e: {
3138 ::a::ByteEnum _aidl_value;
3139 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003140 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3141 set<e>(_aidl_value);
3142 } else {
3143 // NOLINTNEXTLINE(performance-move-const-arg)
3144 set<e>(std::move(_aidl_value));
3145 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003146 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003147 case pfd: {
3148 ::android::os::ParcelFileDescriptor _aidl_value;
3149 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003150 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3151 set<pfd>(_aidl_value);
3152 } else {
3153 // NOLINTNEXTLINE(performance-move-const-arg)
3154 set<pfd>(std::move(_aidl_value));
3155 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003156 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003157 }
3158 return ::android::BAD_VALUE;
3159}
3160
3161::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3162 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3163 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3164 switch (getTag()) {
3165 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3166 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003167 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003168 }
Jooyung Handf39e192020-11-23 15:59:46 +09003169 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003170}
3171
3172} // namespace a
3173)";
3174
Jooyung Han6beac042020-10-17 21:59:43 +09003175const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3176#include <android/binder_interface_utils.h>
3177#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003178#include <codecvt>
3179#include <locale>
3180#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003181
Jooyung Handf39e192020-11-23 15:59:46 +09003182#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003183#include <type_traits>
3184#include <utility>
3185#include <variant>
3186#include <cstdint>
3187#include <memory>
3188#include <optional>
3189#include <string>
3190#include <vector>
3191#ifdef BINDER_STABILITY_SUPPORT
3192#include <android/binder_stability.h>
3193#endif // BINDER_STABILITY_SUPPORT
3194#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003195
3196#ifndef __BIONIC__
3197#define __assert2(a,b,c,d) ((void)0)
3198#endif
3199
Jooyung Han6beac042020-10-17 21:59:43 +09003200namespace aidl {
3201namespace a {
3202class Foo {
3203public:
3204 typedef std::false_type fixed_size;
3205 static const char* descriptor;
3206
3207 enum Tag : int32_t {
3208 ns = 0, // int[] ns;
3209 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003210 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003211 };
3212
3213 template<typename _Tp>
3214 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3215
3216 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3217 Foo(const Foo&) = default;
3218 Foo(Foo&&) = default;
3219 Foo& operator=(const Foo&) = default;
3220 Foo& operator=(Foo&&) = default;
3221
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003222 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3223 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003224 constexpr Foo(_Tp&& _arg)
3225 : _value(std::forward<_Tp>(_arg)) {}
3226
3227 template <typename... _Tp>
3228 constexpr explicit Foo(_Tp&&... _args)
3229 : _value(std::forward<_Tp>(_args)...) {}
3230
3231 template <Tag _tag, typename... _Tp>
3232 static Foo make(_Tp&&... _args) {
3233 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3234 }
3235
3236 template <Tag _tag, typename _Tp, typename... _Up>
3237 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3238 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3239 }
3240
3241 Tag getTag() const {
3242 return static_cast<Tag>(_value.index());
3243 }
3244
3245 template <Tag _tag>
3246 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003247 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003248 return std::get<_tag>(_value);
3249 }
3250
3251 template <Tag _tag>
3252 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003253 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003254 return std::get<_tag>(_value);
3255 }
3256
3257 template <Tag _tag, typename... _Tp>
3258 void set(_Tp&&... _args) {
3259 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3260 }
3261
3262 binder_status_t readFromParcel(const AParcel* _parcel);
3263 binder_status_t writeToParcel(AParcel* _parcel) const;
3264 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003265 template <typename _T> class _has_toString {
3266 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3267 template <typename _U> static std::false_type __has_toString(...);
3268 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3269 };
3270 template <typename _T> inline static std::string _call_toString(const _T& t) {
3271 if constexpr (_has_toString<_T>::value) return t.toString();
3272 return "{no toString() implemented}";
3273 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003274 inline std::string toString() const {
3275 std::ostringstream os;
3276 os << "Foo{";
3277 switch (getTag()) {
3278 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3279 case e: os << "e: " << a::toString(get<e>()); break;
3280 case pfd: os << "pfd: " << ""; break;
3281 }
3282 os << "}";
3283 return os.str();
3284 }
Jooyung Han6beac042020-10-17 21:59:43 +09003285private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003286 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003287};
3288} // namespace a
3289} // namespace aidl
3290)";
3291
3292const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3293
3294#include <android/binder_parcel_utils.h>
3295
3296namespace aidl {
3297namespace a {
3298const char* Foo::descriptor = "a.Foo";
3299
3300binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3301 binder_status_t _aidl_ret_status;
3302 int32_t _aidl_tag;
3303 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3304 switch (_aidl_tag) {
3305 case ns: {
3306 std::vector<int32_t> _aidl_value;
3307 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003308 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3309 set<ns>(_aidl_value);
3310 } else {
3311 // NOLINTNEXTLINE(performance-move-const-arg)
3312 set<ns>(std::move(_aidl_value));
3313 }
Jooyung Han6beac042020-10-17 21:59:43 +09003314 return STATUS_OK; }
3315 case e: {
3316 ::aidl::a::ByteEnum _aidl_value;
3317 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003318 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3319 set<e>(_aidl_value);
3320 } else {
3321 // NOLINTNEXTLINE(performance-move-const-arg)
3322 set<e>(std::move(_aidl_value));
3323 }
Jooyung Han6beac042020-10-17 21:59:43 +09003324 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003325 case pfd: {
3326 ::ndk::ScopedFileDescriptor _aidl_value;
3327 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003328 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3329 set<pfd>(_aidl_value);
3330 } else {
3331 // NOLINTNEXTLINE(performance-move-const-arg)
3332 set<pfd>(std::move(_aidl_value));
3333 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003334 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003335 }
3336 return STATUS_BAD_VALUE;
3337}
3338binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3339 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3340 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3341 switch (getTag()) {
3342 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3343 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003344 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003345 }
Jooyung Handf39e192020-11-23 15:59:46 +09003346 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003347}
3348
3349} // namespace a
3350} // namespace aidl
3351)";
3352
Jooyung Han1f14ab32020-10-14 13:48:29 +09003353const char kUnionExampleExpectedOutputJava[] = R"(/*
3354 * This file is auto-generated. DO NOT MODIFY.
3355 */
3356package a;
3357
3358
3359public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003360 // tags for union fields
3361 public final static int ns = 0; // int[] ns;
3362 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003363 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003364
3365 private int _tag;
3366 private Object _value;
3367
3368 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003369 int[] _value = {42};
3370 this._tag = ns;
3371 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003372 }
Jooyung Han97945de2020-10-15 16:41:38 +09003373
Jooyung Han1f14ab32020-10-14 13:48:29 +09003374 private Foo(android.os.Parcel _aidl_parcel) {
3375 readFromParcel(_aidl_parcel);
3376 }
Jooyung Han97945de2020-10-15 16:41:38 +09003377
Jooyung Hance62f932020-10-25 10:21:49 +09003378 private Foo(int _tag, Object _value) {
3379 this._tag = _tag;
3380 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003381 }
3382
3383 public int getTag() {
3384 return _tag;
3385 }
3386
Jooyung Han97945de2020-10-15 16:41:38 +09003387 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003388
3389 public static Foo ns(int[] _value) {
3390 return new Foo(ns, _value);
3391 }
Jooyung Han97945de2020-10-15 16:41:38 +09003392
Jooyung Han1f14ab32020-10-14 13:48:29 +09003393 public int[] getNs() {
3394 _assertTag(ns);
3395 return (int[]) _value;
3396 }
Jooyung Han97945de2020-10-15 16:41:38 +09003397
Jooyung Han1f14ab32020-10-14 13:48:29 +09003398 public void setNs(int[] _value) {
3399 _set(ns, _value);
3400 }
3401
Jooyung Han97945de2020-10-15 16:41:38 +09003402 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003403
3404 public static Foo e(byte _value) {
3405 return new Foo(e, _value);
3406 }
Jooyung Han97945de2020-10-15 16:41:38 +09003407
Jooyung Han1f14ab32020-10-14 13:48:29 +09003408 public byte getE() {
3409 _assertTag(e);
3410 return (byte) _value;
3411 }
Jooyung Han97945de2020-10-15 16:41:38 +09003412
Jooyung Han1f14ab32020-10-14 13:48:29 +09003413 public void setE(byte _value) {
3414 _set(e, _value);
3415 }
3416
Jooyung Hand2fa0232020-10-19 02:51:41 +09003417 // ParcelFileDescriptor pfd;
3418
3419 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3420 return new Foo(pfd, _value);
3421 }
3422
3423 public android.os.ParcelFileDescriptor getPfd() {
3424 _assertTag(pfd);
3425 return (android.os.ParcelFileDescriptor) _value;
3426 }
3427
3428 public void setPfd(android.os.ParcelFileDescriptor _value) {
3429 _set(pfd, _value);
3430 }
3431
Jooyung Han1f14ab32020-10-14 13:48:29 +09003432 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3433 @Override
3434 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003435 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003436 }
3437 @Override
3438 public Foo[] newArray(int _aidl_size) {
3439 return new Foo[_aidl_size];
3440 }
3441 };
Jooyung Han97945de2020-10-15 16:41:38 +09003442
Jooyung Han1f14ab32020-10-14 13:48:29 +09003443 @Override
3444 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3445 _aidl_parcel.writeInt(_tag);
3446 switch (_tag) {
3447 case ns:
3448 _aidl_parcel.writeIntArray(getNs());
3449 break;
3450 case e:
3451 _aidl_parcel.writeByte(getE());
3452 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003453 case pfd:
3454 if ((getPfd()!=null)) {
3455 _aidl_parcel.writeInt(1);
3456 getPfd().writeToParcel(_aidl_parcel, 0);
3457 }
3458 else {
3459 _aidl_parcel.writeInt(0);
3460 }
3461 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003462 }
3463 }
Jooyung Han97945de2020-10-15 16:41:38 +09003464
Jooyung Han1f14ab32020-10-14 13:48:29 +09003465 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3466 int _aidl_tag;
3467 _aidl_tag = _aidl_parcel.readInt();
3468 switch (_aidl_tag) {
3469 case ns: {
3470 int[] _aidl_value;
3471 _aidl_value = _aidl_parcel.createIntArray();
3472 _set(_aidl_tag, _aidl_value);
3473 return; }
3474 case e: {
3475 byte _aidl_value;
3476 _aidl_value = _aidl_parcel.readByte();
3477 _set(_aidl_tag, _aidl_value);
3478 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003479 case pfd: {
3480 android.os.ParcelFileDescriptor _aidl_value;
3481 if ((0!=_aidl_parcel.readInt())) {
3482 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3483 }
3484 else {
3485 _aidl_value = null;
3486 }
3487 _set(_aidl_tag, _aidl_value);
3488 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003489 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003490 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003491 }
Jooyung Han97945de2020-10-15 16:41:38 +09003492
Jooyung Han1f14ab32020-10-14 13:48:29 +09003493 @Override
3494 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003495 int _mask = 0;
3496 switch (getTag()) {
3497 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003498 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003499 break;
3500 }
3501 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003502 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003503 private int describeContents(Object _v) {
3504 if (_v == null) return 0;
3505 if (_v instanceof android.os.Parcelable) {
3506 return ((android.os.Parcelable) _v).describeContents();
3507 }
3508 return 0;
3509 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003510
3511 private void _assertTag(int tag) {
3512 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003513 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003514 }
3515 }
Jooyung Han97945de2020-10-15 16:41:38 +09003516
Jooyung Han1f14ab32020-10-14 13:48:29 +09003517 private String _tagString(int _tag) {
3518 switch (_tag) {
3519 case ns: return "ns";
3520 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003521 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003522 }
3523 throw new IllegalStateException("unknown field: " + _tag);
3524 }
Jooyung Han97945de2020-10-15 16:41:38 +09003525
Jooyung Hance62f932020-10-25 10:21:49 +09003526 private void _set(int _tag, Object _value) {
3527 this._tag = _tag;
3528 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003529 }
3530}
3531)";
3532
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003533const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3534pub enum Foo {
3535 Ns(Vec<i32>),
3536 E(crate::mangled::_1_a_8_ByteEnum),
3537 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3538}
3539pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3540impl Default for Foo {
3541 fn default() -> Self {
3542 Self::Ns(vec!{42})
3543 }
3544}
3545impl binder::parcel::Serialize for Foo {
3546 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3547 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3548 }
3549}
3550impl binder::parcel::SerializeArray for Foo {}
3551impl binder::parcel::SerializeOption for Foo {
3552 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3553 let this = if let Some(this) = this {
3554 parcel.write(&1i32)?;
3555 this
3556 } else {
3557 return parcel.write(&0i32);
3558 };
3559 match this {
3560 Self::Ns(v) => {
3561 parcel.write(&0i32)?;
3562 parcel.write(v)
3563 }
3564 Self::E(v) => {
3565 parcel.write(&1i32)?;
3566 parcel.write(v)
3567 }
3568 Self::Pfd(v) => {
3569 parcel.write(&2i32)?;
3570 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3571 parcel.write(__field_ref)
3572 }
3573 }
3574 }
3575}
3576impl binder::parcel::Deserialize for Foo {
3577 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3578 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3579 .transpose()
3580 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3581 }
3582}
3583impl binder::parcel::DeserializeArray for Foo {}
3584impl binder::parcel::DeserializeOption for Foo {
3585 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3586 let status: i32 = parcel.read()?;
3587 if status == 0 { return Ok(None); }
3588 let tag: i32 = parcel.read()?;
3589 match tag {
3590 0 => {
3591 let value: Vec<i32> = parcel.read()?;
3592 Ok(Some(Self::Ns(value)))
3593 }
3594 1 => {
3595 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3596 Ok(Some(Self::E(value)))
3597 }
3598 2 => {
3599 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3600 Ok(Some(Self::Pfd(value)))
3601 }
3602 _ => {
3603 Err(binder::StatusCode::BAD_VALUE)
3604 }
3605 }
3606 }
3607}
3608)";
3609
Jooyung Han97945de2020-10-15 16:41:38 +09003610struct AidlUnionTest : ::testing::Test {
3611 void SetUp() override {
3612 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003613package a;
3614import a.ByteEnum;
3615union Foo {
3616 int[] ns = {42};
3617 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003618 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003619}
3620)");
Jooyung Han97945de2020-10-15 16:41:38 +09003621 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003622package a;
3623@Backing(type="byte")
3624enum ByteEnum {
3625 a, b, c
3626}
3627)");
Jooyung Han97945de2020-10-15 16:41:38 +09003628 }
3629 FakeIoDelegate io_delegate_;
3630 void Compile(string lang) {
3631 string command = "aidl --structured -I. -o out --lang=" + lang;
3632 if (lang == "cpp" || lang == "ndk") {
3633 command += " -h out";
3634 }
3635 command += " a/Foo.aidl";
3636 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003637 CaptureStderr();
3638 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3639 auto err = GetCapturedStderr();
3640 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003641 }
3642 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3643 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003644 string actual;
3645 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3646 EXPECT_EQ(expected, actual);
3647 }
Jooyung Han97945de2020-10-15 16:41:38 +09003648 }
3649};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003650
Jooyung Han97945de2020-10-15 16:41:38 +09003651TEST_F(AidlUnionTest, Example_Cpp) {
3652 Compile("cpp");
3653 EXPECT_COMPILE_OUTPUTS(
3654 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3655 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3656}
3657
Jooyung Han6beac042020-10-17 21:59:43 +09003658TEST_F(AidlUnionTest, Example_Ndk) {
3659 Compile("ndk");
3660 EXPECT_COMPILE_OUTPUTS(
3661 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3662 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3663}
3664
Jooyung Han97945de2020-10-15 16:41:38 +09003665TEST_F(AidlUnionTest, Example_Java) {
3666 Compile("java");
3667 EXPECT_COMPILE_OUTPUTS(
3668 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003669}
3670
3671TEST_F(AidlUnionTest, Example_Rust) {
3672 Compile("rust");
3673 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003674}
3675
Jooyung Hanfe89f122020-10-14 03:49:18 +09003676TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3677 const string method = "package a; union Foo {}";
3678 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3679 CaptureStderr();
3680 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3681 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3682}
3683
3684TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3685 const string method = "package a; union Foo { ParcelableHolder x; }";
3686 const string expected_stderr =
3687 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3688 CaptureStderr();
3689 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3690 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3691}
3692
Devin Moore53fc99c2020-08-12 08:07:52 -07003693TEST_P(AidlTest, GenericStructuredParcelable) {
3694 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3695 Options options =
3696 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3697 const string expected_stderr = "";
3698 CaptureStderr();
3699 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3700 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3701}
3702
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003703TEST_F(AidlTest, NestedTypeArgs) {
3704 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003705 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3706
3707 io_delegate_.SetFileContents("a/Foo.aidl",
3708 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3709 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003710 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3711 const string expected_stderr = "";
3712 CaptureStderr();
3713 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3714 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3715
3716 string code;
3717 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003718 EXPECT_THAT(code,
3719 testing::HasSubstr(
3720 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3721}
3722
3723TEST_F(AidlTest, DoubleArrayError) {
3724 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3725
3726 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3727 const string expected_stderr =
3728 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3729 CaptureStderr();
3730 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3731 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3732}
3733
3734TEST_F(AidlTest, DoubleGenericError) {
3735 io_delegate_.SetFileContents("a/Bar.aidl",
3736 "package a; parcelable Bar { List<String><String> a; }");
3737
3738 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3739 const string expected_stderr =
3740 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3741 CaptureStderr();
3742 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3743 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3744}
3745
3746TEST_F(AidlTest, ArrayBeforeGenericError) {
3747 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3748
3749 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3750 const string expected_stderr =
3751 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3752 CaptureStderr();
3753 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3754 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003755}
3756
Jooyung Han14004ed2020-10-16 03:49:57 +09003757struct GenericAidlTest : ::testing::Test {
3758 FakeIoDelegate io_delegate_;
3759 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003760 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003761 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3762 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3763 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3764
3765 Options options = Options::From(cmd);
3766 CaptureStderr();
3767 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3768 EXPECT_EQ("", GetCapturedStderr());
3769 }
3770};
3771
3772TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3773 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3774 string code;
3775 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3776 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3777 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3778 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3779}
3780
3781TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3782 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3783 string code;
3784 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3785 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3786 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3787 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3788}
3789
Devin Moore53fc99c2020-08-12 08:07:52 -07003790TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3791 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3792 Options options =
3793 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3794 const string expected_stderr =
3795 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3796 CaptureStderr();
3797 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3798 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3799}
3800
3801TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3802 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3803 Options options =
3804 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3805 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3806 CaptureStderr();
3807 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3808 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3809}
3810
Jooyung Han7a308842020-10-27 19:06:49 +09003811TEST_P(AidlTest, LongCommentWithinConstExpression) {
3812 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3813 Options options =
3814 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3815 CaptureStderr();
3816 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3817 EXPECT_EQ("", GetCapturedStderr());
3818}
3819
Jeongik Chaef44e622020-10-23 16:00:52 +09003820TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3821 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3822 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3823 std::string expectedErr =
3824 "ERROR: a/Foo.aidl:1.28-30: "
3825 "Encountered an untyped List or Map. The use of untyped List/Map is "
3826 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3827 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3828 "ERROR: a/Foo.aidl:1.35-37: "
3829 "Encountered an untyped List or Map. The use of untyped List/Map is "
3830 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3831 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3832 CaptureStderr();
3833 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3834 EXPECT_EQ(expectedErr, GetCapturedStderr());
3835}
3836
3837TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003838 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3839 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003840 std::string expectedErr =
3841 "ERROR: a/Foo.aidl:1.33-35: "
3842 "Encountered an untyped List or Map. The use of untyped List/Map is "
3843 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3844 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3845 "ERROR: a/Foo.aidl:1.40-42: "
3846 "Encountered an untyped List or Map. The use of untyped List/Map is "
3847 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3848 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003849 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003850 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3851 EXPECT_EQ(expectedErr, GetCapturedStderr());
3852}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003853
Jeongik Chaef44e622020-10-23 16:00:52 +09003854TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3855 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3856 io_delegate_.SetFileContents(
3857 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3858 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3859 std::string expectedErr =
3860 "ERROR: a/Foo.aidl:1.52-54: "
3861 "Encountered an untyped List or Map. The use of untyped List/Map is "
3862 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3863 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3864 "ERROR: a/Foo.aidl:1.64-66: "
3865 "Encountered an untyped List or Map. The use of untyped List/Map is "
3866 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3867 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3868 CaptureStderr();
3869 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3870 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003871}
3872
Christopher Wiley90be4e32015-10-20 14:55:25 -07003873} // namespace aidl
3874} // namespace android