Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015, The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 17 | #include "aidl.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 18 | |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 19 | #include <android-base/format.h> |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 20 | #include <android-base/stringprintf.h> |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 21 | #include <gmock/gmock.h> |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 22 | #include <gtest/gtest.h> |
| 23 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 24 | #include <map> |
| 25 | #include <memory> |
| 26 | #include <set> |
| 27 | #include <string> |
| 28 | #include <vector> |
| 29 | |
Steven Moreland | 4958524 | 2019-12-18 16:06:49 -0800 | [diff] [blame] | 30 | #include "aidl_checkapi.h" |
Jooyung Han | 1f56b70 | 2021-02-11 13:16:15 +0900 | [diff] [blame] | 31 | #include "aidl_dumpapi.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 32 | #include "aidl_language.h" |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 33 | #include "aidl_to_cpp.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 34 | #include "aidl_to_java.h" |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 35 | #include "comments.h" |
Jiyong Park | 2a7c92b | 2020-07-22 19:12:36 +0900 | [diff] [blame] | 36 | #include "logging.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 37 | #include "options.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 38 | #include "tests/fake_io_delegate.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 39 | |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 40 | using android::aidl::internals::parse_preprocessed_file; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 41 | using android::aidl::test::FakeIoDelegate; |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 42 | using android::base::StringPrintf; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 43 | using std::map; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 44 | using std::set; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 45 | using std::string; |
| 46 | using std::unique_ptr; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 47 | using std::vector; |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 48 | using testing::HasSubstr; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 49 | using testing::TestParamInfo; |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 50 | using testing::internal::CaptureStderr; |
| 51 | using testing::internal::GetCapturedStderr; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 52 | |
| 53 | namespace android { |
| 54 | namespace aidl { |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 55 | namespace { |
| 56 | |
| 57 | const char kExpectedDepFileContents[] = |
| 58 | R"(place/for/output/p/IFoo.java : \ |
| 59 | p/IFoo.aidl |
| 60 | |
| 61 | p/IFoo.aidl : |
| 62 | )"; |
| 63 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 64 | const char kExpectedNinjaDepFileContents[] = |
| 65 | R"(place/for/output/p/IFoo.java : \ |
| 66 | p/IFoo.aidl |
| 67 | )"; |
| 68 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 69 | const char kExpectedParcelableDeclarationDepFileContents[] = |
| 70 | R"( : \ |
| 71 | p/Foo.aidl |
| 72 | |
| 73 | p/Foo.aidl : |
| 74 | )"; |
| 75 | |
| 76 | const char kExpectedStructuredParcelableDepFileContents[] = |
Steven Moreland | 2a9a7d6 | 2019-02-05 16:11:54 -0800 | [diff] [blame] | 77 | R"(place/for/output/p/Foo.java : \ |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 78 | p/Foo.aidl |
| 79 | |
| 80 | p/Foo.aidl : |
| 81 | )"; |
| 82 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 83 | } // namespace |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 84 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 85 | class AidlTest : public ::testing::TestWithParam<Options::Language> { |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 86 | protected: |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 87 | AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_, |
| 88 | Options::Language lang, AidlError* error = nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 89 | const vector<string> additional_arguments = {}) { |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 90 | io_delegate_.SetFileContents(path, contents); |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 91 | vector<string> args; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 92 | args.emplace_back("aidl"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 93 | args.emplace_back("--lang=" + to_string(lang)); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 94 | for (const string& s : additional_arguments) { |
| 95 | args.emplace_back(s); |
| 96 | } |
| 97 | for (const string& f : preprocessed_files_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 98 | args.emplace_back("--preprocessed=" + f); |
| 99 | } |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 100 | for (const string& i : import_paths_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 101 | args.emplace_back("--include=" + i); |
| 102 | } |
| 103 | args.emplace_back(path); |
| 104 | Options options = Options::From(args); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 105 | vector<string> imported_files; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 106 | ImportResolver import_resolver{io_delegate_, path, import_paths_, {}}; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 107 | AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl( |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 108 | path, options, io_delegate_, &typenames_, &imported_files); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 109 | |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 110 | if (error != nullptr) { |
| 111 | *error = actual_error; |
| 112 | } |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 113 | |
| 114 | if (actual_error != AidlError::OK) { |
| 115 | return nullptr; |
| 116 | } |
| 117 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 118 | const auto& defined_types = typenames_.MainDocument().DefinedTypes(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 119 | EXPECT_EQ(1ul, defined_types.size()); |
| 120 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 121 | return defined_types.front().get(); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 122 | } |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 123 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 124 | Options::Language GetLanguage() { return GetParam(); } |
| 125 | |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 126 | FakeIoDelegate io_delegate_; |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 127 | vector<string> preprocessed_files_; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 128 | set<string> import_paths_; |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 129 | AidlTypenames typenames_; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 130 | }; |
| 131 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 132 | // Instantiate the AidlTest parameterized suite, calling all of the TEST_P |
| 133 | // tests with each of the supported languages as a parameter. |
| 134 | INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest, |
| 135 | testing::Values(Options::Language::CPP, Options::Language::JAVA, |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 136 | Options::Language::NDK, Options::Language::RUST), |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 137 | [](const testing::TestParamInfo<Options::Language>& info) { |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 138 | return to_string(info.param); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 139 | }); |
| 140 | |
| 141 | TEST_P(AidlTest, AcceptMissingPackage) { |
| 142 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 143 | } |
| 144 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 145 | TEST_P(AidlTest, EndsInSingleLineComment) { |
| 146 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage())); |
Steven Moreland | 9c2988f | 2019-07-17 17:49:10 -0700 | [diff] [blame] | 147 | } |
| 148 | |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 149 | TEST_P(AidlTest, InterfaceRequiresCorrectPath) { |
| 150 | const string expected_stderr = |
| 151 | "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n"; |
| 152 | const std::string file_contents = "package a; interface IBar {}"; |
| 153 | CaptureStderr(); |
| 154 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 155 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 156 | } |
| 157 | |
| 158 | TEST_P(AidlTest, ParcelableRequiresCorrectPath) { |
| 159 | const string expected_stderr = |
| 160 | "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n"; |
| 161 | const std::string file_contents = "package a; interface Bar {}"; |
| 162 | CaptureStderr(); |
| 163 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 164 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 165 | } |
| 166 | |
| 167 | TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) { |
| 168 | const string expected_stderr = |
| 169 | "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n"; |
| 170 | const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";"; |
| 171 | CaptureStderr(); |
| 172 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 173 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 174 | } |
| 175 | |
| 176 | TEST_P(AidlTest, EnumRequiresCorrectPath) { |
| 177 | const string expected_stderr = |
| 178 | "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n"; |
| 179 | const std::string file_contents = "package a; enum Bar { A, }"; |
| 180 | CaptureStderr(); |
| 181 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 182 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 183 | } |
| 184 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 185 | TEST_P(AidlTest, RejectsArraysOfBinders) { |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 186 | import_paths_.emplace(""); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 187 | io_delegate_.SetFileContents("bar/IBar.aidl", |
| 188 | "package bar; interface IBar {}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 189 | const string path = "foo/IFoo.aidl"; |
| 190 | const string contents = |
| 191 | "package foo;\n" |
| 192 | "import bar.IBar;\n" |
| 193 | "interface IFoo { void f(in IBar[] input); }"; |
| 194 | const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n"; |
| 195 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 196 | EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 197 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 198 | } |
| 199 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 200 | TEST_P(AidlTest, SupportOnlyOutParameters) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 201 | const string interface_list = "package a; interface IBar { void f(out List<String> bar); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 202 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 203 | } |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 204 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 205 | TEST_P(AidlTest, RejectOutParametersForIBinder) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 206 | const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }"; |
| 207 | const string expected_ibinder_stderr = |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 208 | "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an " |
| 209 | "in parameter.\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 210 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 211 | EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 212 | EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr()); |
Jeongik Cha | a2080bf | 2019-06-18 16:44:29 +0900 | [diff] [blame] | 213 | } |
| 214 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 215 | TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) { |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 216 | const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 217 | const string expected_stderr = |
| 218 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 219 | CaptureStderr(); |
| 220 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
| 221 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 222 | } |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 223 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 224 | TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) { |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 225 | const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }"; |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 226 | const string expected_stderr = |
| 227 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 228 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 229 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 230 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 231 | } |
| 232 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 233 | TEST_P(AidlTest, RejectsOnewayNonVoidReturn) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 234 | const string oneway_method = "package a; interface IFoo { oneway int f(); }"; |
| 235 | const string expected_stderr = |
| 236 | "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n"; |
| 237 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 238 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 239 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 240 | } |
| 241 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 242 | TEST_P(AidlTest, RejectsNullablePrimitive) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 243 | const string oneway_method = "package a; interface IFoo { @nullable int f(); }"; |
| 244 | const string expected_stderr = |
| 245 | "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n"; |
| 246 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 247 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 248 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Casey Dahlin | 57dbe24 | 2015-12-04 11:44:02 -0800 | [diff] [blame] | 249 | } |
| 250 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 251 | TEST_P(AidlTest, AcceptNullableList) { |
| 252 | const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }"; |
| 253 | const string expected_stderr = ""; |
| 254 | CaptureStderr(); |
| 255 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
| 256 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 257 | } |
| 258 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 259 | TEST_P(AidlTest, RejectsDuplicatedArgumentNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 260 | const string method = "package a; interface IFoo { void f(int a, int a); }"; |
| 261 | const string expected_stderr = |
| 262 | "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n"; |
| 263 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 264 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 265 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | b3cd3c7 | 2018-10-11 12:37:45 -0700 | [diff] [blame] | 266 | } |
| 267 | |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 268 | TEST_P(AidlTest, RejectsDuplicatedFieldNames) { |
| 269 | const string method = "package a; parcelable Foo { int a; String a; }"; |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 270 | const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n"; |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 271 | CaptureStderr(); |
| 272 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 273 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 274 | } |
| 275 | |
Jooyung Han | d902a97 | 2020-10-23 17:32:44 +0900 | [diff] [blame] | 276 | TEST_P(AidlTest, RejectsRepeatedAnnotations) { |
| 277 | const string method = R"(@Hide @Hide parcelable Foo {})"; |
| 278 | const string expected_stderr = |
| 279 | "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: " |
| 280 | "Foo.aidl:1.1-6\n"; |
| 281 | CaptureStderr(); |
| 282 | EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage())); |
| 283 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 284 | } |
| 285 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 286 | TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 287 | const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }"; |
| 288 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n"; |
| 289 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 290 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 291 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 292 | } |
| 293 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 294 | TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 295 | AidlError error; |
| 296 | const string method = "package a; @nullable interface IFoo { int f(); }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 297 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 298 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 299 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 300 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 301 | } |
| 302 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 303 | TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 304 | AidlError error; |
| 305 | const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 306 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 307 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 308 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 309 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 310 | } |
| 311 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 312 | TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 313 | AidlError error; |
| 314 | const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 315 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 316 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 317 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 318 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 319 | } |
| 320 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 321 | TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 322 | AidlError error; |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 323 | const string method = "package a; @nullable parcelable IFoo { String a; String b; }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 324 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 325 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 326 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 327 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 328 | } |
| 329 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 330 | TEST_P(AidlTest, ParsesNonNullableAnnotation) { |
| 331 | auto parse_result = |
| 332 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 333 | ASSERT_NE(nullptr, parse_result); |
| 334 | const AidlInterface* interface = parse_result->AsInterface(); |
| 335 | ASSERT_NE(nullptr, interface); |
| 336 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 337 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 338 | } |
| 339 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 340 | TEST_P(AidlTest, ParsesNullableAnnotation) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 341 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }", |
| 342 | typenames_, GetLanguage()); |
| 343 | ASSERT_NE(nullptr, parse_result); |
| 344 | const AidlInterface* interface = parse_result->AsInterface(); |
| 345 | ASSERT_NE(nullptr, interface); |
| 346 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 347 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 348 | } |
| 349 | |
| 350 | TEST_P(AidlTest, ParsesNonUtf8Annotations) { |
| 351 | auto parse_result = |
| 352 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 353 | ASSERT_NE(nullptr, parse_result); |
| 354 | const AidlInterface* interface = parse_result->AsInterface(); |
| 355 | ASSERT_NE(nullptr, interface); |
| 356 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 357 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 358 | } |
| 359 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 360 | TEST_P(AidlTest, ParsesUtf8Annotations) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 361 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }", |
| 362 | typenames_, GetLanguage()); |
| 363 | ASSERT_NE(nullptr, parse_result); |
| 364 | const AidlInterface* interface = parse_result->AsInterface(); |
| 365 | ASSERT_NE(nullptr, interface); |
| 366 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 367 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 368 | } |
| 369 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 370 | TEST_P(AidlTest, VintfRequiresStructuredAndStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 371 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 372 | const string expected_stderr = |
| 373 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 374 | "\"vintf\"'\n" |
| 375 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 376 | "--structured\n"; |
| 377 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 378 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 379 | GetLanguage(), &error)); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 380 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 381 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 382 | } |
| 383 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 384 | TEST_P(AidlTest, VintfRequiresStructured) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 385 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 386 | const string expected_stderr = |
| 387 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 388 | "--structured\n"; |
| 389 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 390 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 391 | GetLanguage(), &error, {"--stability", "vintf"})); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 392 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 393 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 394 | } |
| 395 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 396 | TEST_P(AidlTest, VintfRequiresSpecifiedStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 397 | AidlError error; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 398 | const string expected_stderr = |
| 399 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 400 | "\"vintf\"'\n"; |
| 401 | CaptureStderr(); |
| 402 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 403 | GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 404 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 405 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 406 | } |
| 407 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 408 | TEST_P(AidlTest, ParsesStabilityAnnotations) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 409 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 410 | auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
| 411 | GetLanguage(), &error, {"--structured", "--stability", "vintf"}); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 412 | ASSERT_EQ(AidlError::OK, error); |
| 413 | ASSERT_NE(nullptr, parse_result); |
| 414 | const AidlInterface* interface = parse_result->AsInterface(); |
| 415 | ASSERT_NE(nullptr, interface); |
| 416 | ASSERT_TRUE(interface->IsVintfStability()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 417 | } |
| 418 | |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 419 | TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) { |
| 420 | Options java_options = Options::From("aidl -o out --structured a/Foo.aidl"); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 421 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl"); |
| 422 | Options cpp_structured_options = |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 423 | Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 424 | Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl"); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 425 | io_delegate_.SetFileContents( |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 426 | "a/Foo.aidl", |
| 427 | StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;")); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 428 | |
| 429 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 430 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 431 | const string expected_stderr = |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 432 | "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. " |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 433 | "Parcelable must be defined in AIDL directly.\n"; |
| 434 | CaptureStderr(); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 435 | EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 436 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 437 | |
| 438 | CaptureStderr(); |
| 439 | EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
| 440 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 441 | } |
| 442 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 443 | TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) { |
| 444 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 445 | @JavaDerive(toString=true) parcelable Foo { int a; float b; })"); |
| 446 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 447 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 448 | |
| 449 | string java_out; |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 450 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 451 | EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {")); |
| 452 | |
| 453 | // Other backends shouldn't be bothered |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 454 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 455 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 456 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 457 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 458 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
| 459 | } |
| 460 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 461 | TEST_F(AidlTest, UnionSupportJavaDeriveToString) { |
| 462 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 463 | @JavaDerive(toString=true) union Foo { int a; int[] b; })"); |
| 464 | CaptureStderr(); |
| 465 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 466 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 467 | EXPECT_EQ("", GetCapturedStderr()); |
| 468 | |
| 469 | const string expected_to_string_method = R"--( |
| 470 | @Override |
| 471 | public String toString() { |
| 472 | switch (_tag) { |
| 473 | case a: return "a.Foo.a(" + (getA()) + ")"; |
| 474 | case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")"; |
| 475 | } |
| 476 | throw new IllegalStateException("unknown field: " + _tag); |
| 477 | } |
| 478 | )--"; |
| 479 | |
| 480 | string java_out; |
| 481 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 482 | EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method)); |
| 483 | } |
| 484 | |
Jiyong Park | 9aa3d04 | 2020-12-04 23:30:02 +0900 | [diff] [blame] | 485 | TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) { |
| 486 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 487 | @JavaDerive(equals=true) parcelable Foo { int a; float b; })"); |
| 488 | CaptureStderr(); |
| 489 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 490 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 491 | EXPECT_EQ("", GetCapturedStderr()); |
| 492 | |
| 493 | const std::string expected = R"--( |
| 494 | @Override |
| 495 | public boolean equals(Object other) { |
| 496 | if (this == other) return true; |
| 497 | if (other == null) return false; |
| 498 | if (!(other instanceof Foo)) return false; |
| 499 | Foo that = (Foo)other; |
| 500 | if (!java.util.Objects.deepEquals(a, that.a)) return false; |
| 501 | if (!java.util.Objects.deepEquals(b, that.b)) return false; |
| 502 | return true; |
| 503 | } |
| 504 | |
| 505 | @Override |
| 506 | public int hashCode() { |
| 507 | return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray()); |
| 508 | } |
| 509 | )--"; |
| 510 | |
| 511 | string java_out; |
| 512 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 513 | EXPECT_THAT(java_out, testing::HasSubstr(expected)); |
| 514 | } |
| 515 | |
| 516 | TEST_F(AidlTest, UnionSupportJavaDeriveEquals) { |
| 517 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 518 | @JavaDerive(equals=true) union Foo { int a; int[] b; })"); |
| 519 | CaptureStderr(); |
| 520 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 521 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 522 | EXPECT_EQ("", GetCapturedStderr()); |
| 523 | |
| 524 | const std::string expected = R"--( |
| 525 | @Override |
| 526 | public boolean equals(Object other) { |
| 527 | if (this == other) return true; |
| 528 | if (other == null) return false; |
| 529 | if (!(other instanceof Foo)) return false; |
| 530 | Foo that = (Foo)other; |
| 531 | if (_tag != that._tag) return false; |
| 532 | if (!java.util.Objects.deepEquals(_value, that._value)) return false; |
| 533 | return true; |
| 534 | } |
| 535 | |
| 536 | @Override |
| 537 | public int hashCode() { |
| 538 | return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray()); |
| 539 | } |
| 540 | )--"; |
| 541 | |
| 542 | string java_out; |
| 543 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 544 | EXPECT_THAT(java_out, testing::HasSubstr(expected)); |
| 545 | } |
| 546 | |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 547 | TEST_F(AidlTest, RejectsJavaDeriveAnnotation) { |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 548 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 549 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 550 | "package a; @JavaDerive(blah=true) parcelable Foo{}"); |
| 551 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 552 | CaptureStderr(); |
| 553 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 554 | const std::string expected_stderr = |
| 555 | "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive."; |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 556 | EXPECT_THAT(GetCapturedStderr(), |
| 557 | HasSubstr("Parameter blah not supported for annotation JavaDerive.")); |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 558 | } |
| 559 | |
| 560 | { |
| 561 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 562 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 563 | CaptureStderr(); |
| 564 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 565 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available.")); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 566 | } |
| 567 | |
| 568 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 569 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 570 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 571 | CaptureStderr(); |
| 572 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 573 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available.")); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 574 | } |
| 575 | } |
| 576 | |
Jiyong Park | 27fd7fd | 2020-08-27 16:25:09 +0900 | [diff] [blame] | 577 | TEST_P(AidlTest, ParseDescriptorAnnotation) { |
| 578 | AidlError error; |
| 579 | auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})", |
| 580 | typenames_, GetLanguage(), &error, {"--structured"}); |
| 581 | ASSERT_EQ(AidlError::OK, error); |
| 582 | ASSERT_NE(nullptr, parse_result); |
| 583 | const AidlInterface* interface = parse_result->AsInterface(); |
| 584 | ASSERT_NE(nullptr, interface); |
| 585 | ASSERT_EQ("IBar", interface->GetDescriptor()); |
| 586 | } |
| 587 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 588 | TEST_P(AidlTest, AcceptsOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 589 | const string oneway_method = "package a; interface IFoo { oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 590 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 591 | } |
| 592 | |
| 593 | TEST_P(AidlTest, AcceptsOnewayInterface) { |
| 594 | const string oneway_interface = "package a; oneway interface IBar { void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 595 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 596 | } |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 597 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 598 | TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 599 | const string oneway_method = |
| 600 | "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 601 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 602 | } |
| 603 | |
Steven Moreland | 65297cc | 2020-04-20 20:17:36 -0700 | [diff] [blame] | 604 | TEST_P(AidlTest, AnnotationsInMultiplePlaces) { |
| 605 | const string oneway_method = |
| 606 | "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }"; |
| 607 | const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()); |
| 608 | ASSERT_NE(nullptr, defined); |
| 609 | const AidlInterface* iface = defined->AsInterface(); |
| 610 | ASSERT_NE(nullptr, iface); |
| 611 | |
| 612 | const auto& methods = iface->GetMethods(); |
| 613 | ASSERT_EQ(1u, methods.size()); |
| 614 | const auto& method = methods[0]; |
| 615 | const AidlTypeSpecifier& ret_type = method->GetType(); |
| 616 | |
| 617 | // TODO(b/151102494): these annotations should be on the method |
| 618 | ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage()); |
| 619 | ASSERT_TRUE(ret_type.IsHide()); |
| 620 | } |
| 621 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 622 | TEST_P(AidlTest, WritesComments) { |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 623 | string foo_interface = |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 624 | R"(package a; |
| 625 | /* foo */ |
| 626 | interface IFoo { |
| 627 | /* i */ |
| 628 | int i(); |
| 629 | // j |
| 630 | @nullable String j(); |
| 631 | // k1 |
| 632 | /* k2 */ |
| 633 | @UnsupportedAppUsage oneway void k(int a); |
| 634 | })"; |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 635 | |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 636 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 637 | auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 638 | EXPECT_NE(nullptr, parse_result); |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 639 | EXPECT_EQ("", GetCapturedStderr()); |
| 640 | |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 641 | EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 642 | |
| 643 | const AidlInterface* interface = parse_result->AsInterface(); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 644 | EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments()); |
| 645 | EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments()); |
| 646 | EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 647 | } |
| 648 | |
Jooyung Han | 1a551d3 | 2020-10-05 15:37:26 +0900 | [diff] [blame] | 649 | TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) { |
| 650 | io_delegate_.SetFileContents("p/cpp_header.aidl", |
| 651 | R"(package p; |
| 652 | parcelable cpp_header cpp_header "bar/header";)"); |
| 653 | import_paths_.emplace(""); |
| 654 | const string input_path = "p/IFoo.aidl"; |
| 655 | const string input = R"(package p; |
| 656 | import p.cpp_header; |
| 657 | interface IFoo { |
| 658 | // get bar |
| 659 | cpp_header get(); |
| 660 | })"; |
| 661 | |
| 662 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 663 | EXPECT_NE(nullptr, parse_result); |
| 664 | const AidlInterface* interface = parse_result->AsInterface(); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 665 | EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments()); |
Jooyung Han | 1a551d3 | 2020-10-05 15:37:26 +0900 | [diff] [blame] | 666 | } |
| 667 | |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 668 | TEST_F(AidlTest, ParsesPreprocessedFile) { |
| 669 | string simple_content = "parcelable a.Foo;\ninterface b.IBar;"; |
| 670 | io_delegate_.SetFileContents("path", simple_content); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 671 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 672 | EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 673 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 674 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 675 | } |
| 676 | |
| 677 | TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) { |
| 678 | string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t"; |
| 679 | io_delegate_.SetFileContents("path", simple_content); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 680 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 681 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 682 | EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 683 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 684 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 685 | } |
| 686 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 687 | TEST_P(AidlTest, PreferImportToPreprocessed) { |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 688 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;"); |
| 689 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; " |
| 690 | "interface IBar {}"); |
| 691 | preprocessed_files_.push_back("preprocessed"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 692 | import_paths_.emplace(""); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 693 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 694 | typenames_, GetLanguage()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 695 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 696 | |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 697 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 698 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 699 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 700 | // But if we request just "IBar" we should get our imported one. |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 701 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {}); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 702 | ambiguous_type.Resolve(typenames_); |
| 703 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 704 | } |
| 705 | |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 706 | // Special case of PreferImportToPreprocessed. Imported type should be preferred |
| 707 | // even when the preprocessed file already has the same type. |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 708 | TEST_P(AidlTest, B147918827) { |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 709 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;"); |
| 710 | io_delegate_.SetFileContents("one/IBar.aidl", |
| 711 | "package one; " |
| 712 | "interface IBar {}"); |
| 713 | preprocessed_files_.push_back("preprocessed"); |
| 714 | import_paths_.emplace(""); |
| 715 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 716 | typenames_, GetLanguage()); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 717 | EXPECT_NE(nullptr, parse_result); |
| 718 | |
| 719 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 720 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 721 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 722 | // But if we request just "IBar" we should get our imported one. |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 723 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {}); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 724 | ambiguous_type.Resolve(typenames_); |
| 725 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
| 726 | } |
| 727 | |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 728 | TEST_F(AidlTest, WritePreprocessedFile) { |
| 729 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 730 | "package p; parcelable Outer.Inner;"); |
| 731 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;" |
| 732 | "interface IBar {}"); |
| 733 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 734 | vector<string> args { |
| 735 | "aidl", |
| 736 | "--preprocess", |
| 737 | "preprocessed", |
| 738 | "p/Outer.aidl", |
| 739 | "one/IBar.aidl"}; |
| 740 | Options options = Options::From(args); |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 741 | EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_)); |
| 742 | |
| 743 | string output; |
| 744 | EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output)); |
| 745 | EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output); |
| 746 | } |
| 747 | |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 748 | TEST_P(AidlTest, SupportDeprecated) { |
| 749 | struct TestCase { |
| 750 | std::string output_file; |
| 751 | std::string annotation; |
| 752 | }; |
| 753 | |
| 754 | auto CheckDeprecated = [&](const std::string& filename, const std::string& contents, |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 755 | std::vector<std::pair<Options::Language, TestCase>> expectations) { |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 756 | io_delegate_.SetFileContents(filename, contents); |
| 757 | |
| 758 | auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename + |
| 759 | " --out=out --header_out=out"); |
| 760 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 761 | for (const auto& [lang, test_case] : expectations) { |
| 762 | if (lang != GetLanguage()) continue; |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 763 | string output; |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 764 | EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output)); |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 765 | EXPECT_THAT(output, HasSubstr(test_case.annotation)); |
| 766 | } |
| 767 | }; |
| 768 | |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 769 | // Emit escaped string for notes |
| 770 | CheckDeprecated( |
| 771 | "IFoo.aidl", |
| 772 | R"(interface IFoo { |
| 773 | /** |
| 774 | * @note asdf |
| 775 | * @deprecated a really long deprecation message |
| 776 | * |
| 777 | * which is really long |
| 778 | * @param foo bar |
| 779 | */ |
| 780 | List<String> foo(); |
| 781 | })", |
| 782 | { |
| 783 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 784 | {Options::Language::CPP, |
| 785 | {"out/IFoo.h", |
| 786 | R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}}, |
| 787 | {Options::Language::NDK, |
| 788 | {"out/aidl/IFoo.h", |
| 789 | R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}}, |
| 790 | {Options::Language::RUST, |
| 791 | {"out/IFoo.rs", |
| 792 | R"(#[deprecated = "a really long deprecation message which is really long"])"}}, |
| 793 | }); |
| 794 | |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 795 | // In AIDL @deprecated can be in block comments as well as javadoc style |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 796 | CheckDeprecated( |
| 797 | "IFoo.aidl", |
| 798 | "interface IFoo {\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 799 | " /* @deprecated use bar() */\n" |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 800 | " List<String> foo();\n" |
| 801 | "}", |
| 802 | { |
| 803 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
Jooyung Han | b7a60ec | 2021-01-21 13:47:59 +0900 | [diff] [blame] | 804 | {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}}, |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 805 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}}, |
| 806 | {Options::Language::NDK, |
| 807 | {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}}, |
| 808 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}}, |
| 809 | }); |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 810 | |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 811 | // but not in line comments |
| 812 | auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage()); |
| 813 | EXPECT_FALSE(parsed->IsDeprecated()); |
| 814 | |
| 815 | // parcelable |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 816 | CheckDeprecated("Foo.aidl", |
| 817 | "parcelable Foo {\n" |
| 818 | " /** @deprecated use bar*/\n" |
| 819 | " int foo = 0;\n" |
| 820 | "}", |
| 821 | { |
| 822 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 823 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 824 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 825 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 826 | }); |
| 827 | |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 828 | // interface constants |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 829 | CheckDeprecated("IFoo.aidl", |
| 830 | "interface IFoo {\n" |
| 831 | " /** @deprecated use bar*/\n" |
| 832 | " const int FOO = 0;\n" |
| 833 | "}", |
| 834 | { |
| 835 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 836 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 837 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 838 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 839 | }); |
| 840 | |
| 841 | // union fields |
| 842 | CheckDeprecated("Foo.aidl", |
| 843 | "union Foo {\n" |
| 844 | " int bar = 0;\n" |
| 845 | " /** @deprecated use bar*/\n" |
| 846 | " int foo;\n" |
| 847 | "}", |
| 848 | { |
| 849 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 850 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 851 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 852 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 853 | }); |
| 854 | |
| 855 | CheckDeprecated("Foo.aidl", |
| 856 | "/** @deprecated use Bar */\n" |
| 857 | "parcelable Foo {}", |
| 858 | { |
| 859 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 860 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 861 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 862 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 863 | }); |
| 864 | |
| 865 | CheckDeprecated("Foo.aidl", |
| 866 | "/** @deprecated use Bar */\n" |
| 867 | "union Foo { int foo = 0; }", |
| 868 | { |
| 869 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 870 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 871 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 872 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 873 | }); |
| 874 | |
| 875 | CheckDeprecated("IFoo.aidl", |
| 876 | "/** @deprecated use IBar */\n" |
| 877 | "interface IFoo {}", |
| 878 | { |
| 879 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 880 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 881 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 882 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 883 | }); |
| 884 | |
| 885 | CheckDeprecated("Foo.aidl", |
| 886 | "/** @deprecated use IBar */\n" |
| 887 | "enum Foo { FOO }", |
| 888 | { |
| 889 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 890 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 891 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
Jooyung Han | b7a60ec | 2021-01-21 13:47:59 +0900 | [diff] [blame] | 892 | // TODO(b/177860423) support "deprecated" in Rust enum |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 893 | // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 894 | }); |
| 895 | } |
| 896 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 897 | TEST_P(AidlTest, RequireOuterClass) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 898 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n"; |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 899 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 900 | "package p; parcelable Outer.Inner;"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 901 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 902 | CaptureStderr(); |
| 903 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 904 | "package p; import p.Outer; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 905 | typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 906 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 907 | } |
| 908 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 909 | TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) { |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 910 | io_delegate_.SetFileContents("preprocessed", |
| 911 | "parcelable p.Outer.Inner;"); |
| 912 | preprocessed_files_.push_back("preprocessed"); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 913 | auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 914 | typenames_, GetLanguage()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 915 | // TODO(wiley): This should actually return nullptr because we require |
| 916 | // the outer class name. However, for legacy reasons, |
| 917 | // this behavior must be maintained. b/17415692 |
| 918 | EXPECT_NE(nullptr, parse_result); |
| 919 | } |
| 920 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 921 | TEST_F(AidlTest, FailOnParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 922 | const string expected_foo_stderr = |
| 923 | "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. " |
| 924 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 925 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 926 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;"); |
| 927 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 928 | // By default, we shouldn't fail on parcelable. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 929 | Options options1 = Options::From("aidl p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 930 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 931 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 932 | EXPECT_EQ("", GetCapturedStderr()); |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 933 | |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 934 | // -b considers this an error |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 935 | Options options2 = Options::From("aidl -b p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 936 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 937 | EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 938 | EXPECT_EQ(expected_foo_stderr, GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 939 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 940 | const string expected_bar_stderr = |
| 941 | "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. " |
| 942 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 943 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 944 | io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}"); |
| 945 | |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 946 | // With '-b' option, a parcelable and an interface should fail. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 947 | Options options3 = Options::From("aidl p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 948 | CaptureStderr(); |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 949 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 950 | EXPECT_EQ("", GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 951 | Options options4 = Options::From("aidl -b p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 952 | CaptureStderr(); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 953 | EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 954 | EXPECT_EQ(expected_bar_stderr, GetCapturedStderr()); |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 955 | } |
| 956 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 957 | TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 958 | const string expected_stderr = |
| 959 | "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a " |
| 960 | "structured interface.\n"; |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 961 | io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;"); |
| 962 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 963 | AidlError error; |
| 964 | CaptureStderr(); |
| 965 | EXPECT_EQ( |
| 966 | nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 967 | Parse("p/IFoo.aidl", |
| 968 | "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 969 | typenames_, GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 970 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 971 | EXPECT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 972 | } |
| 973 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 974 | TEST_P(AidlTest, FailOnDuplicateConstantNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 975 | AidlError error; |
| 976 | const string expected_stderr = |
| 977 | "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n"; |
| 978 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 979 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 980 | R"(package p; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 981 | interface IFoo { |
| 982 | const String DUPLICATED = "d"; |
| 983 | const int DUPLICATED = 1; |
| 984 | } |
| 985 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 986 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 987 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 988 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 989 | } |
| 990 | |
Steven Moreland | e689da2 | 2020-11-10 02:06:30 +0000 | [diff] [blame] | 991 | TEST_P(AidlTest, FailOnTooBigConstant) { |
| 992 | AidlError error; |
| 993 | const string expected_stderr = |
| 994 | "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n"; |
| 995 | CaptureStderr(); |
| 996 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 997 | R"(package p; |
| 998 | interface IFoo { |
| 999 | const byte type2small = 256; |
| 1000 | } |
| 1001 | )", |
| 1002 | typenames_, GetLanguage(), &error)); |
| 1003 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1004 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 1005 | } |
| 1006 | |
Jooyung Han | 30f64ad | 2020-12-15 08:16:31 +0900 | [diff] [blame] | 1007 | TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) { |
| 1008 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }"); |
| 1009 | CaptureStderr(); |
| 1010 | auto options = Options::From("aidl --lang java -o out a/Foo.aidl"); |
| 1011 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 1012 | EXPECT_EQ("", GetCapturedStderr()); |
| 1013 | string code; |
| 1014 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
| 1015 | EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;")); |
| 1016 | } |
| 1017 | |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1018 | TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) { |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1019 | using Ptr = unique_ptr<AidlConstantValue>; |
| 1020 | const AidlLocation& loc = AIDL_LOCATION_HERE; |
| 1021 | |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1022 | EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>()); |
| 1023 | EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>()); |
| 1024 | EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>()); |
| 1025 | EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1026 | |
| 1027 | AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+", |
| 1028 | Ptr(AidlConstantValue::Integral(loc, "1"))); |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1029 | EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1030 | |
| 1031 | auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>}; |
| 1032 | values->emplace_back(AidlConstantValue::String(loc, "\"hello\"")); |
| 1033 | values->emplace_back(AidlConstantValue::String(loc, "\"world\"")); |
| 1034 | vector<string> expected{"hello", "world"}; |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1035 | EXPECT_EQ( |
| 1036 | expected, |
| 1037 | Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1038 | } |
| 1039 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1040 | TEST_P(AidlTest, FailOnManyDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1041 | AidlError error; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1042 | const string expected_stderr = |
| 1043 | "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 1044 | CaptureStderr(); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1045 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1046 | R"(package p; |
| 1047 | interface IFoo {} |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1048 | parcelable IBar {} |
| 1049 | parcelable StructuredParcelable {} |
| 1050 | interface IBaz {} |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 1051 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1052 | typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 1053 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1054 | // Parse success is important for clear error handling even if the cases aren't |
| 1055 | // actually supported in code generation. |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1056 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1057 | } |
| 1058 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1059 | TEST_P(AidlTest, FailOnNoDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1060 | AidlError error; |
| 1061 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n"; |
| 1062 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1063 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1064 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1065 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1066 | } |
| 1067 | |
Steven Moreland | f9e922f | 2020-07-08 21:15:27 +0000 | [diff] [blame] | 1068 | TEST_P(AidlTest, FailOnEmptyListWithComma) { |
| 1069 | AidlError error; |
| 1070 | const string expected_stderr = |
| 1071 | "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n"; |
| 1072 | CaptureStderr(); |
| 1073 | EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })", |
| 1074 | typenames_, GetLanguage(), &error)); |
| 1075 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1076 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1077 | } |
| 1078 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1079 | TEST_P(AidlTest, FailOnMalformedConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1080 | AidlError error; |
| 1081 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 1082 | "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1083 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1084 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1085 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1086 | interface IFoo { |
| 1087 | const int BAD_HEX_VALUE = 0xffffffffffffffffff; |
| 1088 | } |
| 1089 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1090 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1091 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1092 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1093 | } |
| 1094 | |
Jiyong Park | 1813218 | 2020-06-08 20:24:40 +0900 | [diff] [blame] | 1095 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) { |
| 1096 | AidlError error; |
| 1097 | const string expected_stderr = |
| 1098 | "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or " |
| 1099 | "cpp_header (which can also be used as an identifier)\n"; |
| 1100 | CaptureStderr(); |
| 1101 | // Notice the trailing dot(.) in the name, which isn't a correct name |
| 1102 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_, |
| 1103 | GetLanguage(), &error)); |
| 1104 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1105 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1106 | } |
| 1107 | |
| 1108 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) { |
| 1109 | AidlError error; |
| 1110 | const string expected_stderr = |
| 1111 | "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or " |
| 1112 | "cpp_header (which can also be used as an identifier)\n"; |
| 1113 | CaptureStderr(); |
| 1114 | // Notice the trailing dot(.) in the package name |
| 1115 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_, |
| 1116 | GetLanguage(), &error)); |
| 1117 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1118 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1119 | } |
| 1120 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1121 | TEST_P(AidlTest, ParsePositiveConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1122 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1123 | auto parse_result = Parse("p/IFoo.aidl", |
| 1124 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1125 | interface IFoo { |
| 1126 | const int POSITIVE_HEX_VALUE = 0xf5; |
| 1127 | } |
| 1128 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1129 | typenames_, GetLanguage(), &error); |
| 1130 | EXPECT_NE(nullptr, parse_result); |
| 1131 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1132 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1133 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1134 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1135 | EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1136 | EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1137 | EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1138 | } |
| 1139 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1140 | TEST_P(AidlTest, ParseNegativeConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1141 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1142 | auto parse_result = Parse("p/IFoo.aidl", |
| 1143 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1144 | interface IFoo { |
| 1145 | const int NEGATIVE_HEX_VALUE = 0xffffffff; |
| 1146 | } |
| 1147 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1148 | typenames_, GetLanguage(), &error); |
| 1149 | ASSERT_NE(nullptr, parse_result); |
| 1150 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1151 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1152 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1153 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1154 | EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1155 | EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1156 | EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1157 | } |
| 1158 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1159 | TEST_P(AidlTest, UnderstandsNestedParcelables) { |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1160 | io_delegate_.SetFileContents( |
| 1161 | "p/Outer.aidl", |
| 1162 | "package p; parcelable Outer.Inner cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1163 | import_paths_.emplace(""); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1164 | const string input_path = "p/IFoo.aidl"; |
| 1165 | const string input = "package p; import p.Outer; interface IFoo" |
| 1166 | " { Outer.Inner get(); }"; |
| 1167 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1168 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1169 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1170 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1171 | EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1172 | // C++ uses "::" instead of "." to refer to a inner class. |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 1173 | AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {}); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1174 | EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_)); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1175 | } |
| 1176 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1177 | TEST_P(AidlTest, UnderstandsNativeParcelables) { |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1178 | io_delegate_.SetFileContents( |
| 1179 | "p/Bar.aidl", |
Casey Dahlin | cd63921 | 2015-12-15 12:51:04 -0800 | [diff] [blame] | 1180 | "package p; parcelable Bar cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1181 | import_paths_.emplace(""); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1182 | const string input_path = "p/IFoo.aidl"; |
| 1183 | const string input = "package p; import p.Bar; interface IFoo { }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1184 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1185 | EXPECT_NE(nullptr, parse_result); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1186 | EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved); |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 1187 | AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {}); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1188 | native_type.Resolve(typenames_); |
| 1189 | |
| 1190 | EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_)); |
| 1191 | // C++ understands C++ specific stuff |
| 1192 | EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_)); |
| 1193 | set<string> headers; |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 1194 | cpp::AddHeaders(native_type, typenames_, &headers); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1195 | EXPECT_EQ(1u, headers.size()); |
| 1196 | EXPECT_EQ(1u, headers.count("baz/header")); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1197 | } |
| 1198 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1199 | TEST_F(AidlTest, WritesCorrectDependencyFile) { |
| 1200 | // While the in tree build system always gives us an output file name, |
| 1201 | // other android tools take advantage of our ability to infer the intended |
| 1202 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1203 | vector<string> args = { |
| 1204 | "aidl", |
| 1205 | "-d dep/file/path", |
| 1206 | "-o place/for/output", |
| 1207 | "p/IFoo.aidl"}; |
| 1208 | Options options = Options::From(args); |
| 1209 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1210 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1211 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1212 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1213 | EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents); |
| 1214 | } |
| 1215 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1216 | TEST_F(AidlTest, WritesCorrectDependencyFileNinja) { |
| 1217 | // While the in tree build system always gives us an output file name, |
| 1218 | // other android tools take advantage of our ability to infer the intended |
| 1219 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1220 | vector<string> args = { |
| 1221 | "aidl", |
| 1222 | "-d dep/file/path", |
| 1223 | "--ninja", |
| 1224 | "-o place/for/output", |
| 1225 | "p/IFoo.aidl"}; |
| 1226 | Options options = Options::From(args); |
| 1227 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1228 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1229 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1230 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1231 | EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents); |
| 1232 | } |
| 1233 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1234 | TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) { |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1235 | // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does |
| 1236 | // this by calling aidl with every .aidl file it finds, then parsing the |
| 1237 | // generated dependency files. Those that reference .java output files are |
| 1238 | // for interfaces and those that do not are parcelables. However, for both |
| 1239 | // parcelables and interfaces, we *must* generate a non-empty dependency file. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1240 | vector<string> args = { |
| 1241 | "aidl", |
| 1242 | "-o place/for/output", |
| 1243 | "-d dep/file/path", |
| 1244 | "p/Foo.aidl"}; |
| 1245 | Options options = Options::From(args); |
| 1246 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1247 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1248 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1249 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1250 | EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents); |
| 1251 | } |
| 1252 | |
| 1253 | TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) { |
| 1254 | vector<string> args = { |
| 1255 | "aidl", |
| 1256 | "--structured", |
| 1257 | "-o place/for/output", |
| 1258 | "-d dep/file/path", |
| 1259 | "p/Foo.aidl"}; |
| 1260 | Options options = Options::From(args); |
| 1261 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}"); |
| 1262 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1263 | string actual_dep_file_contents; |
| 1264 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
| 1265 | EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1266 | } |
| 1267 | |
Jiyong Park | 9ca5c7e | 2019-10-17 15:01:14 +0900 | [diff] [blame] | 1268 | TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) { |
| 1269 | vector<string> args = { |
| 1270 | "aidl", |
| 1271 | "--lang=java", |
| 1272 | "-o place/for/output", |
| 1273 | "p/Foo.aidl"}; |
| 1274 | Options options = Options::From(args); |
| 1275 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
| 1276 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1277 | string output_file_contents; |
| 1278 | EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents)); |
| 1279 | } |
| 1280 | |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1281 | TEST_P(AidlTest, RejectsListArray) { |
Devin Moore | 6a01ca1 | 2020-08-28 10:24:19 -0700 | [diff] [blame] | 1282 | const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n"; |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1283 | const string list_array_parcelable = |
| 1284 | "package a; parcelable Foo {\n" |
| 1285 | " List[] lists; }"; |
| 1286 | CaptureStderr(); |
| 1287 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage())); |
| 1288 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1289 | } |
| 1290 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1291 | TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) { |
| 1292 | AidlError error; |
| 1293 | string expected_stderr = |
| 1294 | "ERROR: a/IFoo.aidl:2.7-11: " |
| 1295 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 1296 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 1297 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 1298 | if (GetLanguage() != Options::Language::JAVA) { |
| 1299 | expected_stderr = |
| 1300 | "ERROR: a/IFoo.aidl:2.1-7: " |
| 1301 | "Currently, only the Java backend supports non-generic List.\n"; |
| 1302 | } |
| 1303 | |
| 1304 | const string primitive_interface = |
| 1305 | "package a; interface IFoo {\n" |
| 1306 | " List foo(); }"; |
| 1307 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1308 | AidlTypenames tn1; |
| 1309 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1310 | {"--structured"})); |
| 1311 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1312 | |
| 1313 | string primitive_parcelable = |
| 1314 | "package a; parcelable IFoo {\n" |
| 1315 | " List foo;}"; |
| 1316 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1317 | AidlTypenames tn2; |
| 1318 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1319 | {"--structured"})); |
| 1320 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1321 | } |
| 1322 | |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1323 | TEST_P(AidlTest, ExtensionTest) { |
| 1324 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1325 | string extendable_parcelable = |
| 1326 | "package a; parcelable Data {\n" |
| 1327 | " ParcelableHolder extension;\n" |
| 1328 | " ParcelableHolder extension2;\n" |
| 1329 | "}"; |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1330 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1331 | EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1332 | EXPECT_EQ( |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1333 | "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1334 | "yet.\n", |
| 1335 | GetCapturedStderr()); |
| 1336 | } else { |
| 1337 | EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1338 | EXPECT_EQ("", GetCapturedStderr()); |
| 1339 | } |
| 1340 | } |
| 1341 | TEST_P(AidlTest, ParcelableHolderAsReturnType) { |
| 1342 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1343 | string parcelableholder_return_interface = |
| 1344 | "package a; interface IFoo {\n" |
| 1345 | " ParcelableHolder foo();\n" |
| 1346 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1347 | EXPECT_EQ(nullptr, |
| 1348 | Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage())); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1349 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1350 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1351 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1352 | "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1353 | "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1354 | "yet.\n", |
| 1355 | GetCapturedStderr()); |
| 1356 | return; |
| 1357 | } |
| 1358 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n", |
| 1359 | GetCapturedStderr()); |
| 1360 | } |
| 1361 | |
| 1362 | TEST_P(AidlTest, ParcelableHolderAsArgumentType) { |
| 1363 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1364 | string extendable_parcelable_arg_interface = |
| 1365 | "package a; interface IFoo {\n" |
| 1366 | " void foo(in ParcelableHolder ph);\n" |
| 1367 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1368 | EXPECT_EQ(nullptr, |
| 1369 | Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage())); |
| 1370 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1371 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1372 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1373 | "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1374 | "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1375 | "yet.\n", |
| 1376 | GetCapturedStderr()); |
| 1377 | return; |
| 1378 | } |
| 1379 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n", |
| 1380 | GetCapturedStderr()); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1381 | } |
| 1382 | |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1383 | TEST_P(AidlTest, RejectNullableParcelableHolderField) { |
| 1384 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1385 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1386 | const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"; |
| 1387 | CaptureStderr(); |
| 1388 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1389 | if (GetLanguage() == Options::Language::RUST) { |
| 1390 | EXPECT_EQ( |
| 1391 | "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n" |
| 1392 | "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder " |
| 1393 | "yet.\n", |
| 1394 | GetCapturedStderr()); |
| 1395 | return; |
| 1396 | } |
| 1397 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1398 | } |
| 1399 | |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1400 | TEST_P(AidlTest, ParcelablesWithConstants) { |
| 1401 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1402 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1403 | CaptureStderr(); |
| 1404 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1405 | EXPECT_EQ("", GetCapturedStderr()); |
| 1406 | } |
| 1407 | |
| 1408 | TEST_P(AidlTest, UnionWithConstants) { |
| 1409 | io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1410 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1411 | CaptureStderr(); |
| 1412 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1413 | EXPECT_EQ("", GetCapturedStderr()); |
| 1414 | } |
| 1415 | |
Jooyung Han | 633eab6 | 2021-01-07 14:12:40 +0900 | [diff] [blame] | 1416 | TEST_F(AidlTest, ConstantsWithAnnotations) { |
| 1417 | io_delegate_.SetFileContents("IFoo.aidl", |
| 1418 | "interface IFoo {\n" |
| 1419 | " @JavaPassthrough(annotation=\"@Foo\")\n" |
| 1420 | " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n" |
| 1421 | "}"); |
| 1422 | Options options = Options::From("aidl IFoo.aidl --lang=java -o out"); |
| 1423 | CaptureStderr(); |
| 1424 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1425 | EXPECT_EQ("", GetCapturedStderr()); |
| 1426 | string code; |
| 1427 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code)); |
| 1428 | EXPECT_THAT(code, HasSubstr("@Foo\n")); |
| 1429 | EXPECT_THAT(code, HasSubstr("@Bar\n")); |
| 1430 | } |
| 1431 | |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1432 | TEST_F(AidlTest, ApiDump) { |
| 1433 | io_delegate_.SetFileContents( |
| 1434 | "foo/bar/IFoo.aidl", |
| 1435 | "package foo.bar;\n" |
| 1436 | "import foo.bar.Data;\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1437 | "// commented /* @hide */\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1438 | "interface IFoo {\n" |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1439 | " /* @hide applied \n" |
| 1440 | " @deprecated use foo2 */\n" |
| 1441 | " int foo(out int[] a, String b, boolean c, inout List<String> d);\n" |
| 1442 | " int foo2(@utf8InCpp String x, inout List<String> y);\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1443 | " IFoo foo3(IFoo foo);\n" |
| 1444 | " Data getData();\n" |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1445 | " // @hide not applied\n" |
Jooyung Han | 9fd6702 | 2021-01-13 10:49:48 +0900 | [diff] [blame] | 1446 | " /** blahblah\n" |
| 1447 | " @deprecated\n" |
| 1448 | " reason why... */\n" |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1449 | " const int A = 1;\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1450 | " // @deprecated tags in line comments are ignored\n" |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1451 | " const String STR = \"Hello\";\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1452 | "}\n"); |
| 1453 | io_delegate_.SetFileContents("foo/bar/Data.aidl", |
| 1454 | "package foo.bar;\n" |
| 1455 | "import foo.bar.IFoo;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1456 | "/* @hide*/\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1457 | "parcelable Data {\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1458 | " // @hide\n" |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 1459 | " int x = 10;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1460 | " // @hide\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1461 | " int y;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1462 | " /*@hide2*/\n" |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 1463 | " IFoo foo;\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1464 | " // Ignore @hide property in line comment\n" |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1465 | " @nullable String[] c;\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1466 | "}\n"); |
| 1467 | io_delegate_.SetFileContents("api.aidl", ""); |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1468 | vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.", |
| 1469 | "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"}; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1470 | Options options = Options::From(args); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1471 | bool result = dump_api(options, io_delegate_); |
| 1472 | ASSERT_TRUE(result); |
| 1473 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1474 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1475 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1476 | interface IFoo { |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1477 | /** |
| 1478 | * @hide |
| 1479 | * @deprecated use foo2 |
| 1480 | */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1481 | int foo(out int[] a, String b, boolean c, inout List<String> d); |
| 1482 | int foo2(@utf8InCpp String x, inout List<String> y); |
| 1483 | foo.bar.IFoo foo3(foo.bar.IFoo foo); |
| 1484 | foo.bar.Data getData(); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1485 | /** |
| 1486 | * @deprecated reason why... |
| 1487 | */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1488 | const int A = 1; |
| 1489 | const String STR = "Hello"; |
| 1490 | } |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1491 | )"), |
| 1492 | actual); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1493 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1494 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual)); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1495 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
Jooyung Han | 8db6594 | 2021-03-02 18:14:44 +0900 | [diff] [blame] | 1496 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1497 | parcelable Data { |
| 1498 | int x = 10; |
| 1499 | int y; |
| 1500 | foo.bar.IFoo foo; |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1501 | @nullable String[] c; |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1502 | } |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1503 | )"), |
| 1504 | actual); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1505 | } |
| 1506 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1507 | TEST_F(AidlTest, ApiDumpWithManualIds) { |
| 1508 | io_delegate_.SetFileContents( |
| 1509 | "foo/bar/IFoo.aidl", |
| 1510 | "package foo.bar;\n" |
| 1511 | "interface IFoo {\n" |
| 1512 | " int foo() = 1;\n" |
| 1513 | " int bar() = 2;\n" |
| 1514 | " int baz() = 10;\n" |
| 1515 | "}\n"); |
| 1516 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1517 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1518 | Options options = Options::From(args); |
| 1519 | bool result = dump_api(options, io_delegate_); |
| 1520 | ASSERT_TRUE(result); |
| 1521 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1522 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1523 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1524 | interface IFoo { |
| 1525 | int foo() = 1; |
| 1526 | int bar() = 2; |
| 1527 | int baz() = 10; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1528 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1529 | )")); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1530 | } |
| 1531 | |
| 1532 | TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1533 | const string expected_stderr = |
| 1534 | "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of " |
| 1535 | "them.\n"; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1536 | io_delegate_.SetFileContents( |
| 1537 | "foo/bar/IFoo.aidl", |
| 1538 | "package foo.bar;\n" |
| 1539 | "interface IFoo {\n" |
| 1540 | " int foo() = 1;\n" |
| 1541 | " int bar();\n" |
| 1542 | " int baz() = 10;\n" |
| 1543 | "}\n"); |
| 1544 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1545 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1546 | Options options = Options::From(args); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1547 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1548 | EXPECT_FALSE(dump_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1549 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1550 | } |
| 1551 | |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1552 | TEST_F(AidlTest, ApiDumpConstWithAnnotation) { |
| 1553 | io_delegate_.SetFileContents("foo/bar/IFoo.aidl", |
| 1554 | "package foo.bar;\n" |
| 1555 | "interface IFoo {\n" |
| 1556 | " @utf8InCpp String foo();\n" |
| 1557 | " const @utf8InCpp String bar = \"bar\";\n" |
| 1558 | "}\n"); |
| 1559 | |
| 1560 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
| 1561 | Options options = Options::From(args); |
| 1562 | CaptureStderr(); |
| 1563 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1564 | EXPECT_EQ("", GetCapturedStderr()); |
| 1565 | string actual; |
| 1566 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1567 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
| 1568 | interface IFoo { |
| 1569 | @utf8InCpp String foo(); |
Jooyung Han | b3ca630 | 2020-11-27 14:13:27 +0900 | [diff] [blame] | 1570 | const @utf8InCpp String bar = "bar"; |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1571 | } |
| 1572 | )"), |
| 1573 | actual); |
| 1574 | } |
| 1575 | |
Jooyung Han | fdaae1d | 2020-12-14 13:16:15 +0900 | [diff] [blame] | 1576 | TEST_F(AidlTest, ApiDumpWithEnums) { |
| 1577 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 1578 | "package foo.bar;\n" |
| 1579 | "enum Enum {\n" |
| 1580 | " FOO,\n" |
| 1581 | " BAR = FOO + 1,\n" |
| 1582 | "}\n"); |
| 1583 | |
| 1584 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"}; |
| 1585 | Options options = Options::From(args); |
| 1586 | CaptureStderr(); |
| 1587 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1588 | EXPECT_EQ("", GetCapturedStderr()); |
| 1589 | string actual; |
| 1590 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual)); |
| 1591 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1592 | "enum Enum {\n" |
| 1593 | " FOO = 0,\n" |
| 1594 | " BAR = 1,\n" |
| 1595 | "}\n"), |
| 1596 | actual); |
| 1597 | } |
| 1598 | |
| 1599 | TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) { |
| 1600 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 1601 | "package foo.bar;\n" |
| 1602 | "enum Enum {\n" |
| 1603 | " FOO,\n" |
| 1604 | "}\n"); |
| 1605 | io_delegate_.SetFileContents("foo/bar/Foo.aidl", |
| 1606 | "package foo.bar;\n" |
| 1607 | "import foo.bar.Enum;\n" |
| 1608 | "parcelable Foo {\n" |
| 1609 | " Enum e = Enum.FOO;\n" |
| 1610 | "}\n"); |
| 1611 | |
| 1612 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"}; |
| 1613 | Options options = Options::From(args); |
| 1614 | CaptureStderr(); |
| 1615 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1616 | EXPECT_EQ("", GetCapturedStderr()); |
| 1617 | string actual; |
| 1618 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual)); |
| 1619 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1620 | "parcelable Foo {\n" |
| 1621 | " foo.bar.Enum e = foo.bar.Enum.FOO;\n" |
| 1622 | "}\n"), |
| 1623 | actual); |
| 1624 | } |
| 1625 | |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1626 | TEST_F(AidlTest, CheckNumGenericTypeSecifier) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1627 | const string expected_list_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1628 | "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: " |
| 1629 | "'List<String,String>'\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1630 | const string expected_map_stderr = |
| 1631 | "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n"; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1632 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1633 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1634 | "package p; interface IFoo {" |
| 1635 | "void foo(List<String, String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1636 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1637 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1638 | EXPECT_EQ(expected_list_stderr, GetCapturedStderr()); |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1639 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1640 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1641 | "package p; interface IFoo {" |
| 1642 | "void foo(Map<String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1643 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1644 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1645 | EXPECT_EQ(expected_map_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1646 | } |
| 1647 | |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1648 | TEST_F(AidlTest, CheckTypeParameterInMapType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1649 | const string expected_stderr = |
| 1650 | "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n"; |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1651 | Options options = Options::From("aidl -I p p/IFoo.aidl"); |
| 1652 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }"); |
| 1653 | |
| 1654 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1655 | "package p; interface IFoo {" |
| 1656 | "Map<String, Bar> foo();}"); |
| 1657 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1658 | |
| 1659 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1660 | "package p; interface IFoo {" |
| 1661 | "Map<Bar, Bar> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1662 | CaptureStderr(); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1663 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1664 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1665 | |
| 1666 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1667 | "package p; interface IFoo {" |
| 1668 | "Map<String, String> foo();}"); |
| 1669 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1670 | |
| 1671 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1672 | "package p; interface IFoo {" |
| 1673 | "Map<String, ParcelFileDescriptor> foo();}"); |
| 1674 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1675 | } |
| 1676 | |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1677 | TEST_F(AidlTest, WrongGenericType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1678 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n"; |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1679 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1680 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1681 | "package p; interface IFoo {" |
| 1682 | "String<String> foo(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1683 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1684 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1685 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1686 | } |
| 1687 | |
| 1688 | TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) { |
| 1689 | Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl"); |
| 1690 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1691 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1692 | EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1693 | EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n", |
| 1694 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1695 | |
| 1696 | Options options = Options::From("aidl -I p p/IFoo.aidl"); |
| 1697 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;"); |
| 1698 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1699 | "package p; interface IFoo {" |
| 1700 | "Bar<String, String> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1701 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1702 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1703 | EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1704 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1705 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1706 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1707 | EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n", |
| 1708 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1709 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;"); |
| 1710 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1711 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1712 | "package p; interface IFoo {" |
| 1713 | "Bar<String, ParcelFileDescriptor> foo();}"); |
| 1714 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jeongik Cha | e74c86d | 2019-12-12 16:54:03 +0900 | [diff] [blame] | 1715 | |
| 1716 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1717 | "package p; interface IFoo {" |
| 1718 | "Bar<int, long> foo();}"); |
| 1719 | |
| 1720 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1721 | "package p; interface IFoo {" |
| 1722 | "Bar<int[], long[]> foo();}"); |
| 1723 | |
| 1724 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1725 | } |
| 1726 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1727 | TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) { |
| 1728 | std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl", |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1729 | "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl", |
| 1730 | "aidl --lang=rust -o out foo/bar/Foo.aidl"}; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1731 | for (const auto& rawOption : rawOptions) { |
| 1732 | string expected_stderr = |
| 1733 | "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1734 | Options options = Options::From(rawOption); |
| 1735 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1736 | "package foo.bar;\n" |
| 1737 | "interface IFoo1 { int foo(); }\n" |
| 1738 | "interface IFoo2 { int foo(); }\n" |
| 1739 | "parcelable Data1 { int a; int b;}\n" |
| 1740 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1741 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1742 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1743 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1744 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1745 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1746 | "package foo.bar;\n" |
| 1747 | "interface IFoo1 { int foo(); }\n" |
| 1748 | "interface IFoo2 { int foo(); }\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1749 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1750 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1751 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1752 | |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1753 | expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1754 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1755 | "package foo.bar;\n" |
| 1756 | "parcelable Data1 { int a; int b;}\n" |
| 1757 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1758 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1759 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1760 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1761 | } |
| 1762 | } |
| 1763 | |
Devin Moore | bdba2a8 | 2020-03-31 15:19:02 -0700 | [diff] [blame] | 1764 | TEST_P(AidlTest, FailParseOnEmptyFile) { |
| 1765 | const string contents = ""; |
| 1766 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n"; |
| 1767 | CaptureStderr(); |
| 1768 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage())); |
| 1769 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1770 | } |
| 1771 | |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1772 | TEST_F(AidlTest, MultipleInputFiles) { |
| 1773 | Options options = Options::From( |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1774 | "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1775 | |
| 1776 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1777 | "package foo.bar;\n" |
| 1778 | "import foo.bar.Data;\n" |
| 1779 | "interface IFoo { Data getData(); }\n"); |
| 1780 | |
| 1781 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1782 | "package foo.bar;\n" |
| 1783 | "import foo.bar.IFoo;\n" |
| 1784 | "parcelable Data { IFoo foo; }\n"); |
| 1785 | |
| 1786 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1787 | |
| 1788 | string content; |
| 1789 | for (const auto file : { |
| 1790 | "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) { |
| 1791 | content.clear(); |
| 1792 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1793 | EXPECT_FALSE(content.empty()); |
| 1794 | } |
| 1795 | } |
| 1796 | |
| 1797 | TEST_F(AidlTest, MultipleInputFilesCpp) { |
| 1798 | Options options = Options::From("aidl --lang=cpp -o out -h out/include " |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1799 | "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1800 | |
| 1801 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1802 | "package foo.bar;\n" |
| 1803 | "import foo.bar.Data;\n" |
| 1804 | "interface IFoo { Data getData(); }\n"); |
| 1805 | |
| 1806 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1807 | "package foo.bar;\n" |
| 1808 | "import foo.bar.IFoo;\n" |
| 1809 | "parcelable Data { IFoo foo; }\n"); |
| 1810 | |
| 1811 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1812 | |
| 1813 | string content; |
| 1814 | for (const auto file : { |
Jiyong Park | b03551f | 2018-08-06 19:20:51 +0900 | [diff] [blame] | 1815 | "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp", |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1816 | "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h", |
| 1817 | "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h", |
| 1818 | "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) { |
| 1819 | content.clear(); |
| 1820 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1821 | EXPECT_FALSE(content.empty()); |
| 1822 | } |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1823 | } |
| 1824 | |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1825 | TEST_F(AidlTest, MultipleInputFilesRust) { |
| 1826 | Options options = |
| 1827 | Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
| 1828 | |
| 1829 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1830 | "package foo.bar;\n" |
| 1831 | "import foo.bar.Data;\n" |
| 1832 | "interface IFoo { Data getData(); }\n"); |
| 1833 | |
| 1834 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1835 | "package foo.bar;\n" |
| 1836 | "import foo.bar.IFoo;\n" |
| 1837 | "parcelable Data { IFoo foo; }\n"); |
| 1838 | |
| 1839 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1840 | |
| 1841 | string content; |
| 1842 | for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) { |
| 1843 | content.clear(); |
| 1844 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1845 | EXPECT_FALSE(content.empty()); |
| 1846 | } |
| 1847 | } |
| 1848 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1849 | TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) { |
| 1850 | const string expected_stderr = |
| 1851 | "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n"; |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1852 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
| 1853 | // int getInterfaceVersion() is one of the meta transactions |
| 1854 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1855 | "package p; interface IFoo {" |
| 1856 | "int getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1857 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1858 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1859 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1860 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1861 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1862 | TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) { |
| 1863 | // boolean getInterfaceVersion() is not a meta transaction, but should be |
| 1864 | // prevented because return type is not part of a method signature |
| 1865 | const string expected_stderr = |
| 1866 | "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n"; |
| 1867 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1868 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1869 | "package p; interface IFoo {" |
| 1870 | "boolean getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1871 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1872 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1873 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1874 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1875 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1876 | TEST_F(AidlTest, ConflictWithMetaTransactionGetName) { |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1877 | // this is another reserved name |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1878 | const string expected_stderr = |
| 1879 | "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n"; |
| 1880 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1881 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1882 | "package p; interface IFoo {" |
| 1883 | "String getTransactionName(int code); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1884 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1885 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1886 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1887 | |
| 1888 | // this is not a meta interface method as it differs type arguments |
| 1889 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1890 | "package p; interface IFoo {" |
| 1891 | "String getTransactionName(); }"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1892 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1893 | } |
| 1894 | |
Jooyung Han | b8a9777 | 2021-01-19 01:27:38 +0900 | [diff] [blame] | 1895 | TEST_F(AidlTest, CheckApiForEquality) { |
| 1896 | CaptureStderr(); |
| 1897 | Options options = Options::From("aidl --checkapi=equal old new"); |
| 1898 | |
| 1899 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1900 | "package p; interface IFoo{ @utf8InCpp @nullable String foo();}"); |
| 1901 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1902 | "package p; interface IFoo{ @utf8InCpp String foo();}"); |
| 1903 | |
| 1904 | EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_)); |
| 1905 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();")); |
| 1906 | } |
| 1907 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1908 | TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) { |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1909 | Options options = Options::From("aidl --checkapi old new"); |
| 1910 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1911 | "package p; interface IFoo{ @utf8InCpp @nullable String foo();}"); |
| 1912 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1913 | "package p; interface IFoo{ @nullable @utf8InCpp String foo();}"); |
| 1914 | |
| 1915 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 1916 | } |
| 1917 | |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1918 | TEST_F(AidlTest, SuccessOnIdenticalApiDumps) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1919 | Options options = Options::From("aidl --checkapi old new"); |
| 1920 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
| 1921 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1922 | |
| 1923 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 1924 | } |
| 1925 | |
Jooyung Han | fdaae1d | 2020-12-14 13:16:15 +0900 | [diff] [blame] | 1926 | TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) { |
| 1927 | Options options = Options::From("aidl --checkapi old new"); |
| 1928 | const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }"; |
| 1929 | const string enum_definition = "package p; enum Enum { FOO }"; |
| 1930 | io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition); |
| 1931 | io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition); |
| 1932 | io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition); |
| 1933 | io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition); |
| 1934 | |
| 1935 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 1936 | } |
| 1937 | |
Jooyung Han | 02a11be | 2021-02-11 13:18:06 +0900 | [diff] [blame] | 1938 | TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) { |
| 1939 | Options options = Options::From("aidl --checkapi=equal old new"); |
| 1940 | const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }"; |
| 1941 | const string enum_definition = "package p; enum Enum { FOO }"; |
| 1942 | io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition); |
| 1943 | io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition); |
| 1944 | io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition); |
| 1945 | io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition); |
| 1946 | CaptureStderr(); |
| 1947 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 1948 | EXPECT_EQ("", GetCapturedStderr()); |
| 1949 | } |
| 1950 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1951 | class AidlTestCompatibleChanges : public AidlTest { |
| 1952 | protected: |
| 1953 | Options options_ = Options::From("aidl --checkapi old new"); |
| 1954 | }; |
| 1955 | |
| 1956 | TEST_F(AidlTestCompatibleChanges, NewType) { |
| 1957 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1958 | "package p;" |
| 1959 | "interface IFoo {" |
| 1960 | " void foo(int a);" |
| 1961 | "}"); |
| 1962 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1963 | "package p;" |
| 1964 | "interface IFoo {" |
| 1965 | " void foo(int a);" |
| 1966 | "}"); |
| 1967 | io_delegate_.SetFileContents("new/p/IBar.aidl", |
| 1968 | "package p;" |
| 1969 | "interface IBar {" |
| 1970 | " void bar();" |
| 1971 | "}"); |
| 1972 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1973 | } |
| 1974 | |
| 1975 | TEST_F(AidlTestCompatibleChanges, NewMethod) { |
| 1976 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1977 | "package p;" |
| 1978 | "interface IFoo {" |
| 1979 | " void foo(int a);" |
| 1980 | "}"); |
| 1981 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1982 | "package p;" |
| 1983 | "interface IFoo {" |
| 1984 | " void foo(int a);" |
| 1985 | " void bar();" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1986 | " void baz(in List<IFoo> arg);" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1987 | "}"); |
| 1988 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1989 | } |
| 1990 | |
| 1991 | TEST_F(AidlTestCompatibleChanges, NewField) { |
| 1992 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 1993 | "package p;" |
| 1994 | "parcelable Data {" |
| 1995 | " int foo;" |
| 1996 | "}"); |
| 1997 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 1998 | "package p;" |
| 1999 | "parcelable Data {" |
| 2000 | " int foo;" |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2001 | " int bar = 0;" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2002 | " @nullable List<Data> list;" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2003 | "}"); |
| 2004 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2005 | } |
| 2006 | |
| 2007 | TEST_F(AidlTestCompatibleChanges, NewEnumerator) { |
| 2008 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2009 | "package p;" |
| 2010 | "enum Enum {" |
| 2011 | " FOO = 1," |
| 2012 | "}"); |
| 2013 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2014 | "package p;" |
| 2015 | "enum Enum {" |
| 2016 | " FOO = 1," |
| 2017 | " BAR = 2," |
| 2018 | "}"); |
| 2019 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2020 | } |
| 2021 | |
| 2022 | TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) { |
| 2023 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2024 | "package p;" |
| 2025 | "enum Enum {" |
| 2026 | " FOO = 1," |
| 2027 | " BAR = 2," |
| 2028 | "}"); |
| 2029 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2030 | "package p;" |
| 2031 | "enum Enum {" |
| 2032 | " BAR = 2," |
| 2033 | " FOO = 1," |
| 2034 | "}"); |
| 2035 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2036 | } |
| 2037 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2038 | TEST_F(AidlTestCompatibleChanges, NewUnionField) { |
| 2039 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2040 | "package p;" |
| 2041 | "union Union {" |
| 2042 | " String foo;" |
| 2043 | "}"); |
| 2044 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2045 | "package p;" |
| 2046 | "union Union {" |
| 2047 | " String foo;" |
| 2048 | " int num;" |
| 2049 | "}"); |
| 2050 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2051 | } |
| 2052 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2053 | TEST_F(AidlTestCompatibleChanges, NewPackage) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2054 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2055 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2056 | "interface IFoo {" |
| 2057 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2058 | "}"); |
| 2059 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2060 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2061 | "parcelable Data {" |
| 2062 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2063 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2064 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2065 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2066 | "interface IFoo {" |
| 2067 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2068 | "}"); |
| 2069 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2070 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2071 | "parcelable Data {" |
| 2072 | " int foo;" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2073 | "}"); |
| 2074 | io_delegate_.SetFileContents("new/q/IFoo.aidl", |
| 2075 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2076 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2077 | " void foo(int a);" |
| 2078 | "}"); |
| 2079 | io_delegate_.SetFileContents("new/q/Data.aidl", |
| 2080 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2081 | "parcelable Data {" |
| 2082 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2083 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2084 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2085 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2086 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2087 | TEST_F(AidlTestCompatibleChanges, ArgNameChange) { |
| 2088 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2089 | "package p;" |
| 2090 | "interface IFoo {" |
| 2091 | " void foo(int a);" |
| 2092 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2093 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2094 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2095 | "interface IFoo {" |
| 2096 | " void foo(int b);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2097 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2098 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2099 | } |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2100 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2101 | TEST_F(AidlTestCompatibleChanges, AddedConstValue) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2102 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2103 | "package p; interface I {" |
| 2104 | "const int A = 1; }"); |
| 2105 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 2106 | "package p ; interface I {" |
| 2107 | "const int A = 1; const int B = 2;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2108 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2109 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2110 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2111 | TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2112 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2113 | "package p; interface I {" |
| 2114 | "const int A = 1; const int B = 2;}"); |
| 2115 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 2116 | "package p ; interface I {" |
| 2117 | "const int B = 2; const int A = 1;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2118 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2119 | } |
| 2120 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2121 | TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) { |
| 2122 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2123 | "package p;" |
| 2124 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2125 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2126 | "parcelable Foo {}"); |
| 2127 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2128 | "package p;" |
| 2129 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2130 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2131 | "parcelable Foo {}"); |
| 2132 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2133 | } |
| 2134 | |
Jooyung Han | 0007327 | 2020-11-27 14:20:20 +0900 | [diff] [blame] | 2135 | TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) { |
| 2136 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2137 | "package p;" |
| 2138 | "parcelable Foo {}"); |
| 2139 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2140 | "package p;" |
| 2141 | "@JavaPassthrough(annotation=\"@Deprecated\")" |
| 2142 | "parcelable Foo {}"); |
| 2143 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2144 | } |
| 2145 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2146 | TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) { |
| 2147 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2148 | "package p;" |
| 2149 | "parcelable Data {" |
| 2150 | " int num;" |
| 2151 | "}"); |
| 2152 | io_delegate_.SetFileContents( |
| 2153 | "new/p/Data.aidl", |
| 2154 | "package p;" |
| 2155 | "parcelable Data {" |
| 2156 | " int num;" |
| 2157 | " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type |
| 2158 | "}"); |
| 2159 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2160 | "package p;" |
| 2161 | "enum Enum {" |
| 2162 | " FOO = 0," |
| 2163 | " BAR = 1," |
| 2164 | "}"); |
| 2165 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2166 | } |
| 2167 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2168 | class AidlTestIncompatibleChanges : public AidlTest { |
| 2169 | protected: |
| 2170 | Options options_ = Options::From("aidl --checkapi old new"); |
| 2171 | }; |
| 2172 | |
| 2173 | TEST_F(AidlTestIncompatibleChanges, RemovedType) { |
Jiyong Park | 0cf03b1 | 2020-07-22 19:36:34 +0900 | [diff] [blame] | 2174 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2175 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2176 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2177 | "interface IFoo {" |
| 2178 | " void foo(in String[] str);" |
| 2179 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2180 | "}"); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2181 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2182 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2183 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2184 | } |
| 2185 | |
| 2186 | TEST_F(AidlTestIncompatibleChanges, RemovedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2187 | const string expected_stderr = |
| 2188 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2189 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2190 | "package p;" |
| 2191 | "interface IFoo {" |
| 2192 | " void foo(in String[] str);" |
| 2193 | " void bar(@utf8InCpp String str);" |
| 2194 | "}"); |
| 2195 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2196 | "package p;" |
| 2197 | "interface IFoo {" |
| 2198 | " void foo(in String[] str);" |
| 2199 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2200 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2201 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2202 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2203 | } |
| 2204 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2205 | TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) { |
| 2206 | const string expected_stderr = |
| 2207 | "ERROR: new/p/IFoo.aidl:1.61-65: " |
| 2208 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2209 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2210 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2211 | "ERROR: new/p/IFoo.aidl: Failed to read.\n"; |
| 2212 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2213 | "package p;" |
| 2214 | "interface IFoo {" |
| 2215 | " void foo(in String[] str);" |
| 2216 | "}"); |
| 2217 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2218 | "package p;" |
| 2219 | "interface IFoo {" |
| 2220 | " void foo(in String[] str);" |
| 2221 | " void bar(in List arg);" |
| 2222 | "}"); |
| 2223 | CaptureStderr(); |
| 2224 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2225 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2226 | } |
| 2227 | |
| 2228 | TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) { |
| 2229 | const string expected_stderr = |
| 2230 | "ERROR: new/p/Data.aidl:1.54-59: " |
| 2231 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2232 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2233 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2234 | "ERROR: new/p/Data.aidl: Failed to read.\n"; |
| 2235 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2236 | "package p;" |
| 2237 | "parcelable Data {" |
| 2238 | " int foo;" |
| 2239 | "}"); |
| 2240 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2241 | "package p;" |
| 2242 | "parcelable Data {" |
| 2243 | " int foo;" |
| 2244 | " @nullable List list;" |
| 2245 | "}"); |
| 2246 | CaptureStderr(); |
| 2247 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2248 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2249 | } |
| 2250 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2251 | TEST_F(AidlTestIncompatibleChanges, RemovedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2252 | const string expected_stderr = |
| 2253 | "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2254 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2255 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2256 | "parcelable Data {" |
| 2257 | " int foo;" |
| 2258 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2259 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2260 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2261 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2262 | "parcelable Data {" |
| 2263 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2264 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2265 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2266 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2267 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2268 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2269 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2270 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) { |
| 2271 | const string expected_stderr = |
| 2272 | "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some " |
| 2273 | "backends. Please either provide a default value for this field or mark the field as " |
| 2274 | "@nullable. This value or a null value will be used automatically when an old version of " |
| 2275 | "this parcelable is sent to a process which understands a new version of this parcelable. In " |
| 2276 | "order to make sure your code continues to be backwards compatible, make sure the default or " |
| 2277 | "null value does not cause a semantic change to this parcelable.\n"; |
| 2278 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2279 | "package p;" |
| 2280 | "parcelable Data {" |
| 2281 | " int num;" |
| 2282 | "}"); |
| 2283 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2284 | "package p;" |
| 2285 | "parcelable Data {" |
| 2286 | " int num;" |
| 2287 | " String str;" |
| 2288 | "}"); |
| 2289 | CaptureStderr(); |
| 2290 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2291 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2292 | } |
| 2293 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2294 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) { |
| 2295 | const string expected_stderr = |
| 2296 | "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. " |
| 2297 | "Please make sure 'Enum' has '0' as a valid value.\n"; |
| 2298 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2299 | "package p;" |
| 2300 | "parcelable Data {" |
| 2301 | " int num;" |
| 2302 | "}"); |
| 2303 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2304 | "package p;" |
| 2305 | "parcelable Data {" |
| 2306 | " int num;" |
| 2307 | " p.Enum e;" |
| 2308 | "}"); |
| 2309 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2310 | "package p;" |
| 2311 | "enum Enum {" |
| 2312 | " FOO = 1," |
| 2313 | " BAR = 2," |
| 2314 | "}"); |
| 2315 | CaptureStderr(); |
| 2316 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2317 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2318 | } |
| 2319 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2320 | TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2321 | const string expected_stderr = |
| 2322 | "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2323 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2324 | "package p;" |
| 2325 | "enum Enum {" |
| 2326 | " FOO = 1," |
| 2327 | " BAR = 2," |
| 2328 | "}"); |
| 2329 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2330 | "package p;" |
| 2331 | "enum Enum {" |
| 2332 | " BAR = 2," |
| 2333 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2334 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2335 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2336 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2337 | } |
| 2338 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2339 | TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) { |
| 2340 | const string expected_stderr = |
| 2341 | "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n"; |
| 2342 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2343 | "package p;" |
| 2344 | "union Union {" |
| 2345 | " String str;" |
| 2346 | " int num;" |
| 2347 | "}"); |
| 2348 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2349 | "package p;" |
| 2350 | "union Union {" |
| 2351 | " String str;" |
| 2352 | "}"); |
| 2353 | CaptureStderr(); |
| 2354 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2355 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2356 | } |
| 2357 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2358 | TEST_F(AidlTestIncompatibleChanges, RenamedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2359 | const string expected_stderr = |
| 2360 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2361 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2362 | "package p;" |
| 2363 | "interface IFoo {" |
| 2364 | " void foo(in String[] str);" |
| 2365 | " void bar(@utf8InCpp String str);" |
| 2366 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2367 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2368 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2369 | "interface IFoo {" |
| 2370 | " void foo(in String[] str);" |
| 2371 | " void bar2(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2372 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2373 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2374 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2375 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2376 | } |
| 2377 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2378 | TEST_F(AidlTestIncompatibleChanges, RenamedType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2379 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2380 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2381 | "package p;" |
| 2382 | "interface IFoo {" |
| 2383 | " void foo(in String[] str);" |
| 2384 | " void bar(@utf8InCpp String str);" |
| 2385 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2386 | io_delegate_.SetFileContents("new/p/IFoo2.aidl", |
| 2387 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2388 | "interface IFoo2 {" |
| 2389 | " void foo(in String[] str);" |
| 2390 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2391 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2392 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2393 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2394 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2395 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2396 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2397 | TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2398 | const string expected_stderr = |
| 2399 | "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2400 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2401 | "package p;" |
| 2402 | "enum Enum {" |
| 2403 | " FOO = 1," |
| 2404 | " BAR = 2," |
| 2405 | "}"); |
| 2406 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2407 | "package p;" |
| 2408 | "enum Enum {" |
| 2409 | " FOO = 3," |
| 2410 | " BAR = 2," |
| 2411 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2412 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2413 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2414 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2415 | } |
| 2416 | |
| 2417 | TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2418 | const string expected_stderr = |
| 2419 | "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed " |
| 2420 | "from 0 to 1.\n" |
| 2421 | "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from " |
| 2422 | "1 to 0.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2423 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2424 | "package p;" |
| 2425 | "interface IFoo {" |
| 2426 | " void foo(in String[] str);" |
| 2427 | " void bar(@utf8InCpp String str);" |
| 2428 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2429 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2430 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2431 | "interface IFoo {" |
| 2432 | " void bar(@utf8InCpp String str);" |
| 2433 | " void foo(in String[] str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2434 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2435 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2436 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2437 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2438 | } |
| 2439 | |
| 2440 | TEST_F(AidlTestIncompatibleChanges, ReorderedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2441 | const string expected_stderr = |
Jiyong Park | b07d993 | 2020-05-15 12:56:54 +0900 | [diff] [blame] | 2442 | "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n" |
| 2443 | "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2444 | io_delegate_.SetFileContents("old/p/Data.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2445 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2446 | "parcelable Data {" |
| 2447 | " int foo;" |
| 2448 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2449 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2450 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2451 | "package p;" |
| 2452 | "parcelable Data {" |
| 2453 | " int bar;" |
| 2454 | " int foo;" |
| 2455 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2456 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2457 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2458 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2459 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2460 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2461 | TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) { |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2462 | const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2463 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2464 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2465 | "interface IFoo {" |
| 2466 | " void foo(in String[] str);" |
| 2467 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2468 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2469 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2470 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2471 | "interface IFoo {" |
| 2472 | " void foo(out String[] str);" |
| 2473 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2474 | "}"); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2475 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2476 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2477 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2478 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2479 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2480 | TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2481 | const string expected_stderr = |
| 2482 | "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2483 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2484 | "package p;" |
| 2485 | "interface IFoo {" |
| 2486 | " void foo(in String[] str);" |
| 2487 | " void bar(@utf8InCpp String str);" |
| 2488 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2489 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2490 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2491 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2492 | " void foo(in @utf8InCpp String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2493 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2494 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2495 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2496 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2497 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2498 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2499 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2500 | TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2501 | const string expected_stderr = |
| 2502 | "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2503 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2504 | "package p;" |
| 2505 | "interface IFoo {" |
| 2506 | " void foo(in String[] str);" |
| 2507 | " void bar(@utf8InCpp String str);" |
| 2508 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2509 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2510 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2511 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2512 | " void foo(in String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2513 | " void bar(String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2514 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2515 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2516 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2517 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2518 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2519 | |
Jooyung Han | 60b2fde | 2020-10-29 15:12:40 +0900 | [diff] [blame] | 2520 | TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) { |
| 2521 | const string expected_stderr = |
| 2522 | "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n" |
| 2523 | "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n"; |
| 2524 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2525 | "package p;" |
| 2526 | "@Backing(type=\"byte\")" |
| 2527 | "enum Foo {" |
| 2528 | " FOO, BAR," |
| 2529 | "}"); |
| 2530 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2531 | "package p;" |
| 2532 | "@Backing(type=\"long\")" |
| 2533 | "enum Foo {" |
| 2534 | " FOO, BAR," |
| 2535 | "}"); |
| 2536 | CaptureStderr(); |
| 2537 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2538 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2539 | } |
| 2540 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2541 | TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) { |
| 2542 | const string expected_stderr = |
| 2543 | "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") " |
| 2544 | "to @JavaPassthrough(annotation=\"Bob\")\n"; |
| 2545 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2546 | "package p;" |
| 2547 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2548 | "parcelable Foo {}"); |
| 2549 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2550 | "package p;" |
| 2551 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2552 | "parcelable Foo {}"); |
| 2553 | |
| 2554 | CaptureStderr(); |
| 2555 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2556 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2557 | } |
| 2558 | |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2559 | TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) { |
| 2560 | const string expected_stderr = |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2561 | "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n"; |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2562 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2563 | "package p;" |
| 2564 | "parcelable Foo {" |
| 2565 | " int A;" |
| 2566 | "}"); |
| 2567 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2568 | "package p;" |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2569 | "@FixedSize parcelable Foo {" |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2570 | " int A;" |
| 2571 | "}"); |
| 2572 | CaptureStderr(); |
| 2573 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2574 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2575 | } |
| 2576 | |
| 2577 | TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) { |
| 2578 | const string expected_stderr = |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2579 | "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n"; |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2580 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2581 | "package p;" |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2582 | "@FixedSize parcelable Foo {" |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2583 | " int A;" |
| 2584 | "}"); |
| 2585 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2586 | "package p;" |
| 2587 | "parcelable Foo {" |
| 2588 | " int A;" |
| 2589 | "}"); |
| 2590 | CaptureStderr(); |
| 2591 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2592 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2593 | } |
| 2594 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2595 | TEST_F(AidlTestIncompatibleChanges, RemovedPackage) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2596 | const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2597 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}"); |
| 2598 | io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2599 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2600 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2601 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2602 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2603 | } |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 2604 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2605 | TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) { |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2606 | const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2607 | io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }"); |
| 2608 | io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2609 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2610 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2611 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2612 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2613 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2614 | TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2615 | const string expected_stderr = |
| 2616 | "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2617 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2618 | "package p; interface I {" |
| 2619 | "const int A = 1; const int B = 2;}"); |
| 2620 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2621 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2622 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2623 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2624 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2625 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2626 | TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2627 | const string expected_stderr = |
| 2628 | "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2629 | io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }"); |
| 2630 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2631 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2632 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2633 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3c35e39 | 2018-08-30 13:10:30 +0900 | [diff] [blame] | 2634 | } |
| 2635 | |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2636 | TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) { |
| 2637 | const string expected_stderr = |
| 2638 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. " |
| 2639 | "This is an incompatible change for FixedSize types.\n"; |
| 2640 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2641 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 2642 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2643 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }"); |
| 2644 | CaptureStderr(); |
| 2645 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2646 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2647 | } |
| 2648 | |
| 2649 | TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) { |
| 2650 | const string expected_stderr = |
| 2651 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n"; |
| 2652 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2653 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }"); |
| 2654 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2655 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 2656 | CaptureStderr(); |
| 2657 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2658 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2659 | } |
| 2660 | |
| 2661 | TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) { |
| 2662 | const string expected_stderr = |
| 2663 | "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2664 | "a.\n" |
| 2665 | "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2666 | "b.\n" |
| 2667 | "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2668 | "c.\n" |
| 2669 | "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2670 | "d.\n" |
| 2671 | "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2672 | "e.\n" |
| 2673 | "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2674 | "f.\n"; |
| 2675 | |
| 2676 | io_delegate_.SetFileContents("Foo.aidl", |
| 2677 | "@FixedSize parcelable Foo { " |
| 2678 | " int[] a;" |
| 2679 | " Bar b;" |
| 2680 | " String c;" |
| 2681 | " ParcelFileDescriptor d;" |
| 2682 | " IBinder e;" |
| 2683 | " List<String> f;" |
Steven Moreland | 265f3d4 | 2020-09-24 19:06:54 +0000 | [diff] [blame] | 2684 | " int isFixedSize;" |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2685 | "}"); |
| 2686 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 2687 | Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage())); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2688 | |
| 2689 | CaptureStderr(); |
| 2690 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2691 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2692 | } |
| 2693 | |
| 2694 | TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) { |
| 2695 | const string expected_stderr = ""; |
| 2696 | |
| 2697 | io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }"); |
| 2698 | io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }"); |
| 2699 | io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 2700 | Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage())); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2701 | |
| 2702 | CaptureStderr(); |
| 2703 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2704 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2705 | } |
| 2706 | |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2707 | TEST_F(AidlTest, RejectAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2708 | const string expected_stderr = |
| 2709 | "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n" |
| 2710 | "dir1/q/IBar.aidl\n" |
| 2711 | "dir2/q/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2712 | "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n"; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2713 | Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl"); |
| 2714 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}"); |
| 2715 | io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}"); |
| 2716 | io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}"); |
| 2717 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2718 | CaptureStderr(); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2719 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2720 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2721 | } |
| 2722 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2723 | TEST_F(AidlTest, HandleManualIdAssignments) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2724 | const string expected_stderr = |
| 2725 | "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to " |
| 2726 | "11.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2727 | Options options = Options::From("aidl --checkapi old new"); |
| 2728 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
| 2729 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2730 | |
| 2731 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2732 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2733 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2734 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2735 | EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2736 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2737 | } |
| 2738 | |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 2739 | TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) { |
| 2740 | Options options = |
| 2741 | Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl"); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2742 | |
| 2743 | // use without import |
| 2744 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2745 | "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}"); |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 2746 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2747 | |
| 2748 | // capture output files |
| 2749 | map<string, string> outputs = io_delegate_.OutputFiles(); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2750 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2751 | // use without import but with full name |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2752 | io_delegate_.SetFileContents( |
| 2753 | "p/IFoo.aidl", |
| 2754 | "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}"); |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 2755 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2756 | // output files should be the same |
| 2757 | EXPECT_EQ(outputs, io_delegate_.OutputFiles()); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2758 | |
| 2759 | // use with import (as before) |
| 2760 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2761 | "package p;" |
| 2762 | "import android.os.ParcelFileDescriptor;" |
| 2763 | "interface IFoo{" |
| 2764 | " void foo(in ParcelFileDescriptor fd);" |
| 2765 | "}"); |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 2766 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2767 | // output files should be the same |
| 2768 | EXPECT_EQ(outputs, io_delegate_.OutputFiles()); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2769 | } |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2770 | |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 2771 | TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) { |
| 2772 | Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage())); |
| 2773 | CaptureStderr(); |
| 2774 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2775 | "package p;" |
| 2776 | "interface IFoo{" |
| 2777 | " void foo(out ParcelFileDescriptor fd);" |
| 2778 | "}"); |
| 2779 | EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2780 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter")); |
| 2781 | } |
| 2782 | |
| 2783 | TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) { |
| 2784 | Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage())); |
| 2785 | CaptureStderr(); |
| 2786 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2787 | "package p;" |
| 2788 | "interface IFoo{" |
| 2789 | " void foo(ParcelFileDescriptor fd);" |
| 2790 | "}"); |
| 2791 | EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2792 | EXPECT_THAT(GetCapturedStderr(), |
| 2793 | HasSubstr("ParcelFileDescriptor can be an in or inout parameter.")); |
| 2794 | } |
| 2795 | |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2796 | TEST_F(AidlTest, ManualIds) { |
| 2797 | Options options = Options::From("aidl --lang=java -o out IFoo.aidl"); |
| 2798 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2799 | "interface IFoo {\n" |
| 2800 | " void foo() = 0;\n" |
| 2801 | " void bar() = 1;\n" |
| 2802 | "}"); |
| 2803 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2804 | } |
| 2805 | |
| 2806 | TEST_F(AidlTest, ManualIdsWithMetaTransactions) { |
| 2807 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2808 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2809 | "interface IFoo {\n" |
| 2810 | " void foo() = 0;\n" |
| 2811 | " void bar() = 1;\n" |
| 2812 | "}"); |
| 2813 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2814 | } |
| 2815 | |
| 2816 | TEST_F(AidlTest, FailOnDuplicatedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2817 | const string expected_stderr = |
| 2818 | "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2819 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2820 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2821 | "interface IFoo {\n" |
| 2822 | " void foo() = 3;\n" |
| 2823 | " void bar() = 3;\n" |
| 2824 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2825 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2826 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2827 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2828 | } |
| 2829 | |
| 2830 | TEST_F(AidlTest, FailOnOutOfRangeIds) { |
| 2831 | // 16777115 is kLastMetaMethodId + 1 |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2832 | const string expected_stderr = |
| 2833 | "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. " |
| 2834 | "Value for id must be between 0 and 16777114 inclusive.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2835 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2836 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2837 | "interface IFoo {\n" |
| 2838 | " void foo() = 3;\n" |
| 2839 | " void bar() = 16777115;\n" |
| 2840 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2841 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2842 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2843 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2844 | } |
| 2845 | |
| 2846 | TEST_F(AidlTest, FailOnPartiallyAssignedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2847 | const string expected_stderr = |
| 2848 | "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2849 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2850 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2851 | "interface IFoo {\n" |
| 2852 | " void foo() = 3;\n" |
| 2853 | " void bar();\n" |
| 2854 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2855 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2856 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2857 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2858 | } |
| 2859 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2860 | TEST_F(AidlTest, AllowDuplicatedImportPaths) { |
| 2861 | Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl"); |
| 2862 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 2863 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
| 2864 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2865 | } |
| 2866 | |
| 2867 | TEST_F(AidlTest, FailOnAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2868 | const string expected_stderr = |
| 2869 | "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n" |
| 2870 | "dir/IBar.aidl\n" |
| 2871 | "dir2/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2872 | "ERROR: IFoo.aidl: Couldn't find import for class IBar\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2873 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2874 | Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl"); |
| 2875 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 2876 | io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}"); |
| 2877 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2878 | CaptureStderr(); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2879 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2880 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2881 | } |
| 2882 | |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 2883 | TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) { |
| 2884 | io_delegate_.SetFileContents("a/b/IFoo.aidl", |
| 2885 | "package a.b;\n" |
| 2886 | "import a.b.IBar;\n" |
| 2887 | "import a.b.IQux;\n" |
| 2888 | "interface IFoo { IQux foo(); }\n"); |
| 2889 | io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }"); |
| 2890 | io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }"); |
| 2891 | |
| 2892 | Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include"); |
| 2893 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2894 | |
| 2895 | string output; |
| 2896 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output)); |
| 2897 | // IBar was imported but wasn't used. include is not expected. |
| 2898 | EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>"))); |
| 2899 | // IBar was imported and used. include is expected. |
| 2900 | EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>"))); |
| 2901 | } |
| 2902 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2903 | TEST_F(AidlTest, ParseJavaPassthroughAnnotation) { |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2904 | io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a; |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2905 | import a.MyEnum; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2906 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 2907 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2908 | interface IFoo { |
| 2909 | @JavaPassthrough(annotation="@com.android.Bob") |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2910 | void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y); |
Jiyong Park | 7c3b0e4 | 2020-08-04 16:08:32 +0900 | [diff] [blame] | 2911 | const @JavaPassthrough(annotation="@com.android.David") int A = 3; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2912 | })--"); |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2913 | // JavaPassthrough should work with other types as well (e.g. enum) |
| 2914 | io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a; |
| 2915 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 2916 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
| 2917 | @Backing(type="byte") |
| 2918 | enum MyEnum { |
| 2919 | a, b, c |
| 2920 | })--"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2921 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2922 | Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2923 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 2924 | |
| 2925 | string java_out; |
| 2926 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out)); |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2927 | // type-decl-level annotations with newline at the end |
| 2928 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 2929 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 2930 | // member-decl-level annotations with newline at the end |
| 2931 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n")); |
| 2932 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n")); |
| 2933 | // inline annotations with space at the end |
| 2934 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat ")); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2935 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2936 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out)); |
| 2937 | // type-decl-level annotations with newline at the end |
| 2938 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 2939 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 2940 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2941 | // Other backends shouldn't be bothered |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2942 | Options cpp_options = |
| 2943 | Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2944 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 2945 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2946 | Options ndk_options = |
| 2947 | Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2948 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2949 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2950 | Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2951 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2952 | } |
| 2953 | |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 2954 | TEST_F(AidlTest, ParseRustDerive) { |
| 2955 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 2956 | @RustDerive(Clone=true, Copy=false) |
| 2957 | parcelable Foo { |
| 2958 | int a; |
| 2959 | })"); |
| 2960 | |
| 2961 | Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl"); |
| 2962 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
| 2963 | |
| 2964 | string rust_out; |
| 2965 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out)); |
| 2966 | EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]")); |
| 2967 | |
| 2968 | // Other backends shouldn't be bothered |
| 2969 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
| 2970 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 2971 | |
| 2972 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
| 2973 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
| 2974 | |
| 2975 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 2976 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 2977 | } |
| 2978 | |
Jiyong Park | 56f73d7 | 2019-06-11 12:20:28 +0900 | [diff] [blame] | 2979 | class AidlOutputPathTest : public AidlTest { |
| 2980 | protected: |
| 2981 | void SetUp() override { |
| 2982 | AidlTest::SetUp(); |
| 2983 | io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}"); |
| 2984 | } |
| 2985 | |
| 2986 | void Test(const Options& options, const std::string expected_output_path) { |
| 2987 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2988 | // check the existence |
| 2989 | EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr)); |
| 2990 | } |
| 2991 | }; |
| 2992 | |
| 2993 | TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) { |
| 2994 | // <out_dir> / <package_name> / <type_name>.java |
| 2995 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java"); |
| 2996 | } |
| 2997 | |
| 2998 | TEST_F(AidlOutputPathTest, OutDirWithOutputFile) { |
| 2999 | // when output file is explicitly set, it is always respected. -o option is |
| 3000 | // ignored. |
| 3001 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 3002 | } |
| 3003 | |
| 3004 | TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) { |
| 3005 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 3006 | } |
| 3007 | |
| 3008 | TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) { |
| 3009 | // output is the same as the input file except for the suffix |
| 3010 | Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java"); |
| 3011 | } |
| 3012 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3013 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3014 | AidlError error; |
| 3015 | const string expected_stderr = |
| 3016 | "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n"; |
| 3017 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3018 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3019 | R"(package p; |
| 3020 | interface IFoo { |
| 3021 | const int int32_max_oob = 2147483650; |
| 3022 | } |
| 3023 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3024 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3025 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3026 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3027 | } |
| 3028 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3029 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3030 | AidlError error; |
| 3031 | const string expected_stderr = |
| 3032 | "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n"; |
| 3033 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3034 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3035 | R"(package p; |
| 3036 | interface IFoo { |
| 3037 | const int int32_min_oob = -2147483650; |
| 3038 | } |
| 3039 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3040 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3041 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3042 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3043 | } |
| 3044 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3045 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3046 | AidlError error; |
| 3047 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 3048 | "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3049 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3050 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3051 | R"(package p; |
| 3052 | interface IFoo { |
| 3053 | const long int64_max_oob = 21474836509999999999999999; |
| 3054 | } |
| 3055 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3056 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3057 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3058 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3059 | } |
| 3060 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3061 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3062 | AidlError error; |
| 3063 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 3064 | "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3065 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3066 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3067 | R"(package p; |
| 3068 | interface IFoo { |
| 3069 | const long int64_min_oob = -21474836509999999999999999; |
| 3070 | } |
| 3071 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3072 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3073 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3074 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3075 | } |
| 3076 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3077 | TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3078 | AidlError error; |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3079 | const string expected_stderr = |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 3080 | "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n" |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3081 | "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n"; |
| 3082 | CaptureStderr(); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 3083 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 3084 | R"(package p; |
| 3085 | @Backing(type="byte") |
| 3086 | enum TestEnum { |
| 3087 | FOO = 127, |
| 3088 | BAR, |
| 3089 | } |
| 3090 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3091 | typenames_, GetLanguage(), &error)); |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3092 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3093 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 3094 | } |
| 3095 | |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 3096 | TEST_P(AidlTest, UnsupportedBackingAnnotationParam) { |
| 3097 | AidlError error; |
| 3098 | const string expected_stderr = |
| 3099 | "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must " |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 3100 | "be one of: type\n"; |
| 3101 | CaptureStderr(); |
| 3102 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 3103 | R"(package p; |
| 3104 | @Backing(foo="byte") |
| 3105 | enum TestEnum { |
| 3106 | FOO = 1, |
| 3107 | BAR, |
| 3108 | } |
| 3109 | )", |
| 3110 | typenames_, GetLanguage(), &error)); |
| 3111 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3112 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 3113 | } |
| 3114 | |
Jooyung Han | 5721a23 | 2020-12-24 04:34:55 +0900 | [diff] [blame] | 3115 | TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) { |
| 3116 | const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n"; |
| 3117 | CaptureStderr(); |
| 3118 | EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage())); |
| 3119 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3120 | } |
| 3121 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3122 | TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3123 | io_delegate_.SetFileContents("Foo.aidl", |
| 3124 | "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; " |
| 3125 | "Map<String, Baz> d; Bar[] e; }"); |
| 3126 | io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }"); |
| 3127 | io_delegate_.SetFileContents("Baz.aidl", |
| 3128 | "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3129 | Options options = Options::From("aidl --lang=java -I . Foo.aidl"); |
| 3130 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3131 | } |
| 3132 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3133 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3134 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3135 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3136 | string expected_error = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3137 | "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
| 3138 | "named 'bar'.\n"; |
| 3139 | CaptureStderr(); |
| 3140 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
| 3141 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3142 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
| 3143 | } |
| 3144 | |
| 3145 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) { |
| 3146 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }"); |
| 3147 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
| 3148 | string expected_error = |
| 3149 | "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3150 | "named 'bar'.\n"; |
| 3151 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3152 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
| 3153 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3154 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3155 | } |
| 3156 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3157 | TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3158 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3159 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }"); |
| 3160 | string expected_error = |
| 3161 | "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can " |
| 3162 | "only be an in parameter.\n"; |
| 3163 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3164 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
| 3165 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3166 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3167 | } |
| 3168 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3169 | TEST_F(AidlTest, ImmutableParcelableCannotBeOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3170 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3171 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }"); |
| 3172 | string expected_error = |
| 3173 | "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can " |
| 3174 | "only be an in parameter.\n"; |
| 3175 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3176 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
| 3177 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3178 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3179 | } |
| 3180 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3181 | TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3182 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }"); |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3183 | Options options = Options::From("aidl --lang=java Foo.aidl"); |
| 3184 | const string expected_stderr = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3185 | "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first " |
| 3186 | "letter\n"; |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3187 | CaptureStderr(); |
| 3188 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3189 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3190 | } |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3191 | |
Jooyung Han | fe086af | 2021-01-16 03:44:47 +0900 | [diff] [blame] | 3192 | TEST_P(AidlTest, UnionInUnion) { |
| 3193 | import_paths_.insert("."); |
| 3194 | io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }"); |
| 3195 | CaptureStderr(); |
| 3196 | EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage())); |
| 3197 | EXPECT_THAT("", GetCapturedStderr()); |
| 3198 | } |
| 3199 | |
Jooyung Han | fe89f12 | 2020-10-14 03:49:18 +0900 | [diff] [blame] | 3200 | TEST_P(AidlTest, UnionRejectsEmptyDecl) { |
| 3201 | const string method = "package a; union Foo {}"; |
| 3202 | const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n"; |
| 3203 | CaptureStderr(); |
| 3204 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3205 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3206 | } |
| 3207 | |
| 3208 | TEST_P(AidlTest, UnionRejectsParcelableHolder) { |
| 3209 | const string method = "package a; union Foo { ParcelableHolder x; }"; |
| 3210 | const string expected_stderr = |
| 3211 | "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n"; |
| 3212 | CaptureStderr(); |
| 3213 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3214 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3215 | } |
| 3216 | |
Jooyung Han | 53fb424 | 2020-12-17 16:03:49 +0900 | [diff] [blame] | 3217 | TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) { |
| 3218 | import_paths_.insert("."); |
| 3219 | io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }"); |
| 3220 | const string expected_err = "The union's first member should have a useful default value."; |
| 3221 | CaptureStderr(); |
| 3222 | EXPECT_EQ(nullptr, |
| 3223 | Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage())); |
| 3224 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err)); |
| 3225 | } |
| 3226 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3227 | TEST_P(AidlTest, GenericStructuredParcelable) { |
| 3228 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3229 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3230 | const string expected_stderr = ""; |
| 3231 | CaptureStderr(); |
| 3232 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3233 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3234 | } |
| 3235 | |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3236 | TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) { |
| 3237 | io_delegate_.SetFileContents("Foo.aidl", |
| 3238 | "parcelable Foo<T, U> { int a; const String s = \"\"; }"); |
| 3239 | Options options = |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3240 | Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out"); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3241 | const string expected_stderr = ""; |
| 3242 | CaptureStderr(); |
| 3243 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3244 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3245 | |
| 3246 | string code; |
| 3247 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 3248 | EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U> |
| 3249 | const ::android::String16& Foo<T,U>::s() { |
| 3250 | static const ::android::String16 value(::android::String16("")); |
| 3251 | return value; |
| 3252 | })--")); |
| 3253 | } |
| 3254 | |
| 3255 | TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) { |
| 3256 | io_delegate_.SetFileContents("Foo.aidl", |
| 3257 | "parcelable Foo<T, U> { int a; const String s = \"\"; }"); |
| 3258 | Options options = |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3259 | Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out"); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3260 | const string expected_stderr = ""; |
| 3261 | CaptureStderr(); |
| 3262 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3263 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3264 | |
| 3265 | string code; |
| 3266 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 3267 | EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U> |
| 3268 | const char* Foo<T, U>::s = ""; |
| 3269 | )--")); |
| 3270 | } |
| 3271 | |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3272 | TEST_F(AidlTest, NestedTypeArgs) { |
| 3273 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }"); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3274 | io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }"); |
| 3275 | |
| 3276 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 3277 | "package a; import a.Bar; import a.Baz; parcelable Foo { " |
| 3278 | "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }"); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3279 | Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java"); |
| 3280 | const string expected_stderr = ""; |
| 3281 | CaptureStderr(); |
| 3282 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3283 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3284 | |
| 3285 | string code; |
| 3286 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3287 | EXPECT_THAT(code, |
| 3288 | testing::HasSubstr( |
| 3289 | "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;")); |
| 3290 | } |
| 3291 | |
| 3292 | TEST_F(AidlTest, DoubleArrayError) { |
| 3293 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }"); |
| 3294 | |
| 3295 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3296 | const string expected_stderr = |
| 3297 | "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n"; |
| 3298 | CaptureStderr(); |
| 3299 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3300 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3301 | } |
| 3302 | |
| 3303 | TEST_F(AidlTest, DoubleGenericError) { |
| 3304 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3305 | "package a; parcelable Bar { List<String><String> a; }"); |
| 3306 | |
| 3307 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3308 | const string expected_stderr = |
| 3309 | "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n"; |
| 3310 | CaptureStderr(); |
| 3311 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3312 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3313 | } |
| 3314 | |
| 3315 | TEST_F(AidlTest, ArrayBeforeGenericError) { |
| 3316 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }"); |
| 3317 | |
| 3318 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3319 | CaptureStderr(); |
| 3320 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 97c324a | 2021-02-15 16:09:51 +0900 | [diff] [blame] | 3321 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'")); |
| 3322 | } |
| 3323 | |
| 3324 | TEST_F(AidlTest, NullableArraysAreNotSupported) { |
| 3325 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3326 | "package a; parcelable Bar { String @nullable [] a; }"); |
| 3327 | |
| 3328 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3329 | CaptureStderr(); |
| 3330 | EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3331 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported.")); |
| 3332 | } |
| 3333 | |
| 3334 | TEST_F(AidlTest, ListOfNullablesAreNotSupported) { |
| 3335 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3336 | "package a; parcelable Bar { List<@nullable String> a; }"); |
| 3337 | |
| 3338 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3339 | CaptureStderr(); |
| 3340 | EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3341 | EXPECT_THAT(GetCapturedStderr(), |
| 3342 | testing::HasSubstr("Annotations for type arguments are not supported.")); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3343 | } |
| 3344 | |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3345 | struct GenericAidlTest : ::testing::Test { |
| 3346 | FakeIoDelegate io_delegate_; |
| 3347 | void Compile(string cmd) { |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3348 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }"); |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3349 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }"); |
| 3350 | io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }"); |
| 3351 | io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }"); |
| 3352 | |
| 3353 | Options options = Options::From(cmd); |
| 3354 | CaptureStderr(); |
| 3355 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3356 | EXPECT_EQ("", GetCapturedStderr()); |
| 3357 | } |
| 3358 | }; |
| 3359 | |
| 3360 | TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) { |
| 3361 | Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out"); |
| 3362 | string code; |
| 3363 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 3364 | EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>")); |
| 3365 | EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>")); |
| 3366 | EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>")); |
| 3367 | } |
| 3368 | |
| 3369 | TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) { |
| 3370 | Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out"); |
| 3371 | string code; |
| 3372 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 3373 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>")); |
| 3374 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>")); |
| 3375 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>")); |
| 3376 | } |
| 3377 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3378 | TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) { |
| 3379 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3380 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3381 | const string expected_stderr = |
| 3382 | "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n"; |
| 3383 | CaptureStderr(); |
| 3384 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3385 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3386 | } |
| 3387 | |
| 3388 | TEST_P(AidlTest, RejectGenericStructuredParcelableField) { |
| 3389 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3390 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3391 | const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n"; |
| 3392 | CaptureStderr(); |
| 3393 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3394 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3395 | } |
| 3396 | |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 3397 | TEST_P(AidlTest, LongCommentWithinConstExpression) { |
| 3398 | io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3399 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 3400 | CaptureStderr(); |
| 3401 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3402 | EXPECT_EQ("", GetCapturedStderr()); |
| 3403 | } |
| 3404 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3405 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) { |
| 3406 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }"); |
| 3407 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
| 3408 | std::string expectedErr = |
| 3409 | "ERROR: a/Foo.aidl:1.28-30: " |
| 3410 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3411 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3412 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3413 | "ERROR: a/Foo.aidl:1.35-37: " |
| 3414 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3415 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3416 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 3417 | CaptureStderr(); |
| 3418 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3419 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 3420 | } |
| 3421 | |
| 3422 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) { |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3423 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }"); |
| 3424 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3425 | std::string expectedErr = |
| 3426 | "ERROR: a/Foo.aidl:1.33-35: " |
| 3427 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3428 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3429 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3430 | "ERROR: a/Foo.aidl:1.40-42: " |
| 3431 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3432 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3433 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3434 | CaptureStderr(); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3435 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3436 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 3437 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3438 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3439 | TEST_F(AidlTest, RejectNestedUntypedListAndMap) { |
| 3440 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;"); |
| 3441 | io_delegate_.SetFileContents( |
| 3442 | "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }"); |
| 3443 | Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out"); |
| 3444 | std::string expectedErr = |
| 3445 | "ERROR: a/Foo.aidl:1.52-54: " |
| 3446 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3447 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3448 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3449 | "ERROR: a/Foo.aidl:1.64-66: " |
| 3450 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3451 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3452 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 3453 | CaptureStderr(); |
| 3454 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3455 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3456 | } |
| 3457 | |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3458 | TEST_F(AidlTest, EnumWithDefaults_Java) { |
| 3459 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3460 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3461 | package p; |
| 3462 | import p.Enum; |
| 3463 | parcelable Foo { |
| 3464 | Enum e = Enum.BAR; |
| 3465 | })"); |
| 3466 | CaptureStderr(); |
| 3467 | auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl"); |
| 3468 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3469 | auto err = GetCapturedStderr(); |
| 3470 | EXPECT_EQ("", err); |
| 3471 | |
| 3472 | string code; |
| 3473 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code)); |
Jooyung Han | 2d83361 | 2020-12-17 15:59:27 +0900 | [diff] [blame] | 3474 | EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR")); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3475 | } |
| 3476 | |
| 3477 | TEST_F(AidlTest, EnumWithDefaults_Cpp) { |
| 3478 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3479 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3480 | package p; |
| 3481 | import p.Enum; |
| 3482 | parcelable Foo { |
| 3483 | Enum e = Enum.BAR; |
| 3484 | })"); |
| 3485 | CaptureStderr(); |
| 3486 | auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl"); |
| 3487 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3488 | auto err = GetCapturedStderr(); |
| 3489 | EXPECT_EQ("", err); |
| 3490 | |
| 3491 | string code; |
| 3492 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code)); |
| 3493 | EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);")); |
| 3494 | } |
| 3495 | |
| 3496 | TEST_F(AidlTest, EnumWithDefaults_Ndk) { |
| 3497 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3498 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3499 | package p; |
| 3500 | import p.Enum; |
| 3501 | parcelable Foo { |
| 3502 | Enum e = Enum.BAR; |
| 3503 | })"); |
| 3504 | CaptureStderr(); |
| 3505 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 3506 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3507 | auto err = GetCapturedStderr(); |
| 3508 | EXPECT_EQ("", err); |
| 3509 | |
| 3510 | string code; |
| 3511 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code)); |
| 3512 | EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;")); |
| 3513 | } |
| 3514 | |
| 3515 | TEST_F(AidlTest, EnumWithDefaults_Rust) { |
| 3516 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3517 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3518 | package p; |
| 3519 | import p.Enum; |
| 3520 | parcelable Foo { |
| 3521 | int n = 42; |
| 3522 | Enum e = Enum.BAR; |
| 3523 | })"); |
| 3524 | CaptureStderr(); |
| 3525 | auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl"); |
| 3526 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3527 | auto err = GetCapturedStderr(); |
| 3528 | EXPECT_EQ("", err); |
| 3529 | |
| 3530 | string code; |
| 3531 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code)); |
| 3532 | EXPECT_THAT(code, testing::HasSubstr(R"( |
| 3533 | fn default() -> Self { |
| 3534 | Self { |
| 3535 | n: 42, |
| 3536 | e: crate::mangled::_1_p_4_Enum::BAR, |
| 3537 | } |
| 3538 | })")); |
| 3539 | } |
| 3540 | |
| 3541 | TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) { |
| 3542 | import_paths_.insert("a"); |
| 3543 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 3544 | CaptureStderr(); |
| 3545 | const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"( |
| 3546 | package p; |
| 3547 | import p.Enum; |
| 3548 | parcelable Foo { |
| 3549 | int e = Enum.FOO | Enum.BAR; |
| 3550 | })", |
| 3551 | typenames_, GetLanguage()); |
| 3552 | auto err = GetCapturedStderr(); |
| 3553 | EXPECT_EQ("", err); |
| 3554 | EXPECT_TRUE(type); |
| 3555 | const auto& fields = type->AsStructuredParcelable()->GetFields(); |
| 3556 | EXPECT_EQ("int e = 3", fields[0]->ToString()); |
| 3557 | } |
| 3558 | |
| 3559 | TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) { |
| 3560 | CaptureStderr(); |
| 3561 | const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"( |
| 3562 | @Backing(type="int") |
| 3563 | enum Foo { |
| 3564 | STANDARD_SHIFT = 16, |
| 3565 | STANDARD_BT709 = 1 << STANDARD_SHIFT, |
| 3566 | STANDARD_BT601_625 = 2 << STANDARD_SHIFT, |
| 3567 | } |
| 3568 | )", |
| 3569 | typenames_, GetLanguage()); |
| 3570 | auto err = GetCapturedStderr(); |
| 3571 | EXPECT_EQ("", err); |
| 3572 | EXPECT_TRUE(type); |
| 3573 | const auto& enum_type = type->AsEnumDeclaration(); |
| 3574 | string code; |
Jooyung Han | 1f56b70 | 2021-02-11 13:16:15 +0900 | [diff] [blame] | 3575 | auto writer = CodeWriter::ForString(&code); |
| 3576 | DumpVisitor visitor(*writer); |
| 3577 | visitor.Visit(*enum_type); |
| 3578 | writer->Close(); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3579 | EXPECT_EQ(R"--(@Backing(type="int") |
| 3580 | enum Foo { |
| 3581 | STANDARD_SHIFT = 16, |
| 3582 | STANDARD_BT709 = 65536, |
| 3583 | STANDARD_BT601_625 = 131072, |
| 3584 | } |
| 3585 | )--", |
| 3586 | code); |
| 3587 | } |
| 3588 | |
| 3589 | TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) { |
| 3590 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 3591 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3592 | package p; |
| 3593 | import p.Enum; |
| 3594 | parcelable Foo { |
| 3595 | Enum e = Enum.FOO | Enum.BAR; |
| 3596 | })"); |
| 3597 | CaptureStderr(); |
| 3598 | auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl"); |
| 3599 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3600 | auto err = GetCapturedStderr(); |
| 3601 | EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n", |
| 3602 | err); |
| 3603 | } |
| 3604 | |
| 3605 | TEST_P(AidlTest, DefaultWithEmptyArray) { |
| 3606 | io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }"); |
| 3607 | io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }"); |
| 3608 | CaptureStderr(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3609 | auto options = |
| 3610 | Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl"); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3611 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3612 | auto err = GetCapturedStderr(); |
| 3613 | EXPECT_EQ("", err); |
| 3614 | } |
| 3615 | |
| 3616 | TEST_P(AidlTest, RejectRefsInAnnotation) { |
| 3617 | io_delegate_.SetFileContents("a/p/IFoo.aidl", |
| 3618 | "package p; interface IFoo {\n" |
| 3619 | " const String ANNOTATION = \"@Annotation\";\n" |
| 3620 | " @JavaPassthrough(annotation=ANNOTATION) void foo();\n" |
| 3621 | "}"); |
| 3622 | CaptureStderr(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3623 | auto options = |
| 3624 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl"); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3625 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3626 | auto err = GetCapturedStderr(); |
| 3627 | EXPECT_EQ( |
| 3628 | "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to " |
| 3629 | "ANNOTATION.\n", |
| 3630 | err); |
| 3631 | } |
| 3632 | |
| 3633 | TEST_F(AidlTest, DefaultWithEnumValues) { |
| 3634 | io_delegate_.SetFileContents( |
| 3635 | "a/p/Foo.aidl", |
| 3636 | "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }"); |
| 3637 | io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }"); |
| 3638 | CaptureStderr(); |
| 3639 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 3640 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3641 | auto err = GetCapturedStderr(); |
| 3642 | EXPECT_EQ("", err); |
| 3643 | string code; |
| 3644 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code)); |
| 3645 | EXPECT_THAT( |
| 3646 | code, testing::HasSubstr( |
| 3647 | "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};")); |
| 3648 | } |
| 3649 | |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 3650 | TEST_F(AidlTest, RejectsCircularReferencingEnumerators) { |
| 3651 | io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }"); |
| 3652 | CaptureStderr(); |
| 3653 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 3654 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3655 | auto err = GetCapturedStderr(); |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 3656 | EXPECT_EQ( |
| 3657 | "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n" |
| 3658 | "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n", |
| 3659 | err); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 3660 | } |
| 3661 | |
| 3662 | TEST_F(AidlTest, RejectsCircularReferencingConsts) { |
| 3663 | io_delegate_.SetFileContents("a/p/Foo.aidl", |
| 3664 | "package p; parcelable Foo { const int A = A + 1; }"); |
| 3665 | CaptureStderr(); |
| 3666 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 3667 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3668 | auto err = GetCapturedStderr(); |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 3669 | EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err); |
| 3670 | } |
| 3671 | |
| 3672 | TEST_F(AidlTest, RecursiveReferences) { |
| 3673 | io_delegate_.SetFileContents("a/p/Foo.aidl", |
| 3674 | "package p; parcelable Foo { const int A = p.Bar.A + 1; }"); |
| 3675 | io_delegate_.SetFileContents("a/p/Bar.aidl", |
| 3676 | "package p; parcelable Bar { const int A = p.Baz.A + 1; }"); |
| 3677 | io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }"); |
| 3678 | CaptureStderr(); |
| 3679 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 3680 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 3681 | EXPECT_EQ("", GetCapturedStderr()); |
| 3682 | } |
| 3683 | |
Jooyung Han | e9f5b27 | 2021-01-07 00:18:11 +0900 | [diff] [blame] | 3684 | TEST_P(AidlTest, UnknownConstReference) { |
| 3685 | io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }"); |
| 3686 | auto options = |
| 3687 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl"); |
| 3688 | const string err = |
| 3689 | "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n" |
| 3690 | "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n" |
| 3691 | "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n"; |
| 3692 | CaptureStderr(); |
| 3693 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3694 | EXPECT_EQ(err, GetCapturedStderr()); |
| 3695 | } |
| 3696 | |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 3697 | TEST_P(AidlTest, JavaCompatibleBuiltinTypes) { |
| 3698 | string contents = R"( |
| 3699 | import android.os.IBinder; |
| 3700 | import android.os.IInterface; |
| 3701 | interface IFoo {} |
| 3702 | )"; |
| 3703 | EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage())); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 3704 | } |
| 3705 | |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 3706 | TEST_P(AidlTest, WarningInterfaceName) { |
| 3707 | io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3708 | auto options = Options::From("aidl --lang " + to_string(GetLanguage()) + |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 3709 | " -Weverything -o out -h out p/Foo.aidl"); |
| 3710 | CaptureStderr(); |
| 3711 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 808a2a0 | 2020-12-28 16:46:54 +0900 | [diff] [blame] | 3712 | EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n", |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 3713 | GetCapturedStderr()); |
| 3714 | } |
| 3715 | |
| 3716 | TEST_P(AidlTest, ErrorInterfaceName) { |
| 3717 | io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3718 | auto options = Options::From("aidl --lang " + to_string(GetLanguage()) + |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 3719 | " -Weverything -Werror -o out -h out p/Foo.aidl"); |
| 3720 | CaptureStderr(); |
| 3721 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 808a2a0 | 2020-12-28 16:46:54 +0900 | [diff] [blame] | 3722 | EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n", |
Jooyung Han | 3b99018 | 2020-12-22 17:44:31 +0900 | [diff] [blame] | 3723 | GetCapturedStderr()); |
| 3724 | } |
| 3725 | |
Jooyung Han | b7a60ec | 2021-01-21 13:47:59 +0900 | [diff] [blame] | 3726 | TEST_F(AidlTest, FormatCommentsForJava) { |
| 3727 | using android::aidl::FormatCommentsForJava; |
| 3728 | |
| 3729 | struct TestCase { |
| 3730 | vector<Comment> comments; |
| 3731 | string formatted; |
| 3732 | }; |
| 3733 | vector<TestCase> testcases = { |
| 3734 | {{}, ""}, |
| 3735 | {{{"// line comments\n"}}, "// line comments\n"}, |
| 3736 | {{{"// @hide \n"}}, "// @hide \n"}, |
| 3737 | // Transform the last block comment as Javadoc. |
| 3738 | {{{"/*\n" |
| 3739 | " * Hello, world!\n" |
| 3740 | " */"}}, |
| 3741 | "/**\n" |
| 3742 | " * Hello, world!\n" |
| 3743 | " */"}, |
| 3744 | {{{"/* @hide */"}}, "/** @hide */"}, |
| 3745 | {{{"/**\n" |
| 3746 | " @param foo ...\n" |
| 3747 | "*/"}}, |
| 3748 | "/**\n" |
| 3749 | " @param foo ...\n" |
| 3750 | "*/"}, |
| 3751 | {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"}, |
| 3752 | {{{"/* @deprecated first */"}, {"/* @deprecated second */"}}, |
| 3753 | "/* @deprecated first *//** @deprecated second */"}, |
| 3754 | {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"}, |
| 3755 | // Line comments are printed as they are |
| 3756 | {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"}, |
| 3757 | }; |
| 3758 | for (const auto& [input, formatted] : testcases) { |
| 3759 | EXPECT_EQ(formatted, FormatCommentsForJava(input)); |
| 3760 | } |
| 3761 | } |
| 3762 | |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 3763 | TEST_F(AidlTest, HideIsNotForArgs) { |
| 3764 | io_delegate_.SetFileContents("IFoo.aidl", |
| 3765 | "interface IFoo {\n" |
| 3766 | " void foo(in @Hide int x);\n" |
| 3767 | "}"); |
| 3768 | auto options = Options::From("aidl --lang=java IFoo.aidl"); |
| 3769 | CaptureStderr(); |
| 3770 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3771 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available")); |
| 3772 | } |
| 3773 | |
| 3774 | TEST_F(AidlTest, SuppressWarningsIsNotForArgs) { |
| 3775 | io_delegate_.SetFileContents( |
| 3776 | "IFoo.aidl", |
| 3777 | "interface IFoo {\n" |
| 3778 | " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n" |
| 3779 | "}"); |
| 3780 | auto options = Options::From("aidl --lang=java IFoo.aidl"); |
| 3781 | CaptureStderr(); |
| 3782 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 3783 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available")); |
| 3784 | } |
| 3785 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3786 | struct TypeParam { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3787 | string kind; |
| 3788 | string literal; |
| 3789 | }; |
| 3790 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3791 | const TypeParam kTypeParams[] = { |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 3792 | {"primitive", "int"}, {"primitiveArray", "int[]"}, |
| 3793 | {"String", "String"}, {"StringArray", "String[]"}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3794 | {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"}, |
| 3795 | {"parcelable", "Foo"}, {"enum", "a.Enum"}, |
| 3796 | {"union", "a.Union"}, {"interface", "a.IBar"}, |
| 3797 | }; |
| 3798 | |
| 3799 | const std::map<std::string, std::string> kListSupportExpectations = { |
| 3800 | {"cpp_primitive", "A generic type cannot have any primitive type parameters."}, |
| 3801 | {"java_primitive", "A generic type cannot have any primitive type parameters."}, |
| 3802 | {"ndk_primitive", "A generic type cannot have any primitive type parameters."}, |
| 3803 | {"rust_primitive", "A generic type cannot have any primitive type parameters."}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 3804 | {"cpp_primitiveArray", "List of arrays is not supported."}, |
| 3805 | {"java_primitiveArray", "List of arrays is not supported."}, |
| 3806 | {"ndk_primitiveArray", "List of arrays is not supported."}, |
| 3807 | {"rust_primitiveArray", "List of arrays is not supported."}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3808 | {"cpp_String", ""}, |
| 3809 | {"java_String", ""}, |
| 3810 | {"ndk_String", ""}, |
| 3811 | {"rust_String", ""}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 3812 | {"cpp_StringArray", "List of arrays is not supported."}, |
| 3813 | {"java_StringArray", "List of arrays is not supported."}, |
| 3814 | {"ndk_StringArray", "List of arrays is not supported."}, |
| 3815 | {"rust_StringArray", "List of arrays is not supported."}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3816 | {"cpp_IBinder", ""}, |
| 3817 | {"java_IBinder", ""}, |
| 3818 | {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."}, |
| 3819 | {"rust_IBinder", ""}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 3820 | {"cpp_ParcelFileDescriptor", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3821 | {"java_ParcelFileDescriptor", ""}, |
| 3822 | {"ndk_ParcelFileDescriptor", ""}, |
| 3823 | {"rust_ParcelFileDescriptor", ""}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 3824 | {"cpp_interface", "List<a.IBar> is not supported."}, |
| 3825 | {"java_interface", "List<a.IBar> is not supported."}, |
| 3826 | {"ndk_interface", "List<a.IBar> is not supported."}, |
| 3827 | {"rust_interface", "List<a.IBar> is not supported."}, |
| 3828 | {"cpp_parcelable", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3829 | {"java_parcelable", ""}, |
| 3830 | {"ndk_parcelable", ""}, |
| 3831 | {"rust_parcelable", ""}, |
| 3832 | {"cpp_enum", "A generic type cannot have any primitive type parameters."}, |
| 3833 | {"java_enum", "A generic type cannot have any primitive type parameters."}, |
| 3834 | {"ndk_enum", "A generic type cannot have any primitive type parameters."}, |
| 3835 | {"rust_enum", "A generic type cannot have any primitive type parameters."}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 3836 | {"cpp_union", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3837 | {"java_union", ""}, |
| 3838 | {"ndk_union", ""}, |
| 3839 | {"rust_union", ""}, |
| 3840 | }; |
| 3841 | |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 3842 | const std::map<std::string, std::string> kArraySupportExpectations = { |
| 3843 | {"cpp_primitive", ""}, |
| 3844 | {"java_primitive", ""}, |
| 3845 | {"ndk_primitive", ""}, |
| 3846 | {"rust_primitive", ""}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 3847 | {"cpp_primitiveArray", "Can only have one dimensional arrays."}, |
| 3848 | {"java_primitiveArray", "Can only have one dimensional arrays."}, |
| 3849 | {"ndk_primitiveArray", "Can only have one dimensional arrays."}, |
| 3850 | {"rust_primitiveArray", "Can only have one dimensional arrays."}, |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 3851 | {"cpp_String", ""}, |
| 3852 | {"java_String", ""}, |
| 3853 | {"ndk_String", ""}, |
| 3854 | {"rust_String", ""}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 3855 | {"cpp_StringArray", "Can only have one dimensional arrays."}, |
| 3856 | {"java_StringArray", "Can only have one dimensional arrays."}, |
| 3857 | {"ndk_StringArray", "Can only have one dimensional arrays."}, |
| 3858 | {"rust_StringArray", "Can only have one dimensional arrays."}, |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 3859 | {"cpp_IBinder", ""}, |
| 3860 | {"java_IBinder", ""}, |
| 3861 | {"ndk_IBinder", "The ndk backend does not support array of IBinder"}, |
| 3862 | {"rust_IBinder", "The rust backend does not support array of IBinder"}, |
| 3863 | {"cpp_ParcelFileDescriptor", ""}, |
| 3864 | {"java_ParcelFileDescriptor", ""}, |
| 3865 | {"ndk_ParcelFileDescriptor", ""}, |
| 3866 | {"rust_ParcelFileDescriptor", ""}, |
| 3867 | {"cpp_interface", "Binder type cannot be an array"}, |
| 3868 | {"java_interface", "Binder type cannot be an array"}, |
| 3869 | {"ndk_interface", "Binder type cannot be an array"}, |
| 3870 | {"rust_interface", "Binder type cannot be an array"}, |
| 3871 | {"cpp_parcelable", ""}, |
| 3872 | {"java_parcelable", ""}, |
| 3873 | {"ndk_parcelable", ""}, |
| 3874 | {"rust_parcelable", ""}, |
| 3875 | {"cpp_enum", ""}, |
| 3876 | {"java_enum", ""}, |
| 3877 | {"ndk_enum", ""}, |
| 3878 | {"rust_enum", ""}, |
| 3879 | {"cpp_union", ""}, |
| 3880 | {"java_union", ""}, |
| 3881 | {"ndk_union", ""}, |
| 3882 | {"rust_union", ""}, |
| 3883 | }; |
| 3884 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3885 | class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3886 | public: |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3887 | void Run(const std::string& generic_type_decl, |
| 3888 | const std::map<std::string, std::string>& expectations) { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3889 | const auto& param = GetParam(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3890 | const auto& lang = to_string(std::get<0>(param)); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3891 | const auto& kind = std::get<1>(param).kind; |
| 3892 | |
| 3893 | FakeIoDelegate io; |
| 3894 | io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }"); |
| 3895 | io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }"); |
| 3896 | io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }"); |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3897 | std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal); |
| 3898 | io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }"); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3899 | |
| 3900 | const auto options = |
| 3901 | Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang)); |
| 3902 | CaptureStderr(); |
| 3903 | compile_aidl(options, io); |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3904 | auto it = expectations.find(lang + "_" + kind); |
| 3905 | EXPECT_TRUE(it != expectations.end()); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3906 | const string err = GetCapturedStderr(); |
| 3907 | if (it->second.empty()) { |
| 3908 | EXPECT_EQ("", err); |
| 3909 | } else { |
| 3910 | EXPECT_THAT(err, testing::HasSubstr(it->second)); |
| 3911 | } |
| 3912 | } |
| 3913 | }; |
| 3914 | |
| 3915 | INSTANTIATE_TEST_SUITE_P( |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3916 | AidlTestSuite, AidlTypeParamTest, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3917 | testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA, |
| 3918 | Options::Language::NDK, Options::Language::RUST), |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3919 | testing::ValuesIn(kTypeParams)), |
| 3920 | [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) { |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3921 | return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind; |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3922 | }); |
| 3923 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 3924 | TEST_P(AidlTypeParamTest, ListSupportedTypes) { |
| 3925 | Run("List<{}>", kListSupportExpectations); |
| 3926 | } |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 3927 | |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 3928 | TEST_P(AidlTypeParamTest, ArraySupportedTypes) { |
| 3929 | Run("{}[]", kArraySupportExpectations); |
| 3930 | } |
| 3931 | |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 3932 | } // namespace aidl |
| 3933 | } // namespace android |