blob: ab01940ea1e09258b620bdd36f6135791208f90a [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
1477TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1478 io_delegate_.SetFileContents("p/IOuter.aidl",
1479 "package p;\n"
1480 "interface IOuter {\n"
1481 " parcelable Inner {}\n"
1482 "}");
1483 import_paths_.emplace("");
1484 const string input_path = "p/IFoo.aidl";
1485 const string input =
1486 "package p;\n"
1487 "interface IFoo {\n"
1488 " p.IOuter.Inner get();\n"
1489 "}";
1490 CaptureStderr();
1491 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1492 EXPECT_EQ(GetCapturedStderr(), "");
1493
1494 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1495}
1496
1497TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1498 io_delegate_.SetFileContents("p/IOuter.aidl",
1499 "package p;\n"
1500 "interface IOuter {\n"
1501 " parcelable Inner {}\n"
1502 "}");
1503 import_paths_.emplace("");
1504 const string input_path = "p/IFoo.aidl";
1505 const string input =
1506 "package p;\n"
1507 "import p.IOuter.Inner;"
1508 "interface IFoo {\n"
1509 " Inner get();\n"
1510 "}";
1511 CaptureStderr();
1512 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1513 EXPECT_EQ(GetCapturedStderr(), "");
1514
1515 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1516}
1517
1518TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1519 const string input_path = "p/IFoo.aidl";
1520 const string input =
1521 "package p;\n"
1522 "interface IFoo {\n"
1523 " parcelable Result {}\n"
1524 " Result get();\n"
1525 "}";
1526 CaptureStderr();
1527 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1528 EXPECT_EQ(GetCapturedStderr(), "");
1529
1530 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1531}
1532
1533// Finding the type of nested named member.
1534struct TypeFinder : AidlVisitor {
1535 string name;
1536 const AidlTypeSpecifier* type = nullptr;
1537 TypeFinder(std::string name) : name(name) {}
1538 void Visit(const AidlVariableDeclaration& v) override {
1539 if (v.GetName() == name) {
1540 type = &v.GetType();
1541 }
1542 }
1543 void Visit(const AidlMethod& m) override {
1544 if (m.GetName() == name) {
1545 type = &m.GetType();
1546 }
1547 }
1548 static string Get(const AidlDefinedType& type, const string& name) {
1549 TypeFinder v(name);
1550 VisitTopDown(v, type);
1551 return v.type ? v.type->Signature() : "(null)";
1552 };
1553};
1554
1555TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1556 io_delegate_.SetFileContents("q/IBar.aidl",
1557 "package q;\n"
1558 "interface IBar {\n"
1559 " parcelable Baz {}\n"
1560 "}");
1561 import_paths_.emplace("");
1562 const string input_path = "p/IFoo.aidl";
1563 const string input =
1564 "package p;\n"
1565 "import q.IBar;\n"
1566 "interface IFoo {\n"
1567 " parcelable Nested {\n"
1568 " Baz t1;\n"
1569 " }\n"
1570 " parcelable Baz { }\n"
1571 " IBar.Baz t2();\n"
1572 " Baz t3();\n"
1573 "}";
1574 CaptureStderr();
1575 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1576 EXPECT_EQ(GetCapturedStderr(), "");
1577 ASSERT_NE(nullptr, foo);
1578
1579 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1580 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1581 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1582}
1583
1584TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1585 const string input_path = "p/Foo.aidl";
1586 const string input =
1587 "package p;\n"
1588 "parcelable Foo {\n"
1589 " parcelable Foo {}\n"
1590 "}";
1591 CaptureStderr();
1592 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1593 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1594}
1595
1596TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1597 const string input_path = "p/IFoo.aidl";
1598 const string input =
1599 "package p;\n"
1600 "interface IFoo {\n"
1601 " interface ICallback { void done(); }\n"
1602 " void doTask(ICallback cb);\n"
1603 "}";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1606 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1607}
1608
1609TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1610 const string input_path = "p/Foo.aidl";
1611 const string input =
1612 "package p;\n"
1613 "interface Foo {\n"
1614 " parcelable Bar {}\n"
1615 " parcelable Bar {}\n"
1616 "}";
1617 CaptureStderr();
1618 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1619 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1620}
1621
1622TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1623 struct Failure {
1624 string err;
1625 };
1626 struct TestCase {
1627 string type;
1628 variant<string, Failure> expected; // success<0> or failure<1>
1629 };
1630 vector<TestCase> cases = {
1631 {"foo.A", "foo.A"},
1632 {"foo.A.B", "foo.A.B"},
1633 {"@nullable(heap=true) A", "foo.A.B.A"},
1634 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1635 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1636 {"B", "foo.A.B.A.B"},
1637 {"A.B", "foo.A.B.A.B"},
1638 };
1639 const string input_path = "foo/A.aidl";
1640 for (auto& [type, expected] : cases) {
1641 AidlTypenames typenames;
1642 // clang-format off
1643 const string input =
1644 "package foo;\n"
1645 "parcelable A {\n"
1646 " parcelable B {\n"
1647 " parcelable A {\n"
1648 " parcelable B {\n"
1649 " }\n"
1650 " " + type + " m;\n"
1651 " }\n"
1652 " }\n"
1653 "}";
1654 // clang-format on
1655 CaptureStderr();
1656 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1657 if (auto failure = std::get_if<Failure>(&expected); failure) {
1658 ASSERT_EQ(nullptr, foo);
1659 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1660 } else {
1661 EXPECT_EQ(GetCapturedStderr(), "");
1662 ASSERT_NE(nullptr, foo);
1663 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1664 }
1665 }
1666}
1667
Jooyung Hanca84b032021-09-30 02:15:59 +09001668TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1669 const string input_path = "p/IFoo.aidl";
1670 const string input =
1671 "package p;\n"
1672 "interface IFoo {\n"
1673 " parcelable Result {}\n"
1674 "}";
1675 CaptureStderr();
1676 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1677 ASSERT_NE(nullptr, foo);
1678 EXPECT_EQ(GetCapturedStderr(), "");
1679
1680 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1681 ASSERT_NE(nullptr, result);
1682 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1683}
1684
Jooyung Han0a950bd2021-05-15 12:50:36 +09001685TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001686 const string input_path = "p/Wrapper.aidl";
1687 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001688
1689 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1690 EXPECT_NE(nullptr, parse_result);
1691
1692 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1693 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1694 (..., params->emplace_back(std::move(type_params)));
1695 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1696 };
1697
1698 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1699 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001700 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001701 type->Annotate(std::move(annotations));
1702 return std::move(type);
1703 };
1704
1705 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1706 (void)type->SetArray();
1707 return std::move(type);
1708 };
1709
1710 auto w = type("p.Wrapper", type("String"));
1711 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1712
1713 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1714 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1715 cpp::CppNameOf(*nullable_w, typenames_));
1716
1717 auto array_w = set_array(type("p.Wrapper", type("String")));
1718 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1719 cpp::CppNameOf(*array_w, typenames_));
1720
1721 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1722 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1723 cpp::CppNameOf(*nullable_array_w, typenames_));
1724
1725 auto list_w = type("List", type("p.Wrapper", type("String")));
1726 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1727 cpp::CppNameOf(*list_w, typenames_));
1728
1729 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1730 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1731 cpp::CppNameOf(*nullable_list_w, typenames_));
1732}
1733
Devin Moore7b8d5c92020-03-17 14:14:08 -07001734TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001735 io_delegate_.SetFileContents(
1736 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001737 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001738 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001739 const string input_path = "p/IFoo.aidl";
1740 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001741 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1742 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001743 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001744 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001745 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001746
1747 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1748 // C++ understands C++ specific stuff
1749 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1750 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001751 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001752 EXPECT_EQ(1u, headers.size());
1753 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001754}
1755
Christopher Wileyf8136192016-04-12 14:19:35 -07001756TEST_F(AidlTest, WritesCorrectDependencyFile) {
1757 // While the in tree build system always gives us an output file name,
1758 // other android tools take advantage of our ability to infer the intended
1759 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001760 vector<string> args = {
1761 "aidl",
1762 "-d dep/file/path",
1763 "-o place/for/output",
1764 "p/IFoo.aidl"};
1765 Options options = Options::From(args);
1766 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001767 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001768 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001769 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001770 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1771}
1772
Dan Willemsen93298ee2016-11-10 23:55:55 -08001773TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1774 // While the in tree build system always gives us an output file name,
1775 // other android tools take advantage of our ability to infer the intended
1776 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001777 vector<string> args = {
1778 "aidl",
1779 "-d dep/file/path",
1780 "--ninja",
1781 "-o place/for/output",
1782 "p/IFoo.aidl"};
1783 Options options = Options::From(args);
1784 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001785 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001786 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001787 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001788 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1789}
1790
Jiyong Parkdf202122019-09-30 20:48:35 +09001791TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001792 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1793 // this by calling aidl with every .aidl file it finds, then parsing the
1794 // generated dependency files. Those that reference .java output files are
1795 // for interfaces and those that do not are parcelables. However, for both
1796 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001797 vector<string> args = {
1798 "aidl",
1799 "-o place/for/output",
1800 "-d dep/file/path",
1801 "p/Foo.aidl"};
1802 Options options = Options::From(args);
1803 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001804 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001805 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001806 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001807 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1808}
1809
1810TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1811 vector<string> args = {
1812 "aidl",
1813 "--structured",
1814 "-o place/for/output",
1815 "-d dep/file/path",
1816 "p/Foo.aidl"};
1817 Options options = Options::From(args);
1818 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001819 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001820 string actual_dep_file_contents;
1821 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1822 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001823}
1824
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001825TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1826 vector<string> args = {
1827 "aidl",
1828 "--lang=java",
1829 "-o place/for/output",
1830 "p/Foo.aidl"};
1831 Options options = Options::From(args);
1832 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001833 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001834 string output_file_contents;
1835 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1836}
1837
Devin Moore21b26772020-08-26 16:37:56 -07001838TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001839 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001840 const string list_array_parcelable =
1841 "package a; parcelable Foo {\n"
1842 " List[] lists; }";
1843 CaptureStderr();
1844 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1845 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1846}
1847
Jiyong Parkf8d53612020-05-04 14:06:13 +09001848TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1849 AidlError error;
1850 string expected_stderr =
1851 "ERROR: a/IFoo.aidl:2.7-11: "
1852 "Encountered an untyped List or Map. The use of untyped List/Map is "
1853 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1854 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1855 if (GetLanguage() != Options::Language::JAVA) {
1856 expected_stderr =
1857 "ERROR: a/IFoo.aidl:2.1-7: "
1858 "Currently, only the Java backend supports non-generic List.\n";
1859 }
1860
1861 const string primitive_interface =
1862 "package a; interface IFoo {\n"
1863 " List foo(); }";
1864 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001865 AidlTypenames tn1;
1866 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001867 {"--structured"}));
1868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001869
1870 string primitive_parcelable =
1871 "package a; parcelable IFoo {\n"
1872 " List foo;}";
1873 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001874 AidlTypenames tn2;
1875 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001876 {"--structured"}));
1877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1878}
1879
Jeongik Cha225519b2020-08-29 01:55:32 +09001880TEST_P(AidlTest, ExtensionTest) {
1881 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001882 string extendable_parcelable =
1883 "package a; parcelable Data {\n"
1884 " ParcelableHolder extension;\n"
1885 " ParcelableHolder extension2;\n"
1886 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001887 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001888 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1889 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001890 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001891 "yet.\n",
1892 GetCapturedStderr());
1893 } else {
1894 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1895 EXPECT_EQ("", GetCapturedStderr());
1896 }
1897}
1898TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1899 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001900 string parcelableholder_return_interface =
1901 "package a; interface IFoo {\n"
1902 " ParcelableHolder foo();\n"
1903 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001904 EXPECT_EQ(nullptr,
1905 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001906
Jeongik Cha8f02a532020-10-14 00:16:28 +09001907 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001908 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001909 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001910 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001911 "yet.\n",
1912 GetCapturedStderr());
1913 return;
1914 }
1915 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1916 GetCapturedStderr());
1917}
1918
1919TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1920 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001921 string extendable_parcelable_arg_interface =
1922 "package a; interface IFoo {\n"
1923 " void foo(in ParcelableHolder ph);\n"
1924 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001925 EXPECT_EQ(nullptr,
1926 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1927
Jeongik Cha8f02a532020-10-14 00:16:28 +09001928 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001929 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001930 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001931 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001932 "yet.\n",
1933 GetCapturedStderr());
1934 return;
1935 }
1936 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1937 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001938}
1939
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001940TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1941 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001942 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001943 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1944 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001945 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001946 if (GetLanguage() == Options::Language::RUST) {
1947 EXPECT_EQ(
1948 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1949 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1950 "yet.\n",
1951 GetCapturedStderr());
1952 return;
1953 }
1954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1955}
1956
Jooyung Han3f347ca2020-12-01 12:41:50 +09001957TEST_P(AidlTest, ParcelablesWithConstants) {
1958 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001959 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001960 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001961 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001962 EXPECT_EQ("", GetCapturedStderr());
1963}
1964
1965TEST_P(AidlTest, UnionWithConstants) {
1966 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001967 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001968 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001969 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001970 EXPECT_EQ("", GetCapturedStderr());
1971}
1972
Jooyung Han633eab62021-01-07 14:12:40 +09001973TEST_F(AidlTest, ConstantsWithAnnotations) {
1974 io_delegate_.SetFileContents("IFoo.aidl",
1975 "interface IFoo {\n"
1976 " @JavaPassthrough(annotation=\"@Foo\")\n"
1977 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1978 "}");
1979 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1980 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001981 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09001982 EXPECT_EQ("", GetCapturedStderr());
1983 string code;
1984 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1985 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1986 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1987}
1988
Jiyong Park02da7422018-07-16 16:00:26 +09001989TEST_F(AidlTest, ApiDump) {
1990 io_delegate_.SetFileContents(
1991 "foo/bar/IFoo.aidl",
1992 "package foo.bar;\n"
1993 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001994 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001995 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001996 " /* @hide applied \n"
1997 " @deprecated use foo2 */\n"
1998 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1999 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002000 " IFoo foo3(IFoo foo);\n"
2001 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002002 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002003 " /** blahblah\n"
2004 " @deprecated\n"
2005 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002006 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002007 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002008 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002009 "}\n");
2010 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2011 "package foo.bar;\n"
2012 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002013 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002014 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002015 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002016 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002017 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002018 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002019 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002020 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002021 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002022 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002023 "}\n");
2024 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002025 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2026 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002027 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002028 bool result = dump_api(options, io_delegate_);
2029 ASSERT_TRUE(result);
2030 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002031 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002032 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002033interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002034 /**
2035 * @hide
2036 * @deprecated use foo2
2037 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002038 int foo(out int[] a, String b, boolean c, inout List<String> d);
2039 int foo2(@utf8InCpp String x, inout List<String> y);
2040 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2041 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002042 /**
2043 * @deprecated reason why...
2044 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002045 const int A = 1;
2046 const String STR = "Hello";
2047}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002048)"),
2049 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002050
Jiyong Parke59c3682018-09-11 23:10:25 +09002051 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002052 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002053/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002054parcelable Data {
2055 int x = 10;
2056 int y;
2057 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002058 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002059}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002060)"),
2061 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002062}
2063
Jiyong Parked65bf42018-08-28 15:43:27 +09002064TEST_F(AidlTest, ApiDumpWithManualIds) {
2065 io_delegate_.SetFileContents(
2066 "foo/bar/IFoo.aidl",
2067 "package foo.bar;\n"
2068 "interface IFoo {\n"
2069 " int foo() = 1;\n"
2070 " int bar() = 2;\n"
2071 " int baz() = 10;\n"
2072 "}\n");
2073
Jiyong Parke59c3682018-09-11 23:10:25 +09002074 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002075 Options options = Options::From(args);
2076 bool result = dump_api(options, io_delegate_);
2077 ASSERT_TRUE(result);
2078 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002079 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002080 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002081interface IFoo {
2082 int foo() = 1;
2083 int bar() = 2;
2084 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002085}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002086)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002087}
2088
2089TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002090 const string expected_stderr =
2091 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2092 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002093 io_delegate_.SetFileContents(
2094 "foo/bar/IFoo.aidl",
2095 "package foo.bar;\n"
2096 "interface IFoo {\n"
2097 " int foo() = 1;\n"
2098 " int bar();\n"
2099 " int baz() = 10;\n"
2100 "}\n");
2101
Jiyong Parke59c3682018-09-11 23:10:25 +09002102 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002103 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002104 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002105 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002106 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002107}
2108
Jooyung Han965e31d2020-11-27 12:30:16 +09002109TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2110 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2111 "package foo.bar;\n"
2112 "interface IFoo {\n"
2113 " @utf8InCpp String foo();\n"
2114 " const @utf8InCpp String bar = \"bar\";\n"
2115 "}\n");
2116
2117 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2118 Options options = Options::From(args);
2119 CaptureStderr();
2120 EXPECT_TRUE(dump_api(options, io_delegate_));
2121 EXPECT_EQ("", GetCapturedStderr());
2122 string actual;
2123 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002124 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2125interface IFoo {
2126 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002127 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002128}
2129)"),
2130 actual);
2131}
2132
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002133TEST_F(AidlTest, ApiDumpWithEnums) {
2134 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2135 "package foo.bar;\n"
2136 "enum Enum {\n"
2137 " FOO,\n"
2138 " BAR = FOO + 1,\n"
2139 "}\n");
2140
2141 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2142 Options options = Options::From(args);
2143 CaptureStderr();
2144 EXPECT_TRUE(dump_api(options, io_delegate_));
2145 EXPECT_EQ("", GetCapturedStderr());
2146 string actual;
2147 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2148 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2149 "enum Enum {\n"
2150 " FOO = 0,\n"
2151 " BAR = 1,\n"
2152 "}\n"),
2153 actual);
2154}
2155
2156TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2157 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2158 "package foo.bar;\n"
2159 "enum Enum {\n"
2160 " FOO,\n"
2161 "}\n");
2162 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2163 "package foo.bar;\n"
2164 "import foo.bar.Enum;\n"
2165 "parcelable Foo {\n"
2166 " Enum e = Enum.FOO;\n"
2167 "}\n");
2168
2169 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2170 Options options = Options::From(args);
2171 CaptureStderr();
2172 EXPECT_TRUE(dump_api(options, io_delegate_));
2173 EXPECT_EQ("", GetCapturedStderr());
2174 string actual;
2175 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2176 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2177 "parcelable Foo {\n"
2178 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2179 "}\n"),
2180 actual);
2181}
2182
Jooyung Han71dfec32021-05-23 07:18:58 +09002183TEST_F(AidlTest, ApiDumpWithGenerics) {
2184 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2185 "package foo.bar;\n"
2186 "parcelable Foo<T, U> {\n"
2187 "}\n");
2188
2189 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2190 Options options = Options::From(args);
2191 CaptureStderr();
2192 EXPECT_TRUE(dump_api(options, io_delegate_));
2193 EXPECT_EQ("", GetCapturedStderr());
2194 string actual;
2195 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2196 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2197 "parcelable Foo<T, U> {\n"
2198 "}\n"),
2199 actual);
2200}
2201
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002202TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2203 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2204 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2205
2206 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2207 Options options = Options::From(args);
2208 CaptureStderr();
2209 EXPECT_FALSE(dump_api(options, io_delegate_));
2210 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2211}
2212
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002213TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002214 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002215 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2216 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002217 const string expected_map_stderr =
2218 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002219 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2220 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002221 "package p; interface IFoo {"
2222 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002223 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002224 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002225 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002226
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002227 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002228 "package p; interface IFoo {"
2229 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002230 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002231 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002233}
2234
Jeongik Chae48d9942020-01-02 17:39:00 +09002235TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002236 const string expected_stderr =
2237 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002238 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002239 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2240
2241 io_delegate_.SetFileContents("p/IFoo.aidl",
2242 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002243 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002244 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002245
2246 io_delegate_.SetFileContents("p/IFoo.aidl",
2247 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002248 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002249 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002250 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002252
2253 io_delegate_.SetFileContents("p/IFoo.aidl",
2254 "package p; interface IFoo {"
2255 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002256 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002257
2258 io_delegate_.SetFileContents("p/IFoo.aidl",
2259 "package p; interface IFoo {"
2260 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002261 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002262}
2263
Jeongik Chadf76dc72019-11-28 00:08:47 +09002264TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002265 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002266 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2267 io_delegate_.SetFileContents(options.InputFiles().front(),
2268 "package p; interface IFoo {"
2269 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002270 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002271 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002272 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002273}
2274
2275TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002276 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002277 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002278 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002279 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002280 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2281 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002282
Jooyung Han13f1fa52021-06-11 18:06:12 +09002283 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002284 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2285 io_delegate_.SetFileContents("p/IFoo.aidl",
2286 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002287 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002288 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002289 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002290 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002291 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002292 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002293 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002294 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002295 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002296 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002297 io_delegate_.SetFileContents("p/IFoo.aidl",
2298 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002299 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002300 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002301
2302 io_delegate_.SetFileContents("p/IFoo.aidl",
2303 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002304 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002305
2306 io_delegate_.SetFileContents("p/IFoo.aidl",
2307 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002308 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002309
Steven Moreland4e059132021-08-11 13:36:30 -07002310 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002311}
2312
Jeongik Cha0e426012019-07-29 15:57:02 +09002313TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2314 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002315 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2316 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002317 for (const auto& rawOption : rawOptions) {
2318 string expected_stderr =
2319 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002320 Options options = Options::From(rawOption);
2321 io_delegate_.SetFileContents(options.InputFiles().front(),
2322 "package foo.bar;\n"
2323 "interface IFoo1 { int foo(); }\n"
2324 "interface IFoo2 { int foo(); }\n"
2325 "parcelable Data1 { int a; int b;}\n"
2326 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002327 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002328 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002330
Jeongik Cha0e426012019-07-29 15:57:02 +09002331 io_delegate_.SetFileContents(options.InputFiles().front(),
2332 "package foo.bar;\n"
2333 "interface IFoo1 { int foo(); }\n"
2334 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002335 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002336 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002337 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002338
Devin Moore5de18ed2020-04-02 13:52:29 -07002339 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002340 io_delegate_.SetFileContents(options.InputFiles().front(),
2341 "package foo.bar;\n"
2342 "parcelable Data1 { int a; int b;}\n"
2343 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002345 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002347 }
2348}
2349
Devin Moorebdba2a82020-03-31 15:19:02 -07002350TEST_P(AidlTest, FailParseOnEmptyFile) {
2351 const string contents = "";
2352 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2353 CaptureStderr();
2354 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2356}
2357
Jiyong Parkb034bf02018-07-30 17:44:33 +09002358TEST_F(AidlTest, MultipleInputFiles) {
2359 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002360 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002361
2362 io_delegate_.SetFileContents(options.InputFiles().at(0),
2363 "package foo.bar;\n"
2364 "import foo.bar.Data;\n"
2365 "interface IFoo { Data getData(); }\n");
2366
2367 io_delegate_.SetFileContents(options.InputFiles().at(1),
2368 "package foo.bar;\n"
2369 "import foo.bar.IFoo;\n"
2370 "parcelable Data { IFoo foo; }\n");
2371
Steven Moreland4e059132021-08-11 13:36:30 -07002372 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002373
2374 string content;
2375 for (const auto file : {
2376 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2377 content.clear();
2378 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2379 EXPECT_FALSE(content.empty());
2380 }
2381}
2382
2383TEST_F(AidlTest, MultipleInputFilesCpp) {
2384 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002385 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002386
2387 io_delegate_.SetFileContents(options.InputFiles().at(0),
2388 "package foo.bar;\n"
2389 "import foo.bar.Data;\n"
2390 "interface IFoo { Data getData(); }\n");
2391
2392 io_delegate_.SetFileContents(options.InputFiles().at(1),
2393 "package foo.bar;\n"
2394 "import foo.bar.IFoo;\n"
2395 "parcelable Data { IFoo foo; }\n");
2396
Steven Moreland4e059132021-08-11 13:36:30 -07002397 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002398
2399 string content;
2400 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002401 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002402 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2403 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2404 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2405 content.clear();
2406 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2407 EXPECT_FALSE(content.empty());
2408 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002409}
2410
Andrei Homescub62afd92020-05-11 19:24:59 -07002411TEST_F(AidlTest, MultipleInputFilesRust) {
2412 Options options =
2413 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2414
2415 io_delegate_.SetFileContents(options.InputFiles().at(0),
2416 "package foo.bar;\n"
2417 "import foo.bar.Data;\n"
2418 "interface IFoo { Data getData(); }\n");
2419
2420 io_delegate_.SetFileContents(options.InputFiles().at(1),
2421 "package foo.bar;\n"
2422 "import foo.bar.IFoo;\n"
2423 "parcelable Data { IFoo foo; }\n");
2424
Steven Moreland4e059132021-08-11 13:36:30 -07002425 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002426
2427 string content;
2428 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2429 content.clear();
2430 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2431 EXPECT_FALSE(content.empty());
2432 }
2433}
2434
Devin Moore097a3ab2020-03-11 16:08:44 -07002435TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2436 const string expected_stderr =
2437 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002438 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2439 // int getInterfaceVersion() is one of the meta transactions
2440 io_delegate_.SetFileContents(options.InputFiles().front(),
2441 "package p; interface IFoo {"
2442 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002443 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002444 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002445 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2446}
Jiyong Park309668e2018-07-28 16:55:44 +09002447
Devin Moore097a3ab2020-03-11 16:08:44 -07002448TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2449 // boolean getInterfaceVersion() is not a meta transaction, but should be
2450 // prevented because return type is not part of a method signature
2451 const string expected_stderr =
2452 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2453 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002454 io_delegate_.SetFileContents(options.InputFiles().front(),
2455 "package p; interface IFoo {"
2456 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002458 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002459 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2460}
Jiyong Park309668e2018-07-28 16:55:44 +09002461
Devin Moore097a3ab2020-03-11 16:08:44 -07002462TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002463 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002464 const string expected_stderr =
2465 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2466 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002467 io_delegate_.SetFileContents(options.InputFiles().front(),
2468 "package p; interface IFoo {"
2469 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002470 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002471 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002472 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002473
2474 // this is not a meta interface method as it differs type arguments
2475 io_delegate_.SetFileContents(options.InputFiles().front(),
2476 "package p; interface IFoo {"
2477 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002478 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002479}
2480
Jooyung Hanb8a97772021-01-19 01:27:38 +09002481TEST_F(AidlTest, CheckApiForEquality) {
2482 CaptureStderr();
2483 Options options = Options::From("aidl --checkapi=equal old new");
2484
2485 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2486 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2487 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2488 "package p; interface IFoo{ @utf8InCpp String foo();}");
2489
2490 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2491 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2492}
2493
Daniel Norman85aed542019-08-21 12:01:14 -07002494TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002495 Options options = Options::From("aidl --checkapi old new");
2496 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2497 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2498 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2499 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2500
2501 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2502}
2503
Jiyong Park3656c3c2018-08-01 20:02:01 +09002504TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002505 Options options = Options::From("aidl --checkapi old new");
2506 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2507 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002508
2509 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2510}
2511
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002512TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2513 Options options = Options::From("aidl --checkapi old new");
2514 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2515 const string enum_definition = "package p; enum Enum { FOO }";
2516 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2517 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2518 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2519 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2520
2521 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2522}
2523
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002524TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2525 Options options = Options::From("aidl --checkapi old new -I import");
2526
2527 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2528 io_delegate_.SetFileContents("new/p/Foo.aidl",
2529 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2530 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2531
2532 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2533}
2534
Jooyung Han02a11be2021-02-11 13:18:06 +09002535TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2536 Options options = Options::From("aidl --checkapi=equal old new");
2537 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2538 const string enum_definition = "package p; enum Enum { FOO }";
2539 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2540 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2541 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2542 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2543 CaptureStderr();
2544 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2545 EXPECT_EQ("", GetCapturedStderr());
2546}
2547
Daniel Norman85aed542019-08-21 12:01:14 -07002548class AidlTestCompatibleChanges : public AidlTest {
2549 protected:
2550 Options options_ = Options::From("aidl --checkapi old new");
2551};
2552
2553TEST_F(AidlTestCompatibleChanges, NewType) {
2554 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2555 "package p;"
2556 "interface IFoo {"
2557 " void foo(int a);"
2558 "}");
2559 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2560 "package p;"
2561 "interface IFoo {"
2562 " void foo(int a);"
2563 "}");
2564 io_delegate_.SetFileContents("new/p/IBar.aidl",
2565 "package p;"
2566 "interface IBar {"
2567 " void bar();"
2568 "}");
2569 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2570}
2571
2572TEST_F(AidlTestCompatibleChanges, NewMethod) {
2573 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2574 "package p;"
2575 "interface IFoo {"
2576 " void foo(int a);"
2577 "}");
2578 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2579 "package p;"
2580 "interface IFoo {"
2581 " void foo(int a);"
2582 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002583 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002584 "}");
2585 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2586}
2587
2588TEST_F(AidlTestCompatibleChanges, NewField) {
2589 io_delegate_.SetFileContents("old/p/Data.aidl",
2590 "package p;"
2591 "parcelable Data {"
2592 " int foo;"
2593 "}");
2594 io_delegate_.SetFileContents("new/p/Data.aidl",
2595 "package p;"
2596 "parcelable Data {"
2597 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002598 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002599 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002600 "}");
2601 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2602}
2603
Jooyung Han05bd8a82021-04-28 23:56:38 +09002604TEST_F(AidlTestCompatibleChanges, NewField2) {
2605 io_delegate_.SetFileContents("old/p/Data.aidl",
2606 "package p;"
2607 "parcelable Data {"
2608 "}");
2609 io_delegate_.SetFileContents("new/p/Data.aidl",
2610 "package p;"
2611 "parcelable Data {"
2612 " int foo = 0;"
2613 "}");
2614 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2615}
2616
Daniel Norman85aed542019-08-21 12:01:14 -07002617TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2618 io_delegate_.SetFileContents("old/p/Enum.aidl",
2619 "package p;"
2620 "enum Enum {"
2621 " FOO = 1,"
2622 "}");
2623 io_delegate_.SetFileContents("new/p/Enum.aidl",
2624 "package p;"
2625 "enum Enum {"
2626 " FOO = 1,"
2627 " BAR = 2,"
2628 "}");
2629 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2630}
2631
2632TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2633 io_delegate_.SetFileContents("old/p/Enum.aidl",
2634 "package p;"
2635 "enum Enum {"
2636 " FOO = 1,"
2637 " BAR = 2,"
2638 "}");
2639 io_delegate_.SetFileContents("new/p/Enum.aidl",
2640 "package p;"
2641 "enum Enum {"
2642 " BAR = 2,"
2643 " FOO = 1,"
2644 "}");
2645 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2646}
2647
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002648TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2649 io_delegate_.SetFileContents("old/p/Union.aidl",
2650 "package p;"
2651 "union Union {"
2652 " String foo;"
2653 "}");
2654 io_delegate_.SetFileContents("new/p/Union.aidl",
2655 "package p;"
2656 "union Union {"
2657 " String foo;"
2658 " int num;"
2659 "}");
2660 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2661}
2662
Daniel Norman85aed542019-08-21 12:01:14 -07002663TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002664 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2665 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002666 "interface IFoo {"
2667 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002668 "}");
2669 io_delegate_.SetFileContents("old/p/Data.aidl",
2670 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002671 "parcelable Data {"
2672 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002673 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002674 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2675 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002676 "interface IFoo {"
2677 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002678 "}");
2679 io_delegate_.SetFileContents("new/p/Data.aidl",
2680 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002681 "parcelable Data {"
2682 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002683 "}");
2684 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2685 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002686 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002687 " void foo(int a);"
2688 "}");
2689 io_delegate_.SetFileContents("new/q/Data.aidl",
2690 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002691 "parcelable Data {"
2692 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002693 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002694 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2695}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002696
Daniel Norman85aed542019-08-21 12:01:14 -07002697TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2698 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2699 "package p;"
2700 "interface IFoo {"
2701 " void foo(int a);"
2702 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002703 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2704 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002705 "interface IFoo {"
2706 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002707 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002708 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2709}
Jiyong Parke59c3682018-09-11 23:10:25 +09002710
Daniel Norman85aed542019-08-21 12:01:14 -07002711TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002712 io_delegate_.SetFileContents("old/p/I.aidl",
2713 "package p; interface I {"
2714 "const int A = 1; }");
2715 io_delegate_.SetFileContents("new/p/I.aidl",
2716 "package p ; interface I {"
2717 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002718 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2719}
Jiyong Parka428d212018-08-29 22:26:30 +09002720
Daniel Norman85aed542019-08-21 12:01:14 -07002721TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002722 io_delegate_.SetFileContents("old/p/I.aidl",
2723 "package p; interface I {"
2724 "const int A = 1; const int B = 2;}");
2725 io_delegate_.SetFileContents("new/p/I.aidl",
2726 "package p ; interface I {"
2727 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002728 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002729}
2730
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002731TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2732 io_delegate_.SetFileContents("old/p/Foo.aidl",
2733 "package p;"
2734 "@JavaPassthrough(annotation=\"Alice\")"
2735 "@JavaPassthrough(annotation=\"Bob\")"
2736 "parcelable Foo {}");
2737 io_delegate_.SetFileContents("new/p/Foo.aidl",
2738 "package p;"
2739 "@JavaPassthrough(annotation=\"Bob\")"
2740 "@JavaPassthrough(annotation=\"Alice\")"
2741 "parcelable Foo {}");
2742 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2743}
2744
Jooyung Han00073272020-11-27 14:20:20 +09002745TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2746 io_delegate_.SetFileContents("old/p/Foo.aidl",
2747 "package p;"
2748 "parcelable Foo {}");
2749 io_delegate_.SetFileContents("new/p/Foo.aidl",
2750 "package p;"
2751 "@JavaPassthrough(annotation=\"@Deprecated\")"
2752 "parcelable Foo {}");
2753 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2754}
2755
Jooyung Han636fd2f2020-10-22 11:33:45 +09002756TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2757 io_delegate_.SetFileContents("old/p/Data.aidl",
2758 "package p;"
2759 "parcelable Data {"
2760 " int num;"
2761 "}");
2762 io_delegate_.SetFileContents(
2763 "new/p/Data.aidl",
2764 "package p;"
2765 "parcelable Data {"
2766 " int num;"
2767 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2768 "}");
2769 io_delegate_.SetFileContents("new/p/Enum.aidl",
2770 "package p;"
2771 "enum Enum {"
2772 " FOO = 0,"
2773 " BAR = 1,"
2774 "}");
2775 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2776}
2777
Jooyung Han308bbe02021-04-27 12:09:59 +09002778TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2779 io_delegate_.SetFileContents("old/p/Data.aidl",
2780 "package p;\n"
2781 "parcelable Data {\n"
2782 " p.Enum e;\n"
2783 "}");
2784 io_delegate_.SetFileContents("old/p/Enum.aidl",
2785 "package p;\n"
2786 "enum Enum {\n"
2787 " FOO = 0,\n"
2788 " BAR = 1,\n"
2789 "}");
2790 io_delegate_.SetFileContents("new/p/Data.aidl",
2791 "package p;\n"
2792 "parcelable Data {\n"
2793 " p.Enum e = p.Enum.FOO;\n"
2794 "}");
2795 io_delegate_.SetFileContents("new/p/Enum.aidl",
2796 "package p;\n"
2797 "enum Enum {\n"
2798 " FOO = 0,\n"
2799 " BAR = 1,\n"
2800 "}");
2801 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2802}
2803
Daniel Norman85aed542019-08-21 12:01:14 -07002804class AidlTestIncompatibleChanges : public AidlTest {
2805 protected:
2806 Options options_ = Options::From("aidl --checkapi old new");
2807};
2808
2809TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002810 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002811 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2812 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002813 "interface IFoo {"
2814 " void foo(in String[] str);"
2815 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002816 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002817 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002818 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002819 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002820}
2821
2822TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002823 const string expected_stderr =
2824 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002825 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2826 "package p;"
2827 "interface IFoo {"
2828 " void foo(in String[] str);"
2829 " void bar(@utf8InCpp String str);"
2830 "}");
2831 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2832 "package p;"
2833 "interface IFoo {"
2834 " void foo(in String[] str);"
2835 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002836 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002837 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002838 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002839}
2840
Jiyong Parkf8d53612020-05-04 14:06:13 +09002841TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2842 const string expected_stderr =
2843 "ERROR: new/p/IFoo.aidl:1.61-65: "
2844 "Encountered an untyped List or Map. The use of untyped List/Map is "
2845 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2846 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2847 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2848 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2849 "package p;"
2850 "interface IFoo {"
2851 " void foo(in String[] str);"
2852 "}");
2853 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2854 "package p;"
2855 "interface IFoo {"
2856 " void foo(in String[] str);"
2857 " void bar(in List arg);"
2858 "}");
2859 CaptureStderr();
2860 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2861 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2862}
2863
2864TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2865 const string expected_stderr =
2866 "ERROR: new/p/Data.aidl:1.54-59: "
2867 "Encountered an untyped List or Map. The use of untyped List/Map is "
2868 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2869 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2870 "ERROR: new/p/Data.aidl: Failed to read.\n";
2871 io_delegate_.SetFileContents("old/p/Data.aidl",
2872 "package p;"
2873 "parcelable Data {"
2874 " int foo;"
2875 "}");
2876 io_delegate_.SetFileContents("new/p/Data.aidl",
2877 "package p;"
2878 "parcelable Data {"
2879 " int foo;"
2880 " @nullable List list;"
2881 "}");
2882 CaptureStderr();
2883 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2884 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2885}
2886
Daniel Norman85aed542019-08-21 12:01:14 -07002887TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002888 const string expected_stderr =
2889 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002890 io_delegate_.SetFileContents("old/p/Data.aidl",
2891 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002892 "parcelable Data {"
2893 " int foo;"
2894 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002895 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002896 io_delegate_.SetFileContents("new/p/Data.aidl",
2897 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002898 "parcelable Data {"
2899 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002900 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002901 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002902 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002903 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002904}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002905
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002906TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2907 const string expected_stderr =
2908 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2909 "backends. Please either provide a default value for this field or mark the field as "
2910 "@nullable. This value or a null value will be used automatically when an old version of "
2911 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2912 "order to make sure your code continues to be backwards compatible, make sure the default or "
2913 "null value does not cause a semantic change to this parcelable.\n";
2914 io_delegate_.SetFileContents("old/p/Data.aidl",
2915 "package p;"
2916 "parcelable Data {"
2917 " int num;"
2918 "}");
2919 io_delegate_.SetFileContents("new/p/Data.aidl",
2920 "package p;"
2921 "parcelable Data {"
2922 " int num;"
2923 " String str;"
2924 "}");
2925 CaptureStderr();
2926 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2927 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2928}
2929
Jooyung Han636fd2f2020-10-22 11:33:45 +09002930TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2931 const string expected_stderr =
2932 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2933 "Please make sure 'Enum' has '0' as a valid value.\n";
2934 io_delegate_.SetFileContents("old/p/Data.aidl",
2935 "package p;"
2936 "parcelable Data {"
2937 " int num;"
2938 "}");
2939 io_delegate_.SetFileContents("new/p/Data.aidl",
2940 "package p;"
2941 "parcelable Data {"
2942 " int num;"
2943 " p.Enum e;"
2944 "}");
2945 io_delegate_.SetFileContents("new/p/Enum.aidl",
2946 "package p;"
2947 "enum Enum {"
2948 " FOO = 1,"
2949 " BAR = 2,"
2950 "}");
2951 CaptureStderr();
2952 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2954}
2955
Daniel Norman85aed542019-08-21 12:01:14 -07002956TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002957 const string expected_stderr =
2958 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002959 io_delegate_.SetFileContents("old/p/Enum.aidl",
2960 "package p;"
2961 "enum Enum {"
2962 " FOO = 1,"
2963 " BAR = 2,"
2964 "}");
2965 io_delegate_.SetFileContents("new/p/Enum.aidl",
2966 "package p;"
2967 "enum Enum {"
2968 " BAR = 2,"
2969 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002970 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002971 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002972 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002973}
2974
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002975TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2976 const string expected_stderr =
2977 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2978 io_delegate_.SetFileContents("old/p/Union.aidl",
2979 "package p;"
2980 "union Union {"
2981 " String str;"
2982 " int num;"
2983 "}");
2984 io_delegate_.SetFileContents("new/p/Union.aidl",
2985 "package p;"
2986 "union Union {"
2987 " String str;"
2988 "}");
2989 CaptureStderr();
2990 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2992}
2993
Daniel Norman85aed542019-08-21 12:01:14 -07002994TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002995 const string expected_stderr =
2996 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002997 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2998 "package p;"
2999 "interface IFoo {"
3000 " void foo(in String[] str);"
3001 " void bar(@utf8InCpp String str);"
3002 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003003 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3004 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003005 "interface IFoo {"
3006 " void foo(in String[] str);"
3007 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003008 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003010 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003011 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003012}
3013
Daniel Norman85aed542019-08-21 12:01:14 -07003014TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003015 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003016 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3017 "package p;"
3018 "interface IFoo {"
3019 " void foo(in String[] str);"
3020 " void bar(@utf8InCpp String str);"
3021 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003022 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3023 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003024 "interface IFoo2 {"
3025 " void foo(in String[] str);"
3026 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003027 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003028 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003029 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003030 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003031}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003032
Daniel Norman85aed542019-08-21 12:01:14 -07003033TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003034 const string expected_stderr =
3035 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003036 io_delegate_.SetFileContents("old/p/Enum.aidl",
3037 "package p;"
3038 "enum Enum {"
3039 " FOO = 1,"
3040 " BAR = 2,"
3041 "}");
3042 io_delegate_.SetFileContents("new/p/Enum.aidl",
3043 "package p;"
3044 "enum Enum {"
3045 " FOO = 3,"
3046 " BAR = 2,"
3047 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003048 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003049 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003050 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003051}
3052
3053TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003054 const string expected_stderr =
3055 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3056 "from 0 to 1.\n"
3057 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3058 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003059 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3060 "package p;"
3061 "interface IFoo {"
3062 " void foo(in String[] str);"
3063 " void bar(@utf8InCpp String str);"
3064 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003065 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3066 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003067 "interface IFoo {"
3068 " void bar(@utf8InCpp String str);"
3069 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003070 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003071 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003072 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003073 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003074}
3075
3076TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003077 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003078 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3079 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003080 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003081 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003082 "parcelable Data {"
3083 " int foo;"
3084 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003085 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003086 io_delegate_.SetFileContents("new/p/Data.aidl",
3087 "package p;"
3088 "parcelable Data {"
3089 " int bar;"
3090 " int foo;"
3091 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003092 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003093 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003094 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003095}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003096
Daniel Norman85aed542019-08-21 12:01:14 -07003097TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003098 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003099 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003100 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003101 "interface IFoo {"
3102 " void foo(in String[] str);"
3103 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003104 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003105 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3106 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003107 "interface IFoo {"
3108 " void foo(out String[] str);"
3109 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003110 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003111 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003112 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003113 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003114}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003115
Daniel Norman85aed542019-08-21 12:01:14 -07003116TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003117 const string expected_stderr =
3118 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003119 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3120 "package p;"
3121 "interface IFoo {"
3122 " void foo(in String[] str);"
3123 " void bar(@utf8InCpp String str);"
3124 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003125 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3126 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003127 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003128 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003129 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003130 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003131 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003132 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003134}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003135
Daniel Norman85aed542019-08-21 12:01:14 -07003136TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003137 const string expected_stderr =
3138 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003139 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3140 "package p;"
3141 "interface IFoo {"
3142 " void foo(in String[] str);"
3143 " void bar(@utf8InCpp String str);"
3144 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003145 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3146 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003147 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003148 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003149 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003150 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003151 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003152 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003153 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003154}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003155
Jooyung Han60b2fde2020-10-29 15:12:40 +09003156TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3157 const string expected_stderr =
3158 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3159 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3160 io_delegate_.SetFileContents("old/p/Foo.aidl",
3161 "package p;"
3162 "@Backing(type=\"byte\")"
3163 "enum Foo {"
3164 " FOO, BAR,"
3165 "}");
3166 io_delegate_.SetFileContents("new/p/Foo.aidl",
3167 "package p;"
3168 "@Backing(type=\"long\")"
3169 "enum Foo {"
3170 " FOO, BAR,"
3171 "}");
3172 CaptureStderr();
3173 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3174 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3175}
3176
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003177TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3178 const string expected_stderr =
3179 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3180 "to @JavaPassthrough(annotation=\"Bob\")\n";
3181 io_delegate_.SetFileContents("old/p/Foo.aidl",
3182 "package p;"
3183 "@JavaPassthrough(annotation=\"Alice\")"
3184 "parcelable Foo {}");
3185 io_delegate_.SetFileContents("new/p/Foo.aidl",
3186 "package p;"
3187 "@JavaPassthrough(annotation=\"Bob\")"
3188 "parcelable Foo {}");
3189
3190 CaptureStderr();
3191 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3193}
3194
Devin Mooredb7ac512020-08-07 11:17:36 -07003195TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3196 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003197 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003198 io_delegate_.SetFileContents("old/p/Foo.aidl",
3199 "package p;"
3200 "parcelable Foo {"
3201 " int A;"
3202 "}");
3203 io_delegate_.SetFileContents("new/p/Foo.aidl",
3204 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003205 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003206 " int A;"
3207 "}");
3208 CaptureStderr();
3209 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3210 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3211}
3212
3213TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3214 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003215 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003216 io_delegate_.SetFileContents("old/p/Foo.aidl",
3217 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003218 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003219 " int A;"
3220 "}");
3221 io_delegate_.SetFileContents("new/p/Foo.aidl",
3222 "package p;"
3223 "parcelable Foo {"
3224 " int A;"
3225 "}");
3226 CaptureStderr();
3227 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3229}
3230
Daniel Norman85aed542019-08-21 12:01:14 -07003231TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003232 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003233 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3234 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003235 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003236 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003237 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003239}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003240
Daniel Norman85aed542019-08-21 12:01:14 -07003241TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003242 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003243 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3244 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003245 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003246 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003248}
Jiyong Parka428d212018-08-29 22:26:30 +09003249
Daniel Norman85aed542019-08-21 12:01:14 -07003250TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003251 const string expected_stderr =
3252 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003253 io_delegate_.SetFileContents("old/p/I.aidl",
3254 "package p; interface I {"
3255 "const int A = 1; const int B = 2;}");
3256 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003257 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003258 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003260}
Jiyong Parka428d212018-08-29 22:26:30 +09003261
Daniel Norman85aed542019-08-21 12:01:14 -07003262TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003263 const string expected_stderr =
3264 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003265 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3266 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003267 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003268 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003269 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003270}
3271
Devin Moorec7e47a32020-08-07 10:55:25 -07003272TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3273 const string expected_stderr =
3274 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3275 "This is an incompatible change for FixedSize types.\n";
3276 io_delegate_.SetFileContents("old/p/Foo.aidl",
3277 "package p; @FixedSize parcelable Foo { int A = 1; }");
3278 io_delegate_.SetFileContents("new/p/Foo.aidl",
3279 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3280 CaptureStderr();
3281 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3282 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3283}
3284
Jeongik Cha68d18e72021-04-29 20:07:01 +09003285TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3286 const string expected_stderr =
3287 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3288 "android.net.UidRangeParcel is changed from 1 to 2. "
3289 "But it is forbidden because of legacy support.\n";
3290 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3291 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3292 io_delegate_.SetFileContents(
3293 "new/android/net/UidRangeParcel.aidl",
3294 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3295 CaptureStderr();
3296 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3297 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3298}
3299
Devin Moorec7e47a32020-08-07 10:55:25 -07003300TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3301 const string expected_stderr =
3302 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3303 io_delegate_.SetFileContents("old/p/Foo.aidl",
3304 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3305 io_delegate_.SetFileContents("new/p/Foo.aidl",
3306 "package p; @FixedSize parcelable Foo { int A = 1; }");
3307 CaptureStderr();
3308 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3310}
3311
3312TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3313 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003314 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003315 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003316 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3317 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003318 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003319 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003320 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003321 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003322 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003323 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3324 "f.\n"
3325 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3326 "nullable1.\n"
3327 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3328 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003329
3330 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003331 "@FixedSize parcelable Foo {\n"
3332 " int[] a;\n"
3333 " Bar b;\n"
3334 " String c;\n"
3335 " ParcelFileDescriptor d;\n"
3336 " IBinder e;\n"
3337 " List<String> f;\n"
3338 " int isFixedSize;\n"
3339 " @nullable OtherFixed nullable1;\n"
3340 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003341 "}");
3342 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003343 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003344 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003345
3346 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003347 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003348 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3349}
3350
3351TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3352 const string expected_stderr = "";
3353
3354 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3355 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3356 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003357 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003358
3359 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003360 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003361 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3362}
3363
Jiyong Park8c380532018-08-30 14:55:26 +09003364TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003365 const string expected_stderr =
3366 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3367 "dir1/q/IBar.aidl\n"
3368 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003369 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003370 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3371 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3372 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3373 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3374
Devin Moore097a3ab2020-03-11 16:08:44 -07003375 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003376 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003378}
3379
Jiyong Parked65bf42018-08-28 15:43:27 +09003380TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003381 const string expected_stderr =
3382 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3383 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003384 Options options = Options::From("aidl --checkapi old new");
3385 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3386 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003387
3388 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3389
Jiyong Parke59c3682018-09-11 23:10:25 +09003390 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003391 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003392 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003393 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003394}
3395
Jooyung Han652ce482021-02-26 12:40:35 +09003396TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3397 Options options =
3398 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003399
3400 // use without import
3401 io_delegate_.SetFileContents("p/IFoo.aidl",
3402 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003403 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003404
3405 // capture output files
3406 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003407
Devin Moore7b8d5c92020-03-17 14:14:08 -07003408 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003409 io_delegate_.SetFileContents(
3410 "p/IFoo.aidl",
3411 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003412 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003413 // output files should be the same
3414 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003415
3416 // use with import (as before)
3417 io_delegate_.SetFileContents("p/IFoo.aidl",
3418 "package p;"
3419 "import android.os.ParcelFileDescriptor;"
3420 "interface IFoo{"
3421 " void foo(in ParcelFileDescriptor fd);"
3422 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003423 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003424 // output files should be the same
3425 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003426}
Jiyong Parked65bf42018-08-28 15:43:27 +09003427
Jooyung Han020d8d12021-02-26 17:23:02 +09003428TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3429 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3430 CaptureStderr();
3431 io_delegate_.SetFileContents("p/IFoo.aidl",
3432 "package p;"
3433 "interface IFoo{"
3434 " void foo(out ParcelFileDescriptor fd);"
3435 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003436 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003437 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3438}
3439
3440TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3441 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3442 CaptureStderr();
3443 io_delegate_.SetFileContents("p/IFoo.aidl",
3444 "package p;"
3445 "interface IFoo{"
3446 " void foo(ParcelFileDescriptor fd);"
3447 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003448 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003449 EXPECT_THAT(GetCapturedStderr(),
3450 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3451}
3452
Jiyong Park3633b722019-04-11 15:38:26 +09003453TEST_F(AidlTest, ManualIds) {
3454 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3455 io_delegate_.SetFileContents("IFoo.aidl",
3456 "interface IFoo {\n"
3457 " void foo() = 0;\n"
3458 " void bar() = 1;\n"
3459 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003460 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003461}
3462
3463TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3464 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3465 io_delegate_.SetFileContents("IFoo.aidl",
3466 "interface IFoo {\n"
3467 " void foo() = 0;\n"
3468 " void bar() = 1;\n"
3469 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003470 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003471}
3472
3473TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003474 const string expected_stderr =
3475 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003476 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3477 io_delegate_.SetFileContents("IFoo.aidl",
3478 "interface IFoo {\n"
3479 " void foo() = 3;\n"
3480 " void bar() = 3;\n"
3481 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003482 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003483 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003485}
3486
3487TEST_F(AidlTest, FailOnOutOfRangeIds) {
3488 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003489 const string expected_stderr =
3490 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3491 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003492 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3493 io_delegate_.SetFileContents("IFoo.aidl",
3494 "interface IFoo {\n"
3495 " void foo() = 3;\n"
3496 " void bar() = 16777115;\n"
3497 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003499 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003500 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003501}
3502
3503TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003504 const string expected_stderr =
3505 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003506 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3507 io_delegate_.SetFileContents("IFoo.aidl",
3508 "interface IFoo {\n"
3509 " void foo() = 3;\n"
3510 " void bar();\n"
3511 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003512 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003513 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003514 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003515}
3516
Jiyong Parkc6816252019-07-08 08:12:28 +09003517TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3518 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3519 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3520 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003521 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003522}
3523
3524TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003525 const string expected_stderr =
3526 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3527 "dir/IBar.aidl\n"
3528 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003529 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003530
Jiyong Parkc6816252019-07-08 08:12:28 +09003531 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3532 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3533 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3534 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003535 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003536 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003537 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003538}
3539
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003540TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3541 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3542 "package a.b;\n"
3543 "import a.b.IBar;\n"
3544 "import a.b.IQux;\n"
3545 "interface IFoo { IQux foo(); }\n");
3546 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3547 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3548
3549 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003550 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003551
3552 string output;
3553 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3554 // IBar was imported but wasn't used. include is not expected.
3555 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3556 // IBar was imported and used. include is expected.
3557 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3558}
3559
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003560TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003561 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003562 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003563 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3564 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003565 interface IFoo {
3566 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003567 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003568 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003569 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003570 // JavaPassthrough should work with other types as well (e.g. enum)
3571 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3572 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3573 @JavaPassthrough(annotation="@com.android.AliceTwo")
3574 @Backing(type="byte")
3575 enum MyEnum {
3576 a, b, c
3577 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003578
Jooyung Han4cde01d2020-10-13 11:10:47 +09003579 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003580 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003581
3582 string java_out;
3583 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003584 // type-decl-level annotations with newline at the end
3585 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3586 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3587 // member-decl-level annotations with newline at the end
3588 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3589 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3590 // inline annotations with space at the end
3591 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003592
Jooyung Han4cde01d2020-10-13 11:10:47 +09003593 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3594 // type-decl-level annotations with newline at the end
3595 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3596 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3597
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003598 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003599 Options cpp_options =
3600 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003601 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003602
Jooyung Han4cde01d2020-10-13 11:10:47 +09003603 Options ndk_options =
3604 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003605 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003606
Jooyung Han4cde01d2020-10-13 11:10:47 +09003607 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003608 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003609}
3610
Andrei Homescue61feb52020-08-18 15:44:24 -07003611TEST_F(AidlTest, ParseRustDerive) {
3612 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3613 @RustDerive(Clone=true, Copy=false)
3614 parcelable Foo {
3615 int a;
3616 })");
3617
3618 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003619 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003620
3621 string rust_out;
3622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3623 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3624
3625 // Other backends shouldn't be bothered
3626 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003627 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003628
3629 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003630 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003631
3632 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003633 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003634}
3635
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003636TEST_F(AidlTest, EmptyEnforceAnnotation) {
3637 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3638 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3639 interface IFoo {
3640 @Enforce()
3641 void Protected();
3642 })");
3643
3644 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3645 CaptureStderr();
3646 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3647 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3648}
3649
3650TEST_F(AidlTest, EmptyEnforceCondition) {
3651 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3652 interface IFoo {
3653 @Enforce(condition="")
3654 void Protected();
3655 })");
3656
3657 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3658 CaptureStderr();
3659 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3660 EXPECT_THAT(GetCapturedStderr(),
3661 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3662}
3663
3664TEST_F(AidlTest, InvalidEnforceCondition) {
3665 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3666 interface IFoo {
3667 @Enforce(condition="invalid")
3668 void Protected();
3669 })");
3670
3671 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3672 CaptureStderr();
3673 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3674 EXPECT_THAT(GetCapturedStderr(),
3675 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3676}
3677
Jiyong Park56f73d72019-06-11 12:20:28 +09003678class AidlOutputPathTest : public AidlTest {
3679 protected:
3680 void SetUp() override {
3681 AidlTest::SetUp();
3682 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3683 }
3684
3685 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003686 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003687 // check the existence
3688 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3689 }
3690};
3691
3692TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3693 // <out_dir> / <package_name> / <type_name>.java
3694 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3695}
3696
3697TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3698 // when output file is explicitly set, it is always respected. -o option is
3699 // ignored.
3700 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3701}
3702
3703TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3704 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3705}
3706
3707TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3708 // output is the same as the input file except for the suffix
3709 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3710}
3711
Devin Moore7b8d5c92020-03-17 14:14:08 -07003712TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003713 AidlError error;
3714 const string expected_stderr =
3715 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3716 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003717 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3718 R"(package p;
3719 interface IFoo {
3720 const int int32_max_oob = 2147483650;
3721 }
3722 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003723 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003724 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3725 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003726}
3727
Devin Moore7b8d5c92020-03-17 14:14:08 -07003728TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003729 AidlError error;
3730 const string expected_stderr =
3731 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3732 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003733 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3734 R"(package p;
3735 interface IFoo {
3736 const int int32_min_oob = -2147483650;
3737 }
3738 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003739 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003740 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3741 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003742}
3743
Devin Moore7b8d5c92020-03-17 14:14:08 -07003744TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003745 AidlError error;
3746 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003747 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003748 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003749 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3750 R"(package p;
3751 interface IFoo {
3752 const long int64_max_oob = 21474836509999999999999999;
3753 }
3754 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003755 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003756 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3757 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003758}
3759
Devin Moore7b8d5c92020-03-17 14:14:08 -07003760TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003761 AidlError error;
3762 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003763 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003764 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003765 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3766 R"(package p;
3767 interface IFoo {
3768 const long int64_min_oob = -21474836509999999999999999;
3769 }
3770 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003771 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3773 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003774}
3775
Devin Moore7b8d5c92020-03-17 14:14:08 -07003776TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003777 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003778 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003779 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003780 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3781 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003782 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3783 R"(package p;
3784 @Backing(type="byte")
3785 enum TestEnum {
3786 FOO = 127,
3787 BAR,
3788 }
3789 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003790 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003791 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003792 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003793}
3794
Devin Mooredecaf292020-04-30 09:16:40 -07003795TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3796 AidlError error;
3797 const string expected_stderr =
3798 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003799 "be one of: type\n";
3800 CaptureStderr();
3801 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3802 R"(package p;
3803 @Backing(foo="byte")
3804 enum TestEnum {
3805 FOO = 1,
3806 BAR,
3807 }
3808 )",
3809 typenames_, GetLanguage(), &error));
3810 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3811 EXPECT_EQ(AidlError::BAD_TYPE, error);
3812}
3813
Jooyung Han5721a232020-12-24 04:34:55 +09003814TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3815 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3816 CaptureStderr();
3817 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3818 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3819}
3820
Jooyung Han66813932020-10-23 13:24:44 +09003821TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003822 io_delegate_.SetFileContents("Foo.aidl",
3823 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3824 "Map<String, Baz> d; Bar[] e; }");
3825 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3826 io_delegate_.SetFileContents("Baz.aidl",
3827 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003828 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003829 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003830}
3831
Jooyung Han66813932020-10-23 13:24:44 +09003832TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003833 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003834 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003835 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003836 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3837 "named 'bar'.\n";
3838 CaptureStderr();
3839 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003840 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003841 EXPECT_EQ(expected_error, GetCapturedStderr());
3842}
3843
Jooyung Han09e551c2021-05-11 11:44:48 +09003844TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3845 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3846 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3847 CaptureStderr();
3848 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003849 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003850 EXPECT_EQ("", GetCapturedStderr());
3851}
3852
Jooyung Han59af9cc2020-10-25 21:44:14 +09003853TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3854 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3855 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3856 string expected_error =
3857 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003858 "named 'bar'.\n";
3859 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003860 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003861 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003862 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003863}
3864
Jooyung Han66813932020-10-23 13:24:44 +09003865TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003866 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003867 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3868 string expected_error =
3869 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3870 "only be an in parameter.\n";
3871 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003872 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003873 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003874 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003875}
3876
Jooyung Han66813932020-10-23 13:24:44 +09003877TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003878 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003879 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3880 string expected_error =
3881 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3882 "only be an in parameter.\n";
3883 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003884 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003885 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003886 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003887}
3888
Jooyung Han66813932020-10-23 13:24:44 +09003889TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003890 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003891 Options options = Options::From("aidl --lang=java Foo.aidl");
3892 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003893 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3894 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003895 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003896 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003897 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3898}
Devin Moore53fc99c2020-08-12 08:07:52 -07003899
Jooyung Hanfe086af2021-01-16 03:44:47 +09003900TEST_P(AidlTest, UnionInUnion) {
3901 import_paths_.insert(".");
3902 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3903 CaptureStderr();
3904 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3905 EXPECT_THAT("", GetCapturedStderr());
3906}
3907
Jooyung Hanfe89f122020-10-14 03:49:18 +09003908TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3909 const string method = "package a; union Foo {}";
3910 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3911 CaptureStderr();
3912 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3913 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3914}
3915
3916TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3917 const string method = "package a; union Foo { ParcelableHolder x; }";
3918 const string expected_stderr =
3919 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3920 CaptureStderr();
3921 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3922 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3923}
3924
Jooyung Han53fb4242020-12-17 16:03:49 +09003925TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3926 import_paths_.insert(".");
3927 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3928 const string expected_err = "The union's first member should have a useful default value.";
3929 CaptureStderr();
3930 EXPECT_EQ(nullptr,
3931 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3932 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3933}
3934
Devin Moore53fc99c2020-08-12 08:07:52 -07003935TEST_P(AidlTest, GenericStructuredParcelable) {
3936 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003937 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003938 const string expected_stderr = "";
3939 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003940 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3942}
3943
Jooyung Han3f347ca2020-12-01 12:41:50 +09003944TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3945 io_delegate_.SetFileContents("Foo.aidl",
3946 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3947 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003948 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003949 const string expected_stderr = "";
3950 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003951 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003952 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3953
3954 string code;
3955 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3956 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3957const ::android::String16& Foo<T,U>::s() {
3958 static const ::android::String16 value(::android::String16(""));
3959 return value;
3960})--"));
3961}
3962
3963TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3964 io_delegate_.SetFileContents("Foo.aidl",
3965 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3966 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003967 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003968 const string expected_stderr = "";
3969 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003970 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3972
3973 string code;
3974 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3975 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3976const char* Foo<T, U>::s = "";
3977)--"));
3978}
3979
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003980TEST_F(AidlTest, NestedTypeArgs) {
3981 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003982 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3983
3984 io_delegate_.SetFileContents("a/Foo.aidl",
3985 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3986 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003987 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3988 const string expected_stderr = "";
3989 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003990 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3992
3993 string code;
3994 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003995 EXPECT_THAT(code,
3996 testing::HasSubstr(
3997 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3998}
3999
4000TEST_F(AidlTest, DoubleArrayError) {
4001 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4002
4003 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4004 const string expected_stderr =
4005 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4006 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004007 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004008 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4009}
4010
4011TEST_F(AidlTest, DoubleGenericError) {
4012 io_delegate_.SetFileContents("a/Bar.aidl",
4013 "package a; parcelable Bar { List<String><String> a; }");
4014
4015 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4016 const string expected_stderr =
4017 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4018 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004019 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4021}
4022
4023TEST_F(AidlTest, ArrayBeforeGenericError) {
4024 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4025
4026 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004027 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004028 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004029 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4030}
4031
4032TEST_F(AidlTest, NullableArraysAreNotSupported) {
4033 io_delegate_.SetFileContents("a/Bar.aidl",
4034 "package a; parcelable Bar { String @nullable [] a; }");
4035
4036 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4037 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004038 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004039 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4040}
4041
4042TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4043 io_delegate_.SetFileContents("a/Bar.aidl",
4044 "package a; parcelable Bar { List<@nullable String> a; }");
4045
4046 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4047 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004048 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004049 EXPECT_THAT(GetCapturedStderr(),
4050 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004051}
4052
Jooyung Han14004ed2020-10-16 03:49:57 +09004053struct GenericAidlTest : ::testing::Test {
4054 FakeIoDelegate io_delegate_;
4055 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004056 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004057 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4058 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4059 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4060
4061 Options options = Options::From(cmd);
4062 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004063 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004064 EXPECT_EQ("", GetCapturedStderr());
4065 }
4066};
4067
4068TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4069 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4070 string code;
4071 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4072 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4073 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4074 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4075}
4076
4077TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4078 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4079 string code;
4080 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4081 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4082 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4083 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4084}
4085
Devin Moore53fc99c2020-08-12 08:07:52 -07004086TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4087 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004088 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004089 const string expected_stderr =
4090 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4091 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004092 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004093 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4094}
4095
4096TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4097 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004098 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004099 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4100 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004101 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004102 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4103}
4104
Jooyung Han7a308842020-10-27 19:06:49 +09004105TEST_P(AidlTest, LongCommentWithinConstExpression) {
4106 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004107 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004108 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004109 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004110 EXPECT_EQ("", GetCapturedStderr());
4111}
4112
Jeongik Chaef44e622020-10-23 16:00:52 +09004113TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4114 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4115 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4116 std::string expectedErr =
4117 "ERROR: a/Foo.aidl:1.28-30: "
4118 "Encountered an untyped List or Map. The use of untyped List/Map is "
4119 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4120 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4121 "ERROR: a/Foo.aidl:1.35-37: "
4122 "Encountered an untyped List or Map. The use of untyped List/Map is "
4123 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4124 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4125 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004126 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004127 EXPECT_EQ(expectedErr, GetCapturedStderr());
4128}
4129
4130TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004131 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4132 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004133 std::string expectedErr =
4134 "ERROR: a/Foo.aidl:1.33-35: "
4135 "Encountered an untyped List or Map. The use of untyped List/Map is "
4136 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4137 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4138 "ERROR: a/Foo.aidl:1.40-42: "
4139 "Encountered an untyped List or Map. The use of untyped List/Map is "
4140 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4141 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004142 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004143 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004144 EXPECT_EQ(expectedErr, GetCapturedStderr());
4145}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004146
Jeongik Chaef44e622020-10-23 16:00:52 +09004147TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4148 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4149 io_delegate_.SetFileContents(
4150 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4151 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4152 std::string expectedErr =
4153 "ERROR: a/Foo.aidl:1.52-54: "
4154 "Encountered an untyped List or Map. The use of untyped List/Map is "
4155 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4156 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4157 "ERROR: a/Foo.aidl:1.64-66: "
4158 "Encountered an untyped List or Map. The use of untyped List/Map is "
4159 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4160 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4161 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004162 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004163 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004164}
4165
Jooyung Han690f5842020-12-04 13:02:04 +09004166TEST_F(AidlTest, EnumWithDefaults_Java) {
4167 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4168 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4169package p;
4170import p.Enum;
4171parcelable Foo {
4172 Enum e = Enum.BAR;
4173})");
4174 CaptureStderr();
4175 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004176 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004177 auto err = GetCapturedStderr();
4178 EXPECT_EQ("", err);
4179
4180 string code;
4181 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004182 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004183}
4184
4185TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4186 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4187 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4188package p;
4189import p.Enum;
4190parcelable Foo {
4191 Enum e = Enum.BAR;
4192})");
4193 CaptureStderr();
4194 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004195 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004196 auto err = GetCapturedStderr();
4197 EXPECT_EQ("", err);
4198
4199 string code;
4200 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4201 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4202}
4203
4204TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4205 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4206 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4207package p;
4208import p.Enum;
4209parcelable Foo {
4210 Enum e = Enum.BAR;
4211})");
4212 CaptureStderr();
4213 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004214 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004215 auto err = GetCapturedStderr();
4216 EXPECT_EQ("", err);
4217
4218 string code;
4219 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4220 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4221}
4222
4223TEST_F(AidlTest, EnumWithDefaults_Rust) {
4224 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4225 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4226package p;
4227import p.Enum;
4228parcelable Foo {
4229 int n = 42;
4230 Enum e = Enum.BAR;
4231})");
4232 CaptureStderr();
4233 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004234 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004235 auto err = GetCapturedStderr();
4236 EXPECT_EQ("", err);
4237
4238 string code;
4239 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4240 EXPECT_THAT(code, testing::HasSubstr(R"(
4241 fn default() -> Self {
4242 Self {
4243 n: 42,
4244 e: crate::mangled::_1_p_4_Enum::BAR,
4245 }
4246 })"));
4247}
4248
4249TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4250 import_paths_.insert("a");
4251 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4252 CaptureStderr();
4253 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4254package p;
4255import p.Enum;
4256parcelable Foo {
4257 int e = Enum.FOO | Enum.BAR;
4258})",
4259 typenames_, GetLanguage());
4260 auto err = GetCapturedStderr();
4261 EXPECT_EQ("", err);
4262 EXPECT_TRUE(type);
4263 const auto& fields = type->AsStructuredParcelable()->GetFields();
4264 EXPECT_EQ("int e = 3", fields[0]->ToString());
4265}
4266
4267TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4268 CaptureStderr();
4269 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4270@Backing(type="int")
4271enum Foo {
4272 STANDARD_SHIFT = 16,
4273 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4274 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4275}
4276)",
4277 typenames_, GetLanguage());
4278 auto err = GetCapturedStderr();
4279 EXPECT_EQ("", err);
4280 EXPECT_TRUE(type);
4281 const auto& enum_type = type->AsEnumDeclaration();
4282 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004283 auto writer = CodeWriter::ForString(&code);
4284 DumpVisitor visitor(*writer);
4285 visitor.Visit(*enum_type);
4286 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004287 EXPECT_EQ(R"--(@Backing(type="int")
4288enum Foo {
4289 STANDARD_SHIFT = 16,
4290 STANDARD_BT709 = 65536,
4291 STANDARD_BT601_625 = 131072,
4292}
4293)--",
4294 code);
4295}
4296
4297TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4298 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4299 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4300package p;
4301import p.Enum;
4302parcelable Foo {
4303 Enum e = Enum.FOO | Enum.BAR;
4304})");
4305 CaptureStderr();
4306 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004307 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004308 auto err = GetCapturedStderr();
4309 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4310 err);
4311}
4312
Jooyung Han361cd102021-05-24 11:30:10 +09004313TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4314 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4315 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4316package p;
4317import p.Enum;
4318parcelable Foo {
4319 Enum e = 1;
4320})");
4321 CaptureStderr();
4322 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004323 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4325}
4326
Jooyung Han690f5842020-12-04 13:02:04 +09004327TEST_P(AidlTest, DefaultWithEmptyArray) {
4328 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4329 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4330 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004331 auto options =
4332 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004333 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004334 auto err = GetCapturedStderr();
4335 EXPECT_EQ("", err);
4336}
4337
4338TEST_P(AidlTest, RejectRefsInAnnotation) {
4339 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4340 "package p; interface IFoo {\n"
4341 " const String ANNOTATION = \"@Annotation\";\n"
4342 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4343 "}");
4344 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004345 auto options =
4346 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004347 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004348 auto err = GetCapturedStderr();
4349 EXPECT_EQ(
4350 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4351 "ANNOTATION.\n",
4352 err);
4353}
4354
4355TEST_F(AidlTest, DefaultWithEnumValues) {
4356 io_delegate_.SetFileContents(
4357 "a/p/Foo.aidl",
4358 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4359 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4360 CaptureStderr();
4361 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004362 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004363 auto err = GetCapturedStderr();
4364 EXPECT_EQ("", err);
4365 string code;
4366 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4367 EXPECT_THAT(
4368 code, testing::HasSubstr(
4369 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4370}
4371
Jooyung Han14259392020-12-07 10:00:08 +09004372TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4373 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4374 CaptureStderr();
4375 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004376 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004377 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004378 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004379}
4380
4381TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4382 io_delegate_.SetFileContents("a/p/Foo.aidl",
4383 "package p; parcelable Foo { const int A = A + 1; }");
4384 CaptureStderr();
4385 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004386 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004387 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004388 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4389}
4390
4391TEST_F(AidlTest, RecursiveReferences) {
4392 io_delegate_.SetFileContents("a/p/Foo.aidl",
4393 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4394 io_delegate_.SetFileContents("a/p/Bar.aidl",
4395 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4396 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4397 CaptureStderr();
4398 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004399 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004400 EXPECT_EQ("", GetCapturedStderr());
4401}
4402
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004403TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4404 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4405 auto options =
4406 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4407 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4408 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004409 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004410 EXPECT_EQ(err, GetCapturedStderr());
4411}
4412
4413TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4414 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4415 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4416 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4417 auto options =
4418 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4419 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004420 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004421 EXPECT_EQ("", GetCapturedStderr());
4422}
4423
Jooyung Hane9f5b272021-01-07 00:18:11 +09004424TEST_P(AidlTest, UnknownConstReference) {
4425 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4426 auto options =
4427 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4428 const string err =
4429 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4430 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4431 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4432 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004433 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004434 EXPECT_EQ(err, GetCapturedStderr());
4435}
4436
Jooyung Han29813842020-12-08 01:28:03 +09004437TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4438 string contents = R"(
4439import android.os.IBinder;
4440import android.os.IInterface;
4441interface IFoo {}
4442 )";
4443 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004444}
4445
Jooyung Han888c5bc2020-12-22 17:28:47 +09004446TEST_P(AidlTest, WarningInterfaceName) {
4447 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004448 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004449 " -Weverything -o out -h out p/Foo.aidl");
4450 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004451 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004452 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004453 GetCapturedStderr());
4454}
4455
4456TEST_P(AidlTest, ErrorInterfaceName) {
4457 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004458 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004459 " -Weverything -Werror -o out -h out p/Foo.aidl");
4460 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004461 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004462 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004463 GetCapturedStderr());
4464}
4465
Jiyong Park9f4c3822021-04-07 20:36:45 +09004466TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4467 const std::string input_file = "base/p/q/IFoo.aidl";
4468 const std::string header_dir = "out/";
4469 const std::string output_file = "out/base/p/q/IFoo.cpp";
4470 const std::string package = "p.q"; // not base.p.q
4471 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4472
4473 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4474 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004475 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004476 EXPECT_THAT(
4477 GetCapturedStderr(),
4478 testing::StartsWith(
4479 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4480 "but is out/base/p/q/IFoo.cpp."));
4481}
4482
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004483TEST_F(AidlTest, FormatCommentsForJava) {
4484 using android::aidl::FormatCommentsForJava;
4485
4486 struct TestCase {
4487 vector<Comment> comments;
4488 string formatted;
4489 };
4490 vector<TestCase> testcases = {
4491 {{}, ""},
4492 {{{"// line comments\n"}}, "// line comments\n"},
4493 {{{"// @hide \n"}}, "// @hide \n"},
4494 // Transform the last block comment as Javadoc.
4495 {{{"/*\n"
4496 " * Hello, world!\n"
4497 " */"}},
4498 "/**\n"
4499 " * Hello, world!\n"
4500 " */"},
4501 {{{"/* @hide */"}}, "/** @hide */"},
4502 {{{"/**\n"
4503 " @param foo ...\n"
4504 "*/"}},
4505 "/**\n"
4506 " @param foo ...\n"
4507 "*/"},
4508 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4509 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4510 "/* @deprecated first *//** @deprecated second */"},
4511 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4512 // Line comments are printed as they are
4513 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4514 };
4515 for (const auto& [input, formatted] : testcases) {
4516 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4517 }
4518}
4519
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004520TEST_F(AidlTest, HideIsNotForArgs) {
4521 io_delegate_.SetFileContents("IFoo.aidl",
4522 "interface IFoo {\n"
4523 " void foo(in @Hide int x);\n"
4524 "}");
4525 auto options = Options::From("aidl --lang=java IFoo.aidl");
4526 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004527 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004528 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4529}
4530
4531TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4532 io_delegate_.SetFileContents(
4533 "IFoo.aidl",
4534 "interface IFoo {\n"
4535 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4536 "}");
4537 auto options = Options::From("aidl --lang=java IFoo.aidl");
4538 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004539 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004540 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4541}
4542
Jooyung Hanfa181932021-06-12 07:56:53 +09004543TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4544 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4545 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4546 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004547 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004548 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4549}
4550
Jooyung Hanfd3be322020-12-13 09:11:06 +09004551struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004552 string kind;
4553 string literal;
4554};
4555
Jooyung Hanfd3be322020-12-13 09:11:06 +09004556const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004557 {"primitive", "int"}, {"primitiveArray", "int[]"},
4558 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004559 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4560 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4561 {"union", "a.Union"}, {"interface", "a.IBar"},
4562};
4563
4564const std::map<std::string, std::string> kListSupportExpectations = {
4565 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4566 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4567 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4568 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004569 {"cpp_primitiveArray", "List of arrays is not supported."},
4570 {"java_primitiveArray", "List of arrays is not supported."},
4571 {"ndk_primitiveArray", "List of arrays is not supported."},
4572 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004573 {"cpp_String", ""},
4574 {"java_String", ""},
4575 {"ndk_String", ""},
4576 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004577 {"cpp_StringArray", "List of arrays is not supported."},
4578 {"java_StringArray", "List of arrays is not supported."},
4579 {"ndk_StringArray", "List of arrays is not supported."},
4580 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004581 {"cpp_IBinder", ""},
4582 {"java_IBinder", ""},
4583 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4584 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004585 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004586 {"java_ParcelFileDescriptor", ""},
4587 {"ndk_ParcelFileDescriptor", ""},
4588 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004589 {"cpp_interface", "List<a.IBar> is not supported."},
4590 {"java_interface", "List<a.IBar> is not supported."},
4591 {"ndk_interface", "List<a.IBar> is not supported."},
4592 {"rust_interface", "List<a.IBar> is not supported."},
4593 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004594 {"java_parcelable", ""},
4595 {"ndk_parcelable", ""},
4596 {"rust_parcelable", ""},
4597 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4598 {"java_enum", "A generic type cannot have any primitive type parameters."},
4599 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4600 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004601 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004602 {"java_union", ""},
4603 {"ndk_union", ""},
4604 {"rust_union", ""},
4605};
4606
Jooyung Hand236e552020-12-13 09:21:27 +09004607const std::map<std::string, std::string> kArraySupportExpectations = {
4608 {"cpp_primitive", ""},
4609 {"java_primitive", ""},
4610 {"ndk_primitive", ""},
4611 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004612 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4613 {"java_primitiveArray", "Can only have one dimensional arrays."},
4614 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4615 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004616 {"cpp_String", ""},
4617 {"java_String", ""},
4618 {"ndk_String", ""},
4619 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004620 {"cpp_StringArray", "Can only have one dimensional arrays."},
4621 {"java_StringArray", "Can only have one dimensional arrays."},
4622 {"ndk_StringArray", "Can only have one dimensional arrays."},
4623 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004624 {"cpp_IBinder", ""},
4625 {"java_IBinder", ""},
4626 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4627 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4628 {"cpp_ParcelFileDescriptor", ""},
4629 {"java_ParcelFileDescriptor", ""},
4630 {"ndk_ParcelFileDescriptor", ""},
4631 {"rust_ParcelFileDescriptor", ""},
4632 {"cpp_interface", "Binder type cannot be an array"},
4633 {"java_interface", "Binder type cannot be an array"},
4634 {"ndk_interface", "Binder type cannot be an array"},
4635 {"rust_interface", "Binder type cannot be an array"},
4636 {"cpp_parcelable", ""},
4637 {"java_parcelable", ""},
4638 {"ndk_parcelable", ""},
4639 {"rust_parcelable", ""},
4640 {"cpp_enum", ""},
4641 {"java_enum", ""},
4642 {"ndk_enum", ""},
4643 {"rust_enum", ""},
4644 {"cpp_union", ""},
4645 {"java_union", ""},
4646 {"ndk_union", ""},
4647 {"rust_union", ""},
4648};
4649
Jooyung Hanfd3be322020-12-13 09:11:06 +09004650class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004651 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004652 void Run(const std::string& generic_type_decl,
4653 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004654 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004655 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004656 const auto& kind = std::get<1>(param).kind;
4657
4658 FakeIoDelegate io;
4659 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4660 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4661 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004662 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4663 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004664
4665 const auto options =
4666 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4667 CaptureStderr();
4668 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004669 auto it = expectations.find(lang + "_" + kind);
4670 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004671 const string err = GetCapturedStderr();
4672 if (it->second.empty()) {
4673 EXPECT_EQ("", err);
4674 } else {
4675 EXPECT_THAT(err, testing::HasSubstr(it->second));
4676 }
4677 }
4678};
4679
4680INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004681 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004682 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4683 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004684 testing::ValuesIn(kTypeParams)),
4685 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004686 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004687 });
4688
Jooyung Hanfd3be322020-12-13 09:11:06 +09004689TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4690 Run("List<{}>", kListSupportExpectations);
4691}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004692
Jooyung Hand236e552020-12-13 09:21:27 +09004693TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4694 Run("{}[]", kArraySupportExpectations);
4695}
4696
Christopher Wiley90be4e32015-10-20 14:55:25 -07004697} // namespace aidl
4698} // namespace android