blob: da4f035e7bbb39cb92ac49725ebcc96f3022a6a6 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Christopher Wileyf8136192016-04-12 14:19:35 -070081} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070082
Devin Moore7b8d5c92020-03-17 14:14:08 -070083class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070084 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090085 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
86 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070087 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070088 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090089 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070090 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090091 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 for (const string& s : additional_arguments) {
93 args.emplace_back(s);
94 }
95 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090096 args.emplace_back("--preprocessed=" + f);
97 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -070098 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--include=" + i);
100 }
101 args.emplace_back(path);
102 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900103 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900104 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700105 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900106 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900107
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 if (error != nullptr) {
109 *error = actual_error;
110 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900111
112 if (actual_error != AidlError::OK) {
113 return nullptr;
114 }
115
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900116 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900117 EXPECT_EQ(1ul, defined_types.size());
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700120 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700121
Devin Moore7b8d5c92020-03-17 14:14:08 -0700122 Options::Language GetLanguage() { return GetParam(); }
123
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800125 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900126 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900127 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700128};
129
Devin Moore7b8d5c92020-03-17 14:14:08 -0700130// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
131// tests with each of the supported languages as a parameter.
132INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
133 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700134 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900136 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 });
138
139TEST_P(AidlTest, AcceptMissingPackage) {
140 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700141}
142
Devin Moore7b8d5c92020-03-17 14:14:08 -0700143TEST_P(AidlTest, EndsInSingleLineComment) {
144 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700145}
146
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000147TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
148 const string expected_stderr =
149 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
150 const std::string file_contents = "package a; interface IBar {}";
151 CaptureStderr();
152 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
153 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
154}
155
156TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
157 const string expected_stderr =
158 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
159 const std::string file_contents = "package a; interface Bar {}";
160 CaptureStderr();
161 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
162 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
163}
164
165TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
166 const string expected_stderr =
167 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
168 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
169 CaptureStderr();
170 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
171 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
172}
173
174TEST_P(AidlTest, EnumRequiresCorrectPath) {
175 const string expected_stderr =
176 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
177 const std::string file_contents = "package a; enum Bar { A, }";
178 CaptureStderr();
179 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
180 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
181}
182
Devin Moore7b8d5c92020-03-17 14:14:08 -0700183TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900184 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700185 io_delegate_.SetFileContents("bar/IBar.aidl",
186 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700187 const string path = "foo/IFoo.aidl";
188 const string contents =
189 "package foo;\n"
190 "import bar.IBar;\n"
191 "interface IFoo { void f(in IBar[] input); }";
192 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
193 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700194 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700195 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700196}
197
Devin Moore7b8d5c92020-03-17 14:14:08 -0700198TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700199 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900201}
Devin Moore097a3ab2020-03-11 16:08:44 -0700202
Jiyong Park40782d02020-07-24 19:17:43 +0900203TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
205 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900206 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
207 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700208 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700209 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900211}
212
Jiyong Park40782d02020-07-24 19:17:43 +0900213TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700214 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
215 const string expected_stderr =
216 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 CaptureStderr();
218 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
219 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900220}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700221
Jiyong Park40782d02020-07-24 19:17:43 +0900222TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700223 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900224 const string expected_stderr =
225 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700226 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700227 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700229}
230
Devin Moore7b8d5c92020-03-17 14:14:08 -0700231TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700232 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
233 const string expected_stderr =
234 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
235 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700238}
239
Devin Moore7b8d5c92020-03-17 14:14:08 -0700240TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700241 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
242 const string expected_stderr =
243 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
244 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800247}
248
Devin Moore2f2077a2020-08-28 11:27:53 -0700249TEST_P(AidlTest, AcceptNullableList) {
250 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
251 const string expected_stderr = "";
252 CaptureStderr();
253 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
254 EXPECT_EQ(expected_stderr, GetCapturedStderr());
255}
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700258 const string method = "package a; interface IFoo { void f(int a, int a); }";
259 const string expected_stderr =
260 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
261 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700264}
265
Jeongik Cha13066da2020-08-06 15:43:19 +0900266TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
267 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900268 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
272}
273
Jooyung Hand902a972020-10-23 17:32:44 +0900274TEST_P(AidlTest, RejectsRepeatedAnnotations) {
275 const string method = R"(@Hide @Hide parcelable Foo {})";
276 const string expected_stderr =
277 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
278 "Foo.aidl:1.1-6\n";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
282}
283
Devin Moore7b8d5c92020-03-17 14:14:08 -0700284TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700285 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
286 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
287 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700288 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100290}
291
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 AidlError error;
294 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900297 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700298 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800299}
300
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 AidlError error;
303 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700307 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 AidlError error;
312 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700313 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000314 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000321 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700322 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700325 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800326}
327
Jiyong Park40782d02020-07-24 19:17:43 +0900328TEST_P(AidlTest, ParsesNonNullableAnnotation) {
329 auto parse_result =
330 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
331 ASSERT_NE(nullptr, parse_result);
332 const AidlInterface* interface = parse_result->AsInterface();
333 ASSERT_NE(nullptr, interface);
334 ASSERT_FALSE(interface->GetMethods().empty());
335 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
336}
337
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900339 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
340 typenames_, GetLanguage());
341 ASSERT_NE(nullptr, parse_result);
342 const AidlInterface* interface = parse_result->AsInterface();
343 ASSERT_NE(nullptr, interface);
344 ASSERT_FALSE(interface->GetMethods().empty());
345 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
346}
347
348TEST_P(AidlTest, ParsesNonUtf8Annotations) {
349 auto parse_result =
350 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
351 ASSERT_NE(nullptr, parse_result);
352 const AidlInterface* interface = parse_result->AsInterface();
353 ASSERT_NE(nullptr, interface);
354 ASSERT_FALSE(interface->GetMethods().empty());
355 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900359 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
360 typenames_, GetLanguage());
361 ASSERT_NE(nullptr, parse_result);
362 const AidlInterface* interface = parse_result->AsInterface();
363 ASSERT_NE(nullptr, interface);
364 ASSERT_FALSE(interface->GetMethods().empty());
365 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700369 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700370 const string expected_stderr =
371 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
372 "\"vintf\"'\n"
373 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
374 "--structured\n";
375 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700376 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700377 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700379 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700380}
381
Devin Moore7b8d5c92020-03-17 14:14:08 -0700382TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700383 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700384 const string expected_stderr =
385 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
386 "--structured\n";
387 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700391 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392}
393
Devin Moore7b8d5c92020-03-17 14:14:08 -0700394TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700395 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 const string expected_stderr =
397 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
398 "\"vintf\"'\n";
399 CaptureStderr();
400 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700401 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700403 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700407 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
409 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700410 ASSERT_EQ(AidlError::OK, error);
411 ASSERT_NE(nullptr, parse_result);
412 const AidlInterface* interface = parse_result->AsInterface();
413 ASSERT_NE(nullptr, interface);
414 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700415}
416
Jeongik Cha64783ed2019-06-07 18:30:54 +0900417TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
418 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900419 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
420 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900421 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700422 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900423 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900424 "a/Foo.aidl",
425 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900426
427 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900428 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700429 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900430 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700431 "Parcelable must be defined in AIDL directly.\n";
432 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900433 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700435
436 CaptureStderr();
437 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900439}
440
Jooyung Han1cbc4962020-10-25 10:07:15 +0900441TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
442 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
443 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
444 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900445 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
446
447 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900448 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900449 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
450
451 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900452 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900453 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
454
Jooyung Han1cbc4962020-10-25 10:07:15 +0900455 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900456 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
457}
458
Jooyung Han1cbc4962020-10-25 10:07:15 +0900459TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
460 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
461 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
462 CaptureStderr();
463 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
464 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
465 EXPECT_EQ("", GetCapturedStderr());
466
467 const string expected_to_string_method = R"--(
468 @Override
469 public String toString() {
470 switch (_tag) {
471 case a: return "a.Foo.a(" + (getA()) + ")";
472 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
473 }
474 throw new IllegalStateException("unknown field: " + _tag);
475 }
476)--";
477
478 string java_out;
479 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
480 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
481}
482
Jiyong Park9aa3d042020-12-04 23:30:02 +0900483TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
484 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
485 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
486 CaptureStderr();
487 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
488 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
489 EXPECT_EQ("", GetCapturedStderr());
490
491 const std::string expected = R"--(
492 @Override
493 public boolean equals(Object other) {
494 if (this == other) return true;
495 if (other == null) return false;
496 if (!(other instanceof Foo)) return false;
497 Foo that = (Foo)other;
498 if (!java.util.Objects.deepEquals(a, that.a)) return false;
499 if (!java.util.Objects.deepEquals(b, that.b)) return false;
500 return true;
501 }
502
503 @Override
504 public int hashCode() {
505 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
506 }
507)--";
508
509 string java_out;
510 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
511 EXPECT_THAT(java_out, testing::HasSubstr(expected));
512}
513
514TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
515 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
516 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
517 CaptureStderr();
518 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
519 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
520 EXPECT_EQ("", GetCapturedStderr());
521
522 const std::string expected = R"--(
523 @Override
524 public boolean equals(Object other) {
525 if (this == other) return true;
526 if (other == null) return false;
527 if (!(other instanceof Foo)) return false;
528 Foo that = (Foo)other;
529 if (_tag != that._tag) return false;
530 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
531 return true;
532 }
533
534 @Override
535 public int hashCode() {
536 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
537 }
538)--";
539
540 string java_out;
541 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
542 EXPECT_THAT(java_out, testing::HasSubstr(expected));
543}
544
Jooyung Han90345002020-10-23 15:28:53 +0900545TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900546 {
Jooyung Han90345002020-10-23 15:28:53 +0900547 io_delegate_.SetFileContents("a/Foo.aidl",
548 "package a; @JavaDerive(blah=true) parcelable Foo{}");
549 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
550 CaptureStderr();
551 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
552 const std::string expected_stderr =
553 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900554 EXPECT_THAT(GetCapturedStderr(),
555 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900556 }
557
558 {
559 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900560 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
561 CaptureStderr();
562 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900563 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900564 }
565
566 {
Jooyung Han90345002020-10-23 15:28:53 +0900567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900571 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900572 }
573}
574
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900575TEST_P(AidlTest, ParseDescriptorAnnotation) {
576 AidlError error;
577 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
578 typenames_, GetLanguage(), &error, {"--structured"});
579 ASSERT_EQ(AidlError::OK, error);
580 ASSERT_NE(nullptr, parse_result);
581 const AidlInterface* interface = parse_result->AsInterface();
582 ASSERT_NE(nullptr, interface);
583 ASSERT_EQ("IBar", interface->GetDescriptor());
584}
585
Jiyong Park40782d02020-07-24 19:17:43 +0900586TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700587 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700588 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900589}
590
591TEST_P(AidlTest, AcceptsOnewayInterface) {
592 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700593 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700594}
Christopher Wileyef140932015-11-03 09:29:19 -0800595
Devin Moore7b8d5c92020-03-17 14:14:08 -0700596TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700597 const string oneway_method =
598 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700599 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100600}
601
Steven Moreland65297cc2020-04-20 20:17:36 -0700602TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
603 const string oneway_method =
604 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
605 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
606 ASSERT_NE(nullptr, defined);
607 const AidlInterface* iface = defined->AsInterface();
608 ASSERT_NE(nullptr, iface);
609
610 const auto& methods = iface->GetMethods();
611 ASSERT_EQ(1u, methods.size());
612 const auto& method = methods[0];
613 const AidlTypeSpecifier& ret_type = method->GetType();
614
615 // TODO(b/151102494): these annotations should be on the method
616 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
617 ASSERT_TRUE(ret_type.IsHide());
618}
619
Devin Moore7b8d5c92020-03-17 14:14:08 -0700620TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100621 string foo_interface =
622 "package a; /* foo */ interface IFoo {"
623 " /* i */ int i();"
624 " /* j */ @nullable String j();"
625 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
626
Devin Moore7b8d5c92020-03-17 14:14:08 -0700627 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100628 EXPECT_NE(nullptr, parse_result);
629 EXPECT_EQ("/* foo */", parse_result->GetComments());
630
631 const AidlInterface* interface = parse_result->AsInterface();
632 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
633 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
634 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
635}
636
Jooyung Han1a551d32020-10-05 15:37:26 +0900637TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
638 io_delegate_.SetFileContents("p/cpp_header.aidl",
639 R"(package p;
640 parcelable cpp_header cpp_header "bar/header";)");
641 import_paths_.emplace("");
642 const string input_path = "p/IFoo.aidl";
643 const string input = R"(package p;
644 import p.cpp_header;
645 interface IFoo {
646 // get bar
647 cpp_header get();
648 })";
649
650 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
651 EXPECT_NE(nullptr, parse_result);
652 const AidlInterface* interface = parse_result->AsInterface();
653 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
654}
655
Christopher Wileyef140932015-11-03 09:29:19 -0800656TEST_F(AidlTest, ParsesPreprocessedFile) {
657 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
658 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700659 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900660 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700661 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
662 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800663}
664
665TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
666 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
667 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900668
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700669 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900670 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700671 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
672 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800673}
674
Devin Moore7b8d5c92020-03-17 14:14:08 -0700675TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800676 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
677 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
678 "interface IBar {}");
679 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900680 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900681 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800683 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900684
Christopher Wiley41544372015-11-03 14:52:29 -0800685 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700686 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
687 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800688 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700689 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900690 ambiguous_type.Resolve(typenames_);
691 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800692}
693
Jiyong Park8f6ec462020-01-19 20:52:47 +0900694// Special case of PreferImportToPreprocessed. Imported type should be preferred
695// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700696TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900697 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
698 io_delegate_.SetFileContents("one/IBar.aidl",
699 "package one; "
700 "interface IBar {}");
701 preprocessed_files_.push_back("preprocessed");
702 import_paths_.emplace("");
703 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700704 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900705 EXPECT_NE(nullptr, parse_result);
706
707 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700708 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
709 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900710 // But if we request just "IBar" we should get our imported one.
711 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
712 ambiguous_type.Resolve(typenames_);
713 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
714}
715
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800716TEST_F(AidlTest, WritePreprocessedFile) {
717 io_delegate_.SetFileContents("p/Outer.aidl",
718 "package p; parcelable Outer.Inner;");
719 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
720 "interface IBar {}");
721
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900722 vector<string> args {
723 "aidl",
724 "--preprocess",
725 "preprocessed",
726 "p/Outer.aidl",
727 "one/IBar.aidl"};
728 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800729 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
730
731 string output;
732 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
733 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
734}
735
Jooyung Han720253d2021-01-05 19:13:17 +0900736TEST_P(AidlTest, SupportDeprecated) {
737 struct TestCase {
738 std::string output_file;
739 std::string annotation;
740 };
741
742 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900743 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900744 io_delegate_.SetFileContents(filename, contents);
745
746 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
747 " --out=out --header_out=out");
748 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900749 for (const auto& [lang, test_case] : expectations) {
750 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900751 string output;
752 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output))
753 << base::Join(io_delegate_.ListOutputFiles(), ",");
754 EXPECT_THAT(output, HasSubstr(test_case.annotation));
755 }
756 };
757
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900758 // Emit escaped string for notes
759 CheckDeprecated(
760 "IFoo.aidl",
761 R"(interface IFoo {
762 /**
763 * @note asdf
764 * @deprecated a really long deprecation message
765 *
766 * which is really long
767 * @param foo bar
768 */
769 List<String> foo();
770 })",
771 {
772 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
773 {Options::Language::CPP,
774 {"out/IFoo.h",
775 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
776 {Options::Language::NDK,
777 {"out/aidl/IFoo.h",
778 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
779 {Options::Language::RUST,
780 {"out/IFoo.rs",
781 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
782 });
783
784 // In AIDL @deprecated can be in any style of comments
785 CheckDeprecated(
786 "IFoo.aidl",
787 "interface IFoo {\n"
788 " // @deprecated use bar()\n"
789 " List<String> foo();\n"
790 "}",
791 {
792 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
793 // TODO(b/177276893) @deprecated should be in javadoc style comments
794 // {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
795 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
796 {Options::Language::NDK,
797 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
798 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
799 });
Jooyung Han720253d2021-01-05 19:13:17 +0900800
801 CheckDeprecated("Foo.aidl",
802 "parcelable Foo {\n"
803 " /** @deprecated use bar*/\n"
804 " int foo = 0;\n"
805 "}",
806 {
807 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
808 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
809 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
810 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
811 });
812
813 CheckDeprecated("IFoo.aidl",
814 "interface IFoo {\n"
815 " /** @deprecated use bar*/\n"
816 " const int FOO = 0;\n"
817 "}",
818 {
819 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
820 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
821 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
822 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
823 });
824
825 // union fields
826 CheckDeprecated("Foo.aidl",
827 "union Foo {\n"
828 " int bar = 0;\n"
829 " /** @deprecated use bar*/\n"
830 " int foo;\n"
831 "}",
832 {
833 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
834 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
835 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
836 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
837 });
838
839 CheckDeprecated("Foo.aidl",
840 "/** @deprecated use Bar */\n"
841 "parcelable Foo {}",
842 {
843 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
844 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
845 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
846 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
847 });
848
849 CheckDeprecated("Foo.aidl",
850 "/** @deprecated use Bar */\n"
851 "union Foo { int foo = 0; }",
852 {
853 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
854 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
855 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
856 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
857 });
858
859 CheckDeprecated("IFoo.aidl",
860 "/** @deprecated use IBar */\n"
861 "interface IFoo {}",
862 {
863 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
864 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
865 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
866 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
867 });
868
869 CheckDeprecated("Foo.aidl",
870 "/** @deprecated use IBar */\n"
871 "enum Foo { FOO }",
872 {
873 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
874 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
875 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
876 // TODO(b/174514415) support "deprecated"
877 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
878 });
879}
880
Devin Moore7b8d5c92020-03-17 14:14:08 -0700881TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700882 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800883 io_delegate_.SetFileContents("p/Outer.aidl",
884 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900885 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700886 CaptureStderr();
887 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
888 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700889 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700890 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800891}
892
Devin Moore7b8d5c92020-03-17 14:14:08 -0700893TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800894 io_delegate_.SetFileContents("preprocessed",
895 "parcelable p.Outer.Inner;");
896 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900897 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700898 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800899 // TODO(wiley): This should actually return nullptr because we require
900 // the outer class name. However, for legacy reasons,
901 // this behavior must be maintained. b/17415692
902 EXPECT_NE(nullptr, parse_result);
903}
904
Christopher Wiley632801d2015-11-05 14:15:49 -0800905TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 const string expected_foo_stderr =
907 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
908 "Declared parcelables should be in their own file and/or cannot be used with --structured "
909 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700910 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
911
Christopher Wiley632801d2015-11-05 14:15:49 -0800912 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700913 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700914 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900915 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700916 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900917
Steven Morelande2c64b42018-09-18 15:06:37 -0700918 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900919 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700920 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900921 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700923
Devin Moore097a3ab2020-03-11 16:08:44 -0700924 const string expected_bar_stderr =
925 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
926 "Declared parcelables should be in their own file and/or cannot be used with --structured "
927 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700928 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
929
Jiyong Parkda8c6932019-08-12 19:56:08 +0900930 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700931 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900933 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700935 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700937 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800939}
940
Devin Moore7b8d5c92020-03-17 14:14:08 -0700941TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 const string expected_stderr =
943 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
944 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700945 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
946 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700947 AidlError error;
948 CaptureStderr();
949 EXPECT_EQ(
950 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700951 Parse("p/IFoo.aidl",
952 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700953 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
955 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700956}
957
Devin Moore7b8d5c92020-03-17 14:14:08 -0700958TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700959 AidlError error;
960 const string expected_stderr =
961 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
962 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900963 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
964 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700965 interface IFoo {
966 const String DUPLICATED = "d";
967 const int DUPLICATED = 1;
968 }
969 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700970 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
972 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700973}
974
Steven Morelande689da22020-11-10 02:06:30 +0000975TEST_P(AidlTest, FailOnTooBigConstant) {
976 AidlError error;
977 const string expected_stderr =
978 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
979 CaptureStderr();
980 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
981 R"(package p;
982 interface IFoo {
983 const byte type2small = 256;
984 }
985 )",
986 typenames_, GetLanguage(), &error));
987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
988 EXPECT_EQ(AidlError::BAD_TYPE, error);
989}
990
Jooyung Han30f64ad2020-12-15 08:16:31 +0900991TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
992 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
993 CaptureStderr();
994 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
995 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
996 EXPECT_EQ("", GetCapturedStderr());
997 string code;
998 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
999 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1000}
1001
Jooyung Han535c5e82020-12-29 15:16:59 +09001002TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001003 using Ptr = unique_ptr<AidlConstantValue>;
1004 const AidlLocation& loc = AIDL_LOCATION_HERE;
1005
Jooyung Han535c5e82020-12-29 15:16:59 +09001006 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1007 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1008 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1009 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001010
1011 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1012 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001013 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001014
1015 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1016 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1017 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1018 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001019 EXPECT_EQ(
1020 expected,
1021 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001022}
1023
Devin Moore7b8d5c92020-03-17 14:14:08 -07001024TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001025 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001026 const string expected_stderr =
1027 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001028 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001029 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1030 R"(package p;
1031 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001032 parcelable IBar {}
1033 parcelable StructuredParcelable {}
1034 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001035 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001036 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001038 // Parse success is important for clear error handling even if the cases aren't
1039 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001040 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001041}
1042
Devin Moore7b8d5c92020-03-17 14:14:08 -07001043TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001044 AidlError error;
1045 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1046 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001047 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001048 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1049 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001050}
1051
Steven Morelandf9e922f2020-07-08 21:15:27 +00001052TEST_P(AidlTest, FailOnEmptyListWithComma) {
1053 AidlError error;
1054 const string expected_stderr =
1055 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1056 CaptureStderr();
1057 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1058 typenames_, GetLanguage(), &error));
1059 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1060 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1061}
1062
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001064 AidlError error;
1065 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001066 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001067 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001068 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1069 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001070 interface IFoo {
1071 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1072 }
1073 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001074 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1076 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001077}
1078
Jiyong Park18132182020-06-08 20:24:40 +09001079TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1080 AidlError error;
1081 const string expected_stderr =
1082 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1083 "cpp_header (which can also be used as an identifier)\n";
1084 CaptureStderr();
1085 // Notice the trailing dot(.) in the name, which isn't a correct name
1086 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1087 GetLanguage(), &error));
1088 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1089 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1090}
1091
1092TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1093 AidlError error;
1094 const string expected_stderr =
1095 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1096 "cpp_header (which can also be used as an identifier)\n";
1097 CaptureStderr();
1098 // Notice the trailing dot(.) in the package name
1099 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1100 GetLanguage(), &error));
1101 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1102 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1103}
1104
Devin Moore7b8d5c92020-03-17 14:14:08 -07001105TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001106 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001107 auto parse_result = Parse("p/IFoo.aidl",
1108 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001109 interface IFoo {
1110 const int POSITIVE_HEX_VALUE = 0xf5;
1111 }
1112 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001113 typenames_, GetLanguage(), &error);
1114 EXPECT_NE(nullptr, parse_result);
1115 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001116 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001117 const auto& cpp_constants = interface->GetConstantDeclarations();
1118 EXPECT_EQ((size_t)1, cpp_constants.size());
1119 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001120 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001121 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001122}
1123
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001125 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001126 auto parse_result = Parse("p/IFoo.aidl",
1127 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001128 interface IFoo {
1129 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1130 }
1131 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001132 typenames_, GetLanguage(), &error);
1133 ASSERT_NE(nullptr, parse_result);
1134 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001135 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001136 const auto& cpp_constants = interface->GetConstantDeclarations();
1137 EXPECT_EQ((size_t)1, cpp_constants.size());
1138 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001139 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001140 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001141}
1142
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001144 io_delegate_.SetFileContents(
1145 "p/Outer.aidl",
1146 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001147 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001148 const string input_path = "p/IFoo.aidl";
1149 const string input = "package p; import p.Outer; interface IFoo"
1150 " { Outer.Inner get(); }";
1151
Devin Moore7b8d5c92020-03-17 14:14:08 -07001152 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1153 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001154
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001155 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001156 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001157 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1158 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001159}
1160
Devin Moore7b8d5c92020-03-17 14:14:08 -07001161TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001162 io_delegate_.SetFileContents(
1163 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001164 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001165 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001166 const string input_path = "p/IFoo.aidl";
1167 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001168 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1169 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001170 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001171 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1172 native_type.Resolve(typenames_);
1173
1174 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1175 // C++ understands C++ specific stuff
1176 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1177 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001178 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001179 EXPECT_EQ(1u, headers.size());
1180 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001181}
1182
Christopher Wileyf8136192016-04-12 14:19:35 -07001183TEST_F(AidlTest, WritesCorrectDependencyFile) {
1184 // While the in tree build system always gives us an output file name,
1185 // other android tools take advantage of our ability to infer the intended
1186 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001187 vector<string> args = {
1188 "aidl",
1189 "-d dep/file/path",
1190 "-o place/for/output",
1191 "p/IFoo.aidl"};
1192 Options options = Options::From(args);
1193 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001194 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001195 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001196 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001197 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1198}
1199
Dan Willemsen93298ee2016-11-10 23:55:55 -08001200TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1201 // While the in tree build system always gives us an output file name,
1202 // other android tools take advantage of our ability to infer the intended
1203 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001204 vector<string> args = {
1205 "aidl",
1206 "-d dep/file/path",
1207 "--ninja",
1208 "-o place/for/output",
1209 "p/IFoo.aidl"};
1210 Options options = Options::From(args);
1211 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001212 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001213 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001214 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001215 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1216}
1217
Jiyong Parkdf202122019-09-30 20:48:35 +09001218TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001219 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1220 // this by calling aidl with every .aidl file it finds, then parsing the
1221 // generated dependency files. Those that reference .java output files are
1222 // for interfaces and those that do not are parcelables. However, for both
1223 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001224 vector<string> args = {
1225 "aidl",
1226 "-o place/for/output",
1227 "-d dep/file/path",
1228 "p/Foo.aidl"};
1229 Options options = Options::From(args);
1230 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001231 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001232 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001233 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001234 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1235}
1236
1237TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1238 vector<string> args = {
1239 "aidl",
1240 "--structured",
1241 "-o place/for/output",
1242 "-d dep/file/path",
1243 "p/Foo.aidl"};
1244 Options options = Options::From(args);
1245 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1246 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1247 string actual_dep_file_contents;
1248 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1249 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001250}
1251
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001252TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1253 vector<string> args = {
1254 "aidl",
1255 "--lang=java",
1256 "-o place/for/output",
1257 "p/Foo.aidl"};
1258 Options options = Options::From(args);
1259 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1260 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1261 string output_file_contents;
1262 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1263}
1264
Devin Moore21b26772020-08-26 16:37:56 -07001265TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001266 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001267 const string list_array_parcelable =
1268 "package a; parcelable Foo {\n"
1269 " List[] lists; }";
1270 CaptureStderr();
1271 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1272 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1273}
1274
Jiyong Parkf8d53612020-05-04 14:06:13 +09001275TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1276 AidlError error;
1277 string expected_stderr =
1278 "ERROR: a/IFoo.aidl:2.7-11: "
1279 "Encountered an untyped List or Map. The use of untyped List/Map is "
1280 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1281 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1282 if (GetLanguage() != Options::Language::JAVA) {
1283 expected_stderr =
1284 "ERROR: a/IFoo.aidl:2.1-7: "
1285 "Currently, only the Java backend supports non-generic List.\n";
1286 }
1287
1288 const string primitive_interface =
1289 "package a; interface IFoo {\n"
1290 " List foo(); }";
1291 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001292 AidlTypenames tn1;
1293 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001294 {"--structured"}));
1295 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001296
1297 string primitive_parcelable =
1298 "package a; parcelable IFoo {\n"
1299 " List foo;}";
1300 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001301 AidlTypenames tn2;
1302 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001303 {"--structured"}));
1304 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1305}
1306
Jeongik Cha225519b2020-08-29 01:55:32 +09001307TEST_P(AidlTest, ExtensionTest) {
1308 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001309 string extendable_parcelable =
1310 "package a; parcelable Data {\n"
1311 " ParcelableHolder extension;\n"
1312 " ParcelableHolder extension2;\n"
1313 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001314 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001315 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1316 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001317 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001318 "yet.\n",
1319 GetCapturedStderr());
1320 } else {
1321 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1322 EXPECT_EQ("", GetCapturedStderr());
1323 }
1324}
1325TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1326 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001327 string parcelableholder_return_interface =
1328 "package a; interface IFoo {\n"
1329 " ParcelableHolder foo();\n"
1330 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(nullptr,
1332 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001333
Jeongik Cha8f02a532020-10-14 00:16:28 +09001334 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001335 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001336 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001337 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001338 "yet.\n",
1339 GetCapturedStderr());
1340 return;
1341 }
1342 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1343 GetCapturedStderr());
1344}
1345
1346TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1347 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001348 string extendable_parcelable_arg_interface =
1349 "package a; interface IFoo {\n"
1350 " void foo(in ParcelableHolder ph);\n"
1351 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001352 EXPECT_EQ(nullptr,
1353 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1354
Jeongik Cha8f02a532020-10-14 00:16:28 +09001355 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001356 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001357 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001358 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001359 "yet.\n",
1360 GetCapturedStderr());
1361 return;
1362 }
1363 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1364 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001365}
1366
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001367TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1368 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001369 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001370 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1371 CaptureStderr();
1372 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1373 if (GetLanguage() == Options::Language::RUST) {
1374 EXPECT_EQ(
1375 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1376 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1377 "yet.\n",
1378 GetCapturedStderr());
1379 return;
1380 }
1381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1382}
1383
Jooyung Han3f347ca2020-12-01 12:41:50 +09001384TEST_P(AidlTest, ParcelablesWithConstants) {
1385 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001386 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001387 CaptureStderr();
1388 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1389 EXPECT_EQ("", GetCapturedStderr());
1390}
1391
1392TEST_P(AidlTest, UnionWithConstants) {
1393 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001394 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001395 CaptureStderr();
1396 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1397 EXPECT_EQ("", GetCapturedStderr());
1398}
1399
Jooyung Han633eab62021-01-07 14:12:40 +09001400TEST_F(AidlTest, ConstantsWithAnnotations) {
1401 io_delegate_.SetFileContents("IFoo.aidl",
1402 "interface IFoo {\n"
1403 " @JavaPassthrough(annotation=\"@Foo\")\n"
1404 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1405 "}");
1406 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1407 CaptureStderr();
1408 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1409 EXPECT_EQ("", GetCapturedStderr());
1410 string code;
1411 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1412 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1413 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1414}
1415
Jiyong Park02da7422018-07-16 16:00:26 +09001416TEST_F(AidlTest, ApiDump) {
1417 io_delegate_.SetFileContents(
1418 "foo/bar/IFoo.aidl",
1419 "package foo.bar;\n"
1420 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001421 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001422 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001423 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001424 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1425 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1426 " IFoo foo3(IFoo foo);\n"
1427 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001428 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001429 " const int A = 1;\n"
1430 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001431 "}\n");
1432 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1433 "package foo.bar;\n"
1434 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001435 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001436 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001437 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001438 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001439 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001440 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001441 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001442 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001443 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001444 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001445 "}\n");
1446 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001447 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1448 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001449 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001450 bool result = dump_api(options, io_delegate_);
1451 ASSERT_TRUE(result);
1452 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001453 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001454 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001455/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001456interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001457 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001458 int foo(out int[] a, String b, boolean c, inout List<String> d);
1459 int foo2(@utf8InCpp String x, inout List<String> y);
1460 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1461 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001462 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001463 const int A = 1;
1464 const String STR = "Hello";
1465}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001466)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001467
Jiyong Parke59c3682018-09-11 23:10:25 +09001468 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001469 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001470/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001471parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001472 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001473 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001474 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001475 int y;
1476 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001477 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001478 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001479}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001480)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001481}
1482
Jiyong Parked65bf42018-08-28 15:43:27 +09001483TEST_F(AidlTest, ApiDumpWithManualIds) {
1484 io_delegate_.SetFileContents(
1485 "foo/bar/IFoo.aidl",
1486 "package foo.bar;\n"
1487 "interface IFoo {\n"
1488 " int foo() = 1;\n"
1489 " int bar() = 2;\n"
1490 " int baz() = 10;\n"
1491 "}\n");
1492
Jiyong Parke59c3682018-09-11 23:10:25 +09001493 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001494 Options options = Options::From(args);
1495 bool result = dump_api(options, io_delegate_);
1496 ASSERT_TRUE(result);
1497 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001498 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001499 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001500interface IFoo {
1501 int foo() = 1;
1502 int bar() = 2;
1503 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001504}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001505)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001506}
1507
1508TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001509 const string expected_stderr =
1510 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1511 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001512 io_delegate_.SetFileContents(
1513 "foo/bar/IFoo.aidl",
1514 "package foo.bar;\n"
1515 "interface IFoo {\n"
1516 " int foo() = 1;\n"
1517 " int bar();\n"
1518 " int baz() = 10;\n"
1519 "}\n");
1520
Jiyong Parke59c3682018-09-11 23:10:25 +09001521 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001522 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001523 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001524 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001525 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001526}
1527
Jooyung Han965e31d2020-11-27 12:30:16 +09001528TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1529 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1530 "package foo.bar;\n"
1531 "interface IFoo {\n"
1532 " @utf8InCpp String foo();\n"
1533 " const @utf8InCpp String bar = \"bar\";\n"
1534 "}\n");
1535
1536 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1537 Options options = Options::From(args);
1538 CaptureStderr();
1539 EXPECT_TRUE(dump_api(options, io_delegate_));
1540 EXPECT_EQ("", GetCapturedStderr());
1541 string actual;
1542 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001543 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1544interface IFoo {
1545 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001546 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001547}
1548)"),
1549 actual);
1550}
1551
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001552TEST_F(AidlTest, ApiDumpWithEnums) {
1553 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1554 "package foo.bar;\n"
1555 "enum Enum {\n"
1556 " FOO,\n"
1557 " BAR = FOO + 1,\n"
1558 "}\n");
1559
1560 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1561 Options options = Options::From(args);
1562 CaptureStderr();
1563 EXPECT_TRUE(dump_api(options, io_delegate_));
1564 EXPECT_EQ("", GetCapturedStderr());
1565 string actual;
1566 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1567 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1568 "enum Enum {\n"
1569 " FOO = 0,\n"
1570 " BAR = 1,\n"
1571 "}\n"),
1572 actual);
1573}
1574
1575TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1576 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1577 "package foo.bar;\n"
1578 "enum Enum {\n"
1579 " FOO,\n"
1580 "}\n");
1581 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1582 "package foo.bar;\n"
1583 "import foo.bar.Enum;\n"
1584 "parcelable Foo {\n"
1585 " Enum e = Enum.FOO;\n"
1586 "}\n");
1587
1588 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1589 Options options = Options::From(args);
1590 CaptureStderr();
1591 EXPECT_TRUE(dump_api(options, io_delegate_));
1592 EXPECT_EQ("", GetCapturedStderr());
1593 string actual;
1594 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1595 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1596 "parcelable Foo {\n"
1597 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1598 "}\n"),
1599 actual);
1600}
1601
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001602TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001603 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001604 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1605 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001606 const string expected_map_stderr =
1607 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001608 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1609 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001610 "package p; interface IFoo {"
1611 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001612 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001613 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001614 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001615
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001616 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001617 "package p; interface IFoo {"
1618 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001619 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001620 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001621 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001622}
1623
Jeongik Chae48d9942020-01-02 17:39:00 +09001624TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001625 const string expected_stderr =
1626 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001627 Options options = Options::From("aidl -I p p/IFoo.aidl");
1628 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1629
1630 io_delegate_.SetFileContents("p/IFoo.aidl",
1631 "package p; interface IFoo {"
1632 "Map<String, Bar> foo();}");
1633 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1634
1635 io_delegate_.SetFileContents("p/IFoo.aidl",
1636 "package p; interface IFoo {"
1637 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001639 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001640 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001641
1642 io_delegate_.SetFileContents("p/IFoo.aidl",
1643 "package p; interface IFoo {"
1644 "Map<String, String> foo();}");
1645 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1646
1647 io_delegate_.SetFileContents("p/IFoo.aidl",
1648 "package p; interface IFoo {"
1649 "Map<String, ParcelFileDescriptor> foo();}");
1650 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1651}
1652
Jeongik Chadf76dc72019-11-28 00:08:47 +09001653TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001654 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001655 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1656 io_delegate_.SetFileContents(options.InputFiles().front(),
1657 "package p; interface IFoo {"
1658 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001659 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001660 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001662}
1663
1664TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1665 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1666 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001667 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001668 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001669 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1670 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001671
1672 Options options = Options::From("aidl -I p p/IFoo.aidl");
1673 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1674 io_delegate_.SetFileContents("p/IFoo.aidl",
1675 "package p; interface IFoo {"
1676 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001677 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001678 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001679 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001680 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001681 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001682 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001683 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1684 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001685 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1686 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1687 io_delegate_.SetFileContents("p/IFoo.aidl",
1688 "package p; interface IFoo {"
1689 "Bar<String, ParcelFileDescriptor> foo();}");
1690 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001691
1692 io_delegate_.SetFileContents("p/IFoo.aidl",
1693 "package p; interface IFoo {"
1694 "Bar<int, long> foo();}");
1695
1696 io_delegate_.SetFileContents("p/IFoo.aidl",
1697 "package p; interface IFoo {"
1698 "Bar<int[], long[]> foo();}");
1699
1700 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001701}
1702
Jeongik Cha0e426012019-07-29 15:57:02 +09001703TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1704 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001705 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1706 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001707 for (const auto& rawOption : rawOptions) {
1708 string expected_stderr =
1709 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001710 Options options = Options::From(rawOption);
1711 io_delegate_.SetFileContents(options.InputFiles().front(),
1712 "package foo.bar;\n"
1713 "interface IFoo1 { int foo(); }\n"
1714 "interface IFoo2 { int foo(); }\n"
1715 "parcelable Data1 { int a; int b;}\n"
1716 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001717 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001718 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001719 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001720
Jeongik Cha0e426012019-07-29 15:57:02 +09001721 io_delegate_.SetFileContents(options.InputFiles().front(),
1722 "package foo.bar;\n"
1723 "interface IFoo1 { int foo(); }\n"
1724 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001725 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001726 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001727 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001728
Devin Moore5de18ed2020-04-02 13:52:29 -07001729 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001730 io_delegate_.SetFileContents(options.InputFiles().front(),
1731 "package foo.bar;\n"
1732 "parcelable Data1 { int a; int b;}\n"
1733 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001734 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001735 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001736 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001737 }
1738}
1739
Devin Moorebdba2a82020-03-31 15:19:02 -07001740TEST_P(AidlTest, FailParseOnEmptyFile) {
1741 const string contents = "";
1742 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1743 CaptureStderr();
1744 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1746}
1747
Jiyong Parkb034bf02018-07-30 17:44:33 +09001748TEST_F(AidlTest, MultipleInputFiles) {
1749 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001750 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001751
1752 io_delegate_.SetFileContents(options.InputFiles().at(0),
1753 "package foo.bar;\n"
1754 "import foo.bar.Data;\n"
1755 "interface IFoo { Data getData(); }\n");
1756
1757 io_delegate_.SetFileContents(options.InputFiles().at(1),
1758 "package foo.bar;\n"
1759 "import foo.bar.IFoo;\n"
1760 "parcelable Data { IFoo foo; }\n");
1761
1762 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1763
1764 string content;
1765 for (const auto file : {
1766 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1767 content.clear();
1768 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1769 EXPECT_FALSE(content.empty());
1770 }
1771}
1772
1773TEST_F(AidlTest, MultipleInputFilesCpp) {
1774 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001775 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001776
1777 io_delegate_.SetFileContents(options.InputFiles().at(0),
1778 "package foo.bar;\n"
1779 "import foo.bar.Data;\n"
1780 "interface IFoo { Data getData(); }\n");
1781
1782 io_delegate_.SetFileContents(options.InputFiles().at(1),
1783 "package foo.bar;\n"
1784 "import foo.bar.IFoo;\n"
1785 "parcelable Data { IFoo foo; }\n");
1786
1787 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1788
1789 string content;
1790 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001791 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001792 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1793 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1794 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1795 content.clear();
1796 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1797 EXPECT_FALSE(content.empty());
1798 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001799}
1800
Andrei Homescub62afd92020-05-11 19:24:59 -07001801TEST_F(AidlTest, MultipleInputFilesRust) {
1802 Options options =
1803 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1804
1805 io_delegate_.SetFileContents(options.InputFiles().at(0),
1806 "package foo.bar;\n"
1807 "import foo.bar.Data;\n"
1808 "interface IFoo { Data getData(); }\n");
1809
1810 io_delegate_.SetFileContents(options.InputFiles().at(1),
1811 "package foo.bar;\n"
1812 "import foo.bar.IFoo;\n"
1813 "parcelable Data { IFoo foo; }\n");
1814
1815 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1816
1817 string content;
1818 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1819 content.clear();
1820 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1821 EXPECT_FALSE(content.empty());
1822 }
1823}
1824
Devin Moore097a3ab2020-03-11 16:08:44 -07001825TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1826 const string expected_stderr =
1827 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001828 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1829 // int getInterfaceVersion() is one of the meta transactions
1830 io_delegate_.SetFileContents(options.InputFiles().front(),
1831 "package p; interface IFoo {"
1832 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001833 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001834 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001835 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1836}
Jiyong Park309668e2018-07-28 16:55:44 +09001837
Devin Moore097a3ab2020-03-11 16:08:44 -07001838TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1839 // boolean getInterfaceVersion() is not a meta transaction, but should be
1840 // prevented because return type is not part of a method signature
1841 const string expected_stderr =
1842 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1843 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001844 io_delegate_.SetFileContents(options.InputFiles().front(),
1845 "package p; interface IFoo {"
1846 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001847 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001848 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001849 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1850}
Jiyong Park309668e2018-07-28 16:55:44 +09001851
Devin Moore097a3ab2020-03-11 16:08:44 -07001852TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001853 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001854 const string expected_stderr =
1855 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1856 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001857 io_delegate_.SetFileContents(options.InputFiles().front(),
1858 "package p; interface IFoo {"
1859 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001860 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001861 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001862 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001863
1864 // this is not a meta interface method as it differs type arguments
1865 io_delegate_.SetFileContents(options.InputFiles().front(),
1866 "package p; interface IFoo {"
1867 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001868 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001869}
1870
Daniel Norman85aed542019-08-21 12:01:14 -07001871TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001872 Options options = Options::From("aidl --checkapi old new");
1873 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1874 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1875 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1876 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1877
1878 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1879}
1880
Jiyong Park3656c3c2018-08-01 20:02:01 +09001881TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001882 Options options = Options::From("aidl --checkapi old new");
1883 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1884 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001885
1886 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1887}
1888
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001889TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1890 Options options = Options::From("aidl --checkapi old new");
1891 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1892 const string enum_definition = "package p; enum Enum { FOO }";
1893 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1894 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1895 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1896 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1897
1898 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1899}
1900
Daniel Norman85aed542019-08-21 12:01:14 -07001901class AidlTestCompatibleChanges : public AidlTest {
1902 protected:
1903 Options options_ = Options::From("aidl --checkapi old new");
1904};
1905
1906TEST_F(AidlTestCompatibleChanges, NewType) {
1907 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1908 "package p;"
1909 "interface IFoo {"
1910 " void foo(int a);"
1911 "}");
1912 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1913 "package p;"
1914 "interface IFoo {"
1915 " void foo(int a);"
1916 "}");
1917 io_delegate_.SetFileContents("new/p/IBar.aidl",
1918 "package p;"
1919 "interface IBar {"
1920 " void bar();"
1921 "}");
1922 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1923}
1924
1925TEST_F(AidlTestCompatibleChanges, NewMethod) {
1926 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1927 "package p;"
1928 "interface IFoo {"
1929 " void foo(int a);"
1930 "}");
1931 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1932 "package p;"
1933 "interface IFoo {"
1934 " void foo(int a);"
1935 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001936 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001937 "}");
1938 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1939}
1940
1941TEST_F(AidlTestCompatibleChanges, NewField) {
1942 io_delegate_.SetFileContents("old/p/Data.aidl",
1943 "package p;"
1944 "parcelable Data {"
1945 " int foo;"
1946 "}");
1947 io_delegate_.SetFileContents("new/p/Data.aidl",
1948 "package p;"
1949 "parcelable Data {"
1950 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001951 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001952 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001953 "}");
1954 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1955}
1956
1957TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1958 io_delegate_.SetFileContents("old/p/Enum.aidl",
1959 "package p;"
1960 "enum Enum {"
1961 " FOO = 1,"
1962 "}");
1963 io_delegate_.SetFileContents("new/p/Enum.aidl",
1964 "package p;"
1965 "enum Enum {"
1966 " FOO = 1,"
1967 " BAR = 2,"
1968 "}");
1969 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1970}
1971
1972TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1973 io_delegate_.SetFileContents("old/p/Enum.aidl",
1974 "package p;"
1975 "enum Enum {"
1976 " FOO = 1,"
1977 " BAR = 2,"
1978 "}");
1979 io_delegate_.SetFileContents("new/p/Enum.aidl",
1980 "package p;"
1981 "enum Enum {"
1982 " BAR = 2,"
1983 " FOO = 1,"
1984 "}");
1985 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1986}
1987
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001988TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1989 io_delegate_.SetFileContents("old/p/Union.aidl",
1990 "package p;"
1991 "union Union {"
1992 " String foo;"
1993 "}");
1994 io_delegate_.SetFileContents("new/p/Union.aidl",
1995 "package p;"
1996 "union Union {"
1997 " String foo;"
1998 " int num;"
1999 "}");
2000 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2001}
2002
Daniel Norman85aed542019-08-21 12:01:14 -07002003TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002004 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2005 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002006 "interface IFoo {"
2007 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002008 "}");
2009 io_delegate_.SetFileContents("old/p/Data.aidl",
2010 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002011 "parcelable Data {"
2012 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002013 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002014 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2015 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002016 "interface IFoo {"
2017 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002018 "}");
2019 io_delegate_.SetFileContents("new/p/Data.aidl",
2020 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002021 "parcelable Data {"
2022 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002023 "}");
2024 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2025 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002026 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002027 " void foo(int a);"
2028 "}");
2029 io_delegate_.SetFileContents("new/q/Data.aidl",
2030 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002031 "parcelable Data {"
2032 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002033 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002034 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2035}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002036
Daniel Norman85aed542019-08-21 12:01:14 -07002037TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2038 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2039 "package p;"
2040 "interface IFoo {"
2041 " void foo(int a);"
2042 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002043 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2044 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002045 "interface IFoo {"
2046 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002047 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002048 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2049}
Jiyong Parke59c3682018-09-11 23:10:25 +09002050
Daniel Norman85aed542019-08-21 12:01:14 -07002051TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002052 io_delegate_.SetFileContents("old/p/I.aidl",
2053 "package p; interface I {"
2054 "const int A = 1; }");
2055 io_delegate_.SetFileContents("new/p/I.aidl",
2056 "package p ; interface I {"
2057 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002058 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2059}
Jiyong Parka428d212018-08-29 22:26:30 +09002060
Daniel Norman85aed542019-08-21 12:01:14 -07002061TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002062 io_delegate_.SetFileContents("old/p/I.aidl",
2063 "package p; interface I {"
2064 "const int A = 1; const int B = 2;}");
2065 io_delegate_.SetFileContents("new/p/I.aidl",
2066 "package p ; interface I {"
2067 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002068 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002069}
2070
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002071TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2072 io_delegate_.SetFileContents("old/p/Foo.aidl",
2073 "package p;"
2074 "@JavaPassthrough(annotation=\"Alice\")"
2075 "@JavaPassthrough(annotation=\"Bob\")"
2076 "parcelable Foo {}");
2077 io_delegate_.SetFileContents("new/p/Foo.aidl",
2078 "package p;"
2079 "@JavaPassthrough(annotation=\"Bob\")"
2080 "@JavaPassthrough(annotation=\"Alice\")"
2081 "parcelable Foo {}");
2082 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2083}
2084
Jooyung Han00073272020-11-27 14:20:20 +09002085TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2086 io_delegate_.SetFileContents("old/p/Foo.aidl",
2087 "package p;"
2088 "parcelable Foo {}");
2089 io_delegate_.SetFileContents("new/p/Foo.aidl",
2090 "package p;"
2091 "@JavaPassthrough(annotation=\"@Deprecated\")"
2092 "parcelable Foo {}");
2093 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2094}
2095
Jooyung Han636fd2f2020-10-22 11:33:45 +09002096TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2097 io_delegate_.SetFileContents("old/p/Data.aidl",
2098 "package p;"
2099 "parcelable Data {"
2100 " int num;"
2101 "}");
2102 io_delegate_.SetFileContents(
2103 "new/p/Data.aidl",
2104 "package p;"
2105 "parcelable Data {"
2106 " int num;"
2107 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2108 "}");
2109 io_delegate_.SetFileContents("new/p/Enum.aidl",
2110 "package p;"
2111 "enum Enum {"
2112 " FOO = 0,"
2113 " BAR = 1,"
2114 "}");
2115 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2116}
2117
Daniel Norman85aed542019-08-21 12:01:14 -07002118class AidlTestIncompatibleChanges : public AidlTest {
2119 protected:
2120 Options options_ = Options::From("aidl --checkapi old new");
2121};
2122
2123TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002124 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002125 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2126 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002127 "interface IFoo {"
2128 " void foo(in String[] str);"
2129 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002130 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002131 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002132 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002134}
2135
2136TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002137 const string expected_stderr =
2138 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002139 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2140 "package p;"
2141 "interface IFoo {"
2142 " void foo(in String[] str);"
2143 " void bar(@utf8InCpp String str);"
2144 "}");
2145 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2146 "package p;"
2147 "interface IFoo {"
2148 " void foo(in String[] str);"
2149 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002150 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002151 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002153}
2154
Jiyong Parkf8d53612020-05-04 14:06:13 +09002155TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2156 const string expected_stderr =
2157 "ERROR: new/p/IFoo.aidl:1.61-65: "
2158 "Encountered an untyped List or Map. The use of untyped List/Map is "
2159 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2160 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2161 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2162 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2163 "package p;"
2164 "interface IFoo {"
2165 " void foo(in String[] str);"
2166 "}");
2167 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2168 "package p;"
2169 "interface IFoo {"
2170 " void foo(in String[] str);"
2171 " void bar(in List arg);"
2172 "}");
2173 CaptureStderr();
2174 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2175 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2176}
2177
2178TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2179 const string expected_stderr =
2180 "ERROR: new/p/Data.aidl:1.54-59: "
2181 "Encountered an untyped List or Map. The use of untyped List/Map is "
2182 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2183 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2184 "ERROR: new/p/Data.aidl: Failed to read.\n";
2185 io_delegate_.SetFileContents("old/p/Data.aidl",
2186 "package p;"
2187 "parcelable Data {"
2188 " int foo;"
2189 "}");
2190 io_delegate_.SetFileContents("new/p/Data.aidl",
2191 "package p;"
2192 "parcelable Data {"
2193 " int foo;"
2194 " @nullable List list;"
2195 "}");
2196 CaptureStderr();
2197 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2199}
2200
Daniel Norman85aed542019-08-21 12:01:14 -07002201TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002202 const string expected_stderr =
2203 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002204 io_delegate_.SetFileContents("old/p/Data.aidl",
2205 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002206 "parcelable Data {"
2207 " int foo;"
2208 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002209 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002210 io_delegate_.SetFileContents("new/p/Data.aidl",
2211 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002212 "parcelable Data {"
2213 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002214 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002215 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002216 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002217 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002218}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002219
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002220TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2221 const string expected_stderr =
2222 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2223 "backends. Please either provide a default value for this field or mark the field as "
2224 "@nullable. This value or a null value will be used automatically when an old version of "
2225 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2226 "order to make sure your code continues to be backwards compatible, make sure the default or "
2227 "null value does not cause a semantic change to this parcelable.\n";
2228 io_delegate_.SetFileContents("old/p/Data.aidl",
2229 "package p;"
2230 "parcelable Data {"
2231 " int num;"
2232 "}");
2233 io_delegate_.SetFileContents("new/p/Data.aidl",
2234 "package p;"
2235 "parcelable Data {"
2236 " int num;"
2237 " String str;"
2238 "}");
2239 CaptureStderr();
2240 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2241 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2242}
2243
Jooyung Han636fd2f2020-10-22 11:33:45 +09002244TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2245 const string expected_stderr =
2246 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2247 "Please make sure 'Enum' has '0' as a valid value.\n";
2248 io_delegate_.SetFileContents("old/p/Data.aidl",
2249 "package p;"
2250 "parcelable Data {"
2251 " int num;"
2252 "}");
2253 io_delegate_.SetFileContents("new/p/Data.aidl",
2254 "package p;"
2255 "parcelable Data {"
2256 " int num;"
2257 " p.Enum e;"
2258 "}");
2259 io_delegate_.SetFileContents("new/p/Enum.aidl",
2260 "package p;"
2261 "enum Enum {"
2262 " FOO = 1,"
2263 " BAR = 2,"
2264 "}");
2265 CaptureStderr();
2266 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2267 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2268}
2269
Daniel Norman85aed542019-08-21 12:01:14 -07002270TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002271 const string expected_stderr =
2272 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002273 io_delegate_.SetFileContents("old/p/Enum.aidl",
2274 "package p;"
2275 "enum Enum {"
2276 " FOO = 1,"
2277 " BAR = 2,"
2278 "}");
2279 io_delegate_.SetFileContents("new/p/Enum.aidl",
2280 "package p;"
2281 "enum Enum {"
2282 " BAR = 2,"
2283 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002284 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002285 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002286 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002287}
2288
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002289TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2290 const string expected_stderr =
2291 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2292 io_delegate_.SetFileContents("old/p/Union.aidl",
2293 "package p;"
2294 "union Union {"
2295 " String str;"
2296 " int num;"
2297 "}");
2298 io_delegate_.SetFileContents("new/p/Union.aidl",
2299 "package p;"
2300 "union Union {"
2301 " String str;"
2302 "}");
2303 CaptureStderr();
2304 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2305 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2306}
2307
Daniel Norman85aed542019-08-21 12:01:14 -07002308TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002309 const string expected_stderr =
2310 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002311 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2312 "package p;"
2313 "interface IFoo {"
2314 " void foo(in String[] str);"
2315 " void bar(@utf8InCpp String str);"
2316 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002317 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2318 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002319 "interface IFoo {"
2320 " void foo(in String[] str);"
2321 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002322 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002323 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002324 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002326}
2327
Daniel Norman85aed542019-08-21 12:01:14 -07002328TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002330 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2331 "package p;"
2332 "interface IFoo {"
2333 " void foo(in String[] str);"
2334 " void bar(@utf8InCpp String str);"
2335 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002336 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2337 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002338 "interface IFoo2 {"
2339 " void foo(in String[] str);"
2340 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002341 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002342 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002343 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002345}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002346
Daniel Norman85aed542019-08-21 12:01:14 -07002347TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002348 const string expected_stderr =
2349 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002350 io_delegate_.SetFileContents("old/p/Enum.aidl",
2351 "package p;"
2352 "enum Enum {"
2353 " FOO = 1,"
2354 " BAR = 2,"
2355 "}");
2356 io_delegate_.SetFileContents("new/p/Enum.aidl",
2357 "package p;"
2358 "enum Enum {"
2359 " FOO = 3,"
2360 " BAR = 2,"
2361 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002363 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002365}
2366
2367TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002368 const string expected_stderr =
2369 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2370 "from 0 to 1.\n"
2371 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2372 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002373 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2374 "package p;"
2375 "interface IFoo {"
2376 " void foo(in String[] str);"
2377 " void bar(@utf8InCpp String str);"
2378 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002379 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2380 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002381 "interface IFoo {"
2382 " void bar(@utf8InCpp String str);"
2383 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002384 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002385 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002386 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002388}
2389
2390TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002391 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002392 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2393 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002394 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002395 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002396 "parcelable Data {"
2397 " int foo;"
2398 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002399 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002400 io_delegate_.SetFileContents("new/p/Data.aidl",
2401 "package p;"
2402 "parcelable Data {"
2403 " int bar;"
2404 " int foo;"
2405 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002407 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002409}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002410
Daniel Norman85aed542019-08-21 12:01:14 -07002411TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002412 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002413 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002414 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002415 "interface IFoo {"
2416 " void foo(in String[] str);"
2417 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002418 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002419 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2420 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002421 "interface IFoo {"
2422 " void foo(out String[] str);"
2423 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002424 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002425 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002426 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002428}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002429
Daniel Norman85aed542019-08-21 12:01:14 -07002430TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002431 const string expected_stderr =
2432 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002433 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2434 "package p;"
2435 "interface IFoo {"
2436 " void foo(in String[] str);"
2437 " void bar(@utf8InCpp String str);"
2438 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002439 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2440 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002441 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002442 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002443 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002444 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002445 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002446 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002447 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002448}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002449
Daniel Norman85aed542019-08-21 12:01:14 -07002450TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002451 const string expected_stderr =
2452 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002453 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2454 "package p;"
2455 "interface IFoo {"
2456 " void foo(in String[] str);"
2457 " void bar(@utf8InCpp String str);"
2458 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002459 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2460 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002461 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002462 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002463 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002464 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002465 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002466 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002468}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002469
Jooyung Han60b2fde2020-10-29 15:12:40 +09002470TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2471 const string expected_stderr =
2472 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2473 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2474 io_delegate_.SetFileContents("old/p/Foo.aidl",
2475 "package p;"
2476 "@Backing(type=\"byte\")"
2477 "enum Foo {"
2478 " FOO, BAR,"
2479 "}");
2480 io_delegate_.SetFileContents("new/p/Foo.aidl",
2481 "package p;"
2482 "@Backing(type=\"long\")"
2483 "enum Foo {"
2484 " FOO, BAR,"
2485 "}");
2486 CaptureStderr();
2487 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2488 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2489}
2490
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002491TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2492 const string expected_stderr =
2493 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2494 "to @JavaPassthrough(annotation=\"Bob\")\n";
2495 io_delegate_.SetFileContents("old/p/Foo.aidl",
2496 "package p;"
2497 "@JavaPassthrough(annotation=\"Alice\")"
2498 "parcelable Foo {}");
2499 io_delegate_.SetFileContents("new/p/Foo.aidl",
2500 "package p;"
2501 "@JavaPassthrough(annotation=\"Bob\")"
2502 "parcelable Foo {}");
2503
2504 CaptureStderr();
2505 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2507}
2508
Devin Mooredb7ac512020-08-07 11:17:36 -07002509TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2510 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002511 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002512 io_delegate_.SetFileContents("old/p/Foo.aidl",
2513 "package p;"
2514 "parcelable Foo {"
2515 " int A;"
2516 "}");
2517 io_delegate_.SetFileContents("new/p/Foo.aidl",
2518 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002519 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002520 " int A;"
2521 "}");
2522 CaptureStderr();
2523 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2524 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2525}
2526
2527TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2528 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002529 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002530 io_delegate_.SetFileContents("old/p/Foo.aidl",
2531 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002532 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002533 " int A;"
2534 "}");
2535 io_delegate_.SetFileContents("new/p/Foo.aidl",
2536 "package p;"
2537 "parcelable Foo {"
2538 " int A;"
2539 "}");
2540 CaptureStderr();
2541 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2542 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2543}
2544
Daniel Norman85aed542019-08-21 12:01:14 -07002545TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002546 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002547 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2548 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002549 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002550 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002551 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002552 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002553}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002554
Daniel Norman85aed542019-08-21 12:01:14 -07002555TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002556 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002557 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2558 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002559 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002560 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002562}
Jiyong Parka428d212018-08-29 22:26:30 +09002563
Daniel Norman85aed542019-08-21 12:01:14 -07002564TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 const string expected_stderr =
2566 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002567 io_delegate_.SetFileContents("old/p/I.aidl",
2568 "package p; interface I {"
2569 "const int A = 1; const int B = 2;}");
2570 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002571 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002572 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002573 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002574}
Jiyong Parka428d212018-08-29 22:26:30 +09002575
Daniel Norman85aed542019-08-21 12:01:14 -07002576TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 const string expected_stderr =
2578 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002579 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2580 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002581 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002582 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002583 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002584}
2585
Devin Moorec7e47a32020-08-07 10:55:25 -07002586TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2587 const string expected_stderr =
2588 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2589 "This is an incompatible change for FixedSize types.\n";
2590 io_delegate_.SetFileContents("old/p/Foo.aidl",
2591 "package p; @FixedSize parcelable Foo { int A = 1; }");
2592 io_delegate_.SetFileContents("new/p/Foo.aidl",
2593 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2594 CaptureStderr();
2595 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2596 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2597}
2598
2599TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2600 const string expected_stderr =
2601 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2602 io_delegate_.SetFileContents("old/p/Foo.aidl",
2603 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2604 io_delegate_.SetFileContents("new/p/Foo.aidl",
2605 "package p; @FixedSize parcelable Foo { int A = 1; }");
2606 CaptureStderr();
2607 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2608 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2609}
2610
2611TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2612 const string expected_stderr =
2613 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2614 "a.\n"
2615 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2616 "b.\n"
2617 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2618 "c.\n"
2619 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2620 "d.\n"
2621 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2622 "e.\n"
2623 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2624 "f.\n";
2625
2626 io_delegate_.SetFileContents("Foo.aidl",
2627 "@FixedSize parcelable Foo { "
2628 " int[] a;"
2629 " Bar b;"
2630 " String c;"
2631 " ParcelFileDescriptor d;"
2632 " IBinder e;"
2633 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002634 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002635 "}");
2636 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002637 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002638
2639 CaptureStderr();
2640 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2641 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2642}
2643
2644TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2645 const string expected_stderr = "";
2646
2647 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2648 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2649 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002650 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002651
2652 CaptureStderr();
2653 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2654 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2655}
2656
Jiyong Park8c380532018-08-30 14:55:26 +09002657TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002658 const string expected_stderr =
2659 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2660 "dir1/q/IBar.aidl\n"
2661 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002662 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002663 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2664 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2665 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2666 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2667
Devin Moore097a3ab2020-03-11 16:08:44 -07002668 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002669 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002670 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002671}
2672
Jiyong Parked65bf42018-08-28 15:43:27 +09002673TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002674 const string expected_stderr =
2675 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2676 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002677 Options options = Options::From("aidl --checkapi old new");
2678 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2679 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002680
2681 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2682
Jiyong Parke59c3682018-09-11 23:10:25 +09002683 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002684 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002685 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002686 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002687}
2688
Jiyong Parke05195e2018-10-08 18:24:23 +09002689TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2690 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2691 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002692 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002693
2694 // use without import
2695 io_delegate_.SetFileContents("p/IFoo.aidl",
2696 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2697 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2698 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002699 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002700
Devin Moore7b8d5c92020-03-17 14:14:08 -07002701 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002702 io_delegate_.SetFileContents(
2703 "p/IFoo.aidl",
2704 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2705 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2706 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002707 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002708
2709 // use with import (as before)
2710 io_delegate_.SetFileContents("p/IFoo.aidl",
2711 "package p;"
2712 "import android.os.ParcelFileDescriptor;"
2713 "interface IFoo{"
2714 " void foo(in ParcelFileDescriptor fd);"
2715 "}");
2716 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2717 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002718 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002719}
Jiyong Parked65bf42018-08-28 15:43:27 +09002720
Jiyong Park3633b722019-04-11 15:38:26 +09002721TEST_F(AidlTest, ManualIds) {
2722 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2723 io_delegate_.SetFileContents("IFoo.aidl",
2724 "interface IFoo {\n"
2725 " void foo() = 0;\n"
2726 " void bar() = 1;\n"
2727 "}");
2728 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2729}
2730
2731TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2732 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2733 io_delegate_.SetFileContents("IFoo.aidl",
2734 "interface IFoo {\n"
2735 " void foo() = 0;\n"
2736 " void bar() = 1;\n"
2737 "}");
2738 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2739}
2740
2741TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002742 const string expected_stderr =
2743 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002744 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2745 io_delegate_.SetFileContents("IFoo.aidl",
2746 "interface IFoo {\n"
2747 " void foo() = 3;\n"
2748 " void bar() = 3;\n"
2749 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002750 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002751 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002752 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002753}
2754
2755TEST_F(AidlTest, FailOnOutOfRangeIds) {
2756 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002757 const string expected_stderr =
2758 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2759 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002760 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2761 io_delegate_.SetFileContents("IFoo.aidl",
2762 "interface IFoo {\n"
2763 " void foo() = 3;\n"
2764 " void bar() = 16777115;\n"
2765 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002766 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002767 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002768 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002769}
2770
2771TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002772 const string expected_stderr =
2773 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002774 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2775 io_delegate_.SetFileContents("IFoo.aidl",
2776 "interface IFoo {\n"
2777 " void foo() = 3;\n"
2778 " void bar();\n"
2779 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002780 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002781 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002782 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002783}
2784
Jiyong Parkc6816252019-07-08 08:12:28 +09002785TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2786 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2787 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2788 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2789 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2790}
2791
2792TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002793 const string expected_stderr =
2794 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2795 "dir/IBar.aidl\n"
2796 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002797 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002798
Jiyong Parkc6816252019-07-08 08:12:28 +09002799 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2800 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2801 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2802 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002803 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002804 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002805 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002806}
2807
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002808TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2809 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2810 "package a.b;\n"
2811 "import a.b.IBar;\n"
2812 "import a.b.IQux;\n"
2813 "interface IFoo { IQux foo(); }\n");
2814 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2815 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2816
2817 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2818 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2819
2820 string output;
2821 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2822 // IBar was imported but wasn't used. include is not expected.
2823 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2824 // IBar was imported and used. include is expected.
2825 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2826}
2827
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002828TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002829 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002830 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002831 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2832 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002833 interface IFoo {
2834 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002835 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002836 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002837 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002838 // JavaPassthrough should work with other types as well (e.g. enum)
2839 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2840 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2841 @JavaPassthrough(annotation="@com.android.AliceTwo")
2842 @Backing(type="byte")
2843 enum MyEnum {
2844 a, b, c
2845 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002846
Jooyung Han4cde01d2020-10-13 11:10:47 +09002847 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002848 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2849
2850 string java_out;
2851 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002852 // type-decl-level annotations with newline at the end
2853 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2854 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2855 // member-decl-level annotations with newline at the end
2856 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2857 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2858 // inline annotations with space at the end
2859 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002860
Jooyung Han4cde01d2020-10-13 11:10:47 +09002861 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2862 // type-decl-level annotations with newline at the end
2863 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2864 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2865
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002866 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002867 Options cpp_options =
2868 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002869 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2870
Jooyung Han4cde01d2020-10-13 11:10:47 +09002871 Options ndk_options =
2872 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002873 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002874
Jooyung Han4cde01d2020-10-13 11:10:47 +09002875 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002876 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002877}
2878
Andrei Homescue61feb52020-08-18 15:44:24 -07002879TEST_F(AidlTest, ParseRustDerive) {
2880 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2881 @RustDerive(Clone=true, Copy=false)
2882 parcelable Foo {
2883 int a;
2884 })");
2885
2886 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2887 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2888
2889 string rust_out;
2890 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2891 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2892
2893 // Other backends shouldn't be bothered
2894 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2895 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2896
2897 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2898 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2899
2900 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2901 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2902}
2903
Jiyong Park56f73d72019-06-11 12:20:28 +09002904class AidlOutputPathTest : public AidlTest {
2905 protected:
2906 void SetUp() override {
2907 AidlTest::SetUp();
2908 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2909 }
2910
2911 void Test(const Options& options, const std::string expected_output_path) {
2912 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2913 // check the existence
2914 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2915 }
2916};
2917
2918TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2919 // <out_dir> / <package_name> / <type_name>.java
2920 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2921}
2922
2923TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2924 // when output file is explicitly set, it is always respected. -o option is
2925 // ignored.
2926 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2927}
2928
2929TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2930 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2931}
2932
2933TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2934 // output is the same as the input file except for the suffix
2935 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2936}
2937
Devin Moore7b8d5c92020-03-17 14:14:08 -07002938TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002939 AidlError error;
2940 const string expected_stderr =
2941 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2942 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002943 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2944 R"(package p;
2945 interface IFoo {
2946 const int int32_max_oob = 2147483650;
2947 }
2948 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002949 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002950 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2951 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002952}
2953
Devin Moore7b8d5c92020-03-17 14:14:08 -07002954TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002955 AidlError error;
2956 const string expected_stderr =
2957 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2958 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002959 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2960 R"(package p;
2961 interface IFoo {
2962 const int int32_min_oob = -2147483650;
2963 }
2964 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002965 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2967 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002968}
2969
Devin Moore7b8d5c92020-03-17 14:14:08 -07002970TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002971 AidlError error;
2972 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002973 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002974 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002975 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2976 R"(package p;
2977 interface IFoo {
2978 const long int64_max_oob = 21474836509999999999999999;
2979 }
2980 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002981 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002982 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2983 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002984}
2985
Devin Moore7b8d5c92020-03-17 14:14:08 -07002986TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002987 AidlError error;
2988 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002989 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002990 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002991 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2992 R"(package p;
2993 interface IFoo {
2994 const long int64_min_oob = -21474836509999999999999999;
2995 }
2996 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002997 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002998 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2999 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003000}
3001
Devin Moore7b8d5c92020-03-17 14:14:08 -07003002TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003003 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003004 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003005 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003006 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3007 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003008 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3009 R"(package p;
3010 @Backing(type="byte")
3011 enum TestEnum {
3012 FOO = 127,
3013 BAR,
3014 }
3015 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003016 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003017 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003019}
3020
Devin Mooredecaf292020-04-30 09:16:40 -07003021TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3022 AidlError error;
3023 const string expected_stderr =
3024 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003025 "be one of: type\n";
3026 CaptureStderr();
3027 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3028 R"(package p;
3029 @Backing(foo="byte")
3030 enum TestEnum {
3031 FOO = 1,
3032 BAR,
3033 }
3034 )",
3035 typenames_, GetLanguage(), &error));
3036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3037 EXPECT_EQ(AidlError::BAD_TYPE, error);
3038}
3039
Jooyung Han5721a232020-12-24 04:34:55 +09003040TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3041 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3042 CaptureStderr();
3043 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3044 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3045}
3046
Jooyung Han66813932020-10-23 13:24:44 +09003047TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003048 io_delegate_.SetFileContents("Foo.aidl",
3049 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3050 "Map<String, Baz> d; Bar[] e; }");
3051 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3052 io_delegate_.SetFileContents("Baz.aidl",
3053 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003054 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3055 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3056}
3057
Jooyung Han66813932020-10-23 13:24:44 +09003058TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003059 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003060 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003061 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003062 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3063 "named 'bar'.\n";
3064 CaptureStderr();
3065 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3066 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3067 EXPECT_EQ(expected_error, GetCapturedStderr());
3068}
3069
3070TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3071 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3072 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3073 string expected_error =
3074 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003075 "named 'bar'.\n";
3076 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003077 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3078 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003079 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003080}
3081
Jooyung Han66813932020-10-23 13:24:44 +09003082TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003083 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003084 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3085 string expected_error =
3086 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3087 "only be an in parameter.\n";
3088 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003089 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3090 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003091 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003092}
3093
Jooyung Han66813932020-10-23 13:24:44 +09003094TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003095 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003096 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3097 string expected_error =
3098 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3099 "only be an in parameter.\n";
3100 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003101 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3102 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003103 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003104}
3105
Jooyung Han66813932020-10-23 13:24:44 +09003106TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003107 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003108 Options options = Options::From("aidl --lang=java Foo.aidl");
3109 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003110 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3111 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003112 CaptureStderr();
3113 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3114 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3115}
Devin Moore53fc99c2020-08-12 08:07:52 -07003116
Jooyung Hanfe89f122020-10-14 03:49:18 +09003117TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3118 const string method = "package a; union Foo {}";
3119 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3120 CaptureStderr();
3121 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3122 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3123}
3124
3125TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3126 const string method = "package a; union Foo { ParcelableHolder x; }";
3127 const string expected_stderr =
3128 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3129 CaptureStderr();
3130 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3131 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3132}
3133
Jooyung Han53fb4242020-12-17 16:03:49 +09003134TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3135 import_paths_.insert(".");
3136 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3137 const string expected_err = "The union's first member should have a useful default value.";
3138 CaptureStderr();
3139 EXPECT_EQ(nullptr,
3140 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3141 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3142}
3143
Devin Moore53fc99c2020-08-12 08:07:52 -07003144TEST_P(AidlTest, GenericStructuredParcelable) {
3145 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003146 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003147 const string expected_stderr = "";
3148 CaptureStderr();
3149 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3150 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3151}
3152
Jooyung Han3f347ca2020-12-01 12:41:50 +09003153TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3154 io_delegate_.SetFileContents("Foo.aidl",
3155 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3156 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003157 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003158 const string expected_stderr = "";
3159 CaptureStderr();
3160 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3161 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3162
3163 string code;
3164 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3165 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3166const ::android::String16& Foo<T,U>::s() {
3167 static const ::android::String16 value(::android::String16(""));
3168 return value;
3169})--"));
3170}
3171
3172TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3173 io_delegate_.SetFileContents("Foo.aidl",
3174 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3175 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003176 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003177 const string expected_stderr = "";
3178 CaptureStderr();
3179 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3180 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3181
3182 string code;
3183 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3184 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3185const char* Foo<T, U>::s = "";
3186)--"));
3187}
3188
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003189TEST_F(AidlTest, NestedTypeArgs) {
3190 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003191 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3192
3193 io_delegate_.SetFileContents("a/Foo.aidl",
3194 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3195 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003196 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3197 const string expected_stderr = "";
3198 CaptureStderr();
3199 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3201
3202 string code;
3203 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003204 EXPECT_THAT(code,
3205 testing::HasSubstr(
3206 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3207}
3208
3209TEST_F(AidlTest, DoubleArrayError) {
3210 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3211
3212 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3213 const string expected_stderr =
3214 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3215 CaptureStderr();
3216 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3217 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3218}
3219
3220TEST_F(AidlTest, DoubleGenericError) {
3221 io_delegate_.SetFileContents("a/Bar.aidl",
3222 "package a; parcelable Bar { List<String><String> a; }");
3223
3224 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3225 const string expected_stderr =
3226 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3227 CaptureStderr();
3228 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3229 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3230}
3231
3232TEST_F(AidlTest, ArrayBeforeGenericError) {
3233 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3234
3235 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3236 const string expected_stderr =
3237 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3238 CaptureStderr();
3239 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003241}
3242
Jooyung Han14004ed2020-10-16 03:49:57 +09003243struct GenericAidlTest : ::testing::Test {
3244 FakeIoDelegate io_delegate_;
3245 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003246 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003247 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3248 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3249 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3250
3251 Options options = Options::From(cmd);
3252 CaptureStderr();
3253 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3254 EXPECT_EQ("", GetCapturedStderr());
3255 }
3256};
3257
3258TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3259 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3260 string code;
3261 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3262 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3263 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3264 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3265}
3266
3267TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3268 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3269 string code;
3270 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3271 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3272 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3273 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3274}
3275
Devin Moore53fc99c2020-08-12 08:07:52 -07003276TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3277 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003278 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003279 const string expected_stderr =
3280 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3281 CaptureStderr();
3282 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3284}
3285
3286TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3287 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003288 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003289 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3290 CaptureStderr();
3291 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3293}
3294
Jooyung Han7a308842020-10-27 19:06:49 +09003295TEST_P(AidlTest, LongCommentWithinConstExpression) {
3296 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003297 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003298 CaptureStderr();
3299 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3300 EXPECT_EQ("", GetCapturedStderr());
3301}
3302
Jeongik Chaef44e622020-10-23 16:00:52 +09003303TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3304 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3305 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3306 std::string expectedErr =
3307 "ERROR: a/Foo.aidl:1.28-30: "
3308 "Encountered an untyped List or Map. The use of untyped List/Map is "
3309 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3310 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3311 "ERROR: a/Foo.aidl:1.35-37: "
3312 "Encountered an untyped List or Map. The use of untyped List/Map is "
3313 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3314 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3315 CaptureStderr();
3316 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3317 EXPECT_EQ(expectedErr, GetCapturedStderr());
3318}
3319
3320TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003321 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3322 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003323 std::string expectedErr =
3324 "ERROR: a/Foo.aidl:1.33-35: "
3325 "Encountered an untyped List or Map. The use of untyped List/Map is "
3326 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3327 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3328 "ERROR: a/Foo.aidl:1.40-42: "
3329 "Encountered an untyped List or Map. The use of untyped List/Map is "
3330 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3331 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003332 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003333 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3334 EXPECT_EQ(expectedErr, GetCapturedStderr());
3335}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003336
Jeongik Chaef44e622020-10-23 16:00:52 +09003337TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3338 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3339 io_delegate_.SetFileContents(
3340 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3341 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3342 std::string expectedErr =
3343 "ERROR: a/Foo.aidl:1.52-54: "
3344 "Encountered an untyped List or Map. The use of untyped List/Map is "
3345 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3346 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3347 "ERROR: a/Foo.aidl:1.64-66: "
3348 "Encountered an untyped List or Map. The use of untyped List/Map is "
3349 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3350 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3351 CaptureStderr();
3352 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3353 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003354}
3355
Jooyung Han690f5842020-12-04 13:02:04 +09003356TEST_F(AidlTest, EnumWithDefaults_Java) {
3357 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3358 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3359package p;
3360import p.Enum;
3361parcelable Foo {
3362 Enum e = Enum.BAR;
3363})");
3364 CaptureStderr();
3365 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3366 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3367 auto err = GetCapturedStderr();
3368 EXPECT_EQ("", err);
3369
3370 string code;
3371 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003372 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003373}
3374
3375TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3376 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3377 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3378package p;
3379import p.Enum;
3380parcelable Foo {
3381 Enum e = Enum.BAR;
3382})");
3383 CaptureStderr();
3384 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3385 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3386 auto err = GetCapturedStderr();
3387 EXPECT_EQ("", err);
3388
3389 string code;
3390 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3391 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3392}
3393
3394TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3395 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3396 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3397package p;
3398import p.Enum;
3399parcelable Foo {
3400 Enum e = Enum.BAR;
3401})");
3402 CaptureStderr();
3403 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3404 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3405 auto err = GetCapturedStderr();
3406 EXPECT_EQ("", err);
3407
3408 string code;
3409 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3410 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3411}
3412
3413TEST_F(AidlTest, EnumWithDefaults_Rust) {
3414 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3415 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3416package p;
3417import p.Enum;
3418parcelable Foo {
3419 int n = 42;
3420 Enum e = Enum.BAR;
3421})");
3422 CaptureStderr();
3423 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3424 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3425 auto err = GetCapturedStderr();
3426 EXPECT_EQ("", err);
3427
3428 string code;
3429 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3430 EXPECT_THAT(code, testing::HasSubstr(R"(
3431 fn default() -> Self {
3432 Self {
3433 n: 42,
3434 e: crate::mangled::_1_p_4_Enum::BAR,
3435 }
3436 })"));
3437}
3438
3439TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3440 import_paths_.insert("a");
3441 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3442 CaptureStderr();
3443 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3444package p;
3445import p.Enum;
3446parcelable Foo {
3447 int e = Enum.FOO | Enum.BAR;
3448})",
3449 typenames_, GetLanguage());
3450 auto err = GetCapturedStderr();
3451 EXPECT_EQ("", err);
3452 EXPECT_TRUE(type);
3453 const auto& fields = type->AsStructuredParcelable()->GetFields();
3454 EXPECT_EQ("int e = 3", fields[0]->ToString());
3455}
3456
3457TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3458 CaptureStderr();
3459 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3460@Backing(type="int")
3461enum Foo {
3462 STANDARD_SHIFT = 16,
3463 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3464 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3465}
3466)",
3467 typenames_, GetLanguage());
3468 auto err = GetCapturedStderr();
3469 EXPECT_EQ("", err);
3470 EXPECT_TRUE(type);
3471 const auto& enum_type = type->AsEnumDeclaration();
3472 string code;
3473 enum_type->Dump(CodeWriter::ForString(&code).get());
3474 EXPECT_EQ(R"--(@Backing(type="int")
3475enum Foo {
3476 STANDARD_SHIFT = 16,
3477 STANDARD_BT709 = 65536,
3478 STANDARD_BT601_625 = 131072,
3479}
3480)--",
3481 code);
3482}
3483
3484TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3485 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3486 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3487package p;
3488import p.Enum;
3489parcelable Foo {
3490 Enum e = Enum.FOO | Enum.BAR;
3491})");
3492 CaptureStderr();
3493 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3494 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3495 auto err = GetCapturedStderr();
3496 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3497 err);
3498}
3499
3500TEST_P(AidlTest, DefaultWithEmptyArray) {
3501 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3502 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3503 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003504 auto options =
3505 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003506 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3507 auto err = GetCapturedStderr();
3508 EXPECT_EQ("", err);
3509}
3510
3511TEST_P(AidlTest, RejectRefsInAnnotation) {
3512 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3513 "package p; interface IFoo {\n"
3514 " const String ANNOTATION = \"@Annotation\";\n"
3515 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3516 "}");
3517 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003518 auto options =
3519 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003520 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3521 auto err = GetCapturedStderr();
3522 EXPECT_EQ(
3523 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3524 "ANNOTATION.\n",
3525 err);
3526}
3527
3528TEST_F(AidlTest, DefaultWithEnumValues) {
3529 io_delegate_.SetFileContents(
3530 "a/p/Foo.aidl",
3531 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3532 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3533 CaptureStderr();
3534 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3535 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3536 auto err = GetCapturedStderr();
3537 EXPECT_EQ("", err);
3538 string code;
3539 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3540 EXPECT_THAT(
3541 code, testing::HasSubstr(
3542 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3543}
3544
Jooyung Han14259392020-12-07 10:00:08 +09003545TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3546 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3547 CaptureStderr();
3548 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3549 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3550 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003551 EXPECT_EQ(
3552 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3553 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3554 err);
Jooyung Han14259392020-12-07 10:00:08 +09003555}
3556
3557TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3558 io_delegate_.SetFileContents("a/p/Foo.aidl",
3559 "package p; parcelable Foo { const int A = A + 1; }");
3560 CaptureStderr();
3561 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3562 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3563 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003564 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3565}
3566
3567TEST_F(AidlTest, RecursiveReferences) {
3568 io_delegate_.SetFileContents("a/p/Foo.aidl",
3569 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3570 io_delegate_.SetFileContents("a/p/Bar.aidl",
3571 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3572 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3573 CaptureStderr();
3574 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3575 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3576 EXPECT_EQ("", GetCapturedStderr());
3577}
3578
Jooyung Hane9f5b272021-01-07 00:18:11 +09003579TEST_P(AidlTest, UnknownConstReference) {
3580 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3581 auto options =
3582 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3583 const string err =
3584 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3585 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3586 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3587 CaptureStderr();
3588 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3589 EXPECT_EQ(err, GetCapturedStderr());
3590}
3591
Jooyung Han29813842020-12-08 01:28:03 +09003592TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3593 string contents = R"(
3594import android.os.IBinder;
3595import android.os.IInterface;
3596interface IFoo {}
3597 )";
3598 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003599}
3600
Jooyung Han888c5bc2020-12-22 17:28:47 +09003601TEST_P(AidlTest, WarningInterfaceName) {
3602 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003603 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003604 " -Weverything -o out -h out p/Foo.aidl");
3605 CaptureStderr();
3606 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003607 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003608 GetCapturedStderr());
3609}
3610
3611TEST_P(AidlTest, ErrorInterfaceName) {
3612 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003613 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003614 " -Weverything -Werror -o out -h out p/Foo.aidl");
3615 CaptureStderr();
3616 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003617 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003618 GetCapturedStderr());
3619}
3620
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003621TEST_F(AidlTest, HideIsNotForArgs) {
3622 io_delegate_.SetFileContents("IFoo.aidl",
3623 "interface IFoo {\n"
3624 " void foo(in @Hide int x);\n"
3625 "}");
3626 auto options = Options::From("aidl --lang=java IFoo.aidl");
3627 CaptureStderr();
3628 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3630}
3631
3632TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3633 io_delegate_.SetFileContents(
3634 "IFoo.aidl",
3635 "interface IFoo {\n"
3636 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3637 "}");
3638 auto options = Options::From("aidl --lang=java IFoo.aidl");
3639 CaptureStderr();
3640 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3641 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3642}
3643
Jooyung Hanfd3be322020-12-13 09:11:06 +09003644struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003645 string kind;
3646 string literal;
3647};
3648
Jooyung Hanfd3be322020-12-13 09:11:06 +09003649const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003650 {"primitive", "int"}, {"String", "String"},
3651 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3652 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3653 {"union", "a.Union"}, {"interface", "a.IBar"},
3654};
3655
3656const std::map<std::string, std::string> kListSupportExpectations = {
3657 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3658 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3659 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3660 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
3661 {"cpp_String", ""},
3662 {"java_String", ""},
3663 {"ndk_String", ""},
3664 {"rust_String", ""},
3665 {"cpp_IBinder", ""},
3666 {"java_IBinder", ""},
3667 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3668 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003669 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003670 {"java_ParcelFileDescriptor", ""},
3671 {"ndk_ParcelFileDescriptor", ""},
3672 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003673 {"cpp_interface", "List<a.IBar> is not supported."},
3674 {"java_interface", "List<a.IBar> is not supported."},
3675 {"ndk_interface", "List<a.IBar> is not supported."},
3676 {"rust_interface", "List<a.IBar> is not supported."},
3677 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003678 {"java_parcelable", ""},
3679 {"ndk_parcelable", ""},
3680 {"rust_parcelable", ""},
3681 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3682 {"java_enum", "A generic type cannot have any primitive type parameters."},
3683 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3684 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003685 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003686 {"java_union", ""},
3687 {"ndk_union", ""},
3688 {"rust_union", ""},
3689};
3690
Jooyung Hand236e552020-12-13 09:21:27 +09003691const std::map<std::string, std::string> kArraySupportExpectations = {
3692 {"cpp_primitive", ""},
3693 {"java_primitive", ""},
3694 {"ndk_primitive", ""},
3695 {"rust_primitive", ""},
3696 {"cpp_String", ""},
3697 {"java_String", ""},
3698 {"ndk_String", ""},
3699 {"rust_String", ""},
3700 {"cpp_IBinder", ""},
3701 {"java_IBinder", ""},
3702 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3703 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3704 {"cpp_ParcelFileDescriptor", ""},
3705 {"java_ParcelFileDescriptor", ""},
3706 {"ndk_ParcelFileDescriptor", ""},
3707 {"rust_ParcelFileDescriptor", ""},
3708 {"cpp_interface", "Binder type cannot be an array"},
3709 {"java_interface", "Binder type cannot be an array"},
3710 {"ndk_interface", "Binder type cannot be an array"},
3711 {"rust_interface", "Binder type cannot be an array"},
3712 {"cpp_parcelable", ""},
3713 {"java_parcelable", ""},
3714 {"ndk_parcelable", ""},
3715 {"rust_parcelable", ""},
3716 {"cpp_enum", ""},
3717 {"java_enum", ""},
3718 {"ndk_enum", ""},
3719 {"rust_enum", ""},
3720 {"cpp_union", ""},
3721 {"java_union", ""},
3722 {"ndk_union", ""},
3723 {"rust_union", ""},
3724};
3725
Jooyung Hanfd3be322020-12-13 09:11:06 +09003726class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003727 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003728 void Run(const std::string& generic_type_decl,
3729 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003730 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003731 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003732 const auto& kind = std::get<1>(param).kind;
3733
3734 FakeIoDelegate io;
3735 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3736 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3737 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003738 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3739 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003740
3741 const auto options =
3742 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3743 CaptureStderr();
3744 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003745 auto it = expectations.find(lang + "_" + kind);
3746 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003747 const string err = GetCapturedStderr();
3748 if (it->second.empty()) {
3749 EXPECT_EQ("", err);
3750 } else {
3751 EXPECT_THAT(err, testing::HasSubstr(it->second));
3752 }
3753 }
3754};
3755
3756INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003757 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003758 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3759 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003760 testing::ValuesIn(kTypeParams)),
3761 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003762 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003763 });
3764
Jooyung Hanfd3be322020-12-13 09:11:06 +09003765TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3766 Run("List<{}>", kListSupportExpectations);
3767}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003768
Jooyung Hand236e552020-12-13 09:21:27 +09003769TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3770 Run("{}[]", kArraySupportExpectations);
3771}
3772
Christopher Wiley90be4e32015-10-20 14:55:25 -07003773} // namespace aidl
3774} // namespace android