blob: f296ce7e565ae13bace8cc98dcf5b2b7b74da04d [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
Jooyung Hanf8c39632021-10-05 09:56:29 +09001477TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1478 const string input_path = "p/IFoo.aidl";
1479 const string input =
1480 "package p;\n"
1481 "interface IFoo {\n"
1482 " parcelable Inner {\n"
1483 " enum Enum { A }\n"
1484 " }\n"
1485 "}";
1486 CaptureStderr();
1487 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1488 EXPECT_EQ(GetCapturedStderr(), "");
1489
1490 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1491 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1492 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1493 EXPECT_TRUE(enum_type.is_resolved);
1494 EXPECT_TRUE(inner_type.is_resolved);
1495 EXPECT_TRUE(ifoo_type.is_resolved);
1496 // GetParentType()
1497 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1498 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1499 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1500 // GetRootType()
1501 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1502 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1503 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1504 // GetDocument()
1505 auto main_document = &typenames_.MainDocument();
1506 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1507 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1508 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1509}
1510
Jooyung Han2aedb112021-09-29 09:37:59 +09001511TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1512 io_delegate_.SetFileContents("p/IOuter.aidl",
1513 "package p;\n"
1514 "interface IOuter {\n"
1515 " parcelable Inner {}\n"
1516 "}");
1517 import_paths_.emplace("");
1518 const string input_path = "p/IFoo.aidl";
1519 const string input =
1520 "package p;\n"
1521 "interface IFoo {\n"
1522 " p.IOuter.Inner get();\n"
1523 "}";
1524 CaptureStderr();
1525 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1526 EXPECT_EQ(GetCapturedStderr(), "");
1527
1528 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1529}
1530
1531TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1532 io_delegate_.SetFileContents("p/IOuter.aidl",
1533 "package p;\n"
1534 "interface IOuter {\n"
1535 " parcelable Inner {}\n"
1536 "}");
1537 import_paths_.emplace("");
1538 const string input_path = "p/IFoo.aidl";
1539 const string input =
1540 "package p;\n"
1541 "import p.IOuter.Inner;"
1542 "interface IFoo {\n"
1543 " Inner get();\n"
1544 "}";
1545 CaptureStderr();
1546 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1547 EXPECT_EQ(GetCapturedStderr(), "");
1548
1549 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1550}
1551
1552TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1553 const string input_path = "p/IFoo.aidl";
1554 const string input =
1555 "package p;\n"
1556 "interface IFoo {\n"
1557 " parcelable Result {}\n"
1558 " Result get();\n"
1559 "}";
1560 CaptureStderr();
1561 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1562 EXPECT_EQ(GetCapturedStderr(), "");
1563
1564 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1565}
1566
1567// Finding the type of nested named member.
1568struct TypeFinder : AidlVisitor {
1569 string name;
1570 const AidlTypeSpecifier* type = nullptr;
1571 TypeFinder(std::string name) : name(name) {}
1572 void Visit(const AidlVariableDeclaration& v) override {
1573 if (v.GetName() == name) {
1574 type = &v.GetType();
1575 }
1576 }
1577 void Visit(const AidlMethod& m) override {
1578 if (m.GetName() == name) {
1579 type = &m.GetType();
1580 }
1581 }
1582 static string Get(const AidlDefinedType& type, const string& name) {
1583 TypeFinder v(name);
1584 VisitTopDown(v, type);
1585 return v.type ? v.type->Signature() : "(null)";
1586 };
1587};
1588
1589TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1590 io_delegate_.SetFileContents("q/IBar.aidl",
1591 "package q;\n"
1592 "interface IBar {\n"
1593 " parcelable Baz {}\n"
1594 "}");
1595 import_paths_.emplace("");
1596 const string input_path = "p/IFoo.aidl";
1597 const string input =
1598 "package p;\n"
1599 "import q.IBar;\n"
1600 "interface IFoo {\n"
1601 " parcelable Nested {\n"
1602 " Baz t1;\n"
1603 " }\n"
1604 " parcelable Baz { }\n"
1605 " IBar.Baz t2();\n"
1606 " Baz t3();\n"
1607 "}";
1608 CaptureStderr();
1609 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1610 EXPECT_EQ(GetCapturedStderr(), "");
1611 ASSERT_NE(nullptr, foo);
1612
1613 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1614 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1615 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1616}
1617
1618TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1619 const string input_path = "p/Foo.aidl";
1620 const string input =
1621 "package p;\n"
1622 "parcelable Foo {\n"
1623 " parcelable Foo {}\n"
1624 "}";
1625 CaptureStderr();
1626 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1628}
1629
1630TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1631 const string input_path = "p/IFoo.aidl";
1632 const string input =
1633 "package p;\n"
1634 "interface IFoo {\n"
1635 " interface ICallback { void done(); }\n"
1636 " void doTask(ICallback cb);\n"
1637 "}";
1638 CaptureStderr();
1639 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1640 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1641}
1642
Jooyung Han2b1487d2021-09-30 09:57:01 +09001643TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1644 const string input_path = "p/IFoo.aidl";
1645 const string input =
1646 "package p;\n"
1647 "interface IFoo {\n"
1648 " parcelable Bar cpp_header \"Bar.h\";\n"
1649 "}";
1650 CaptureStderr();
1651 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1652 EXPECT_THAT(GetCapturedStderr(),
1653 HasSubstr("Unstructured parcelables should be at the root scope"));
1654}
1655
Jooyung Han7fc5de02021-09-30 22:26:27 +09001656TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1657 const string input_path = "p/Foo.aidl";
1658 const string input =
1659 "package p;\n"
1660 "parcelable Foo<T> {\n"
1661 " parcelable Bar {}\n"
1662 "}";
1663 CaptureStderr();
1664 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1665 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1666}
1667
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001668TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1669 const string input_path = "p/IFoo.aidl";
1670 const string input =
1671 "package p;\n"
1672 "interface IFoo {\n"
1673 " parcelable;\n" // missing identifier
1674 "}";
1675 CaptureStderr();
1676 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1677 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1678}
1679
Jooyung Han2aedb112021-09-29 09:37:59 +09001680TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1681 const string input_path = "p/Foo.aidl";
1682 const string input =
1683 "package p;\n"
1684 "interface Foo {\n"
1685 " parcelable Bar {}\n"
1686 " parcelable Bar {}\n"
1687 "}";
1688 CaptureStderr();
1689 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1690 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1691}
1692
1693TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1694 struct Failure {
1695 string err;
1696 };
1697 struct TestCase {
1698 string type;
1699 variant<string, Failure> expected; // success<0> or failure<1>
1700 };
1701 vector<TestCase> cases = {
1702 {"foo.A", "foo.A"},
1703 {"foo.A.B", "foo.A.B"},
1704 {"@nullable(heap=true) A", "foo.A.B.A"},
1705 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1706 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1707 {"B", "foo.A.B.A.B"},
1708 {"A.B", "foo.A.B.A.B"},
1709 };
1710 const string input_path = "foo/A.aidl";
1711 for (auto& [type, expected] : cases) {
1712 AidlTypenames typenames;
1713 // clang-format off
1714 const string input =
1715 "package foo;\n"
1716 "parcelable A {\n"
1717 " parcelable B {\n"
1718 " parcelable A {\n"
1719 " parcelable B {\n"
1720 " }\n"
1721 " " + type + " m;\n"
1722 " }\n"
1723 " }\n"
1724 "}";
1725 // clang-format on
1726 CaptureStderr();
1727 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1728 if (auto failure = std::get_if<Failure>(&expected); failure) {
1729 ASSERT_EQ(nullptr, foo);
1730 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1731 } else {
1732 EXPECT_EQ(GetCapturedStderr(), "");
1733 ASSERT_NE(nullptr, foo);
1734 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1735 }
1736 }
1737}
1738
Jooyung Hanca84b032021-09-30 02:15:59 +09001739TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1740 const string input_path = "p/IFoo.aidl";
1741 const string input =
1742 "package p;\n"
1743 "interface IFoo {\n"
1744 " parcelable Result {}\n"
1745 "}";
1746 CaptureStderr();
1747 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1748 ASSERT_NE(nullptr, foo);
1749 EXPECT_EQ(GetCapturedStderr(), "");
1750
1751 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1752 ASSERT_NE(nullptr, result);
1753 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1754}
1755
Jooyung Han0a950bd2021-05-15 12:50:36 +09001756TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001757 const string input_path = "p/Wrapper.aidl";
1758 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001759
1760 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1761 EXPECT_NE(nullptr, parse_result);
1762
1763 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1764 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1765 (..., params->emplace_back(std::move(type_params)));
1766 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1767 };
1768
1769 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1770 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001771 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001772 type->Annotate(std::move(annotations));
1773 return std::move(type);
1774 };
1775
1776 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1777 (void)type->SetArray();
1778 return std::move(type);
1779 };
1780
1781 auto w = type("p.Wrapper", type("String"));
1782 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1783
1784 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1785 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1786 cpp::CppNameOf(*nullable_w, typenames_));
1787
1788 auto array_w = set_array(type("p.Wrapper", type("String")));
1789 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1790 cpp::CppNameOf(*array_w, typenames_));
1791
1792 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1793 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1794 cpp::CppNameOf(*nullable_array_w, typenames_));
1795
1796 auto list_w = type("List", type("p.Wrapper", type("String")));
1797 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1798 cpp::CppNameOf(*list_w, typenames_));
1799
1800 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1801 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1802 cpp::CppNameOf(*nullable_list_w, typenames_));
1803}
1804
Devin Moore7b8d5c92020-03-17 14:14:08 -07001805TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001806 io_delegate_.SetFileContents(
1807 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001808 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001809 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001810 const string input_path = "p/IFoo.aidl";
1811 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001812 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1813 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001814 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001815 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001816 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001817
1818 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1819 // C++ understands C++ specific stuff
1820 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1821 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001822 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001823 EXPECT_EQ(1u, headers.size());
1824 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001825}
1826
Christopher Wileyf8136192016-04-12 14:19:35 -07001827TEST_F(AidlTest, WritesCorrectDependencyFile) {
1828 // While the in tree build system always gives us an output file name,
1829 // other android tools take advantage of our ability to infer the intended
1830 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001831 vector<string> args = {
1832 "aidl",
1833 "-d dep/file/path",
1834 "-o place/for/output",
1835 "p/IFoo.aidl"};
1836 Options options = Options::From(args);
1837 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001838 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001839 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001840 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001841 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1842}
1843
Dan Willemsen93298ee2016-11-10 23:55:55 -08001844TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1845 // While the in tree build system always gives us an output file name,
1846 // other android tools take advantage of our ability to infer the intended
1847 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001848 vector<string> args = {
1849 "aidl",
1850 "-d dep/file/path",
1851 "--ninja",
1852 "-o place/for/output",
1853 "p/IFoo.aidl"};
1854 Options options = Options::From(args);
1855 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001856 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001857 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001858 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001859 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1860}
1861
Jiyong Parkdf202122019-09-30 20:48:35 +09001862TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001863 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1864 // this by calling aidl with every .aidl file it finds, then parsing the
1865 // generated dependency files. Those that reference .java output files are
1866 // for interfaces and those that do not are parcelables. However, for both
1867 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001868 vector<string> args = {
1869 "aidl",
1870 "-o place/for/output",
1871 "-d dep/file/path",
1872 "p/Foo.aidl"};
1873 Options options = Options::From(args);
1874 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001875 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001876 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001877 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001878 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1879}
1880
1881TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1882 vector<string> args = {
1883 "aidl",
1884 "--structured",
1885 "-o place/for/output",
1886 "-d dep/file/path",
1887 "p/Foo.aidl"};
1888 Options options = Options::From(args);
1889 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001890 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001891 string actual_dep_file_contents;
1892 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1893 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001894}
1895
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001896TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1897 vector<string> args = {
1898 "aidl",
1899 "--lang=java",
1900 "-o place/for/output",
1901 "p/Foo.aidl"};
1902 Options options = Options::From(args);
1903 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001904 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001905 string output_file_contents;
1906 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1907}
1908
Devin Moore21b26772020-08-26 16:37:56 -07001909TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001910 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001911 const string list_array_parcelable =
1912 "package a; parcelable Foo {\n"
1913 " List[] lists; }";
1914 CaptureStderr();
1915 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1916 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1917}
1918
Jiyong Parkf8d53612020-05-04 14:06:13 +09001919TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1920 AidlError error;
1921 string expected_stderr =
1922 "ERROR: a/IFoo.aidl:2.7-11: "
1923 "Encountered an untyped List or Map. The use of untyped List/Map is "
1924 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1925 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1926 if (GetLanguage() != Options::Language::JAVA) {
1927 expected_stderr =
1928 "ERROR: a/IFoo.aidl:2.1-7: "
1929 "Currently, only the Java backend supports non-generic List.\n";
1930 }
1931
1932 const string primitive_interface =
1933 "package a; interface IFoo {\n"
1934 " List foo(); }";
1935 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001936 AidlTypenames tn1;
1937 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001938 {"--structured"}));
1939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001940
1941 string primitive_parcelable =
1942 "package a; parcelable IFoo {\n"
1943 " List foo;}";
1944 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001945 AidlTypenames tn2;
1946 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001947 {"--structured"}));
1948 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1949}
1950
Jeongik Cha225519b2020-08-29 01:55:32 +09001951TEST_P(AidlTest, ExtensionTest) {
1952 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001953 string extendable_parcelable =
1954 "package a; parcelable Data {\n"
1955 " ParcelableHolder extension;\n"
1956 " ParcelableHolder extension2;\n"
1957 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001958 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001959 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1960 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001961 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001962 "yet.\n",
1963 GetCapturedStderr());
1964 } else {
1965 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1966 EXPECT_EQ("", GetCapturedStderr());
1967 }
1968}
1969TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1970 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001971 string parcelableholder_return_interface =
1972 "package a; interface IFoo {\n"
1973 " ParcelableHolder foo();\n"
1974 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001975 EXPECT_EQ(nullptr,
1976 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001977
Jeongik Cha8f02a532020-10-14 00:16:28 +09001978 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001979 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001980 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001981 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001982 "yet.\n",
1983 GetCapturedStderr());
1984 return;
1985 }
1986 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1987 GetCapturedStderr());
1988}
1989
1990TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1991 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001992 string extendable_parcelable_arg_interface =
1993 "package a; interface IFoo {\n"
1994 " void foo(in ParcelableHolder ph);\n"
1995 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001996 EXPECT_EQ(nullptr,
1997 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1998
Jeongik Cha8f02a532020-10-14 00:16:28 +09001999 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09002000 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002001 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09002002 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09002003 "yet.\n",
2004 GetCapturedStderr());
2005 return;
2006 }
2007 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
2008 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09002009}
2010
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002011TEST_P(AidlTest, RejectNullableParcelableHolderField) {
2012 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002013 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002014 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
2015 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002016 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002017 if (GetLanguage() == Options::Language::RUST) {
2018 EXPECT_EQ(
2019 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
2020 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
2021 "yet.\n",
2022 GetCapturedStderr());
2023 return;
2024 }
2025 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2026}
2027
Jooyung Han3f347ca2020-12-01 12:41:50 +09002028TEST_P(AidlTest, ParcelablesWithConstants) {
2029 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002030 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002031 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002032 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002033 EXPECT_EQ("", GetCapturedStderr());
2034}
2035
2036TEST_P(AidlTest, UnionWithConstants) {
2037 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002038 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002039 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002040 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002041 EXPECT_EQ("", GetCapturedStderr());
2042}
2043
Jooyung Han633eab62021-01-07 14:12:40 +09002044TEST_F(AidlTest, ConstantsWithAnnotations) {
2045 io_delegate_.SetFileContents("IFoo.aidl",
2046 "interface IFoo {\n"
2047 " @JavaPassthrough(annotation=\"@Foo\")\n"
2048 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2049 "}");
2050 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2051 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002052 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002053 EXPECT_EQ("", GetCapturedStderr());
2054 string code;
2055 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2056 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2057 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2058}
2059
Jiyong Park02da7422018-07-16 16:00:26 +09002060TEST_F(AidlTest, ApiDump) {
2061 io_delegate_.SetFileContents(
2062 "foo/bar/IFoo.aidl",
2063 "package foo.bar;\n"
2064 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002065 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002066 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002067 " /* @hide applied \n"
2068 " @deprecated use foo2 */\n"
2069 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2070 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002071 " IFoo foo3(IFoo foo);\n"
2072 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002073 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002074 " /** blahblah\n"
2075 " @deprecated\n"
2076 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002077 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002078 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002079 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002080 "}\n");
2081 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2082 "package foo.bar;\n"
2083 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002084 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002085 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002086 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002087 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002088 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002089 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002090 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002091 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002092 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002093 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002094 "}\n");
2095 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002096 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2097 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002098 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002099 bool result = dump_api(options, io_delegate_);
2100 ASSERT_TRUE(result);
2101 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002102 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002103 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002104interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002105 /**
2106 * @hide
2107 * @deprecated use foo2
2108 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002109 int foo(out int[] a, String b, boolean c, inout List<String> d);
2110 int foo2(@utf8InCpp String x, inout List<String> y);
2111 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2112 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002113 /**
2114 * @deprecated reason why...
2115 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002116 const int A = 1;
2117 const String STR = "Hello";
2118}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002119)"),
2120 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002121
Jiyong Parke59c3682018-09-11 23:10:25 +09002122 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002123 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002124/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002125parcelable Data {
2126 int x = 10;
2127 int y;
2128 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002129 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002130}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002131)"),
2132 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002133}
2134
Jiyong Parked65bf42018-08-28 15:43:27 +09002135TEST_F(AidlTest, ApiDumpWithManualIds) {
2136 io_delegate_.SetFileContents(
2137 "foo/bar/IFoo.aidl",
2138 "package foo.bar;\n"
2139 "interface IFoo {\n"
2140 " int foo() = 1;\n"
2141 " int bar() = 2;\n"
2142 " int baz() = 10;\n"
2143 "}\n");
2144
Jiyong Parke59c3682018-09-11 23:10:25 +09002145 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002146 Options options = Options::From(args);
2147 bool result = dump_api(options, io_delegate_);
2148 ASSERT_TRUE(result);
2149 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002150 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002151 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002152interface IFoo {
2153 int foo() = 1;
2154 int bar() = 2;
2155 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002156}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002157)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002158}
2159
2160TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002161 const string expected_stderr =
2162 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2163 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002164 io_delegate_.SetFileContents(
2165 "foo/bar/IFoo.aidl",
2166 "package foo.bar;\n"
2167 "interface IFoo {\n"
2168 " int foo() = 1;\n"
2169 " int bar();\n"
2170 " int baz() = 10;\n"
2171 "}\n");
2172
Jiyong Parke59c3682018-09-11 23:10:25 +09002173 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002174 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002175 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002176 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002177 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002178}
2179
Jooyung Han965e31d2020-11-27 12:30:16 +09002180TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2181 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2182 "package foo.bar;\n"
2183 "interface IFoo {\n"
2184 " @utf8InCpp String foo();\n"
2185 " const @utf8InCpp String bar = \"bar\";\n"
2186 "}\n");
2187
2188 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2189 Options options = Options::From(args);
2190 CaptureStderr();
2191 EXPECT_TRUE(dump_api(options, io_delegate_));
2192 EXPECT_EQ("", GetCapturedStderr());
2193 string actual;
2194 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002195 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2196interface IFoo {
2197 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002198 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002199}
2200)"),
2201 actual);
2202}
2203
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002204TEST_F(AidlTest, ApiDumpWithEnums) {
2205 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2206 "package foo.bar;\n"
2207 "enum Enum {\n"
2208 " FOO,\n"
2209 " BAR = FOO + 1,\n"
2210 "}\n");
2211
2212 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2213 Options options = Options::From(args);
2214 CaptureStderr();
2215 EXPECT_TRUE(dump_api(options, io_delegate_));
2216 EXPECT_EQ("", GetCapturedStderr());
2217 string actual;
2218 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2219 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2220 "enum Enum {\n"
2221 " FOO = 0,\n"
2222 " BAR = 1,\n"
2223 "}\n"),
2224 actual);
2225}
2226
2227TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2228 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2229 "package foo.bar;\n"
2230 "enum Enum {\n"
2231 " FOO,\n"
2232 "}\n");
2233 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2234 "package foo.bar;\n"
2235 "import foo.bar.Enum;\n"
2236 "parcelable Foo {\n"
2237 " Enum e = Enum.FOO;\n"
2238 "}\n");
2239
2240 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2241 Options options = Options::From(args);
2242 CaptureStderr();
2243 EXPECT_TRUE(dump_api(options, io_delegate_));
2244 EXPECT_EQ("", GetCapturedStderr());
2245 string actual;
2246 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2247 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2248 "parcelable Foo {\n"
2249 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2250 "}\n"),
2251 actual);
2252}
2253
Jooyung Han71dfec32021-05-23 07:18:58 +09002254TEST_F(AidlTest, ApiDumpWithGenerics) {
2255 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2256 "package foo.bar;\n"
2257 "parcelable Foo<T, U> {\n"
2258 "}\n");
2259
2260 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2261 Options options = Options::From(args);
2262 CaptureStderr();
2263 EXPECT_TRUE(dump_api(options, io_delegate_));
2264 EXPECT_EQ("", GetCapturedStderr());
2265 string actual;
2266 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2267 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2268 "parcelable Foo<T, U> {\n"
2269 "}\n"),
2270 actual);
2271}
2272
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002273TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2274 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2275 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2276
2277 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2278 Options options = Options::From(args);
2279 CaptureStderr();
2280 EXPECT_FALSE(dump_api(options, io_delegate_));
2281 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2282}
2283
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002284TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002285 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002286 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2287 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002288 const string expected_map_stderr =
2289 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002290 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2291 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002292 "package p; interface IFoo {"
2293 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002294 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002295 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002296 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002297
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002298 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002299 "package p; interface IFoo {"
2300 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002301 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002302 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002304}
2305
Jeongik Chae48d9942020-01-02 17:39:00 +09002306TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002307 const string expected_stderr =
2308 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002309 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002310 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2311
2312 io_delegate_.SetFileContents("p/IFoo.aidl",
2313 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002314 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002315 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002316
2317 io_delegate_.SetFileContents("p/IFoo.aidl",
2318 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002319 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002320 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002321 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002323
2324 io_delegate_.SetFileContents("p/IFoo.aidl",
2325 "package p; interface IFoo {"
2326 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002327 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002328
2329 io_delegate_.SetFileContents("p/IFoo.aidl",
2330 "package p; interface IFoo {"
2331 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002332 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002333}
2334
Jeongik Chadf76dc72019-11-28 00:08:47 +09002335TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002336 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002337 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2338 io_delegate_.SetFileContents(options.InputFiles().front(),
2339 "package p; interface IFoo {"
2340 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002341 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002342 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002344}
2345
2346TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002347 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002348 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002349 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002350 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002351 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2352 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002353
Jooyung Han13f1fa52021-06-11 18:06:12 +09002354 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002355 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2356 io_delegate_.SetFileContents("p/IFoo.aidl",
2357 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002358 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002360 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002361 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002362 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002363 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002364 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002366 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002367 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002368 io_delegate_.SetFileContents("p/IFoo.aidl",
2369 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002370 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002371 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002372
2373 io_delegate_.SetFileContents("p/IFoo.aidl",
2374 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002375 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002376
2377 io_delegate_.SetFileContents("p/IFoo.aidl",
2378 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002379 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002380
Steven Moreland4e059132021-08-11 13:36:30 -07002381 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002382}
2383
Jeongik Cha0e426012019-07-29 15:57:02 +09002384TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2385 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002386 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2387 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002388 for (const auto& rawOption : rawOptions) {
2389 string expected_stderr =
2390 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002391 Options options = Options::From(rawOption);
2392 io_delegate_.SetFileContents(options.InputFiles().front(),
2393 "package foo.bar;\n"
2394 "interface IFoo1 { int foo(); }\n"
2395 "interface IFoo2 { int foo(); }\n"
2396 "parcelable Data1 { int a; int b;}\n"
2397 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002398 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002399 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002401
Jeongik Cha0e426012019-07-29 15:57:02 +09002402 io_delegate_.SetFileContents(options.InputFiles().front(),
2403 "package foo.bar;\n"
2404 "interface IFoo1 { int foo(); }\n"
2405 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002407 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002409
Devin Moore5de18ed2020-04-02 13:52:29 -07002410 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002411 io_delegate_.SetFileContents(options.InputFiles().front(),
2412 "package foo.bar;\n"
2413 "parcelable Data1 { int a; int b;}\n"
2414 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002415 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002416 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002418 }
2419}
2420
Devin Moorebdba2a82020-03-31 15:19:02 -07002421TEST_P(AidlTest, FailParseOnEmptyFile) {
2422 const string contents = "";
2423 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2424 CaptureStderr();
2425 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2427}
2428
Jiyong Parkb034bf02018-07-30 17:44:33 +09002429TEST_F(AidlTest, MultipleInputFiles) {
2430 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002431 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002432
2433 io_delegate_.SetFileContents(options.InputFiles().at(0),
2434 "package foo.bar;\n"
2435 "import foo.bar.Data;\n"
2436 "interface IFoo { Data getData(); }\n");
2437
2438 io_delegate_.SetFileContents(options.InputFiles().at(1),
2439 "package foo.bar;\n"
2440 "import foo.bar.IFoo;\n"
2441 "parcelable Data { IFoo foo; }\n");
2442
Steven Moreland4e059132021-08-11 13:36:30 -07002443 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002444
2445 string content;
2446 for (const auto file : {
2447 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2448 content.clear();
2449 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2450 EXPECT_FALSE(content.empty());
2451 }
2452}
2453
2454TEST_F(AidlTest, MultipleInputFilesCpp) {
2455 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002456 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002457
2458 io_delegate_.SetFileContents(options.InputFiles().at(0),
2459 "package foo.bar;\n"
2460 "import foo.bar.Data;\n"
2461 "interface IFoo { Data getData(); }\n");
2462
2463 io_delegate_.SetFileContents(options.InputFiles().at(1),
2464 "package foo.bar;\n"
2465 "import foo.bar.IFoo;\n"
2466 "parcelable Data { IFoo foo; }\n");
2467
Steven Moreland4e059132021-08-11 13:36:30 -07002468 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002469
2470 string content;
2471 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002472 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002473 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2474 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2475 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2476 content.clear();
2477 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2478 EXPECT_FALSE(content.empty());
2479 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002480}
2481
Andrei Homescub62afd92020-05-11 19:24:59 -07002482TEST_F(AidlTest, MultipleInputFilesRust) {
2483 Options options =
2484 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2485
2486 io_delegate_.SetFileContents(options.InputFiles().at(0),
2487 "package foo.bar;\n"
2488 "import foo.bar.Data;\n"
2489 "interface IFoo { Data getData(); }\n");
2490
2491 io_delegate_.SetFileContents(options.InputFiles().at(1),
2492 "package foo.bar;\n"
2493 "import foo.bar.IFoo;\n"
2494 "parcelable Data { IFoo foo; }\n");
2495
Steven Moreland4e059132021-08-11 13:36:30 -07002496 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002497
2498 string content;
2499 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2500 content.clear();
2501 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2502 EXPECT_FALSE(content.empty());
2503 }
2504}
2505
Devin Moore097a3ab2020-03-11 16:08:44 -07002506TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2507 const string expected_stderr =
2508 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002509 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2510 // int getInterfaceVersion() is one of the meta transactions
2511 io_delegate_.SetFileContents(options.InputFiles().front(),
2512 "package p; interface IFoo {"
2513 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002514 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002515 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002516 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2517}
Jiyong Park309668e2018-07-28 16:55:44 +09002518
Devin Moore097a3ab2020-03-11 16:08:44 -07002519TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2520 // boolean getInterfaceVersion() is not a meta transaction, but should be
2521 // prevented because return type is not part of a method signature
2522 const string expected_stderr =
2523 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2524 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002525 io_delegate_.SetFileContents(options.InputFiles().front(),
2526 "package p; interface IFoo {"
2527 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002528 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002529 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002530 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2531}
Jiyong Park309668e2018-07-28 16:55:44 +09002532
Devin Moore097a3ab2020-03-11 16:08:44 -07002533TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002534 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002535 const string expected_stderr =
2536 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2537 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002538 io_delegate_.SetFileContents(options.InputFiles().front(),
2539 "package p; interface IFoo {"
2540 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002541 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002542 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002544
2545 // this is not a meta interface method as it differs type arguments
2546 io_delegate_.SetFileContents(options.InputFiles().front(),
2547 "package p; interface IFoo {"
2548 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002549 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002550}
2551
Jooyung Hanb8a97772021-01-19 01:27:38 +09002552TEST_F(AidlTest, CheckApiForEquality) {
2553 CaptureStderr();
2554 Options options = Options::From("aidl --checkapi=equal old new");
2555
2556 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2557 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2558 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2559 "package p; interface IFoo{ @utf8InCpp String foo();}");
2560
2561 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2562 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2563}
2564
Daniel Norman85aed542019-08-21 12:01:14 -07002565TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002566 Options options = Options::From("aidl --checkapi old new");
2567 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2568 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2569 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2570 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2571
2572 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2573}
2574
Jiyong Park3656c3c2018-08-01 20:02:01 +09002575TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002576 Options options = Options::From("aidl --checkapi old new");
2577 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2578 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002579
2580 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2581}
2582
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002583TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2584 Options options = Options::From("aidl --checkapi old new");
2585 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2586 const string enum_definition = "package p; enum Enum { FOO }";
2587 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2588 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2589 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2590 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2591
2592 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2593}
2594
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002595TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2596 Options options = Options::From("aidl --checkapi old new -I import");
2597
2598 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2599 io_delegate_.SetFileContents("new/p/Foo.aidl",
2600 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2601 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2602
2603 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2604}
2605
Jooyung Han02a11be2021-02-11 13:18:06 +09002606TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2607 Options options = Options::From("aidl --checkapi=equal old new");
2608 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2609 const string enum_definition = "package p; enum Enum { FOO }";
2610 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2611 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2612 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2613 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2614 CaptureStderr();
2615 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2616 EXPECT_EQ("", GetCapturedStderr());
2617}
2618
Daniel Norman85aed542019-08-21 12:01:14 -07002619class AidlTestCompatibleChanges : public AidlTest {
2620 protected:
2621 Options options_ = Options::From("aidl --checkapi old new");
2622};
2623
2624TEST_F(AidlTestCompatibleChanges, NewType) {
2625 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2626 "package p;"
2627 "interface IFoo {"
2628 " void foo(int a);"
2629 "}");
2630 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2631 "package p;"
2632 "interface IFoo {"
2633 " void foo(int a);"
2634 "}");
2635 io_delegate_.SetFileContents("new/p/IBar.aidl",
2636 "package p;"
2637 "interface IBar {"
2638 " void bar();"
2639 "}");
2640 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2641}
2642
2643TEST_F(AidlTestCompatibleChanges, NewMethod) {
2644 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2645 "package p;"
2646 "interface IFoo {"
2647 " void foo(int a);"
2648 "}");
2649 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2650 "package p;"
2651 "interface IFoo {"
2652 " void foo(int a);"
2653 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002654 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002655 "}");
2656 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2657}
2658
2659TEST_F(AidlTestCompatibleChanges, NewField) {
2660 io_delegate_.SetFileContents("old/p/Data.aidl",
2661 "package p;"
2662 "parcelable Data {"
2663 " int foo;"
2664 "}");
2665 io_delegate_.SetFileContents("new/p/Data.aidl",
2666 "package p;"
2667 "parcelable Data {"
2668 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002669 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002670 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002671 "}");
2672 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2673}
2674
Jooyung Han05bd8a82021-04-28 23:56:38 +09002675TEST_F(AidlTestCompatibleChanges, NewField2) {
2676 io_delegate_.SetFileContents("old/p/Data.aidl",
2677 "package p;"
2678 "parcelable Data {"
2679 "}");
2680 io_delegate_.SetFileContents("new/p/Data.aidl",
2681 "package p;"
2682 "parcelable Data {"
2683 " int foo = 0;"
2684 "}");
2685 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2686}
2687
Daniel Norman85aed542019-08-21 12:01:14 -07002688TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2689 io_delegate_.SetFileContents("old/p/Enum.aidl",
2690 "package p;"
2691 "enum Enum {"
2692 " FOO = 1,"
2693 "}");
2694 io_delegate_.SetFileContents("new/p/Enum.aidl",
2695 "package p;"
2696 "enum Enum {"
2697 " FOO = 1,"
2698 " BAR = 2,"
2699 "}");
2700 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2701}
2702
2703TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2704 io_delegate_.SetFileContents("old/p/Enum.aidl",
2705 "package p;"
2706 "enum Enum {"
2707 " FOO = 1,"
2708 " BAR = 2,"
2709 "}");
2710 io_delegate_.SetFileContents("new/p/Enum.aidl",
2711 "package p;"
2712 "enum Enum {"
2713 " BAR = 2,"
2714 " FOO = 1,"
2715 "}");
2716 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2717}
2718
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002719TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2720 io_delegate_.SetFileContents("old/p/Union.aidl",
2721 "package p;"
2722 "union Union {"
2723 " String foo;"
2724 "}");
2725 io_delegate_.SetFileContents("new/p/Union.aidl",
2726 "package p;"
2727 "union Union {"
2728 " String foo;"
2729 " int num;"
2730 "}");
2731 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2732}
2733
Daniel Norman85aed542019-08-21 12:01:14 -07002734TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002735 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2736 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002737 "interface IFoo {"
2738 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002739 "}");
2740 io_delegate_.SetFileContents("old/p/Data.aidl",
2741 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002742 "parcelable Data {"
2743 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002744 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002745 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2746 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002747 "interface IFoo {"
2748 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002749 "}");
2750 io_delegate_.SetFileContents("new/p/Data.aidl",
2751 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002752 "parcelable Data {"
2753 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002754 "}");
2755 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2756 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002757 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002758 " void foo(int a);"
2759 "}");
2760 io_delegate_.SetFileContents("new/q/Data.aidl",
2761 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002762 "parcelable Data {"
2763 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002764 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002765 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2766}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002767
Daniel Norman85aed542019-08-21 12:01:14 -07002768TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2769 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2770 "package p;"
2771 "interface IFoo {"
2772 " void foo(int a);"
2773 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002774 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2775 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002776 "interface IFoo {"
2777 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002778 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002779 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2780}
Jiyong Parke59c3682018-09-11 23:10:25 +09002781
Daniel Norman85aed542019-08-21 12:01:14 -07002782TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002783 io_delegate_.SetFileContents("old/p/I.aidl",
2784 "package p; interface I {"
2785 "const int A = 1; }");
2786 io_delegate_.SetFileContents("new/p/I.aidl",
2787 "package p ; interface I {"
2788 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002789 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2790}
Jiyong Parka428d212018-08-29 22:26:30 +09002791
Daniel Norman85aed542019-08-21 12:01:14 -07002792TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002793 io_delegate_.SetFileContents("old/p/I.aidl",
2794 "package p; interface I {"
2795 "const int A = 1; const int B = 2;}");
2796 io_delegate_.SetFileContents("new/p/I.aidl",
2797 "package p ; interface I {"
2798 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002799 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002800}
2801
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002802TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2803 io_delegate_.SetFileContents("old/p/Foo.aidl",
2804 "package p;"
2805 "@JavaPassthrough(annotation=\"Alice\")"
2806 "@JavaPassthrough(annotation=\"Bob\")"
2807 "parcelable Foo {}");
2808 io_delegate_.SetFileContents("new/p/Foo.aidl",
2809 "package p;"
2810 "@JavaPassthrough(annotation=\"Bob\")"
2811 "@JavaPassthrough(annotation=\"Alice\")"
2812 "parcelable Foo {}");
2813 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2814}
2815
Jooyung Han00073272020-11-27 14:20:20 +09002816TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2817 io_delegate_.SetFileContents("old/p/Foo.aidl",
2818 "package p;"
2819 "parcelable Foo {}");
2820 io_delegate_.SetFileContents("new/p/Foo.aidl",
2821 "package p;"
2822 "@JavaPassthrough(annotation=\"@Deprecated\")"
2823 "parcelable Foo {}");
2824 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2825}
2826
Jooyung Han636fd2f2020-10-22 11:33:45 +09002827TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2828 io_delegate_.SetFileContents("old/p/Data.aidl",
2829 "package p;"
2830 "parcelable Data {"
2831 " int num;"
2832 "}");
2833 io_delegate_.SetFileContents(
2834 "new/p/Data.aidl",
2835 "package p;"
2836 "parcelable Data {"
2837 " int num;"
2838 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2839 "}");
2840 io_delegate_.SetFileContents("new/p/Enum.aidl",
2841 "package p;"
2842 "enum Enum {"
2843 " FOO = 0,"
2844 " BAR = 1,"
2845 "}");
2846 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2847}
2848
Jooyung Han308bbe02021-04-27 12:09:59 +09002849TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2850 io_delegate_.SetFileContents("old/p/Data.aidl",
2851 "package p;\n"
2852 "parcelable Data {\n"
2853 " p.Enum e;\n"
2854 "}");
2855 io_delegate_.SetFileContents("old/p/Enum.aidl",
2856 "package p;\n"
2857 "enum Enum {\n"
2858 " FOO = 0,\n"
2859 " BAR = 1,\n"
2860 "}");
2861 io_delegate_.SetFileContents("new/p/Data.aidl",
2862 "package p;\n"
2863 "parcelable Data {\n"
2864 " p.Enum e = p.Enum.FOO;\n"
2865 "}");
2866 io_delegate_.SetFileContents("new/p/Enum.aidl",
2867 "package p;\n"
2868 "enum Enum {\n"
2869 " FOO = 0,\n"
2870 " BAR = 1,\n"
2871 "}");
2872 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2873}
2874
Daniel Norman85aed542019-08-21 12:01:14 -07002875class AidlTestIncompatibleChanges : public AidlTest {
2876 protected:
2877 Options options_ = Options::From("aidl --checkapi old new");
2878};
2879
2880TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002881 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002882 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2883 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002884 "interface IFoo {"
2885 " void foo(in String[] str);"
2886 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002887 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002888 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002889 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002890 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002891}
2892
2893TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002894 const string expected_stderr =
2895 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002896 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2897 "package p;"
2898 "interface IFoo {"
2899 " void foo(in String[] str);"
2900 " void bar(@utf8InCpp String str);"
2901 "}");
2902 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2903 "package p;"
2904 "interface IFoo {"
2905 " void foo(in String[] str);"
2906 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002907 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002908 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002910}
2911
Jiyong Parkf8d53612020-05-04 14:06:13 +09002912TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2913 const string expected_stderr =
2914 "ERROR: new/p/IFoo.aidl:1.61-65: "
2915 "Encountered an untyped List or Map. The use of untyped List/Map is "
2916 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2917 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2918 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2919 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2920 "package p;"
2921 "interface IFoo {"
2922 " void foo(in String[] str);"
2923 "}");
2924 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2925 "package p;"
2926 "interface IFoo {"
2927 " void foo(in String[] str);"
2928 " void bar(in List arg);"
2929 "}");
2930 CaptureStderr();
2931 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2932 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2933}
2934
2935TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2936 const string expected_stderr =
2937 "ERROR: new/p/Data.aidl:1.54-59: "
2938 "Encountered an untyped List or Map. The use of untyped List/Map is "
2939 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2940 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2941 "ERROR: new/p/Data.aidl: Failed to read.\n";
2942 io_delegate_.SetFileContents("old/p/Data.aidl",
2943 "package p;"
2944 "parcelable Data {"
2945 " int foo;"
2946 "}");
2947 io_delegate_.SetFileContents("new/p/Data.aidl",
2948 "package p;"
2949 "parcelable Data {"
2950 " int foo;"
2951 " @nullable List list;"
2952 "}");
2953 CaptureStderr();
2954 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2956}
2957
Daniel Norman85aed542019-08-21 12:01:14 -07002958TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002959 const string expected_stderr =
2960 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002961 io_delegate_.SetFileContents("old/p/Data.aidl",
2962 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002963 "parcelable Data {"
2964 " int foo;"
2965 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002966 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002967 io_delegate_.SetFileContents("new/p/Data.aidl",
2968 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002969 "parcelable Data {"
2970 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002971 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002972 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002973 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002975}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002976
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002977TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2978 const string expected_stderr =
2979 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2980 "backends. Please either provide a default value for this field or mark the field as "
2981 "@nullable. This value or a null value will be used automatically when an old version of "
2982 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2983 "order to make sure your code continues to be backwards compatible, make sure the default or "
2984 "null value does not cause a semantic change to this parcelable.\n";
2985 io_delegate_.SetFileContents("old/p/Data.aidl",
2986 "package p;"
2987 "parcelable Data {"
2988 " int num;"
2989 "}");
2990 io_delegate_.SetFileContents("new/p/Data.aidl",
2991 "package p;"
2992 "parcelable Data {"
2993 " int num;"
2994 " String str;"
2995 "}");
2996 CaptureStderr();
2997 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2998 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2999}
3000
Jooyung Han636fd2f2020-10-22 11:33:45 +09003001TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
3002 const string expected_stderr =
3003 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
3004 "Please make sure 'Enum' has '0' as a valid value.\n";
3005 io_delegate_.SetFileContents("old/p/Data.aidl",
3006 "package p;"
3007 "parcelable Data {"
3008 " int num;"
3009 "}");
3010 io_delegate_.SetFileContents("new/p/Data.aidl",
3011 "package p;"
3012 "parcelable Data {"
3013 " int num;"
3014 " p.Enum e;"
3015 "}");
3016 io_delegate_.SetFileContents("new/p/Enum.aidl",
3017 "package p;"
3018 "enum Enum {"
3019 " FOO = 1,"
3020 " BAR = 2,"
3021 "}");
3022 CaptureStderr();
3023 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3024 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3025}
3026
Daniel Norman85aed542019-08-21 12:01:14 -07003027TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003028 const string expected_stderr =
3029 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003030 io_delegate_.SetFileContents("old/p/Enum.aidl",
3031 "package p;"
3032 "enum Enum {"
3033 " FOO = 1,"
3034 " BAR = 2,"
3035 "}");
3036 io_delegate_.SetFileContents("new/p/Enum.aidl",
3037 "package p;"
3038 "enum Enum {"
3039 " BAR = 2,"
3040 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003041 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003042 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003043 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003044}
3045
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003046TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3047 const string expected_stderr =
3048 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3049 io_delegate_.SetFileContents("old/p/Union.aidl",
3050 "package p;"
3051 "union Union {"
3052 " String str;"
3053 " int num;"
3054 "}");
3055 io_delegate_.SetFileContents("new/p/Union.aidl",
3056 "package p;"
3057 "union Union {"
3058 " String str;"
3059 "}");
3060 CaptureStderr();
3061 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3062 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3063}
3064
Daniel Norman85aed542019-08-21 12:01:14 -07003065TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003066 const string expected_stderr =
3067 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003068 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3069 "package p;"
3070 "interface IFoo {"
3071 " void foo(in String[] str);"
3072 " void bar(@utf8InCpp String str);"
3073 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003074 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3075 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003076 "interface IFoo {"
3077 " void foo(in String[] str);"
3078 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003079 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003080 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003081 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003082 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003083}
3084
Daniel Norman85aed542019-08-21 12:01:14 -07003085TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003086 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003087 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3088 "package p;"
3089 "interface IFoo {"
3090 " void foo(in String[] str);"
3091 " void bar(@utf8InCpp String str);"
3092 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003093 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3094 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003095 "interface IFoo2 {"
3096 " void foo(in String[] str);"
3097 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003098 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003099 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003100 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003101 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003102}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003103
Daniel Norman85aed542019-08-21 12:01:14 -07003104TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003105 const string expected_stderr =
3106 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003107 io_delegate_.SetFileContents("old/p/Enum.aidl",
3108 "package p;"
3109 "enum Enum {"
3110 " FOO = 1,"
3111 " BAR = 2,"
3112 "}");
3113 io_delegate_.SetFileContents("new/p/Enum.aidl",
3114 "package p;"
3115 "enum Enum {"
3116 " FOO = 3,"
3117 " BAR = 2,"
3118 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003119 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003120 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003121 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003122}
3123
3124TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003125 const string expected_stderr =
3126 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3127 "from 0 to 1.\n"
3128 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3129 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003130 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3131 "package p;"
3132 "interface IFoo {"
3133 " void foo(in String[] str);"
3134 " void bar(@utf8InCpp String str);"
3135 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003136 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3137 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003138 "interface IFoo {"
3139 " void bar(@utf8InCpp String str);"
3140 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003141 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003142 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003143 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003144 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003145}
3146
3147TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003148 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003149 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3150 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003151 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003152 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003153 "parcelable Data {"
3154 " int foo;"
3155 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003156 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003157 io_delegate_.SetFileContents("new/p/Data.aidl",
3158 "package p;"
3159 "parcelable Data {"
3160 " int bar;"
3161 " int foo;"
3162 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003163 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003164 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003165 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003166}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003167
Daniel Norman85aed542019-08-21 12:01:14 -07003168TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003169 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003170 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003171 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003172 "interface IFoo {"
3173 " void foo(in String[] str);"
3174 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003175 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003176 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3177 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003178 "interface IFoo {"
3179 " void foo(out String[] str);"
3180 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003181 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003182 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003183 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003184 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003185}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003186
Daniel Norman85aed542019-08-21 12:01:14 -07003187TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003188 const string expected_stderr =
3189 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003190 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3191 "package p;"
3192 "interface IFoo {"
3193 " void foo(in String[] str);"
3194 " void bar(@utf8InCpp String str);"
3195 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003196 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3197 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003198 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003199 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003200 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003201 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003202 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003203 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003204 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003205}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003206
Daniel Norman85aed542019-08-21 12:01:14 -07003207TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003208 const string expected_stderr =
3209 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003210 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3211 "package p;"
3212 "interface IFoo {"
3213 " void foo(in String[] str);"
3214 " void bar(@utf8InCpp String str);"
3215 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003216 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3217 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003218 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003219 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003220 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003221 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003222 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003223 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003225}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003226
Jooyung Han60b2fde2020-10-29 15:12:40 +09003227TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3228 const string expected_stderr =
3229 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3230 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3231 io_delegate_.SetFileContents("old/p/Foo.aidl",
3232 "package p;"
3233 "@Backing(type=\"byte\")"
3234 "enum Foo {"
3235 " FOO, BAR,"
3236 "}");
3237 io_delegate_.SetFileContents("new/p/Foo.aidl",
3238 "package p;"
3239 "@Backing(type=\"long\")"
3240 "enum Foo {"
3241 " FOO, BAR,"
3242 "}");
3243 CaptureStderr();
3244 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3245 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3246}
3247
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003248TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3249 const string expected_stderr =
3250 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3251 "to @JavaPassthrough(annotation=\"Bob\")\n";
3252 io_delegate_.SetFileContents("old/p/Foo.aidl",
3253 "package p;"
3254 "@JavaPassthrough(annotation=\"Alice\")"
3255 "parcelable Foo {}");
3256 io_delegate_.SetFileContents("new/p/Foo.aidl",
3257 "package p;"
3258 "@JavaPassthrough(annotation=\"Bob\")"
3259 "parcelable Foo {}");
3260
3261 CaptureStderr();
3262 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3264}
3265
Devin Mooredb7ac512020-08-07 11:17:36 -07003266TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3267 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003268 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003269 io_delegate_.SetFileContents("old/p/Foo.aidl",
3270 "package p;"
3271 "parcelable Foo {"
3272 " int A;"
3273 "}");
3274 io_delegate_.SetFileContents("new/p/Foo.aidl",
3275 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003276 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003277 " int A;"
3278 "}");
3279 CaptureStderr();
3280 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3282}
3283
3284TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3285 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003286 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003287 io_delegate_.SetFileContents("old/p/Foo.aidl",
3288 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003289 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003290 " int A;"
3291 "}");
3292 io_delegate_.SetFileContents("new/p/Foo.aidl",
3293 "package p;"
3294 "parcelable Foo {"
3295 " int A;"
3296 "}");
3297 CaptureStderr();
3298 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3299 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3300}
3301
Daniel Norman85aed542019-08-21 12:01:14 -07003302TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003303 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003304 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3305 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003306 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003307 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003308 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003310}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003311
Daniel Norman85aed542019-08-21 12:01:14 -07003312TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003313 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003314 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3315 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003316 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003317 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003318 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003319}
Jiyong Parka428d212018-08-29 22:26:30 +09003320
Daniel Norman85aed542019-08-21 12:01:14 -07003321TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003322 const string expected_stderr =
3323 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003324 io_delegate_.SetFileContents("old/p/I.aidl",
3325 "package p; interface I {"
3326 "const int A = 1; const int B = 2;}");
3327 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003328 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003329 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003330 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003331}
Jiyong Parka428d212018-08-29 22:26:30 +09003332
Daniel Norman85aed542019-08-21 12:01:14 -07003333TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003334 const string expected_stderr =
3335 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003336 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3337 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003338 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003339 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003341}
3342
Devin Moorec7e47a32020-08-07 10:55:25 -07003343TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3344 const string expected_stderr =
3345 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3346 "This is an incompatible change for FixedSize types.\n";
3347 io_delegate_.SetFileContents("old/p/Foo.aidl",
3348 "package p; @FixedSize parcelable Foo { int A = 1; }");
3349 io_delegate_.SetFileContents("new/p/Foo.aidl",
3350 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3351 CaptureStderr();
3352 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3353 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3354}
3355
Jeongik Cha68d18e72021-04-29 20:07:01 +09003356TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3357 const string expected_stderr =
3358 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3359 "android.net.UidRangeParcel is changed from 1 to 2. "
3360 "But it is forbidden because of legacy support.\n";
3361 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3362 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3363 io_delegate_.SetFileContents(
3364 "new/android/net/UidRangeParcel.aidl",
3365 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3366 CaptureStderr();
3367 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3368 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3369}
3370
Devin Moorec7e47a32020-08-07 10:55:25 -07003371TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3372 const string expected_stderr =
3373 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3374 io_delegate_.SetFileContents("old/p/Foo.aidl",
3375 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3376 io_delegate_.SetFileContents("new/p/Foo.aidl",
3377 "package p; @FixedSize parcelable Foo { int A = 1; }");
3378 CaptureStderr();
3379 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3381}
3382
3383TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3384 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003385 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003386 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003387 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3388 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003389 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003390 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003391 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003392 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003393 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003394 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3395 "f.\n"
3396 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3397 "nullable1.\n"
3398 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3399 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003400
3401 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003402 "@FixedSize parcelable Foo {\n"
3403 " int[] a;\n"
3404 " Bar b;\n"
3405 " String c;\n"
3406 " ParcelFileDescriptor d;\n"
3407 " IBinder e;\n"
3408 " List<String> f;\n"
3409 " int isFixedSize;\n"
3410 " @nullable OtherFixed nullable1;\n"
3411 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003412 "}");
3413 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003414 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003415 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003416
3417 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003418 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003419 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3420}
3421
3422TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3423 const string expected_stderr = "";
3424
3425 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3426 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3427 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003428 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003429
3430 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003431 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003432 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3433}
3434
Jiyong Park8c380532018-08-30 14:55:26 +09003435TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003436 const string expected_stderr =
3437 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3438 "dir1/q/IBar.aidl\n"
3439 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003440 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003441 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3442 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3443 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3444 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3445
Devin Moore097a3ab2020-03-11 16:08:44 -07003446 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003447 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003448 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003449}
3450
Jiyong Parked65bf42018-08-28 15:43:27 +09003451TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003452 const string expected_stderr =
3453 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3454 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003455 Options options = Options::From("aidl --checkapi old new");
3456 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3457 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003458
3459 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3460
Jiyong Parke59c3682018-09-11 23:10:25 +09003461 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003462 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003463 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003464 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003465}
3466
Jooyung Han652ce482021-02-26 12:40:35 +09003467TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3468 Options options =
3469 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003470
3471 // use without import
3472 io_delegate_.SetFileContents("p/IFoo.aidl",
3473 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003474 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003475
3476 // capture output files
3477 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003478
Devin Moore7b8d5c92020-03-17 14:14:08 -07003479 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003480 io_delegate_.SetFileContents(
3481 "p/IFoo.aidl",
3482 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003483 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003484 // output files should be the same
3485 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003486
3487 // use with import (as before)
3488 io_delegate_.SetFileContents("p/IFoo.aidl",
3489 "package p;"
3490 "import android.os.ParcelFileDescriptor;"
3491 "interface IFoo{"
3492 " void foo(in ParcelFileDescriptor fd);"
3493 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003494 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003495 // output files should be the same
3496 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003497}
Jiyong Parked65bf42018-08-28 15:43:27 +09003498
Jooyung Han020d8d12021-02-26 17:23:02 +09003499TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3500 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3501 CaptureStderr();
3502 io_delegate_.SetFileContents("p/IFoo.aidl",
3503 "package p;"
3504 "interface IFoo{"
3505 " void foo(out ParcelFileDescriptor fd);"
3506 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003507 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003508 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3509}
3510
3511TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3512 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3513 CaptureStderr();
3514 io_delegate_.SetFileContents("p/IFoo.aidl",
3515 "package p;"
3516 "interface IFoo{"
3517 " void foo(ParcelFileDescriptor fd);"
3518 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003519 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003520 EXPECT_THAT(GetCapturedStderr(),
3521 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3522}
3523
Jiyong Park3633b722019-04-11 15:38:26 +09003524TEST_F(AidlTest, ManualIds) {
3525 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3526 io_delegate_.SetFileContents("IFoo.aidl",
3527 "interface IFoo {\n"
3528 " void foo() = 0;\n"
3529 " void bar() = 1;\n"
3530 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003531 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003532}
3533
3534TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3535 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3536 io_delegate_.SetFileContents("IFoo.aidl",
3537 "interface IFoo {\n"
3538 " void foo() = 0;\n"
3539 " void bar() = 1;\n"
3540 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003541 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003542}
3543
3544TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003545 const string expected_stderr =
3546 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003547 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3548 io_delegate_.SetFileContents("IFoo.aidl",
3549 "interface IFoo {\n"
3550 " void foo() = 3;\n"
3551 " void bar() = 3;\n"
3552 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003553 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003554 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003555 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003556}
3557
3558TEST_F(AidlTest, FailOnOutOfRangeIds) {
3559 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003560 const string expected_stderr =
3561 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3562 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003563 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3564 io_delegate_.SetFileContents("IFoo.aidl",
3565 "interface IFoo {\n"
3566 " void foo() = 3;\n"
3567 " void bar() = 16777115;\n"
3568 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003569 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003570 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003571 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003572}
3573
3574TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003575 const string expected_stderr =
3576 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003577 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3578 io_delegate_.SetFileContents("IFoo.aidl",
3579 "interface IFoo {\n"
3580 " void foo() = 3;\n"
3581 " void bar();\n"
3582 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003583 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003584 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003585 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003586}
3587
Jiyong Parkc6816252019-07-08 08:12:28 +09003588TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3589 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3590 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3591 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003592 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003593}
3594
3595TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003596 const string expected_stderr =
3597 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3598 "dir/IBar.aidl\n"
3599 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003600 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003601
Jiyong Parkc6816252019-07-08 08:12:28 +09003602 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3603 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3604 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3605 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003606 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003607 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003608 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003609}
3610
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003611TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3612 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3613 "package a.b;\n"
3614 "import a.b.IBar;\n"
3615 "import a.b.IQux;\n"
3616 "interface IFoo { IQux foo(); }\n");
3617 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3618 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3619
3620 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003621 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003622
3623 string output;
3624 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3625 // IBar was imported but wasn't used. include is not expected.
3626 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3627 // IBar was imported and used. include is expected.
3628 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3629}
3630
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003631TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003632 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003633 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003634 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3635 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003636 interface IFoo {
3637 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003638 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003639 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003640 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003641 // JavaPassthrough should work with other types as well (e.g. enum)
3642 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3643 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3644 @JavaPassthrough(annotation="@com.android.AliceTwo")
3645 @Backing(type="byte")
3646 enum MyEnum {
3647 a, b, c
3648 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003649
Jooyung Han4cde01d2020-10-13 11:10:47 +09003650 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003651 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003652
3653 string java_out;
3654 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003655 // type-decl-level annotations with newline at the end
3656 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3657 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3658 // member-decl-level annotations with newline at the end
3659 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3660 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3661 // inline annotations with space at the end
3662 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003663
Jooyung Han4cde01d2020-10-13 11:10:47 +09003664 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3665 // type-decl-level annotations with newline at the end
3666 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3667 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3668
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003669 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003670 Options cpp_options =
3671 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003672 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003673
Jooyung Han4cde01d2020-10-13 11:10:47 +09003674 Options ndk_options =
3675 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003676 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003677
Jooyung Han4cde01d2020-10-13 11:10:47 +09003678 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003679 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003680}
3681
Andrei Homescue61feb52020-08-18 15:44:24 -07003682TEST_F(AidlTest, ParseRustDerive) {
3683 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3684 @RustDerive(Clone=true, Copy=false)
3685 parcelable Foo {
3686 int a;
3687 })");
3688
3689 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003690 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003691
3692 string rust_out;
3693 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3694 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3695
3696 // Other backends shouldn't be bothered
3697 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003698 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003699
3700 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003701 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003702
3703 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003704 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003705}
3706
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003707TEST_F(AidlTest, EmptyEnforceAnnotation) {
3708 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3709 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3710 interface IFoo {
3711 @Enforce()
3712 void Protected();
3713 })");
3714
3715 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3716 CaptureStderr();
3717 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3718 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3719}
3720
3721TEST_F(AidlTest, EmptyEnforceCondition) {
3722 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3723 interface IFoo {
3724 @Enforce(condition="")
3725 void Protected();
3726 })");
3727
3728 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3729 CaptureStderr();
3730 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3731 EXPECT_THAT(GetCapturedStderr(),
3732 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3733}
3734
3735TEST_F(AidlTest, InvalidEnforceCondition) {
3736 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3737 interface IFoo {
3738 @Enforce(condition="invalid")
3739 void Protected();
3740 })");
3741
3742 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3743 CaptureStderr();
3744 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3745 EXPECT_THAT(GetCapturedStderr(),
3746 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3747}
3748
Jiyong Park56f73d72019-06-11 12:20:28 +09003749class AidlOutputPathTest : public AidlTest {
3750 protected:
3751 void SetUp() override {
3752 AidlTest::SetUp();
3753 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3754 }
3755
3756 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003757 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003758 // check the existence
3759 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3760 }
3761};
3762
3763TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3764 // <out_dir> / <package_name> / <type_name>.java
3765 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3766}
3767
3768TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3769 // when output file is explicitly set, it is always respected. -o option is
3770 // ignored.
3771 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3772}
3773
3774TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3775 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3776}
3777
3778TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3779 // output is the same as the input file except for the suffix
3780 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3781}
3782
Devin Moore7b8d5c92020-03-17 14:14:08 -07003783TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003784 AidlError error;
3785 const string expected_stderr =
3786 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3787 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003788 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3789 R"(package p;
3790 interface IFoo {
3791 const int int32_max_oob = 2147483650;
3792 }
3793 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003794 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003795 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3796 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003797}
3798
Devin Moore7b8d5c92020-03-17 14:14:08 -07003799TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003800 AidlError error;
3801 const string expected_stderr =
3802 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3803 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003804 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3805 R"(package p;
3806 interface IFoo {
3807 const int int32_min_oob = -2147483650;
3808 }
3809 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003810 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003811 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3812 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003813}
3814
Devin Moore7b8d5c92020-03-17 14:14:08 -07003815TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003816 AidlError error;
3817 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003818 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003819 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003820 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3821 R"(package p;
3822 interface IFoo {
3823 const long int64_max_oob = 21474836509999999999999999;
3824 }
3825 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003826 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003827 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3828 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003829}
3830
Devin Moore7b8d5c92020-03-17 14:14:08 -07003831TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003832 AidlError error;
3833 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003834 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003835 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003836 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3837 R"(package p;
3838 interface IFoo {
3839 const long int64_min_oob = -21474836509999999999999999;
3840 }
3841 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003842 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003843 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3844 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003845}
3846
Devin Moore7b8d5c92020-03-17 14:14:08 -07003847TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003848 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003849 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003850 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003851 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3852 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003853 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3854 R"(package p;
3855 @Backing(type="byte")
3856 enum TestEnum {
3857 FOO = 127,
3858 BAR,
3859 }
3860 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003861 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003862 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003863 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003864}
3865
Steven Morelandb248d072021-09-29 19:07:17 -07003866TEST_P(AidlTest, FailOnUnsupportedBackingType) {
3867 AidlError error;
3868 const string expected_stderr =
3869 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
3870 "byte, int, long\n";
3871 CaptureStderr();
3872 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3873 R"(package p;
3874 @Backing(type="boolean")
3875 enum TestEnum {
3876 FOO = 0,
3877 BAR = 1,
3878 }
3879 )",
3880 typenames_, GetLanguage(), &error));
3881 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3882 EXPECT_EQ(AidlError::BAD_TYPE, error);
3883}
3884
Devin Mooredecaf292020-04-30 09:16:40 -07003885TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3886 AidlError error;
3887 const string expected_stderr =
3888 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003889 "be one of: type\n";
3890 CaptureStderr();
3891 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3892 R"(package p;
3893 @Backing(foo="byte")
3894 enum TestEnum {
3895 FOO = 1,
3896 BAR,
3897 }
3898 )",
3899 typenames_, GetLanguage(), &error));
3900 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3901 EXPECT_EQ(AidlError::BAD_TYPE, error);
3902}
3903
Jooyung Han5721a232020-12-24 04:34:55 +09003904TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3905 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3906 CaptureStderr();
3907 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3908 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3909}
3910
Jooyung Han66813932020-10-23 13:24:44 +09003911TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003912 io_delegate_.SetFileContents("Foo.aidl",
3913 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3914 "Map<String, Baz> d; Bar[] e; }");
3915 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3916 io_delegate_.SetFileContents("Baz.aidl",
3917 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003918 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003919 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003920}
3921
Jooyung Han66813932020-10-23 13:24:44 +09003922TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003923 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003924 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003925 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003926 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3927 "named 'bar'.\n";
3928 CaptureStderr();
3929 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003930 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003931 EXPECT_EQ(expected_error, GetCapturedStderr());
3932}
3933
Jooyung Han09e551c2021-05-11 11:44:48 +09003934TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3935 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3936 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3937 CaptureStderr();
3938 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003939 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003940 EXPECT_EQ("", GetCapturedStderr());
3941}
3942
Jooyung Han59af9cc2020-10-25 21:44:14 +09003943TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3944 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3945 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3946 string expected_error =
3947 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003948 "named 'bar'.\n";
3949 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003950 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003951 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003952 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003953}
3954
Jooyung Han66813932020-10-23 13:24:44 +09003955TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003956 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003957 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3958 string expected_error =
3959 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3960 "only be an in parameter.\n";
3961 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003962 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003963 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003964 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003965}
3966
Jooyung Han66813932020-10-23 13:24:44 +09003967TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003968 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003969 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3970 string expected_error =
3971 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3972 "only be an in parameter.\n";
3973 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003974 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003975 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003976 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003977}
3978
Jooyung Han66813932020-10-23 13:24:44 +09003979TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003980 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003981 Options options = Options::From("aidl --lang=java Foo.aidl");
3982 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003983 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3984 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003985 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003986 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3988}
Devin Moore53fc99c2020-08-12 08:07:52 -07003989
Jooyung Hanfe086af2021-01-16 03:44:47 +09003990TEST_P(AidlTest, UnionInUnion) {
3991 import_paths_.insert(".");
3992 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3993 CaptureStderr();
3994 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3995 EXPECT_THAT("", GetCapturedStderr());
3996}
3997
Jooyung Hanfe89f122020-10-14 03:49:18 +09003998TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3999 const string method = "package a; union Foo {}";
4000 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
4001 CaptureStderr();
4002 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4003 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4004}
4005
4006TEST_P(AidlTest, UnionRejectsParcelableHolder) {
4007 const string method = "package a; union Foo { ParcelableHolder x; }";
4008 const string expected_stderr =
4009 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
4010 CaptureStderr();
4011 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4012 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4013}
4014
Jooyung Han53fb4242020-12-17 16:03:49 +09004015TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
4016 import_paths_.insert(".");
4017 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
4018 const string expected_err = "The union's first member should have a useful default value.";
4019 CaptureStderr();
4020 EXPECT_EQ(nullptr,
4021 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
4022 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
4023}
4024
Devin Moore53fc99c2020-08-12 08:07:52 -07004025TEST_P(AidlTest, GenericStructuredParcelable) {
4026 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004027 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004028 const string expected_stderr = "";
4029 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004030 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004031 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4032}
4033
Jooyung Han3f347ca2020-12-01 12:41:50 +09004034TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4035 io_delegate_.SetFileContents("Foo.aidl",
4036 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4037 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004038 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004039 const string expected_stderr = "";
4040 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004041 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4043
4044 string code;
4045 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4046 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4047const ::android::String16& Foo<T,U>::s() {
4048 static const ::android::String16 value(::android::String16(""));
4049 return value;
4050})--"));
4051}
4052
4053TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4054 io_delegate_.SetFileContents("Foo.aidl",
4055 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4056 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004057 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004058 const string expected_stderr = "";
4059 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004060 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004061 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4062
4063 string code;
4064 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4065 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4066const char* Foo<T, U>::s = "";
4067)--"));
4068}
4069
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004070TEST_F(AidlTest, NestedTypeArgs) {
4071 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004072 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4073
4074 io_delegate_.SetFileContents("a/Foo.aidl",
4075 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4076 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004077 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4078 const string expected_stderr = "";
4079 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004080 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004081 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4082
4083 string code;
4084 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004085 EXPECT_THAT(code,
4086 testing::HasSubstr(
4087 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4088}
4089
4090TEST_F(AidlTest, DoubleArrayError) {
4091 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4092
4093 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4094 const string expected_stderr =
4095 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4096 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004097 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004098 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4099}
4100
4101TEST_F(AidlTest, DoubleGenericError) {
4102 io_delegate_.SetFileContents("a/Bar.aidl",
4103 "package a; parcelable Bar { List<String><String> a; }");
4104
4105 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4106 const string expected_stderr =
4107 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4108 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004109 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4111}
4112
4113TEST_F(AidlTest, ArrayBeforeGenericError) {
4114 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4115
4116 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004117 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004118 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004119 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4120}
4121
4122TEST_F(AidlTest, NullableArraysAreNotSupported) {
4123 io_delegate_.SetFileContents("a/Bar.aidl",
4124 "package a; parcelable Bar { String @nullable [] a; }");
4125
4126 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4127 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004128 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004129 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4130}
4131
4132TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4133 io_delegate_.SetFileContents("a/Bar.aidl",
4134 "package a; parcelable Bar { List<@nullable String> a; }");
4135
4136 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4137 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004138 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004139 EXPECT_THAT(GetCapturedStderr(),
4140 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004141}
4142
Jooyung Han14004ed2020-10-16 03:49:57 +09004143struct GenericAidlTest : ::testing::Test {
4144 FakeIoDelegate io_delegate_;
4145 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004146 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004147 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4148 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4149 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4150
4151 Options options = Options::From(cmd);
4152 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004153 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004154 EXPECT_EQ("", GetCapturedStderr());
4155 }
4156};
4157
4158TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4159 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4160 string code;
4161 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4162 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4163 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4164 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4165}
4166
4167TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4168 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4169 string code;
4170 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4171 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4172 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4173 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4174}
4175
Devin Moore53fc99c2020-08-12 08:07:52 -07004176TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4177 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004178 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004179 const string expected_stderr =
4180 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4181 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004182 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004183 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4184}
4185
4186TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4187 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004188 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004189 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4190 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004191 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4193}
4194
Jooyung Han7a308842020-10-27 19:06:49 +09004195TEST_P(AidlTest, LongCommentWithinConstExpression) {
4196 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004197 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004198 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004199 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004200 EXPECT_EQ("", GetCapturedStderr());
4201}
4202
Jeongik Chaef44e622020-10-23 16:00:52 +09004203TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4204 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4205 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4206 std::string expectedErr =
4207 "ERROR: a/Foo.aidl:1.28-30: "
4208 "Encountered an untyped List or Map. The use of untyped List/Map is "
4209 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4210 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4211 "ERROR: a/Foo.aidl:1.35-37: "
4212 "Encountered an untyped List or Map. The use of untyped List/Map is "
4213 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4214 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4215 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004216 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004217 EXPECT_EQ(expectedErr, GetCapturedStderr());
4218}
4219
4220TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004221 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4222 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004223 std::string expectedErr =
4224 "ERROR: a/Foo.aidl:1.33-35: "
4225 "Encountered an untyped List or Map. The use of untyped List/Map is "
4226 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4227 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4228 "ERROR: a/Foo.aidl:1.40-42: "
4229 "Encountered an untyped List or Map. The use of untyped List/Map is "
4230 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4231 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004232 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004233 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004234 EXPECT_EQ(expectedErr, GetCapturedStderr());
4235}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004236
Jeongik Chaef44e622020-10-23 16:00:52 +09004237TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4238 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4239 io_delegate_.SetFileContents(
4240 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4241 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4242 std::string expectedErr =
4243 "ERROR: a/Foo.aidl:1.52-54: "
4244 "Encountered an untyped List or Map. The use of untyped List/Map is "
4245 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4246 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4247 "ERROR: a/Foo.aidl:1.64-66: "
4248 "Encountered an untyped List or Map. The use of untyped List/Map is "
4249 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4250 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4251 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004252 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004253 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004254}
4255
Jooyung Han690f5842020-12-04 13:02:04 +09004256TEST_F(AidlTest, EnumWithDefaults_Java) {
4257 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4258 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4259package p;
4260import p.Enum;
4261parcelable Foo {
4262 Enum e = Enum.BAR;
4263})");
4264 CaptureStderr();
4265 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004266 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004267 auto err = GetCapturedStderr();
4268 EXPECT_EQ("", err);
4269
4270 string code;
4271 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004272 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004273}
4274
4275TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4276 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4277 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4278package p;
4279import p.Enum;
4280parcelable Foo {
4281 Enum e = Enum.BAR;
4282})");
4283 CaptureStderr();
4284 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004285 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004286 auto err = GetCapturedStderr();
4287 EXPECT_EQ("", err);
4288
4289 string code;
4290 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4291 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4292}
4293
4294TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4295 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4296 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4297package p;
4298import p.Enum;
4299parcelable Foo {
4300 Enum e = Enum.BAR;
4301})");
4302 CaptureStderr();
4303 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004304 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004305 auto err = GetCapturedStderr();
4306 EXPECT_EQ("", err);
4307
4308 string code;
4309 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4310 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4311}
4312
4313TEST_F(AidlTest, EnumWithDefaults_Rust) {
4314 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4315 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4316package p;
4317import p.Enum;
4318parcelable Foo {
4319 int n = 42;
4320 Enum e = Enum.BAR;
4321})");
4322 CaptureStderr();
4323 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004324 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004325 auto err = GetCapturedStderr();
4326 EXPECT_EQ("", err);
4327
4328 string code;
4329 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4330 EXPECT_THAT(code, testing::HasSubstr(R"(
4331 fn default() -> Self {
4332 Self {
4333 n: 42,
4334 e: crate::mangled::_1_p_4_Enum::BAR,
4335 }
4336 })"));
4337}
4338
4339TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4340 import_paths_.insert("a");
4341 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4342 CaptureStderr();
4343 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4344package p;
4345import p.Enum;
4346parcelable Foo {
4347 int e = Enum.FOO | Enum.BAR;
4348})",
4349 typenames_, GetLanguage());
4350 auto err = GetCapturedStderr();
4351 EXPECT_EQ("", err);
4352 EXPECT_TRUE(type);
4353 const auto& fields = type->AsStructuredParcelable()->GetFields();
4354 EXPECT_EQ("int e = 3", fields[0]->ToString());
4355}
4356
4357TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4358 CaptureStderr();
4359 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4360@Backing(type="int")
4361enum Foo {
4362 STANDARD_SHIFT = 16,
4363 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4364 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4365}
4366)",
4367 typenames_, GetLanguage());
4368 auto err = GetCapturedStderr();
4369 EXPECT_EQ("", err);
4370 EXPECT_TRUE(type);
4371 const auto& enum_type = type->AsEnumDeclaration();
4372 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004373 auto writer = CodeWriter::ForString(&code);
4374 DumpVisitor visitor(*writer);
4375 visitor.Visit(*enum_type);
4376 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004377 EXPECT_EQ(R"--(@Backing(type="int")
4378enum Foo {
4379 STANDARD_SHIFT = 16,
4380 STANDARD_BT709 = 65536,
4381 STANDARD_BT601_625 = 131072,
4382}
4383)--",
4384 code);
4385}
4386
4387TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4388 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4389 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4390package p;
4391import p.Enum;
4392parcelable Foo {
4393 Enum e = Enum.FOO | Enum.BAR;
4394})");
4395 CaptureStderr();
4396 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004397 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004398 auto err = GetCapturedStderr();
4399 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4400 err);
4401}
4402
Jooyung Han361cd102021-05-24 11:30:10 +09004403TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4404 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4405 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4406package p;
4407import p.Enum;
4408parcelable Foo {
4409 Enum e = 1;
4410})");
4411 CaptureStderr();
4412 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004413 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004414 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4415}
4416
Jooyung Han690f5842020-12-04 13:02:04 +09004417TEST_P(AidlTest, DefaultWithEmptyArray) {
4418 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4419 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4420 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004421 auto options =
4422 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004423 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004424 auto err = GetCapturedStderr();
4425 EXPECT_EQ("", err);
4426}
4427
4428TEST_P(AidlTest, RejectRefsInAnnotation) {
4429 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4430 "package p; interface IFoo {\n"
4431 " const String ANNOTATION = \"@Annotation\";\n"
4432 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4433 "}");
4434 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004435 auto options =
4436 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004437 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004438 auto err = GetCapturedStderr();
4439 EXPECT_EQ(
4440 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4441 "ANNOTATION.\n",
4442 err);
4443}
4444
4445TEST_F(AidlTest, DefaultWithEnumValues) {
4446 io_delegate_.SetFileContents(
4447 "a/p/Foo.aidl",
4448 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4449 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4450 CaptureStderr();
4451 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004452 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004453 auto err = GetCapturedStderr();
4454 EXPECT_EQ("", err);
4455 string code;
4456 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4457 EXPECT_THAT(
4458 code, testing::HasSubstr(
4459 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4460}
4461
Jooyung Han14259392020-12-07 10:00:08 +09004462TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4463 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4464 CaptureStderr();
4465 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004466 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004467 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004468 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004469}
4470
4471TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4472 io_delegate_.SetFileContents("a/p/Foo.aidl",
4473 "package p; parcelable Foo { const int A = A + 1; }");
4474 CaptureStderr();
4475 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004476 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004477 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004478 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4479}
4480
4481TEST_F(AidlTest, RecursiveReferences) {
4482 io_delegate_.SetFileContents("a/p/Foo.aidl",
4483 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4484 io_delegate_.SetFileContents("a/p/Bar.aidl",
4485 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4486 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4487 CaptureStderr();
4488 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004489 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004490 EXPECT_EQ("", GetCapturedStderr());
4491}
4492
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004493TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4494 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4495 auto options =
4496 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4497 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004499 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004500 EXPECT_EQ(err, GetCapturedStderr());
4501}
4502
4503TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4504 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4505 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4506 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4507 auto options =
4508 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4509 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004510 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004511 EXPECT_EQ("", GetCapturedStderr());
4512}
4513
Jooyung Hane9f5b272021-01-07 00:18:11 +09004514TEST_P(AidlTest, UnknownConstReference) {
4515 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4516 auto options =
4517 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4518 const string err =
4519 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4520 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4521 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4522 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004523 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004524 EXPECT_EQ(err, GetCapturedStderr());
4525}
4526
Jooyung Han29813842020-12-08 01:28:03 +09004527TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4528 string contents = R"(
4529import android.os.IBinder;
4530import android.os.IInterface;
4531interface IFoo {}
4532 )";
4533 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004534}
4535
Jooyung Han888c5bc2020-12-22 17:28:47 +09004536TEST_P(AidlTest, WarningInterfaceName) {
4537 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004538 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004539 " -Weverything -o out -h out p/Foo.aidl");
4540 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004541 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004542 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004543 GetCapturedStderr());
4544}
4545
4546TEST_P(AidlTest, ErrorInterfaceName) {
4547 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004548 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004549 " -Weverything -Werror -o out -h out p/Foo.aidl");
4550 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004551 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004552 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004553 GetCapturedStderr());
4554}
4555
Jiyong Park9f4c3822021-04-07 20:36:45 +09004556TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4557 const std::string input_file = "base/p/q/IFoo.aidl";
4558 const std::string header_dir = "out/";
4559 const std::string output_file = "out/base/p/q/IFoo.cpp";
4560 const std::string package = "p.q"; // not base.p.q
4561 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4562
4563 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4564 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004565 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004566 EXPECT_THAT(
4567 GetCapturedStderr(),
4568 testing::StartsWith(
4569 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4570 "but is out/base/p/q/IFoo.cpp."));
4571}
4572
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004573TEST_F(AidlTest, FormatCommentsForJava) {
4574 using android::aidl::FormatCommentsForJava;
4575
4576 struct TestCase {
4577 vector<Comment> comments;
4578 string formatted;
4579 };
4580 vector<TestCase> testcases = {
4581 {{}, ""},
4582 {{{"// line comments\n"}}, "// line comments\n"},
4583 {{{"// @hide \n"}}, "// @hide \n"},
4584 // Transform the last block comment as Javadoc.
4585 {{{"/*\n"
4586 " * Hello, world!\n"
4587 " */"}},
4588 "/**\n"
4589 " * Hello, world!\n"
4590 " */"},
4591 {{{"/* @hide */"}}, "/** @hide */"},
4592 {{{"/**\n"
4593 " @param foo ...\n"
4594 "*/"}},
4595 "/**\n"
4596 " @param foo ...\n"
4597 "*/"},
4598 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4599 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4600 "/* @deprecated first *//** @deprecated second */"},
4601 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4602 // Line comments are printed as they are
4603 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4604 };
4605 for (const auto& [input, formatted] : testcases) {
4606 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4607 }
4608}
4609
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004610TEST_F(AidlTest, HideIsNotForArgs) {
4611 io_delegate_.SetFileContents("IFoo.aidl",
4612 "interface IFoo {\n"
4613 " void foo(in @Hide int x);\n"
4614 "}");
4615 auto options = Options::From("aidl --lang=java IFoo.aidl");
4616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004617 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004618 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4619}
4620
4621TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4622 io_delegate_.SetFileContents(
4623 "IFoo.aidl",
4624 "interface IFoo {\n"
4625 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4626 "}");
4627 auto options = Options::From("aidl --lang=java IFoo.aidl");
4628 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004629 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004630 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4631}
4632
Jooyung Hanfa181932021-06-12 07:56:53 +09004633TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4634 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4635 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4636 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004637 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004638 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4639}
4640
Jooyung Hanfd3be322020-12-13 09:11:06 +09004641struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004642 string kind;
4643 string literal;
4644};
4645
Jooyung Hanfd3be322020-12-13 09:11:06 +09004646const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004647 {"primitive", "int"}, {"primitiveArray", "int[]"},
4648 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004649 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4650 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4651 {"union", "a.Union"}, {"interface", "a.IBar"},
4652};
4653
4654const std::map<std::string, std::string> kListSupportExpectations = {
4655 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4656 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4657 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4658 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004659 {"cpp_primitiveArray", "List of arrays is not supported."},
4660 {"java_primitiveArray", "List of arrays is not supported."},
4661 {"ndk_primitiveArray", "List of arrays is not supported."},
4662 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004663 {"cpp_String", ""},
4664 {"java_String", ""},
4665 {"ndk_String", ""},
4666 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004667 {"cpp_StringArray", "List of arrays is not supported."},
4668 {"java_StringArray", "List of arrays is not supported."},
4669 {"ndk_StringArray", "List of arrays is not supported."},
4670 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004671 {"cpp_IBinder", ""},
4672 {"java_IBinder", ""},
4673 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4674 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004675 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004676 {"java_ParcelFileDescriptor", ""},
4677 {"ndk_ParcelFileDescriptor", ""},
4678 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004679 {"cpp_interface", "List<a.IBar> is not supported."},
4680 {"java_interface", "List<a.IBar> is not supported."},
4681 {"ndk_interface", "List<a.IBar> is not supported."},
4682 {"rust_interface", "List<a.IBar> is not supported."},
4683 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004684 {"java_parcelable", ""},
4685 {"ndk_parcelable", ""},
4686 {"rust_parcelable", ""},
4687 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4688 {"java_enum", "A generic type cannot have any primitive type parameters."},
4689 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4690 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004691 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004692 {"java_union", ""},
4693 {"ndk_union", ""},
4694 {"rust_union", ""},
4695};
4696
Jooyung Hand236e552020-12-13 09:21:27 +09004697const std::map<std::string, std::string> kArraySupportExpectations = {
4698 {"cpp_primitive", ""},
4699 {"java_primitive", ""},
4700 {"ndk_primitive", ""},
4701 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004702 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4703 {"java_primitiveArray", "Can only have one dimensional arrays."},
4704 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4705 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004706 {"cpp_String", ""},
4707 {"java_String", ""},
4708 {"ndk_String", ""},
4709 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004710 {"cpp_StringArray", "Can only have one dimensional arrays."},
4711 {"java_StringArray", "Can only have one dimensional arrays."},
4712 {"ndk_StringArray", "Can only have one dimensional arrays."},
4713 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004714 {"cpp_IBinder", ""},
4715 {"java_IBinder", ""},
4716 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4717 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4718 {"cpp_ParcelFileDescriptor", ""},
4719 {"java_ParcelFileDescriptor", ""},
4720 {"ndk_ParcelFileDescriptor", ""},
4721 {"rust_ParcelFileDescriptor", ""},
4722 {"cpp_interface", "Binder type cannot be an array"},
4723 {"java_interface", "Binder type cannot be an array"},
4724 {"ndk_interface", "Binder type cannot be an array"},
4725 {"rust_interface", "Binder type cannot be an array"},
4726 {"cpp_parcelable", ""},
4727 {"java_parcelable", ""},
4728 {"ndk_parcelable", ""},
4729 {"rust_parcelable", ""},
4730 {"cpp_enum", ""},
4731 {"java_enum", ""},
4732 {"ndk_enum", ""},
4733 {"rust_enum", ""},
4734 {"cpp_union", ""},
4735 {"java_union", ""},
4736 {"ndk_union", ""},
4737 {"rust_union", ""},
4738};
4739
Jooyung Hanfd3be322020-12-13 09:11:06 +09004740class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004741 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004742 void Run(const std::string& generic_type_decl,
4743 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004744 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004745 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004746 const auto& kind = std::get<1>(param).kind;
4747
4748 FakeIoDelegate io;
4749 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4750 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4751 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004752 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4753 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004754
4755 const auto options =
4756 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4757 CaptureStderr();
4758 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004759 auto it = expectations.find(lang + "_" + kind);
4760 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004761 const string err = GetCapturedStderr();
4762 if (it->second.empty()) {
4763 EXPECT_EQ("", err);
4764 } else {
4765 EXPECT_THAT(err, testing::HasSubstr(it->second));
4766 }
4767 }
4768};
4769
4770INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004771 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004772 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4773 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004774 testing::ValuesIn(kTypeParams)),
4775 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004776 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004777 });
4778
Jooyung Hanfd3be322020-12-13 09:11:06 +09004779TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4780 Run("List<{}>", kListSupportExpectations);
4781}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004782
Jooyung Hand236e552020-12-13 09:21:27 +09004783TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4784 Run("{}[]", kArraySupportExpectations);
4785}
4786
Christopher Wiley90be4e32015-10-20 14:55:25 -07004787} // namespace aidl
4788} // namespace android