commit 23cc5fa0238d6846147e768c2a382c654e3b3332
author Steven Moreland <smoreland@google.com> Wed May 09 10:48:48 2018 -0700
committer Steven Moreland <smoreland@google.com> Wed May 16 23:02:08 2018 +0000
tree c5f43618e4b208b7cbcf571ea698bd61754b306f
parent 700922209f17b67949950de9e96847e9e5f95e02

Fix HIDL output errata.

Some missing newlines and redundant comments.

Bug: N/A
Test: manually inspecting output
Change-Id: Ic8bd6f44ce32b04378d92c1b5d558c7b3a9433a8

Interface.cpp

diff --git a/Interface.cpp b/Interface.cpp
index 6c5c764..9e53e1f 100644
--- a/Interface.cpp
+++ b/Interface.cpp
@@ -141,7 +141,7 @@
             {
                 {IMPL_INTERFACE,
                     [](auto &out) {
-                        out << "return true;";
+                        out << "return true;\n";
                     }
                 },
                 {IMPL_PROXY,
@@ -180,7 +180,7 @@
                                     << "_hidl_mDeathRecipients.erase(it);\n"
                                     << "return status == ::android::OK;\n";
                                 });
-                            });
+                            }).endl();
                         out << "}\n";
                         out << "return false;\n";
                     }
@@ -212,10 +212,10 @@
             HIDL_SYSPROPS_CHANGED_TRANSACTION,
             { { IMPL_INTERFACE, [](auto &out) {
                 out << "::android::report_sysprop_change();\n";
-                out << "return ::android::hardware::Void();";
+                out << "return ::android::hardware::Void();\n";
             } } }, /*cppImpl */
             { { IMPL_INTERFACE, [](auto &out) { /* javaImpl */
-                out << "android.os.HwBinder.enableInstrumentation();";
+                out << "android.os.HwBinder.enableInstrumentation();\n";
             } } } /*javaImpl */
     );
     return true;
@@ -281,7 +281,7 @@
                     out << ",\n";
                 out << chain[i]->fullJavaName() << ".kInterfaceName";
             }
-            out << "));";
+            out << "));\n";
             out.unindent(); out.unindent();
         } } } /* javaImpl */
     );
@@ -353,7 +353,7 @@
             out << "_hidl_cb("
                 << fullName()
                 << "::descriptor);\n"
-                << "return ::android::hardware::Void();";
+                << "return ::android::hardware::Void();\n";
         } } }, /* cppImpl */
         { { IMPL_INTERFACE, [this](auto &out) {
             out << "return "
@@ -385,7 +385,7 @@
                     out << "_hidl_cb({ -1 /* pid */, 0 /* ptr */, \n"
                         << sArch
                         << "});\n"
-                        << "return ::android::hardware::Void();";
+                        << "return ::android::hardware::Void();\n";
                 }
             },
             {IMPL_STUB_IMPL,
@@ -398,7 +398,7 @@
                             << sArch << "\n";
                     });
                     out << ");\n"
-                        << "return ::android::hardware::Void();";
+                        << "return ::android::hardware::Void();\n";
                 }
             }
         }, /* cppImpl */
@@ -409,7 +409,7 @@
                 << "info.pid = android.os.HidlSupport.getPidIfSharable();\n"
                 << "info.ptr = 0;\n"
                 << "info.arch = android.hidl.base.V1_0.DebugInfo.Architecture.UNKNOWN;\n"
-                << "return info;";
+                << "return info;\n";
         } } } /* javaImpl */
     );
 
@@ -428,7 +428,7 @@
                 [](auto &out) {
                     out << "(void)fd;\n"
                         << "(void)options;\n"
-                        << "return ::android::hardware::Void();";
+                        << "return ::android::hardware::Void();\n";
                 }
             },
         }, /* cppImpl */