commit 28b9b537a4941ac9e4ef2e25e64e3ffc4b833676
author Steven Moreland <smoreland@google.com> Fri May 12 17:02:58 2017 -0700
committer Steven Moreland <smoreland@google.com> Fri May 12 17:02:58 2017 -0700
tree aacd842946d3500054a59c85dd59a93bb69c77b8
parent 97e5233c9934d2793fa633c8ffe12ba624e49fb0

Prevent AST from modifying Coordinator.

With additional methods in Coordinator which are non-const, we
should prevent this from happening.

Test: manual
Change-Id: I067840164f847a59239e3c2f0e19a62a4575d704

Coordinator.cpp

diff --git a/Coordinator.cpp b/Coordinator.cpp
index 8223326..1ec0554 100644
--- a/Coordinator.cpp
+++ b/Coordinator.cpp
@@ -63,7 +63,7 @@
     }
 }
 
-AST *Coordinator::parse(const FQName &fqName, std::set<AST *> *parsedASTs, bool enforce) {
+AST *Coordinator::parse(const FQName &fqName, std::set<AST *> *parsedASTs, bool enforce) const {
     CHECK(fqName.isFullyQualified());
 
     auto it = mCache.find(fqName);
@@ -375,7 +375,7 @@
 }
 
 
-status_t Coordinator::enforceRestrictionsOnPackage(const FQName &fqName) {
+status_t Coordinator::enforceRestrictionsOnPackage(const FQName &fqName) const {
     // need fqName to be something like android.hardware.foo@1.0.
     // name and valueName is ignored.
     if (fqName.package().empty() || fqName.version().empty()) {
@@ -407,7 +407,7 @@
     return OK;
 }
 
-status_t Coordinator::enforceMinorVersionUprevs(const FQName &currentPackage) {
+status_t Coordinator::enforceMinorVersionUprevs(const FQName &currentPackage) const {
     if(!currentPackage.hasVersion()) {
         LOG(ERROR) << "Cannot enforce minor version uprevs for " << currentPackage.string()
                    << ": missing version.";
@@ -510,7 +510,7 @@
     return OK;
 }
 
-status_t Coordinator::enforceHashes(const FQName &currentPackage) {
+status_t Coordinator::enforceHashes(const FQName &currentPackage) const {
     status_t err = OK;
     std::vector<FQName> packageInterfaces;
     err = appendPackageInterfacesToVector(currentPackage, &packageInterfaces);