Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / hidl / 3effa83f93e1fcd4fe2b714b97fb461dfeda8af7
commit3effa83f93e1fcd4fe2b714b97fb461dfeda8af7[log] [tgz]
authorSteven Moreland <smoreland@google.com>Fri Jun 16 16:17:41 2017 -0700
committerSteven Moreland <smoreland@google.com>Mon Jun 19 20:07:09 2017 +0000
tree6b08b6e7927d57f2734969d102248b606aa331d6
parent214f4aef99a80adc7fbccab8587164b294c3d95b [diff]
Error message for incorrect FQNames.

Given this FQName in a file:
@2.1::IComposerClient::Command

Which should be:
@2.1::IComposerClient.Command

The lexer reads in FQName objects. Before, the lexer was parsing
the following tokens:
'@2.1::IComposerClient' ':' ':' 'Command'
as
Interface FQName, invalid character, invalid character, identifier

Before:
ERROR: Invalid enum storage type specified. at ...

Now we get this error message (with only one token):
ERROR: FQName '@2.1::IComposerClient::Command' is not valid at ...

We do this by having the lexer accept a superset of valid FQNames which
FQName itself later can't parse.

- also added better error for enum invalid type errors
- also added error when hidl-gen is invoked with no fqnames

Test: check all interfaces with hidl-gen
Fixes: 62721248
Change-Id: I7f27d60a2026f026315e426febba9483d468e29a
3 files changed
tree: 6b08b6e7927d57f2734969d102248b606aa331d6
  1. c2hal/
  2. include_hash/
  3. test/
  4. utils/
  5. .clang-format
  6. Android.bp
  7. Annotation.cpp
  8. Annotation.h
  9. ArrayType.cpp
  10. ArrayType.h
  11. AST.cpp
  12. AST.h
  13. CompoundType.cpp
  14. CompoundType.h
  15. ConstantExpression.cpp
  16. ConstantExpression.h
  17. Coordinator.cpp
  18. Coordinator.h
  19. DeathRecipientType.cpp
  20. DeathRecipientType.h
  21. EnumType.cpp
  22. EnumType.h
  23. FmqType.cpp
  24. FmqType.h
  25. generateCpp.cpp
  26. generateCppImpl.cpp
  27. generateJava.cpp
  28. generateVts.cpp
  29. HandleType.cpp
  30. HandleType.h
  31. Hash.cpp
  32. hidl-gen_l.ll
  33. hidl-gen_y.yy
  34. HidlTypeAssertion.cpp
  35. HidlTypeAssertion.h
  36. Interface.cpp
  37. Interface.h
  38. Location.h
  39. main.cpp
  40. MemoryType.cpp
  41. MemoryType.h
  42. Method.cpp
  43. Method.h
  44. MODULE_LICENSE_APACHE2
  45. NamedType.cpp
  46. NamedType.h
  47. NOTICE
  48. OWNERS
  49. PointerType.cpp
  50. PointerType.h
  51. PREUPLOAD.cfg
  52. README.md
  53. RefType.cpp
  54. RefType.h
  55. ScalarType.cpp
  56. ScalarType.h
  57. Scope.cpp
  58. Scope.h
  59. StringType.cpp
  60. StringType.h
  61. Type.cpp
  62. Type.h
  63. TypeDef.cpp
  64. TypeDef.h
  65. update-all-google-makefiles.sh
  66. update-makefiles-helper.sh
  67. VectorType.cpp
  68. VectorType.h
README.md

hidl-gen user guide

1. Build

croot
make hidl-gen

2. Run

hidl-gen -o output-path -L language (-r interface-root) fqname

output-path: directory to store the output files.
language: output file for given language. e.g.c++, vts..

fqname: fully qualified name of the input files.
For singe file input, follow the format: package@version::fileName
For directory input, follow the format: package@version

interface-root(optional): prefix and root path for fqname.
If not set, use the default prefix: android.hardware and default root path
defined in $TOP.

examples:

croot
hidl-gen -o output -L c++ -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0::INfc.hal
hidl-gen -o output -L vts -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0
hidl-gen -o test -L c++ -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0