commit 42394ce58336d22a98370a0be12738b8cce8d9ae
author Steven Moreland <smoreland@google.com> Mon Mar 27 17:03:04 2017 -0700
committer Steven Moreland <smoreland@google.com> Tue Mar 28 00:22:43 2017 +0000
tree 6b011e0e874ba8ff53af4e9a9ad5cf9f647421b7
parent 937408abc412733f46ba59e2342496b465e8c312

getService: break on null hwservicemanager

Test: hidl_test
Test: internal marlin boots and works, verified lshal
Bug: 36611652
Change-Id: Ia307e0e6f43ccbb19ccb249e85969cd095a5c545

generateCpp.cpp

diff --git a/generateCpp.cpp b/generateCpp.cpp
index 178b705..3a1a200 100644
--- a/generateCpp.cpp
+++ b/generateCpp.cpp
@@ -225,10 +225,10 @@
             });
 
             out.sIf("!ret.isOk()", [&] {
-                // hwservicemanager fails
+                // hwservicemanager fails, may be security issue
                 out << "ALOGE(\"getService: defaultServiceManager()->get returns %s\", "
                     << "ret.description().c_str());\n"
-                    << "continue;\n";
+                    << "break;\n";
             }).endl();
 
             out << "iface = " << interfaceName << "::castFrom(ret);\n";