Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / hidl / 579b0f60f798ad89c1b7ffb8a6389a3311b313f4
commit579b0f60f798ad89c1b7ffb8a6389a3311b313f4[log] [tgz]
authorSteven Moreland <smoreland@google.com>Thu Oct 25 13:40:47 2018 -0700
committerSteven Moreland <smoreland@google.com>Thu Oct 25 13:47:56 2018 -0700
tree22f1e76bedb068f5b0a18d8daa37c80dfc6a13ec
parent9b37ed1d66c8a1ce15042177a9e261843037ee60 [diff]
safe_union: fix up default initialization.

This error was introduced when hidl_no_init was removed.

Before, Objecct hidl_o only got declared if a default Java initializer
was defined for this type. Now, this field is declared, and then the
default java value is set in the constructor.

This also means that primitive values must be manually initialized (or
they result in a NullPointerException). This is intentional, and we do
it for the same reason the Java wrapper classes don't have a default
value (so we don't initialize an extra object to a useless value).

In the future, we're still able to change this (it isn't part of any
ABI). One optimization to be made here is that we can add an extra
field to the safe union like "long hidl_o_primitive" which stores the
value of the fields if it is a primitive to avoid an object creation.
This would also mean at that point that primitives won't require an
additional object instantiation.

Bug: N/A
Test: hidl_test, hidl_test_java, manually inspect safe_union output.
Change-Id: I2317f7b72819de5132944ecc9c723203123fc55d
1 file changed
tree: 22f1e76bedb068f5b0a18d8daa37c80dfc6a13ec
  1. build/
  2. c2hal/
  3. docs/
  4. hashing/
  5. host_utils/
  6. scripts/
  7. test/
  8. utils/
  9. .clang-format
  10. Android.bp
  11. Annotation.cpp
  12. Annotation.h
  13. ArrayType.cpp
  14. ArrayType.h
  15. AST.cpp
  16. AST.h
  17. CleanSpec.mk
  18. CompoundType.cpp
  19. CompoundType.h
  20. ConstantExpression.cpp
  21. ConstantExpression.h
  22. Coordinator.cpp
  23. Coordinator.h
  24. DeathRecipientType.cpp
  25. DeathRecipientType.h
  26. DocComment.cpp
  27. DocComment.h
  28. EnumType.cpp
  29. EnumType.h
  30. FmqType.cpp
  31. FmqType.h
  32. generateCpp.cpp
  33. generateCppAdapter.cpp
  34. generateCppImpl.cpp
  35. generateDependencies.cpp
  36. generateJava.cpp
  37. generateVts.cpp
  38. HandleType.cpp
  39. HandleType.h
  40. hidl-gen_l.h
  41. hidl-gen_l.ll
  42. hidl-gen_y.yy
  43. HidlTypeAssertion.cpp
  44. HidlTypeAssertion.h
  45. Interface.cpp
  46. Interface.h
  47. Location.cpp
  48. Location.h
  49. main.cpp
  50. MemoryType.cpp
  51. MemoryType.h
  52. Method.cpp
  53. Method.h
  54. MODULE_LICENSE_APACHE2
  55. NamedType.cpp
  56. NamedType.h
  57. NOTICE
  58. OWNERS
  59. PointerType.cpp
  60. PointerType.h
  61. PREUPLOAD.cfg
  62. README.md
  63. Reference.h
  64. RefType.cpp
  65. RefType.h
  66. ScalarType.cpp
  67. ScalarType.h
  68. Scope.cpp
  69. Scope.h
  70. StringType.cpp
  71. StringType.h
  72. Type.cpp
  73. Type.h
  74. TypeDef.cpp
  75. TypeDef.h
  76. update-all-google-makefiles.sh
  77. update-makefiles-helper.sh
  78. VectorType.cpp
  79. VectorType.h
README.md

hidl-gen

Full documentation can be found here: https://source.android.com/devices/architecture/hidl/

hidl-gen is a compiler for the HIDL (HAL Interface Design Language) which generates C++ and Java endpoints for RPC mechanisms. The main userspace libraries which this compiler uses can be found at system/libhidl.

1. Build

m hidl-gen

2. Run

Note that options for hidl-gen expected to be invoked by the build system are marked with 'internal' in the help menu.

hidl-gen -h

hidl-gen -o output -L c++-impl -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0

Some defaults for package roots are also provided

hidl-gen -o output -L c++-impl android.hardware.nfc@1.0
hidl-gen -o output -L vts android.hardware.nfc@1.0
hidl-gen -L hash android.hardware.nfc@1.0

Example command for vendor project

hidl-gen -L c++-impl -r vendor.foo:vendor/foo/interfaces vendor.foo.nfc@1.0

See update-makefiles-helper.sh and update-all-google-makefiles.sh for examples of how to generate HIDL makefiles (using the -Landroidbp option).

c2hal

This is a helper tool to convert C headers to valid .hal files.

m c2hal && c2hal -h

docs

This tool generates html documentation for hal interfaces.

m hidl-doc && hidl-doc -h