commit 6081863ce80ff231323a54e97072a17227a56820
author Steven Moreland <smoreland@google.com> Sat Feb 04 00:33:42 2017 -0800
committer Yifan Hong <elsk@google.com> Mon Feb 06 18:33:08 2017 +0000
tree 3b2e8b014dcbb63df4d753b9714d193d6f4311c0
parent 8adcb651a25c5faefb5e75166c453962a0189e1b

Add -Werror.

Also, fixed several warnings (including one bug in generateCppImpl.cpp).

Test: compiles

Bug: 32559427

Change-Id: I78375b9052c0ad447ebac638258f25bbf562712f

Android.bp

diff --git a/Android.bp b/Android.bp
index e7a0cfe..6db4821 100644
--- a/Android.bp
+++ b/Android.bp
@@ -18,16 +18,20 @@
     "utils",
 ]
 
+hidl_flags = [
+    "-O0",
+    "-g",
+    "-Wall",
+    "-Werror",
+]
+
 //
 // libhidl-gen
 //
 cc_library_shared {
     name: "libhidl-gen",
     host_supported: true,
-    cflags: [
-        "-O0",
-        "-g",
-    ],
+    cflags: hidl_flags,
     srcs: [
         "Annotation.cpp",
         "ArrayType.cpp",
@@ -63,10 +67,7 @@
 
 cc_library_host_shared {
     name: "libhidl-gen-ast",
-    cflags: [
-        "-O0",
-        "-g",
-    ],
+    cflags: hidl_flags,
     srcs: [
         "Coordinator.cpp",
         "generateCpp.cpp",
@@ -77,7 +78,6 @@
         "hidl-gen_l.ll",
         "AST.cpp",
     ],
-
     shared_libs: [
         "libbase",
         "liblog",
@@ -91,8 +91,8 @@
 //
 cc_binary_host {
     name: "hidl-gen",
+    cflags: hidl_flags,
     srcs: ["main.cpp"],
-
     shared_libs: [
         "libbase",
         "liblog",
@@ -100,9 +100,4 @@
         "libhidl-gen-ast",
         "libhidl-gen-utils",
     ],
-
-    cflags: [
-        "-O0",
-        "-g",
-    ],
 }