commit 70a59e1dc3dcf32f791d2dd7966111d4adf32eca
author Andreas Huber <andih@google.com> Tue Aug 16 12:57:01 2016 -0700
committer Andreas Huber <andih@google.com> Tue Aug 16 13:02:13 2016 -0700
tree 72dc0677ff37d23f4a7ec6290c03c6f9ffbd2aa2
parent c7dfef3fda2061dcaeeb144c10eef3cf7360b03c

Validate upfront that an interface is compatible with our Java backend,

emit diagnostics if it is not. Also cleans up all other error messages to
clearly indicate an error condition.

Bug: 30876839
Change-Id: I18bcd723107ab93abcad38c976f3c38dda60a743

hidl-gen_y.yy

diff --git a/hidl-gen_y.yy b/hidl-gen_y.yy
index d6f03d0..f9d1d93 100644
--- a/hidl-gen_y.yy
+++ b/hidl-gen_y.yy
@@ -241,13 +241,14 @@
     : opt_annotations INTERFACE IDENTIFIER opt_extends
       {
           if ($4 != NULL && !$4->isInterface()) {
-              fprintf(stderr, "You can only extend interfaces.\n");
+              fprintf(stderr, "ERROR: You can only extend interfaces.\n");
               YYERROR;
           }
 
           if ($3[0] != 'I') {
               fprintf(stderr,
-                      "All interface names must start with an 'I' prefix.\n");
+                      "ERROR: All interface names must start with an 'I' "
+                      "prefix.\n");
 
               YYERROR;
           }
@@ -429,7 +430,7 @@
           $$ = $2;
 
           if ($$ != NULL && !$$->isValidEnumStorageType()) {
-              fprintf(stderr, "Invalid enum storage type specified.\n");
+              fprintf(stderr, "ERROR: Invalid enum storage type specified.\n");
               YYABORT;
           }
       }
@@ -505,7 +506,9 @@
     | fqname '[' INTEGER ']'
       {
           if ($1->isInterface()) {
-              fprintf(stderr, "Arrays of interface types are not supported.");
+              fprintf(stderr,
+                      "ERROR: Arrays of interface types are not supported.");
+
               YYERROR;
           }
 
@@ -514,7 +517,9 @@
     | VEC '<' fqname '>'
       {
           if ($3->isInterface()) {
-              fprintf(stderr, "Vectors of interface types are not supported.");
+              fprintf(stderr,
+                      "ERROR: Vectors of interface types are not supported.");
+
               YYERROR;
           }