Remove ref<>.
This type is unused and some parts of it has bitrot. In order to reduce
the complexity of new features, removing this.
Fixes: 131616631
Test: ./test/run_all_device_tests.sh
Test: ./test/run_all_host_tests.sh
Change-Id: I319f3ed937a113cd7abba430401b4fb9dd69c651
diff --git a/generateCpp.cpp b/generateCpp.cpp
index c6de972..b160a11 100644
--- a/generateCpp.cpp
+++ b/generateCpp.cpp
@@ -985,23 +985,6 @@
mode);
}
-void AST::emitCppResolveReferences(Formatter& out, const std::string& parcelObj,
- bool parcelObjIsPointer, const NamedReference<Type>* arg,
- bool isReader, Type::ErrorMode mode,
- bool addPrefixToName) const {
- const Type &type = arg->type();
- if(type.needsResolveReferences()) {
- type.emitResolveReferences(
- out,
- addPrefixToName ? ("_hidl_out_" + arg->name()) : arg->name(),
- isReader, // nameIsPointer
- parcelObj,
- parcelObjIsPointer,
- isReader,
- mode);
- }
-}
-
void AST::generateProxyMethodSource(Formatter& out, const std::string& klassName,
const Method* method, const Interface* superInterface) const {
method->generateCppSignature(out,
@@ -1108,7 +1091,7 @@
out << "if (_hidl_err != ::android::OK) { goto _hidl_error; }\n\n";
bool hasInterfaceArgument = false;
- // First DFS: write all buffers and resolve pointers for parent
+
for (const auto &arg : method->args()) {
if (arg->type().isInterface()) {
hasInterfaceArgument = true;
@@ -1123,18 +1106,6 @@
false /* addPrefixToName */);
}
- // Second DFS: resolve references.
- for (const auto &arg : method->args()) {
- emitCppResolveReferences(
- out,
- "_hidl_data",
- false /* parcelObjIsPointer */,
- arg,
- false /* reader */,
- Type::ErrorMode_Goto,
- false /* addPrefixToName */);
- }
-
if (hasInterfaceArgument) {
// Start binder threadpool to handle incoming transactions
out << "::android::hardware::ProcessState::self()->startThreadPool();\n";
@@ -1178,7 +1149,6 @@
out << "if (!_hidl_status.isOk()) { return _hidl_status; }\n\n";
}
- // First DFS: write all buffers and resolve pointers for parent
for (const auto &arg : method->results()) {
emitCppReaderWriter(
out,
@@ -1190,18 +1160,6 @@
true /* addPrefixToName */);
}
- // Second DFS: resolve references.
- for (const auto &arg : method->results()) {
- emitCppResolveReferences(
- out,
- "_hidl_reply",
- false /* parcelObjIsPointer */,
- arg,
- true /* reader */,
- errorMode,
- true /* addPrefixToName */);
- }
-
if (returnsValue && elidedReturn == nullptr) {
out << "_hidl_cb(";
@@ -1520,7 +1478,6 @@
declareCppReaderLocals(out, method->args(), false /* forResults */);
- // First DFS: write buffers
for (const auto &arg : method->args()) {
emitCppReaderWriter(
out,
@@ -1532,18 +1489,6 @@
false /* addPrefixToName */);
}
- // Second DFS: resolve references
- for (const auto &arg : method->args()) {
- emitCppResolveReferences(
- out,
- "_hidl_data",
- false /* parcelObjIsPointer */,
- arg,
- true /* reader */,
- Type::ErrorMode_Return,
- false /* addPrefixToName */);
- }
-
generateCppInstrumentationCall(
out,
InstrumentationEvent::SERVER_API_ENTRY,
@@ -1589,15 +1534,6 @@
false, /* isReader */
Type::ErrorMode_Ignore);
- emitCppResolveReferences(
- out,
- "_hidl_reply",
- true /* parcelObjIsPointer */,
- elidedReturn,
- false /* reader */,
- Type::ErrorMode_Ignore,
- true /* addPrefixToName */);
-
generateCppInstrumentationCall(
out,
InstrumentationEvent::SERVER_API_EXIT,
@@ -1646,7 +1582,6 @@
out << "::android::hardware::writeToParcel(::android::hardware::Status::ok(), "
<< "_hidl_reply);\n\n";
- // First DFS: buffers
for (const auto &arg : method->results()) {
emitCppReaderWriter(
out,
@@ -1658,18 +1593,6 @@
true /* addPrefixToName */);
}
- // Second DFS: resolve references
- for (const auto &arg : method->results()) {
- emitCppResolveReferences(
- out,
- "_hidl_reply",
- true /* parcelObjIsPointer */,
- arg,
- false /* reader */,
- Type::ErrorMode_Ignore,
- true /* addPrefixToName */);
- }
-
generateCppInstrumentationCall(
out,
InstrumentationEvent::SERVER_API_EXIT,