Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / tools / hidl / 8c90cc59bf93bd0c08970b4488067a33015d4a1c
commit8c90cc59bf93bd0c08970b4488067a33015d4a1c[log] [tgz]
authorChih-Hung Hsieh <chh@google.com>Thu Aug 03 14:51:13 2017 -0700
committerChih-Hung Hsieh <chh@google.com>Tue Aug 15 15:14:47 2017 -0700
treeb05288aaaa1a49d116f9743db3429fb600c075b4
parente9ccfa2e9c177ead2b6ccb36dd20de294666abcd [diff]
Fix clang-tidy performance warnings in system/tools/hidl.

* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.

Bug: 30407689
Bug: 30411878
Test: build with WITH_TIDY=1
Change-Id: Ib90a35106eb59d05878b75504b87ef324211cc6b
19 files changed
tree: b05288aaaa1a49d116f9743db3429fb600c075b4
  1. c2hal/
  2. include_hash/
  3. test/
  4. utils/
  5. .clang-format
  6. Android.bp
  7. Annotation.cpp
  8. Annotation.h
  9. ArrayType.cpp
  10. ArrayType.h
  11. AST.cpp
  12. AST.h
  13. CompoundType.cpp
  14. CompoundType.h
  15. ConstantExpression.cpp
  16. ConstantExpression.h
  17. Coordinator.cpp
  18. Coordinator.h
  19. DeathRecipientType.cpp
  20. DeathRecipientType.h
  21. EnumType.cpp
  22. EnumType.h
  23. FmqType.cpp
  24. FmqType.h
  25. generateCpp.cpp
  26. generateCppImpl.cpp
  27. generateJava.cpp
  28. generateVts.cpp
  29. HandleType.cpp
  30. HandleType.h
  31. Hash.cpp
  32. hidl-gen_l.ll
  33. hidl-gen_y.yy
  34. HidlTypeAssertion.cpp
  35. HidlTypeAssertion.h
  36. Interface.cpp
  37. Interface.h
  38. Location.h
  39. main.cpp
  40. MemoryType.cpp
  41. MemoryType.h
  42. Method.cpp
  43. Method.h
  44. MODULE_LICENSE_APACHE2
  45. NamedType.cpp
  46. NamedType.h
  47. NOTICE
  48. OWNERS
  49. PointerType.cpp
  50. PointerType.h
  51. PREUPLOAD.cfg
  52. README.md
  53. Reference.h
  54. RefType.cpp
  55. RefType.h
  56. ScalarType.cpp
  57. ScalarType.h
  58. Scope.cpp
  59. Scope.h
  60. StringType.cpp
  61. StringType.h
  62. Type.cpp
  63. Type.h
  64. TypeDef.cpp
  65. TypeDef.h
  66. update-all-google-makefiles.sh
  67. update-makefiles-helper.sh
  68. VectorType.cpp
  69. VectorType.h
README.md

hidl-gen user guide

1. Build

croot
make hidl-gen

2. Run

hidl-gen -o output-path -L language (-r interface-root) fqname

output-path: directory to store the output files.
language: output file for given language. e.g.c++, vts..

fqname: fully qualified name of the input files.
For singe file input, follow the format: package@version::fileName
For directory input, follow the format: package@version

interface-root(optional): prefix and root path for fqname.
If not set, use the default prefix: android.hardware and default root path
defined in $TOP.

examples:

croot
hidl-gen -o output -L c++ -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0::INfc.hal
hidl-gen -o output -L vts -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0
hidl-gen -o test -L c++ -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0
hidl-gen -L hash -r android.hardware:hardware/interfaces -r android.hidl:system/libhidl/transport android.hardware.nfc@1.0