commit 8c90cc59bf93bd0c08970b4488067a33015d4a1c
author Chih-Hung Hsieh <chh@google.com> Thu Aug 03 14:51:13 2017 -0700
committer Chih-Hung Hsieh <chh@google.com> Tue Aug 15 15:14:47 2017 -0700
tree b05288aaaa1a49d116f9743db3429fb600c075b4
parent e9ccfa2e9c177ead2b6ccb36dd20de294666abcd

Fix clang-tidy performance warnings in system/tools/hidl.

* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.

Bug: 30407689
Bug: 30411878
Test: build with WITH_TIDY=1
Change-Id: Ib90a35106eb59d05878b75504b87ef324211cc6b

CompoundType.cpp

diff --git a/CompoundType.cpp b/CompoundType.cpp
index 146074e..c8d56b0 100644
--- a/CompoundType.cpp
+++ b/CompoundType.cpp
@@ -491,8 +491,7 @@
     return OK;
 }
 
-status_t CompoundType::emitTypeDefinitions(
-        Formatter &out, const std::string prefix) const {
+status_t CompoundType::emitTypeDefinitions(Formatter& out, const std::string& prefix) const {
     std::string space = prefix.empty() ? "" : (prefix + "::");
     status_t err = Scope::emitTypeDefinitions(out, space + localName());
 
@@ -871,8 +870,8 @@
     out << "}\n\n";
 }
 
-void CompoundType::emitResolveReferenceDef(
-        Formatter &out, const std::string prefix, bool isReader) const {
+void CompoundType::emitResolveReferenceDef(Formatter& out, const std::string& prefix,
+                                           bool isReader) const {
     out << "::android::status_t ";
     const std::string space(prefix.empty() ? "" : (prefix + "::"));