commit 8c90cc59bf93bd0c08970b4488067a33015d4a1c
author Chih-Hung Hsieh <chh@google.com> Thu Aug 03 14:51:13 2017 -0700
committer Chih-Hung Hsieh <chh@google.com> Tue Aug 15 15:14:47 2017 -0700
tree b05288aaaa1a49d116f9743db3429fb600c075b4
parent e9ccfa2e9c177ead2b6ccb36dd20de294666abcd

Fix clang-tidy performance warnings in system/tools/hidl.

* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.

Bug: 30407689
Bug: 30411878
Test: build with WITH_TIDY=1
Change-Id: Ib90a35106eb59d05878b75504b87ef324211cc6b

Scope.h

diff --git a/Scope.h b/Scope.h
index 14f51f9..63bfbfd 100644
--- a/Scope.h
+++ b/Scope.h
@@ -61,8 +61,7 @@
     status_t emitJavaTypeDeclarations(
             Formatter &out, bool atTopLevel) const override;
 
-    status_t emitTypeDefinitions(
-            Formatter &out, const std::string prefix) const override;
+    status_t emitTypeDefinitions(Formatter& out, const std::string& prefix) const override;
 
     const std::vector<NamedType *> &getSubTypes() const;
 
@@ -79,7 +78,7 @@
     std::map<std::string, size_t> mTypeIndexByName;
     std::vector<Annotation*> mAnnotations;
 
-    status_t forEachType(std::function<status_t(Type *)> func) const;
+    status_t forEachType(const std::function<status_t(Type*)>& func) const;
 
     DISALLOW_COPY_AND_ASSIGN(Scope);
 };